Re: [patch 1/2] libceph: fix error handling in handle_reply()

2013-08-15 Thread Sage Weil
Applied all 3 of these. Thanks, Dan! sage On Thu, 15 Aug 2013, Dan Carpenter wrote: We've tried to fix the error paths in this function before, but there is still a hidden goto in the ceph_decode_need() macro which goes to the wrong place. We need to release the req and unlock a mutex

[patch 1/2] libceph: fix error handling in handle_reply()

2013-08-14 Thread Dan Carpenter
We've tried to fix the error paths in this function before, but there is still a hidden goto in the ceph_decode_need() macro which goes to the wrong place. We need to release the req and unlock a mutex before returning. Signed-off-by: Dan Carpenter dan.carpen...@oracle.com diff --git