Re: Transaction struct Op

2015-07-03 Thread Matt W. Benjamin
I tend to support (++) - "Piotr Dałek" wrote: > > -Original Message- > > From: Haomai Wang [mailto:haomaiw...@gmail.com] > > Sent: Thursday, July 02, 2015 7:26 PM > > > > Yes, some fields only used for special ops. But union may increase > the > > complexity of stuct. > > Not by th

RE: Transaction struct Op

2015-07-02 Thread Dałek , Piotr
> -Original Message- > From: Haomai Wang [mailto:haomaiw...@gmail.com] > Sent: Thursday, July 02, 2015 7:26 PM > > Yes, some fields only used for special ops. But union may increase the > complexity of stuct. Not by that much, actual changes would be only in coding and encoding, rest of

Re: Transaction struct Op

2015-07-02 Thread Haomai Wang
Yes, some fields only used for special ops. But union may increase the complexity of stuct. And the extra memory may not a problem because "Ops" in one transaction should be within ten. On Thu, Jul 2, 2015 at 10:05 PM, Dałek, Piotr wrote: > Hello, > > In ObjectStore.h we have the following stuc

Transaction struct Op

2015-07-02 Thread Dałek , Piotr
Hello, In ObjectStore.h we have the following stuct: struct Op { __le32 op; __le32 cid; __le32 oid; __le64 off; __le64 len; __le32 dest_cid; __le32 dest_oid; //OP_CLONE, OP_CLONERANGE __le64 dest_off; //OP_CLONE