Re: osd/OSDMap.h: 330: FAILED assert(is_up(osd))

2012-07-18 Thread Jim Schutt
On 07/17/2012 06:03 PM, Samuel Just wrote: master should now have a fix for that, let me know how it goes. I opened bug #2798 for this issue. Hmmm, it seems handle_osd_ping() now runs into a case where for the first ping it gets, service.osdmap can be empty? 0 2012-07-18

Re: osd/OSDMap.h: 330: FAILED assert(is_up(osd))

2012-07-18 Thread Samuel Just
Sorry, master has a fix now for that also. 76efd9772c60b93bbf632e3ecc3b9117dc081427 -Sam On Wed, Jul 18, 2012 at 8:29 AM, Jim Schutt jasc...@sandia.gov wrote: On 07/17/2012 06:03 PM, Samuel Just wrote: master should now have a fix for that, let me know how it goes. I opened bug #2798 for

Re: osd/OSDMap.h: 330: FAILED assert(is_up(osd))

2012-07-18 Thread Jim Schutt
On 07/18/2012 12:03 PM, Samuel Just wrote: Sorry, master has a fix now for that also. 76efd9772c60b93bbf632e3ecc3b9117dc081427 -Sam That got things running for me. Thanks for the quick reply. -- Jim -- To unsubscribe from this list: send the line unsubscribe ceph-devel in the body of a

osd/OSDMap.h: 330: FAILED assert(is_up(osd))

2012-07-17 Thread Jim Schutt
Hi, Recent master branch is asserting for me like this: ceph version 0.48argonaut-404-gabe05a3 (commit:abe05a3fbbb120d8d354623258d9104584db66f7) 1: (OSDMap::get_cluster_inst(int) const+0xc9) [0x58cde9] 2: (OSD::handle_osd_ping(MOSDPing*)+0x8cf) [0x5d4b4f] 3:

Re: osd/OSDMap.h: 330: FAILED assert(is_up(osd))

2012-07-17 Thread Samuel Just
Not quite. OSDService::get_osdmap() returns the most recently published osdmap. Generally, OSD::osdmap is safe to use when you are holding the osd lock. Otherwise, OSDService::get_osdmap() should be used. There are a few other things that should be fixed surrounding this issue as well, I'll

Re: osd/OSDMap.h: 330: FAILED assert(is_up(osd))

2012-07-17 Thread Jim Schutt
On 07/17/2012 03:44 PM, Samuel Just wrote: Not quite. OSDService::get_osdmap() returns the most recently published osdmap. Generally, OSD::osdmap is safe to use when you are holding the osd lock. Otherwise, OSDService::get_osdmap() should be used. There are a few other things that should be

Re: osd/OSDMap.h: 330: FAILED assert(is_up(osd))

2012-07-17 Thread Samuel Just
master should now have a fix for that, let me know how it goes. I opened bug #2798 for this issue. Thanks for the info! -Sam On Tue, Jul 17, 2012 at 2:54 PM, Jim Schutt jasc...@sandia.gov wrote: On 07/17/2012 03:44 PM, Samuel Just wrote: Not quite. OSDService::get_osdmap() returns the most