Re: rbd: enforce parent overlap

2013-04-30 Thread Alex Elder
... -Alex The patch 64548e0638af: rbd: enforce parent overlap from Apr 21, 2013, leads to the following Smatch complaint: drivers/block/rbd.c:1449 rbd_osd_read_callback() error: we previously assumed 'img_request' could be null (see line 1448) drivers

Re: rbd: enforce parent overlap

2013-04-30 Thread Dan Carpenter
On Tue, Apr 30, 2013 at 06:57:14AM -0500, Alex Elder wrote: On 04/30/2013 02:24 AM, Dan Carpenter wrote: Hello Alex Elder, This is a semi-automatic email about new static checker warnings. Cool, I've never used smatch before. Great to get these automated warnings. I looked at this,

Re: [PATCH] rbd: enforce parent overlap

2013-04-22 Thread Josh Durgin
Alex Elder el...@inktank.com wrote: (This patch is available in branch review/wip-overlap of the ceph-client git repository.) A clone image has a defined overlap point with its parent image. That is the byte offset beyond which the parent image has no defined data to back the clone, and

Re: [PATCH] rbd: enforce parent overlap

2013-04-22 Thread Alex Elder
On 04/22/2013 01:34 PM, Josh Durgin wrote: Alex Elder el...@inktank.com wrote: (This patch is available in branch review/wip-overlap of the ceph-client git repository.) A clone image has a defined overlap point with its parent image. That is the byte offset beyond which the parent image

Re: [PATCH] rbd: enforce parent overlap

2013-04-22 Thread Josh Durgin
On 04/22/2013 12:33 PM, Alex Elder wrote: On 04/22/2013 01:34 PM, Josh Durgin wrote: Alex Elder el...@inktank.com wrote: (This patch is available in branch review/wip-overlap of the ceph-client git repository.) A clone image has a defined overlap point with its parent image. That is the

Re: [PATCH] rbd: enforce parent overlap

2013-04-22 Thread Alex Elder
On 04/22/2013 01:34 PM, Josh Durgin wrote: + * We need to zero anything beyond the parent overlap + * boundary. Since rbd_img_obj_request_read_callback() + * will zero anything beyond the end of a short read, an + * easy way to do this is to pretend the data from the + *

Re: [PATCH] rbd: enforce parent overlap

2013-04-22 Thread Josh Durgin
On 04/22/2013 01:43 PM, Alex Elder wrote: On 04/22/2013 01:34 PM, Josh Durgin wrote: + * We need to zero anything beyond the parent overlap + * boundary. Since rbd_img_obj_request_read_callback() + * will zero anything beyond the end of a short read, an + * easy way to do this

[PATCH] rbd: enforce parent overlap

2013-04-20 Thread Alex Elder
(This patch is available in branch review/wip-overlap of the ceph-client git repository.) A clone image has a defined overlap point with its parent image. That is the byte offset beyond which the parent image has no defined data to back the clone, and anything thereafter can be viewed as being