Re: [PATCH 0/5] block/scsi/lio support for COMPARE_AND_WRITE

2014-10-18 Thread Mike Christie
On 10/18/2014 03:11 AM, Bart Van Assche wrote: On 10/16/14 07:37, micha...@cs.wisc.edu wrote: The following patches implement the SCSI command COMPARE_AND_WRITE as a new bio/request type REQ_CMP_AND_WRITE. COMPARE_AND_WRITE is defined in the SCSI SBC (SCSI block command) specs as: The

Re: SOCK_MEMALLOC vs loopback

2015-03-04 Thread Mike Christie
On 03/04/2015 10:03 PM, Mike Christie wrote: On 03/04/2015 02:04 PM, Mel Gorman wrote: On Wed, Mar 04, 2015 at 09:38:48PM +0300, Ilya Dryomov wrote: Hello, A short while ago Mike added a patch to libceph to set SOCK_MEMALLOC on libceph sockets and PF_MEMALLOC around send/receive paths

Re: SOCK_MEMALLOC vs loopback

2015-03-04 Thread Mike Christie
On 03/04/2015 02:04 PM, Mel Gorman wrote: On Wed, Mar 04, 2015 at 09:38:48PM +0300, Ilya Dryomov wrote: Hello, A short while ago Mike added a patch to libceph to set SOCK_MEMALLOC on libceph sockets and PF_MEMALLOC around send/receive paths (commit 89baaa570ab0, libceph: use memalloc flags

Re: [PATCH 2/3] rbd: combine object method calls in header refresh using fewer ceph_msgs

2015-04-24 Thread Mike Christie
On 04/23/2015 02:06 PM, Douglas Fuller wrote: Signed-off-by: Douglas Fuller douglas.ful...@gmail.com --- drivers/block/rbd.c | 337 include/linux/ceph/osd_client.h | 2 +- 2 files changed, 312 insertions(+), 27 deletions(-) diff

Re: [PATCH 0/5] target/rbd: distributed lun reset support

2015-05-08 Thread Mike Christie
On 05/06/2015 01:48 AM, Christoph Hellwig wrote: As for the API: I would much prefer to have things at the block layer in some form than adding side band protocol for specific functionality. Ok. For what you need for your NFS cluster work, will you have a request_queue or block_device or

Re: [PATCH] libceph: don't set memalloc flags in loopback case

2015-04-03 Thread Mike Christie
On 04/02/2015 12:41 AM, Mel Gorman wrote: On Thu, Apr 02, 2015 at 02:40:19AM +0300, Ilya Dryomov wrote: On Thu, Apr 2, 2015 at 2:03 AM, Mel Gorman mgor...@suse.de wrote: On Wed, Apr 01, 2015 at 08:19:20PM +0300, Ilya Dryomov wrote: Following nbd and iscsi, commit 89baaa570ab0 (libceph:

Re: [PATCH] Revert libceph: use memalloc flags for net IO

2015-04-07 Thread Mike Christie
/msg23392.html Conflicts: net/ceph/messenger.c [ context: tcp_nodelay option ] Cc: Mike Christie micha...@cs.wisc.edu Cc: Mel Gorman mgor...@suse.de Cc: Sage Weil s...@redhat.com Cc: sta...@vger.kernel.org # 3.18+, needs backporting Signed-off-by: Ilya Dryomov idryo...@gmail.com Yeah

Re: [PATCHv2 5/6] osd_client: add support for notify payloads via notify event

2015-06-22 Thread Mike Christie
On 06/17/2015 09:25 AM, Douglas Fuller wrote: @@ -3055,12 +3151,33 @@ static struct ceph_msg *alloc_msg(struct ceph_connection *con, struct ceph_osd *osd = con-private; int type = le16_to_cpu(hdr-type); int front = le32_to_cpu(hdr-front_len); + struct ceph_msg *m;

Re: [PATCH 5/6] osd_client: add support for notify payloads via notify event

2015-06-16 Thread Mike Christie
On 06/12/2015 10:56 AM, Douglas Fuller wrote: @@ -2533,8 +2548,10 @@ static void handle_watch_notify(struct ceph_osd_client *osdc, if (msg-hdr.version = 2) ceph_decode_32_safe(p, end, return_code, bad); - if (msg-hdr.version = 3) + if (msg-hdr.version = 3) {

Re: [PATCHv2 5/6] osd_client: add support for notify payloads via notify event

2015-06-17 Thread Mike Christie
On 06/17/2015 09:25 AM, Douglas Fuller wrote: @@ -2486,6 +2579,7 @@ static void __do_event(struct ceph_osd_client *osdc, u8 opcode, case CEPH_WATCH_EVENT_NOTIFY_COMPLETE: if (event) { event-notify.notify_data = data; +

Re: [PATCH 17/18] target: add rbd backend

2015-07-29 Thread Mike Christie
On 07/29/2015 09:27 AM, Bart Van Assche wrote: On 07/29/15 02:23, mchri...@redhat.com wrote: +static sector_t tcm_rbd_get_blocks(struct se_device *dev) +{ +struct tcm_rbd_dev *tcm_rbd_dev = TCM_RBD_DEV(dev); +sector_t blocks_long = tcm_rbd_dev-rbd_dev-mapping.size +

Re: [PATCH 01/18] libceph: add scatterlist messenger data type

2015-07-29 Thread Mike Christie
On 07/29/2015 08:34 AM, Alex Elder wrote: On 07/29/2015 04:23 AM, mchri...@redhat.com wrote: From: Mike Christie micha...@cs.wisc.edu LIO uses scatterlist for its page/data management. This patch adds a scatterlist messenger data type, so LIO can pass its sg down directly to rbd. Signed

[PATCH 0/18] lio rbd support

2015-07-29 Thread Mike Christie
The following patches implement a LIO RBD backend. Instead of having LIO send bios/requests through the block layer and having rbd translate them to ceph/rados requests, this implements a LIO RBD backend module that translates LIO se_cmds directly to ceph/rados requests. This patchset also

Re: [RFC PATCH 0/5] rbd_tcm cluster COMPARE AND WRITE

2015-07-29 Thread Mike Christie
On 07/28/2015 08:15 PM, David Disseldorp wrote: Hi Mike, This RFC patch-set expands on your recently proposed cluster API changes to add rbd_tcm COMPARE AND WRITE support. Rather than offloading the entire COMPARE AND WRITE operation to the cluster back-end, these changes extend on the

Re: [PATCH 01/18] libceph: add scatterlist messenger data type

2015-07-29 Thread Mike Christie
On 07/29/2015 12:55 PM, Christoph Hellwig wrote: On Wed, Jul 29, 2015 at 04:23:38AM -0500, mchri...@redhat.com wrote: From: Mike Christie micha...@cs.wisc.edu LIO uses scatterlist for its page/data management. This patch adds a scatterlist messenger data type, so LIO can pass its sg down

Re: [PATCH] mark rbd requiring stable pages

2015-10-22 Thread Mike Christie
On 10/22/15, 11:52 AM, Ilya Dryomov wrote: On Thu, Oct 22, 2015 at 5:37 PM, Mike Christie <micha...@cs.wisc.edu> wrote: On 10/22/2015 06:20 AM, Ilya Dryomov wrote: If we are just talking about if stable pages are not used, and someone is re-writing data to a page after the page has a

Re: [PATCH] mark rbd requiring stable pages

2015-10-21 Thread Mike Christie
On 10/21/2015 03:57 PM, Ilya Dryomov wrote: > On Wed, Oct 21, 2015 at 10:51 PM, Ilya Dryomov wrote: >> On Fri, Oct 16, 2015 at 1:09 PM, Ilya Dryomov wrote: >>> Hmm... On the one hand, yes, we do compute CRCs, but that's optional, >>> so enabling this

Re: [PATCH] mark rbd requiring stable pages

2015-10-22 Thread Mike Christie
On 10/22/2015 06:20 AM, Ilya Dryomov wrote: > >> > >> > If we are just talking about if stable pages are not used, and someone >> > is re-writing data to a page after the page has already been submitted >> > to the block layer (I mean the page is on some bio which is on a request >> > which is on

Re: [PATCH 12/18] target: compare and write backend driver sense handling

2015-09-04 Thread Mike Christie
, sense_reason_t sense, u32 info) On 07/29/2015 04:23 AM, mchri...@redhat.com wrote: > From: Mike Christie <micha...@cs.wisc.edu> > > Currently, backend drivers seem to only fail IO with > SAM_STAT_CHECK_CONDITION which gets us > TCM_LOGICAL_UNIT_COMMUNICATION_F

Re: RBD Kernel: write_same_max_bytes and SCSI XCOPY

2015-12-09 Thread Mike Christie
On 12/09/2015 01:08 AM, Timofey Titovets wrote: > Hi list, > As i found write_same_max_bytes are equal to zero > if i understand correctly, it's means what RBD not support offloading > copy operations > Not yet. I did patches to support commands like write same and compare and write in this

Re: Issue with Ceph File System and LIO

2015-12-15 Thread Mike Christie
On 12/15/2015 12:08 AM, Eric Eastman wrote: > I am testing Linux Target SCSI, LIO, with a Ceph File System backstore > and I am seeing this error on my LIO gateway. I am using Ceph v9.2.0 > on a 4.4rc4 Kernel, on Trusty, using a kernel mounted Ceph File > System. A file on the Ceph File System

Re: Issue with Ceph File System and LIO

2015-12-18 Thread Mike Christie
Eric, Do you have iSCSI data digests on? On 12/15/2015 12:08 AM, Eric Eastman wrote: > I am testing Linux Target SCSI, LIO, with a Ceph File System backstore > and I am seeing this error on my LIO gateway. I am using Ceph v9.2.0 > on a 4.4rc4 Kernel, on Trusty, using a kernel mounted Ceph File