Re: misc: ignore some unusable block devices

2015-12-14 Thread Robin H. Johnson
On Mon, Dec 14, 2015 at 04:12:16PM +0100, Loic Dachary wrote:
> Hi Robin,
> 
> I removed misc: ignore some unusable block devices
> 9c5eaeccb807d103884f46d174798dd982092696 from the openstack branch
> because it fails on CentOS 7 with
> the following. Could you please make a new pull request with it so we
> can keep testing it there ?
Will do, but I wonder how you managed to get a return code of 2 from it;
as that should be device-does-not-exist.

-- 
Robin Hugh Johnson
Gentoo Linux: Developer, Infrastructure Lead, Foundation Trustee
E-Mail : robb...@gentoo.org
GnuPG FP   : 11ACBA4F 4778E3F6 E4EDF38E B27B944E 34884E85


signature.asc
Description: Digital signature


Re: misc: ignore some unusable block devices

2015-12-14 Thread Loic Dachary


On 14/12/2015 19:18, Robin H. Johnson wrote:
> On Mon, Dec 14, 2015 at 04:12:16PM +0100, Loic Dachary wrote:
>> Hi Robin,
>>
>> I removed misc: ignore some unusable block devices
>> 9c5eaeccb807d103884f46d174798dd982092696 from the openstack branch
>> because it fails on CentOS 7 with
>> the following. Could you please make a new pull request with it so we
>> can keep testing it there ?
> Will do, but I wonder how you managed to get a return code of 2 from it;
> as that should be device-does-not-exist.

IIRC that happens when blkid fails to retrieve information. I found blkid to be 
generally faster and less reliable than sgdisk -i 1 /dev/sdd for the purpose of 
getting partition information. For ceph-disk we chose reliability over speed. 
That being said I've not investigated the real reason why blkid returns -2.

Cheers

-- 
Loïc Dachary, Artisan Logiciel Libre



signature.asc
Description: OpenPGP digital signature