Re: [CF-metadata] [cf-convention/cf-conventions] Errors introduced in 276: Rendering of figure and i, j index order (#295)

2020-09-07 Thread Daniel Lee
Hi @lesserwhirls , that sounds awesome! I fully support migrating the Travis build into GitHub actions - let's move discussion of this into a separate issue I'll shard out of here. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on

Re: [CF-metadata] [cf-convention/cf-conventions] Errors introduced in 276: Rendering of figure and i, j index order (#295)

2020-09-04 Thread Sean Arms
> **Opportunity for improvement:** > > 1. First of all I find it a bit confusing to have builds on both Travis and > GitHub Actions. If we ever get the time it might be a good idea to refactor > this. This is especially important because the build process must be > maintained ATM in 2 places,

Re: [CF-metadata] [cf-convention/cf-conventions] Errors introduced in 276: Rendering of figure and i, j index order (#295)

2020-09-04 Thread Daniel Lee
# Analysis of build problem I'll also insert this into the issue description above. 1 of the problems here was the build process. I have fixed it and noted a further opportunity for improvement below. There are 2 build jobs that should have been uploading images next to the compiled docs, but

Re: [CF-metadata] [cf-convention/cf-conventions] Errors introduced in 276: Rendering of figure and i, j index order (#295)

2020-09-04 Thread Daniel Heydebreck
@erget Thanks for investigating -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/cf-convention/cf-conventions/issues/295#issuecomment-686987420 This list forwards relevant notifications from Github. It is

Re: [CF-metadata] [cf-convention/cf-conventions] Errors introduced in 276: Rendering of figure and i, j index order (#295)

2020-09-04 Thread Daniel Lee
Looks like this is correct, as the images make it into the PDF. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/cf-convention/cf-conventions/issues/295#issuecomment-686986151 This list forwards relevant

Re: [CF-metadata] [cf-convention/cf-conventions] Errors introduced in 276: Rendering of figure and i, j index order (#295)

2020-09-04 Thread Daniel Lee
Yes, I'm seeing that no figures are rendering, it looks like there's an issue with the assets as referenced. Investigating now... -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [CF-metadata] [cf-convention/cf-conventions] Errors introduced in 276: Rendering of figure and i, j index order (#295)

2020-09-03 Thread Daniel Heydebreck
The [other new figure](http://cfconventions.org/cf-conventions/cf-conventions.html#img-netCDF) also does not seem to render. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [CF-metadata] [cf-convention/cf-conventions] Errors introduced in 276: Rendering of figure and i, j index order (#295)

2020-09-03 Thread Daniel Lee
> @erget Do you know why the figure does not render correctly? Is it a wrong > file format? Haven't had time to investigate yet, but I can take a look tomorrow. > I will correct the order. Thanks! -- You are receiving this because you are subscribed to this thread. Reply to this email

Re: [CF-metadata] [cf-convention/cf-conventions] Errors introduced in 276: Rendering of figure and i, j index order (#295)

2020-09-03 Thread Daniel Heydebreck
@erget Do you know why the figure does not render correctly? Is it a wrong file format? > Furthermore, @AndersMS has noticed that the ordering in the text regarding > the order of indices i and j are reversed in the figure - this should be > harmonised as it was likely not intentional

[CF-metadata] [cf-convention/cf-conventions] Errors introduced in 276: Rendering of figure and i, j index order (#295)

2020-09-03 Thread Daniel Lee
# Title Errors introduced in 276: Rendering of figure and i, j index order # Moderator @user - I'm recruiting for this! # Requirement Summary The figure introduced in #276 [doesn't render correctly](http://cfconventions.org/cf-conventions/cf-conventions.html#cell-boundaries). Furthermore,