RE: Anyone care to review this image handling process?

2011-08-23 Thread Rick Faircloth
- From: Rick Faircloth [mailto:r...@whitestonemedia.com] Sent: 22 August 2011 03:50 To: cf-talk Subject: RE: Anyone care to review this image handling process? Hi, Kym, and thanks for the feedback. I will implement the suggestion to test isImage. That's good advice. Also, I like using a lot

Re: Anyone care to review this image handling process?

2011-08-21 Thread Peter Boughton
I'd raise four must-fix issues with that code. 1: You haven't var/local scoped any of these variables, despite being inside a function which is probably going to end up in a shared scope, so this code isn't thread-safe and thus can cause incorrect behaviour if two people upload images at the

RE: Anyone care to review this image handling process?

2011-08-21 Thread Rick Faircloth
it. Thanks for the feedback! Rick -Original Message- From: Justin Scott [mailto:leviat...@darktech.org] Sent: Saturday, August 20, 2011 3:34 PM To: cf-talk Subject: Re: Anyone care to review this image handling process? This is part of a component method for handling uploaded images that I've

Re: Anyone care to review this image handling process?

2011-08-21 Thread Casey Dougall
On Sun, Aug 21, 2011 at 10:18 AM, Rick Faircloth r...@whitestonemedia.comwrote: I do now have a line of code that deletes in the initially uploaded image from the tempImage folder after all processing on the image is complete. That gets rid of those 5MB photos clients upload just so I can

RE: Anyone care to review this image handling process?

2011-08-21 Thread Rick Faircloth
appreciate your feedback and that of others! Thanks, all! Rick -Original Message- From: Peter Boughton [mailto:bought...@gmail.com] Sent: Sunday, August 21, 2011 9:49 AM To: cf-talk Subject: Re: Anyone care to review this image handling process? I'd raise four must-fix issues

Re: Anyone care to review this image handling process?

2011-08-21 Thread Kym Kovan
feedback and that of others! Thanks, all! Rick -Original Message- From: Peter Boughton [mailto:bought...@gmail.com] Sent: Sunday, August 21, 2011 9:49 AM To: cf-talk Subject: Re: Anyone care to review this image handling process? I'd raise four must-fix issues with that code

RE: Anyone care to review this image handling process?

2011-08-21 Thread Rick Faircloth
that would make it harder to work with for me. Thanks, again! Rick -Original Message- From: Kym Kovan [mailto:dev-li...@mbcomms.net.au] Sent: Sunday, August 21, 2011 9:35 PM To: cf-talk Subject: Re: Anyone care to review this image handling process? Hi Rick, not knowing what is in the rest

RE: Anyone care to review this image handling process?

2011-08-21 Thread Jenny Gavin-Wear
[mailto:r...@whitestonemedia.com] Sent: 22 August 2011 03:50 To: cf-talk Subject: RE: Anyone care to review this image handling process? Hi, Kym, and thanks for the feedback. I will implement the suggestion to test isImage. That's good advice. Also, I like using a lot of variables, also

Anyone care to review this image handling process?

2011-08-20 Thread Rick Faircloth
This is part of a component method for handling uploaded images that I've recently revamped. Thoughts on this? cfif len(trim(arguments.staffPhoto)) cffile action = upload filefield = staffPhoto

Re: Anyone care to review this image handling process?

2011-08-20 Thread Justin Scott
This is part of a component method for handling uploaded images that I've recently revamped.  Thoughts on this? Is there anything specific you're concerned about with that code? It looks pretty straightforward, is uploading the image to a temp folder (presumably outside the webroot so that's