Re: [cfe-commits] r168260 - in /cfe/trunk: lib/Basic/Targets.cpp lib/CodeGen/CGExpr.cpp test/CodeGen/ppc-atomics.c

2012-11-18 Thread Benjamin Kramer
On 17.11.2012, at 18:30, Benjamin Kramer benny@googlemail.com wrote: Author: d0k Date: Sat Nov 17 11:30:55 2012 New Revision: 168260 URL: http://llvm.org/viewvc/llvm-project?rev=168260view=rev Log: Enable inlining of 4 byte atomic ops on ppc32, 8 byte atomic ops on ppc64. Also

[cfe-commits] [PATCH] RecursiveASTVisitor.h: Rework r160404, Eliminating the GCC_CAST hack, take two.

2012-11-18 Thread NAKAMURA Takumi
Hi doug.gregor, RecursiveASTVisitor.h: Rework Doug's r160404, Eliminating the GCC_CAST hack, take two. With this, ARCMT tests would not crash on certain hosts with g++ -O2, eg. cygwin g++-4.5.3. r160404 crashed mingw32-g++-4.4.0. I guess method's pointer in conditional expression could not

[cfe-commits] r168293 - /cfe/trunk/lib/Sema/SemaStmt.cpp

2012-11-18 Thread Dmitri Gribenko
Author: gribozavr Date: Sun Nov 18 16:28:42 2012 New Revision: 168293 URL: http://llvm.org/viewvc/llvm-project?rev=168293view=rev Log: Remove redundant (duplicated) check. Modified: cfe/trunk/lib/Sema/SemaStmt.cpp Modified: cfe/trunk/lib/Sema/SemaStmt.cpp URL:

Re: [cfe-commits] [Patch] Fix parser diagnostic on class specifiers following c++11 attributes

2012-11-18 Thread Michael Han
Hi Richard, Thanks for the suggestions! Attached updated patch. The parser now will parse C++11 attribute specifiers, in the form of double squares that appear at all possible syntactic locations following class-name in a class specifier (also before or after 'final' keyword). In case of final

Re: [cfe-commits] [PATCH] RecursiveASTVisitor.h: Rework r160404, Eliminating the GCC_CAST hack, take two.

2012-11-18 Thread NAKAMURA Takumi
It also passes on; http://bb.pgr.jp/builders/clang-3stage-cygwin/builds/543 http://bb.pgr.jp/builders/clang-i686-msys/builds/831 http://bb.pgr.jp/builders/clang-ppc-linux/builds/683 http://llvm-reviews.chandlerc.com/D125 ___ cfe-commits

Re: [cfe-commits] [Patch] Fix parser diagnostic on class specifiers following c++11 attributes

2012-11-18 Thread Sean Silva
+ ParsedAttributesWithRange attrs(AttrFactory); Variable names should be uppercase, as per the coding standards: http://llvm.org/docs/CodingStandards.html#name-types-functions-variables-and-enumerators-properly -- Sean Silva On Sun, Nov 18, 2012 at 5:52 PM, Michael Han

Re: [cfe-commits] [PATCH] RecursiveASTVisitor.h: Rework r160404, Eliminating the GCC_CAST hack, take two.

2012-11-18 Thread Douglas Gregor
LGTM! Sent from my iPhone On Nov 18, 2012, at 6:00 AM, NAKAMURA Takumi geek4ci...@gmail.com wrote: Hi doug.gregor, RecursiveASTVisitor.h: Rework Doug's r160404, Eliminating the GCC_CAST hack, take two. With this, ARCMT tests would not crash on certain hosts with g++ -O2, eg. cygwin

[cfe-commits] r168295 - /cfe/trunk/include/clang/AST/RecursiveASTVisitor.h

2012-11-18 Thread NAKAMURA Takumi
Author: chapuni Date: Sun Nov 18 18:51:37 2012 New Revision: 168295 URL: http://llvm.org/viewvc/llvm-project?rev=168295view=rev Log: RecursiveASTVisitor.h: Rework Doug's r160404, Eliminating the GCC_CAST hack, take two. With this, ARCMT tests would not crash on certain hosts with g++ -O2, eg.

Re: [cfe-commits] [PATCH] RecursiveASTVisitor.h: Rework r160404, Eliminating the GCC_CAST hack, take two.

2012-11-18 Thread NAKAMURA Takumi
Applied in r168295, thank you! http://llvm-reviews.chandlerc.com/D125 ___ cfe-commits mailing list cfe-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

Re: [cfe-commits] [Patch] Fix parser diagnostic on class specifiers following c++11 attributes

2012-11-18 Thread Richard Smith
Index: lib/Parse/ParseDecl.cpp === --- lib/Parse/ParseDecl.cpp (revision 168292) +++ lib/Parse/ParseDecl.cpp (working copy) @@ -1923,12 +1923,13 @@ TokenName TagName; } + ParsedAttributesWithRange

[cfe-commits] r168296 - /cfe/trunk/include/clang/Driver/Arg.h

2012-11-18 Thread Chandler Carruth
Author: chandlerc Date: Sun Nov 18 21:52:00 2012 New Revision: 168296 URL: http://llvm.org/viewvc/llvm-project?rev=168296view=rev Log: Remove a no-op 'const' from a by-value return type. Modified: cfe/trunk/include/clang/Driver/Arg.h Modified: cfe/trunk/include/clang/Driver/Arg.h URL:

[cfe-commits] r168297 - in /cfe/trunk: include/clang/Basic/DiagnosticDriverKinds.td include/clang/Driver/ToolChain.h lib/Driver/ToolChains.cpp lib/Driver/ToolChains.h lib/Driver/Tools.cpp lib/Driver/W

2012-11-18 Thread Chandler Carruth
Author: chandlerc Date: Sun Nov 18 21:52:03 2012 New Revision: 168297 URL: http://llvm.org/viewvc/llvm-project?rev=168297view=rev Log: Completely re-work how the Clang driver interprets PIC and PIE options. There were numerous issues here that were all entangled, and so I've tried to do a

Re: [cfe-commits] r168260 - in /cfe/trunk: lib/Basic/Targets.cpp lib/CodeGen/CGExpr.cpp test/CodeGen/ppc-atomics.c

2012-11-18 Thread John McCall
On Nov 18, 2012, at 3:03 AM, Benjamin Kramer benny@gmail.com wrote: On 17.11.2012, at 18:30, Benjamin Kramer benny@googlemail.com wrote: Author: d0k Date: Sat Nov 17 11:30:55 2012 New Revision: 168260 URL: http://llvm.org/viewvc/llvm-project?rev=168260view=rev Log: Enable inlining