Re: [cfe-commits] r169328 - in /cfe/trunk: lib/Driver/Tools.cpp test/Driver/asan-ld.c

2012-12-05 Thread Kostya Serebryany
+asan/tsan/msan folks That's not as simple as this, I afraid. In *san there are two different kinds of interceptors. 1. foo from libc/libstc++ is completely replaced with foo from asan. Example: malloc, operator new 2. foo from libc/libstc++ is wrapped, such that when a user calls foo it calls

Re: [cfe-commits] r169328 - in /cfe/trunk: lib/Driver/Tools.cpp test/Driver/asan-ld.c

2012-12-05 Thread Chandler Carruth
On Wed, Dec 5, 2012 at 12:13 AM, Kostya Serebryany k...@google.com wrote: +asan/tsan/msan folks That's not as simple as this, I afraid. In *san there are two different kinds of interceptors. 1. foo from libc/libstc++ is completely replaced with foo from asan. Example: malloc, operator new

Re: [cfe-commits] r169328 - in /cfe/trunk: lib/Driver/Tools.cpp test/Driver/asan-ld.c

2012-12-05 Thread Dmitry Vyukov
On Wed, Dec 5, 2012 at 12:36 PM, Chandler Carruth chandl...@gmail.com wrote: On Wed, Dec 5, 2012 at 12:13 AM, Kostya Serebryany k...@google.com wrote: +asan/tsan/msan folks That's not as simple as this, I afraid. In *san there are two different kinds of interceptors. 1. foo from

Re: [cfe-commits] r169328 - in /cfe/trunk: lib/Driver/Tools.cpp test/Driver/asan-ld.c

2012-12-05 Thread Kostya Serebryany
On Wed, Dec 5, 2012 at 12:36 PM, Chandler Carruth chandl...@gmail.comwrote: On Wed, Dec 5, 2012 at 12:13 AM, Kostya Serebryany k...@google.com wrote: +asan/tsan/msan folks That's not as simple as this, I afraid. In *san there are two different kinds of interceptors. 1. foo from

Re: [cfe-commits] r169328 - in /cfe/trunk: lib/Driver/Tools.cpp test/Driver/asan-ld.c

2012-12-05 Thread Kostya Serebryany
And with tsan the situation is worse because it has to intercept __cxa_guard_acquire/__cxa_guard_release, On Wed, Dec 5, 2012 at 12:45 PM, Kostya Serebryany k...@google.com wrote: On Wed, Dec 5, 2012 at 12:36 PM, Chandler Carruth chandl...@gmail.comwrote: On Wed, Dec 5, 2012 at 12:13 AM,

[cfe-commits] [clang-tools-extra] r169364 - in /clang-tools-extra/trunk: CMakeLists.txt Makefile clang-format/ clang-format/CMakeLists.txt clang-format/ClangFormat.cpp clang-format/Makefile

2012-12-05 Thread Daniel Jasper
Author: djasper Date: Wed Dec 5 03:01:09 2012 New Revision: 169364 URL: http://llvm.org/viewvc/llvm-project?rev=169364view=rev Log: First version of a command line clang-format tool. Reads a single source range (offset, length) as well as the style guide as parameters and then reformats

Re: [cfe-commits] [PATCH] First version of a command line clang-format tool.

2012-12-05 Thread Daniel Jasper
Submitted as r169364. http://llvm-reviews.chandlerc.com/D167 ___ cfe-commits mailing list cfe-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

[cfe-commits] r169365 - /cfe/trunk/lib/StaticAnalyzer/Checkers/DirectIvarAssignment.cpp

2012-12-05 Thread Daniel Jasper
Author: djasper Date: Wed Dec 5 03:23:48 2012 New Revision: 169365 URL: http://llvm.org/viewvc/llvm-project?rev=169365view=rev Log: Add missing virtual destructors reported by -Wnon-virtual-dtor. Modified: cfe/trunk/lib/StaticAnalyzer/Checkers/DirectIvarAssignment.cpp Modified:

Re: [cfe-commits] r169328 - in /cfe/trunk: lib/Driver/Tools.cpp test/Driver/asan-ld.c

2012-12-05 Thread Evgeniy Stepanov
We could reimplement the __cxa_guard_* stuff in TSan... On Wed, Dec 5, 2012 at 12:47 PM, Kostya Serebryany k...@google.com wrote: And with tsan the situation is worse because it has to intercept __cxa_guard_acquire/__cxa_guard_release, On Wed, Dec 5, 2012 at 12:45 PM, Kostya Serebryany

[cfe-commits] r169367 - /cfe/trunk/lib/Frontend/DiagnosticRenderer.cpp

2012-12-05 Thread Richard Smith
Author: rsmith Date: Wed Dec 5 03:47:49 2012 New Revision: 169367 URL: http://llvm.org/viewvc/llvm-project?rev=169367view=rev Log: Minor reorganization. No functionality change. Modified: cfe/trunk/lib/Frontend/DiagnosticRenderer.cpp Modified: cfe/trunk/lib/Frontend/DiagnosticRenderer.cpp

Re: [cfe-commits] [PATCH] [CMake] Move libxml2 stuff from clang to llvm/cmake.

2012-12-05 Thread NAKAMURA Takumi
Autoconf seeks libxml2 in llvm part. I am proposing this for config.h.cmake to be synced to config.h.in. ...I forgot to add *-commits to CCs... http://llvm-reviews.chandlerc.com/D170 ___ cfe-commits mailing list cfe-commits@cs.uiuc.edu

Re: [cfe-commits] [Patch] Initial FreeBSD ARM support

2012-12-05 Thread Andrew Turner
On Wed, 28 Nov 2012 00:02:25 +0200 Dmitri Gribenko griboz...@gmail.com wrote: On Mon, Nov 26, 2012 at 11:15 AM, Andrew Turner and...@fubar.geek.nz wrote: On Sat, 24 Nov 2012 22:23:40 +0200 Dmitri Gribenko griboz...@gmail.com wrote: On Sat, Nov 24, 2012 at 10:47 AM, Andrew Turner

Re: [cfe-commits] [PATCH] [CMake] Move libxml2 stuff from clang to llvm/cmake.

2012-12-05 Thread Sean Silva
How are you committing across both projects simultaneously? http://llvm-reviews.chandlerc.com/D170 ___ cfe-commits mailing list cfe-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

[cfe-commits] [clang-tools-extra] r169371 - /clang-tools-extra/trunk/clang-format/Makefile

2012-12-05 Thread Daniel Jasper
Author: djasper Date: Wed Dec 5 04:22:07 2012 New Revision: 169371 URL: http://llvm.org/viewvc/llvm-project?rev=169371view=rev Log: Fix make build (hopefully). Modified: clang-tools-extra/trunk/clang-format/Makefile Modified: clang-tools-extra/trunk/clang-format/Makefile URL:

Re: [cfe-commits] [PATCH] Implement AST dumper for Decls

2012-12-05 Thread Philip Craig
Thanks for the pointers; test/SemaTemplate had what I needed. I have 5 patches now. The first is http://llvm-reviews.chandlerc.com/D156. The other 4 patches are: - coding style changes for StmtDumper - rename StmtDumper to ASTDumper - add Decl dumping - add Attr dumping Let me

[cfe-commits] [PATCH] Suppress macro backtraces for notes

2012-12-05 Thread Richard Smith
Based on a suggestion from Chandler, the attached patch suppresses macro backtraces for notes. First, the best macro in the expansion chain is chosen (the lowest ancestor of all the source locations provided for the diagnostic in its caret, ranges and fixits). Then we walk up until we hit a line

[cfe-commits] r169373 - in /cfe/trunk: lib/Frontend/DiagnosticRenderer.cpp test/Misc/diag-macro-backtrace.c test/Modules/epic-fail.m

2012-12-05 Thread Richard Smith
Author: rsmith Date: Wed Dec 5 05:04:55 2012 New Revision: 169373 URL: http://llvm.org/viewvc/llvm-project?rev=169373view=rev Log: PR14049: Don't say expanded from macro 'foo' when 'foo' just happens to be the LHS of a token paste. Use expanded from here instead when we're not sure it's actually

[cfe-commits] r169374 - in /cfe/trunk: lib/Sema/SemaDecl.cpp test/Parser/cxx-undeclared-identifier.cpp test/Parser/recovery.cpp

2012-12-05 Thread Richard Smith
Author: rsmith Date: Wed Dec 5 05:34:06 2012 New Revision: 169374 URL: http://llvm.org/viewvc/llvm-project?rev=169374view=rev Log: In C++, if we hit an error in the class-head, don't try to parse the class body. Our error recovery path may have made the class anonymous, and that has a pretty

[cfe-commits] r169375 - /cfe/trunk/test/Modules/build-fail-notes.m

2012-12-05 Thread NAKAMURA Takumi
Author: chapuni Date: Wed Dec 5 05:52:45 2012 New Revision: 169375 URL: http://llvm.org/viewvc/llvm-project?rev=169375view=rev Log: test/Modules/build-fail-notes.m: Tweak to unbreak Win32 hosts to relax expressions, for now. Modified: cfe/trunk/test/Modules/build-fail-notes.m Modified:

Re: [cfe-commits] r169328 - in /cfe/trunk: lib/Driver/Tools.cpp test/Driver/asan-ld.c

2012-12-05 Thread Kostya Serebryany
On Wed, Dec 5, 2012 at 1:30 PM, Evgeniy Stepanov euge...@google.com wrote: We could reimplement the __cxa_guard_* stuff in TSan... Dmitry did this in r169376. We still have a similar problem in asan with __cxa_throw (less likely to appear in real life, but still possible). --kcc On Wed,

[cfe-commits] r169380 - in /cfe/trunk: include/clang/Basic/DiagnosticDriverKinds.td lib/Driver/Tools.cpp test/Driver/fsanitize.c

2012-12-05 Thread Evgeniy Stepanov
Author: eugenis Date: Wed Dec 5 07:37:12 2012 New Revision: 169380 URL: http://llvm.org/viewvc/llvm-project?rev=169380view=rev Log: Reuse an existing diagnostic for tsan/msan needing -pie error. Add a diagnosting for -fsanitize=memory conflicting with other sanitizers. Extend tests. Modified:

Re: [cfe-commits] [PATCH] Clang support for MemorySanitizer

2012-12-05 Thread Evgeniy Stepanov
Done and committed. I also noticed that we do not catch conflicts between memory and other sanitizers. Let me know if you are not comfortable with a bit of code duplication there. I think that N*(N-1) explicit checks (for N=3) is still better and more readable than generic code for arbitrary

[cfe-commits] r169382 - in /cfe/trunk/lib/Format: Format.cpp UnwrappedLineParser.cpp UnwrappedLineParser.h

2012-12-05 Thread Alexander Kornienko
Author: alexfh Date: Wed Dec 5 07:56:52 2012 New Revision: 169382 URL: http://llvm.org/viewvc/llvm-project?rev=169382view=rev Log: Follow-up to r169286, addresses comments in http://llvm-reviews.chandlerc.com/D164#comment-4 : comments and a method rename Modified:

[cfe-commits] [PATCH] Indentation fixes for clang-format.

2012-12-05 Thread Daniel Jasper
Hi klimek, - Fix behavior of memoization together with optimization - Correctly attribute the PenaltyIndentLevel (breaking directly after ( did not count towards the inner level) - Recognize more tokens as assignments http://llvm-reviews.chandlerc.com/D172 Files: lib/Format/Format.cpp

Re: [cfe-commits] [PATCH] First OpenMP patch

2012-12-05 Thread Alexey Bataev
Here is an updated patch. - Original Message - From: Dmitri Gribenko Sent: 12/04/12 06:26 PM To: Alexey Bataev Subject: Re: [cfe-commits] [PATCH] First OpenMP patch On Tue, Dec 4, 2012 at 9:26 AM, Alexey Bataev a.bat...@gmx.com wrote: After discussion with Mahesha, we decided that it

Re: [cfe-commits] [PATCH] Indentation fixes for clang-format.

2012-12-05 Thread Manuel Klimek
I think we might want to come up with more tests that trigger the corner cases of the memoization. Comment at: lib/Format/Format.cpp:300 @@ +299,3 @@ + // previous result unless we have hit the optimatization (and thus + // returned UINT_MAX) and are now computing

Re: [cfe-commits] [PATCH] [CMake] Move libxml2 stuff from clang to llvm/cmake.

2012-12-05 Thread NAKAMURA Takumi
Sean, it might be offtopic here. Please see my post in the llvmdev. http://llvm-reviews.chandlerc.com/D170 ___ cfe-commits mailing list cfe-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

Re: [cfe-commits] [Review] First step towards PR13231 - vftable generation with -cxx-abi microsoft

2012-12-05 Thread Timur Iskhodzhanov
On Tue, Dec 4, 2012 at 8:09 PM, Timur Iskhodzhanov timur...@google.com wrote: d) The complete/deleting dtor logic will change when we support MSVC dtor types, but not now [shouldn't matter now that we still don't support virtual inheritance] You're thinking about complete vs. base

Re: [cfe-commits] [PATCH] Clang-format: parse for and while loops

2012-12-05 Thread Manuel Klimek
lg http://llvm-reviews.chandlerc.com/D174 ___ cfe-commits mailing list cfe-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

Re: [cfe-commits] [PATCH] Indentation fixes for clang-format.

2012-12-05 Thread Daniel Jasper
Hi klimek, http://llvm-reviews.chandlerc.com/D172 CHANGE SINCE LAST DIFF http://llvm-reviews.chandlerc.com/D172?vs=429id=432#toc Files: lib/Format/Format.cpp lib/Format/UnwrappedLineParser.cpp unittests/Format/FormatTest.cpp Index: lib/Format/Format.cpp

Re: [cfe-commits] [PATCH] Indentation fixes for clang-format.

2012-12-05 Thread Manuel Klimek
On Wed, Dec 5, 2012 at 3:43 PM, Daniel Jasper djas...@google.com wrote: I don't disagree, but it is also not easy to do. Do you consider that a precondition for this patch? Comment at: lib/Format/Format.cpp:300 @@ +299,3 @@ + // previous result unless we have hit

Re: [cfe-commits] [PATCH] Indentation fixes for clang-format.

2012-12-05 Thread Daniel Jasper
I don't disagree, but it is also not easy to do. Do you consider that a precondition for this patch? Comment at: lib/Format/Format.cpp:300 @@ +299,3 @@ + // previous result unless we have hit the optimatization (and thus + // returned UINT_MAX) and are now

Re: [cfe-commits] [PATCH] Indentation fixes for clang-format.

2012-12-05 Thread Daniel Jasper
Submitted as r169384. http://llvm-reviews.chandlerc.com/D172 ___ cfe-commits mailing list cfe-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

[cfe-commits] r169384 - in /cfe/trunk: lib/Format/Format.cpp lib/Format/UnwrappedLineParser.cpp unittests/Format/FormatTest.cpp

2012-12-05 Thread Daniel Jasper
Author: djasper Date: Wed Dec 5 08:57:28 2012 New Revision: 169384 URL: http://llvm.org/viewvc/llvm-project?rev=169384view=rev Log: Indentation fixes for clang-format. - Fix behavior of memoization together with optimization - Correctly attribute the PenaltyIndentLevel (breaking directly after

Re: [cfe-commits] [Review] First step towards PR13231 - vftable generation with -cxx-abi microsoft

2012-12-05 Thread João Matos
I've researched MS ctor/dtor behaviour a bit, check PR 12784 ( http://llvm.org/bugs/show_bug.cgi?id=12784) for a simple file that shows the different types we will expect. On Wed, Dec 5, 2012 at 2:28 PM, Timur Iskhodzhanov timur...@google.comwrote: On Tue, Dec 4, 2012 at 8:09 PM, Timur

[cfe-commits] r169387 - in /cfe/trunk: lib/Format/UnwrappedLineParser.cpp lib/Format/UnwrappedLineParser.h unittests/Format/FormatTest.cpp

2012-12-05 Thread Alexander Kornienko
Author: alexfh Date: Wed Dec 5 09:06:06 2012 New Revision: 169387 URL: http://llvm.org/viewvc/llvm-project?rev=169387view=rev Log: Clang-format: parse for and while loops Summary: Adds support for formatting for and while loops. Reviewers: djasper, klimek Reviewed By: klimek CC: cfe-commits

Re: [cfe-commits] r169373 - in /cfe/trunk: lib/Frontend/DiagnosticRenderer.cpp test/Misc/diag-macro-backtrace.c test/Modules/epic-fail.m

2012-12-05 Thread NAKAMURA Takumi
2012/12/5 Richard Smith richard-l...@metafoo.co.uk: Author: rsmith Date: Wed Dec 5 05:04:55 2012 New Revision: 169373 URL: http://llvm.org/viewvc/llvm-project?rev=169373view=rev Log: PR14049: Don't say expanded from macro 'foo' when 'foo' just happens to be the LHS of a token paste. Use

Re: [cfe-commits] [PATCH] Fix analysis based warnings so that all warnings are emitted with -Werror.

2012-12-05 Thread Delesley Hutchins
I'm happy with uncompilable. It's not quite accurate; there are some errors that are technically compilable, but treated as errors for other reasons, but it captures the spirit of what I'm trying to do, and I don't have a better name. Anybody else want to weigh in? -DeLesley On Tue, Dec 4,

[cfe-commits] r169390 - /cfe/trunk/lib/Format/Format.cpp

2012-12-05 Thread Daniel Jasper
Author: djasper Date: Wed Dec 5 10:24:48 2012 New Revision: 169390 URL: http://llvm.org/viewvc/llvm-project?rev=169390view=rev Log: Remove bad and useless enum to bool conversion. Modified: cfe/trunk/lib/Format/Format.cpp Modified: cfe/trunk/lib/Format/Format.cpp URL:

Re: [cfe-commits] r167766 - in /cfe/trunk: include/clang/Sema/Scope.h lib/Parse/ParseStmt.cpp lib/Sema/IdentifierResolver.cpp test/CXX/basic/basic.scope/basic.scope.local/p2.cpp

2012-12-05 Thread David Blaikie
Richard - apparently this didn't make it into the 3.2 branch, could you approve? On Tue, Nov 13, 2012 at 10:53 AM, David Blaikie dblai...@gmail.com wrote: On Mon, Nov 12, 2012 at 3:41 PM, Richard Smith rich...@metafoo.co.uk wrote: On Mon, Nov 12, 2012 at 2:25 PM, David Blaikie

Re: [cfe-commits] [PATCH] Suppress macro backtraces for notes

2012-12-05 Thread David Blaikie
On Wed, Dec 5, 2012 at 2:45 AM, Richard Smith rich...@metafoo.co.uk wrote: Based on a suggestion from Chandler, the attached patch suppresses macro backtraces for notes. First, the best macro in the expansion chain is chosen (the lowest ancestor of all the source locations provided for the

Re: [cfe-commits] r169365 - /cfe/trunk/lib/StaticAnalyzer/Checkers/DirectIvarAssignment.cpp

2012-12-05 Thread Jordan Rose
Sorry I missed this the first time around...these should probably not be struct, per the LLVM coding conventions, and the inheritance should be public. Jordan On Dec 5, 2012, at 1:23 , Daniel Jasper djas...@google.com wrote: Author: djasper Date: Wed Dec 5 03:23:48 2012 New Revision:

Re: [cfe-commits] [Review] First step towards PR13231 - vftable generation with -cxx-abi microsoft

2012-12-05 Thread Timur Iskhodzhanov
Thanks to John's example above I think I now understand what's going on in the Itanium ABI and I think I know where to go now to fix the incompatibility. On Wed, Dec 5, 2012 at 6:58 PM, João Matos ripzonetri...@gmail.com wrote: I've researched MS ctor/dtor behaviour a bit, check PR 12784

[cfe-commits] [PATCH] Clang-format: detect unbalanced braces.

2012-12-05 Thread Alexander Kornienko
Hi klimek, djasper, http://llvm-reviews.chandlerc.com/D176 Files: lib/Format/UnwrappedLineParser.cpp unittests/Format/FormatTest.cpp Index: lib/Format/UnwrappedLineParser.cpp === --- lib/Format/UnwrappedLineParser.cpp +++

[cfe-commits] [PATCH] alignment for clang-format

2012-12-05 Thread Daniel Jasper
Hi klimek, http://llvm-reviews.chandlerc.com/D177 Files: lib/Format/Format.cpp unittests/Format/FormatTest.cpp Index: lib/Format/Format.cpp === --- lib/Format/Format.cpp +++ lib/Format/Format.cpp @@ -102,6 +102,7 @@

[cfe-commits] r169398 - in /cfe/trunk: lib/Sema/SemaChecking.cpp test/FixIt/format.m

2012-12-05 Thread Jordan Rose
Author: jrose Date: Wed Dec 5 12:44:40 2012 New Revision: 169398 URL: http://llvm.org/viewvc/llvm-project?rev=169398view=rev Log: Format strings: a character literal should be printed with %c, not %d. The type of a character literal is 'int' in C, but if the user writes a character /as/ a

[cfe-commits] r169397 - in /cfe/trunk: lib/Analysis/PrintfFormatString.cpp test/FixIt/format.m

2012-12-05 Thread Jordan Rose
Author: jrose Date: Wed Dec 5 12:44:37 2012 New Revision: 169397 URL: http://llvm.org/viewvc/llvm-project?rev=169397view=rev Log: Format strings: the correct conversion for 'char' is %c, not %d or %hhd. We tried to account for 'uint8_t' by saying that /typedefs/ of 'char' should be corrected as

[cfe-commits] r169400 - in /cfe/trunk: lib/Analysis/PrintfFormatString.cpp lib/Sema/SemaChecking.cpp test/FixIt/format.m test/FixIt/format.mm test/SemaObjC/format-strings-objc.m

2012-12-05 Thread Jordan Rose
Author: jrose Date: Wed Dec 5 12:44:49 2012 New Revision: 169400 URL: http://llvm.org/viewvc/llvm-project?rev=169400view=rev Log: Format strings: offer a cast to 'unichar' for %C in Objective-C contexts. For most cases where a conversion specifier doesn't match an argument, we usually guess

[cfe-commits] r169399 - in /cfe/trunk: lib/Sema/SemaChecking.cpp test/FixIt/format-darwin.m

2012-12-05 Thread Jordan Rose
Author: jrose Date: Wed Dec 5 12:44:44 2012 New Revision: 169399 URL: http://llvm.org/viewvc/llvm-project?rev=169399view=rev Log: Format strings: add more expression types that don't need parens to cast. No functionality change (the test change is a comment only, and the new functionality can't

Re: [cfe-commits] r169191 - in /cfe/trunk: lib/CodeGen/CodeGenFunction.cpp test/CodeGen/fast-math.c test/CodeGen/finite-math.c

2012-12-05 Thread Dmitri Gribenko
On Tue, Dec 4, 2012 at 2:36 AM, Michael Ilseman milse...@apple.com wrote: Added: cfe/trunk/test/CodeGen/finite-math.c URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGen/finite-math.c?rev=169191view=auto

[cfe-commits] r169411 - /cfe/trunk/test/CodeGen/ms-inline-asm.c

2012-12-05 Thread Chad Rosier
Author: mcrosier Date: Wed Dec 5 13:52:05 2012 New Revision: 169411 URL: http://llvm.org/viewvc/llvm-project?rev=169411view=rev Log: [ms-inline asm] Add more tests. Modified: cfe/trunk/test/CodeGen/ms-inline-asm.c Modified: cfe/trunk/test/CodeGen/ms-inline-asm.c URL:

[cfe-commits] r169412 - in /cfe/trunk: lib/AST/DeclPrinter.cpp test/Index/comment-to-html-xml-conversion.cpp unittests/AST/DeclPrinterTest.cpp

2012-12-05 Thread Fariborz Jahanian
Author: fjahanian Date: Wed Dec 5 13:54:11 2012 New Revision: 169412 URL: http://llvm.org/viewvc/llvm-project?rev=169412view=rev Log: Testing C++ declarations embedded in declaration tag of Comment XML. Added DeclPrint support for constructors and fix tests accordingly. This is wip. //

Re: [cfe-commits] r169412 - in /cfe/trunk: lib/AST/DeclPrinter.cpp test/Index/comment-to-html-xml-conversion.cpp unittests/AST/DeclPrinterTest.cpp

2012-12-05 Thread Dmitri Gribenko
Hi Fariborz, On Wed, Dec 5, 2012 at 9:54 PM, Fariborz Jahanian fjahan...@apple.com wrote: @@ -482,8 +477,8 @@ A() = default; };, constructorDecl(ofClass(hasName(A))).bind(id), -)); -// WRONG; Should be: A() = default; +A() noexcept)); +// WRONG; Should be:

[cfe-commits] r169413 - /cfe/trunk/unittests/AST/DeclPrinterTest.cpp

2012-12-05 Thread Fariborz Jahanian
Author: fjahanian Date: Wed Dec 5 14:10:11 2012 New Revision: 169413 URL: http://llvm.org/viewvc/llvm-project?rev=169413view=rev Log: fix comment. Modified: cfe/trunk/unittests/AST/DeclPrinterTest.cpp Modified: cfe/trunk/unittests/AST/DeclPrinterTest.cpp URL:

Re: [cfe-commits] [PATCH] Invariants (and Assume Aligned) - Clang

2012-12-05 Thread hfin...@anl.gov
Test cases have been enhanced. We now use @llvm.invariant. http://llvm-reviews.chandlerc.com/D149 CHANGE SINCE LAST DIFF http://llvm-reviews.chandlerc.com/D149?vs=383id=438#toc Files: include/clang/Basic/Builtins.def include/clang/Sema/Sema.h lib/AST/ExprConstant.cpp

[cfe-commits] [clang-tools-extra] r169421 - /clang-tools-extra/trunk/clang-format/clang-format.py

2012-12-05 Thread Daniel Jasper
Author: djasper Date: Wed Dec 5 15:06:08 2012 New Revision: 169421 URL: http://llvm.org/viewvc/llvm-project?rev=169421view=rev Log: Basic clang-format vim-integration. File contains installation and usage instructions. Added: clang-tools-extra/trunk/clang-format/clang-format.py Added:

[cfe-commits] r169422 - in /cfe/trunk: include/clang/Basic/LangOptions.def include/clang/Driver/Options.td lib/Driver/Tools.cpp lib/Frontend/CompilerInvocation.cpp lib/Parse/ParseStmt.cpp test/CodeGen

2012-12-05 Thread Chad Rosier
Author: mcrosier Date: Wed Dec 5 15:08:21 2012 New Revision: 169422 URL: http://llvm.org/viewvc/llvm-project?rev=169422view=rev Log: [driver, ms-inline asm] MS-Style inline assembly is controlled by the -fasm-blocks flag, not the -fms-extensions flag. rdar://12808010 Added:

Re: [cfe-commits] [PATCH] Invariants (and Assume Aligned) - Clang

2012-12-05 Thread Dmitri Gribenko
Please update docs/LanguageExtensions.html with descriptions of these two new builtins. Comment at: lib/Sema/SemaChecking.cpp:1605 @@ +1604,3 @@ + // We can't check the value of a dependent argument. + if (!Arg-isTypeDependent() !Arg-isValueDependent()) { +

[cfe-commits] r169429 - /cfe/trunk/test/CodeGenCXX/debug-info-zero-length-arrays.cpp

2012-12-05 Thread Bill Wendling
Author: void Date: Wed Dec 5 15:43:37 2012 New Revision: 169429 URL: http://llvm.org/viewvc/llvm-project?rev=169429view=rev Log: Fix name. The array is unboundED. Modified: cfe/trunk/test/CodeGenCXX/debug-info-zero-length-arrays.cpp Modified:

[cfe-commits] r169430 - /cfe/trunk/tools/c-index-test/c-index-test.c

2012-12-05 Thread Argyrios Kyrtzidis
Author: akirtzidis Date: Wed Dec 5 15:53:37 2012 New Revision: 169430 URL: http://llvm.org/viewvc/llvm-project?rev=169430view=rev Log: [c-index-test] Introduce '-index-compile-db' which accepts a compilation database file and does an '-index-file' for all compile commands in the database.

Re: [cfe-commits] [PATCH] Invariants (and Assume Aligned) - Clang

2012-12-05 Thread Tobias Grosser
On 12/05/2012 09:39 PM, hfin...@anl.gov wrote: Test cases have been enhanced. We now use @llvm.invariant. Index: test/CodeGen/builtin-assume.c === --- /dev/null +++ test/CodeGen/builtin-assume.c @@ -0,0 +1,9 @@ +// RUN:

[cfe-commits] r169434 - /cfe/trunk/test/Modules/build-fail-notes.m

2012-12-05 Thread Richard Smith
Author: rsmith Date: Wed Dec 5 16:18:04 2012 New Revision: 169434 URL: http://llvm.org/viewvc/llvm-project?rev=169434view=rev Log: Fix an egregiously broken test. This pattern doesn't work: RUN: a RUN: b || true lit expands it to a b || true, and the || true applies to both commands (thus

[cfe-commits] r169435 - in /cfe/trunk: lib/AST/DeclPrinter.cpp unittests/AST/DeclPrinterTest.cpp

2012-12-05 Thread Fariborz Jahanian
Author: fjahanian Date: Wed Dec 5 16:19:06 2012 New Revision: 169435 URL: http://llvm.org/viewvc/llvm-project?rev=169435view=rev Log: In DeclPrint add printing of 'explicit' constructors. Modified: cfe/trunk/lib/AST/DeclPrinter.cpp cfe/trunk/unittests/AST/DeclPrinterTest.cpp Modified:

Re: [cfe-commits] r169434 - /cfe/trunk/test/Modules/build-fail-notes.m

2012-12-05 Thread Jordan Rose
Okay, lit just needs to reject this if it doesn't work. It's too easy to write it by accident. On Dec 5, 2012, at 14:18 , Richard Smith richard-l...@metafoo.co.uk wrote: Author: rsmith Date: Wed Dec 5 16:18:04 2012 New Revision: 169434 URL:

Re: [cfe-commits] [PATCH] Invariants (and Assume Aligned) - Clang

2012-12-05 Thread Hal Finkel
- Original Message - From: Tobias Grosser tob...@grosser.es To: reviews+d149+public+707ba5224a940...@llvm-reviews.chandlerc.com Cc: hfin...@anl.gov, cfe-commits@cs.uiuc.edu Sent: Wednesday, December 5, 2012 4:04:54 PM Subject: Re: [cfe-commits] [PATCH] Invariants (and Assume Aligned)

[cfe-commits] r169437 - in /cfe/trunk/test: Misc/serialized-diags-frontend.c Misc/serialized-diags-no-category.c Misc/serialized-diags.c PCH/missing-file.cpp

2012-12-05 Thread Richard Smith
Author: rsmith Date: Wed Dec 5 16:33:14 2012 New Revision: 169437 URL: http://llvm.org/viewvc/llvm-project?rev=169437view=rev Log: More workarounds for PR10867. Modified: cfe/trunk/test/Misc/serialized-diags-frontend.c cfe/trunk/test/Misc/serialized-diags-no-category.c

Re: [cfe-commits] [PATCH] Invariants (and Assume Aligned) - Clang

2012-12-05 Thread Tobias Grosser
On 12/05/2012 11:29 PM, Hal Finkel wrote: - Original Message - From: Tobias Grossertob...@grosser.es To: reviews+d149+public+707ba5224a940...@llvm-reviews.chandlerc.com Cc: hfin...@anl.gov, cfe-commits@cs.uiuc.edu Sent: Wednesday, December 5, 2012 4:04:54 PM Subject: Re: [cfe-commits]

Re: [cfe-commits] [PATCH] Invariants (and Assume Aligned) - Clang

2012-12-05 Thread Hal Finkel
- Original Message - From: Tobias Grosser tob...@grosser.es To: Hal Finkel hfin...@anl.gov Cc: cfe-commits@cs.uiuc.edu, reviews+d149+public+707ba5224a940...@llvm-reviews.chandlerc.com Sent: Wednesday, December 5, 2012 4:37:01 PM Subject: Re: [cfe-commits] [PATCH] Invariants (and

Re: [cfe-commits] [PATCH] Invariants (and Assume Aligned) - Clang

2012-12-05 Thread Tobias Grosser
On 12/05/2012 11:45 PM, Hal Finkel wrote: - Original Message - From: Tobias Grossertob...@grosser.es To: Hal Finkelhfin...@anl.gov Cc: cfe-commits@cs.uiuc.edu, reviews+d149+public+707ba5224a940...@llvm-reviews.chandlerc.com Sent: Wednesday, December 5, 2012 4:37:01 PM Subject: Re:

[cfe-commits] web code review not integrating emails

2012-12-05 Thread Tobias Grosser
On 12/05/2012 11:45 PM, Hal Finkel wrote: - Original Message - From: Tobias Grossertob...@grosser.es To: Hal Finkelhfin...@anl.gov Cc: cfe-commits@cs.uiuc.edu, reviews+d149+public+707ba5224a940...@llvm-reviews.chandlerc.com Sent: Wednesday, December 5, 2012 4:37:01 PM Subject: Re:

[cfe-commits] r169440 - in /cfe/trunk: lib/AST/DeclPrinter.cpp unittests/AST/DeclPrinterTest.cpp

2012-12-05 Thread Fariborz Jahanian
Author: fjahanian Date: Wed Dec 5 16:53:06 2012 New Revision: 169440 URL: http://llvm.org/viewvc/llvm-project?rev=169440view=rev Log: In DeclPrint add printing of '= default' in constructors. Modified: cfe/trunk/lib/AST/DeclPrinter.cpp cfe/trunk/unittests/AST/DeclPrinterTest.cpp

Re: [cfe-commits] PATCH: Large re-working of bitfield IR-gen, and a fix for PR13691

2012-12-05 Thread Chris Lattner
On Dec 4, 2012, at 11:07 AM, Chandler Carruth chandl...@google.com wrote: Chris, any final comments? Everyone else seems happy with this approach now. Go for it. Please watch for regressions carefully :) -Chris ___ cfe-commits mailing list

[cfe-commits] r169442 - /cfe/trunk/test/PCH/missing-file.cpp

2012-12-05 Thread Richard Smith
Author: rsmith Date: Wed Dec 5 16:59:28 2012 New Revision: 169442 URL: http://llvm.org/viewvc/llvm-project?rev=169442view=rev Log: Looks like lit on Windows can't cope with parens here, and in any case, we shouldn't need them after r169441. Modified: cfe/trunk/test/PCH/missing-file.cpp

[cfe-commits] r169445 - in /cfe/trunk: lib/Frontend/CompilerInvocation.cpp test/Parser/MicrosoftExtensions.c

2012-12-05 Thread Chad Rosier
Author: mcrosier Date: Wed Dec 5 17:08:09 2012 New Revision: 169445 URL: http://llvm.org/viewvc/llvm-project?rev=169445view=rev Log: [driver, ms-inline asm] Have -fms-extensions enable the AsmBlocks language option. MS-style inline asm can now be enabled by either -fasm-blocks or

Re: [cfe-commits] r169445 - in /cfe/trunk: lib/Frontend/CompilerInvocation.cpp test/Parser/MicrosoftExtensions.c

2012-12-05 Thread Richard Smith
On Wed, Dec 5, 2012 at 3:08 PM, Chad Rosier mcros...@apple.com wrote: Author: mcrosier Date: Wed Dec 5 17:08:09 2012 New Revision: 169445 URL: http://llvm.org/viewvc/llvm-project?rev=169445view=rev Log: [driver, ms-inline asm] Have -fms-extensions enable the AsmBlocks language option.

Re: [cfe-commits] r169445 - in /cfe/trunk: lib/Frontend/CompilerInvocation.cpp test/Parser/MicrosoftExtensions.c

2012-12-05 Thread Richard Smith
On Wed, Dec 5, 2012 at 3:20 PM, Richard Smith rich...@metafoo.co.uk wrote: On Wed, Dec 5, 2012 at 3:08 PM, Chad Rosier mcros...@apple.com wrote: Author: mcrosier Date: Wed Dec 5 17:08:09 2012 New Revision: 169445 URL: http://llvm.org/viewvc/llvm-project?rev=169445view=rev Log: [driver,

Re: [cfe-commits] [PATCH] Suppress macro backtraces for notes

2012-12-05 Thread Richard Smith
On Wed, Dec 5, 2012 at 8:57 AM, David Blaikie dblai...@gmail.com wrote: On Wed, Dec 5, 2012 at 2:45 AM, Richard Smith rich...@metafoo.co.uk wrote: Based on a suggestion from Chandler, the attached patch suppresses macro backtraces for notes. First, the best macro in the expansion chain

Re: [cfe-commits] [PATCH] Clang support for MemorySanitizer

2012-12-05 Thread Richard Smith
On Wed, Dec 5, 2012 at 5:41 AM, Evgeniy Stepanov euge...@google.com wrote: Done and committed. I also noticed that we do not catch conflicts between memory and other sanitizers. Let me know if you are not comfortable with a bit of code duplication there. I think that N*(N-1) explicit checks

Re: [cfe-commits] r167766 - in /cfe/trunk: include/clang/Sema/Scope.h lib/Parse/ParseStmt.cpp lib/Sema/IdentifierResolver.cpp test/CXX/basic/basic.scope/basic.scope.local/p2.cpp

2012-12-05 Thread Richard Smith
On Wed, Dec 5, 2012 at 8:42 AM, David Blaikie dblai...@gmail.com wrote: Richard - apparently this didn't make it into the 3.2 branch, could you approve? Yes, this is important. Approved, but Doug was owner here for 3.2, and I'm not sure whether Pawel is looking at the owners as listed in the

Re: [cfe-commits] r169434 - /cfe/trunk/test/Modules/build-fail-notes.m

2012-12-05 Thread Richard Smith
On Wed, Dec 5, 2012 at 2:23 PM, Jordan Rose jordan_r...@apple.com wrote: Okay, lit just needs to reject this if it doesn't work. It's too easy to write it by accident. I've gone ahead and fixed lit. On Dec 5, 2012, at 14:18 , Richard Smith richard-l...@metafoo.co.uk wrote: Author:

Re: [cfe-commits] r167766 - in /cfe/trunk: include/clang/Sema/Scope.h lib/Parse/ParseStmt.cpp lib/Sema/IdentifierResolver.cpp test/CXX/basic/basic.scope/basic.scope.local/p2.cpp

2012-12-05 Thread Douglas Gregor
On Dec 5, 2012, at 3:31 PM, Richard Smith rich...@metafoo.co.uk wrote: On Wed, Dec 5, 2012 at 8:42 AM, David Blaikie dblai...@gmail.com wrote: Richard - apparently this didn't make it into the 3.2 branch, could you approve? Yes, this is important. Approved, but Doug was owner here for

[cfe-commits] r169448 - /cfe/trunk/lib/Frontend/CompilerInvocation.cpp

2012-12-05 Thread Chad Rosier
Author: mcrosier Date: Wed Dec 5 17:35:10 2012 New Revision: 169448 URL: http://llvm.org/viewvc/llvm-project?rev=169448view=rev Log: [driver, ms-inline asm] -fms-compatibility enables -fms-extensions, so this should enable the AsmBlocks language extension as well. rdar://12808010 Modified:

Re: [cfe-commits] r169445 - in /cfe/trunk: lib/Frontend/CompilerInvocation.cpp test/Parser/MicrosoftExtensions.c

2012-12-05 Thread Chad Rosier
On Dec 5, 2012, at 3:20 PM, Richard Smith rich...@metafoo.co.uk wrote: On Wed, Dec 5, 2012 at 3:20 PM, Richard Smith rich...@metafoo.co.uk wrote: On Wed, Dec 5, 2012 at 3:08 PM, Chad Rosier mcros...@apple.com wrote: Author: mcrosier Date: Wed Dec 5 17:08:09 2012 New Revision: 169445

Re: [cfe-commits] [PATCH] Invariants (and Assume Aligned) - Clang

2012-12-05 Thread hfin...@anl.gov
More, and more explicit, test cases. Removed unneeded '+' operators. Added documentation. http://llvm-reviews.chandlerc.com/D149 CHANGE SINCE LAST DIFF http://llvm-reviews.chandlerc.com/D149?vs=438id=441#toc Files: docs/LanguageExtensions.html include/clang/Basic/Builtins.def

Re: [cfe-commits] r167766 - in /cfe/trunk: include/clang/Sema/Scope.h lib/Parse/ParseStmt.cpp lib/Sema/IdentifierResolver.cpp test/CXX/basic/basic.scope/basic.scope.local/p2.cpp

2012-12-05 Thread Pawel Wodnicki
On Dec 5, 2012, at 3:31 PM, Richard Smith rich...@metafoo.co.uk wrote: On Wed, Dec 5, 2012 at 8:42 AM, David Blaikie dblai...@gmail.com wrote: Richard - apparently this didn't make it into the 3.2 branch, could you approve? Yes, this is important. Approved, but Doug was owner here for

Re: [cfe-commits] [PATCH] Invariants (and Assume Aligned) - Clang

2012-12-05 Thread Dmitri Gribenko
I don't have more comments, so this looks good to me, but please wait for another review. Comment at: docs/LanguageExtensions.html:1409-1412 @@ +1408,6 @@ + +pThe boolean argument to this function is defined to be true. The optimizer +may analyze the expression used to

[cfe-commits] r169453 - in /cfe/trunk: lib/AST/DeclPrinter.cpp test/Index/comment-cplus-template-decls.cpp

2012-12-05 Thread Fariborz Jahanian
Author: fjahanian Date: Wed Dec 5 18:09:40 2012 New Revision: 169453 URL: http://llvm.org/viewvc/llvm-project?rev=169453view=rev Log: More C++ testing of declarations embedded in declaration tag of Comment XML and fixing DeclPrint of templates along the way - wip. //rdar://12378714 Added:

Re: [cfe-commits] [PATCH] Invariants (and Assume Aligned) - Clang

2012-12-05 Thread hfin...@anl.gov
- Original Message - From: Dmitri Gribenko griboz...@gmail.com To: hfin...@anl.gov Cc: griboz...@gmail.com, cfe-commits@cs.uiuc.edu, chandl...@gmail.com Sent: Wednesday, December 5, 2012 5:57:58 PM Subject: Re: [PATCH] Invariants (and Assume Aligned) - Clang I

Re: [cfe-commits] [PATCH] Invariants (and Assume Aligned) - Clang

2012-12-05 Thread Hal Finkel
- Original Message - From: Dmitri Gribenko griboz...@gmail.com To: hfin...@anl.gov Cc: griboz...@gmail.com, cfe-commits@cs.uiuc.edu, chandl...@gmail.com Sent: Wednesday, December 5, 2012 5:57:58 PM Subject: Re: [PATCH] Invariants (and Assume Aligned) - Clang I don't have more

Re: [cfe-commits] web code review not integrating emails

2012-12-05 Thread Chandler Carruth
Manuel might have more insight than me. On Wed, Dec 5, 2012 at 2:50 PM, Tobias Grosser tob...@grosser.es wrote: On 12/05/2012 11:45 PM, Hal Finkel wrote: - Original Message - From: Tobias Grossertob...@grosser.es To: Hal Finkelhfin...@anl.gov Cc: cfe-commits@cs.uiuc.edu,

[cfe-commits] r169457 - /cfe/trunk/test/Index/comment-cplus-template-decls.cpp

2012-12-05 Thread Fariborz Jahanian
Author: fjahanian Date: Wed Dec 5 18:57:28 2012 New Revision: 169457 URL: http://llvm.org/viewvc/llvm-project?rev=169457view=rev Log: more test of template declarations in a declaration XML tag. // rdar://12378714 Modified: cfe/trunk/test/Index/comment-cplus-template-decls.cpp Modified:

[cfe-commits] r169458 - in /cfe/trunk/test/Preprocessor: macro-multiline.c macro-multiline.c.ignoreme

2012-12-05 Thread NAKAMURA Takumi
Author: chapuni Date: Wed Dec 5 19:09:31 2012 New Revision: 169458 URL: http://llvm.org/viewvc/llvm-project?rev=169458view=rev Log: Disable clang/test/Preprocessor/macro-multiline.c for now, while investigating lit.ShUtil.parser. Added:

Re: [cfe-commits] [PATCH] Add i686-linux-android for gcc toolchain detection

2012-12-05 Thread Logan Chien
Ping. The rebased patch is attached. On Thu, Nov 15, 2012 at 11:36 AM, Logan Chien tzuhsiang.ch...@gmail.comwrote: Dear all, The GCCInstallationDetector can't detect the GCC for X86 in NDK (i686-linux-android.) The attached patch should fix the problem, and slightly enhance the test

[cfe-commits] r169467 - in /cfe/trunk: lib/AST/ASTContext.cpp test/SemaCXX/empty-class-layout.cpp

2012-12-05 Thread Richard Smith
Author: rsmith Date: Wed Dec 5 21:04:50 2012 New Revision: 169467 URL: http://llvm.org/viewvc/llvm-project?rev=169467view=rev Log: Don't use dyn_cast on a Type* which might not be canonical. Fixes an extremely obscure record layout bug. Modified: cfe/trunk/lib/AST/ASTContext.cpp

[cfe-commits] [libcxxabi] r169402 - /libcxxabi/trunk/src/cxa_demangle.cpp

2012-12-05 Thread Daniel Malea
Author: dmalea Date: Wed Dec 5 12:55:49 2012 New Revision: 169402 URL: http://llvm.org/viewvc/llvm-project?rev=169402view=rev Log: Rename class __lambda_node to ___lambda_node to fix compile failure with gcc 4.6 and 4.7 - using __lambda_node causes internal compiler error in newer GCC versions

[cfe-commits] PATCH: fix the way AST record layouts are dumped

2012-12-05 Thread Eli Bendersky
Hello, Currently when AST record layouts are dumped with -fdump-record-layouts, the following: sizeof=132, dsize=132, align=4 nvsize=132, nvalign=4 Is not indented, so when classes are nested there is no way to know to which class it belongs. This patch fixes it by indenting the size summary

[cfe-commits] r169475 - in /cfe/trunk: lib/Sema/SemaTemplateDeduction.cpp test/CXX/temp/temp.fct.spec/temp.deduct/temp.deduct.type/p9-0x.cpp

2012-12-05 Thread Richard Smith
Author: rsmith Date: Thu Dec 6 00:44:44 2012 New Revision: 169475 URL: http://llvm.org/viewvc/llvm-project?rev=169475view=rev Log: Fix http://stackoverflow.com/questions/13521163 Don't require that, during template deduction, a template specialization type as a function parameter has at least

[cfe-commits] r169479 - in /cfe/trunk: include/clang/StaticAnalyzer/Core/PathSensitive/MemRegion.h lib/StaticAnalyzer/Core/MemRegion.cpp

2012-12-05 Thread Ted Kremenek
Author: kremenek Date: Thu Dec 6 01:17:13 2012 New Revision: 169479 URL: http://llvm.org/viewvc/llvm-project?rev=169479view=rev Log: Pull logic to map from VarDecl* to captured region using a helper function. WIP. Modified:

[cfe-commits] r169478 - /cfe/trunk/lib/StaticAnalyzer/Checkers/UndefCapturedBlockVarChecker.cpp

2012-12-05 Thread Ted Kremenek
Author: kremenek Date: Thu Dec 6 01:17:04 2012 New Revision: 169478 URL: http://llvm.org/viewvc/llvm-project?rev=169478view=rev Log: Use 'getOriginalRegion()' rather than going through the logic to recreate it. Modified: cfe/trunk/lib/StaticAnalyzer/Checkers/UndefCapturedBlockVarChecker.cpp

[cfe-commits] r169481 - in /cfe/trunk: lib/Analysis/AnalysisDeclContext.cpp test/Analysis/blocks.m

2012-12-05 Thread Ted Kremenek
Author: kremenek Date: Thu Dec 6 01:17:26 2012 New Revision: 169481 URL: http://llvm.org/viewvc/llvm-project?rev=169481view=rev Log: Use the BlockDecl captures list to infer the direct captures for a BlockDataRegion. Fixes rdar://problem/12415065. We still need to do a recursive walk to

  1   2   >