This is a test reply to see whether directly replying to the phab email
still generates multiple mails to some recipients - if you get this email
multiple times, please let me know so I can update the upstream phab bug.
Cheers,
/Manuel
On Thu, Jan 3, 2013 at 4:10 PM, Manuel Klimek
Hello Rafael.
Would you mind to double-check the following change in your commit?
On 11/29/2012 05:09 PM, Rafael Espindola wrote:
Author: rafael
Date: Thu Nov 29 10:09:03 2012
New Revision: 168895
URL: http://llvm.org/viewvc/llvm-project?rev=168895view=rev
Log:
Merge function types in C.
Hi,
LLParser::ParseCmpPredicate has two uses of TokError in a switch which,
currently, fall through so an invalid cmp operand can becomes a valid,
different parse. I don't really understand the big picture of the codeI can fix
that either by doing return TokError(...) or adding a break. Using
Sorry: I'm all over the codebase these days and didn't think about it. This is
an LLVM issue not a clang one, I'll repost there.
From: cfe-commits-boun...@cs.uiuc.edu [cfe-commits-boun...@cs.uiuc.edu] On
Behalf Of David Tweed [david.tw...@arm.com]
Sent:
A different (though very similar) patch has been committed in r171413, so I
think this can be closed?
http://llvm-reviews.chandlerc.com/D218
___
cfe-commits mailing list
cfe-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
On 4 January 2013 05:34, Enea Zaffanella zaffane...@cs.unipr.it wrote:
Hello Rafael.
...
It seems to me that, this way, you are no longer unqualifying the parameter
type. As a consequence, I now see the following:
$ cat bug.c
void foo1(void*);
void foo2(void* const);
void bar() {
LGTM.
On Jan 4, 2013, at 8:18 AM, Rafael Espíndola rafael.espind...@gmail.com wrote:
On 4 January 2013 05:34, Enea Zaffanella zaffane...@cs.unipr.it wrote:
Hello Rafael.
...
It seems to me that, this way, you are no longer unqualifying the parameter
type. As a consequence, I now see the
Author: echristo
Date: Fri Jan 4 11:59:07 2013
New Revision: 171472
URL: http://llvm.org/viewvc/llvm-project?rev=171472view=rev
Log:
Fix fieldNo usage for lambdas. No behavior change since the
field number was 0 anyhow.
Modified:
cfe/trunk/lib/CodeGen/CGDebugInfo.cpp
Modified:
Author: djasper
Date: Fri Jan 4 12:24:12 2013
New Revision: 171480
URL: http://llvm.org/viewvc/llvm-project?rev=171480view=rev
Log:
Handle segfaults in clang-format vim-integration.
A segfault used to clear the entire buffer. With this change, a message
to report a bug is displayed instead.
Committed as r171481.
http://llvm-reviews.chandlerc.com/D251
___
cfe-commits mailing list
cfe-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
Author: dgregor
Date: Fri Jan 4 12:22:19 2013
New Revision: 171478
URL: http://llvm.org/viewvc/llvm-project?rev=171478view=rev
Log:
Remove -Wmodule-build; it was a dumb idea anyway. rdar://problem/12957525
Removed:
cfe/trunk/test/Modules/on-demand-build-warnings.m
Modified:
Author: akirtzidis
Date: Fri Jan 4 12:29:59 2013
New Revision: 171482
URL: http://llvm.org/viewvc/llvm-project?rev=171482view=rev
Log:
[arcmt] Don't error if an autoreleased variable is returned after the
-autorelease.
rdar://12952025
Modified:
Author: akirtzidis
Date: Fri Jan 4 12:30:04 2013
New Revision: 171483
URL: http://llvm.org/viewvc/llvm-project?rev=171483view=rev
Log:
Move the common source locations of CastStmt DefaultStmt into their base
class, SwitchCase.
Modified:
cfe/trunk/include/clang/AST/Stmt.h
Author: akirtzidis
Date: Fri Jan 4 12:30:13 2013
New Revision: 171486
URL: http://llvm.org/viewvc/llvm-project?rev=171486view=rev
Log:
[libclang] Introduce clang_getFileLocation.
Uses of clang_getSpellingLocation should eventually move to calling
clang_getFileLocation, and
Ping.
On Thu, Jan 3, 2013 at 1:28 PM, Matt Beaumont-Gay matthe...@google.com wrote:
I just realized this might seem a little weird, since we'll still give
a -Wunused-value warning for an unused comparison in a macro body.
But, my next patch is going to be suppress all -Wunused-value
warnings
Author: akirtzidis
Date: Fri Jan 4 12:30:08 2013
New Revision: 171484
URL: http://llvm.org/viewvc/llvm-project?rev=171484view=rev
Log:
[arcmt] Adds brackets in case statements that contain initialization of
retaining
variable, thus emitting the switch case is in protected scope error.
Author: akirtzidis
Date: Fri Jan 4 12:30:11 2013
New Revision: 171485
URL: http://llvm.org/viewvc/llvm-project?rev=171485view=rev
Log:
[arcmt] Allow removing an -autorelease of a variable initialized in the
previous statement.
rdar://11074996
Modified:
Author: fjahanian
Date: Fri Jan 4 12:45:40 2013
New Revision: 171492
URL: http://llvm.org/viewvc/llvm-project?rev=171492view=rev
Log:
Fix up various builtin declaration of objc_msgSend families
to match those foung in objc.h an avoid spurious warnings.
// rdar://12489098
Modified:
Author: mren
Date: Fri Jan 4 12:51:35 2013
New Revision: 171493
URL: http://llvm.org/viewvc/llvm-project?rev=171493view=rev
Log:
Debug Info: fix the line location for cleanup code of a block function
The line information was changed when emitting debug information for all the
DeclRefExprs and
Author: dgregor
Date: Fri Jan 4 12:58:28 2013
New Revision: 171497
URL: http://llvm.org/viewvc/llvm-project?rev=171497view=rev
Log:
Add the module name to the 'incomplete umbrella header' warning.
Modified:
cfe/trunk/include/clang/Basic/DiagnosticLexKinds.td
Author: hhinnant
Date: Fri Jan 4 12:58:50 2013
New Revision: 171498
URL: http://llvm.org/viewvc/llvm-project?rev=171498view=rev
Log:
atomic_bool was missing (just a typedef to atomicbool).
Modified:
libcxx/trunk/include/atomic
Author: djasper
Date: Fri Jan 4 12:52:56 2013
New Revision: 171495
URL: http://llvm.org/viewvc/llvm-project?rev=171495view=rev
Log:
Let the formatter ignore UnwrappedLines containing errors.
This prevents code like:
namespace {
class Foo {
Foo(
};
} // comment
from causing segfaults (see
Author: kremenek
Date: Fri Jan 4 13:04:42 2013
New Revision: 171503
URL: http://llvm.org/viewvc/llvm-project?rev=171503view=rev
Log:
Require set-xcode-analyzer to run with Python 2.7 or later.
Addresses LLVM PR 11661.
Modified:
cfe/trunk/tools/scan-build/set-xcode-analyzer
Modified:
Author: kremenek
Date: Fri Jan 4 13:04:47 2013
New Revision: 171505
URL: http://llvm.org/viewvc/llvm-project?rev=171505view=rev
Log:
Update CMakeLists.txt
Modified:
cfe/trunk/lib/ARCMigrate/CMakeLists.txt
Modified: cfe/trunk/lib/ARCMigrate/CMakeLists.txt
URL:
Author: kremenek
Date: Fri Jan 4 13:04:40 2013
New Revision: 171502
URL: http://llvm.org/viewvc/llvm-project?rev=171502view=rev
Log:
NSErrorChecker: remove quoting the parameter name in the diagnostic until we
actually include it's name.
This is a possible regression of moving to using
Author: kremenek
Date: Fri Jan 4 13:04:44 2013
New Revision: 171504
URL: http://llvm.org/viewvc/llvm-project?rev=171504view=rev
Log:
Add __has_feature support to detect if clang supports the explicit atomic
keyword for ObjC properties.
Fixes rdar://problem/12953378.
Modified:
Hi Richard,
Updated patch attached, please take a look. Sorry for the long delay of
reworking this patch.
Michael
On Tue, Dec 18, 2012 at 12:49 AM, Richard Smith rich...@metafoo.co.ukwrote:
Sorry for the delay!
+void Parser::CutAndPasteCode(SourceRange Range,
+
Hi all,
My last commit seems to be making the cmake-clang-x86_64-linux builder choke
(http://bb.pgr.jp/builders/cmake-clang-x86_64-linux). However, I can't
reproduce the failure locally and the compiler error doesn't make any sense to
me. The includes seem to be good. I can only suspect a
On Dec 20, 2012, at 11:25 PM, Saleem Abdulrasool compn...@compnerd.org wrote:
Add a new driver-only option `--supported-targets` which enumerates the
supported targets to stdout. This is an often requested feature, allowing
for a quick inspection of supported target architectures supported
Author: dgregor
Date: Fri Jan 4 13:44:26 2013
New Revision: 171516
URL: http://llvm.org/viewvc/llvm-project?rev=171516view=rev
Log:
realpath'ify the mapping from header includes to module imports.
Modified:
cfe/trunk/lib/Lex/ModuleMap.cpp
Modified: cfe/trunk/lib/Lex/ModuleMap.cpp
URL:
Hello,
LLVM buildbot master could be unavailable from midnight to 6:00AM Pacific
on the 8th January 2013 due repair jobs.
Thanks for understanding.
Thanks
Galina
___
cfe-commits mailing list
cfe-commits@cs.uiuc.edu
On Jan 4, 2013, at 11:41 AM, John McCall rjmcc...@apple.com wrote:
On Dec 20, 2012, at 11:25 PM, Saleem Abdulrasool compn...@compnerd.org
wrote:
Add a new driver-only option `--supported-targets` which enumerates the
supported targets to stdout. This is an often requested feature, allowing
Author: rafael
Date: Fri Jan 4 14:34:32 2013
New Revision: 171519
URL: http://llvm.org/viewvc/llvm-project?rev=171519view=rev
Log:
Unqualify the parameter type.
This fixes a regression from 168895.
Added:
cfe/trunk/test/Sema/implicit-cast-dump.c
Modified:
Hi klimek,
- Turned off -count-only tests as they aren't supported in cpp11-migrate
yet.
- Updated tests to use new binary name and options to access
loop-convert transform.
http://llvm-reviews.chandlerc.com/D263
Files:
test/cpp11-migrate/LoopConvert/Inputs/negative-header.h
Author: rafael
Date: Fri Jan 4 14:41:40 2013
New Revision: 171521
URL: http://llvm.org/viewvc/llvm-project?rev=171521view=rev
Log:
Fix typo. Thanks to dgregor for noticing it.
Modified:
cfe/trunk/lib/AST/Decl.cpp
Modified: cfe/trunk/lib/AST/Decl.cpp
URL:
Author: djasper
Date: Fri Jan 4 14:46:38 2013
New Revision: 171522
URL: http://llvm.org/viewvc/llvm-project?rev=171522view=rev
Log:
Correctly format dereference and address of in array parameters.
Before: InvalidRegions[ R] = 0;
After: InvalidRegions[R] = 0;
This fixes llvm.org/PR14793
Comment at: test/cpp11-migrate/LoopConvert/Inputs/negative-header.h:1
@@ +1,2 @@
+#ifndef _CLANG_TOOLS_EXTRA_H_
+#define _CLANG_TOOLS_EXTRA_H_
This name is reserved.
http://llvm-reviews.chandlerc.com/D263
___
Author: rafael
Date: Fri Jan 4 15:18:45 2013
New Revision: 171532
URL: http://llvm.org/viewvc/llvm-project?rev=171532view=rev
Log:
Style fix: We don't use lowercase-and-underscored template parameter names.
Thanks for dgregor for noticing it.
Modified:
cfe/trunk/lib/AST/Decl.cpp
Modified:
On Fri, Jan 4, 2013 at 12:46 PM, Daniel Jasper djas...@google.com wrote:
Author: djasper
Date: Fri Jan 4 14:46:38 2013
New Revision: 171522
URL: http://llvm.org/viewvc/llvm-project?rev=171522view=rev
Log:
Correctly format dereference and address of in array parameters.
Before:
Do you need to add any new tests to cover the macro body case fully?
What happens when only part of a comparison comes from the macro body? I
wonder if we should suppress the warning if the start and end location come
from different expansions (regardless of argument vs. body). Thoughts
Probably, but I fear we'll need to do a lot more to understand those
initializers .. :-/
On Fri, Jan 4, 2013 at 10:25 PM, Nico Weber tha...@chromium.org wrote:
On Fri, Jan 4, 2013 at 12:46 PM, Daniel Jasper djas...@google.com wrote:
Author: djasper
Date: Fri Jan 4 14:46:38 2013
New
Actually add richard to the CC...
http://llvm-reviews.chandlerc.com/D259
___
cfe-commits mailing list
cfe-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
b) Instead of inlining all the code for CollectRecordStaticVars how about
outlining it into a couple of static functions?
Hmm, yeah the body of that loop is basically if static-member do this; else if
field do that; so factoring out those bits seems reasonable. (The lambda
part, which I
On Thu, Jan 3, 2013 at 11:18 AM, Christopher Berner cber...@fb.com wrote:
I've run into this bug (http://llvm.org/bugs/show_bug.cgi?id=13517), which
seems to be related to the fixme in SemaType.cpp on line 2691.
I believe you mean PR12008, not PR13517 -- PR13517 was originally
about a different
On Fri, Jan 4, 2013 at 11:01 AM, Michael Han fragmentshad...@gmail.com wrote:
Hi Richard,
Updated patch attached, please take a look.
Thanks! Just a couple of small things, then this is ready to go:
- void ParseCXXMemberSpecification(SourceLocation StartLoc, unsigned TagType,
+ void
Author: mcrosier
Date: Fri Jan 4 16:40:33 2013
New Revision: 171545
URL: http://llvm.org/viewvc/llvm-project?rev=171545view=rev
Log:
Fix indent and remove parameter with a matching default value.
Modified:
cfe/trunk/lib/Rewrite/Frontend/RewriteModernObjC.cpp
Author: fjahanian
Date: Fri Jan 4 17:32:24 2013
New Revision: 171555
URL: http://llvm.org/viewvc/llvm-project?rev=171555view=rev
Log:
objective-C arc: in copy helper function for
__strong __block variables, perform objc_storeStrong on
source and destination instead of direct move. This
is done
Author: klimek
Date: Fri Jan 4 17:34:14 2013
New Revision: 171556
URL: http://llvm.org/viewvc/llvm-project?rev=171556view=rev
Log:
Various fixes to clang-format's macro handling.
Some of this is still pretty rough (note the load of FIXMEs), but it is
strictly an improvement and fixes various
On Jan 4, 2013, at 3:32 PM, Fariborz Jahanian fjahan...@apple.com wrote:
Author: fjahanian
Date: Fri Jan 4 17:32:24 2013
New Revision: 171555
URL: http://llvm.org/viewvc/llvm-project?rev=171555view=rev
Log:
objective-C arc: in copy helper function for
__strong __block variables, perform
Author: mren
Date: Fri Jan 4 18:01:42 2013
New Revision: 171564
URL: http://llvm.org/viewvc/llvm-project?rev=171564view=rev
Log:
Fix testing case for Release build (r171493)
rdar://11562117
Modified:
cfe/trunk/test/CodeGenObjC/debug-info-block-line.m
Modified:
Agreed, that makes code cleaner indeed. Attach revised patch.
Michael
On Fri, Jan 4, 2013 at 2:39 PM, Richard Smith rich...@metafoo.co.uk wrote:
On Fri, Jan 4, 2013 at 11:01 AM, Michael Han fragmentshad...@gmail.com
wrote:
Hi Richard,
Updated patch attached, please take a look.
Author: fjahanian
Date: Fri Jan 4 18:32:13 2013
New Revision: 171572
URL: http://llvm.org/viewvc/llvm-project?rev=171572view=rev
Log:
In my last patch initialize the destination to null (with a simple store)
before doing a storeStrong to it.
// rdar://12530881
Modified:
On Jan 4, 2013, at 3:56 PM, John McCall wrote:
On Jan 4, 2013, at 3:32 PM, Fariborz Jahanian fjahan...@apple.com wrote:
Author: fjahanian
Date: Fri Jan 4 17:32:24 2013
New Revision: 171555
URL: http://llvm.org/viewvc/llvm-project?rev=171555view=rev
Log:
objective-C arc: in copy helper
On Jan 4, 2013, at 4:34 PM, Fariborz Jahanian fjahan...@apple.com wrote:
On Jan 4, 2013, at 3:56 PM, John McCall wrote:
On Jan 4, 2013, at 3:32 PM, Fariborz Jahanian fjahan...@apple.com wrote:
Author: fjahanian
Date: Fri Jan 4 17:32:24 2013
New Revision: 171555
URL:
On Jan 4, 2013, at 4:44 PM, John McCall wrote:
On Jan 4, 2013, at 4:34 PM, Fariborz Jahanian fjahan...@apple.com wrote:
On Jan 4, 2013, at 3:56 PM, John McCall wrote:
You need to initialize the destination to null (with a simple store) before
doing a storeStrong to it.
In r171572. This
Author: rafael
Date: Fri Jan 4 19:28:37 2013
New Revision: 171585
URL: http://llvm.org/viewvc/llvm-project?rev=171585view=rev
Log:
Assert that redeclarations have the same linkage.
It is somewhat hard to test linkage, so I decided to try to add an assert. This
already found some interesting
Author: ahatanak
Date: Fri Jan 4 20:04:34 2013
New Revision: 171588
URL: http://llvm.org/viewvc/llvm-project?rev=171588view=rev
Log:
[mips] Fix data layout string. Add 64 to the list of native integer widths
and add stack alignment information.
Added:
This is awesome. Would it be generally useful as a fixit for the protected
scope problem in C++?
Jordan
On Jan 4, 2013, at 10:30 , Argyrios Kyrtzidis akyr...@gmail.com wrote:
Author: akirtzidis
Date: Fri Jan 4 12:30:08 2013
New Revision: 171484
URL:
Author: filcab
Date: Fri Jan 4 12:52:29 2013
New Revision: 171494
URL: http://llvm.org/viewvc/llvm-project?rev=171494view=rev
Log:
Add file added in r171484 to CMakelists.txt.
Modified:
cfe/trunk/lib/ARCMigrate/CMakeLists.txt
Modified: cfe/trunk/lib/ARCMigrate/CMakeLists.txt
URL:
Author: chandlerc
Date: Fri Jan 4 20:57:54 2013
New Revision: 171593
URL: http://llvm.org/viewvc/llvm-project?rev=171593view=rev
Log:
Add a namespace qualifier to the befriending statement for
RecusiveASTVisitor. With Clang and modern GCCs this was found through
the injected class name of the
Hey Galina,
This commit should have fixed the build for one of the clang bots:
http://lab.llvm.org:8011/builders/clang-x86_64-darwin11-self-mingw32/builds/8298
But the bot didn't trigger on this commit. It's now re-running, but due to
a different commit and without showing this commit as one of
-// CHECK: ![[MD1]] = metadata !{i32 83
+// CHECK: ![[MD1]] = metadata !{i32 84
[map dataWithCompletionBlock:^(NSData *data, NSError *error) {
if (data) {
NSString*encoded = [[data compressedData]
encodedString:18];
FWIW this is why putting the check lines
On Fri, Jan 4, 2013 at 1:45 PM, Robinson, Paul paul.robin...@am.sony.comwrote:
b) Instead of inlining all the code for CollectRecordStaticVars
how about outlining it into a couple of static functions?
Hmm, yeah the body of that loop is basically if static-member do this;
else if
Author: dblaikie
Date: Fri Jan 4 23:39:21 2013
New Revision: 171602
URL: http://llvm.org/viewvc/llvm-project?rev=171602view=rev
Log:
FileCheck-ize test/CodeGenCXX/debug-info-method.cpp
Modified:
cfe/trunk/test/CodeGenCXX/debug-info-method.cpp
Modified:
Author: dblaikie
Date: Fri Jan 4 23:48:08 2013
New Revision: 171604
URL: http://llvm.org/viewvc/llvm-project?rev=171604view=rev
Log:
Change test/CodeGenCXX/debug-info-method.cpp an IR (rather than asm) test.
Referring back to the original commit (r115090) which was a frontend only test
I
Author: dblaikie
Date: Fri Jan 4 23:58:35 2013
New Revision: 171605
URL: http://llvm.org/viewvc/llvm-project?rev=171605view=rev
Log:
Emit debug info for unnamed parameters.
LLVM ignores this data for now - patch for that to follow.
Modified:
cfe/trunk/lib/CodeGen/CGDebugInfo.cpp
On Fri, Jan 4, 2013 at 9:48 PM, David Blaikie dblai...@gmail.com wrote:
Author: dblaikie
Date: Fri Jan 4 23:48:08 2013
New Revision: 171604
URL: http://llvm.org/viewvc/llvm-project?rev=171604view=rev
Log:
Change test/CodeGenCXX/debug-info-method.cpp an IR (rather than asm) test.
On Fri, Jan 4, 2013 at 10:05 PM, Chandler Carruth chandl...@google.com wrote:
On Fri, Jan 4, 2013 at 9:48 PM, David Blaikie dblai...@gmail.com wrote:
Author: dblaikie
Date: Fri Jan 4 23:48:08 2013
New Revision: 171604
URL: http://llvm.org/viewvc/llvm-project?rev=171604view=rev
Log:
On Fri, Jan 4, 2013 at 9:33 PM, Eric Christopher echri...@gmail.com wrote:
On Fri, Jan 4, 2013 at 1:45 PM, Robinson, Paul
paul.robin...@am.sony.comwrote:
b) Instead of inlining all the code for CollectRecordStaticVars
how about outlining it into a couple of static functions?
Any ideas how we can make these types of debug info tests
more understandable to future devs? My only idea is copious comments,
but I
feel like having some self-documenting system would be better and I just
don't have any good ideas about what it would look like.
Yeah, I'm not sure what
On Fri, Jan 4, 2013 at 10:23 PM, Eric Christopher echri...@gmail.comwrote:
Any ideas how we can make these types of debug info tests
more understandable to future devs? My only idea is copious comments,
but I
feel like having some self-documenting system would be better and I just
On Fri, Jan 4, 2013 at 10:29 PM, Chandler Carruth chandl...@google.comwrote:
On Fri, Jan 4, 2013 at 10:23 PM, Eric Christopher echri...@gmail.comwrote:
Any ideas how we can make these types of debug info tests
more understandable to future devs? My only idea is copious comments,
but I
On Fri, Jan 4, 2013 at 10:43 PM, Eric Christopher echri...@gmail.comwrote:
On Fri, Jan 4, 2013 at 10:29 PM, Chandler Carruth chandl...@google.comwrote:
On Fri, Jan 4, 2013 at 10:23 PM, Eric Christopher echri...@gmail.comwrote:
Any ideas how we can make these types of debug info tests
Author: kremenek
Date: Sat Jan 5 01:31:54 2013
New Revision: 171607
URL: http://llvm.org/viewvc/llvm-project?rev=171607view=rev
Log:
Fix set-xcode-analyzer to only modify the ExecPath for the analyzer when using
--use-xcode-clang.
Turns out that the ExecPath for the ObjC migrator would also
74 matches
Mail list logo
