Re: Fix build with CLANG_ENABLE_STATIC_ANALYZER

2013-07-04 Thread Stephen Kelly
On 07/03/2013 06:22 PM, Jordan Rose wrote: On Jun 27, 2013, at 2:54 , Stephen Kelly steve...@gmail.com wrote: Jordan Rose wrote: I won't block the patch, and we certainly don't want to leave the CMake build broken, Can someone commit this please? I don't have an svn account. Committed in

[PATCH] Added AlwaysBreakBeforeMultilineStrings option.

2013-07-04 Thread Alexander Kornienko
Hi djasper, Always breaking before multiline strings can help format complex expressions containing multiline strings more consistently, and avoid consuming too much horizontal space. http://llvm-reviews.chandlerc.com/D1097 Files: include/clang/Format/Format.h lib/Format/Format.cpp

Re: [PATCH] Added AlwaysBreakBeforeMultilineStrings option.

2013-07-04 Thread Daniel Jasper
This looks good. When I played around with this idea, the one exception to this might be inline assembler. Do you think we should make an exception for that? http://llvm-reviews.chandlerc.com/D1097 ___ cfe-commits mailing list

Re: [PATCH] Added AlwaysBreakBeforeMultilineStrings option.

2013-07-04 Thread Alexander Kornienko
I have zero experience with gcc-style inline asm, so it would be nice to see an few examples formatted in a good manner. http://llvm-reviews.chandlerc.com/D1097 ___ cfe-commits mailing list cfe-commits@cs.uiuc.edu

Re: [PATCH] Search for gcc in the gcc-cross directory.

2013-07-04 Thread Stephen Kelly
Stephen Kelly wrote: Rebased patch attached. Please apply. Bump. http://thread.gmane.org/gmane.comp.compilers.clang.scm/73551/focus=76120 ___ cfe-commits mailing list cfe-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

Re: [PATCH] Added AlwaysBreakBeforeMultilineStrings option.

2013-07-04 Thread Daniel Jasper
Ok. Then lets just patch this in as is. We can add an exception later. http://llvm-reviews.chandlerc.com/D1097 BRANCH svn ARCANIST PROJECT clang ___ cfe-commits mailing list cfe-commits@cs.uiuc.edu

r185622 - Added AlwaysBreakBeforeMultilineStrings option.

2013-07-04 Thread Alexander Kornienko
Author: alexfh Date: Thu Jul 4 07:02:44 2013 New Revision: 185622 URL: http://llvm.org/viewvc/llvm-project?rev=185622view=rev Log: Added AlwaysBreakBeforeMultilineStrings option. Summary: Always breaking before multiline strings can help format complex expressions containing multiline strings

Re: [PATCH] cpp11-migrate: Fix parsing of '.' for header include/excludes

2013-07-04 Thread Edwin Vane
Committed as r184322. http://llvm-reviews.chandlerc.com/D1004 ___ cfe-commits mailing list cfe-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

r185623 - Use SmallVectorImpl::const_iterator instead of SmallVector to avoid specifying the vector size.

2013-07-04 Thread Craig Topper
Author: ctopper Date: Thu Jul 4 08:11:33 2013 New Revision: 185623 URL: http://llvm.org/viewvc/llvm-project?rev=185623view=rev Log: Use SmallVectorImpl::const_iterator instead of SmallVector to avoid specifying the vector size. Modified: cfe/trunk/include/clang/Sema/Initialization.h

r185628 - Clang has no nested function support. Delete this test.

2013-07-04 Thread Rafael Espindola
Author: rafael Date: Thu Jul 4 09:13:53 2013 New Revision: 185628 URL: http://llvm.org/viewvc/llvm-project?rev=185628view=rev Log: Clang has no nested function support. Delete this test. Removed: cfe/trunk/test/CodeGen/2008-01-11-ChainConsistency.c Removed:

r185629 - Remove old test.

2013-07-04 Thread Rafael Espindola
Author: rafael Date: Thu Jul 4 09:18:32 2013 New Revision: 185629 URL: http://llvm.org/viewvc/llvm-project?rev=185629view=rev Log: Remove old test. It was not clear what was being tested and the test was trivially passing by getting grep confused with tcl quotes. Removed:

r185630 - Remove old test.

2013-07-04 Thread Rafael Espindola
Author: rafael Date: Thu Jul 4 09:20:52 2013 New Revision: 185630 URL: http://llvm.org/viewvc/llvm-project?rev=185630view=rev Log: Remove old test. It was trivially passing because of the tcl quotes and we have better datalayout tests. Removed:

r185634 - Replace void with int to make this a valid C++ file.

2013-07-04 Thread Rafael Espindola
Author: rafael Date: Thu Jul 4 09:25:25 2013 New Revision: 185634 URL: http://llvm.org/viewvc/llvm-project?rev=185634view=rev Log: Replace void with int to make this a valid C++ file. The test was passing because clang would still print the ast before exiting with an error. Since that didn't

r185636 - Remove tcl quotes.

2013-07-04 Thread Rafael Espindola
Author: rafael Date: Thu Jul 4 09:30:41 2013 New Revision: 185636 URL: http://llvm.org/viewvc/llvm-project?rev=185636view=rev Log: Remove tcl quotes. Modified: cfe/trunk/test/CodeGen/2007-05-07-PaddingElements.c Modified: cfe/trunk/test/CodeGen/2007-05-07-PaddingElements.c URL:

r185637 - Use a clang -cc1 option instead of -m32 and remove tcl quotes.

2013-07-04 Thread Rafael Espindola
Author: rafael Date: Thu Jul 4 09:36:22 2013 New Revision: 185637 URL: http://llvm.org/viewvc/llvm-project?rev=185637view=rev Log: Use a clang -cc1 option instead of -m32 and remove tcl quotes. Modified: cfe/trunk/test/CodeGen/2008-03-24-BitField-And-Alloca.c Modified:

r185640 - Fixed typo: NoneComment - NonComment, no other changes.

2013-07-04 Thread Alexander Kornienko
Author: alexfh Date: Thu Jul 4 09:47:51 2013 New Revision: 185640 URL: http://llvm.org/viewvc/llvm-project?rev=185640view=rev Log: Fixed typo: NoneComment - NonComment, no other changes. Modified: cfe/trunk/lib/Format/Format.cpp cfe/trunk/lib/Format/FormatToken.h

r185641 - Remove unused -verify.

2013-07-04 Thread Rafael Espindola
Author: rafael Date: Thu Jul 4 09:51:11 2013 New Revision: 185641 URL: http://llvm.org/viewvc/llvm-project?rev=185641view=rev Log: Remove unused -verify. Modified: cfe/trunk/test/CodeGen/PR5060-align.c Modified: cfe/trunk/test/CodeGen/PR5060-align.c URL:

r185643 - Remove more unused uses of -verify.

2013-07-04 Thread Rafael Espindola
Author: rafael Date: Thu Jul 4 09:58:42 2013 New Revision: 185643 URL: http://llvm.org/viewvc/llvm-project?rev=185643view=rev Log: Remove more unused uses of -verify. Modified: cfe/trunk/test/CodeGenCXX/bitfield.cpp cfe/trunk/test/CodeGenCXX/bool-bitfield.cpp Modified:

r185645 - Convert test to FileCheck.

2013-07-04 Thread Rafael Espindola
Author: rafael Date: Thu Jul 4 10:08:20 2013 New Revision: 185645 URL: http://llvm.org/viewvc/llvm-project?rev=185645view=rev Log: Convert test to FileCheck. Modified: cfe/trunk/test/Preprocessor/x86_target_features.c Modified: cfe/trunk/test/Preprocessor/x86_target_features.c URL:

r185649 - Relax pattern to accept a signext on ppc64.

2013-07-04 Thread Rafael Espindola
Author: rafael Date: Thu Jul 4 10:25:05 2013 New Revision: 185649 URL: http://llvm.org/viewvc/llvm-project?rev=185649view=rev Log: Relax pattern to accept a signext on ppc64. Modified: cfe/trunk/test/CodeGen/2004-11-27-StaticFunctionRedeclare.c Modified:

r185650 - Looks like {{.*}} doesn't match the empty string. Fix test.

2013-07-04 Thread Rafael Espindola
Author: rafael Date: Thu Jul 4 10:29:20 2013 New Revision: 185650 URL: http://llvm.org/viewvc/llvm-project?rev=185650view=rev Log: Looks like {{.*}} doesn't match the empty string. Fix test. Modified: cfe/trunk/test/CodeGen/2004-11-27-StaticFunctionRedeclare.c Modified:

r185653 - Require a shell for this test.

2013-07-04 Thread Rafael Espindola
Author: rafael Date: Thu Jul 4 11:23:44 2013 New Revision: 185653 URL: http://llvm.org/viewvc/llvm-project?rev=185653view=rev Log: Require a shell for this test. Some versions of python will expand the glob used in the test, others wont, causing the test to fail when run with

[libcxx] r185646 - Fix bashism.

2013-07-04 Thread Joerg Sonnenberger
Author: joerg Date: Thu Jul 4 10:11:10 2013 New Revision: 185646 URL: http://llvm.org/viewvc/llvm-project?rev=185646view=rev Log: Fix bashism. Modified: libcxx/trunk/test/testit Modified: libcxx/trunk/test/testit URL:

Re: r185582 - [PowerPC] FreeBSD does not require f128 in its data layout string.

2013-07-04 Thread David Blaikie
On Wed, Jul 3, 2013 at 2:03 PM, Bill Schmidt wschm...@linux.vnet.ibm.com wrote: Author: wschmidt Date: Wed Jul 3 16:03:06 2013 New Revision: 185582 URL: http://llvm.org/viewvc/llvm-project?rev=185582view=rev Log: [PowerPC] FreeBSD does not require f128 in its data layout string. Long

Re: r185584 - Check LongDoubleFormat instead of just Width as this is PowerPC specific.

2013-07-04 Thread David Blaikie
On Wed, Jul 3, 2013 at 2:08 PM, Roman Divacky rdiva...@freebsd.org wrote: Author: rdivacky Date: Wed Jul 3 16:08:41 2013 New Revision: 185584 URL: http://llvm.org/viewvc/llvm-project?rev=185584view=rev Log: Check LongDoubleFormat instead of just Width as this is PowerPC specific. Test

Re: r185584 - Check LongDoubleFormat instead of just Width as this is PowerPC specific.

2013-07-04 Thread Roman Divacky
On Thu, Jul 04, 2013 at 09:50:55AM -0700, David Blaikie wrote: On Wed, Jul 3, 2013 at 2:08 PM, Roman Divacky rdiva...@freebsd.org wrote: Author: rdivacky Date: Wed Jul 3 16:08:41 2013 New Revision: 185584 URL: http://llvm.org/viewvc/llvm-project?rev=185584view=rev Log: Check

Re: r184276 - Debug Info: support for gdwarf-2 gdwarf-3 gdwarf-4

2013-07-04 Thread David Blaikie
On Wed, Jul 3, 2013 at 5:31 PM, Eric Christopher echri...@gmail.com wrote: On Wed, Jul 3, 2013 at 5:24 PM, David Blaikie dblai...@gmail.com wrote: On Jul 2, 2013 5:40 PM, Eric Christopher echri...@gmail.com wrote: I see you went ahead and committed these (the mailing list is down, but I saw

Re: r185635 - Convert test to FileCheck.

2013-07-04 Thread jahanian
On Jul 4, 2013, at 7:28 AM, Rafael Espindola rafael.espind...@gmail.com wrote: Author: rafael Date: Thu Jul 4 09:28:33 2013 New Revision: 185635 URL: http://llvm.org/viewvc/llvm-project?rev=185635view=rev Log: Convert test to FileCheck. Modified:

Re: r185635 - Convert test to FileCheck.

2013-07-04 Thread Rafael EspĂ­ndola
Should be fixed in 185650. On 4 July 2013 13:13, jahanian fjahan...@apple.com wrote: On Jul 4, 2013, at 7:28 AM, Rafael Espindola rafael.espind...@gmail.com wrote: Author: rafael Date: Thu Jul 4 09:28:33 2013 New Revision: 185635 URL:

Re: r185584 - Check LongDoubleFormat instead of just Width as this is PowerPC specific.

2013-07-04 Thread David Blaikie
On Thu, Jul 4, 2013 at 9:54 AM, Roman Divacky rdiva...@freebsd.org wrote: On Thu, Jul 04, 2013 at 09:50:55AM -0700, David Blaikie wrote: On Wed, Jul 3, 2013 at 2:08 PM, Roman Divacky rdiva...@freebsd.org wrote: Author: rdivacky Date: Wed Jul 3 16:08:41 2013 New Revision: 185584 URL:

[clang-tools-extra] r185660 - cpp11-migrate: Minor command-line fixes and improvements

2013-07-04 Thread Edwin Vane
Author: revane Date: Thu Jul 4 12:49:59 2013 New Revision: 185660 URL: http://llvm.org/viewvc/llvm-project?rev=185660view=rev Log: cpp11-migrate: Minor command-line fixes and improvements * all transforms are in the same category * all transforms' options are in the same category * display the

Re: [PATCH] cpp11-migrate: Minor command-line fixes and improvements

2013-07-04 Thread Edwin Vane
Committed as r185660. http://llvm-reviews.chandlerc.com/D1085 ___ cfe-commits mailing list cfe-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

[PATCH] cpp11-migrate: Fix some headers and other coding style issues.

2013-07-04 Thread Guillaume Papin
Hi revane, While reading the Core code I saw a few headers missing and some other things, here are the changes I made: - some headers were missing in Core for the .cpp files - some headers were included but not necessary - the CMakeLists.txt linked support for no apparent reason since it's

Re: [PATCH] cpp11-migrate: Fix some headers and other coding style issues.

2013-07-04 Thread Edwin Vane
Since you're shortening some header guards here. Shorten them all across the project. See CM-82. Comment at: cpp11-migrate/Core/Transforms.h:17 @@ -16,2 +16,3 @@ + #ifndef LLVM_TOOLS_CLANG_TOOLS_EXTRA_CPP11_MIGRATE_TRANSFORMS_H #define

[libcxx] r185665 - Simplify comparators of [unordered_][multi]map. This fixes http://llvm.org/bugs/show_bug.cgi?id=16538

2013-07-04 Thread Howard Hinnant
Author: hhinnant Date: Thu Jul 4 14:46:35 2013 New Revision: 185665 URL: http://llvm.org/viewvc/llvm-project?rev=185665view=rev Log: Simplify comparators of [unordered_][multi]map. This fixes http://llvm.org/bugs/show_bug.cgi?id=16538 Added:

Re: r185582 - [PowerPC] FreeBSD does not require f128 in its data layout string.

2013-07-04 Thread Bill Schmidt
On Thu, 2013-07-04 at 09:50 -0700, David Blaikie wrote: On Wed, Jul 3, 2013 at 2:03 PM, Bill Schmidt wschm...@linux.vnet.ibm.com wrote: Author: wschmidt Date: Wed Jul 3 16:03:06 2013 New Revision: 185582 URL: http://llvm.org/viewvc/llvm-project?rev=185582view=rev Log: [PowerPC]

[libcxx] r185666 - Removed extension in [unordered_][multi]map which allowed one to emplace using just an argument for the key, as opposed to using piecewise_construct. However a bug report exposed th

2013-07-04 Thread Howard Hinnant
Author: hhinnant Date: Thu Jul 4 15:59:16 2013 New Revision: 185666 URL: http://llvm.org/viewvc/llvm-project?rev=185666view=rev Log: Removed extension in [unordered_][multi]map which allowed one to emplace using just an argument for the key, as opposed to using piecewise_construct. However a

Re: patch: add readonly argument attribute

2013-07-04 Thread Chris Lattner
Hi Nick, here's a quick concept review: On Jul 3, 2013, at 9:27 PM, Nick Lewycky nlewy...@google.com wrote: The attached patch implements support for 'readonly' and 'readnone' on individual pointer-typed attributes. The llvm memcpy/memmove intrinsics are given readonly on their source

r185668 - Add test for r185584.

2013-07-04 Thread Roman Divacky
Author: rdivacky Date: Thu Jul 4 16:29:24 2013 New Revision: 185668 URL: http://llvm.org/viewvc/llvm-project?rev=185668view=rev Log: Add test for r185584. Modified: cfe/trunk/test/Sema/attr-mode.c Modified: cfe/trunk/test/Sema/attr-mode.c URL:

r185672 - Minor documentation cleanup

2013-07-04 Thread James Dennett
Author: jdennett Date: Thu Jul 4 17:14:20 2013 New Revision: 185672 URL: http://llvm.org/viewvc/llvm-project?rev=185672view=rev Log: Minor documentation cleanup Modified: cfe/trunk/include/clang/Basic/DiagnosticIDs.h Modified: cfe/trunk/include/clang/Basic/DiagnosticIDs.h URL:

r185674 - Add some more documentation on how to navigate from a LambdaExpr::Capture

2013-07-04 Thread James Dennett
Author: jdennett Date: Thu Jul 4 17:15:44 2013 New Revision: 185674 URL: http://llvm.org/viewvc/llvm-project?rev=185674view=rev Log: Add some more documentation on how to navigate from a LambdaExpr::Capture to the associated FieldDecl. Modified: cfe/trunk/include/clang/AST/DeclCXX.h

r185679 - Use the new --crash option in commands that are expected to crash.

2013-07-04 Thread Rafael Espindola
Author: rafael Date: Thu Jul 4 21:53:30 2013 New Revision: 185679 URL: http://llvm.org/viewvc/llvm-project?rev=185679view=rev Log: Use the new --crash option in commands that are expected to crash. Modified: cfe/trunk/test/PCH/badpch.c cfe/trunk/test/Parser/crash-report.c Modified:

r185682 - Add typedefs for Densemaps containing SmallVectors to avoid repeating the SmallVector size when creating iterators for the DenseMap.

2013-07-04 Thread Craig Topper
Author: ctopper Date: Thu Jul 4 23:33:53 2013 New Revision: 185682 URL: http://llvm.org/viewvc/llvm-project?rev=185682view=rev Log: Add typedefs for Densemaps containing SmallVectors to avoid repeating the SmallVector size when creating iterators for the DenseMap. Modified:

r185683 - Use typedef for Densemap contraining SmallVector passed to a function to avoid repeating SmallVector size.

2013-07-04 Thread Craig Topper
Author: ctopper Date: Thu Jul 4 23:43:31 2013 New Revision: 185683 URL: http://llvm.org/viewvc/llvm-project?rev=185683view=rev Log: Use typedef for Densemap contraining SmallVector passed to a function to avoid repeating SmallVector size. Modified: cfe/trunk/lib/Serialization/ASTReader.cpp