Author: enea
Date: Thu Nov 7 02:14:26 2013
New Revision: 194197
URL: http://llvm.org/viewvc/llvm-project?rev=194197view=rev
Log:
Fixed bug in return type of __builtin_va_start().
Modified:
cfe/trunk/lib/Sema/SemaChecking.cpp
cfe/trunk/test/Sema/varargs.c
Modified:
Author: sylvestre
Date: Thu Nov 7 03:31:30 2013
New Revision: 194198
URL: http://llvm.org/viewvc/llvm-project?rev=194198view=rev
Log:
Ubuntu has published its Saucy release. 'Trusty Tahr' dev has just started. Add
its support in Clang
Modified:
cfe/trunk/lib/Driver/ToolChains.cpp
2013/11/6 Rafael Espíndola rafael.espind...@gmail.com:
On 6 November 2013 09:32, Rafael Espíndola rafael.espind...@gmail.com wrote:
Here we go:
-
templatetypename T class A {
~A() {}
};
template class Achar;
-
I can reproduce it. Debugging.
Fixed in r194158. None of the
2013/11/7 Timur Iskhodzhanov timur...@google.com:
2013/11/6 Rafael Espíndola rafael.espind...@gmail.com:
On 6 November 2013 09:32, Rafael Espíndola rafael.espind...@gmail.com
wrote:
Here we go:
-
templatetypename T class A {
~A() {}
};
template class Achar;
-
I can
Hi,
Haven't received any comments yet on this check. Is anyone available to review
it?.
Best regards,
Per
...
Hello,
The patch adds a check that warns for relational
I don't have any strong opinions of where to place the check. I will place it
where you feel is the best place for it.
I think I would be good if CFG could use it at least as it already has some
checks to see if an expression always evaluates to true/false.
//Anders
From: Anna Zaks
Author: d0k
Date: Thu Nov 7 05:03:53 2013
New Revision: 194200
URL: http://llvm.org/viewvc/llvm-project?rev=194200view=rev
Log:
Add parens for || in in assert. No functionality change.
Modified:
cfe/trunk/lib/Sema/SemaExpr.cpp
Modified: cfe/trunk/lib/Sema/SemaExpr.cpp
URL:
I'm not very sure about the GenerateVirtualMemPtrThunk code.
It's probably mostly copied from other similar functions, but it's a bit hard
to reason about its correctness without firsthand knowledge of why each line is
required.
Can you tell what was function you've used as a reference
Author: timu
Date: Thu Nov 7 07:34:02 2013
New Revision: 194202
URL: http://llvm.org/viewvc/llvm-project?rev=194202view=rev
Log:
Minor refinement of VTableBuilder.h: fix wrong indentation, rename a struct
field with a more appropriate name
Modified:
Author: djasper
Date: Thu Nov 7 08:02:28 2013
New Revision: 194204
URL: http://llvm.org/viewvc/llvm-project?rev=194204view=rev
Log:
clang-format: Fix corner case for brace alignment.
Before:
Constructor::Constructor()
: some_value{ //
aaa //
} {}
After:
Hi rnk,
This addresses the post-commit comments on r194082.
http://llvm-reviews.chandlerc.com/D2120
Files:
include/clang/AST/RecordLayout.h
lib/AST/RecordLayout.cpp
lib/AST/RecordLayoutBuilder.cpp
lib/AST/VTableBuilder.cpp
Index: include/clang/AST/RecordLayout.h
Ah, I see.
This turned out to be easier than I thought, so here we go:
http://llvm-reviews.chandlerc.com/D2120
2013/11/5 Reid Kleckner r...@google.com:
Comment at: lib/AST/VTableBuilder.cpp:3314-3316
@@ +3313,5 @@
+const ASTRecordLayout BaseLayout =
Hi Eric,
Some of the main reasons (there may be more I'm overlooking) for using this
scheme is consistency with the existing ARM backend for end users. From our
perspective, -march should be restricted to actual architectures, and not
one specific implementation. A pragmatic addition is that
Comment at: lib/ASTMatchers/ASTMatchFinder.cpp:819
@@ +818,3 @@
+return true;
+ } else if (NodeMatch.canConvertToQualType()) {
+addMatcher(NodeMatch.convertToQualType(), Action);
Does canConvertToQualType return true for Type matchers? Otherwise I think
Hi Faisal,
+void LambdaScopeInfo::getPotentialVariableCapture(unsigned Idx, VarDecl
*VD, Expr *E) {
+ assert((Idx = 0 Idx getNumPotentialVariableCaptures())
+Index of potential capture must be within 0 to less than the
+number of captures!);
Idx will always be = 0 since it's
Author: faisalv
Date: Thu Nov 7 10:57:56 2013
New Revision: 194206
URL: http://llvm.org/viewvc/llvm-project?rev=194206view=rev
Log:
Remove an unnecessary condition that I added hastily: Unsigned numbers are
obviously = 0 ;)
Also - others have complained about some white space issues - sorry
Author: hhinnant
Date: Thu Nov 7 11:15:51 2013
New Revision: 194207
URL: http://llvm.org/viewvc/llvm-project?rev=194207view=rev
Log:
Tell libc++abi whether or not libc++ has declared bad_array_length.
Modified:
libcxx/trunk/include/new
Modified: libcxx/trunk/include/new
URL:
Author: hhinnant
Date: Thu Nov 7 11:16:37 2013
New Revision: 194208
URL: http://llvm.org/viewvc/llvm-project?rev=194208view=rev
Log:
If libc++ has not declared bad_array_length, then declare it here just so that
it gets into the binary.
Modified:
libcxxabi/trunk/src/cxa_new_delete.cpp
Author: djasper
Date: Thu Nov 7 11:43:07 2013
New Revision: 194209
URL: http://llvm.org/viewvc/llvm-project?rev=194209view=rev
Log:
clang-format: Remove old hack that mainly made incorrect tests pass.
As a side-effect, constructors definitions will correctly be recognized
and formatted as
Author: djasper
Date: Thu Nov 7 11:52:51 2013
New Revision: 194210
URL: http://llvm.org/viewvc/llvm-project?rev=194210view=rev
Log:
clang-format: Improve formatting of constructor initializers.
Before:
Constructor()
: aaa(a(,
Author: rbarton
Date: Thu Nov 7 12:05:57 2013
New Revision: 194211
URL: http://llvm.org/viewvc/llvm-project?rev=194211view=rev
Log:
XFAIL the test for non-x86 targets for which this message cannot be generated.
Modified:
cfe/trunk/test/Index/ms-asm-no-target.cpp
Modified:
Hi all
[Adding Alp - didn't realise he was missed off my original mail.]
Looking at the code in lib/Parse/ParseStmt.cpp it looks as though this test
can only be expected to pass when targeting x86 or x86_64. Any other
architecture emits the Unsupported architecture 'aarch64' for MS-style
inline
Hi gribozavr,
This allows compilation database implementations for
distributed build systems to hand all data to the client to make
parsing independent of the file system.
http://llvm-reviews.chandlerc.com/D2121
Files:
include/clang-c/CXCompilationDatabase.h
Author: chris.wailes
Date: Thu Nov 7 12:35:18 2013
New Revision: 194212
URL: http://llvm.org/viewvc/llvm-project?rev=194212view=rev
Log:
Added a test case for the fix to bug 17632 in r193751
Modified:
cfe/trunk/test/SemaCXX/warn-consumed-analysis.cpp
Modified:
Author: rsmith
Date: Thu Nov 7 12:45:03 2013
New Revision: 194213
URL: http://llvm.org/viewvc/llvm-project?rev=194213view=rev
Log:
PR17615: A delegating constructor initializer is a full-expression. Don't
forget to clean up temporaries at the end of it.
Modified:
On Wed, Nov 6, 2013 at 7:39 AM, Alp Toker a...@nuanti.com wrote:
On 06/11/2013 14:55, Anthony Scopatz wrote:
Hello All,
Could we please hear some response on this? Thanks!
Hello Anthony, Geoffrey,
Thanks for the contribution.
You'll need to rebase this work against current SVN, add at
LG
Comment at: lib/ASTMatchers/ASTMatchFinder.cpp:758-762
@@ -757,7 +757,7 @@
}
Visitor.set_active_ast_context(Context);
Visitor.onStartOfTranslationUnit();
Visitor.TraverseDecl(Context.getTranslationUnitDecl());
Visitor.onEndOfTranslationUnit();
Author: djasper
Date: Thu Nov 7 13:23:49 2013
New Revision: 194214
URL: http://llvm.org/viewvc/llvm-project?rev=194214view=rev
Log:
clang-format: Improve ObjC variadic and binary expression parameters.
Before:
[self aaa:aaa | aaa | aaa |
Author: rsmith
Date: Thu Nov 7 13:26:14 2013
New Revision: 194215
URL: http://llvm.org/viewvc/llvm-project?rev=194215view=rev
Log:
Tests for CWG issue 165-170.
Modified:
cfe/trunk/test/CXX/drs/dr1xx.cpp
cfe/trunk/www/cxx_dr_status.html
Modified: cfe/trunk/test/CXX/drs/dr1xx.cpp
URL:
Thanks, LGTM!
Comment at: include/clang/AST/RecordLayout.h:263
@@ -258,3 +262,3 @@
assert(CXXInfo Record layout does not have C++ specific info!);
return CXXInfo-HasOwnVBPtr;
}
This can be hasVBPtr() !BaseSharingVBPtr.
Comment
Author: djasper
Date: Thu Nov 7 13:56:07 2013
New Revision: 194216
URL: http://llvm.org/viewvc/llvm-project?rev=194216view=rev
Log:
clang-format: Improve binary operator detection in macros.
Before:
#define M(NAME) assert(!Context.Verifying #NAME);
After:
#define M(NAME)
Author: rsmith
Date: Thu Nov 7 14:07:17 2013
New Revision: 194217
URL: http://llvm.org/viewvc/llvm-project?rev=194217view=rev
Log:
PR17800: When performing pack expansion, we must always rebuild the AST nodes
to avoid breaking AST invariants by reusing Stmt nodes within the same
function.
Comment at: lib/ASTMatchers/ASTMatchFinder.cpp:819
@@ +818,3 @@
+return true;
+ } else if (NodeMatch.canConvertToQualType()) {
+addMatcher(NodeMatch.convertToQualType(), Action);
Manuel Klimek wrote:
Does canConvertToQualType return true for Type
lg
http://llvm-reviews.chandlerc.com/D2114
BRANCH
clangquery4
ARCANIST PROJECT
clang
___
cfe-commits mailing list
cfe-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
On Thu, Nov 7, 2013 at 6:47 AM, Amara Emerson amara.emer...@arm.com wrote:
Hi Eric,
Some of the main reasons (there may be more I’m overlooking) for using
this scheme is consistency with the existing ARM backend for end users.
From our perspective, -march should be restricted to actual
Richard,
Thanks for the review feedback!
Here's an alternate version that better handles cases (such as the example
you gave) where the code is actually valid without the - or being
changed to -, by only trying the correction if an error diagnostic would
have been emitted. It is similar to what
Author: pcc
Date: Thu Nov 7 16:30:36 2013
New Revision: 194223
URL: http://llvm.org/viewvc/llvm-project?rev=194223view=rev
Log:
Introduce MatchFinder::matchAST.
Differential Revision: http://llvm-reviews.chandlerc.com/D2115
Modified:
cfe/trunk/include/clang/ASTMatchers/ASTMatchFinder.h
Author: pcc
Date: Thu Nov 7 16:30:32 2013
New Revision: 194222
URL: http://llvm.org/viewvc/llvm-project?rev=194222view=rev
Log:
Re-introduce MatchFinder::addDynamicMatcher.
Differential Revision: http://llvm-reviews.chandlerc.com/D2114
Modified:
Closed by commit rL194222 (authored by @pcc).
CHANGED PRIOR TO COMMIT
http://llvm-reviews.chandlerc.com/D2114?vs=5387id=5402#toc
http://llvm-reviews.chandlerc.com/D2114
COMMIT
http://llvm-reviews.chandlerc.com/rL194222
___
cfe-commits mailing
Closed by commit rL194223 (authored by @pcc).
CHANGED PRIOR TO COMMIT
http://llvm-reviews.chandlerc.com/D2115?vs=5388id=5403#toc
http://llvm-reviews.chandlerc.com/D2115
COMMIT
http://llvm-reviews.chandlerc.com/rL194223
___
cfe-commits mailing
Author: dgregor
Date: Thu Nov 7 16:34:54 2013
New Revision: 194224
URL: http://llvm.org/viewvc/llvm-project?rev=194224view=rev
Log:
Re-instate contextual conversion to Objective-C pointers in message sends.
When performing an Objective-C message send to a value of class type,
perform a
Author: dgregor
Date: Thu Nov 7 16:55:02 2013
New Revision: 194225
URL: http://llvm.org/viewvc/llvm-project?rev=194225view=rev
Log:
Modules: Teach the preprocessor to recognize 'import' only after an '@'.
The preprocessor currently recognizes module declarations to load a
module based on seeing
Awesome, thanks! PR16185 comment 2 isn't quite perfect yet though as far as
I can tell.
In a block, I get (I deleted some characters from the function names):
{
popup_wdow_.reset(
[[RenderWidgetPopupWindow alloc] iniithContentRect:NSMakRet(
origin_global.x, origin_global.y,
Author: klimek
Date: Thu Nov 7 17:18:05 2013
New Revision: 194226
URL: http://llvm.org/viewvc/llvm-project?rev=194226view=rev
Log:
Adds the ability to inject a DiagnosticConsumer into ClangTools.
Modified:
cfe/trunk/include/clang/Tooling/Tooling.h
cfe/trunk/lib/Tooling/Tooling.cpp
Produces neater IR in significantly less time.
(~18% faster -O0 compile time for sqlite3 with -fsanitize=undefined)
-
Patch attached, both of these were marked as FIXME's previously.
Okay to commit?
~Will
From eb61ff9d5f83be6d828ed0769732bb06d8478a19 Mon Sep 17 00:00:00 2001
From: Will
Closed by commit rL194227 (authored by @pcc).
CHANGED PRIOR TO COMMIT
http://llvm-reviews.chandlerc.com/D2098?vs=5389id=5404#toc
http://llvm-reviews.chandlerc.com/D2098
COMMIT
http://llvm-reviews.chandlerc.com/rL194227
___
cfe-commits mailing
Author: pcc
Date: Thu Nov 7 18:08:23 2013
New Revision: 194227
URL: http://llvm.org/viewvc/llvm-project?rev=194227view=rev
Log:
Introduce clang-query tool.
This tool is for interactive exploration of the Clang AST using AST matchers.
It currently allows the user to enter a matcher at an
Author: dgregor
Date: Thu Nov 7 18:38:03 2013
New Revision: 194228
URL: http://llvm.org/viewvc/llvm-project?rev=194228view=rev
Log:
Eliminate an unnecessary .c_str()
Modified:
cfe/trunk/lib/Frontend/CompilerInvocation.cpp
Modified: cfe/trunk/lib/Frontend/CompilerInvocation.cpp
URL:
Looks like this is unnecessary and was actually only temporarily
broken by r193528, which was reverted quickly and fixed shortly
thereafter in r193554 and others.
AFAICT --no-add-needed is not used by default, so it seems the
default handling for an unknown target is appropriate.
Thanks for the
Author: djasper
Date: Thu Nov 7 18:57:11 2013
New Revision: 194229
URL: http://llvm.org/viewvc/llvm-project?rev=194229view=rev
Log:
clang-format: Make breaking before ternary operators configurable.
Modified:
cfe/trunk/include/clang/Format/Format.h
On Thu, Nov 7, 2013 at 3:34 PM, Will Dietz wdie...@illinois.edu wrote:
Produces neater IR in significantly less time.
(~18% faster -O0 compile time for sqlite3 with -fsanitize=undefined)
-
Patch attached, both of these were marked as FIXME's previously.
Okay to commit?
Yes, thank
Author: pcc
Date: Thu Nov 7 19:08:12 2013
New Revision: 194230
URL: http://llvm.org/viewvc/llvm-project?rev=194230view=rev
Log:
Silence GCC warning.
Modified:
clang-tools-extra/trunk/clang-query/QueryParser.cpp
Modified: clang-tools-extra/trunk/clang-query/QueryParser.cpp
URL:
Author: wdietz2
Date: Thu Nov 7 19:09:22 2013
New Revision: 194231
URL: http://llvm.org/viewvc/llvm-project?rev=194231view=rev
Log:
ubsan: Only emit constants for filenames and type descriptors once.
Produces neater IR in significantly less time.
(~18% faster -O0 compile time for sqlite3 with
My pleasure :).
r194231, thanks!
~Will
On Thu, Nov 7, 2013 at 7:07 PM, Richard Smith rich...@metafoo.co.uk wrote:
On Thu, Nov 7, 2013 at 3:34 PM, Will Dietz wdie...@illinois.edu wrote:
Produces neater IR in significantly less time.
(~18% faster -O0 compile time for sqlite3 with
On Thu, Nov 07, 2013 at 11:18:05PM -, Manuel Klimek wrote:
+TEST(ClangToolTest, InjectDiagnosticConsumer) {
+ FixedCompilationDatabase Compilations(/, std::vectorstd::string());
+ ClangTool Tool(Compilations, std::vectorstd::string(1, /a.cc));
+ Tool.mapVirtualFile(/a.cc, int x =
Author: fjahanian
Date: Thu Nov 7 19:15:17 2013
New Revision: 194233
URL: http://llvm.org/viewvc/llvm-project?rev=194233view=rev
Log:
ObjectiveC migrator. Fixes an obscure bug where
NS_RETURNS_INNER_POINTER ends up unintentionally
on the @property under -objcmt-migrate-all
// rdar://15396636
Author: jrose
Date: Thu Nov 7 19:15:30 2013
New Revision: 194234
URL: http://llvm.org/viewvc/llvm-project?rev=194234view=rev
Log:
[analyzer] Specialize loop executed 0 times for for-in and for-range loops.
The path note that says Loop body executed 0 times has been changed to
Loop body skipped
Author: jrose
Date: Thu Nov 7 19:15:39 2013
New Revision: 194236
URL: http://llvm.org/viewvc/llvm-project?rev=194236view=rev
Log:
[analyzer] Add IdenticalExprChecker, to find copy-pasted code.
This syntactic checker looks for expressions on both sides of comparison
operators that are
Author: jrose
Date: Thu Nov 7 19:15:35 2013
New Revision: 194235
URL: http://llvm.org/viewvc/llvm-project?rev=194235view=rev
Log:
[analyzer] Track whether an ObjC for-in loop had zero iterations.
An Objective-C for-in loop will have zero iterations if the collection is
empty. Previously, we
Author: dgregor
Date: Thu Nov 7 19:20:25 2013
New Revision: 194237
URL: http://llvm.org/viewvc/llvm-project?rev=194237view=rev
Log:
Fix a bogus assert I introduced in r194224
Modified:
cfe/trunk/lib/Sema/SemaOverload.cpp
Modified: cfe/trunk/lib/Sema/SemaOverload.cpp
URL:
Author: fjahanian
Date: Thu Nov 7 20:00:22 2013
New Revision: 194238
URL: http://llvm.org/viewvc/llvm-project?rev=194238view=rev
Log:
ObjectiveC migrator. Added a dropped check in my
last patch.
Modified:
cfe/trunk/lib/ARCMigrate/ObjCMT.cpp
Modified: cfe/trunk/lib/ARCMigrate/ObjCMT.cpp
Author: dgregor
Date: Thu Nov 7 20:04:24 2013
New Revision: 194239
URL: http://llvm.org/viewvc/llvm-project?rev=194239view=rev
Log:
Objective-C++ ARC: Improve the conversion to a const __unsafe_unretained
reference.
Under ARC++, a reference to a const Objective-C pointer is implicitly
treated
Author: rsmith
Date: Thu Nov 7 20:05:54 2013
New Revision: 194240
URL: http://llvm.org/viewvc/llvm-project?rev=194240view=rev
Log:
Tests for core issue 170-200.
Added:
cfe/trunk/test/CXX/drs/dr2xx.cpp
Modified:
cfe/trunk/test/CXX/drs/dr1xx.cpp
cfe/trunk/www/cxx_dr_status.html
Author: djasper
Date: Thu Nov 7 20:08:01 2013
New Revision: 194241
URL: http://llvm.org/viewvc/llvm-project?rev=194241view=rev
Log:
clang-format: Properly indent ObjC calls wrapped before first selector
Before:
[self // break
a:a
aa:aa
a:aaa];
After:
[self // break
Author: dgregor
Date: Thu Nov 7 20:16:10 2013
New Revision: 194242
URL: http://llvm.org/viewvc/llvm-project?rev=194242view=rev
Log:
s/DebugPrint/dump/g
Modified:
cfe/trunk/include/clang/Sema/Overload.h
cfe/trunk/lib/Sema/SemaInit.cpp
cfe/trunk/lib/Sema/SemaOverload.cpp
Modified:
Author: majnemer
Date: Thu Nov 7 21:06:45 2013
New Revision: 194243
URL: http://llvm.org/viewvc/llvm-project?rev=194243view=rev
Log:
Fix tests effected by r194221
GEP expressions were folded differently from before, change the tests to
reflect this.
Modified:
Author: chapuni
Date: Thu Nov 7 22:00:53 2013
New Revision: 194244
URL: http://llvm.org/viewvc/llvm-project?rev=194244view=rev
Log:
StaticAnalyzer/Checkers/BasicObjCFoundationChecks.cpp: Tweak
ContainerNonEmptyMap with int instead of bool, to appease building since
r194235.
In
Jordan, seems it had not been built on trunk.
Please see my tweak, in r194244.
2013/11/8 Jordan Rose jordan_r...@apple.com:
Author: jrose
Date: Thu Nov 7 19:15:35 2013
New Revision: 194235
URL: http://llvm.org/viewvc/llvm-project?rev=194235view=rev
Log:
[analyzer] Track whether an ObjC
On 07/11/2013 18:10, Richard Barton wrote:
Hi all
[Adding Alp - didn't realise he was missed off my original mail.]
Looking at the code in lib/Parse/ParseStmt.cpp it looks as though this test
can only be expected to pass when targeting x86 or x86_64. Any other
architecture emits the
Author: chapuni
Date: Thu Nov 7 23:16:50 2013
New Revision: 194246
URL: http://llvm.org/viewvc/llvm-project?rev=194246view=rev
Log:
clang/test/CXX/drs/dr1xx.cpp: Add explicit triple x86_64-unknown-unknown to
satisfy check7a and check8a since r194240.
For i686 targets and LLP64 targets, we can
Author: chapuni
Date: Fri Nov 8 00:29:09 2013
New Revision: 194247
URL: http://llvm.org/viewvc/llvm-project?rev=194247view=rev
Log:
clang-query: Unbreak msvc.
Modified:
clang-tools-extra/trunk/clang-query/Query.cpp
Modified: clang-tools-extra/trunk/clang-query/Query.cpp
URL:
Ah, so sorry everyone! I have a local specialization of ImutProfileInfobool,
but forgot to commit it. I'll double-check it and merge tomorrow. Thanks,
Takumi.
Jordan
On Nov 7, 2013, at 20:09 , NAKAMURA Takumi geek4ci...@gmail.com wrote:
Jordan, seems it had not been built on trunk.
Please
Author: djasper
Date: Fri Nov 8 00:45:35 2013
New Revision: 194248
URL: http://llvm.org/viewvc/llvm-project?rev=194248view=rev
Log:
Add .clang-format without column limit to subdirectory tests/.
A column limit in the test folder can lead to trouble as the RUN, CHECK,
etc. comments can
Author: alp
Date: Fri Nov 8 00:50:48 2013
New Revision: 194249
URL: http://llvm.org/viewvc/llvm-project?rev=194249view=rev
Log:
Improve the missing ASM parser test for MS-style assembly
It's better to test clang-check rather than the internal c-index-test utility.
Also adds a target so we can
Richard,
I've replaced this with a better test in r194249.
Please keep an eye on this, let's see if it works everywhere.
Alp.
On 08/11/2013 04:16, Alp Toker wrote:
On 07/11/2013 18:10, Richard Barton wrote:
Hi all
[Adding Alp - didn't realise he was missed off my original mail.]
Looking
On Wed, Nov 6, 2013 at 5:10 AM, David Majnemer david.majne...@gmail.comwrote:
From my experience,
`SkipUntil(EndKind, /*StopAtSemi=*/true, /*DontConsume=*/true);`
is more typical in clang than
`SkipUntil(EndKind, StopAtSemi | DontConsume);`
It seems that some of the calls that
Dont without the apostrophe reads more like Donut than anything else.
I know it was like that before your patch, but let's go with
s/DontConsume/NoConsume/g
Otherwise this patch is starting to look seriously good :-)
Alp.
On 08/11/2013 06:17, Alexey Bataev wrote:
Fixes after Richard Smith
On Thu, Nov 7, 2013 at 11:23 PM, Alp Toker a...@nuanti.com wrote:
Dont without the apostrophe reads more like Donut than anything else.
I know it was like that before your patch, but let's go with
s/DontConsume/NoConsume/g
Maybe even StopBeforeMatch?
... and that makes it a bit more
78 matches
Mail list logo
