Author: kcc
Date: Mon May 12 02:05:16 2014
New Revision: 208521
URL: http://llvm.org/viewvc/llvm-project?rev=208521view=rev
Log:
disable asan's detect_stack_use_after_return when running CXX/drs/dr4xx.cpp
(temporary workaround for PR19722); This should make the asan bootstrap bot
green again
Author: atanasyan
Date: Mon May 12 02:37:51 2014
New Revision: 208523
URL: http://llvm.org/viewvc/llvm-project?rev=208523view=rev
Log:
[Driver] Do not lose already detected set of toolchain's multilibs while
iterating over different library path suffixes and different library versions.
To find
Thanks for review.
Closed by commit rL208523 (authored by @atanasyan)
http://reviews.llvm.org/D3684
___
cfe-commits mailing list
cfe-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
Patch solves a problem for me.
http://reviews.llvm.org/D3684
___
cfe-commits mailing list
cfe-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
Author: chapuni
Date: Mon May 12 05:16:20 2014
New Revision: 208532
URL: http://llvm.org/viewvc/llvm-project?rev=208532view=rev
Log:
clang/test/CXX/drs/dr4xx.cpp: Use env(1) to satisfy lit internal runner.
Modified:
cfe/trunk/test/CXX/drs/dr4xx.cpp
Modified: cfe/trunk/test/CXX/drs/dr4xx.cpp
On Thu, May 8, 2014 at 6:14 PM, Marshall Clow mclow.li...@gmail.com
mailto:mclow.li...@gmail.com wrote:
(...)
@@ -1535,6 +1582,7 @@ vector_Tp, _Allocator::push_back(const
{
if (this-__end_ != this-__end_cap())
{
+__annotate_increase(1);
Do you have a test that demonstrates that? That would be very helpful.
On Mon, May 12, 2014 at 3:12 PM, Stephan Tolksdorf s...@quanttec.com wrote:
On Thu, May 8, 2014 at 6:14 PM, Marshall Clow mclow.li...@gmail.com
mailto:mclow.li...@gmail.com wrote:
(...)
@@ -1535,6 +1582,7 @@
Author: djasper
Date: Mon May 12 06:29:50 2014
New Revision: 208539
URL: http://llvm.org/viewvc/llvm-project?rev=208539view=rev
Log:
clang-format: [JS] Basic support for escape sequences in regex literals.
Before:
var regex = /\\/ g; // This isn't even recognized as regex.
After:
var regex
On 12.05.14 13:13, Kostya Serebryany wrote:
Do you have a test that demonstrates that? That would be very helpful.
In push_back for example, you annotate that the length increases by 1,
but then you don't undo that annotation if the copy constructor of the
element throws an exception.
LGTM with just a few more test cases. For example, what does gcc do for powerpc?
Thanks,
Rafael
___
cfe-commits mailing list
cfe-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
On Mon, May 12, 2014 at 3:45 PM, Stephan Tolksdorf s...@quanttec.com wrote:
On 12.05.14 13:13, Kostya Serebryany wrote:
Do you have a test that demonstrates that? That would be very helpful.
In push_back for example, you annotate that the length increases by 1, but
then you don't undo that
On Mon, May 12, 2014 at 5:29 PM, Kostya Serebryany k...@google.com wrote:
On Mon, May 12, 2014 at 3:45 PM, Stephan Tolksdorf s...@quanttec.comwrote:
On 12.05.14 13:13, Kostya Serebryany wrote:
Do you have a test that demonstrates that? That would be very helpful.
In push_back for
On 14-05-12 16:27, Kostya Serebryany wrote:
And an unrelated issue: the documentation for
__sanitizer_annotate_contiguous_container states that the
complete buffer should be unpoisened before it is deallocated.
This doesn't seem to be happening in the
On Mon, May 12, 2014 at 7:04 PM, Stephan Tolksdorf s...@quanttec.com wrote:
On 14-05-12 16:27, Kostya Serebryany wrote:
And an unrelated issue: the documentation for
__sanitizer_annotate_contiguous_container states that the
complete buffer should be unpoisened
Author: jrose
Date: Mon May 12 12:04:44 2014
New Revision: 208595
URL: http://llvm.org/viewvc/llvm-project?rev=208595view=rev
Log:
[scan-build] Pass --sysroot through for both compilation and linking.
PR19704
Modified:
cfe/trunk/tools/scan-build/ccc-analyzer
Modified:
So guys, how do you find this fix?
http://reviews.llvm.org/D3646
___
cfe-commits mailing list
cfe-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
This does not seem like a reasonable approach. The problem is that we're
looking at the contents of the already-demangled buffer to determine how to
demangle and then making incorrect assumptions about it. We should stop making
those assumptions.
It doesn't seem difficult for parse_name to
+#pragma clang optimize on top of spaghetti // expected-warning {{extra
tokens at end of '#pragma clang optimize' - ignored}}
The diagnostic here is ambiguous. Was the pragma itself ignored or were the
extra tokens ignored?
-- Sean Silva
PS: I actually laughed out loud when I read on top of
Re. the cruelty of macros: I have a case in my backlog where
a macro expands to multiple statements; we emit the same source
location for each, but put a separate is_stmt flag on each
statement. Literally true but not helpful to the debugging
experience.
Given that a debugger would be stepping
Fixed in r208611.
http://reviews.llvm.org/D3646
___
cfe-commits mailing list
cfe-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
On Mon, May 12, 2014 at 11:48 AM, Robinson, Paul
paul_robin...@playstation.sony.com wrote:
Re. the cruelty of macros: I have a case in my backlog where
a macro expands to multiple statements; we emit the same source
location for each, but put a separate is_stmt flag on each
statement.
Author: rsmith
Date: Mon May 12 13:44:13 2014
New Revision: 208611
URL: http://llvm.org/viewvc/llvm-project?rev=208611view=rev
Log:
PR19091: Track whether we're demangling a function template specialization to
determine whether we get a mangling for a return type, rather than trying to
figure it
Author: samsonov
Date: Mon May 12 13:39:51 2014
New Revision: 208610
URL: http://llvm.org/viewvc/llvm-project?rev=208610view=rev
Log:
[ASan] Split static ASan runtime in two parts: asan and asan_cxx.
asan_cxx containts replacements for new/delete operators, and should
only be linked in C++ mode.
Author: hans
Date: Mon May 12 13:59:00 2014
New Revision: 208613
URL: http://llvm.org/viewvc/llvm-project?rev=208613view=rev
Log:
clang-cl: accept -mllvm and -fsanitize_blacklist
Modified:
cfe/trunk/include/clang/Driver/Options.td
Modified: cfe/trunk/include/clang/Driver/Options.td
URL:
Gentle ping.
http://reviews.llvm.org/D3632
___
cfe-commits mailing list
cfe-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
Hi Sean.
On 12 May 2014 19:36, Sean Silva chisophu...@gmail.com wrote:
+#pragma clang optimize on top of spaghetti // expected-warning {{extra
tokens at end of '#pragma clang optimize' - ignored}}
The diagnostic here is ambiguous. Was the pragma itself ignored or were
the extra tokens
Ping!
http://reviews.llvm.org/D3457
___
cfe-commits mailing list
cfe-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
Author: samsonov
Date: Mon May 12 15:20:20 2014
New Revision: 208625
URL: http://llvm.org/viewvc/llvm-project?rev=208625view=rev
Log:
[ASan] Fixup for r208610: link in asan_cxx library on Windows
Modified:
cfe/trunk/lib/Driver/Tools.cpp
cfe/trunk/test/Driver/cl-link.c
Modified:
Hi rsmith,
This adds documentation for -Rpass, -Rpass-missed and -Rpass-analysis.
It also adds release notes for 3.5.
http://reviews.llvm.org/D3730
Files:
docs/ReleaseNotes.rst
docs/UsersManual.rst
Index: docs/ReleaseNotes.rst
This patch adds a new option AllowSimpleBracedStatements that allows
braced statements to be considered as simple. That is, if
AllowShortIfStatementsOnASingleLine and AllowShortLoopStatementsOnASingle
line are enabled, code like:
if (true) {
f();
}
can be wrapped into a single line as:
if
LGTM
http://reviews.llvm.org/D3730
___
cfe-commits mailing list
cfe-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
LGTM
On Mon, May 12, 2014 at 1:27 PM, Diego Novillo dnovi...@google.com wrote:
Hi rsmith,
This adds documentation for -Rpass, -Rpass-missed and -Rpass-analysis.
It also adds release notes for 3.5.
http://reviews.llvm.org/D3730
Files:
docs/ReleaseNotes.rst
docs/UsersManual.rst
Hi Richard et al,
Can you give this a quick review? I got caught out when I attempted to make
use of this long abandoned variable earlier on today...
Thanks,
Will.
remove_unused_pp_numincluded.patch
Description: Binary data
___
cfe-commits mailing
LGTM
On Mon, May 12, 2014 at 1:52 PM, Will Wilson w...@indefiant.com wrote:
Hi Richard et al,
Can you give this a quick review? I got caught out when I attempted to
make use of this long abandoned variable earlier on today...
Thanks,
Will.
Author: lantictac
Date: Mon May 12 16:26:54 2014
New Revision: 208633
URL: http://llvm.org/viewvc/llvm-project?rev=208633view=rev
Log:
Remove unused PP variable NumIncluded
Modified:
cfe/trunk/include/clang/Lex/Preprocessor.h
Modified: cfe/trunk/include/clang/Lex/Preprocessor.h
URL:
OK. I added a two-copy ctor test case, but it's not enough of a corner case.
We appear to eagerly declare the implicit special members for it.
PTAL
Comment at: lib/CodeGen/CGCXXABI.cpp:49-50
@@ +48,4 @@
+
+ // If all trivial copy and move constructors are deleted, we cannot
- Review stuff and add a test case for multiple copy ctors
http://reviews.llvm.org/D3660
Files:
lib/CodeGen/CGCXXABI.cpp
lib/CodeGen/CGCXXABI.h
lib/CodeGen/ItaniumCXXABI.cpp
lib/CodeGen/MicrosoftCXXABI.cpp
test/CodeGenCXX/uncopyable-args.cpp
Index: lib/CodeGen/CGCXXABI.cpp
LGTM, but wait for acks from Aaron and Richard.
Ben
On May 12, 2014, at 4:20 PM, Tyler Nowicki tnowi...@apple.com wrote:
Hi Aaron, Ben,
Thank again for the review. I’ve made the changes you suggested.
There was a question about why I reversed the iteration over the attribute
list. The
Hello everyone,
LLVM buildmaster will be restarted today after 6 PM Pacific Time
Thanks
Galina
___
cfe-commits mailing list
cfe-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
Hm, this approach fails quickly when I try to compile some simple programs.
This program doesn't declare any special members:
struct S { int a; };
void foo(S s) { }
On Mon, May 12, 2014 at 4:15 PM, Reid Kleckner r...@google.com wrote:
- Review stuff and add a test case for multiple copy
- Fix zero ctor case
http://reviews.llvm.org/D3660
Files:
lib/CodeGen/CGCXXABI.cpp
lib/CodeGen/CGCXXABI.h
lib/CodeGen/ItaniumCXXABI.cpp
lib/CodeGen/MicrosoftCXXABI.cpp
test/CodeGenCXX/uncopyable-args.cpp
Index: lib/CodeGen/CGCXXABI.cpp
Comment at: lib/builtins/arm/vfp/adddf3vfp.S:10
@@ -9,3 +9,3 @@
-#include ../assembly.h
+#include ../../assembly.h
Im tempted to say that we should adjust the CPPFLAGS to include
$(top_srcdir)/lib/builtins in the include search path and make this into:
Author: rsmith
Date: Mon May 12 19:34:43 2014
New Revision: 208659
URL: http://llvm.org/viewvc/llvm-project?rev=208659view=rev
Log:
Refactor and fix a latent bug (found by inspection) where an external AST
source that provides a declaration from a hidden module would not have the
visibility of
Comment at: lib/builtins/arm/vfp/adddf3vfp.S:10
@@ -9,3 +9,3 @@
-#include ../assembly.h
+#include ../../assembly.h
Saleem Abdulrasool wrote:
Im tempted to say that we should adjust the CPPFLAGS to include
$(top_srcdir)/lib/builtins in the include search
Author: majnemer
Date: Mon May 12 19:44:44 2014
New Revision: 208661
URL: http://llvm.org/viewvc/llvm-project?rev=208661view=rev
Log:
MS ABI: Preliminary RTTI mangling
Implement what we currently believe is the mangling scheme for RTTI
data. Tests will be added in a later commit which actually
On Mon, May 12, 2014 at 5:45 PM, Jon Roelofs jonat...@codesourcery.comwrote:
Comment at: lib/builtins/arm/vfp/adddf3vfp.S:10
@@ -9,3 +9,3 @@
-#include ../assembly.h
+#include ../../assembly.h
Saleem Abdulrasool wrote:
Im tempted to say that we should
Author: rsmith
Date: Mon May 12 20:15:00 2014
New Revision: 208662
URL: http://llvm.org/viewvc/llvm-project?rev=208662view=rev
Log:
Refactor to avoid explicitly listing all the different flavours of redeclarable
declarations, and duplicating code between them.
Modified:
On Mon, May 12, 2014 at 5:09 PM, Reid Kleckner r...@google.com wrote:
Hm, this approach fails quickly when I try to compile some simple
programs. This program doesn't declare any special members:
struct S { int a; };
void foo(S s) { }
You should be able handle this by using
Author: filcab
Date: Mon May 12 21:37:02 2014
New Revision: 208664
URL: http://llvm.org/viewvc/llvm-project?rev=208664view=rev
Log:
Patched clang to emit x86 blends as shufflevectors.
Summary:
Most of the clang header patch by Simon Pilgrim @ SCEE.
Also fixed (or added) clang tests for these
+// FIXME: We should lower as many of these as possible to LLVM IR without
+// intrinsics which will allow us to remove redundant intrinsics in the
+// future. Taking care that we manage to optimize them afterwards and emit
+// the actual instruction (or better code).
+
What I meant was that
Ah, so I didn't fully understand then. Sorry about that.
But right now the only test that tests those functions is builtins-x86.c,
but that test never runs FileCheck. Shall I put the comment there?
Regards,
Filipe
On Monday, May 12, 2014, Rafael Espíndola rafael.espind...@gmail.com
wrote:
On 12 May 2014 22:58, Filipe Cabecinhas m...@filcab.net wrote:
Ah, so I didn't fully understand then. Sorry about that.
But right now the only test that tests those functions is builtins-x86.c,
but that test never runs FileCheck. Shall I put the comment there?
Well, when we implement this
It's being tested now. But it's only trying for the presence of the new
expansion, not that the old expansion isn't there. I'll add CHECK-NOT for
the old expansion and move the comment there.
Is that what you're saying?
Filipe
On Monday, May 12, 2014, Rafael Espíndola
On 12 May 2014 23:11, Filipe Cabecinhas fil...@filcab.net wrote:
It's being tested now. But it's only trying for the presence of the new
expansion, not that the old expansion isn't there. I'll add CHECK-NOT for
the old expansion and move the comment there.
That would OK.
Thanks,
Rafael
Author: filcab
Date: Tue May 13 00:21:11 2014
New Revision: 208665
URL: http://llvm.org/viewvc/llvm-project?rev=208665view=rev
Log:
Fixed a few tests and moved a comment to its proper place
Modified:
cfe/trunk/test/CodeGen/avx2-builtins.c
Modified: cfe/trunk/test/CodeGen/avx2-builtins.c
I wonder if this is http://llvm.org/bugs/show_bug.cgi?id=19061. (I don't have a
clean tree to rebuild/test with right now.)
Jordan
On May 12, 2014, at 17:34 , Richard Smith richard-l...@metafoo.co.uk wrote:
Author: rsmith
Date: Mon May 12 19:34:43 2014
New Revision: 208659
URL:
56 matches
Mail list logo
