r209969 - Rename utility function templates

2014-05-31 Thread Alp Toker
Author: alp Date: Sat May 31 01:11:02 2014 New Revision: 209969 URL: http://llvm.org/viewvc/llvm-project?rev=209969view=rev Log: Rename utility function templates isExternCTemplate() and getLanguageLinkageTemplate() have nothing to do with templates despite the dubious naming scheme. Modified:

r209970 - Support C++11 scoped enums in NamedDecl::isCXXClassMember()

2014-05-31 Thread Alp Toker
Author: alp Date: Sat May 31 01:11:09 2014 New Revision: 209970 URL: http://llvm.org/viewvc/llvm-project?rev=209970view=rev Log: Support C++11 scoped enums in NamedDecl::isCXXClassMember() Resolves an old FIXME. No callers depend on this giving the right answer so I haven't been able to cook up

Re: r209970 - Support C++11 scoped enums in NamedDecl::isCXXClassMember()

2014-05-31 Thread Alp Toker
On 31/05/2014 09:11, Alp Toker wrote: Author: alp Date: Sat May 31 01:11:09 2014 New Revision: 209970 URL: http://llvm.org/viewvc/llvm-project?rev=209970view=rev Log: Support C++11 scoped enums in NamedDecl::isCXXClassMember() Resolves an old FIXME. No callers depend on this giving the right

[libcxx] r209972 - Fix XFAIL condition from r208840

2014-05-31 Thread Justin Bogner
Author: bogner Date: Sat May 31 02:59:03 2014 New Revision: 209972 URL: http://llvm.org/viewvc/llvm-project?rev=209972view=rev Log: Fix XFAIL condition from r208840 The XFAILs in r208840 were too general. They were meant to only apply to testing when use_system_lib was set. Modified:

Re: r209955 - PR12961 - Extend DR532 to cover C++98/03.

2014-05-31 Thread Edoardo P.
Hi, I'd like to say that, IMHO, DR532 test should be moved to a more proper place, like test/CXX/drs/dr5xx.cpp . What do you think about this? 2014-05-31 4:11 GMT+02:00 Nikola Smiljanic popiz...@gmail.com: Author: nikola Date: Fri May 30 21:10:59 2014 New Revision: 209955 URL:

[PATCH] Expose template types in libclang

2014-05-31 Thread Olivier JG
The various template types are currently given as CXType_Unexposed, where exposing them would be very useful for knowing when you can call functions that work on them, such as clang_Type_getNumTemplateArguments/clang_Type_getTemplateArgumentAsType. http://reviews.llvm.org/D3978 Files:

Re: [PATCH] Expose template types in libclang

2014-05-31 Thread Olivier JG
Remove trailing comma http://reviews.llvm.org/D3978 Files: include/clang-c/Index.h tools/libclang/CXType.cpp Index: include/clang-c/Index.h === --- include/clang-c/Index.h +++ include/clang-c/Index.h @@ -2747,7 +2747,12 @@

Re: [PATCH] [libc++] Allow libc++ to be built on systems without POSIX threads

2014-05-31 Thread Marshall Clow
I would also like to understand more about the motivation behind this patch. Concurrency is a core part of C++11library, and just disabling it seems wrong to me. I know there are systems w/o POSIX threads, but to support those systems, libc++ should use whatever primitives exist there, rather

Re: [PATCH] [libc++] Allow libc++ to be built on systems without POSIX threads

2014-05-31 Thread Jon Roelofs
mclow, the motivation for this is for bare-metal systems where we don't have threads. The other alternative would be to write no-op shims around all of these primitives, but that seems like it would be a lot of mess for very little benefit. Comment at:

Re: [PATCH] [libc++] Allow libc++ to be built on systems without POSIX threads

2014-05-31 Thread Jon Roelofs
Comment at: sources/cxx-stl/llvm-libc++/libcxx/include/__mutex_base:53 @@ -49,2 +52,3 @@ }; +#endif // !_LIBCPP_SINGLE_THREADED awong pointed out that it makes sense to exclude defer_lock_t and friends also, so delete this line Comment

r209974 - Fix test on platforms where size_t is not 'unsigned long'.

2014-05-31 Thread Benjamin Kramer
Author: d0k Date: Sat May 31 10:06:33 2014 New Revision: 209974 URL: http://llvm.org/viewvc/llvm-project?rev=209974view=rev Log: Fix test on platforms where size_t is not 'unsigned long'. Modified: cfe/trunk/test/FixIt/format.m Modified: cfe/trunk/test/FixIt/format.m URL:

Re: [PATCH] [libc++] Allow libc++ to be built on systems without POSIX threads

2014-05-31 Thread Jon Roelofs
Comment at: sources/cxx-stl/llvm-libc++/libcxx/include/__config:14 @@ -13,1 +13,3 @@ +#include unistd.h + awong also suggested that I wrap this in an `#if !_WIN32`. http://reviews.llvm.org/D3969 ___ cfe-commits

r209978 - Preprocessor: make C++ operator names as macro identifiers a compatible extension

2014-05-31 Thread Alp Toker
Author: alp Date: Sat May 31 11:32:22 2014 New Revision: 209978 URL: http://llvm.org/viewvc/llvm-project?rev=209978view=rev Log: Preprocessor: make C++ operator names as macro identifiers a compatible extension With recent changes, this is now a compatible language extension and can be safely

Re: r209942 - [CodeGen] Don't cast and use SizeTy instead of Int32Ty when constructing {extract, insert} vector element instructions.

2014-05-31 Thread David Blaikie
On Fri, May 30, 2014 at 5:22 PM, Michael J. Spencer bigchees...@gmail.com wrote: Author: mspencer Date: Fri May 30 19:22:12 2014 New Revision: 209942 URL: http://llvm.org/viewvc/llvm-project?rev=209942view=rev Log: [CodeGen] Don't cast and use SizeTy instead of Int32Ty when constructing

Re: r209942 - [CodeGen] Don't cast and use SizeTy instead of Int32Ty when constructing {extract, insert} vector element instructions.

2014-05-31 Thread Michael Spencer
On Sat, May 31, 2014 at 10:44 AM, David Blaikie dblai...@gmail.com wrote: On Fri, May 30, 2014 at 5:22 PM, Michael J. Spencer bigchees...@gmail.com wrote: Author: mspencer Date: Fri May 30 19:22:12 2014 New Revision: 209942 URL: http://llvm.org/viewvc/llvm-project?rev=209942view=rev Log:

Re: r209974 - Fix test on platforms where size_t is not 'unsigned long'.

2014-05-31 Thread Jordan Rose
Thanks, Ben! On May 31, 2014, at 8:06 , Benjamin Kramer benny@googlemail.com wrote: Author: d0k Date: Sat May 31 10:06:33 2014 New Revision: 209974 URL: http://llvm.org/viewvc/llvm-project?rev=209974view=rev Log: Fix test on platforms where size_t is not 'unsigned long'. Modified:

[PATCH] Allow per-file clang-tidy options.

2014-05-31 Thread Alexander Kornienko
Hi klimek, This patch makes it possible for clang-tidy clients to provide different options for different translation units. The option, which doesn't make sense to be file-dependent, was moved to a separate ClangTidyGlobalOptions struct. Added parsing of ClangTidyOptions.

Re: [PATCH] Allow per-file clang-tidy options.

2014-05-31 Thread Alexander Kornienko
Added a comment and an assertion, replaced a couple of |= with definitely short cirtuited versions. http://reviews.llvm.org/D3979 Files: clang-tidy/ClangTidy.cpp clang-tidy/ClangTidy.h clang-tidy/ClangTidyDiagnosticConsumer.cpp clang-tidy/ClangTidyDiagnosticConsumer.h

[PATCH] Exit with error when no checks enabled.

2014-05-31 Thread Alexander Kornienko
Hi klimek, This seems like a more appropriate reaction to the user specifying a single check with a wrong name, for example. http://reviews.llvm.org/D3981 Files: clang-tidy/tool/ClangTidyMain.cpp test/clang-tidy/diagnostic.cpp test/clang-tidy/select-checks.cpp Index:

[PATCH] Never filter-out compile errors in clang-tidy, display them as errors.

2014-05-31 Thread Alexander Kornienko
Hi klimek, No filters should affect the display of errors. Fixed a few tests, which had compile errors. We need to think what we should do with mapped errors (-Werror). http://reviews.llvm.org/D3982 Files: clang-tidy/ClangTidy.cpp clang-tidy/ClangTidyDiagnosticConsumer.cpp

Re: r207951 - Update lit.cfg to support the clang-interpreter test from r207950

2014-05-31 Thread Richard Smith
On Sun, May 4, 2014 at 11:42 PM, Alp Toker a...@nuanti.com wrote: Author: alp Date: Mon May 5 01:42:07 2014 New Revision: 207951 URL: http://llvm.org/viewvc/llvm-project?rev=207951view=rev Log: Update lit.cfg to support the clang-interpreter test from r207950 Performs behind-the-scenes

Should unw_word_t be 32-bits on 32-bit platforms?

2014-05-31 Thread 王重傑
Hello cfe-commits, As part of our work to implement EHABI, we experimentally tried to typedef unw_word_t so it was 32-bits on arm platforms. It felt wasteful of memory and CPU cycles to work in 64-bits when everything on the architecture is 32-bits. Unfortunately, this caused a problem with all

Re: r207951 - Update lit.cfg to support the clang-interpreter test from r207950

2014-05-31 Thread Alp Toker
On 01/06/2014 04:05, Richard Smith wrote: On Sun, May 4, 2014 at 11:42 PM, Alp Toker a...@nuanti.com mailto:a...@nuanti.com wrote: Author: alp Date: Mon May 5 01:42:07 2014 New Revision: 207951 URL: http://llvm.org/viewvc/llvm-project?rev=207951view=rev Log: Update

Re: r207951 - Update lit.cfg to support the clang-interpreter test from r207950

2014-05-31 Thread Richard Smith
On Sat, May 31, 2014 at 6:46 PM, Alp Toker a...@nuanti.com wrote: On 01/06/2014 04:05, Richard Smith wrote: On Sun, May 4, 2014 at 11:42 PM, Alp Toker a...@nuanti.com mailto: a...@nuanti.com wrote: Author: alp Date: Mon May 5 01:42:07 2014 New Revision: 207951 URL:

r209983 - Don't add examples to the check-clang dependencies unless requested

2014-05-31 Thread Alp Toker
Author: alp Date: Sat May 31 21:02:23 2014 New Revision: 209983 URL: http://llvm.org/viewvc/llvm-project?rev=209983view=rev Log: Don't add examples to the check-clang dependencies unless requested The tests were correctly getting skipped but the targets still mistakenly got built. Modified:

Re: r207951 - Update lit.cfg to support the clang-interpreter test from r207950

2014-05-31 Thread Alp Toker
On 01/06/2014 04:54, Richard Smith wrote: On Sat, May 31, 2014 at 6:46 PM, Alp Toker a...@nuanti.com mailto:a...@nuanti.com wrote: On 01/06/2014 04:05, Richard Smith wrote: On Sun, May 4, 2014 at 11:42 PM, Alp Toker a...@nuanti.com mailto:a...@nuanti.com

Re: r207951 - Update lit.cfg to support the clang-interpreter test from r207950

2014-05-31 Thread Richard Smith
On Sat, May 31, 2014 at 7:18 PM, Alp Toker a...@nuanti.com wrote: On 01/06/2014 04:54, Richard Smith wrote: On Sat, May 31, 2014 at 6:46 PM, Alp Toker a...@nuanti.com mailto: a...@nuanti.com wrote: On 01/06/2014 04:05, Richard Smith wrote: On Sun, May 4, 2014 at 11:42 PM,

Re: r207951 - Update lit.cfg to support the clang-interpreter test from r207950

2014-05-31 Thread Richard Smith
On Sat, May 31, 2014 at 7:21 PM, Richard Smith rich...@metafoo.co.uk wrote: On Sat, May 31, 2014 at 7:18 PM, Alp Toker a...@nuanti.com wrote: On 01/06/2014 04:54, Richard Smith wrote: On Sat, May 31, 2014 at 6:46 PM, Alp Toker a...@nuanti.com mailto: a...@nuanti.com wrote: On

Re: Should unw_word_t be 32-bits on 32-bit platforms?

2014-05-31 Thread Saleem Abdulrasool
On Sat, May 31, 2014 at 6:21 PM, Albert Wong (王重傑) ajw...@google.com wrote: Hello cfe-commits, As part of our work to implement EHABI, we experimentally tried to typedef unw_word_t so it was 32-bits on arm platforms. It felt wasteful of memory and CPU cycles to work in 64-bits when

Re: Should unw_word_t be 32-bits on 32-bit platforms?

2014-05-31 Thread Jean-Daniel Dupas
Le 1 juin 2014 à 06:42, Saleem Abdulrasool compn...@compnerd.org a écrit : On Sat, May 31, 2014 at 6:21 PM, Albert Wong (王重傑) ajw...@google.com wrote: Hello cfe-commits, As part of our work to implement EHABI, we experimentally tried to typedef unw_word_t so it was 32-bits on arm