Re: r237608 - Detect uses of mismatching forms of 'new' and 'delete'

2015-05-20 Thread Ismail Pazarbasi
Thank you both. Richard's example triggered assertion. I'll work on a fix, and update the patch. On Wed, May 20, 2015 at 2:09 AM, Nick Lewycky nlewy...@google.com wrote: On 19 May 2015 at 15:48, Richard Trieu rtr...@google.com wrote: On Tue, May 19, 2015 at 2:19 PM, Nick Lewycky

Re: [PATCH] -Wprofile-instr-out-of-date warnings due to certain destructor types not being assigned increment intrinsics

2015-05-20 Thread Justin Bogner
Betul Buyukkurt bet...@codeaurora.org writes: Betul Buyukkurt bet...@codeaurora.org writes: Betul Buyukkurt bet...@codeaurora.org writes: Hi bogner, dsule, davidxl, -fprofile-instr-generate does not emit counter increment intrinsics for Dtor_Deleting and Dtor_Complete destructors with

r237776 - Fix CGRecordLayouts description to say it maps clang types not llvm types

2015-05-20 Thread Yaron Keren
Author: yrnkrn Date: Wed May 20 02:15:28 2015 New Revision: 237776 URL: http://llvm.org/viewvc/llvm-project?rev=237776view=rev Log: Fix CGRecordLayouts description to say it maps clang types not llvm types and de-duplicate data fields names from comments according to the coding standard.

[PATCH] Support memory markers for nonzero address spaces

2015-05-20 Thread John Garvin
Hi majnemer, It would be very helpful to support memory usage markers for address spaces other than zero. This should be considered together with LLVM patch http://reviews.llvm.org/D9870 . http://reviews.llvm.org/D9871 Files: lib/CodeGen/CGDecl.cpp lib/CodeGen/CGDeclCXX.cpp

r237778 - [X86] Add _mm256_set_m128 and its 5 variants.

2015-05-20 Thread Michael Kuperstein
Author: mkuper Date: Wed May 20 02:46:52 2015 New Revision: 237778 URL: http://llvm.org/viewvc/llvm-project?rev=237778view=rev Log: [X86] Add _mm256_set_m128 and its 5 variants. Differential Revision: http://reviews.llvm.org/D9855 Modified: cfe/trunk/lib/Headers/avxintrin.h

Re: [PATCH] [X86] Add _mm256_set_m128 and friends

2015-05-20 Thread Michael Kuperstein
REPOSITORY rL LLVM http://reviews.llvm.org/D9855 Files: cfe/trunk/lib/Headers/avxintrin.h cfe/trunk/test/CodeGen/avx-shuffle-builtins.c Index: cfe/trunk/lib/Headers/avxintrin.h === --- cfe/trunk/lib/Headers/avxintrin.h +++

Re: [PATCH] [libcxx] Fix PR 23589: std::function doesn't recognize null pointer to varargs function

2015-05-20 Thread Eric Fiselier
Flush out tests. http://reviews.llvm.org/D9873 Files: include/__functional_03 include/__functional_base_03 include/functional test/std/utilities/function.objects/func.wrap/func.wrap.func/func.wrap.func.con/F_nullptr.pass.cpp EMAIL PREFERENCES

[PATCH] [OPENMP] Allow to disable OpenMP support and link libgomp

2015-05-20 Thread Alexey Bataev
Hi chandlerc, Added flag ENABLE_CLANG_OPENMP that is ON by default. If set to OFF, changes behavior of -fopenmp option to the old one. http://reviews.llvm.org/D9875 Files: CMakeLists.txt lib/Driver/Tools.cpp test/OpenMP/linking.c test/OpenMP/linking_no_openmp.c test/lit.cfg

r237782 - Allow skipping imports in the module visitor.

2015-05-20 Thread Manuel Klimek
Author: klimek Date: Wed May 20 05:29:23 2015 New Revision: 237782 URL: http://llvm.org/viewvc/llvm-project?rev=237782view=rev Log: Allow skipping imports in the module visitor. Skip imports when we know that we do not need to visit any imports because we've already deserialized the redecls from

Re: [PATCH] [OPENMP] Allow to disable OpenMP support and link libgomp

2015-05-20 Thread Ed Maste
I'm curious - what is the use case for the old behaviour? AFAICT if the user sets `Enable OpenMP support` `OFF` they'll get a compiler that links against `libgomp` when `-fopenmp` is specified, but doesn't produce a useful openmp executable? Comment at:

Re: [PATCH] Speed up modules compilation.

2015-05-20 Thread Manuel Klimek
Review comments. http://reviews.llvm.org/D9498 Files: include/clang/Serialization/ModuleManager.h lib/Serialization/ASTReader.cpp lib/Serialization/ASTReaderDecl.cpp lib/Serialization/ModuleManager.cpp EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ Index:

Re: [PATCH] [OPENMP] Allow to disable OpenMP support and link libgomp

2015-05-20 Thread Ed Maste
In http://reviews.llvm.org/D9875#175604, @emaste wrote: I'm curious - what is the use case for the old behaviour? Ah, I found Chandler's explanation for this, in the thread for r237769. http://reviews.llvm.org/D9875 EMAIL PREFERENCES

Re: [PATCH] [MSVC] Handle out-of-line definition of static data member correctly (fix for http://llvm.org/PR21164)

2015-05-20 Thread Alexey Bataev
REPOSITORY rL LLVM http://reviews.llvm.org/D9850 Files: cfe/trunk/lib/AST/ASTContext.cpp cfe/trunk/test/CodeGenCXX/dllexport-members.cpp cfe/trunk/test/CodeGenCXX/ms-integer-static-data-members.cpp EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ Index:

Re: [PATCH] Speed up modules compilation.

2015-05-20 Thread Manuel Klimek
In http://reviews.llvm.org/D9498#175201, @rsmith wrote: Essentially this seems fine. It'd be better if `visitDepthFirst` didn't actually walk the the entire module graph in the case where it's been told to `SkipChildren`, but we can leave that improvement for a later change. I'm not sure

r237787 - [MSVC] Handle out-of-line definition of static data member correctly (fix for http://llvm.org/PR21164), by Alexey Frolov

2015-05-20 Thread Alexey Bataev
Author: abataev Date: Wed May 20 06:57:02 2015 New Revision: 237787 URL: http://llvm.org/viewvc/llvm-project?rev=237787view=rev Log: [MSVC] Handle out-of-line definition of static data member correctly (fix for http://llvm.org/PR21164), by Alexey Frolov There are 3 cases of defining static

Re: [PATCH] [libcxx] Fix PR 23589: std::function doesn't recognize null pointer to varargs function

2015-05-20 Thread Eric Fiselier
Use Davids suggestion to reduce code duplication. I didn't know that would work :-) http://reviews.llvm.org/D9873 Files: include/__functional_03 include/__functional_base_03 include/functional test/std/utilities/function.objects/func.wrap/func.wrap.func/func.wrap.func.con/F.pass.cpp

[PATCH] [libcxx] Fix PR 23589: std::function doesn't recognize null pointer to varargs function

2015-05-20 Thread Eric Fiselier
Hi mclow.lists, __not_null is missing overloads for cv and ref qualified member functions as well as functions that have varargs. This patch adds these overloads. see https://llvm.org/bugs/show_bug.cgi?id=23589. http://reviews.llvm.org/D9873 Files: include/functional

r237788 - [OPENMP] Fix codegen for ordered loop directives.

2015-05-20 Thread Alexey Bataev
Author: abataev Date: Wed May 20 08:12:48 2015 New Revision: 237788 URL: http://llvm.org/viewvc/llvm-project?rev=237788view=rev Log: [OPENMP] Fix codegen for ordered loop directives. loops with ordered clause must be generated the same way as dynamic loops, but with static scheduleing.

Re: [PATCH] Fix for #pragma warning to work correctly with 1-4: specifiers

2015-05-20 Thread Andrey Bokhanko
Reid, thank you for the review! I fixed the use-after-free bug you found (good catch, BTW!) I also created a test that checks -E (not sure this is exactly what you wanted; let me know if I misunderstood you). http://reviews.llvm.org/D9856 Files: lib/Lex/Pragma.cpp

[PATCH] [OpenMP] Make default OpenMP library (the one selected with just -fopenmp) configurable in the CMake build. There shouldn't be any change in default behavior.

2015-05-20 Thread Daniel Jasper
Hi chandlerc, rsmith, ABataev, http://reviews.llvm.org/D9878 Files: CMakeLists.txt lib/Driver/Tools.cpp Index: CMakeLists.txt === --- CMakeLists.txt +++ CMakeLists.txt @@ -441,6 +441,13 @@

[PATCH] Fix Bug 23189 in C++14 type inference for lambdas with undeclared identifiers

2015-05-20 Thread Tomasz Dudziak
Hi dim, yaron.keren, rsmith, Fixes [[ https://llvm.org/bugs/show_bug.cgi?id=23189 | Bug 23189 ]] by adding additional checks in `DeduceFunctionTypeFromReturnExpr`. Without these checks, the code attempts to dereference a null pointer when trying to infer the return type of a lambda if there

Re: [PATCH] [libcxx] Fix detection of __is_final.

2015-05-20 Thread Marshall Clow
What do you think of making `__libcpp_is_final` be false when we don't have `__is_final`. Then the `#if` in unordered_map, memory, map, etc. can be removed. http://reviews.llvm.org/D8795 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/

RE: [PATCH] -Wprofile-instr-out-of-date warnings due to certain destructor types not being assigned increment intrinsics

2015-05-20 Thread Betul Buyukkurt
Hi Justin, I do not have commit rights. Could you please direct how I should commit or commit the change on my behalf? Thanks, -Betul -Original Message- From: Justin Bogner [mailto:jus...@justinbogner.com] On Behalf Of Justin Bogner Sent: Tuesday, May 19, 2015 11:05 PM To: Betul

Re: [PATCH] [ARM] Restructure cpu handling in the driver to mostly use the triple

2015-05-20 Thread John Brawn
Fix typo. REPOSITORY rL LLVM http://reviews.llvm.org/D9879 Files: lib/Driver/Tools.cpp test/Driver/arm-cortex-cpus.c EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ Index: lib/Driver/Tools.cpp

[PATCH] [ARM] Restructure cpu handling in the driver to mostly use the triple

2015-05-20 Thread John Brawn
Hi rengolin, Using the target cpu to determine some behaviour is sprinkled in several places in the driver, but in almost all the information that is needed can be found in the triple. Restructure things so that the triple is used, and the cpu is only used if the exact cpu name is needed.

Re: [PATCH] [ARM] Restructure cpu handling in the driver to mostly use the triple

2015-05-20 Thread Renato Golin
Hi John, I'm about to commit some changes to ARMTargetParser that may affect your patch. I have tested both LLVM and Clang with it and found no bugs, but that doesn't guarantee much. I've also added a lot more unit tests to the Triple interface, which should stabilise things. I was going to

r237802 - CodeGen: Remove some trailing whitespace. NFC

2015-05-20 Thread Justin Bogner
Author: bogner Date: Wed May 20 10:53:59 2015 New Revision: 237802 URL: http://llvm.org/viewvc/llvm-project?rev=237802view=rev Log: CodeGen: Remove some trailing whitespace. NFC Modified: cfe/trunk/lib/CodeGen/CGClass.cpp Modified: cfe/trunk/lib/CodeGen/CGClass.cpp URL:

r237806 - InstrProf: Change this triple back to %itanium_abi_triple

2015-05-20 Thread Justin Bogner
Author: bogner Date: Wed May 20 11:25:35 2015 New Revision: 237806 URL: http://llvm.org/viewvc/llvm-project?rev=237806view=rev Log: InstrProf: Change this triple back to %itanium_abi_triple In my rush to fix the linux bots in r237805, I accidentally committed a change to the triple. Revert that

Re: [PATCH] [OPENMP] Allow to disable OpenMP support and link libgomp

2015-05-20 Thread Jack Howarth
I am not having any luck with this proposed patch. Building current llvm/clang/openmp/compiler-rt trunk with it produces a compiler that always defaults to emitting -lgomp for -fopenmp even if cmake is explicitly passed -DENABLE_CLANG_OPENMP=ON. http://reviews.llvm.org/D9875 EMAIL

Re: [PATCH] [OpenMP] Make default OpenMP library (the one selected with just -fopenmp) configurable in the CMake build. There shouldn't be any change in default behavior.

2015-05-20 Thread Manuel Klimek
Comment at: CMakeLists.txt:447-448 @@ +446,4 @@ + +if( OPENMP_DEFAULT_LIB ) + add_definitions( -DOPENMP_DEFAULT_LIB=${OPENMP_DEFAULT_LIB} ) +endif() Add comment explaining the space in the end. http://reviews.llvm.org/D9878 EMAIL PREFERENCES

Re: [PATCH] -Wprofile-instr-out-of-date warnings due to certain destructor types not being assigned increment intrinsics

2015-05-20 Thread David
the change looks fine to me. http://reviews.llvm.org/D9861 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ ___ cfe-commits mailing list cfe-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

Re: [PATCH] Fix for #pragma warning to work correctly with 1-4: specifiers

2015-05-20 Thread Reid Kleckner
Comment at: test/Preprocessor/pragma_microsoft_E.c:1-3 @@ +1,4 @@ +// RUN: %clang_cc1 %s -E -fms-extensions 21 | FileCheck %s +// REQUIRES: non-ps4-sdk + +// This test simply checks that these pragmas successfully roundtrip through the Rather than copy-pasting

Re: r237787 - [MSVC] Handle out-of-line definition of static data member correctly (fix for http://llvm.org/PR21164), by Alexey Frolov

2015-05-20 Thread Hans Wennborg
On Wed, May 20, 2015 at 4:57 AM, Alexey Bataev a.bat...@hotmail.com wrote: Author: abataev Date: Wed May 20 06:57:02 2015 New Revision: 237787 URL: http://llvm.org/viewvc/llvm-project?rev=237787view=rev Log: [MSVC] Handle out-of-line definition of static data member correctly (fix for

Re: r237787 - [MSVC] Handle out-of-line definition of static data member correctly (fix for http://llvm.org/PR21164), by Alexey Frolov

2015-05-20 Thread Hans Wennborg
On Wed, May 20, 2015 at 9:26 AM, Hans Wennborg h...@chromium.org wrote: On Wed, May 20, 2015 at 4:57 AM, Alexey Bataev a.bat...@hotmail.com wrote: Author: abataev Date: Wed May 20 06:57:02 2015 New Revision: 237787 URL: http://llvm.org/viewvc/llvm-project?rev=237787view=rev Log: [MSVC]

Re: [PATCH] -Wprofile-instr-out-of-date warnings due to certain destructor types not being assigned increment intrinsics

2015-05-20 Thread Justin Bogner
Betul Buyukkurt bet...@codeaurora.org writes: Hi Justin, I do not have commit rights. Could you please direct how I should commit or commit the change on my behalf? r237804. Thanks, -Betul -Original Message- From: Justin Bogner [mailto:jus...@justinbogner.com] On Behalf Of

Re: [PATCH] [OPENMP] Do not emit references to original variables in 'private' clause.

2015-05-20 Thread John McCall
Sema doesn't know much about the shareds structure, either. To be sure, it builds it as part of building the CapturedStmt, but it's not like Sema creates MemberRefExprs that point into it whenever you refer to a captured variable. It's not even like lambdas, where that struct type is visible

[PATCH] Apply existing checks to C++1Z (has_feature_cxx0x); NFC

2015-05-20 Thread Hubert Tong
Hi rsmith, fraggamuffin, rcraik, This applies the existing checks in `has_feature_cxx0x` to `-std=c++1z`. In addition, references to C++1y are updated to refer to C++14. http://reviews.llvm.org/D9885 Files: test/Lexer/has_feature_cxx0x.cpp EMAIL PREFERENCES

Re: [PATCH] -Wprofile-instr-out-of-date warnings due to certain destructor types not being assigned increment intrinsics

2015-05-20 Thread Betul Buyukkurt
Betul Buyukkurt bet...@codeaurora.org writes: Hi Justin, I do not have commit rights. Could you please direct how I should commit or commit the change on my behalf? r237804. Thanks. -Betul Thanks, -Betul -Original Message- From: Justin Bogner

r237804 - InstrProf: Increment the profile counter for all types of destructor

2015-05-20 Thread Justin Bogner
Author: bogner Date: Wed May 20 11:16:23 2015 New Revision: 237804 URL: http://llvm.org/viewvc/llvm-project?rev=237804view=rev Log: InstrProf: Increment the profile counter for all types of destructor -fprofile-instr-generate does not emit counter increment intrinsics for Dtor_Deleting and

Re: [PATCH] [libcxx] Fix PR 23589: std::function doesn't recognize null pointer to varargs function

2015-05-20 Thread David Krauss
A lot of work can be save by ignoring the function signature. templateclass _R2, class _Cp static bool __not_null( t c::* p ) { return pm; } http://reviews.llvm.org/D9873 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/

r237805 - InstrProf: Remove darwin-specific section names from this test

2015-05-20 Thread Justin Bogner
Author: bogner Date: Wed May 20 11:21:26 2015 New Revision: 237805 URL: http://llvm.org/viewvc/llvm-project?rev=237805view=rev Log: InstrProf: Remove darwin-specific section names from this test Modified: cfe/trunk/test/Profile/cxx-virtual-destructor-calls.cpp Modified:

r237811 - Use Intrinsic::ID instead of unsigned. NFC.

2015-05-20 Thread Pete Cooper
Author: pete Date: Wed May 20 12:17:45 2015 New Revision: 237811 URL: http://llvm.org/viewvc/llvm-project?rev=237811view=rev Log: Use Intrinsic::ID instead of unsigned. NFC. This is after LLVM r237810 which made Function::getIntrinsicID() return an Intrinsic::ID. Modified:

[PATCH] [CodeGen] Teach X86_64ABIInfo about AVX512.

2015-05-20 Thread Ahmed Bougacha
Hi rjmccall, Tentative but straightforward patch, based on the Edited for AVX512 SysV ABI drafts. Depends on a local refactoring to pass the ABI string rather than HasAVX. http://reviews.llvm.org/D9894 Files: lib/Basic/Targets.cpp lib/CodeGen/TargetInfo.cpp

Is __declspec a core language extension?

2015-05-20 Thread Aaron Ballman
While refactoring some attribute parsing code, I noticed that we do not guard __declspec as being a Microsoft-specific extension that we support. This is consistent with the behavior we have for __attribute__. In both cases, the keyword is available everywhere, and specific attributes determine

Re: [PATCH] [CodeGen] Teach X86_64ABIInfo about AVX512.

2015-05-20 Thread Ahmed Bougacha
Comment at: lib/CodeGen/TargetInfo.cpp:1634-1635 @@ -1630,3 +1633,4 @@ unsigned getOpenMPSimdDefaultAlignment(QualType) const override { +// FIXME: What about AVX512? return getABIInfo().hasAVX() ? 32 : 16; } This I'm not sure; it makes sense to me

Re: [PATCH] [OpenMP] Make default OpenMP library (the one selected with just -fopenmp) configurable in the CMake build. There shouldn't be any change in default behavior.

2015-05-20 Thread Richard Smith
Comment at: lib/Driver/Tools.cpp:6294-6309 @@ -6290,14 +6293,18 @@ } else if (Args.hasArg(options::OPT_fopenmp)) { +#if defined(OPENMP_DEFAULT_LIB) +UsedOpenMPLib = OpenMPStringToVersion(OPENMP_DEFAULT_LIB); +#else UsedOpenMPLib = LibIOMP5; +#endif } switch

[clang-tools-extra] r237832 - Copy lit shell changes from clang to clang-tools-extra, excluding some failing tests

2015-05-20 Thread Reid Kleckner
Author: rnk Date: Wed May 20 15:33:18 2015 New Revision: 237832 URL: http://llvm.org/viewvc/llvm-project?rev=237832view=rev Log: Copy lit shell changes from clang to clang-tools-extra, excluding some failing tests Modified:

Re: [PATCH] add the -mrecip driver flag and process its options

2015-05-20 Thread hfin...@anl.gov
Comment at: lib/Driver/Tools.cpp:1623 @@ +1622,3 @@ +const Arg A, size_t Position) { + const char REF_STEP_TOKEN = ':'; + Position = In.find(REF_STEP_TOKEN); Don't name this like a macro. Comment at:

r237839 - Evaluate union cast subexpressions when the cast value is unused

2015-05-20 Thread Reid Kleckner
Author: rnk Date: Wed May 20 16:59:25 2015 New Revision: 237839 URL: http://llvm.org/viewvc/llvm-project?rev=237839view=rev Log: Evaluate union cast subexpressions when the cast value is unused Fixes PR23597. Modified: cfe/trunk/lib/CodeGen/CGExprAgg.cpp cfe/trunk/test/CodeGen/exprs.c

r237835 - Refactored some common functionality into MaybeParseMicrosoftDeclSpecs; NFC.

2015-05-20 Thread Aaron Ballman
Author: aaronballman Date: Wed May 20 15:58:33 2015 New Revision: 237835 URL: http://llvm.org/viewvc/llvm-project?rev=237835view=rev Log: Refactored some common functionality into MaybeParseMicrosoftDeclSpecs; NFC. Modified: cfe/trunk/include/clang/Parse/Parser.h

Re: [PATCH] Clang changes for indirect call target profiling

2015-05-20 Thread David
Comment at: lib/CodeGen/CodeGenPGO.cpp:811 @@ +810,3 @@ + Sum = 0; + OutputData.clear(); + for (unsigned I = 0; I IndirectTargetResults.size(); ++I) { Why is clear needed here? Better asserting. Comment at: lib/CodeGen/CodeGenPGO.cpp:812 @@

Re: [PATCH] [OpenMP] Make default OpenMP library (the one selected with just -fopenmp) configurable in the CMake build. There shouldn't be any change in default behavior.

2015-05-20 Thread Daniel Jasper
Comment at: CMakeLists.txt:447-448 @@ +446,4 @@ + +if( OPENMP_DEFAULT_LIB ) + add_definitions( -DOPENMP_DEFAULT_LIB=${OPENMP_DEFAULT_LIB} ) +endif() klimek wrote: Add comment explaining the space in the end. Removed. I don't think it is necessary.

r237815 - [modules] Support merging a parsed default argument with an imported hidden one for non-type and template template parameters too.

2015-05-20 Thread Richard Smith
Author: rsmith Date: Wed May 20 13:24:21 2015 New Revision: 237815 URL: http://llvm.org/viewvc/llvm-project?rev=237815view=rev Log: [modules] Support merging a parsed default argument with an imported hidden one for non-type and template template parameters too. Modified:

[PATCH] [OPENMP] Driver support for OpenMP offloading

2015-05-20 Thread Samuel Antao
Hi ABataev, hfinkel, rsmith, rjmccall, chandlerc, With a full implementation of OpenMP 3.1. already available upstream, we aim at continuing that work and add support for OpenMP 4.0 as well. One important component introduced by OpenMP 4.0 is offloading which enables the execution of a given

r237818 - [CodeGen] Check x86_64-arguments.c tests on AVX as well. NFC.

2015-05-20 Thread Ahmed Bougacha
Author: ab Date: Wed May 20 13:39:16 2015 New Revision: 237818 URL: http://llvm.org/viewvc/llvm-project?rev=237818view=rev Log: [CodeGen] Check x86_64-arguments.c tests on AVX as well. NFC. We used to only check the differing tests on AVX, but we might as well check all of them. Modified:

Re: [PATCH] [ARM] Restructure cpu handling in the driver to mostly use the triple

2015-05-20 Thread Tim Northover
I've checked the iOS/Darwin behaviour and it seems reasonable from that perspective too. Tim. REPOSITORY rL LLVM http://reviews.llvm.org/D9879 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ ___ cfe-commits mailing

[libcxx] r237813 - Start a to-do list for libc++

2015-05-20 Thread Marshall Clow
Author: marshall Date: Wed May 20 12:39:54 2015 New Revision: 237813 URL: http://llvm.org/viewvc/llvm-project?rev=237813view=rev Log: Start a to-do list for libc++ Added: libcxx/trunk/TODO.TXT Added: libcxx/trunk/TODO.TXT URL:

Re: r237608 - Detect uses of mismatching forms of 'new' and 'delete'

2015-05-20 Thread Richard Trieu
Modified: cfe/trunk/test/SemaCXX/delete.cpp URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/SemaCXX/delete.cpp?rev=237608r1=237607r2=237608view=diff == --- cfe/trunk/test/SemaCXX/delete.cpp (original) +++

r237814 - [modules] Support merging a parsed default function/template argument with an imported but hidden one.

2015-05-20 Thread Richard Smith
Author: rsmith Date: Wed May 20 12:50:35 2015 New Revision: 237814 URL: http://llvm.org/viewvc/llvm-project?rev=237814view=rev Log: [modules] Support merging a parsed default function/template argument with an imported but hidden one. Modified: cfe/trunk/lib/Sema/SemaDeclCXX.cpp

Re: [PATCH] [ARM] Restructure cpu handling in the driver to mostly use the triple

2015-05-20 Thread Renato Golin
Hi John, The changes look fine with two comments. Don't worry too much if ARMTargetParser is a bit confusing, once we got all arch / cpu changes into it, I'll refactor it to make more sense. For now, I'm trying hard to not change the behaviour in any way. cheers, --renato REPOSITORY rL

Re: [PATCH] [libc++] Fix PR22606 - Leak pthread_key with static storage duration to ensure all of thread-local destructors are called.

2015-05-20 Thread Marshall Clow
Other than my inline comment, LGTM. http://reviews.llvm.org/D8802 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ ___ cfe-commits mailing list cfe-commits@cs.uiuc.edu

r237862 - Work around overloading bug in MSVC 2015

2015-05-20 Thread Reid Kleckner
Author: rnk Date: Wed May 20 19:12:53 2015 New Revision: 237862 URL: http://llvm.org/viewvc/llvm-project?rev=237862view=rev Log: Work around overloading bug in MSVC 2015 MSVC 2015 appears to be unable to find the correct operator== here. I haven't yet filed a bug with Microsoft as I've been

r237863 - Rename a helper template function to 'bytes' to avoid a C++17 STL conflict

2015-05-20 Thread Reid Kleckner
Author: rnk Date: Wed May 20 19:13:09 2015 New Revision: 237863 URL: http://llvm.org/viewvc/llvm-project?rev=237863view=rev Log: Rename a helper template function to 'bytes' to avoid a C++17 STL conflict MSVC 2015 includes the std::data() template function added to C++17. ADL causes both cl.exe

r237871 - [modules] If we re-enter a submodule from within itself (when submodule

2015-05-20 Thread Richard Smith
Author: rsmith Date: Wed May 20 20:20:10 2015 New Revision: 237871 URL: http://llvm.org/viewvc/llvm-project?rev=237871view=rev Log: [modules] If we re-enter a submodule from within itself (when submodule visibility is enabled) or leave and re-enter it, restore the macro and module visibility

r237850 - [OpenMP] Make default OpenMP library (the one selected with just -fopenmp)

2015-05-20 Thread Richard Smith
Author: rsmith Date: Wed May 20 17:48:44 2015 New Revision: 237850 URL: http://llvm.org/viewvc/llvm-project?rev=237850view=rev Log: [OpenMP] Make default OpenMP library (the one selected with just -fopenmp) configurable in the CMake build. There shouldn't be any change in default behavior.

Re: [PATCH] [OpenMP] Make default OpenMP library (the one selected with just -fopenmp) configurable in the CMake build. There shouldn't be any change in default behavior.

2015-05-20 Thread Richard Smith
I switched to specifying a library name in `OPENMP_DEFAULT_LIB` (to support cases where people ship libiomp5 under a different name) and commited as r237850. http://reviews.llvm.org/D9878 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/

Re: Is __declspec a core language extension?

2015-05-20 Thread Reid Kleckner
That's Art's fault. Probably the easiest thing to do is enable fms-extensions for cuda and let it go at that. On Wed, May 20, 2015 at 4:09 PM, Aaron Ballman aa...@aaronballman.com wrote: This has one interesting ramification which I wasn't quite expecting. cuda_builtin_vars.h uses

Re: Is __declspec a core language extension?

2015-05-20 Thread Reid Kleckner
+1 for throwing it under -fms-extensions. On Wed, May 20, 2015 at 2:54 PM, Aaron Ballman aa...@aaronballman.com wrote: While refactoring some attribute parsing code, I noticed that we do not guard __declspec as being a Microsoft-specific extension that we support. This is consistent with the

Re: [PATCH] add the -mrecip driver flag and process its options

2015-05-20 Thread Sanjay Patel
Patch updated: Fixed variable names to not look like macros. http://reviews.llvm.org/D8989 Files: include/clang/Basic/TargetOptions.h include/clang/Driver/Options.td lib/CodeGen/BackendUtil.cpp lib/Driver/Tools.cpp lib/Frontend/CompilerInvocation.cpp test/Driver/mrecip.c EMAIL

r237870 - [Driver] Improve unused-argument diagnostic for extra sanitizer features.

2015-05-20 Thread Alexey Samsonov
Author: samsonov Date: Wed May 20 20:07:52 2015 New Revision: 237870 URL: http://llvm.org/viewvc/llvm-project?rev=237870view=rev Log: [Driver] Improve unused-argument diagnostic for extra sanitizer features. Don't print unused-argument warning for sanitizer-specific feature flag if this

r237872 - Avoid using a C++11 library feature not present in libstdc++4.7.

2015-05-20 Thread Richard Smith
Author: rsmith Date: Wed May 20 20:26:53 2015 New Revision: 237872 URL: http://llvm.org/viewvc/llvm-project?rev=237872view=rev Log: Avoid using a C++11 library feature not present in libstdc++4.7. Modified: cfe/trunk/lib/Lex/PPLexerChange.cpp Modified: cfe/trunk/lib/Lex/PPLexerChange.cpp

Re: r237608 - Detect uses of mismatching forms of 'new' and 'delete'

2015-05-20 Thread Ismail Pazarbasi
I think I put it there after reading: test/PCH/cxx_exprs.cpp:4:// Test with pch. Use '-ast-dump' to force deserialization of function bodies. I have made a patch to address this issue, but it will need a review. On Wed, May 20, 2015 at 7:46 PM, Richard Trieu rtr...@google.com wrote: Modified:

[PATCH] MismatchingNewDeleteDetector uses incorrect field, and finds no initializer

2015-05-20 Thread Ismail Pazarbasi
Hi rsmith, rtrieu, In `MismatchingNewDeleteDetector::analyzeInClassInitializer`, if `Field`'s initializer expression is null, lookup the field in implicit instantiation, and use found field's the initializer. http://reviews.llvm.org/D9898 Files: lib/Sema/SemaExprCXX.cpp

Re: r237608 - Detect uses of mismatching forms of 'new' and 'delete'

2015-05-20 Thread Richard Smith
On Wed, May 20, 2015 at 3:19 PM, Ismail Pazarbasi ismail.pazarb...@gmail.com wrote: I think I put it there after reading: test/PCH/cxx_exprs.cpp:4:// Test with pch. Use '-ast-dump' to force deserialization of function bodies. That test is wrong; -ast-dump doesn't force deserialization any

Re: [PATCH] MismatchingNewDeleteDetector uses incorrect field, and finds no initializer

2015-05-20 Thread Richard Smith
Comment at: lib/Sema/SemaExprCXX.cpp:2494 @@ +2493,3 @@ +TemplateSpecializationKind TSK = ParentRD-getTemplateSpecializationKind(); +if (isTemplateInstantiation(TSK)) { + CXXRecordDecl *ClassPattern = ParentRD-getTemplateInstantiationPattern();

Re: Is __declspec a core language extension?

2015-05-20 Thread Aaron Ballman
This has one interesting ramification which I wasn't quite expecting. cuda_builtin_vars.h uses __declspec(property), and it seems strange to me that someone who wishes to use CUDA should have to also use -fms-extensions. I'm not certain what the correct answer is for this particular case. ~Aaron

r237856 - Check for bool-like conversion in conditional expressions.

2015-05-20 Thread Richard Trieu
Author: rtrieu Date: Wed May 20 18:29:18 2015 New Revision: 237856 URL: http://llvm.org/viewvc/llvm-project?rev=237856view=rev Log: Check for bool-like conversion in conditional expressions. Add a check for bool-like conversions for the condition expression of conditional operators. This is

Re: Is __declspec a core language extension?

2015-05-20 Thread Richard Smith
Can we just enable __declspec for CUDA rather than all of -fms-extensions? Long-term, we should probably have some syntax for this CUDA evilness that's not the MS __declspec extension... On Wed, May 20, 2015 at 5:13 PM, Reid Kleckner r...@google.com wrote: That's Art's fault. Probably the

Re: [PATCH] [OPENMP] Allow to disable OpenMP support and link libgomp

2015-05-20 Thread Chandler Carruth
Yea, i think Daniel's patch was a closer start. Anyways, thanks for taking a stab at this. http://reviews.llvm.org/D9875 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ ___ cfe-commits mailing list

Re: r234143 - This reverts commit r234104, bringing back 233393 now that ARM is fixed.

2015-05-20 Thread Rafael Espíndola
This regressed binary size of Chromium on Linux with 1300 kB. Our theory is that the linker [1] is dead-stripping more effectively with unique section names for some reason. It is ICF, which is why it didn't reproduce with the clang binary. I reduced this to

Re: [PATCH] Fix assertion failure with constant lvalues.

2015-05-20 Thread John Garvin
Ping. Is this ready to commit? John On May 19, 2015, at 6:11 PM, John Garvin jgar...@apple.com wrote: No, no commit access. John http://reviews.llvm.org/D9805 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/

Re: [PATCH] [OPENMP] Allow to disable OpenMP support and link libgomp

2015-05-20 Thread Alexey Bataev
Already has been fixed by Richard Smith. http://reviews.llvm.org/D9875 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ ___ cfe-commits mailing list cfe-commits@cs.uiuc.edu

Re: [PATCH] Fix assertion failure with constant lvalues.

2015-05-20 Thread John Garvin
Ping. Is this ready to commit? John http://reviews.llvm.org/D9805 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ ___ cfe-commits mailing list cfe-commits@cs.uiuc.edu

[PATCH] [PPC64] Add vector quadword add/sub instructions for POWER8

2015-05-20 Thread Kit Barton
Hi hfinkel, wschmidt, seurer, nemanjai, Clang-related changes for http://reviews.llvm.org/D9081 Add builtins for the following vector quadword add/sub instructions introduced in POWER8: - vadduqm - vaddeuqm - vaddcuq - vaddecuq - vsubuqm - vsubeuqm - vsubcuq - vsubecuq All

Re: [PATCH] [OPENMP] Allow to disable OpenMP support and link libgomp

2015-05-20 Thread Chandler Carruth
Yea, i think Daniel's patch was a closer start. Anyways, thanks for taking a stab at this. On Wed, May 20, 2015 at 8:04 PM Alexey Bataev a.bat...@hotmail.com wrote: Already has been fixed by Richard Smith. http://reviews.llvm.org/D9875 EMAIL PREFERENCES

Re: [PATCH] [OPENMP] Do not emit references to original variables in 'private' clause.

2015-05-20 Thread Bataev, Alexey
Yeah, I thought about it already. Hope to prepare a fix for it today Best regards, Alexey Bataev = Software Engineer Intel Compiler Team 20.05.2015 20:03, John McCall пишет: Sema doesn't know much about the shareds structure, either. To be sure, it builds it as part of building