Re: [PATCH] Enhance clang-tidy readability-simplify-boolean-expr to handle 'if (e) return true; return false; ' and improve replacement expressions.

2015-05-31 Thread Richard
Document transformations applied to replacement expression. Replace implicit pointer to boolean conversions with explicit comparison to `nullptr`. http://reviews.llvm.org/D9810 Files: clang-tidy/readability/SimplifyBooleanExprCheck.cpp clang-tidy/readability/SimplifyBooleanExprCheck.h

[PATCH] Remove redundant check for value dependency of null pointer constant

2015-05-31 Thread dyp
Hi rsmith, doug.gregor, In SemaOverload.cpp, the isNullPointerConstantForConversion function contains a redundant check for value dependency of a null pointer constant. The same check is performed in Expr::isNullPointerConstant, where the implementation is adapted to various special cases and

Re: [PATCH] Enhance clang-tidy readability-simplify-boolean-expr to handle 'if (e) return true; return false; ' and improve replacement expressions.

2015-05-31 Thread Richard
Remove unnecessary includes. http://reviews.llvm.org/D9810 Files: clang-tidy/readability/SimplifyBooleanExprCheck.cpp clang-tidy/readability/SimplifyBooleanExprCheck.h test/clang-tidy/readability-simplify-bool-expr-chained-conditional-return.cpp

Re: [PATCH] Enhance clang-tidy readability-simplify-boolean-expr to handle 'if (e) return true; return false; '

2015-05-31 Thread Richard
Improve handling of replacement expressions to apply explicit casts to `bool` where necessary. http://reviews.llvm.org/D9810 Files: clang-tidy/readability/SimplifyBooleanExprCheck.cpp clang-tidy/readability/SimplifyBooleanExprCheck.h

Re: [libcxx] r238666 - Don't try to memcpy zero bytes; sometimes the source pointer is NULL, and that's UB. Thanks to Nuno Lopes for the catch.

2015-05-31 Thread David Majnemer
On Sat, May 30, 2015 at 8:13 PM, Marshall Clow mclow.li...@gmail.com wrote: Author: marshall Date: Sat May 30 22:13:31 2015 New Revision: 238666 URL: http://llvm.org/viewvc/llvm-project?rev=238666view=rev Log: Don't try to memcpy zero bytes; sometimes the source pointer is NULL, and

[PATCH] Fix printing of C style casts with suppressed specifiers

2015-05-31 Thread Nick Sumner
Hi all, The attached patch allows C style casts to be printed correctly even when the incoming PrintingPolicy suppresses specifiers. This can happen, for instance, when casts occur during the initialization of variables inside a DeclGroup. Given the code: void foo() { int *x = ((void *)0), *y =

r238673 - [Format] Move UnwrappedLines instead of copying.

2015-05-31 Thread Benjamin Kramer
Author: d0k Date: Sun May 31 06:18:05 2015 New Revision: 238673 URL: http://llvm.org/viewvc/llvm-project?rev=238673view=rev Log: [Format] Move UnwrappedLines instead of copying. No functional change intended. Modified: cfe/trunk/lib/Format/UnwrappedLineParser.cpp Modified:

r238671 - clang-format: [JS] Fix line breaks in computed property names.

2015-05-31 Thread Daniel Jasper
Author: djasper Date: Sun May 31 03:40:37 2015 New Revision: 238671 URL: http://llvm.org/viewvc/llvm-project?rev=238671view=rev Log: clang-format: [JS] Fix line breaks in computed property names. Before: let foo = { [someLongKeyHere]: 1, someOtherLongKeyHere: 2, [keyLongEnoughToWrap]:

r238672 - clang-format: NFC. Cleanup after r237895.

2015-05-31 Thread Daniel Jasper
Author: djasper Date: Sun May 31 03:51:54 2015 New Revision: 238672 URL: http://llvm.org/viewvc/llvm-project?rev=238672view=rev Log: clang-format: NFC. Cleanup after r237895. Specifically adhere to LLVM Coding Standards (no 'else' after return/break/continue) and remove yet another

[libcxx] r238674 - Remove debugging code

2015-05-31 Thread Marshall Clow
Author: marshall Date: Sun May 31 09:01:54 2015 New Revision: 238674 URL: http://llvm.org/viewvc/llvm-project?rev=238674view=rev Log: Remove debugging code Modified: libcxx/trunk/include/memory Modified: libcxx/trunk/include/memory URL:

Re: [PATCH] [libcxx] Fix detection of __is_final.

2015-05-31 Thread Marshall Clow
LGTM. http://reviews.llvm.org/D8795 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ ___ cfe-commits mailing list cfe-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits