r241433 - Replace some const std::string with llvm::StringRef or std::string

Author: yrnkrn Date: Mon Jul 6 03:47:15 2015 New Revision: 241433 URL: http://llvm.org/viewvc/llvm-project?rev=241433view=rev Log: Replace some const std::string with llvm::StringRef or std::string and std::move to avoid implicit std::string construction. Patch by Eugene Kosov. Modified:

Re: [PATCH] replace some const std::string with llvm::StringRef or std::string

Committed revision 241433. 2015-07-05 0:30 GMT+03:00 Eugene Kosov clap...@yandex.ru: Hi. Here is the patch which fixes clang unit tests build. I built llvm without tests - sorry for that. 03.07.2015, 12:42, Yaron Keren yaron.ke...@gmail.com: Hi Eugene, This patch fails the unittests

Re: [PATCH] D10805: Disabling of redefine_extname pragma for C++ code

Ping! http://reviews.llvm.org/D10805 ___ cfe-commits mailing list cfe-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

Re: [PATCH] D10892: warning when inner condition is identical

danielmarjamaki marked an inline comment as done. http://reviews.llvm.org/D10892 ___ cfe-commits mailing list cfe-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

Re: [PATCH] D10892: warning when inner condition is identical

added a few test cases as suggested by Kim. http://reviews.llvm.org/D10892 Files: lib/StaticAnalyzer/Checkers/IdenticalExprChecker.cpp test/Analysis/identical-expressions.cpp Index: test/Analysis/identical-expressions.cpp

Enable ReparseWithModule only if threads

This addresses http://llvm.org/pr20325, this unit test fails when threads are disabled. Index: tools/clang/unittests/libclang/LibclangTest.cpp === --- tools/clang/unittests/libclang/LibclangTest.cpp (revision 241427) +++

r241432 - Teach mingw toolchain the msys2 mingw-w64 distribution C++ dirs.

Author: yrnkrn Date: Mon Jul 6 02:40:10 2015 New Revision: 241432 URL: http://llvm.org/viewvc/llvm-project?rev=241432view=rev Log: Teach mingw toolchain the msys2 mingw-w64 distribution C++ dirs. Modified: cfe/trunk/lib/Driver/MinGWToolChain.cpp cfe/trunk/lib/Driver/ToolChains.h

Re: [PATCH] D10634: Loss of Sign Checker

In http://reviews.llvm.org/D10634#198447, @danielmarjamaki wrote: ftp://ftp.sunet.se/pub/Linux/distributions/Debian/debian/pool/main/a/abcm2ps/abcm2ps_7.8.9.orig.tar.gz clang-tidy abcm2ps-7.8.9/deco.c deco.c:788:9: warning: assigning negative value to unsigned variable loses sign and may

r241439 - clang-format: Fix __attribute__ being treated as decl name.

Author: djasper Date: Mon Jul 6 06:30:34 2015 New Revision: 241439 URL: http://llvm.org/viewvc/llvm-project?rev=241439view=rev Log: clang-format: Fix __attribute__ being treated as decl name. __attribute__ was treated as the name of a function definition, with the tokens in parentheses being

Re: [PATCH] Disabling of redefine_extname pragma for C++ code

On Mon, Jun 29, 2015 at 11:13 AM, Andrey Bokhanko andreybokha...@gmail.com wrote: Hi aaron.ballman, rsmith, In response to Richard Smith's comment (http://lists.cs.uiuc.edu/pipermail/cfe-commits/Week-of-Mon-20150622/131782.html), this patch disables redefine_extname pragma for C++ code.

Re: [PATCH] D10373: clang-format: Fix __attribute__ being treated as decl name.

djasper closed this revision. Submitted as r241439. http://reviews.llvm.org/D10373 ___ cfe-commits mailing list cfe-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

Re: [PATCH] D10634: Loss of Sign Checker

Here is a bigger log with more warnings. there are some cases where I don't think there should be a warning.. for instance some compound assignments: args.c:990:9: warning: assigning negative value to unsigned variable loses sign and may cause undesired runtime behavior

Re: [PATCH] [OPENMP] Initial support for '#pragma omp declare simd' directive.

On Mon, Jun 22, 2015 at 7:35 AM, Alexey Bataev a.bat...@hotmail.com wrote: Hi rsmith, aaron.ballman, hfinkel, ejstotzer, fraggamuffin, Inital parsing/sema/serialization/deserialization support for '#pragma omp declare simd' directive. The declare simd construct can be applied to a function

r241444 - clang-format: [JS] Prevent confusing TypeScript parameters wraps.

Author: djasper Date: Mon Jul 6 09:07:51 2015 New Revision: 241444 URL: http://llvm.org/viewvc/llvm-project?rev=241444view=rev Log: clang-format: [JS] Prevent confusing TypeScript parameters wraps. Before: aa(: aa, :

[libcxx] r241492 - Automatically detect and use clang verify in failure tests.

Author: ericwf Date: Mon Jul 6 14:56:45 2015 New Revision: 241492 URL: http://llvm.org/viewvc/llvm-project?rev=241492view=rev Log: Automatically detect and use clang verify in failure tests. Automatically enable clang verify whenever the '-verify-ignore-unexpected' flag is supported. Failure

[libcxxabi] r241499 - Creating release candidate final from release_362 branch

Author: tstellar Date: Mon Jul 6 15:00:28 2015 New Revision: 241499 URL: http://llvm.org/viewvc/llvm-project?rev=241499view=rev Log: Creating release candidate final from release_362 branch Added: libcxxabi/tags/RELEASE_362/final/ (props changed) - copied from r241498,

[libcxx] r241498 - Creating release candidate final from release_362 branch

Author: tstellar Date: Mon Jul 6 15:00:26 2015 New Revision: 241498 URL: http://llvm.org/viewvc/llvm-project?rev=241498view=rev Log: Creating release candidate final from release_362 branch Added: libcxx/tags/RELEASE_362/final/ (props changed) - copied from r241497,

Re: [PATCH] D10935: [Sema] Don't emit pure virtual warning for fully qualified calls.

In http://reviews.llvm.org/D10935#199903, @thakis wrote: Maybe the ; overrides of 'f' in subclasses are not available in the constructor of 'A' should just be omitted in this case? (This is probably up to Richard.) Maybe add a note qualified call to 'A::f' is treated as a virtual call to

Re: [PATCH] D10972: Add missing builtins to altivec.h for ABI compliance (vol. 3)

Comment at: lib/Basic/Targets.cpp:1025 @@ +1024,3 @@ + HasDirectMove = false; + VSXDisabled = true; +} Oops, there was supposed to be a continue here. Added to the source tree. Repository: rL LLVM http://reviews.llvm.org/D10972

Re: [PATCH] D10907: [CodeGen] Correctly handle base classes which are passed in memory

rnk accepted this revision. This revision is now accepted and ready to land. lgtm http://reviews.llvm.org/D10907 ___ cfe-commits mailing list cfe-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

r241471 - Update testcase to reflect new behavior in DIBuilder.

Author: adrian Date: Mon Jul 6 11:36:04 2015 New Revision: 241471 URL: http://llvm.org/viewvc/llvm-project?rev=241471view=rev Log: Update testcase to reflect new behavior in DIBuilder. Modified: cfe/trunk/test/CodeGenCXX/debug-info-namespace.cpp Modified:

Re: [PATCH] D10935: [Sema] Don't emit pure virtual warning for fully qualified calls.

The kext bits look good to me. I'm not sure if not warning on this at all is a good idea (it looks pretty weird), but the existing warning isn't correct. Maybe the ; overrides of 'f' in subclasses are not available in the constructor of 'A' should just be omitted in this case? (This is probably

Re: [PATCH] D10669: Part 1 of N4279 - Improved insertion interface for unique-key maps

EricWF accepted this revision. This revision is now accepted and ready to land. LGTM modulo inline comments. Comment at: include/map:1138 @@ +1137,3 @@ +else +return emplace_hint(__p, + _VSTD::piecewise_construct,

r241511 - Debug info: Don't emit a bogus location for the global block pointer type

Author: adrian Date: Mon Jul 6 16:31:35 2015 New Revision: 241511 URL: http://llvm.org/viewvc/llvm-project?rev=241511view=rev Log: Debug info: Don't emit a bogus location for the global block pointer type (__block_literal_generic). The arbitrary nature of the location confuses lldb and prevents

Re: [PATCH] D10406: [libcxx] Add atomic_support.h header to src that handles needed atomic operations.

1. Fix increment/decrement consistency to fix PR22803. 2. Put functions in `atomic_support.h` inside an inline namespace. 3. Generate a build warning on MSVC when atomics aren't supported. 4. Fix bad assertion inside shared_ptr race condition test case. I don't think we should make any attempt

Re: r239579 - Add support for the the target attribute.

Eric Christopher echri...@gmail.com writes: Author: echristo Date: Thu Jun 11 20:35:52 2015 New Revision: 239579 URL: http://llvm.org/viewvc/llvm-project?rev=239579view=rev Log: Add support for the the target attribute. Modeled after the gcc attribute of the same name, this feature

r241467 - Resubmit Pass down the -flto option to the -cc1 job (r239481)

Author: tejohnson Date: Mon Jul 6 11:23:00 2015 New Revision: 241467 URL: http://llvm.org/viewvc/llvm-project?rev=241467view=rev Log: Resubmit Pass down the -flto option to the -cc1 job (r239481) The patch is the same except for the addition of a new test for the issue that required reverting

Re: [PATCH] D10949: A step towards getting libclang tests working on Windows

Comment at: tools/clang/include/clang-c/BuildSystem.h:92 @@ +91,3 @@ + */ +CINDEX_LINKAGE void clang_free(char *out_buffer_ptr); + out_buffer_ptr doesn't make sense as a parameter name; it is not an out param. Probably 'buffer' or something is fine. Repository:

Re: r239579 - Add support for the the target attribute.

On Thu, Jun 11, 2015 at 9:35 PM, Eric Christopher echri...@gmail.com wrote: Author: echristo Date: Thu Jun 11 20:35:52 2015 New Revision: 239579 URL: http://llvm.org/viewvc/llvm-project?rev=239579view=rev Log: Add support for the the target attribute. Modeled after the gcc attribute of

r241478 - [Sema] Warn when shifting a negative value.

Author: davide Date: Mon Jul 6 13:02:09 2015 New Revision: 241478 URL: http://llvm.org/viewvc/llvm-project?rev=241478view=rev Log: [Sema] Warn when shifting a negative value. Example: % ./clang -Wshift-negative-value emit.c emit.c:3:14: warning: shifting a negative signed value is undefined

Re: [PATCH] D10949: A step towards getting libclang tests working on Windows

Changed type, name of input argument of clang_free and its description. Repository: rL LLVM http://reviews.llvm.org/D10949 Files: tools/clang/include/clang-c/BuildSystem.h tools/clang/tools/libclang/BuildSystem.cpp tools/clang/tools/libclang/libclang.exports

Re: [PATCH] D10935: [Sema] Don't emit pure virtual warning for fully qualified calls.

davide added a reviewer: thakis. davide removed a subscriber: thakis. davide removed rL LLVM as the repository for this revision. Addressed Nico's comments. While at it added a test. Nico, I hope this is the right way of checking. http://reviews.llvm.org/D10935 Files:

Re: r241467 - Resubmit Pass down the -flto option to the -cc1 job (r239481)

I think I probably asked this before - but just to check, the reason these definitions are left in is because the actual external definition may not be in the lto build? (Otherwise you could drop the available externally definition in each object/bitcode file and know that you could clone it from

Re: [PATCH] D10938: [Sema] Warn when shifting a negative value

davide closed this revision. Now in tree, r241478. Thank you for the review, Richard. Repository: rL LLVM http://reviews.llvm.org/D10938 ___ cfe-commits mailing list cfe-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

r241485 - Support -pthread in mingw toolchain.

Author: yrnkrn Date: Mon Jul 6 13:52:19 2015 New Revision: 241485 URL: http://llvm.org/viewvc/llvm-project?rev=241485view=rev Log: Support -pthread in mingw toolchain. -pthread appends -lpthread after the object files list passed to the linker. Modified: cfe/trunk/lib/Driver/Tools.cpp

Re: r241467 - Resubmit Pass down the -flto option to the -cc1 job (r239481)

On Mon, Jul 6, 2015 at 11:18 AM, David Blaikie dblai...@gmail.com wrote: I think I probably asked this before - but just to check, the reason these definitions are left in is because the actual external definition may not be in the lto build? (Otherwise you could drop the available externally

Re: [PATCH] replace some const std::string with llvm::StringRef or std::string

Thank you! I appreciate your help. So much trouble with such a simple patch. 06.07.2015, 13:25, Yaron Keren yaron.ke...@gmail.com: Committed revision 241433. 2015-07-05 0:30 GMT+03:00 Eugene Kosov clap...@yandex.ru: Hi. Here is the patch which fixes clang unit tests build. I built llvm

Re: [PATCH] D10739: [MIPS] Add support for direct-to-nacl in Clang

Ping. Repository: rL LLVM http://reviews.llvm.org/D10739 ___ cfe-commits mailing list cfe-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

[libcxx] r241491 - Mark LWG#2420 as complete. Eric did this in r228705.

Author: marshall Date: Mon Jul 6 14:36:44 2015 New Revision: 241491 URL: http://llvm.org/viewvc/llvm-project?rev=241491view=rev Log: Mark LWG#2420 as complete. Eric did this in r228705. Modified: libcxx/trunk/www/cxx1z_status.html Modified: libcxx/trunk/www/cxx1z_status.html URL:

r241518 - Refactor to avoid long if-condition.

Author: rsmith Date: Mon Jul 6 17:56:29 2015 New Revision: 241518 URL: http://llvm.org/viewvc/llvm-project?rev=241518view=rev Log: Refactor to avoid long if-condition. Modified: cfe/trunk/lib/Sema/SemaDecl.cpp Modified: cfe/trunk/lib/Sema/SemaDecl.cpp URL:

Re: [PATCH] D10272: Fix alignment issues in Clang.

So, a couple things: Firstly: I think it's pretty sad that this idiom of manually dealing with memory layout is used all over the place, and has basically no abstraction. In addition to having to coordinate carefully between allocation and access, as it stands, it's almost impossible to tell

Re: [PATCH] D8802: [libc++] Fix PR22606 - Leak pthread_key with static storage duration to ensure all of thread-local destructors are called.

In http://reviews.llvm.org/D8802#187303, @EricWF wrote: OK. I have some new thoughts. The `__thread_struct` destructor serves three purposes when it is invoked at thread exit. 1. Notifying registered condition variables. 2. Making registered shared state ready. 3. Deleting the tuple of

r241524 - Add some basic documentation for the __attribute__((target())) support.

Author: echristo Date: Mon Jul 6 18:51:56 2015 New Revision: 241524 URL: http://llvm.org/viewvc/llvm-project?rev=241524view=rev Log: Add some basic documentation for the __attribute__((target())) support. Describes the general syntax of how it's used with the unfortunate usage of subtarget

r241526 - Update target attribute support for post-commit feedback.

Author: echristo Date: Mon Jul 6 18:52:01 2015 New Revision: 241526 URL: http://llvm.org/viewvc/llvm-project?rev=241526view=rev Log: Update target attribute support for post-commit feedback. Use const auto rather than duplicating the type name and fix the error message when the attribute is

r241525 - Handle arbitrary whitespace in the target attribute support.

Author: echristo Date: Mon Jul 6 18:51:59 2015 New Revision: 241525 URL: http://llvm.org/viewvc/llvm-project?rev=241525view=rev Log: Handle arbitrary whitespace in the target attribute support. This allows us to deal a bit more gracefully with inclusions done by macros, token pasting, or just

r241529 - Remember to mark the target attribute as documented and clean up the

Author: echristo Date: Mon Jul 6 19:01:55 2015 New Revision: 241529 URL: http://llvm.org/viewvc/llvm-project?rev=241529view=rev Log: Remember to mark the target attribute as documented and clean up the Subjects line to avoid redundancy. Modified: cfe/trunk/include/clang/Basic/Attr.td

Re: r241428 - PR24030, PR24033: Consistently check whether a new declaration conflicts with

On Mon, Jul 6, 2015 at 2:56 PM, Sean Silva chisophu...@gmail.com wrote: + if (SS.isEmpty() TUK != TUK_Reference TUK != TUK_Friend + isDeclInScope(Shadow, SearchDC, S, isExplicitSpecialization) + !(OldTag +(getLangOpts().MSVCCompat + ?

Re: r241526 - Update target attribute support for post-commit feedback.

On Mon, Jul 6, 2015 at 7:52 PM, Eric Christopher echri...@gmail.com wrote: Author: echristo Date: Mon Jul 6 18:52:01 2015 New Revision: 241526 URL: http://llvm.org/viewvc/llvm-project?rev=241526view=rev Log: Update target attribute support for post-commit feedback. Use const auto rather

Re: r241525 - Handle arbitrary whitespace in the target attribute support.

On Mon, Jul 6, 2015 at 7:51 PM, Eric Christopher echri...@gmail.com wrote: Author: echristo Date: Mon Jul 6 18:51:59 2015 New Revision: 241525 URL: http://llvm.org/viewvc/llvm-project?rev=241525view=rev Log: Handle arbitrary whitespace in the target attribute support. This allows us to

Re: [PATCH] D10272: Fix alignment issues in Clang.

I think there were issues with trailing arrays, which is why Clang ended up settling on this pattern in the first place. Barring significant changes, I think wrapping this up with some library code is the way to go. That's kind of what we were thinking with getTrailingObjects(). :-) I think

r241528 - [Driver] Use llvm::Triple methods to handle -EL and -EB.

Author: d0k Date: Mon Jul 6 18:59:45 2015 New Revision: 241528 URL: http://llvm.org/viewvc/llvm-project?rev=241528view=rev Log: [Driver] Use llvm::Triple methods to handle -EL and -EB. Add a test for ppc64(le), which wasn't handled before. Added: cfe/trunk/test/Driver/ppc-endian.c

Re: r241478 - [Sema] Warn when shifting a negative value.

Looks like this broke bootstrap: http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux/builds/18993/steps/bootstrap%20clang/logs/stdio On 6 July 2015 at 14:02, Davide Italiano dav...@freebsd.org wrote: Author: davide Date: Mon Jul 6 13:02:09 2015 New Revision: 241478 URL:

Re: r241524 - Add some basic documentation for the __attribute__((target())) support.

On Mon, Jul 6, 2015 at 7:51 PM, Eric Christopher echri...@gmail.com wrote: Author: echristo Date: Mon Jul 6 18:51:56 2015 New Revision: 241524 URL: http://llvm.org/viewvc/llvm-project?rev=241524view=rev Log: Add some basic documentation for the __attribute__((target())) support.

Re: r239579 - Add support for the the target attribute.

You get a single email reply for the two of you. :) Fixed the requests with the following: dzur:~/sources/llvm/tools/clang git svn dcommit Committing to https://llvm.org/svn/llvm-project/cfe/trunk ... M include/clang/Basic/AttrDocs.td Committed r241524 M include/clang/Basic/AttrDocs.td r241524 =

Re: r241526 - Update target attribute support for post-commit feedback.

On Mon, Jul 6, 2015 at 4:57 PM Aaron Ballman aa...@aaronballman.com wrote: On Mon, Jul 6, 2015 at 7:52 PM, Eric Christopher echri...@gmail.com wrote: Author: echristo Date: Mon Jul 6 18:52:01 2015 New Revision: 241526 URL: http://llvm.org/viewvc/llvm-project?rev=241526view=rev Log:

Re: [PATCH] D10406: [libcxx] Add atomic_support.h header to src that handles needed atomic operations.

Remove unrelated change in `thread`. http://reviews.llvm.org/D10406 Files: include/memory include/mutex src/memory.cpp src/mutex.cpp src/support/atomic_support.h test/libcxx/utilities/memory/util.smartptr/race_condition.pass.cpp Index:

Re: r241524 - Add some basic documentation for the __attribute__((target())) support.

On Mon, Jul 6, 2015 at 4:55 PM Aaron Ballman aa...@aaronballman.com wrote: On Mon, Jul 6, 2015 at 7:51 PM, Eric Christopher echri...@gmail.com wrote: Author: echristo Date: Mon Jul 6 18:51:56 2015 New Revision: 241524 URL: http://llvm.org/viewvc/llvm-project?rev=241524view=rev Log:

Re: [PATCH] D10406: [libcxx] Add atomic_support.h header to src that handles needed atomic operations.

mclow.lists accepted this revision. This revision is now accepted and ready to land. Except for the stuff in thread, this looks good. Comment at: include/thread:338 @@ -338,2 +337,3 @@ +__invoke(_VSTD::get0(_VSTD::move(__t)), _VSTD::get_Indices(_VSTD::move(__t))...); }

Re: r241428 - PR24030, PR24033: Consistently check whether a new declaration conflicts with

+ if (SS.isEmpty() TUK != TUK_Reference TUK != TUK_Friend + isDeclInScope(Shadow, SearchDC, S, isExplicitSpecialization) + !(OldTag +(getLangOpts().MSVCCompat + ? SearchDC-getRedeclContext()-Encloses( +

Re: [PATCH] D10272: Fix alignment issues in Clang.

rnk added a subscriber: rnk. Most of actual fixes look good, but this adds an awful lot of static_asserts, and they are very far from the code implementing the trailing object array idiom. I chatted with Richard, and he suggested that wrap up the `reinterpret_castT(this + 1)` idiom into

r241533 - Revert Revert 241171, 241187, 241199 (32-bit SEH).

Author: rnk Date: Mon Jul 6 19:36:30 2015 New Revision: 241533 URL: http://llvm.org/viewvc/llvm-project?rev=241533view=rev Log: Revert Revert 241171, 241187, 241199 (32-bit SEH). This reverts commit r241244, but restricts SEH support to Win64. This way, Chromium builds will still fall back on

Re: r241478 - [Sema] Warn when shifting a negative value.

On Mon, Jul 6, 2015 at 4:47 PM, Rafael Espíndola rafael.espind...@gmail.com wrote: Looks like this broke bootstrap: http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux/builds/18993/steps/bootstrap%20clang/logs/stdio Hopefully fixed. On 6 July 2015 at 14:02, Davide Italiano

r241534 - Debug info: Emit distinct __block_literal_generic types for blocks with

Author: adrian Date: Mon Jul 6 19:49:35 2015 New Revision: 241534 URL: http://llvm.org/viewvc/llvm-project?rev=241534view=rev Log: Debug info: Emit distinct __block_literal_generic types for blocks with different function signatures. (Previously clang would emit all block pointer types with the

[libcxx] r241532 - [libcxx] Add atomic_support.h header to src that handles needed atomic operations.

Author: ericwf Date: Mon Jul 6 19:27:16 2015 New Revision: 241532 URL: http://llvm.org/viewvc/llvm-project?rev=241532view=rev Log: [libcxx] Add atomic_support.h header to src that handles needed atomic operations. Summary: In some places in libc++ we need to use the `__atomic_*` builtins. This

[libcxx] r241539 - Implement N4279 and LWG#2664 for map. Reviewed as http://reviews.llvm.org/D10669

Author: marshall Date: Mon Jul 6 22:37:33 2015 New Revision: 241539 URL: http://llvm.org/viewvc/llvm-project?rev=241539view=rev Log: Implement N4279 and LWG#2664 for map. Reviewed as http://reviews.llvm.org/D10669 Added:

Re: [PATCH] D10669: Part 1 of N4279 - Improved insertion interface for unique-key maps

mclow.lists closed this revision. Committed as r241539. http://reviews.llvm.org/D10669 ___ cfe-commits mailing list cfe-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

r241541 - Parsing, semantic analysis, and AST for Objective-C type parameters.

Author: dgregor Date: Mon Jul 6 22:57:15 2015 New Revision: 241541 URL: http://llvm.org/viewvc/llvm-project?rev=241541view=rev Log: Parsing, semantic analysis, and AST for Objective-C type parameters. Produce type parameter declarations for Objective-C type parameters, and attach lists of type

r241545 - C++ support for Objective-C lightweight generics.

Author: dgregor Date: Mon Jul 6 22:58:14 2015 New Revision: 241545 URL: http://llvm.org/viewvc/llvm-project?rev=241545view=rev Log: C++ support for Objective-C lightweight generics. Teach C++'s tentative parsing to handle specializations of Objective-C class types (e.g., NSArrayNSString *) as

r241546 - Warn when an Objective-C collection literal element is converted to an incompatible type.

Author: dgregor Date: Mon Jul 6 22:58:22 2015 New Revision: 241546 URL: http://llvm.org/viewvc/llvm-project?rev=241546view=rev Log: Warn when an Objective-C collection literal element is converted to an incompatible type. Objective-C collection literals produce unspecialized

r241549 - Implement variance for Objective-C type parameters.

Author: dgregor Date: Mon Jul 6 22:58:54 2015 New Revision: 241549 URL: http://llvm.org/viewvc/llvm-project?rev=241549view=rev Log: Implement variance for Objective-C type parameters. Introduce co- and contra-variance for Objective-C type parameters, which allows us to express that (for

r241550 - Factor the simpleTransform() visitor so that it is not a local class.

Author: dgregor Date: Mon Jul 6 22:58:59 2015 New Revision: 241550 URL: http://llvm.org/viewvc/llvm-project?rev=241550view=rev Log: Factor the simpleTransform() visitor so that it is not a local class. Older versions of Clang cannot handle such local classes properly rdar://problem/19386032.

r241554 - Fix alignment check for ObjCObjectTypeLoc.

Author: dgregor Date: Mon Jul 6 23:23:51 2015 New Revision: 241554 URL: http://llvm.org/viewvc/llvm-project?rev=241554view=rev Log: Fix alignment check for ObjCObjectTypeLoc. Modified: cfe/trunk/include/clang/AST/TypeLoc.h Modified: cfe/trunk/include/clang/AST/TypeLoc.h URL:

Re: [PATCH] D10669: Part 1 of N4279 - Improved insertion interface for unique-key maps

Comment at: test/std/containers/associative/map/map.modifiers/try.emplace.pass.cpp:73 @@ +72,3 @@ + +Moveable mv1(3, 3.0); +r = m.try_emplace(2, std::move(mv1)); EricWF wrote: For the sake of covering corner cases could we test every inserted

r241542 - Handle Objective-C type arguments.

Author: dgregor Date: Mon Jul 6 22:57:35 2015 New Revision: 241542 URL: http://llvm.org/viewvc/llvm-project?rev=241542view=rev Log: Handle Objective-C type arguments. Objective-C type arguments can be provided in angle brackets following an Objective-C interface type. Syntactically, this is the

r241544 - Improve the Objective-C common-type computation used by the ternary operator.

Author: dgregor Date: Mon Jul 6 22:58:01 2015 New Revision: 241544 URL: http://llvm.org/viewvc/llvm-project?rev=241544view=rev Log: Improve the Objective-C common-type computation used by the ternary operator. The Objective-C common-type computation had a few problems that required a

r241548 - Implement the Objective-C __kindof type qualifier.

Author: dgregor Date: Mon Jul 6 22:58:42 2015 New Revision: 241548 URL: http://llvm.org/viewvc/llvm-project?rev=241548view=rev Log: Implement the Objective-C __kindof type qualifier. The __kindof type qualifier can be applied to Objective-C object (pointer) types to indicate id-like behavior,

r241547 - Warn when an intended Objective-C specialization was actually a useless protocol qualification.

Author: dgregor Date: Mon Jul 6 22:58:28 2015 New Revision: 241547 URL: http://llvm.org/viewvc/llvm-project?rev=241547view=rev Log: Warn when an intended Objective-C specialization was actually a useless protocol qualification. Warn in cases where one has provided redundant protocol

r241551 - Use llvm::alignOf rather than alignof()

Author: dgregor Date: Mon Jul 6 23:06:31 2015 New Revision: 241551 URL: http://llvm.org/viewvc/llvm-project?rev=241551view=rev Log: Use llvm::alignOf rather than alignof() Modified: cfe/trunk/include/clang/AST/TypeLoc.h Modified: cfe/trunk/include/clang/AST/TypeLoc.h URL:

Re: r241550 - Factor the simpleTransform() visitor so that it is not a local class.

Is there a particular reason you're using lowerCamelCase for local variables in this patch set? -- Sean Silva On Mon, Jul 6, 2015 at 8:58 PM, Douglas Gregor dgre...@apple.com wrote: Author: dgregor Date: Mon Jul 6 22:58:59 2015 New Revision: 241550 URL:

Re: [PATCH] D10739: [MIPS] Add support for direct-to-nacl in Clang

dschuff accepted this revision. This revision is now accepted and ready to land. Comment at: lib/Driver/ToolChains.cpp:2391 @@ +2390,3 @@ + file_paths.push_back(FilePath + mipsel-nacl/usr/lib); + prog_paths.push_back(ProgPath + bin); + file_paths.push_back(ToolPath

Re: [PATCH] D10739: [MIPS] Add support for direct-to-nacl in Clang

oh, also don't forget to add a test, similar to nacl-direct.c (or add to that directly) Repository: rL LLVM http://reviews.llvm.org/D10739 ___ cfe-commits mailing list cfe-commits@cs.uiuc.edu

[libcxx] r241555 - The rest of N4279 and LWG#2464 - for unordered_map

Author: marshall Date: Tue Jul 7 00:45:35 2015 New Revision: 241555 URL: http://llvm.org/viewvc/llvm-project?rev=241555view=rev Log: The rest of N4279 and LWG#2464 - for unordered_map Added: libcxx/trunk/test/std/containers/unord/unord.map/unorder.map.modifiers/insert_or_assign.pass.cpp

r241431 - [TableGen] Change a couple methods to return an ArrayRef instead of a const std::vector reference. NFC

Author: ctopper Date: Mon Jul 6 01:23:06 2015 New Revision: 241431 URL: http://llvm.org/viewvc/llvm-project?rev=241431view=rev Log: [TableGen] Change a couple methods to return an ArrayRef instead of a const std::vector reference. NFC Modified: cfe/trunk/utils/TableGen/ClangAttrEmitter.cpp

r241446 - clang-format: [JS] Properly reset parse state after parsing interface.

Author: djasper Date: Mon Jul 6 09:26:04 2015 New Revision: 241446 URL: http://llvm.org/viewvc/llvm-project?rev=241446view=rev Log: clang-format: [JS] Properly reset parse state after parsing interface. Modified: cfe/trunk/lib/Format/UnwrappedLineParser.cpp

Re: [PATCH] D9126: PR23175 (unit test) - Infinite loop iterating Objective-C method declarations in categories when the AST was deserialized from an .ast file

What's the state of this? I'm not sure who that question is directed to. You haven't accepted the review, so I presume you are awaiting updates, probably from me. Unfortunately, my time is very limited. Repository: rL LLVM http://reviews.llvm.org/D9126

Re: [PATCH] D10729: Make locale code compile on CloudABI.

Friendly ping! :-) Repository: rL LLVM http://reviews.llvm.org/D10729 ___ cfe-commits mailing list cfe-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

[libcxx] r241454 - Cleanup: prefer _LIBCPP_GET_C_LOCALE over __cloc().

Author: ed Date: Mon Jul 6 10:37:40 2015 New Revision: 241454 URL: http://llvm.org/viewvc/llvm-project?rev=241454view=rev Log: Cleanup: prefer _LIBCPP_GET_C_LOCALE over __cloc(). The __cloc() function is only present in case the environment does not provide a way to refer to the C locale using

Re: [PATCH] D10700: Driver: Add AMDGPU toolchain

dougk added a subscriber: dougk. Comment at: lib/Driver/ToolChains.h:726 @@ -725,1 +725,3 @@ +class LLVM_LIBRARY_VISIBILITY AMDGPU_TC : public Generic_ELF { +protected: Please use ToolChain instead of _TC as the suffix. See http://reviews.llvm.org/D10609

Re: [PATCH] D9126: PR23175 (unit test) - Infinite loop iterating Objective-C method declarations in categories when the AST was deserialized from an .ast file

On Mon, Jul 6, 2015 at 4:54 PM Tom Honermann thonerm...@coverity.com wrote: What's the state of this? I'm not sure who that question is directed to. You haven't accepted the review, so I presume you are awaiting updates, probably from me. Unfortunately, my time is very limited.

[libcxx] r241455 - Make locale code compile on CloudABI.

Author: ed Date: Mon Jul 6 10:39:36 2015 New Revision: 241455 URL: http://llvm.org/viewvc/llvm-project?rev=241455view=rev Log: Make locale code compile on CloudABI. After r241454 landed, libc++'s locale code compiles on CloudABI, with the exception of the following two bits: - CloudABI doesn't

[PATCH] D10963: Implement LWG#2063: Contradictory requirements for string move assignment

mclow.lists added a reviewer: EricWF. mclow.lists added a subscriber: cfe-commits. Update the noexcept-ness of move-construction and move-assignment for `basic_string`. Use the new is_always_equal type trait for noexcept stuff when we're building with C++17. Preserve the conforming extension

Re: [PATCH] D10729: Make locale code compile on CloudABI.

jroelofs accepted this revision. This revision is now accepted and ready to land. LGTM Repository: rL LLVM http://reviews.llvm.org/D10729 ___ cfe-commits mailing list cfe-commits@cs.uiuc.edu

Re: [PATCH] D10949: A step towards getting libclang tests working on Windows

doug.gregor added a subscriber: doug.gregor. doug.gregor requested changes to this revision. doug.gregor added a reviewer: doug.gregor. This revision now requires changes to proceed. It would be fantastic to get these tests running on Windows (and make libclang more usable on Windows in

Re: [PATCH] D10690: Cleanup: prefer _LIBCPP_GET_C_LOCALE over __cloc().

Friendly ping! :-) Repository: rL LLVM http://reviews.llvm.org/D10690 ___ cfe-commits mailing list cfe-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

Re: [PATCH] D10690: Cleanup: prefer _LIBCPP_GET_C_LOCALE over __cloc().

jroelofs accepted this revision. This revision is now accepted and ready to land. LGTM Repository: rL LLVM http://reviews.llvm.org/D10690 ___ cfe-commits mailing list cfe-commits@cs.uiuc.edu

r241451 - Grammar bug. NFC

Author: dougk Date: Mon Jul 6 10:25:31 2015 New Revision: 241451 URL: http://llvm.org/viewvc/llvm-project?rev=241451view=rev Log: Grammar bug. NFC Modified: cfe/trunk/docs/CrossCompilation.rst Modified: cfe/trunk/docs/CrossCompilation.rst URL:

Re: [PATCH] D10700: Driver: Add AMDGPU toolchain

Ping. http://reviews.llvm.org/D10700 ___ cfe-commits mailing list cfe-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits