Re: [PATCH] [X86] Use sys::getHostCPUFeatures to improve -march=native

2015-03-31 Thread Craig Topper
r233672 http://reviews.llvm.org/D8694 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ ___ cfe-commits mailing list cfe-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

Re: [PATCH] [X86] Use sys::getHostCPUFeatures to improve -march=native

2015-03-30 Thread Craig Topper
The target-cpu is still used for LLVM features that don't have a real CPUID bit. For instance, slow-bt-mem and slow-incdec. It would also still be used to pick the scheduling model. http://reviews.llvm.org/D8694 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/

Re: [PATCH] [X86] Use sys::getHostCPUFeatures to improve -march=native

2015-03-30 Thread Rafael Ávila de Espíndola
This is fine by me, but I am not sure if I should be the one to LGTM it. Does this make passing -target-cpu for native redundant? http://reviews.llvm.org/D8694 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ ___

Re: [PATCH] [X86] Use sys::getHostCPUFeatures to improve -march=native

2015-03-30 Thread Chandler Carruth
Looks good, go for it. http://reviews.llvm.org/D8694 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ ___ cfe-commits mailing list cfe-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

Re: [PATCH] [X86] Use sys::getHostCPUFeatures to improve -march=native

2015-03-30 Thread Eric Christopher
I think this should be ok. It'll turn some hidden features that would have been target-cpu features into target-features features explicitly, but that'll just mean wordier attribute descriptions (and will be more accurate). -eric On Sun, Mar 29, 2015 at 9:16 PM Craig Topper

[PATCH] [X86] Use sys::getHostCPUFeatures to improve -march=native

2015-03-29 Thread Craig Topper
Hi chandlerc, echristo, rafael, grosbach, Some versions of Sandybridge, Ivybridge, Haswell, and Broadwell CPUs don't support AVX. Currently, getHostCPUName changes the CPU name to Nehalem when it detects one of the CPUs. This also ends up disabling other features that these CPUs might still