Re: [PATCH] Canonicalize the variadic template alias with multiple ellipsis.

2014-07-08 Thread Logan Chien
Subject: [PATCH] Canonicalize the variadic template alias with multiple ellipsis. --- lib/Sema/SemaTemplateInstantiate.cpp | 2 +- test/SemaTemplate/alias-templates.cpp | 14 ++ 2 files changed, 15 insertions(+), 1 deletion(-) diff --git a/lib/Sema/SemaTemplateInstantiate.cpp b/lib/Sema

Re: [PATCH] Canonicalize the variadic template alias with multiple ellipsis.

2014-07-08 Thread Richard Smith
On Mon, Jul 7, 2014 at 6:01 AM, Logan Chien tzuhsiang.ch...@gmail.com wrote: Ping? This patch tries to fix an assertion failure related to the template alias with two (or more) parameter packs. For example, template typename... T struct tuple; template typename... T struct extract_;

Re: [PATCH] Canonicalize the variadic template alias with multiple ellipsis.

2014-07-07 Thread Logan Chien
Ping? This patch tries to fix an assertion failure related to the template alias with two (or more) parameter packs. For example, template typename... T struct tuple; template typename... T struct extract_; template typename... T using extract = typename extract_T...::type; template typename...

[PATCH] Canonicalize the variadic template alias with multiple ellipsis.

2014-06-29 Thread Logan Chien
Hi rsmith, If the template has two variadic formal parameters, then the type might not be canonical. We have call ASTContext.getCanonicalType() to canonicalize the type; otherwise, an assertion failure will be raised. This patch fix this issue by adding getCanonicalType() in