Re: [PATCH] D11581: [SHAVE] Pass all -f, -g, -O, -W options through directly to moviCompile.

2015-08-03 Thread Douglas Katzman
This revision was automatically updated to reflect the committed changes. Closed by commit rL243878: [SHAVE] Pass all -f, -g, -O, -W options through directly to moviCompile. (authored by dougk). Changed prior to commit: http://reviews.llvm.org/D11581?vs=31029id=31230#toc Repository: rL LLVM

Re: [PATCH] D11581: [SHAVE] Pass all -f, -g, -O, -W options through directly to moviCompile.

2015-07-31 Thread James Y Knight
jyknight accepted this revision. jyknight added a comment. This revision is now accepted and ready to land. lgtm http://reviews.llvm.org/D11581 ___ cfe-commits mailing list cfe-commits@cs.uiuc.edu

Re: [PATCH] D11581: [SHAVE] Pass all -f, -g, -O, -W options through directly to moviCompile.

2015-07-30 Thread Douglas Katzman
dougk updated this revision to Diff 31029. dougk added a comment. Make fewer calls to AddAllArgs. http://reviews.llvm.org/D11581 Files: lib/Driver/Tools.cpp test/Driver/shave-toolchain.c Index: test/Driver/shave-toolchain.c

Re: [PATCH] D11581: [SHAVE] Pass all -f, -g, -O, -W options through directly to moviCompile.

2015-07-28 Thread Chandler Carruth
chandlerc added a subscriber: chandlerc. chandlerc added a comment. Comments from the peanut gallery... Comment at: lib/Driver/Tools.cpp:9482-9488 @@ -9481,13 +9481,9 @@ - // Any -O option passes through without translation. What about -Ofast ? - if (Arg *A =

[PATCH] D11581: [SHAVE] Pass all -f, -g, -O, -W options through directly to moviCompile.

2015-07-28 Thread Douglas Katzman
dougk created this revision. dougk added a reviewer: jyknight. dougk added a subscriber: cfe-commits. http://reviews.llvm.org/D11581 Files: lib/Driver/Tools.cpp test/Driver/shave-toolchain.c Index: test/Driver/shave-toolchain.c

Re: [PATCH] D11581: [SHAVE] Pass all -f, -g, -O, -W options through directly to moviCompile.

2015-07-28 Thread James Y Knight
jyknight added inline comments. Comment at: lib/Driver/Tools.cpp:9482-9488 @@ -9481,13 +9481,9 @@ - // Any -O option passes through without translation. What about -Ofast ? - if (Arg *A = Args.getLastArg(options::OPT_O_Group)) -A-render(Args, CmdArgs); - - if