Update.
http://reviews.llvm.org/D7032
Files:
src/Unwind/Unwind-EHABI.cpp
src/Unwind/Unwind-EHABI.h
src/Unwind/UnwindCursor.hpp
src/Unwind/UnwindLevel1-gcc-ext.c
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
Index: src/Unwind/Unwind-EHABI.cpp
Thanks. Committed as rL226822.
http://reviews.llvm.org/D7032
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
___
cfe-commits mailing list
cfe-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
Comment at: src/Unwind/UnwindLevel1-gcc-ext.c:103
@@ +102,3 @@
+#if LIBCXXABI_ARM_EHABI
+static inline uint32_t readPREL31(const uint32_t *data) {
+ uint32_t base = (uintptr_t) data;
jroelofs wrote:
would be nice to re-use signExtendPrel31 instead.
Done.
Address the review comments.
http://reviews.llvm.org/D7032
Files:
src/Unwind/Unwind-EHABI.cpp
src/Unwind/Unwind-EHABI.h
src/Unwind/UnwindCursor.hpp
src/Unwind/UnwindLevel1-gcc-ext.cpp
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
Index:
Comment at: src/Unwind/UnwindLevel1-gcc-ext.c:103
@@ +102,3 @@
+#if LIBCXXABI_ARM_EHABI
+static inline uint32_t readPREL31(const uint32_t *data) {
+ uint32_t base = (uintptr_t) data;
would be nice to re-use signExtendPrel31 instead.
Comment at:
I'll leave this one for @jroelofs... :)
http://reviews.llvm.org/D7032
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
___
cfe-commits mailing list
cfe-commits@cs.uiuc.edu
LGTM with those changes.
http://reviews.llvm.org/D7032
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
___
cfe-commits mailing list
cfe-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
Hi danalbert, rengolin, jroelofs,
If libcxxabi is compiled as a shared library, and the
executable references the user-defined personality routines
(e.g. __gxx_personality_v0), then the pointer comparison in
Unwind-EHABI.cpp won't work. This is due to the fact that
the PREL31 will point to the
