Re: [PATCH] Remove CleanupHackLevel for Exception Handling

2014-07-01 Thread John McCall
On Jun 30, 2014, at 11:31 AM, Reid Kleckner r...@google.com wrote: This is really a question for John, but I have a feeling that he'll be happy to see this code go. Yes, killing the hack is long-overdue. John. ___ cfe-commits mailing list

Re: [PATCH] Remove CleanupHackLevel for Exception Handling

2014-07-01 Thread Logan Chien
Thanks. Committed as r212097. On Tue, Jul 1, 2014 at 2:05 PM, John McCall rjmcc...@apple.com wrote: On Jun 30, 2014, at 11:31 AM, Reid Kleckner r...@google.com wrote: This is really a question for John, but I have a feeling that he'll be happy to see this code go. Yes, killing the hack

[PATCH] Remove CleanupHackLevel for Exception Handling

2014-06-30 Thread Logan Chien
Hi, I would like to propose to remove the CleanupHackLevel from CGException.cpp. This hack was originally written for the old exception handling intrinsics, which have several issues with function inliner. (Read [1] for more background on this hack.) Since LLVM 3.0, the new exception handling

Re: [PATCH] Remove CleanupHackLevel for Exception Handling

2014-06-30 Thread Reid Kleckner
This is really a question for John, but I have a feeling that he'll be happy to see this code go. On Mon, Jun 30, 2014 at 8:56 AM, Logan Chien tzuhsiang.ch...@gmail.com wrote: Hi, I would like to propose to remove the CleanupHackLevel from CGException.cpp. This hack was originally written