Just to be clear, this commit seems good to me, and I'm fine with it being
in, but please don't submit patches without review once you've asked for it.
On Tue, Jun 16, 2015 at 2:22 PM Chandler Carruth chandl...@google.com
wrote:
Doug, why did you commit this without review? That's not really
Doug, why did you commit this without review? That's not really cool after
you've asked folks to code review it and without any update.
On Tue, Jun 16, 2015 at 12:43 PM Douglas Katzman do...@google.com wrote:
REPOSITORY
rL LLVM
http://reviews.llvm.org/D10444
Files:
REPOSITORY
rL LLVM
http://reviews.llvm.org/D10444
Files:
cfe/trunk/lib/Driver/ToolChains.cpp
Index: cfe/trunk/lib/Driver/ToolChains.cpp
===
--- cfe/trunk/lib/Driver/ToolChains.cpp
+++ cfe/trunk/lib/Driver/ToolChains.cpp
@@
Hi t.p.northover,
This seems to have been unintentional but was preserved across several moves
of the code, so... not quite sure why.
http://reviews.llvm.org/D10444
Files:
lib/Driver/ToolChains.cpp
Index: lib/Driver/ToolChains.cpp
