Re: [cfe-commits] r165771 - in /cfe/trunk: include/clang/AST/ASTContext.h include/clang/AST/Comment.h lib/AST/ASTContext.cpp lib/AST/Comment.cpp lib/AST/CommentSema.cpp test/Index/overriding-method-co

2012-10-18 Thread Dmitri Gribenko
On Fri, Oct 12, 2012 at 2:52 AM, Fariborz Jahanian fjahan...@apple.com wrote: +comments::FullComment *ASTContext::cloneFullComment(comments::FullComment *FC, +const Decl *D) const { + comments::DeclInfo *ThisDeclInfo = new (*this)

Re: [cfe-commits] r165771 - in /cfe/trunk: include/clang/AST/ASTContext.h include/clang/AST/Comment.h lib/AST/ASTContext.cpp lib/AST/Comment.cpp lib/AST/CommentSema.cpp test/Index/overriding-method-co

2012-10-18 Thread Douglas Gregor
Hi Dmitri, On Oct 18, 2012, at 5:03 AM, Dmitri Gribenko griboz...@gmail.com wrote: On Fri, Oct 12, 2012 at 2:52 AM, Fariborz Jahanian fjahan...@apple.com wrote: +comments::FullComment *ASTContext::cloneFullComment(comments::FullComment *FC, +

Re: [cfe-commits] r165771 - in /cfe/trunk: include/clang/AST/ASTContext.h include/clang/AST/Comment.h lib/AST/ASTContext.cpp lib/AST/Comment.cpp lib/AST/CommentSema.cpp test/Index/overriding-method-co

2012-10-18 Thread Dmitri Gribenko
On Thu, Oct 18, 2012 at 7:18 PM, Douglas Gregor dgre...@apple.com wrote: On Oct 18, 2012, at 5:03 AM, Dmitri Gribenko griboz...@gmail.com wrote: I think that cloneFullComment() is evil -- it breaks some assumptions about DeclInfo and does not properly introduce a concept of a comment being

Re: [cfe-commits] r165771 - in /cfe/trunk: include/clang/AST/ASTContext.h include/clang/AST/Comment.h lib/AST/ASTContext.cpp lib/AST/Comment.cpp lib/AST/CommentSema.cpp test/Index/overriding-method-co

2012-10-18 Thread Douglas Gregor
On Oct 18, 2012, at 9:56 AM, Dmitri Gribenko griboz...@gmail.com wrote: On Thu, Oct 18, 2012 at 7:18 PM, Douglas Gregor dgre...@apple.com wrote: On Oct 18, 2012, at 5:03 AM, Dmitri Gribenko griboz...@gmail.com wrote: I think that cloneFullComment() is evil -- it breaks some assumptions about

Re: [cfe-commits] r165771 - in /cfe/trunk: include/clang/AST/ASTContext.h include/clang/AST/Comment.h lib/AST/ASTContext.cpp lib/AST/Comment.cpp lib/AST/CommentSema.cpp test/Index/overriding-method-co

2012-10-18 Thread jahanian
On Oct 18, 2012, at 9:18 AM, Douglas Gregor dgre...@apple.com wrote: Hi Dmitri, On Oct 18, 2012, at 5:03 AM, Dmitri Gribenko griboz...@gmail.com wrote: (2) ParamCommandComment::getParamName and others used to return the parameter name *as written* in \param command, without any regard

Re: [cfe-commits] r165771 - in /cfe/trunk: include/clang/AST/ASTContext.h include/clang/AST/Comment.h lib/AST/ASTContext.cpp lib/AST/Comment.cpp lib/AST/CommentSema.cpp test/Index/overriding-method-co

2012-10-15 Thread jahanian
On Oct 12, 2012, at 11:06 AM, Douglas Gregor dgre...@apple.com wrote: On Oct 11, 2012, at 4:52 PM, Fariborz Jahanian fjahan...@apple.com wrote: Author: fjahanian Date: Thu Oct 11 18:52:50 2012 New Revision: 165771 URL: http://llvm.org/viewvc/llvm-project?rev=165771view=rev Log:

Re: [cfe-commits] r165771 - in /cfe/trunk: include/clang/AST/ASTContext.h include/clang/AST/Comment.h lib/AST/ASTContext.cpp lib/AST/Comment.cpp lib/AST/CommentSema.cpp test/Index/overriding-method-co

2012-10-12 Thread Douglas Gregor
On Oct 11, 2012, at 4:52 PM, Fariborz Jahanian fjahan...@apple.com wrote: Author: fjahanian Date: Thu Oct 11 18:52:50 2012 New Revision: 165771 URL: http://llvm.org/viewvc/llvm-project?rev=165771view=rev Log: search for overridden methods with comment when overriding method has none of