Re: VerifyDiagnosticConsumer and ModuleMapParser

2014-11-12 Thread Richard Smith
On Mon, Nov 10, 2014 at 6:52 AM, Vassil Vassilev vasil.georgiev.vasi...@cern.ch wrote: It seems to me not a bad idea: if we are planning to provide better diagnostics of 'ill-formed' modulemaps. We could use FileCheck but I thought -verify was invented for such cases. I agree. We currently

Re: VerifyDiagnosticConsumer and ModuleMapParser

2014-11-10 Thread Vassil Vassilev
It seems to me not a bad idea: if we are planning to provide better diagnostics of 'ill-formed' modulemaps. We could use FileCheck but I thought -verify was invented for such cases. Vassil On 11/07/2014 01:09 AM, Jordan Rose wrote: Is it really worth putting effort into -verify for this? I'd

Re: VerifyDiagnosticConsumer and ModuleMapParser

2014-11-06 Thread Ben Langmuir
On Nov 3, 2014, at 2:38 PM, Vassil Vassilev vvasi...@cern.ch wrote: On 03/11/14 16:49, Ben Langmuir wrote: On Nov 3, 2014, at 2:10 AM, Vassil Vassilev vvasi...@cern.ch wrote: Hi guys, I am working on http://llvm.org/bugs/show_bug.cgi?id=20507 Now the diagnostic gets issued for:

Re: VerifyDiagnosticConsumer and ModuleMapParser

2014-11-06 Thread Jordan Rose
Is it really worth putting effort into -verify for this? I'd be okay with just using FileCheck: // CHECK: {{Inputs[/\\]declare-use[/\\]module.map}}:30:10: note: header file... Jordan On Nov 3, 2014, at 2:10 , Vassil Vassilev vvasi...@cern.ch wrote: Hi guys, I am working on

VerifyDiagnosticConsumer and ModuleMapParser

2014-11-03 Thread Vassil Vassilev
Hi guys, I am working on http://llvm.org/bugs/show_bug.cgi?id=20507 Now the diagnostic gets issued for: Clang :: Modules/declare-use1.cpp Clang :: Modules/declare-use2.cpp Clang :: Modules/declare-use3.cpp Clang :: Modules/strict-decluse.cpp It says smth like:

Re: VerifyDiagnosticConsumer and ModuleMapParser

2014-11-03 Thread Ben Langmuir
On Nov 3, 2014, at 2:10 AM, Vassil Vassilev vvasi...@cern.ch wrote: Hi guys, I am working on http://llvm.org/bugs/show_bug.cgi?id=20507 Now the diagnostic gets issued for: Clang :: Modules/declare-use1.cpp Clang :: Modules/declare-use2.cpp Clang :: Modules/declare-use3.cpp

Re: VerifyDiagnosticConsumer and ModuleMapParser

2014-11-03 Thread Vassil Vassilev
On 03/11/14 16:49, Ben Langmuir wrote: On Nov 3, 2014, at 2:10 AM, Vassil Vassilev vvasi...@cern.ch wrote: Hi guys, I am working on http://llvm.org/bugs/show_bug.cgi?id=20507 Now the diagnostic gets issued for: Clang :: Modules/declare-use1.cpp Clang :: Modules/declare-use2.cpp