r243968 - [Edit] Use StringRef's copy method. No functional change intended.

2015-08-04 Thread Benjamin Kramer
Author: d0k Date: Tue Aug 4 06:18:09 2015 New Revision: 243968 URL: http://llvm.org/viewvc/llvm-project?rev=243968view=rev Log: [Edit] Use StringRef's copy method. No functional change intended. Modified: cfe/trunk/include/clang/Edit/Commit.h cfe/trunk/include/clang/Edit/EditedSource.h

r243972 - [ASTContext] Add a templated convenience wrapper for Allocate.

2015-08-04 Thread Benjamin Kramer
Author: d0k Date: Tue Aug 4 07:34:23 2015 New Revision: 243972 URL: http://llvm.org/viewvc/llvm-project?rev=243972view=rev Log: [ASTContext] Add a templated convenience wrapper for Allocate. This brings ASTContext closer to LLVM's Allocator concept. Ideally we would just derive ASTContext from

r243973 - [CodeGen] Don't write into a SmallVector's uninitialized memory.

2015-08-04 Thread Benjamin Kramer
Author: d0k Date: Tue Aug 4 07:34:30 2015 New Revision: 243973 URL: http://llvm.org/viewvc/llvm-project?rev=243973view=rev Log: [CodeGen] Don't write into a SmallVector's uninitialized memory. That's just ugly and not needed in this case. No functionality change. Modified:

r243974 - [AST] Simplify code by letting ArrayRef do the copying.

2015-08-04 Thread Benjamin Kramer
Author: d0k Date: Tue Aug 4 07:59:41 2015 New Revision: 243974 URL: http://llvm.org/viewvc/llvm-project?rev=243974view=rev Log: [AST] Simplify code by letting ArrayRef do the copying. No functionality change intended. Modified: cfe/trunk/lib/AST/Type.cpp Modified:

r243970 - [FileManager] Use StringRef::copy to store canonical paths.

2015-08-04 Thread Benjamin Kramer
Author: d0k Date: Tue Aug 4 06:27:08 2015 New Revision: 243970 URL: http://llvm.org/viewvc/llvm-project?rev=243970view=rev Log: [FileManager] Use StringRef::copy to store canonical paths. No functional change intended. Modified: cfe/trunk/lib/Basic/FileManager.cpp Modified:

r243979 - [AST] Really allocate a SmallVector to the right size.

2015-08-04 Thread Benjamin Kramer
Author: d0k Date: Tue Aug 4 08:34:50 2015 New Revision: 243979 URL: http://llvm.org/viewvc/llvm-project?rev=243979view=rev Log: [AST] Really allocate a SmallVector to the right size. set_size only resets the end pointer and asserts if it is used to grow the buffer. This would crash when

r243987 - [Sema] Allocate SmallVector to the right size.

2015-08-04 Thread Benjamin Kramer
Author: d0k Date: Tue Aug 4 09:46:06 2015 New Revision: 243987 URL: http://llvm.org/viewvc/llvm-project?rev=243987view=rev Log: [Sema] Allocate SmallVector to the right size. SmallVector::set_size does not reallocate the vector. Sadly I have no idea how to test this. The vector never has more

r243966 - [AST] Use StringRef's convenient copy method. No functionality change.

2015-08-04 Thread Benjamin Kramer
Author: d0k Date: Tue Aug 4 05:22:38 2015 New Revision: 243966 URL: http://llvm.org/viewvc/llvm-project?rev=243966view=rev Log: [AST] Use StringRef's convenient copy method. No functionality change. Modified: cfe/trunk/lib/AST/Stmt.cpp Modified: cfe/trunk/lib/AST/Stmt.cpp URL:

r243989 - [Sema] Add a crazy test case for r243987

2015-08-04 Thread Benjamin Kramer
Author: d0k Date: Tue Aug 4 10:18:16 2015 New Revision: 243989 URL: http://llvm.org/viewvc/llvm-project?rev=243989view=rev Log: [Sema] Add a crazy test case for r243987 It's not valid code (maybe it can be made valid, but I'm not sure how). To trigger the crash fixed in r243987 requires a

Re: r243987 - [Sema] Allocate SmallVector to the right size.

2015-08-04 Thread Benjamin Kramer
On 04.08.2015, at 17:10, Yaron Keren yaron.ke...@gmail.com wrote: This could be added to the regression tests... Fair enough, r243989. It's just a coverage test but better than nothing. - Ben 2015-08-04 18:09 GMT+03:00 Benjamin Kramer benny@gmail.com: On 04.08.2015, at 17:01

r243992 - [CodeGen] Fold memcpy into SmallVector initializer. No functionality change.

2015-08-04 Thread Benjamin Kramer
Author: d0k Date: Tue Aug 4 10:38:49 2015 New Revision: 243992 URL: http://llvm.org/viewvc/llvm-project?rev=243992view=rev Log: [CodeGen] Fold memcpy into SmallVector initializer. No functionality change. Modified: cfe/trunk/lib/CodeGen/CGException.cpp Modified:

Re: r243987 - [Sema] Allocate SmallVector to the right size.

2015-08-04 Thread Benjamin Kramer
() { Xint::Aint::Bint::Cint::Dint::Eint() += 1.0; }; I don't think that's valid C++ though. We have zero test coverage for TempParamLists.size() 1. - Ben 2015-08-04 17:46 GMT+03:00 Benjamin Kramer benny@googlemail.com: Author: d0k Date: Tue Aug 4 09:46:06 2015 New Revision

Re: r243425 - [CodeGen] Clean up CGBuiltin a bit.

2015-07-29 Thread Benjamin Kramer
On Wed, Jul 29, 2015 at 2:25 AM, David Blaikie dblai...@gmail.com wrote: On Tue, Jul 28, 2015 at 8:40 AM, Benjamin Kramer benny@googlemail.com wrote: Author: d0k Date: Tue Jul 28 10:40:11 2015 New Revision: 243425 URL: http://llvm.org/viewvc/llvm-project?rev=243425view=rev Log

r243425 - [CodeGen] Clean up CGBuiltin a bit.

2015-07-28 Thread Benjamin Kramer
Author: d0k Date: Tue Jul 28 10:40:11 2015 New Revision: 243425 URL: http://llvm.org/viewvc/llvm-project?rev=243425view=rev Log: [CodeGen] Clean up CGBuiltin a bit. - Use cached LLVM types - Turn SmallVectors into Arrays/ArrayRef if the size is static - Use ConstantInt::get's implicit splatting

r243439 - [CodeGen] Simplify creation of shuffle masks.

2015-07-28 Thread Benjamin Kramer
Author: d0k Date: Tue Jul 28 11:25:32 2015 New Revision: 243439 URL: http://llvm.org/viewvc/llvm-project?rev=243439view=rev Log: [CodeGen] Simplify creation of shuffle masks. No functional change intended. Modified: cfe/trunk/include/clang/AST/Expr.h cfe/trunk/lib/AST/Expr.cpp

Re: r242608 - [AST] Cleanup ExprIterator.

2015-07-27 Thread Benjamin Kramer
something truly generic there is always child_begin()/child_end(). - Ben On 07/18/2015 05:35 PM, Benjamin Kramer wrote: Author: d0k Date: Sat Jul 18 09:35:53 2015 New Revision: 242608 URL: http://llvm.org/viewvc/llvm-project?rev=242608view=rev Log: [AST] Cleanup ExprIterator. - Make

Re: r243243 - [MS Extensions] Remove support for the i128 integer literal suffix

2015-07-26 Thread Benjamin Kramer
On Sun, Jul 26, 2015 at 6:58 PM, Saleem Abdulrasool compn...@compnerd.org wrote: On Sun, Jul 26, 2015 at 2:02 AM, David Majnemer david.majne...@gmail.com wrote: Author: majnemer Date: Sun Jul 26 04:02:26 2015 New Revision: 243243 URL: http://llvm.org/viewvc/llvm-project?rev=243243view=rev

r243217 - [AST] Turn the callbacks of lookupInBases and forallBases into a function_ref

2015-07-25 Thread Benjamin Kramer
Author: d0k Date: Sat Jul 25 10:07:25 2015 New Revision: 243217 URL: http://llvm.org/viewvc/llvm-project?rev=243217view=rev Log: [AST] Turn the callbacks of lookupInBases and forallBases into a function_ref This lets us pass functors (and lambdas) without void * tricks. On the downside we can't

r243221 - [VTableBuilder] Turn functors into lambdas

2015-07-25 Thread Benjamin Kramer
Author: d0k Date: Sat Jul 25 11:31:30 2015 New Revision: 243221 URL: http://llvm.org/viewvc/llvm-project?rev=243221view=rev Log: [VTableBuilder] Turn functors into lambdas No functional change intended. Modified: cfe/trunk/lib/AST/VTableBuilder.cpp Modified:

r243222 - [VTableBuilder] Use range-based for loops. No functional change intended

2015-07-25 Thread Benjamin Kramer
Author: d0k Date: Sat Jul 25 12:10:49 2015 New Revision: 243222 URL: http://llvm.org/viewvc/llvm-project?rev=243222view=rev Log: [VTableBuilder] Use range-based for loops. No functional change intended Modified: cfe/trunk/lib/AST/VTableBuilder.cpp Modified:

r243218 - Capture 'this' so GCC 4.7 can find a static members.

2015-07-25 Thread Benjamin Kramer
Author: d0k Date: Sat Jul 25 10:27:04 2015 New Revision: 243218 URL: http://llvm.org/viewvc/llvm-project?rev=243218view=rev Log: Capture 'this' so GCC 4.7 can find a static members. Modified: cfe/trunk/lib/AST/CXXInheritance.cpp Modified: cfe/trunk/lib/AST/CXXInheritance.cpp URL:

r243227 - [libclang] Use lambdas instead of explicit structs when storing arguments.

2015-07-25 Thread Benjamin Kramer
Author: d0k Date: Sat Jul 25 15:55:44 2015 New Revision: 243227 URL: http://llvm.org/viewvc/llvm-project?rev=243227view=rev Log: [libclang] Use lambdas instead of explicit structs when storing arguments. This boilerplate code was necessary to move arguments between threads in C++98, lambdas make

r243213 - [Modules] Wrap the main ModuleManager visitor in a function_ref.

2015-07-25 Thread Benjamin Kramer
Author: d0k Date: Sat Jul 25 07:14:04 2015 New Revision: 243213 URL: http://llvm.org/viewvc/llvm-project?rev=243213view=rev Log: [Modules] Wrap the main ModuleManager visitor in a function_ref. Avoids the awkward passing of an opaque void *UserData argument. No functional change intended.

r242678 - [CodeGen] Flip lanes when lowering __builtin_palignr with one lane

2015-07-20 Thread Benjamin Kramer
Author: d0k Date: Mon Jul 20 10:31:17 2015 New Revision: 242678 URL: http://llvm.org/viewvc/llvm-project?rev=242678view=rev Log: [CodeGen] Flip lanes when lowering __builtin_palignr with one lane Otherwise we'd pick the wrong lane for the resulting shuffle and miscompile code. PR24187.

Re: r242678 - [CodeGen] Flip lanes when lowering __builtin_palignr with one lane

2015-07-20 Thread Benjamin Kramer
On 20.07.2015, at 17:31, Benjamin Kramer benny@googlemail.com wrote: Author: d0k Date: Mon Jul 20 10:31:17 2015 New Revision: 242678 URL: http://llvm.org/viewvc/llvm-project?rev=242678view=rev Log: [CodeGen] Flip lanes when lowering __builtin_palignr with one lane Otherwise we'd

[clang-tools-extra] r242607 - [clang-modernize] Don't rely on iterator auto-dereferencing.

2015-07-18 Thread Benjamin Kramer
Author: d0k Date: Sat Jul 18 09:35:41 2015 New Revision: 242607 URL: http://llvm.org/viewvc/llvm-project?rev=242607view=rev Log: [clang-modernize] Don't rely on iterator auto-dereferencing. Modified: clang-tools-extra/trunk/clang-modernize/UseAuto/UseAutoActions.cpp Modified:

r242608 - [AST] Cleanup ExprIterator.

2015-07-18 Thread Benjamin Kramer
Author: d0k Date: Sat Jul 18 09:35:53 2015 New Revision: 242608 URL: http://llvm.org/viewvc/llvm-project?rev=242608view=rev Log: [AST] Cleanup ExprIterator. - Make it a proper random access iterator with a little help from iterator_adaptor_base - Clean up users of magic dereferencing. The

Re: r242608 - [AST] Cleanup ExprIterator.

2015-07-18 Thread Benjamin Kramer
() + ArgVec.size(), CD, IsCopy ? 1 : 0); thus avoiding the dereference passes the tests. Makes sense, applied your suggested fix in r242622. Thanks! - Ben 2015-07-18 17:35 GMT+03:00 Benjamin Kramer benny@googlemail.com: Author: d0k Date: Sat Jul 18 09:35:53 2015 New

r242622 - [CodeGen] Don't dereference vector::end if the vector can be empty

2015-07-18 Thread Benjamin Kramer
Author: d0k Date: Sat Jul 18 15:30:11 2015 New Revision: 242622 URL: http://llvm.org/viewvc/llvm-project?rev=242622view=rev Log: [CodeGen] Don't dereference vector::end if the vector can be empty MSVC complains about this in debug mode. NFC. Modified:

r242615 - [AST] Remove StmtRange in favor of an iterator_range.

2015-07-18 Thread Benjamin Kramer
Author: d0k Date: Sat Jul 18 12:09:36 2015 New Revision: 242615 URL: http://llvm.org/viewvc/llvm-project?rev=242615view=rev Log: [AST] Remove StmtRange in favor of an iterator_range. StmtRange was just a convenient wrapper for two StmtIterators before we had real range support. This removes some

r242140 - [Analyzer] Move FindSuperCallVisitor into an anonymous namespace.

2015-07-14 Thread Benjamin Kramer
Author: d0k Date: Tue Jul 14 07:37:59 2015 New Revision: 242140 URL: http://llvm.org/viewvc/llvm-project?rev=242140view=rev Log: [Analyzer] Move FindSuperCallVisitor into an anonymous namespace. No functionality change. Modified:

r242154 - Pull trivial SanitizerSet methods into the header.

2015-07-14 Thread Benjamin Kramer
Author: d0k Date: Tue Jul 14 10:34:19 2015 New Revision: 242154 URL: http://llvm.org/viewvc/llvm-project?rev=242154view=rev Log: Pull trivial SanitizerSet methods into the header. Inlining them is always preferable to a call. NFC. Modified: cfe/trunk/include/clang/Basic/Sanitizers.h

r242064 - Move class into an anonymous namespace. NFC.

2015-07-13 Thread Benjamin Kramer
Author: d0k Date: Mon Jul 13 15:42:13 2015 New Revision: 242064 URL: http://llvm.org/viewvc/llvm-project?rev=242064view=rev Log: Move class into an anonymous namespace. NFC. Modified: cfe/trunk/lib/Sema/SemaDeclObjC.cpp Modified: cfe/trunk/lib/Sema/SemaDeclObjC.cpp URL:

r241902 - Try to fix the test harder, it still fails on windows for unknown reasons.

2015-07-10 Thread Benjamin Kramer
Author: d0k Date: Fri Jul 10 08:04:41 2015 New Revision: 241902 URL: http://llvm.org/viewvc/llvm-project?rev=241902view=rev Log: Try to fix the test harder, it still fails on windows for unknown reasons. Modified: cfe/trunk/test/Index/complete-ctor-inits.cpp Modified:

Re: r241811 - [CodeCompletion] Don't crash on member inits of templated constructors.

2015-07-10 Thread Benjamin Kramer
:{TypedText a}{LeftParen (}{Placeholder args}{RightParen )} (7) ^ stdin:1:1: note: scanning from here Completion contexts: ^ On Thu, Jul 9, 2015 at 8:31 AM, Benjamin Kramer benny@googlemail.com wrote: Author: d0k Date: Thu Jul 9 10:31:10 2015 New Revision

r241899 - Reapply test for r241811 with a fix for msvc compat mode.

2015-07-10 Thread Benjamin Kramer
Author: d0k Date: Fri Jul 10 06:37:54 2015 New Revision: 241899 URL: http://llvm.org/viewvc/llvm-project?rev=241899view=rev Log: Reapply test for r241811 with a fix for msvc compat mode. Delayed template parsing interferes with code completion, just distable it for this test. This reverts

r241811 - [CodeCompletion] Don't crash on member inits of templated constructors.

2015-07-09 Thread Benjamin Kramer
Author: d0k Date: Thu Jul 9 10:31:10 2015 New Revision: 241811 URL: http://llvm.org/viewvc/llvm-project?rev=241811view=rev Log: [CodeCompletion] Don't crash on member inits of templated constructors. Also fixes a crash (on invalid) member functions with a colon initializer. PR23948. Modified:

r241812 - [Driver] semi-annual ubuntu version bump.

2015-07-09 Thread Benjamin Kramer
Author: d0k Date: Thu Jul 9 10:31:17 2015 New Revision: 241812 URL: http://llvm.org/viewvc/llvm-project?rev=241812view=rev Log: [Driver] semi-annual ubuntu version bump. Modified: cfe/trunk/lib/Driver/ToolChains.cpp Modified: cfe/trunk/lib/Driver/ToolChains.cpp URL:

r241711 - Remove unused diagnostics. NFC.

2015-07-08 Thread Benjamin Kramer
Author: d0k Date: Wed Jul 8 14:10:43 2015 New Revision: 241711 URL: http://llvm.org/viewvc/llvm-project?rev=241711view=rev Log: Remove unused diagnostics. NFC. Modified: cfe/trunk/include/clang/Basic/DiagnosticDriverKinds.td cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td

Re: r241620 - Wrap clang modules and pch files in an object file container.

2015-07-07 Thread Benjamin Kramer
On 07.07.2015, at 22:11, Adrian Prantl apra...@apple.com wrote: Author: adrian Date: Tue Jul 7 15:11:29 2015 New Revision: 241620 URL: http://llvm.org/viewvc/llvm-project?rev=241620view=rev Log: Wrap clang modules and pch files in an object file container. This patch adds

r241528 - [Driver] Use llvm::Triple methods to handle -EL and -EB.

2015-07-06 Thread Benjamin Kramer
Author: d0k Date: Mon Jul 6 18:59:45 2015 New Revision: 241528 URL: http://llvm.org/viewvc/llvm-project?rev=241528view=rev Log: [Driver] Use llvm::Triple methods to handle -EL and -EB. Add a test for ppc64(le), which wasn't handled before. Added: cfe/trunk/test/Driver/ppc-endian.c

r241356 - StmtIterator: Put stmt and decl group pointer into a union.

2015-07-03 Thread Benjamin Kramer
Author: d0k Date: Fri Jul 3 10:12:36 2015 New Revision: 241356 URL: http://llvm.org/viewvc/llvm-project?rev=241356view=rev Log: StmtIterator: Put stmt and decl group pointer into a union. Reduce the size of StmtIterator without changing behavior. Modified:

r241355 - Rewrite users of Stmt::child_begin/end into for-range loops.

2015-07-03 Thread Benjamin Kramer
Author: d0k Date: Fri Jul 3 10:12:24 2015 New Revision: 241355 URL: http://llvm.org/viewvc/llvm-project?rev=241355view=rev Log: Rewrite users of Stmt::child_begin/end into for-range loops. No functionality change intended. Modified: cfe/trunk/lib/Analysis/LiveVariables.cpp

r241299 - [CodeGen] Use llvm::join to simplify string joining.

2015-07-02 Thread Benjamin Kramer
Author: d0k Date: Thu Jul 2 16:02:39 2015 New Revision: 241299 URL: http://llvm.org/viewvc/llvm-project?rev=241299view=rev Log: [CodeGen] Use llvm::join to simplify string joining. While there replace stable_sort of std::string with just sort, stability is not necessary for simple value types.

r240464 - [Driver] Give GnuTool LLVM_LIBRARY_VISIBILITY.

2015-06-23 Thread Benjamin Kramer
Author: d0k Date: Tue Jun 23 16:15:15 2015 New Revision: 240464 URL: http://llvm.org/viewvc/llvm-project?rev=240464view=rev Log: [Driver] Give GnuTool LLVM_LIBRARY_VISIBILITY. This is consistent with all other classes in Tools.h. Modified: cfe/trunk/lib/Driver/Tools.h Modified:

Re: r239605 - [clang-format] Reorder and pack ParenState members to minimize padding

2015-06-15 Thread Benjamin Kramer
On Mon, Jun 15, 2015 at 1:10 PM, Manuel Klimek kli...@google.com wrote: On Mon, Jun 15, 2015 at 12:56 PM Benjamin Kramer benny@gmail.com wrote: On Mon, Jun 15, 2015 at 6:30 AM, Manuel Klimek kli...@google.com wrote: Would have been interesting in the description to mention why

Re: r239605 - [clang-format] Reorder and pack ParenState members to minimize padding

2015-06-15 Thread Benjamin Kramer
allocations, which is about 7-8% of the total memory allocations performed by clang-format on that file. Peak memory doesn't change significantly though. - Ben On Fri, Jun 12, 2015, 4:47 PM Benjamin Kramer benny@gmail.com wrote: On Fri, Jun 12, 2015 at 4:28 PM, Daniel Jasper djas

Re: r239605 - [clang-format] Reorder and pack ParenState members to minimize padding

2015-06-15 Thread Benjamin Kramer
On Mon, Jun 15, 2015 at 1:01 PM, Manuel Klimek kli...@google.com wrote: On Mon, Jun 15, 2015 at 12:56 PM Benjamin Kramer benny@gmail.com wrote: On Mon, Jun 15, 2015 at 6:30 AM, Manuel Klimek kli...@google.com wrote: Would have been interesting in the description to mention why

r239604 - [clang-format] Hoist vector allocation out of loop. NFC.

2015-06-12 Thread Benjamin Kramer
Author: d0k Date: Fri Jun 12 08:06:57 2015 New Revision: 239604 URL: http://llvm.org/viewvc/llvm-project?rev=239604view=rev Log: [clang-format] Hoist vector allocation out of loop. NFC. Modified: cfe/trunk/lib/Format/FormatToken.cpp Modified: cfe/trunk/lib/Format/FormatToken.cpp URL:

r239605 - [clang-format] Reorder and pack ParenState members to minimize padding

2015-06-12 Thread Benjamin Kramer
Author: d0k Date: Fri Jun 12 08:07:03 2015 New Revision: 239605 URL: http://llvm.org/viewvc/llvm-project?rev=239605view=rev Log: [clang-format] Reorder and pack ParenState members to minimize padding sizeof(ParenState) goes from 64 bytes to 52 bytes. NFC. Modified:

r239606 - [clang-format] Use in-class initializers to simplify constructor.

2015-06-12 Thread Benjamin Kramer
Author: d0k Date: Fri Jun 12 09:39:08 2015 New Revision: 239606 URL: http://llvm.org/viewvc/llvm-project?rev=239606view=rev Log: [clang-format] Use in-class initializers to simplify constructor. Sadly C++11 doesn't let us use initializers on bitfield members (DR1341). NFC. Modified:

Re: r239605 - [clang-format] Reorder and pack ParenState members to minimize padding

2015-06-12 Thread Benjamin Kramer
in-class initializers in C++11 :( - Ben On Fri, Jun 12, 2015 at 3:07 PM, Benjamin Kramer benny@googlemail.com wrote: Author: d0k Date: Fri Jun 12 08:07:03 2015 New Revision: 239605 URL: http://llvm.org/viewvc/llvm-project?rev=239605view=rev Log: [clang-format] Reorder and pack

r239607 - push_back() loop - append() for random access iterators.

2015-06-12 Thread Benjamin Kramer
Author: d0k Date: Fri Jun 12 10:31:50 2015 New Revision: 239607 URL: http://llvm.org/viewvc/llvm-project?rev=239607view=rev Log: push_back() loop - append() for random access iterators. append will resize the vector to the optimal size. No functional change intended. Modified:

Re: r239402 - Remove rm invocations where the file is immediately rewritten later.

2015-06-09 Thread Benjamin Kramer
On Tue, Jun 9, 2015 at 6:02 PM, Greg Bedwell gregbedw...@gmail.com wrote: Remove rm invocations where the file is immediately rewritten later. This may or may not help making this test less flaky on windows. There's a race condition in lit somewhere. I've always assumed that this is just

r239402 - Remove rm invocations where the file is immediately rewritten later.

2015-06-09 Thread Benjamin Kramer
Author: d0k Date: Tue Jun 9 07:41:02 2015 New Revision: 239402 URL: http://llvm.org/viewvc/llvm-project?rev=239402view=rev Log: Remove rm invocations where the file is immediately rewritten later. This may or may not help making this test less flaky on windows. There's a race condition in lit

r239401 - Remove unused diagnostics.

2015-06-09 Thread Benjamin Kramer
Author: d0k Date: Tue Jun 9 07:17:19 2015 New Revision: 239401 URL: http://llvm.org/viewvc/llvm-project?rev=239401view=rev Log: Remove unused diagnostics. -Wreceiver-is-weak is unused but should be ignored, move it to the list of diagnostic groups. Modified:

Re: [PATCH] Change big 'if' statement into a switch. NFC

2015-06-03 Thread Benjamin Kramer
Looks good. Feel free to check in trivial changes like this for post-commit review. http://reviews.llvm.org/D10223 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ ___ cfe-commits mailing list cfe-commits@cs.uiuc.edu

Re: [PATCH] [x86-64 ABI] Fix for PR23082: an assertion failure when passing/returning a wrapper union in a full YMM register.

2015-06-02 Thread Benjamin Kramer
LGTM, thanks! http://reviews.llvm.org/D10190 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ ___ cfe-commits mailing list cfe-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

r238673 - [Format] Move UnwrappedLines instead of copying.

2015-05-31 Thread Benjamin Kramer
Author: d0k Date: Sun May 31 06:18:05 2015 New Revision: 238673 URL: http://llvm.org/viewvc/llvm-project?rev=238673view=rev Log: [Format] Move UnwrappedLines instead of copying. No functional change intended. Modified: cfe/trunk/lib/Format/UnwrappedLineParser.cpp Modified:

r238601 - Replace push_back(Constructor(foo)) with emplace_back(foo) for non-trivial types

2015-05-29 Thread Benjamin Kramer
Author: d0k Date: Fri May 29 14:42:19 2015 New Revision: 238601 URL: http://llvm.org/viewvc/llvm-project?rev=238601view=rev Log: Replace push_back(Constructor(foo)) with emplace_back(foo) for non-trivial types If the type isn't trivially moveable emplace can skip a potentially expensive move. It

r238466 - [Format] Skip creating temporary std::strings when filling another string.

2015-05-28 Thread Benjamin Kramer
Author: d0k Date: Thu May 28 14:55:49 2015 New Revision: 238466 URL: http://llvm.org/viewvc/llvm-project?rev=238466view=rev Log: [Format] Skip creating temporary std::strings when filling another string. No functional change intended. Modified: cfe/trunk/lib/Format/WhitespaceManager.cpp

r237525 - [Sema] Fold array into for-range loop. No functional change intended.

2015-05-16 Thread Benjamin Kramer
Author: d0k Date: Sat May 16 11:16:31 2015 New Revision: 237525 URL: http://llvm.org/viewvc/llvm-project?rev=237525view=rev Log: [Sema] Fold array into for-range loop. No functional change intended. Modified: cfe/trunk/lib/Sema/SemaType.cpp Modified: cfe/trunk/lib/Sema/SemaType.cpp URL:

r236315 - Make helper functions static. NFC.

2015-05-01 Thread Benjamin Kramer
Author: d0k Date: Fri May 1 08:59:53 2015 New Revision: 236315 URL: http://llvm.org/viewvc/llvm-project?rev=236315view=rev Log: Make helper functions static. NFC. Modified: cfe/trunk/lib/CodeGen/CGOpenMPRuntime.cpp cfe/trunk/lib/CodeGen/CGStmtOpenMP.cpp

Re: r236075 - Add -Wpessimizing-move and -Wredundant-move warnings.

2015-04-29 Thread Benjamin Kramer
On Wed, Apr 29, 2015 at 5:59 AM, Richard Trieu rtr...@google.com wrote: Since this warning did not exist when std::move was first introduced, and many people are not familiar with copy elision rules, there have been a lot of uses of the pessimizing move pattern. In relative numbers, the

r235253 - Make helper function static. NFC.

2015-04-18 Thread Benjamin Kramer
Author: d0k Date: Sat Apr 18 05:00:10 2015 New Revision: 235253 URL: http://llvm.org/viewvc/llvm-project?rev=235253view=rev Log: Make helper function static. NFC. Modified: cfe/trunk/lib/CodeGen/CGStmtOpenMP.cpp Modified: cfe/trunk/lib/CodeGen/CGStmtOpenMP.cpp URL:

[clang-tools-extra] r235192 - [clang-tidy] Remove static StringSet in favor of binary search.

2015-04-17 Thread Benjamin Kramer
Author: d0k Date: Fri Apr 17 08:52:08 2015 New Revision: 235192 URL: http://llvm.org/viewvc/llvm-project?rev=235192view=rev Log: [clang-tidy] Remove static StringSet in favor of binary search. The number of strings is so small that performance doesn't matter and adding the thread safe static

r234689 - Remove empty non-virtual destructors or mark them =default when non-public

2015-04-11 Thread Benjamin Kramer
Author: d0k Date: Sat Apr 11 10:58:30 2015 New Revision: 234689 URL: http://llvm.org/viewvc/llvm-project?rev=234689view=rev Log: Remove empty non-virtual destructors or mark them =default when non-public These add no value but can make a class non-trivially copyable. NFC. Modified:

r234643 - [tblgen] Use StringRef::trim

2015-04-10 Thread Benjamin Kramer
Author: d0k Date: Fri Apr 10 16:37:21 2015 New Revision: 234643 URL: http://llvm.org/viewvc/llvm-project?rev=234643view=rev Log: [tblgen] Use StringRef::trim Modified: cfe/trunk/utils/TableGen/ClangAttrEmitter.cpp Modified: cfe/trunk/utils/TableGen/ClangAttrEmitter.cpp URL:

r234499 - [CodeGen] When promoting a reference temporary to a global use the inner type to fold it.

2015-04-09 Thread Benjamin Kramer
Author: d0k Date: Thu Apr 9 11:09:29 2015 New Revision: 234499 URL: http://llvm.org/viewvc/llvm-project?rev=234499view=rev Log: [CodeGen] When promoting a reference temporary to a global use the inner type to fold it. The MaterializeTemporaryExpr can have a different type than the inner

r234184 - Prefer uninitialized memory for scratch space.

2015-04-06 Thread Benjamin Kramer
Author: d0k Date: Mon Apr 6 12:45:11 2015 New Revision: 234184 URL: http://llvm.org/viewvc/llvm-project?rev=234184view=rev Log: Prefer uninitialized memory for scratch space. No functional change intended. Modified: cfe/trunk/lib/Basic/SourceManager.cpp

Re: r234202 - MSan told me that we actually dump the entire scratch buffer into PCH files, initialize it.

2015-04-06 Thread Benjamin Kramer
On Mon, Apr 6, 2015 at 10:09 PM, David Blaikie dblai...@gmail.com wrote: On Mon, Apr 6, 2015 at 1:01 PM, Benjamin Kramer benny@googlemail.com wrote: Author: d0k Date: Mon Apr 6 15:01:49 2015 New Revision: 234202 URL: http://llvm.org/viewvc/llvm-project?rev=234202view=rev Log: MSan

r234202 - MSan told me that we actually dump the entire scratch buffer into PCH files, initialize it.

2015-04-06 Thread Benjamin Kramer
Author: d0k Date: Mon Apr 6 15:01:49 2015 New Revision: 234202 URL: http://llvm.org/viewvc/llvm-project?rev=234202view=rev Log: MSan told me that we actually dump the entire scratch buffer into PCH files, initialize it. Writing 4k of zeros is preferrable to 4k of random memory. Document that.

r234149 - Update our list of distros a bit.

2015-04-06 Thread Benjamin Kramer
Author: d0k Date: Mon Apr 6 07:30:43 2015 New Revision: 234149 URL: http://llvm.org/viewvc/llvm-project?rev=234149view=rev Log: Update our list of distros a bit. - Debian jessie will be released this month, add the next testing version to the list. - RHEL7 was released last june. - Ubuntu

r234123 - Replace copy loop with std::copy.

2015-04-05 Thread Benjamin Kramer
Author: d0k Date: Sun Apr 5 13:55:02 2015 New Revision: 234123 URL: http://llvm.org/viewvc/llvm-project?rev=234123view=rev Log: Replace copy loop with std::copy. No functional change intended. Modified: cfe/trunk/lib/AST/Decl.cpp Modified: cfe/trunk/lib/AST/Decl.cpp URL:

r233912 - Partially revert Replace custom alignment enforcement with LLVM_ALIGNAS.

2015-04-02 Thread Benjamin Kramer
Author: d0k Date: Thu Apr 2 07:43:31 2015 New Revision: 233912 URL: http://llvm.org/viewvc/llvm-project?rev=233912view=rev Log: Partially revert Replace custom alignment enforcement with LLVM_ALIGNAS. MSVC 2013 can't even parse __declspec(align(sizeof(foo))). We'll have to wait until MSVC 2015

r233911 - Replace custom alignment enforcement with LLVM_ALIGNAS.

2015-04-02 Thread Benjamin Kramer
Author: d0k Date: Thu Apr 2 07:25:07 2015 New Revision: 233911 URL: http://llvm.org/viewvc/llvm-project?rev=233911view=rev Log: Replace custom alignment enforcement with LLVM_ALIGNAS. This isn't perfect as it still assumes sizeof(void*) == alignof(void*), but we can fix that when compiler

r233921 - [ast] Put the Stmt hierarchy on a diet for 64 bit targets.

2015-04-02 Thread Benjamin Kramer
Author: d0k Date: Thu Apr 2 10:29:07 2015 New Revision: 233921 URL: http://llvm.org/viewvc/llvm-project?rev=233921view=rev Log: [ast] Put the Stmt hierarchy on a diet for 64 bit targets. Previously we would waste 32 bits on alignment, use LLVM_ALIGNAS to free that space for derived classes an

r233922 - Lower the default alignment on ASTContext's operator new.

2015-04-02 Thread Benjamin Kramer
Author: d0k Date: Thu Apr 2 11:19:54 2015 New Revision: 233922 URL: http://llvm.org/viewvc/llvm-project?rev=233922view=rev Log: Lower the default alignment on ASTContext's operator new. It was documented as 8 and operator new[] defaults to 8, but the normal operator new was never updated and

r233725 - [lex] Bitfieldize some booleans.

2015-03-31 Thread Benjamin Kramer
Author: d0k Date: Tue Mar 31 13:47:05 2015 New Revision: 233725 URL: http://llvm.org/viewvc/llvm-project?rev=233725view=rev Log: [lex] Bitfieldize some booleans. Lets us fuse some branches into bit tests downstream. NFC. Modified: cfe/trunk/include/clang/Lex/LiteralSupport.h Modified:

r233493 - [lex] Don't create a garbage token if parsing of __has_include fails.

2015-03-29 Thread Benjamin Kramer
Author: d0k Date: Sun Mar 29 10:33:29 2015 New Revision: 233493 URL: http://llvm.org/viewvc/llvm-project?rev=233493view=rev Log: [lex] Don't create a garbage token if parsing of __has_include fails. It will crash downstream somewhere. Found by afl-fuzz. Modified:

r233492 - [Parse] Don't crash on ~A::{

2015-03-29 Thread Benjamin Kramer
Author: d0k Date: Sun Mar 29 09:35:39 2015 New Revision: 233492 URL: http://llvm.org/viewvc/llvm-project?rev=233492view=rev Log: [Parse] Don't crash on ~A::{ Found by clang-fuzz. Modified: cfe/trunk/lib/Parse/ParseExprCXX.cpp cfe/trunk/test/Parser/cxx-class.cpp Modified:

r233491 - [lex] Don't read past the end of the buffer

2015-03-29 Thread Benjamin Kramer
Author: d0k Date: Sun Mar 29 09:11:37 2015 New Revision: 233491 URL: http://llvm.org/viewvc/llvm-project?rev=233491view=rev Log: [lex] Don't read past the end of the buffer While dereferencing ThisTokEnd is fine and we know that it's not in [a-zA-Z0-9_.], ThisTokEnd[1] is really past the end.

r233490 - [lex] Turn range checks into asserts.

2015-03-29 Thread Benjamin Kramer
Author: d0k Date: Sun Mar 29 09:11:22 2015 New Revision: 233490 URL: http://llvm.org/viewvc/llvm-project?rev=233490view=rev Log: [lex] Turn range checks into asserts. We know that the last accessible char is not in [a-zA-Z0-9_.] so we can happily scan on as long as it is. No functionality

r233494 - [parser] Push _Atomic locs through DeclaratorChunk.

2015-03-29 Thread Benjamin Kramer
Author: d0k Date: Sun Mar 29 11:42:06 2015 New Revision: 233494 URL: http://llvm.org/viewvc/llvm-project?rev=233494view=rev Log: [parser] Push _Atomic locs through DeclaratorChunk. Otherwise it stays uninitialized with potentially catastrophic results. Found by afl-fuzz. Modified:

r233496 - [edit] Don't hit an assert when trying to delete a trailing space at EOF

2015-03-29 Thread Benjamin Kramer
Author: d0k Date: Sun Mar 29 13:07:29 2015 New Revision: 233496 URL: http://llvm.org/viewvc/llvm-project?rev=233496view=rev Log: [edit] Don't hit an assert when trying to delete a trailing space at EOF The buffer is guaranteed to be zero-terminated so we can just circumvent the check. Found by

r233497 - [lex] Provide a valid token when __has_include is found outside of a pp directive

2015-03-29 Thread Benjamin Kramer
Author: d0k Date: Sun Mar 29 14:05:27 2015 New Revision: 233497 URL: http://llvm.org/viewvc/llvm-project?rev=233497view=rev Log: [lex] Provide a valid token when __has_include is found outside of a pp directive ExpandBuiltinMacro would strip the identifier and downstream users crash when they

r233499 - [parse] Don't crash on alternative operator spellings from macros in c++11 attributes.

2015-03-29 Thread Benjamin Kramer
Author: d0k Date: Sun Mar 29 14:25:07 2015 New Revision: 233499 URL: http://llvm.org/viewvc/llvm-project?rev=233499view=rev Log: [parse] Don't crash on alternative operator spellings from macros in c++11 attributes. Found by afl-fuzz. Modified: cfe/trunk/lib/Parse/ParseDeclCXX.cpp

Re: r233491 - [lex] Don't read past the end of the buffer

2015-03-29 Thread Benjamin Kramer
On Mon, Mar 30, 2015 at 12:03 AM, Richard Smith rich...@metafoo.co.uk wrote: On Sun, Mar 29, 2015 at 7:11 AM, Benjamin Kramer benny@googlemail.com wrote: Author: d0k Date: Sun Mar 29 09:11:37 2015 New Revision: 233491 URL: http://llvm.org/viewvc/llvm-project?rev=233491view=rev Log

r233376 - [Sema] Diagnose default argument on a parameter pack.

2015-03-27 Thread Benjamin Kramer
Author: d0k Date: Fri Mar 27 08:58:31 2015 New Revision: 233376 URL: http://llvm.org/viewvc/llvm-project?rev=233376view=rev Log: [Sema] Diagnose default argument on a parameter pack. This is ill-formed (and cannot be used anyways). PR23028. Modified:

r233377 - [Sema] Implement DR777

2015-03-27 Thread Benjamin Kramer
Author: d0k Date: Fri Mar 27 08:58:41 2015 New Revision: 233377 URL: http://llvm.org/viewvc/llvm-project?rev=233377view=rev Log: [Sema] Implement DR777 A parameter pack after a default argument is now valid. PR23029. Added: cfe/trunk/test/CXX/drs/dr7xx.cpp Modified:

r233379 - Remove test for PR12917 for now. I'm relatively sure this is ill-formed per [dcl.fct.default]p3.

2015-03-27 Thread Benjamin Kramer
Author: d0k Date: Fri Mar 27 09:12:44 2015 New Revision: 233379 URL: http://llvm.org/viewvc/llvm-project?rev=233379view=rev Log: Remove test for PR12917 for now. I'm relatively sure this is ill-formed per [dcl.fct.default]p3. Modified: cfe/trunk/test/CodeGenCXX/mangle-lambdas.cpp Modified:

r233387 - [Sema] Factor diags with %plural. No functionality change intended.

2015-03-27 Thread Benjamin Kramer
Author: d0k Date: Fri Mar 27 12:23:14 2015 New Revision: 233387 URL: http://llvm.org/viewvc/llvm-project?rev=233387view=rev Log: [Sema] Factor diags with %plural. No functionality change intended. Modified: cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td

r233391 - Mark DR777 only as fixed in clang SVN.

2015-03-27 Thread Benjamin Kramer
Author: d0k Date: Fri Mar 27 12:38:35 2015 New Revision: 233391 URL: http://llvm.org/viewvc/llvm-project?rev=233391view=rev Log: Mark DR777 only as fixed in clang SVN. Modified: cfe/trunk/test/CXX/drs/dr7xx.cpp cfe/trunk/www/cxx_dr_status.html Modified: cfe/trunk/test/CXX/drs/dr7xx.cpp

r233060 - [analyzer] Remove unused function. No functional change intended.

2015-03-24 Thread Benjamin Kramer
Author: d0k Date: Tue Mar 24 06:11:11 2015 New Revision: 233060 URL: http://llvm.org/viewvc/llvm-project?rev=233060view=rev Log: [analyzer] Remove unused function. No functional change intended. Modified: cfe/trunk/lib/StaticAnalyzer/Core/ExprEngine.cpp Modified:

r233059 - Make header standalone, it uses memset and memcmp.

2015-03-24 Thread Benjamin Kramer
Author: d0k Date: Tue Mar 24 06:11:05 2015 New Revision: 233059 URL: http://llvm.org/viewvc/llvm-project?rev=233059view=rev Log: Make header standalone, it uses memset and memcmp. NFC. Modified: cfe/trunk/include/clang/Basic/ABI.h Modified: cfe/trunk/include/clang/Basic/ABI.h URL:

r232947 - [tooling] Move ArgumentsAdjustingCompilations into an anonymous namespace.

2015-03-23 Thread Benjamin Kramer
Author: d0k Date: Mon Mar 23 07:47:15 2015 New Revision: 232947 URL: http://llvm.org/viewvc/llvm-project?rev=232947view=rev Log: [tooling] Move ArgumentsAdjustingCompilations into an anonymous namespace. NFC. Modified: cfe/trunk/lib/Tooling/CommonOptionsParser.cpp Modified:

[clang-tools-extra] r232948 - Make helpers static. clang-tools edition.

2015-03-23 Thread Benjamin Kramer
Author: d0k Date: Mon Mar 23 07:49:15 2015 New Revision: 232948 URL: http://llvm.org/viewvc/llvm-project?rev=232948view=rev Log: Make helpers static. clang-tools edition. Also purge dead code found by it. NFC. Modified:

r232945 - Move private classes into anonymous namespaces

2015-03-23 Thread Benjamin Kramer
Author: d0k Date: Mon Mar 23 07:31:05 2015 New Revision: 232945 URL: http://llvm.org/viewvc/llvm-project?rev=232945view=rev Log: Move private classes into anonymous namespaces Also merge anonymous namespaces in Targets.cpp a bit. NFC. Modified: cfe/trunk/lib/AST/VTableBuilder.cpp

r232975 - Explicitly include raw_ostream.h instead of relying on transitive inclusion.

2015-03-23 Thread Benjamin Kramer
Author: d0k Date: Mon Mar 23 13:05:43 2015 New Revision: 232975 URL: http://llvm.org/viewvc/llvm-project?rev=232975view=rev Log: Explicitly include raw_ostream.h instead of relying on transitive inclusion. NFC. Modified: cfe/trunk/lib/Format/UnwrappedLineParser.cpp Modified:

r232909 - Remove empty files left behind by r232907.

2015-03-22 Thread Benjamin Kramer
Author: d0k Date: Sun Mar 22 05:08:31 2015 New Revision: 232909 URL: http://llvm.org/viewvc/llvm-project?rev=232909view=rev Log: Remove empty files left behind by r232907. Removed: cfe/trunk/test/Modules/Inputs/update-exception-spec/a.h

  1   2   3   4   5   6   7   8   9   10   >