Re: [cfe-commits] [PATCH] WIP: catch CFMakeCollectable(NULL) with static analyzer

2012-11-07 Thread Jordan Rose
Committed in r167537. Thanks, Sean! Jordan On Nov 5, 2012, at 18:32 , Sean McBride s...@rogue-research.com wrote: Jordan, Updated patch attached. Thanks, Sean On Fri, 2 Nov 2012 09:49:37 -0700, Jordan Rose said: Hi, Sean. Thanks for the patch! Most of the tests in

Re: [cfe-commits] [PATCH] WIP: catch CFMakeCollectable(NULL) with static analyzer

2012-11-05 Thread Sean McBride
Jordan, Updated patch attached. Thanks, Sean On Fri, 2 Nov 2012 09:49:37 -0700, Jordan Rose said: Hi, Sean. Thanks for the patch! Most of the tests in retain-release.m are just top-level functions, numbered numerically from lack of imagination. The arguments are fairly arbitrary—'p' is just

Re: [cfe-commits] [PATCH] WIP: catch CFMakeCollectable(NULL) with static analyzer

2012-11-02 Thread Jordan Rose
Hi, Sean. Thanks for the patch! Most of the tests in retain-release.m are just top-level functions, numbered numerically from lack of imagination. The arguments are fairly arbitrary—'p' is just 'pointer' (I think), and 'x' is being used as a sort of coin toss to arbitrarily create conditions

[cfe-commits] [PATCH] WIP: catch CFMakeCollectable(NULL) with static analyzer

2012-11-01 Thread Sean McBride
Hi all, Attached is a patch that expands the analyzer's check for CFRelease(NULL) to also catch CFMakeCollectable(NULL). It builds, and the resulting clang does now warn on CFMakeCollectable(NULL), but I have not added a test. I'm pretty sure the test belongs in retain-release.m in f16() and