Hi Takumi,
About the patch, adding the feature is not required here. The correct
fix is to remove the CommentXMLValid from CHECK lines. (The test
checks that there are no CommentXMLInvalid lines, so it is OK).
Please tell me if you want me to make this change.
On Thu, Oct 18, 2012 at 5:30 AM,
Dmitri, I'm ok for you to update!
2012/10/18 Dmitri Gribenko griboz...@gmail.com:
Hi Takumi,
About the patch, adding the feature is not required here. The correct
fix is to remove the CommentXMLValid from CHECK lines. (The test
checks that there are no CommentXMLInvalid lines, so it is
On Thu, Oct 18, 2012 at 3:55 PM, NAKAMURA Takumi geek4ci...@gmail.com wrote:
Dmitri, I'm ok for you to update!
Committed r166179, hopefully it fixes mingw and win32 buildbots!
Dmitri
--
main(i,j){for(i=2;;i++){for(j=2;ji;j++){if(!(i%j)){j=0;break;}}if
(j){printf(%d\n,i);}}} /*Dmitri Gribenko
On Oct 18, 2012, at 5:45 AM, Dmitri Gribenko griboz...@gmail.com wrote:
Hi Takumi,
About the patch, adding the feature is not required here. The correct
fix is to remove the CommentXMLValid from CHECK lines. (The test
checks that there are no CommentXMLInvalid lines, so it is OK).
Yes,
FIXME: Could we add the feature 'libxml2' or rename 'xmllint' to one?
---
.../Index/annotate-comments-availability-attrs.cpp |4 +++-
clang/test/Index/overriding-ftemplate-comments.cpp |3 ++-
clang/test/Index/overriding-method-comments.mm |4 +++-
3 files changed, 8
