Re: [cfe-commits] r165256 - /cfe/trunk/lib/Sema/SemaDecl.cpp

2012-10-24 Thread Enea Zaffanella
On 10/23/2012 10:52 AM, Philip Craig wrote: Hi Abramo, On Thu, Oct 18, 2012 at 7:17 PM, Philip Craig philipjcr...@gmail.com wrote: On Sat, Oct 6, 2012 at 3:55 PM, Enea Zaffanella zaffane...@cs.unipr.it wrote: [...] Is this going (or can be modified) to also check for the end location of

Re: [cfe-commits] r165256 - /cfe/trunk/lib/Sema/SemaDecl.cpp

2012-10-23 Thread Philip Craig
Hi Abramo, On Thu, Oct 18, 2012 at 7:17 PM, Philip Craig philipjcr...@gmail.com wrote: On Sat, Oct 6, 2012 at 3:55 PM, Enea Zaffanella zaffane...@cs.unipr.it wrote: On 10/06/2012 01:44 AM, Philip Craig wrote: On Fri, Oct 5, 2012 at 2:40 PM, Abramo Bagnara abramo.bagn...@bugseng.com wrote:

Re: [cfe-commits] r165256 - /cfe/trunk/lib/Sema/SemaDecl.cpp

2012-10-18 Thread Philip Craig
On Sat, Oct 6, 2012 at 3:55 PM, Enea Zaffanella zaffane...@cs.unipr.it wrote: On 10/06/2012 01:44 AM, Philip Craig wrote: On Fri, Oct 5, 2012 at 2:40 PM, Abramo Bagnara abramo.bagn...@bugseng.com wrote: Il 05/10/2012 00:15, Chandler Carruth ha scritto: On Thu, Oct 4, 2012 at 3:12 PM,

Re: [cfe-commits] r165256 - /cfe/trunk/lib/Sema/SemaDecl.cpp

2012-10-05 Thread Philip Craig
On Fri, Oct 5, 2012 at 2:40 PM, Abramo Bagnara abramo.bagn...@bugseng.com wrote: Il 05/10/2012 00:15, Chandler Carruth ha scritto: On Thu, Oct 4, 2012 at 3:12 PM, Chandler Carruth chandl...@google.com mailto:chandl...@google.com wrote: Can we get a test case for this? Also, not just

Re: [cfe-commits] r165256 - /cfe/trunk/lib/Sema/SemaDecl.cpp

2012-10-05 Thread Chandler Carruth
On Fri, Oct 5, 2012 at 4:44 PM, Philip Craig philipjcr...@gmail.com wrote: On Fri, Oct 5, 2012 at 2:40 PM, Abramo Bagnara abramo.bagn...@bugseng.com wrote: Il 05/10/2012 00:15, Chandler Carruth ha scritto: On Thu, Oct 4, 2012 at 3:12 PM, Chandler Carruth chandl...@google.com

Re: [cfe-commits] r165256 - /cfe/trunk/lib/Sema/SemaDecl.cpp

2012-10-05 Thread Enea Zaffanella
On 10/06/2012 01:44 AM, Philip Craig wrote: On Fri, Oct 5, 2012 at 2:40 PM, Abramo Bagnara abramo.bagn...@bugseng.com wrote: Il 05/10/2012 00:15, Chandler Carruth ha scritto: On Thu, Oct 4, 2012 at 3:12 PM, Chandler Carruth chandl...@google.com mailto:chandl...@google.com wrote: Can we

[cfe-commits] r165256 - /cfe/trunk/lib/Sema/SemaDecl.cpp

2012-10-04 Thread Abramo Bagnara
Author: abramo Date: Thu Oct 4 16:38:29 2012 New Revision: 165256 URL: http://llvm.org/viewvc/llvm-project?rev=165256view=rev Log: Fixed ParamDecl source range for implicit typed kr parameters. Modified: cfe/trunk/lib/Sema/SemaDecl.cpp Modified: cfe/trunk/lib/Sema/SemaDecl.cpp URL:

Re: [cfe-commits] r165256 - /cfe/trunk/lib/Sema/SemaDecl.cpp

2012-10-04 Thread Chandler Carruth
Can we get a test case for this? While previously, our ability to regression test the AST has been limited, I think with the tooling infrastructure we got enough unittest infrastructure to grab the AST node and call methods on it asserting their expected contents. On Thu, Oct 4, 2012 at 2:38

Re: [cfe-commits] r165256 - /cfe/trunk/lib/Sema/SemaDecl.cpp

2012-10-04 Thread Chandler Carruth
On Thu, Oct 4, 2012 at 3:12 PM, Chandler Carruth chandl...@google.comwrote: Can we get a test case for this? Also, not just for this, but for all of the source location fixes you're making? We've got *lots* of source location bugs (as you're finding!) and we really need to start testing them

Re: [cfe-commits] r165256 - /cfe/trunk/lib/Sema/SemaDecl.cpp

2012-10-04 Thread Abramo Bagnara
Il 05/10/2012 00:15, Chandler Carruth ha scritto: On Thu, Oct 4, 2012 at 3:12 PM, Chandler Carruth chandl...@google.com mailto:chandl...@google.com wrote: Can we get a test case for this? Also, not just for this, but for all of the source location fixes you're making? This problem