Re: [PATCH] D12797: Refactor LoopConvertCheck.

2015-09-19 Thread Manuel Klimek via cfe-commits
klimek accepted this revision. klimek added a comment. This revision is now accepted and ready to land. lg http://reviews.llvm.org/D12797 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D12903: Add -fplugin=name.so option to the driver

2015-09-19 Thread Nico Weber via cfe-commits
thakis added a subscriber: thakis. thakis added a comment. Is the idea that this loads plugins that link against clang's C++ api? That api isn't considered stable, so not having an "official" flag for this always looked by design to me. Also, C++ doesn't make for a good ABI. Also also, this

[PATCH] D12996: Driver: support ARM/HF on a single toolchain

2015-09-19 Thread Saleem Abdulrasool via cfe-commits
compnerd created this revision. compnerd added a reviewer: rengolin. compnerd added a subscriber: cfe-commits. Herald added subscribers: srhines, danalbert, tberghammer, rengolin, aemerson. ARM EABI adds target attributes to the object file. Amongst the attributes that are emitted is the VFP

r248094 - Driver: tweak ARM target feature calculation

2015-09-19 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Sat Sep 19 13:19:44 2015 New Revision: 248094 URL: http://llvm.org/viewvc/llvm-project?rev=248094=rev Log: Driver: tweak ARM target feature calculation Rather than using re-calculating the effective triple, thread the already calculated value down into AddARMTargetArgs.

Re: r247618 - C11 _Bool bitfield diagnostic

2015-09-19 Thread Nico Weber via cfe-commits
On Fri, Sep 18, 2015 at 10:19 PM, Richard Smith wrote: > On Fri, Sep 18, 2015 at 8:49 PM, Nico Weber wrote: > >> On Fri, Sep 18, 2015 at 5:06 PM, Richard Smith >> wrote: >> >>> On Wed, Sep 16, 2015 at 5:33 PM, Richard Smith

Re: r245459 - According to i686 ABI, long double size on x86 is 12 bytes not 16 bytes.

2015-09-19 Thread Yaron Keren via cfe-commits
Thanks, I have replied there. 2015-09-19 13:33 GMT+03:00 Hal Finkel : > FYI: https://llvm.org/bugs/show_bug.cgi?id=24398 was just reopened > pointing to a lack of resolution here. > > -Hal > > - Original Message - > > From: "Yaron Keren via cfe-commits"

r245459 - According to i686 ABI, long double size on x86 is 12 bytes not 16 bytes.

2015-09-19 Thread Martell Malone via cfe-commits
For reference It was raised again here also https://github.com/Alexpux/MINGW-packages/issues/722 "that is extended from X86TargetInfo Which sets LongDoubleFormat = ::APFloat::x87DoubleExtended;" On Saturday, September

Re: r245459 - According to i686 ABI, long double size on x86 is 12 bytes not 16 bytes.

2015-09-19 Thread Hal Finkel via cfe-commits
FYI: https://llvm.org/bugs/show_bug.cgi?id=24398 was just reopened pointing to a lack of resolution here. -Hal - Original Message - > From: "Yaron Keren via cfe-commits" > To: "Martell Malone" > Cc: "Richard Smith"

Re: [PATCH] D12967: fix comments

2015-09-19 Thread Alexander Kornienko via cfe-commits
alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG. Thanks for the patch! Do you need me to commit this? http://reviews.llvm.org/D12967 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: r245459 - According to i686 ABI, long double size on x86 is 12 bytes not 16 bytes.

2015-09-19 Thread Yaron Keren via cfe-commits
I can't reproduce sizeof = 12 when targetting 64 bits, it is 16 (LongDoubleWidth = 128) and have been this way since r55036. It may be that both 32 bit mingw and 64 bit mingw are installed and clang is targetting the 32 bits while gcc targets 64 bits. 2015-09-19 15:24 GMT+03:00 Martell Malone

Re: [PATCH] D12961: Update clang-tidy documentation.

2015-09-19 Thread Alexander Kornienko via cfe-commits
alexfh added a comment. Thank you for converting the docs! Some of the usages of "transform" and "transformation" in these docs refer to "clang-modernize transform", and, thus, should be replaced with "check" or "clang-tidy check". I tried to find all such places. See comments.

Re: [PATCH] D12967: fix comments

2015-09-19 Thread Alexander Kornienko via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL248090: [clang-tidy] Fix example comments. (authored by alexfh). Changed prior to commit: http://reviews.llvm.org/D12967?vs=35091=35164#toc Repository: rL LLVM http://reviews.llvm.org/D12967

r248090 - [clang-tidy] Fix example comments.

2015-09-19 Thread Alexander Kornienko via cfe-commits
Author: alexfh Date: Sat Sep 19 08:01:57 2015 New Revision: 248090 URL: http://llvm.org/viewvc/llvm-project?rev=248090=rev Log: [clang-tidy] Fix example comments. Patch by don hinton! Differential revision: http://reviews.llvm.org/D12967 Modified:

Re: [PATCH] D12835: [X86][SSE] Replace 128-bit SSE41 PMOVSX intrinsics with native IR

2015-09-19 Thread Simon Pilgrim via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL248092: [X86][SSE] Replace 128-bit SSE41 PMOVSX intrinsics with native IR (authored by RKSimon). Changed prior to commit: http://reviews.llvm.org/D12835?vs=34646=35167#toc Repository: rL LLVM

r248092 - [X86][SSE] Replace 128-bit SSE41 PMOVSX intrinsics with native IR

2015-09-19 Thread Simon Pilgrim via cfe-commits
Author: rksimon Date: Sat Sep 19 10:12:38 2015 New Revision: 248092 URL: http://llvm.org/viewvc/llvm-project?rev=248092=rev Log: [X86][SSE] Replace 128-bit SSE41 PMOVSX intrinsics with native IR 128-bit vector integer sign extensions correctly lower to the pmovsx instructions even for debug

[PATCH] D12993: [analyzer] Add TK_EntireMemSpace invalidation trait.

2015-09-19 Thread Devin Coughlin via cfe-commits
dcoughlin created this revision. dcoughlin added reviewers: krememek, zaks.anna. dcoughlin added subscribers: cfe-commits, seaneveson. This is a patch to support Sean Eveson's work on loop widening. It adds a new TK_EntireMemSpace invalidation trait that, when applied to a MemSpaceRegion,

Re: [PATCH] D12358: [Analyzer] Handling constant bound loops

2015-09-19 Thread Devin Coughlin via cfe-commits
dcoughlin added a comment. There is a patch to add memspace region invalidation in http://reviews.llvm.org/D12993. http://reviews.llvm.org/D12358 ___ cfe-commits mailing list cfe-commits@lists.llvm.org