Re: [PATCH] D10305: [Clang Static Analyzer] Bug identification

babati added a comment. Hi Sorry for the late answer. > Can you please rebase this patch based on http://reviews.llvm.org/D12673? Yes, I can. The patch will comes soon. > How do you expect this to work? i.e. would bug_id_1 always be generated along > with new improved bug_ids in the same

Re: [PATCH] D11182: [OPENMP 4.0] Initial support for 'omp declare reduction' construct.

ABataev added a comment. Ping http://reviews.llvm.org/D11182 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] r248240 - Fix with -pedantic-errors

Author: ericwf Date: Mon Sep 21 22:15:35 2015 New Revision: 248240 URL: http://llvm.org/viewvc/llvm-project?rev=248240=rev Log: Fix with -pedantic-errors Modified: libcxx/trunk/include/__config Modified: libcxx/trunk/include/__config URL:

Re: [PATCH] D12906: [RFC] Bug identification("issue_hash") change for CmpRuns.py

zaks.anna added a comment. I agree with Gabor and do not think we should have 2 entries in the plist file for bug identification. This is confusing and I do not see a need for this. Any comparison script can check for 2 fields in a plist file and concatenate them. We've already discussed this

Re: [PATCH] D12989: [CUDA] Added CUDA installation detector class.

tra updated the summary for this revision. tra updated this revision to Diff 35333. tra added a comment. Added test case for CUDA detection. Removed libdevice file detection for now. http://reviews.llvm.org/D12989 Files: include/clang/Driver/Options.td lib/Driver/ToolChains.cpp

r248234 - ms Intrin.h: Fix __movsw's and __stosw's inline asm.

Author: nico Date: Mon Sep 21 19:46:21 2015 New Revision: 248234 URL: http://llvm.org/viewvc/llvm-project?rev=248234=rev Log: ms Intrin.h: Fix __movsw's and __stosw's inline asm. Before, clang's internal assembler would reject the inline asm in clang's Intrin.h. To make sure this doesn't happen

Re: [PATCH] D12906: [RFC] Bug identification("issue_hash") change for CmpRuns.py

honggyu.kim added a comment. In http://reviews.llvm.org/D12906#250237, @zaks.anna wrote: > I agree with Gabor and do not think we should have 2 entries in the plist > file for bug identification. This is confusing and I do not see a need for > this. > > Any comparison script can check for 2

Re: [PATCH] D12358: [Analyzer] Handling constant bound loops

dcoughlin added inline comments. Comment at: lib/StaticAnalyzer/Core/LoopWidening.cpp:149 @@ +148,3 @@ + break; +} + This doesn't seem quite right. Consider: ``` int i; for (i = 0; i < 21; i += 3) {} clang_analyzer_eval(i == 23); ``` The value of `i`

Re: [PATCH] D12989: [CUDA] Added CUDA installation detector class.

tra added a comment. I'll add tests for install dir detection. As for detection of bitcode files, perhaps I should remove it from this patch and commit it along with the code that's going to use it and where I can test it. http://reviews.llvm.org/D12989

r248235 - Add bug number to FIXME comment.

Author: nico Date: Mon Sep 21 19:51:10 2015 New Revision: 248235 URL: http://llvm.org/viewvc/llvm-project?rev=248235=rev Log: Add bug number to FIXME comment. Modified: cfe/trunk/test/Headers/ms-intrin.cpp Modified: cfe/trunk/test/Headers/ms-intrin.cpp URL:

Re: [PATCH] D12358: [Analyzer] Handling constant bound loops

zaks.anna added a comment. nit: Please, use proper punctuation in the comments. Comment at: lib/StaticAnalyzer/Core/ExprEngine.cpp:1616 @@ +1615,3 @@ +builder.isFeasible(false) && !StFalse && +BldCtx.blockCount() == AMgr.options.maxBlockVisitOnPath - 1) { +

Re: [PATCH] D13009: [X86] Fix some non-reserved parameter names in intrinsic headers

AsafBadouh accepted this revision. AsafBadouh added a comment. This revision is now accepted and ready to land. LGTM http://reviews.llvm.org/D13009 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D12839: Extend MoveConstructorInitCheck to also flag constructor arguments passed by value and can be moved assigned to fields.

On Sun, Sep 20, 2015 at 1:44 PM, Felix Berger wrote: > flx added inline comments. > > > Comment at: clang-tidy/misc/MoveConstructorInitCheck.cpp:38 > @@ +37,3 @@ > + Node.isTriviallyCopyableType(Finder->getASTContext()) || > +

[PATCH] D13013: Fix crash "-target arm -mcpu=generic", without "-march="

vsukharev created this revision. vsukharev added a reviewer: rengolin. vsukharev added a subscriber: cfe-commits. vsukharev set the repository for this revision to rL LLVM. Herald added subscribers: rengolin, aemerson. Follow-up to http://reviews.llvm.org/rL245445 Added more tests for

Re: [PATCH] D13015: [X86] Make f16c intrinsics accessible through emmintrin.h, per Intel docs

This revision was automatically updated to reflect the committed changes. Closed by commit rL248156: [X86] Make f16c intrinsics accessible through emmintrin.h, per Intel docs (authored by mkuper). Changed prior to commit: http://reviews.llvm.org/D13015?vs=35237=35250#toc Repository: rL LLVM

Re: [PATCH] D12955: Fix assertion in inline assembler IR gen

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. With one minor change, LGTM! Thank you for working on this. ~Aaron Comment at: lib/Sema/SemaStmtAsm.cpp:447 @@ +446,3 @@ +// Make sure no more than one

Re: [PATCH] D12839: Extend MoveConstructorInitCheck to also flag constructor arguments passed by value and can be moved assigned to fields.

aaron.ballman added inline comments. Comment at: clang-tidy/misc/MoveConstructorInitCheck.cpp:11 @@ -10,2 +10,3 @@ #include "MoveConstructorInitCheck.h" +#include "../utils/Matchers.h" #include "clang/AST/ASTContext.h" Errr, I'm not certain that we typically

[PATCH] D13014: [X86] Add XSAVE intrinsics (Clang part)

aaboud created this revision. aaboud added reviewers: mkuper, delena, craig.topper. aaboud added a subscriber: cfe-commits. aaboud set the repository for this revision to rL LLVM. Add intrinsics for the XSAVE instructions: XSAVE, XSAVE64 XRSTOR, XRSTOR64 XSAVEOPT, XSAVEOPT64 XRSTORS, XRSTORS64

r248154 - [ARM] Handle +t2dsp feature as an ArchExtKind in ARMTargetParser.def

Author: askrobov Date: Mon Sep 21 08:19:25 2015 New Revision: 248154 URL: http://llvm.org/viewvc/llvm-project?rev=248154=rev Log: [ARM] Handle +t2dsp feature as an ArchExtKind in ARMTargetParser.def Currently, the availability of DSP instructions (ACLE 6.4.7) is handled in a hand-rolled tricky

Re: [PATCH] D12955: Fix assertion in inline assembler IR gen

amusman updated this revision to Diff 35222. amusman added a comment. Added an assertion for TiedTo value. http://reviews.llvm.org/D12955 Files: include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaStmtAsm.cpp test/Sema/asm.c Index: lib/Sema/SemaStmtAsm.cpp

[PATCH] D13009: [X86] Fix some non-reserved parameter names in intrinsic headers

mkuper created this revision. mkuper added a reviewer: AsafBadouh. mkuper added a subscriber: cfe-commits. http://reviews.llvm.org/D13009 Files: lib/Headers/avx512fintrin.h lib/Headers/emmintrin.h Index: lib/Headers/avx512fintrin.h

r248150 - [X86] Fix some non-reserved parameter names in intrinsic headers

Author: mkuper Date: Mon Sep 21 06:45:27 2015 New Revision: 248150 URL: http://llvm.org/viewvc/llvm-project?rev=248150=rev Log: [X86] Fix some non-reserved parameter names in intrinsic headers Differential Revision: http://reviews.llvm.org/D13009 Modified:

Re: [PATCH] D13009: [X86] Fix some non-reserved parameter names in intrinsic headers

This revision was automatically updated to reflect the committed changes. Closed by commit rL248150: [X86] Fix some non-reserved parameter names in intrinsic headers (authored by mkuper). Changed prior to commit: http://reviews.llvm.org/D13009?vs=35225=35230#toc Repository: rL LLVM

Re: [PATCH] D13006: Replace references to "transform" with references to "check" where neccessary in the documentation.

angelgarcia updated this revision to Diff 35232. angelgarcia added a comment. Done. http://reviews.llvm.org/D13006 Files: docs/clang-tidy/checks/modernize-loop-convert.rst docs/clang-tidy/checks/modernize-pass-by-value.rst docs/clang-tidy/checks/modernize-replace-auto-ptr.rst

Re: [PATCH] D13006: Replace references to "transform" with references to "check" where neccessary in the documentation.

This revision was automatically updated to reflect the committed changes. Closed by commit rL248153: Replace references to "transform" with references to "check" where neccessary… (authored by angelgarcia). Changed prior to commit: http://reviews.llvm.org/D13006?vs=35232=35238#toc Repository:

[clang-tools-extra] r248153 - Replace references to "transform" with references to "check" where neccessary in the documentation.

Author: angelgarcia Date: Mon Sep 21 07:53:30 2015 New Revision: 248153 URL: http://llvm.org/viewvc/llvm-project?rev=248153=rev Log: Replace references to "transform" with references to "check" where neccessary in the documentation. Summary: Replace references to "transform" with references to

Re: [PATCH] D13015: [X86] Make f16c intrinsics accessible through emmintrin.h, per Intel docs

AsafBadouh accepted this revision. AsafBadouh added a comment. This revision is now accepted and ready to land. LGTM http://reviews.llvm.org/D13015 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D12761: MPI-Checker patch for Clang Static Analyzer

zaks.anna added a comment. > Sorry, I should have been more precise. The check tests if a request is in > use by a nonblocking > call at the end of a function. But the request can still be alive after > return. You can think of it as > a pointer for which the memory must be freed in the

Re: [PATCH] D12482: Analyzer: Teach analyzer how to handle TypeTraitExpr

dcoughlin added a comment. You should add a test covering the added logic in SValBuilder. For example: clang_analyzer_eval(__is_trivial(NonTrivial)); // expected-warning {{FALSE}} And while we're at it, it would be good to add a test for UnaryExprOrTypeTraitExpr as well:

Re: [PATCH] D10305: [Clang Static Analyzer] Bug identification

zaks.anna added a comment. Hi Babati, As far as I can see, the following comments from June 15th have not been addressed. It would be good if you could address them in the latest revision. "I would be interested in either replacing "issue_hash" or adding "issue_hash_bug_line_content" (or

r248221 - Add msbuild-bin/cl to CLANG_LINKS_TO_CREATE

Author: hans Date: Mon Sep 21 17:44:57 2015 New Revision: 248221 URL: http://llvm.org/viewvc/llvm-project?rev=248221=rev Log: Add msbuild-bin/cl to CLANG_LINKS_TO_CREATE This got lost in r248043 which refactored the symlink creation. Modified: cfe/trunk/tools/driver/CMakeLists.txt

Re: [PATCH] D12989: [CUDA] Added CUDA installation detector class.

echristo added a comment. In http://reviews.llvm.org/D12989#250247, @tra wrote: > I'll add tests for install dir detection. As for detection of bitcode files, > perhaps I should remove it from this patch and commit it along with the code > that's going to use it and where I can test it.

Re: [PATCH] D9040: [analyzer] Make realloc(ptr, 0) handling equivalent to malloc(0).

ayartsev added a comment. Ping. http://reviews.llvm.org/D9040 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D9040: [analyzer] Make realloc(ptr, 0) handling equivalent to malloc(0).

zaks.anna accepted this revision. zaks.anna added a comment. This revision is now accepted and ready to land. See the suggestion for an improved comment. Otherwise, LGTM! Thanks! Anna. Comment at: lib/StaticAnalyzer/Checkers/MallocChecker.cpp:902 @@ +901,3 @@ +} else { +

Re: [PATCH] D12793: Three new security overflow builtins with generic argument types

rjmccall added a comment. Thanks for doing this; this is a great start. Comment at: docs/LanguageExtensions.rst:1720 @@ -1712,1 +1719,3 @@ +being stored there, and the function returns 1. The behavior of these builtins +is well-defined for all argument values.

Re: r247618 - C11 _Bool bitfield diagnostic

Do you plan to fix diagnostic emission for cases like "bool b : 4" in the near future, or it makes sense to revert this change until we reach consensus on the rules, and implementation? On Fri, Sep 18, 2015 at 11:17 PM, Nico Weber via cfe-commits < cfe-commits@lists.llvm.org> wrote: > On Fri,

Re: [PATCH] D12689: [libc++][static linking] std streams are not initialized prior to their use in static object constructors

I think you need to address the feedback about avoiding dynamic initialization on stock non-Mac systems. Sent from phone On Sep 21, 2015 8:33 AM, "Evgeny Astigeevich" wrote: > eastig added a comment. > > Ping. > > > http://reviews.llvm.org/D12689 > > > >

r248158 - Fix assertion in inline assembler IR gen

Author: amusman Date: Mon Sep 21 09:41:00 2015 New Revision: 248158 URL: http://llvm.org/viewvc/llvm-project?rev=248158=rev Log: Fix assertion in inline assembler IR gen Several inputs may not refer to one output constraint in inline assembler insertions, clang was failing on assertion on such

Re: [PATCH] D13004: Create a new attribute set when the definition is parsed after a declaration of a function

vsk added a subscriber: vsk. vsk added a comment. Thanks, LGTM. http://reviews.llvm.org/D13004 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libclc] r248163 - Add sampler defines.

Author: tstellar Date: Mon Sep 21 09:59:58 2015 New Revision: 248163 URL: http://llvm.org/viewvc/llvm-project?rev=248163=rev Log: Add sampler defines. Patch by: Zoltan Gilian Modified: libclc/trunk/generic/include/clc/image/image_defines.h Modified:

[libclc] r248162 - Add image attribute defines.

Author: tstellar Date: Mon Sep 21 09:59:57 2015 New Revision: 248162 URL: http://llvm.org/viewvc/llvm-project?rev=248162=rev Log: Add image attribute defines. Patch by: Zoltan Gilian Added: libclc/trunk/generic/include/clc/image/image_defines.h Modified:

Re: [PATCH] D12689: [libc++][static linking] std streams are not initialized prior to their use in static object constructors

eastig added a comment. Ping. http://reviews.llvm.org/D12689 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D12633: Implement ACLE 2.0 macros of chapters 6.6 and 6.7 for [ARM] and [Aarch64] targets

labrinea added a comment. @rsmith @t.p.northover could you please give us some feedback on this? Thanks. http://reviews.llvm.org/D12633 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D13013: [ARM] Fix crash "-target arm -mcpu=generic", without "-march="

rengolin added a comment. Hi Vladmir, Can you explain what the crash was? cheers, --renato Repository: rL LLVM http://reviews.llvm.org/D13013 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D12761: MPI-Checker patch for Clang Static Analyzer

Alexander_Droste added inline comments. Comment at: tools/clang/lib/StaticAnalyzer/Checkers/MPI-Checker/MPIBugReporter.cpp:137 @@ +136,3 @@ + + // This is never reached... + llvm::outs() << "" Alexander_Droste wrote: > I figured out what the

Re: r248184 - Debug Info: When building a module, emit skeleton CUs for imported modules.

> On Sep 21, 2015, at 10:59 AM, David Blaikie wrote: > > > > On Mon, Sep 21, 2015 at 10:48 AM, Adrian Prantl via cfe-commits > > wrote: > Author: adrian > Date: Mon Sep 21 12:48:37 2015 > New Revision: 248184

Re: [PATCH] D13004: Create a new attribute set when the definition is parsed after a declaration of a function

> On 2015-Sep-21, at 01:42, Akira Hatanaka via cfe-commits > wrote: > > ahatanak created this revision. > ahatanak added a subscriber: cfe-commits. > > An assert is triggered when the test case program is compiled with -Oz: > > Assertion failed:

Re: [PATCH] D10370: clang-format: Implement AlwaysBreakAfterDeclarationReturnType.

djasper added a comment. Maintenance is not about writing 7 lines of code correctly, but ensuring that all these options work correctly and in combination with all other options and that options remain discoverable and well documented. So, please change this to using the one enum with 5

Re: r248154 - [ARM] Handle +t2dsp feature as an ArchExtKind in ARMTargetParser.def

Hi Artyom, I have reverted this in r248173 because the pre-commmit review was not completed. Cheers, James On Mon, 21 Sep 2015 at 06:20 Artyom Skrobov via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: askrobov > Date: Mon Sep 21 08:19:25 2015 > New Revision: 248154 > > URL:

Re: [PATCH] D12633: Implement ACLE 2.0 macros of chapters 6.6 and 6.7 for [ARM] and [Aarch64] targets

rengolin added a comment. Richard, The original patch was following a lot from the AArch64, so I suspect we should first fix the AArch64 side, so that we can follow in a similar way. I don't want to have two different behaviour for ARM and AArch64 regarding macros and ACLE support. But I also

Re: [PATCH] D12633: Implement ACLE 2.0 macros of chapters 6.6 and 6.7 for [ARM] and [Aarch64] targets

richard.barton.arm added a comment. Yes - I would be interested in knowing the rationale behind the original AArch64 setting of __ARM_FP_FPENV_ROUNDING. I also question whether our pre-conditions for __ARM_FP_FAST are sufficient. There are many -f... options relating to maths operations, are

Re: [PATCH] D12955: Fix assertion in inline assembler IR gen

amusman added inline comments. Comment at: lib/Sema/SemaStmtAsm.cpp:447 @@ +446,3 @@ +// Make sure no more than one input constraint matches each output. +if (InputMatchedToOutput[TiedTo] != ~0U) { + Diag(NS->getInputExpr(i)->getLocStart(),

Re: [PATCH] D12938: [ARM] Handle +t2dsp feature as an ArchExtKind in ARMTargetParser.def

This revision was automatically updated to reflect the committed changes. Closed by commit rL248154: [ARM] Handle +t2dsp feature as an ArchExtKind in ARMTargetParser.def (authored by askrobov). Changed prior to commit: http://reviews.llvm.org/D12938?vs=35001=35244#toc Repository: rL LLVM

Re: r248142 - clang/test/Modules/DebugInfoSubmodules.c REQUIRES asserts due to -debug-only.

Thanks for fixing this! -- adrian > On Sep 20, 2015, at 11:57 PM, NAKAMURA Takumi via cfe-commits > wrote: > > Author: chapuni > Date: Mon Sep 21 01:57:36 2015 > New Revision: 248142 > > URL: http://llvm.org/viewvc/llvm-project?rev=248142=rev > Log: >

[libclc] r248161 - r600: Add image writing builtins.

Author: tstellar Date: Mon Sep 21 09:59:56 2015 New Revision: 248161 URL: http://llvm.org/viewvc/llvm-project?rev=248161=rev Log: r600: Add image writing builtins. Patch by: Zoltan Gilian Added: libclc/trunk/r600/lib/image/write_image_impl.ll libclc/trunk/r600/lib/image/write_imagef.cl

[libclc] r248160 - r600: Add image reading builtins.

Author: tstellar Date: Mon Sep 21 09:59:54 2015 New Revision: 248160 URL: http://llvm.org/viewvc/llvm-project?rev=248160=rev Log: r600: Add image reading builtins. Patch by: Zoltan Gilian Added: libclc/trunk/r600/lib/image/read_image_impl.ll libclc/trunk/r600/lib/image/read_imagef.cl

Re: [PATCH] D12938: [ARM] Handle +t2dsp feature as an ArchExtKind in ARMTargetParser.def

Hi Artyom, This, too, looks to be unreviewed. Could you please explain what's going on here? James On Mon, 21 Sep 2015 at 06:21, Phabricator via cfe-commits < cfe-commits@lists.llvm.org> wrote: > This revision was automatically updated to reflect the committed changes. > Closed by commit

[libclc] r248159 - Add image attribute getter builtins

Author: tstellar Date: Mon Sep 21 09:47:53 2015 New Revision: 248159 URL: http://llvm.org/viewvc/llvm-project?rev=248159=rev Log: Add image attribute getter builtins Added get_image_* OpenCL builtins to the headers. Added implementation to the r600 target. Patch by: Zoltan Gilian Added:

Re: [PATCH] D12482: Analyzer: Teach analyzer how to handle TypeTraitExpr

ismailp added a comment. Ping! http://reviews.llvm.org/D12482 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D13006: Replace references to "transform" with references to "check" where neccessary in the documentation.

angelgarcia created this revision. angelgarcia added a reviewer: alexfh. angelgarcia added subscribers: klimek, cfe-commits. Replace references to "transform" with references to "check" where neccessary in the documentation. http://reviews.llvm.org/D13006 Files:

r248145 - clang-format: Fix merging short case labels with comments.

Author: djasper Date: Mon Sep 21 04:50:01 2015 New Revision: 248145 URL: http://llvm.org/viewvc/llvm-project?rev=248145=rev Log: clang-format: Fix merging short case labels with comments. This fixes llvm.org/PR24877. Patch by Benjamin Daly, thank you! Modified:

Re: [PATCH] D12358: [Analyzer] Handling constant bound loops

seaneveson updated this revision to Diff 35216. seaneveson added a comment. The TK_EntireMemSpace trait is now used when invalidating. The trait was added in http://reviews.llvm.org/D12993, thank you Devin for that patch. Updated to the latest trunk. http://reviews.llvm.org/D12358 Files:

Re: r248184 - Debug Info: When building a module, emit skeleton CUs for imported modules.

On Mon, Sep 21, 2015 at 12:25 PM, Adrian Prantl wrote: > > On Sep 21, 2015, at 11:25 AM, David Blaikie wrote: > > > > On Mon, Sep 21, 2015 at 11:18 AM, Adrian Prantl wrote: > >> >> On Sep 21, 2015, at 10:59 AM, David Blaikie

r248205 - clang-format: Remove ChromiumStyle.MacroBlockBegin.

Author: nico Date: Mon Sep 21 15:06:42 2015 New Revision: 248205 URL: http://llvm.org/viewvc/llvm-project?rev=248205=rev Log: clang-format: Remove ChromiumStyle.MacroBlockBegin. We prefer setting these in our .clang-format file as the macros change over time. (Also, the code was setting

[clang-tools-extra] r248151 - [clang-tidy] Fixed formatting of headings in the docs.

Author: alexfh Date: Mon Sep 21 07:13:27 2015 New Revision: 248151 URL: http://llvm.org/viewvc/llvm-project?rev=248151=rev Log: [clang-tidy] Fixed formatting of headings in the docs. Modified: clang-tools-extra/trunk/docs/clang-tidy/checks/modernize-loop-convert.rst

[PATCH] D13015: [X86] Make f16c intrinsics accessible through emmintrin.h, per Intel docs

mkuper created this revision. mkuper added a reviewer: AsafBadouh. mkuper added a subscriber: cfe-commits. http://reviews.llvm.org/D13015 Files: lib/Headers/emmintrin.h lib/Headers/f16cintrin.h Index: lib/Headers/emmintrin.h

r248156 - [X86] Make f16c intrinsics accessible through emmintrin.h, per Intel docs

Author: mkuper Date: Mon Sep 21 08:34:47 2015 New Revision: 248156 URL: http://llvm.org/viewvc/llvm-project?rev=248156=rev Log: [X86] Make f16c intrinsics accessible through emmintrin.h, per Intel docs Differential Revision: http://reviews.llvm.org/D13015 Modified:

Re: r248184 - Debug Info: When building a module, emit skeleton CUs for imported modules.

> On Sep 21, 2015, at 11:25 AM, David Blaikie wrote: > > > > On Mon, Sep 21, 2015 at 11:18 AM, Adrian Prantl > wrote: > >> On Sep 21, 2015, at 10:59 AM, David Blaikie > >

Re: r248184 - Debug Info: When building a module, emit skeleton CUs for imported modules.

On Mon, Sep 21, 2015 at 11:18 AM, Adrian Prantl wrote: > > On Sep 21, 2015, at 10:59 AM, David Blaikie wrote: > > > > On Mon, Sep 21, 2015 at 10:48 AM, Adrian Prantl via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> Author: adrian >> Date: Mon

Re: [PATCH] D13004: Create a new attribute set when the definition is parsed after a declaration of a function

On Mon, Sep 21, 2015 at 11:03 AM, Duncan P. N. Exon Smith < dexonsm...@apple.com> wrote: > > > On 2015-Sep-21, at 01:42, Akira Hatanaka via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > > > > ahatanak created this revision. > > ahatanak added a subscriber: cfe-commits. > > > > An assert is

Re: [PATCH] D12482: Analyzer: Teach analyzer how to handle TypeTraitExpr

dcoughlin added a comment. Ismail, is 24710 the right bug? It is "clang-tidy segfaults with relative include paths". https://llvm.org/bugs/show_bug.cgi?id=24710 http://reviews.llvm.org/D12482 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D12996: Driver: support ARM/HF on a single toolchain

jroelofs added a subscriber: jroelofs. jroelofs added a comment. You'll also need a corresponding patch for compiler-rt to make it use the new name appropriately. http://reviews.llvm.org/D12996 ___ cfe-commits mailing list

Re: [PATCH] D12982: Move routines for guessing mode/target from driver to ToolChain

zarko added a comment. This should be a straight move, unless there is something I don't understand about the semantics of `llvm::InitializeAllTargets();` that would make moving it earlier in `main` a bad idea. Repository: rL LLVM http://reviews.llvm.org/D12982

Re: [PATCH] D12774: createUniqueFile() is documented to create the file in the temporary directory unless it's supplied an absolute path.Make sure the output filepath supplied to createUniqueFile() in

dirty added a comment. Are you suggesting I change the code to something like the following: if (std::error_code EC = llvm::sys::fs::make_absolute(Model)) { llvm::errs() << "warning: could not make '" << Model << "' absolute: " << EC.message() << '\n';