r248929 - clang-format: Add clangRewrite dependency to fix cmake build.

Author: djasper Date: Wed Sep 30 14:28:47 2015 New Revision: 248929 URL: http://llvm.org/viewvc/llvm-project?rev=248929=rev Log: clang-format: Add clangRewrite dependency to fix cmake build. Modified: cfe/trunk/tools/clang-format/CMakeLists.txt Modified:

Re: r248904 - clang-format: Use Rewriter again to write the output files.

cmake build hopefully fixed in r248929. How is the patch you have attached related? On Wed, Sep 30, 2015 at 9:24 PM, Daniel Jasper wrote: > This breaks your *build*? How? > > On Wed, Sep 30, 2015 at 9:19 PM, Jan Vesely > wrote: > >> Hi, >> I think

Re: r248904 - clang-format: Use Rewriter again to write the output files.

Hi, I think this change breaks cmake build. Please consider the attached fix (I can't push atm). thank you, Jan On Wed, Sep 30, 2015 at 8:59 AM, Daniel Jasper via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: djasper > Date: Wed Sep 30 08:59:29 2015 > New Revision: 248904 > > URL:

Re: [PATCH] D13279: Decorating virtual functions load with invariant.load

Prazek updated this revision to Diff 36125. http://reviews.llvm.org/D13279 Files: lib/CodeGen/ItaniumCXXABI.cpp test/CodeGenCXX/virtual-function-calls.cpp Index: test/CodeGenCXX/virtual-function-calls.cpp === ---

Re: [PATCH] D11908: Clang support for -fthinlto.

On Wed, Sep 30, 2015 at 10:19 AM, Duncan P. N. Exon Smith wrote: > >> On 2015-Sep-23, at 10:28, Teresa Johnson wrote: >> >> tejohnson updated this revision to Diff 35527. >> tejohnson added a comment. >> >> Updated the patch for the new LLVM/gold patch

r248925 - [Sema] Avoid crashing during this-> insertion recovery

Author: rnk Date: Wed Sep 30 12:30:48 2015 New Revision: 248925 URL: http://llvm.org/viewvc/llvm-project?rev=248925=rev Log: [Sema] Avoid crashing during this-> insertion recovery We get into this bad state when someone defines a new member function for a class but forgets to add the declaration

Re: [PATCH] D13279: Decorating virtual functions load with invariant.load

Prazek updated this revision to Diff 36130. http://reviews.llvm.org/D13279 Files: lib/CodeGen/ItaniumCXXABI.cpp test/CodeGenCXX/virtual-function-calls.cpp Index: test/CodeGenCXX/virtual-function-calls.cpp === ---

Re: [PATCH] D12251: Analyzer: Calculate field offset correctly

dcoughlin added inline comments. Comment at: test/Analysis/array-struct-region.cpp:128 @@ +127,3 @@ +#if __cplusplus + clang_analyzer_eval((void *)>secondField != (void *)); // expected-warning{{TRUE}} +#endif ismailp wrote: > I might be missing something, and

r248928 - Don't correct non-class using declarations to class members.

Author: rikka Date: Wed Sep 30 13:23:35 2015 New Revision: 248928 URL: http://llvm.org/viewvc/llvm-project?rev=248928=rev Log: Don't correct non-class using declarations to class members. Such declarations would be invalid anyway, and trying to make the correction will lead to a crash. Fixes PR

Re: [PATCH] D11908: Clang support for -fthinlto.

> On 2015-Sep-23, at 10:28, Teresa Johnson wrote: > > tejohnson updated this revision to Diff 35527. > tejohnson added a comment. > > Updated the patch for the new LLVM/gold patch > (http://reviews.llvm.org/D13107). > > Two changes: > > - I put back the original change

Re: [PATCH] D11908: Clang support for -fthinlto.

> On 2015-Sep-30, at 10:40, Teresa Johnson wrote: > > On Wed, Sep 30, 2015 at 10:19 AM, Duncan P. N. Exon Smith > wrote: >> >>> On 2015-Sep-23, at 10:28, Teresa Johnson wrote: >>> >>> tejohnson updated this revision to Diff

Re: r248904 - clang-format: Use Rewriter again to write the output files.

This breaks your *build*? How? On Wed, Sep 30, 2015 at 9:19 PM, Jan Vesely wrote: > Hi, > I think this change breaks cmake build. Please consider the attached fix > (I can't push atm). > > thank you, > Jan > > On Wed, Sep 30, 2015 at 8:59 AM, Daniel Jasper via

[PATCH] D13280: Adding reserved operator logical xor for OpenCL

neil.hickey created this revision. neil.hickey added a reviewer: cfe-commits. This patch adds the reserved operator ^^ when compiling for OpenCL, which results in a more meaningful error message. http://reviews.llvm.org/D13280 Files: include/clang/Basic/DiagnosticParseKinds.td

[PATCH] D13279: Decorating virtual functions load with invariant.load

Prazek created this revision. Prazek added reviewers: rsmith, majnemer, nlewycky, rjmccall. Prazek added a subscriber: cfe-commits. http://reviews.llvm.org/D13279 Files: lib/CodeGen/ItaniumCXXABI.cpp test/CodeGenCXX/virtual-function-calls.cpp Index:

Re: r248904 - clang-format: Use Rewriter again to write the output files.

Ah, very sorry, I was looking at the wrong patch. So I did make the same change :-) On Wed, Sep 30, 2015 at 9:30 PM, Daniel Jasper wrote: > cmake build hopefully fixed in r248929. How is the patch you have attached > related? > > On Wed, Sep 30, 2015 at 9:24 PM, Daniel

r248935 - Revert "[DarwinDriver] Use -lto_library to specify the path for libLTO.dylib"

Author: bruno Date: Wed Sep 30 15:11:02 2015 New Revision: 248935 URL: http://llvm.org/viewvc/llvm-project?rev=248935=rev Log: Revert "[DarwinDriver] Use -lto_library to specify the path for libLTO.dylib" Revert r248932. Bots complaining about new warnings where they shouldn't. Modified:

r248932 - [DarwinDriver] Use -lto_library to specify the path for libLTO.dylib

Author: bruno Date: Wed Sep 30 14:55:07 2015 New Revision: 248932 URL: http://llvm.org/viewvc/llvm-project?rev=248932=rev Log: [DarwinDriver] Use -lto_library to specify the path for libLTO.dylib Usually, when using LTO with a clang installation newer than the system's one, there's a

LLVM buildnaster will be restarted tonight

Hello everyone, LLVM buildmaster will be restarted after 6 PM Pacific time today. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D12761: MPI-Checker patch for Clang Static Analyzer

zaks.anna added inline comments. Comment at: tools/clang/lib/StaticAnalyzer/Checkers/MPI-Checker/MPITypes.h:67 @@ +66,3 @@ + // Every time a request is 'set' a new 'RequestId' gets created. + // Therefore, the 'UserKind' does not need to be profiled. + const int

Re: [PATCH] D12979: Avoid inlining in exception handling context

junbuml abandoned this revision. junbuml added a comment. Move this clang change in http://reviews.llvm.org/D13304 http://reviews.llvm.org/D12979 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: r248932 - [DarwinDriver] Use -lto_library to specify the path for libLTO.dylib

Nice! On 30 September 2015 at 15:55, Bruno Cardoso Lopes via cfe-commits wrote: > Author: bruno > Date: Wed Sep 30 14:55:07 2015 > New Revision: 248932 > > URL: http://llvm.org/viewvc/llvm-project?rev=248932=rev > Log: > [DarwinDriver] Use -lto_library to specify the

r248949 - Don't inherit availability information when implementing a protocol requirement.

Author: dgregor Date: Wed Sep 30 16:27:42 2015 New Revision: 248949 URL: http://llvm.org/viewvc/llvm-project?rev=248949=rev Log: Don't inherit availability information when implementing a protocol requirement. When an Objective-C method implements a protocol requirement, do not inherit any

[PATCH] D13304: Avoid inlining in throw statement

junbuml created this revision. junbuml added reviewers: hfinkel, mcrosier, reames, ashutosh.nema, majnemer. junbuml added subscribers: gberry, cfe-commits. It might be reasonably to avoid inlining CallSites invoked in exception handling context so that we can reduce code size blow-up in EH

Re: [PATCH] D11908: Clang support for -fthinlto.

+echristo, +espindola, +pcc > On 2015-Sep-30, at 12:39, Teresa Johnson wrote: > > On Wed, Sep 30, 2015 at 11:11 AM, Duncan P. N. Exon Smith > wrote: >> >>> On 2015-Sep-30, at 10:40, Teresa Johnson wrote: >>> >>> On Wed, Sep

Re: [PATCH] D12761: MPI-Checker patch for Clang Static Analyzer

Alexander_Droste added a comment. > We gave a talk about building checkers a while back; even though it does not > talk about the bug reporter visitors, it might be worth watching if you > haven't already seen it. I have watched it some months ago but I'm sure it is a good idea to revisit the

r248891 - [OpenCL 2.0] Fix wrong atomic type detection in the diagnostics of allowed types

Author: stulova Date: Wed Sep 30 06:48:15 2015 New Revision: 248891 URL: http://llvm.org/viewvc/llvm-project?rev=248891=rev Log: [OpenCL 2.0] Fix wrong atomic type detection in the diagnostics of allowed types Modified: cfe/trunk/lib/Sema/SemaType.cpp

r248880 - [OPENMP 4.1] Sema analysis for array sections in 'reduction' clause.

Author: abataev Date: Wed Sep 30 04:22:36 2015 New Revision: 248880 URL: http://llvm.org/viewvc/llvm-project?rev=248880=rev Log: [OPENMP 4.1] Sema analysis for array sections in 'reduction' clause. OpenMP 4.1 allows to use array sections|subscript expressions in 'reduction' clauses. Added sema

Re: [PATCH] D13127: [ARM] Upgrade codegen for vld[234] and vst[234] to to communicate a 0 address space

sbaranga accepted this revision. sbaranga added a comment. This revision is now accepted and ready to land. LGTM http://reviews.llvm.org/D13127 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[Patch][OpenCL] Custom atomic Builtin check ignores address space of a non-atomic pointer

Hi all, Address spaces are not handled in custom semantic checks of atomic Builtins. If there are two pointers passed to the Builtin, it doesn't allow the second (non-atomic) one to be qualified with an address space. This patch removed this restriction by recording the address space

Re: [PATCH] D13127: [ARM] Upgrade codegen for vld[234] and vst[234] to to communicate a 0 address space

This revision was automatically updated to reflect the committed changes. Closed by commit rL24: [ARM][NEON] Use address space in vld([1234]|[234]lane) and vst([1234]|… (authored by jketema). Changed prior to commit: http://reviews.llvm.org/D13127?vs=35871=36082#toc Repository: rL LLVM

r248888 - [ARM][NEON] Use address space in vld([1234]|[234]lane) and vst([1234]|[234]lane) instructions

Author: jketema Date: Wed Sep 30 05:56:56 2015 New Revision: 24 URL: http://llvm.org/viewvc/llvm-project?rev=24=rev Log: [ARM][NEON] Use address space in vld([1234]|[234]lane) and vst([1234]|[234]lane) instructions This is the clang commit associated with llvm r248887. This commit

[PATCH] D13285: Fix for bug 24196: clang fails on assertion on complex doubles multiplication when EH is enabled

d.zobnin.bugzilla created this revision. d.zobnin.bugzilla added reviewers: rsmith, rjmccall. d.zobnin.bugzilla added a subscriber: cfe-commits. This patch fixes an assertion failure, caused by EmitCall function producing llvm::InvokeInst* when llvm::CallInst* is needed (when multiplication of

r248902 - [OpenCL] Add missing OpenCL LangOpts in address space compatibility checks

Author: stulova Date: Wed Sep 30 08:49:55 2015 New Revision: 248902 URL: http://llvm.org/viewvc/llvm-project?rev=248902=rev Log: [OpenCL] Add missing OpenCL LangOpts in address space compatibility checks and test checking broken (due to CL specific diagnostics) C functionality M

[PATCH] D13289: [libc++] Provide additional templates for valarray transcendentals that satisfy the standard synopsis

petpav01 created this revision. petpav01 added a subscriber: cfe-commits. Libc++ provides valarray transcendentals with replacement types. These functions are implemented either as `template` or `template`, where `_Expr` can be `__val_expr` or `valarray`. The patch provides additional function

Re: [PATCH] D13249: Divide TraverseInitListExpr to a different function for each form.

angelgarcia updated this revision to Diff 36099. angelgarcia added a comment. Add some comments. http://reviews.llvm.org/D13249 Files: include/clang/AST/RecursiveASTVisitor.h Index: include/clang/AST/RecursiveASTVisitor.h ===

[clang-tools-extra] r248895 - [clang-tidy] Fix an assertion in the readability-braces-around-statements check.

Author: alexfh Date: Wed Sep 30 07:48:42 2015 New Revision: 248895 URL: http://llvm.org/viewvc/llvm-project?rev=248895=rev Log: [clang-tidy] Fix an assertion in the readability-braces-around-statements check. Modified:

r248896 - [OpenCL 2.0] This change adds extra diagnostics to atomic types

Author: stulova Date: Wed Sep 30 08:18:52 2015 New Revision: 248896 URL: http://llvm.org/viewvc/llvm-project?rev=248896=rev Log: [OpenCL 2.0] This change adds extra diagnostics to atomic types Applied restrictions from OpenCL v2.0 s6.13.11.8 that mainly disallow operations on atomic types

[clang-tools-extra] r248899 - [clang-tidy] Added missing check lines, made the checking stricter.

Author: alexfh Date: Wed Sep 30 08:32:42 2015 New Revision: 248899 URL: http://llvm.org/viewvc/llvm-project?rev=248899=rev Log: [clang-tidy] Added missing check lines, made the checking stricter. Modified: clang-tools-extra/trunk/test/clang-tidy/diagnostic.cpp Modified:

r248950 - Don't inherit the "unavailable" attribute from an overridden superclass method.

Author: dgregor Date: Wed Sep 30 16:34:33 2015 New Revision: 248950 URL: http://llvm.org/viewvc/llvm-project?rev=248950=rev Log: Don't inherit the "unavailable" attribute from an overridden superclass method. Fixes rdar://problem/22922259. Modified: cfe/trunk/lib/Sema/SemaDecl.cpp

r248951 - [CUDA] fix codegen for __nvvm_atom_cas_*

Author: jingyue Date: Wed Sep 30 16:49:32 2015 New Revision: 248951 URL: http://llvm.org/viewvc/llvm-project?rev=248951=rev Log: [CUDA] fix codegen for __nvvm_atom_cas_* Summary: __nvvm_atom_cas_* returns the old value instead of whether the swap succeeds. Reviewers: eliben, tra Subscribers:

Re: [PATCH] D13313: [clang-tidy] new check misc-no-reinterpret-cast

vsk added a subscriber: vsk. vsk added a comment. The patch lgtm. Has there been a discussion on cfe-dev about adopting these guidelines? I count well over 500 uses of reinterpret_cast in llvm+clang, so we might not all be on the same page on this. http://reviews.llvm.org/D13313

[PATCH] D13317: clang_Cursor_getMangling shouldn't mangle if the declaration isn't mangled

michaelwu created this revision. michaelwu added a subscriber: cfe-commits. Right now clang_Cursor_getMangling will attempt to mangle any declaration, even if the declaration isn't mangled (extern "C"). This results in a partially mangled name which isn't useful for much. This patch makes

Re: [PATCH] D13319: Eliminate __llvm_profile_register calls

davidxl added a comment. With this patch, 11M bytes (text section) can be shaved off clang build with instrumentation. http://reviews.llvm.org/D13319 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D13318: Add a utility function to add target information to a command line

zarko created this revision. zarko added reviewers: rnk, echristo, klimek. zarko added a subscriber: cfe-commits. Herald added subscribers: srhines, danalbert, tberghammer, klimek. This diff adds `addTargetAndModeForProgramName`, a utility function that will add appropriate `-target foo` and

Re: [PATCH] D12839: Extend MoveConstructorInitCheck to also flag constructor arguments passed by value and can be moved assigned to fields.

flx updated this revision to Diff 36151. flx marked an inline comment as done. flx added a comment. Thanks for catching the last issues, Alex. I rebuilt and ran all tests using llvm-lit -v . for clang-tidy and they pass. http://reviews.llvm.org/D12839 Files:

[PATCH] D13319: Eliminate __llvm_profile_register calls

davidxl created this revision. davidxl added reviewers: bogner, rsmith. davidxl added subscribers: cfe-commits, llvm-commits. Herald added subscribers: srhines, danalbert, tberghammer. With PGO, the instrumented binary needs to dump __llvm_prf_data, __llvm_prf_cnts, and __llvm_prf_names data

Re: [PATCH] D13157: Teach -Wtautological-overlap-compare about enums

rtrieu accepted this revision. rtrieu added a comment. Fix the comments, then it should be ready to commit. Comment at: lib/Analysis/CFG.cpp:49 @@ +48,3 @@ +tryNormalizeBinaryOperator(const BinaryOperator *B) { + auto TryTransformToIntOrEnumConstant = [](const Expr *E) ->

[PATCH] D13313: [clang-tidy] new check misc-no-reinterpret-cast

mgehre created this revision. mgehre added a subscriber: cfe-commits. This check flags all uses of reinterpret_cast in C++ code. Use of these casts can violate type safety and cause the program to access a variable that is actually of type X to be accessed as if it were of an unrelated type Z.

Re: [PATCH] D12774: createUniqueFile() is documented to create the file in the temporary directory unless it's supplied an absolute path.Make sure the output filepath supplied to createUniqueFile() in

vsk added a comment. LGTM, thanks. http://reviews.llvm.org/D12774 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r248953 - [Sema] Don't crash when friending an unqualified templated constructor

Author: majnemer Date: Wed Sep 30 17:07:43 2015 New Revision: 248953 URL: http://llvm.org/viewvc/llvm-project?rev=248953=rev Log: [Sema] Don't crash when friending an unqualified templated constructor Unqualified templated constructors cannot be friended and our lack of a diagnostic led to

Re: [PATCH] D13319: Eliminate __llvm_profile_register calls

rsmith added a comment. Clang changes LGTM. http://reviews.llvm.org/D13319 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D13317: clang_Cursor_getMangling shouldn't mangle if the declaration isn't mangled

rsmith added a subscriber: rsmith. Comment at: tools/libclang/CIndex.cpp:3895 @@ +3894,3 @@ + // Don't mangle if we don't need to. + if (!MC->shouldMangleCXXName(ND)) +return cxstring::createEmpty(); You should use `shouldMangleDeclName` here instead; this

r248975 - Fix printing of parameterized Objective-C interfaces.

Author: bwilson Date: Wed Sep 30 19:53:13 2015 New Revision: 248975 URL: http://llvm.org/viewvc/llvm-project?rev=248975=rev Log: Fix printing of parameterized Objective-C interfaces. This change was accidentally omitted from Doug's change in r241541. Modified:

r248977 - createUniqueFile() is documented to create the file in the temporary directory unless it's supplied an absolute path.

Author: dirty Date: Wed Sep 30 20:24:59 2015 New Revision: 248977 URL: http://llvm.org/viewvc/llvm-project?rev=248977=rev Log: createUniqueFile() is documented to create the file in the temporary directory unless it's supplied an absolute path. Make sure the output filepath supplied to

Re: [PATCH] D11207: Enable recognition of __declspec for PS4

wristow abandoned this revision. wristow added a comment. This has been superseded by http://reviews.llvm.org/D13322. http://reviews.llvm.org/D11207 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D13324: Fix the SSE4 byte sign extension in a cleaner way, and more thoroughly test that our intrinsics behave the same under -fsigned-char and -funsigned-char.

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. LGTM http://reviews.llvm.org/D13324 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D13322: Add -f[no-]declspec to control recognition of __declspec as a keyword

wristow created this revision. wristow added reviewers: aaron.ballman, ygao, alexr, silvas, compnerd, cfe-commits. In versions of clang prior to r238238, __declspec was recognized as a keyword in all modes. It was then changed to only be enabled when Microsoft or Borland extensions were enabled

Re: [PATCH] D13319: Eliminate __llvm_profile_register calls

davidxl abandoned this revision. davidxl added a comment. Will split the patch into 3. http://reviews.llvm.org/D13319 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r248982 - Decorating virtual functions load with invariant.load

Author: prazek Date: Wed Sep 30 22:50:41 2015 New Revision: 248982 URL: http://llvm.org/viewvc/llvm-project?rev=248982=rev Log: Decorating virtual functions load with invariant.load http://reviews.llvm.org/D13279 Modified: cfe/trunk/lib/CodeGen/ItaniumCXXABI.cpp

Re: [PATCH] D13319: Eliminate __llvm_profile_register calls

rsmith added inline comments. Comment at: lib/Driver/ToolChains.cpp:2191-2193 @@ +2190,5 @@ + + SmallString<128> Path(getDriver().ResourceDir); + llvm::sys::path::append(Path, "prf_data.x"); + CmdArgs.push_back(Args.MakeArgString(Path)); + return true; Please

r248974 - Module debugging: Emit Objective-C interfaces in their module scope when

Author: adrian Date: Wed Sep 30 19:48:51 2015 New Revision: 248974 URL: http://llvm.org/viewvc/llvm-project?rev=248974=rev Log: Module debugging: Emit Objective-C interfaces in their module scope when building a clang module. Modified: cfe/trunk/lib/CodeGen/CGDebugInfo.cpp

Re: [PATCH] D13318: Add a utility function to add target information to a command line

echristo added a subscriber: echristo. echristo added a comment. This seems a little odd, could you explain in a bit more detail? Me not understanding I imagine. :) -eric http://reviews.llvm.org/D13318 ___ cfe-commits mailing list

[PATCH] D13325: Fix crash in codegen on casting to `bool &`.

ABataev created this revision. ABataev added a reviewer: rjmccall. ABataev added a subscriber: cfe-commits. Currently codegen crashes trying to emit casting to `bool &`. It happens because `bool` type is converted to `i1` and later then lvalue for reference is converted to `i1*`. But when

Re: [PATCH] D13319: Eliminate __llvm_profile_register calls

David Li writes: > davidxl created this revision. > davidxl added reviewers: bogner, rsmith. > davidxl added subscribers: cfe-commits, llvm-commits. > Herald added subscribers: srhines, danalbert, tberghammer. > > With PGO, the instrumented binary needs to dump

r248980 - Patch over a really horrible bug in our vector builtins that showed up

Author: chandlerc Date: Wed Sep 30 21:21:34 2015 New Revision: 248980 URL: http://llvm.org/viewvc/llvm-project?rev=248980=rev Log: Patch over a really horrible bug in our vector builtins that showed up recently when we started using direct conversion to model sign extension. The __v16qi type we

[PATCH] D13324: Fix the SSE4 byte sign extension in a cleaner way, and more thoroughly test that our intrinsics behave the same under -fsigned-char and -funsigned-char.

chandlerc created this revision. chandlerc added a reviewer: rsmith. chandlerc added a subscriber: cfe-commits. This further testing uncovered that AVX-2 has a broken cmpgt for 8-bit elements, and has for a long time. This is fixed in the same way as SSE4 handles the case. The other ISA

Re: r248980 - Patch over a really horrible bug in our vector builtins that showed up

Note that http://reviews.llvm.org/D13324 is the promised improved fix here, awaiting review. =] On Wed, Sep 30, 2015 at 7:23 PM Chandler Carruth via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: chandlerc > Date: Wed Sep 30 21:21:34 2015 > New Revision: 248980 > > URL:

Re: [PATCH] D12979: Avoid inlining in exception handling context

junbuml added a comment. In this clang change, I added a state flag (bool IsColdRegion) in CodeGenFunction and set/reset the flag in EmitCXXThrowExpr(). In EmitCall(), the NoInline attribute would be added if IsColdRegion is true. As of now, this change only handles throw statements because I

Re: [PATCH] D12979: Avoid inlining in exception handling context

junbuml edited subscribers, added: cfe-commits; removed: llvm-commits. junbuml updated this revision to Diff 36107. http://reviews.llvm.org/D12979 Files: lib/CodeGen/CGCall.cpp lib/CodeGen/CGException.cpp lib/CodeGen/CodeGenFunction.cpp lib/CodeGen/CodeGenFunction.h

[PATCH] D13326: [PGO]: Eliminate __llvm_profile_register calls for Linux (clang changes)

davidxl created this revision. davidxl added reviewers: rsmith, bogner. davidxl added a subscriber: cfe-commits. Herald added subscribers: srhines, danalbert, tberghammer. This is the patch-1. Driver tests are also added. See http://reviews.llvm.org/D13319 for description.

Re: [PATCH] D13326: [PGO]: Eliminate __llvm_profile_register calls for Linux (clang changes)

davidxl removed subscribers: tberghammer, danalbert, srhines. davidxl updated this revision to Diff 36186. http://reviews.llvm.org/D13326 Files: include/clang/Driver/ToolChain.h lib/Driver/SanitizerArgs.cpp lib/Driver/ToolChain.cpp lib/Driver/ToolChains.cpp lib/Driver/ToolChains.h

Re: [PATCH] D13249: Divide TraverseInitListExpr to a different function for each form.

klimek added a reviewer: rsmith. klimek added a comment. +richard to tell us whether that comment is correct :) http://reviews.llvm.org/D13249 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

RE: [PATCH] D13100: [mips] Separated mips specific -Wa options, so that they are not checked on other platforms.

Hi, Sorry for the slow reply. I'm a bit behind on cfe-commits and it seems I dropped out of the CC list so it didn't land in my inbox. Do you mean something like this?: for (...) { ... switch (C.getDefaultToolChain().getArch()) { default:

Re: [PATCH] D13249: Divide TraverseInitListExpr to a different function for each form.

klimek added inline comments. Comment at: include/clang/AST/RecursiveASTVisitor.h:2066-2089 @@ -2058,26 +2065,26 @@ -// InitListExpr is a tricky one, because we want to do all our work on -// the syntactic form of the listexpr, but this method takes the -// semantic form by

Re: [PATCH] D12945: [PATCH] Add checker for objects that should not be value types

alexfh added a comment. In http://reviews.llvm.org/D12945#256509, @aaron.ballman wrote: > I settled on "expression has opaque data structure type 'FILE'; type should > only be used as a pointer and not dereferenced" but we can tweak if that > still isn't quite right. Seems good. Thank you!

r248905 - Fix FunctionParmPackExpr::Create() to take a ParmVarDecl* array.

Author: jyknight Date: Wed Sep 30 09:04:23 2015 New Revision: 248905 URL: http://llvm.org/viewvc/llvm-project?rev=248905=rev Log: Fix FunctionParmPackExpr::Create() to take a ParmVarDecl* array. FunctionParmPackExpr actually stores an array of ParmVarDecl* (and accessors return that). But, the

Re: [PATCH] D12945: [PATCH] Add checker for objects that should not be value types

aaron.ballman closed this revision. aaron.ballman added a comment. I settled on "expression has opaque data structure type 'FILE'; type should only be used as a pointer and not dereferenced" but we can tweak if that still isn't quite right. Committed in r248907. Thank you for the reviews!

[clang-tools-extra] r248907 - Adding a checker (misc-non-copyable-objects) that detects situations where a non-copyable C type is being dereferenced, such as FILE or pthread_mutex_t. Corresponds to th

Author: aaronballman Date: Wed Sep 30 09:09:38 2015 New Revision: 248907 URL: http://llvm.org/viewvc/llvm-project?rev=248907=rev Log: Adding a checker (misc-non-copyable-objects) that detects situations where a non-copyable C type is being dereferenced, such as FILE or pthread_mutex_t.

r248906 - [OpenCL 2.0] Enable program scope variables, Section 6.5.1.

Author: stulova Date: Wed Sep 30 09:08:20 2015 New Revision: 248906 URL: http://llvm.org/viewvc/llvm-project?rev=248906=rev Log: [OpenCL 2.0] Enable program scope variables, Section 6.5.1. - Remove virtual SC_OpenCLWorkGroupLocal storage type specifier as it conflicts with static local

Re: [PATCH] D13100: [mips] Separated mips specific -Wa options, so that they are not checked on other platforms.

On Wed, Sep 30, 2015 at 02:19:58PM +, Daniel Sanders via cfe-commits wrote: > Hi, > > Sorry for the slow reply. I'm a bit behind on cfe-commits and it seems I > dropped out of the CC list so it didn't land in my inbox. > > Do you mean something like this?: > for (...) { > ...

Re: [PATCH] D12979: Avoid inlining in exception handling context

hfinkel added a comment. You should start a new differential for this, so that you can get a clean summary e-mail with a description sent to cfe-commits. There's some overlap, but you'll also get potentially-different reviewers here. http://reviews.llvm.org/D12979

Re: [PATCH] D12793: Three new overflow builtins with generic argument types

DavidEGrayson updated this revision to Diff 36117. DavidEGrayson added a comment. I changed the patch in two ways: it now returns ExprError() is the third argument is wrong (for consistency with the other argument checking code). I removed an outdated comment for EncompassingIntegerType.

[PATCH] D13292: Add support for 'cbegin()' and 'cend()' on modernize-loop-convert.

angelgarcia created this revision. angelgarcia added a reviewer: klimek. angelgarcia added subscribers: cfe-commits, alexfh. This fixes https://llvm.org/bugs/show_bug.cgi?id=22196 . Also add a non-trivially copyable type to fix some tests that were meant to be about using const-refs, but were

r248912 - Alias "-ggdbN" to "-gN" options, fixing some incompatibilities.

Author: dougk Date: Wed Sep 30 10:55:59 2015 New Revision: 248912 URL: http://llvm.org/viewvc/llvm-project?rev=248912=rev Log: Alias "-ggdbN" to "-gN" options, fixing some incompatibilities. * assembling from a .s file mistook -ggdb0 for -g * -ggdb1 is supposed to mean basically -g1, not -gN for

Re: [PATCH] D12251: Analyzer: Calculate field offset correctly

ismailp updated this revision to Diff 36123. ismailp added a comment. - Don't try to calculate field offset for Objective-C instance variables - Added test for Objective-C instance variables - Added a non-null pointer in test http://reviews.llvm.org/D12251 Files:

Re: [PATCH] D12251: Analyzer: Calculate field offset correctly

ismailp marked 3 inline comments as done. Comment at: test/Analysis/array-struct-region.cpp:128 @@ +127,3 @@ +#if __cplusplus + clang_analyzer_eval((void *)>secondField != (void *)); // expected-warning{{TRUE}} +#endif I might be missing something, and would be