Re: r250418 - [CodeGen] Remove dead code. NFC.

Is it possible to add a unittest that exercises this extension point in-tree? For example the way I did for AA extension hooks? On Mon, Oct 19, 2015 at 9:00 PM Michael Gottesman via cfe-commits < cfe-commits@lists.llvm.org> wrote: > On Oct 19, 2015, at 4:40 PM, Michael Gottesman via cfe-commits

Re: r250418 - [CodeGen] Remove dead code. NFC.

Let me play with it a bit (I did not read the code, I just was tracking down the linkage error). Michael > On Oct 20, 2015, at 12:07 AM, Chandler Carruth wrote: > > Is it possible to add a unittest that exercises this extension point in-tree? > For example the way I did

Re: r250418 - [CodeGen] Remove dead code. NFC.

> On Oct 19, 2015, at 4:40 PM, Michael Gottesman via cfe-commits > wrote: > >> >> On Oct 15, 2015, at 8:29 AM, Benjamin Kramer via cfe-commits >> wrote: >> >> Author: d0k >> Date: Thu Oct 15 10:29:40 2015 >> New Revision: 250418 >>

r250803 - Put back dead code that's used out-of-tree.

Author: d0k Date: Tue Oct 20 02:50:21 2015 New Revision: 250803 URL: http://llvm.org/viewvc/llvm-project?rev=250803=rev Log: Put back dead code that's used out-of-tree. Partially reverts r250418. Modified: cfe/trunk/lib/CodeGen/CodeGenABITypes.cpp

Re: [PATCH] D13811: [clang-format] AllowShortFunctionsOnASingleLine: true/Empty didn't work with BreakBeforeBraces: Linux/Allman.

curdeius updated this revision to Diff 37832. curdeius added a comment. - AllowShortFunctionsOnASingleLine: true didn't work with BreakBeforeBraces: Linux/Allman. - Add test checking that non-empty functions in styles with `BraceWrapping.AfterFunction = true` don't get merged into one line. Fix

Re: [PATCH] D13871: Add modernize-use-default check to clang-tidy.

angelgarcia updated this revision to Diff 37833. angelgarcia added a comment. Global variable -> static, and a few other additions. > Will be good idea to add handling of cases where default constructor is empty > and only call base class(es) default constructor/members default constructors I

Re: r250577 - [modules] Allow the error when explicitly loading an incompatible module file

On Tue, Oct 20, 2015 at 10:41 AM Sean Silva wrote: > On Tue, Oct 20, 2015 at 1:38 AM, Manuel Klimek wrote: > >> On Tue, Oct 20, 2015 at 5:52 AM Sean Silva wrote: >> >>> On Mon, Oct 19, 2015 at 2:10 AM, Manuel Klimek

Re: r250577 - [modules] Allow the error when explicitly loading an incompatible module file

On Tue, Oct 20, 2015 at 5:52 AM Sean Silva wrote: > On Mon, Oct 19, 2015 at 2:10 AM, Manuel Klimek wrote: > >> On Sat, Oct 17, 2015 at 3:41 AM Richard Smith via cfe-commits < >> cfe-commits@lists.llvm.org> wrote: >> >>> On Fri, Oct 16, 2015 at 6:30 PM,

Re: r250577 - [modules] Allow the error when explicitly loading an incompatible module file

On Tue, Oct 20, 2015 at 1:38 AM, Manuel Klimek wrote: > On Tue, Oct 20, 2015 at 5:52 AM Sean Silva wrote: > >> On Mon, Oct 19, 2015 at 2:10 AM, Manuel Klimek wrote: >> >>> On Sat, Oct 17, 2015 at 3:41 AM Richard Smith via cfe-commits

Re: [PATCH] D13861: [x86] fix wrong maskload/store intrinsic definitions in avxintrin.h (follow up of D13776).

delena added a comment. LGTM http://reviews.llvm.org/D13861 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D13861: [x86] fix wrong maskload/store intrinsic definitions in avxintrin.h (follow up of D13776).

andreadb added a comment. In http://reviews.llvm.org/D13861#270811, @delena wrote: > LGTM Thanks Elena! Committed revision250816. Repository: rL LLVM http://reviews.llvm.org/D13861 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D13673: Add initial support for the MUSL C library.

vkalintiris updated this revision to Diff 37850. vkalintiris marked 6 inline comments as done. vkalintiris added a comment. Sorry for the delay. Addressed reviewer comments and modifed CMake to check that LIBCXX_INSTALL_SUPPORT_HEADERS is not turned off when LIBCXX_LIBC_IS_MUSL is ON.

Re: [PATCH] D13861: [x86] fix wrong maskload/store intrinsic definitions in avxintrin.h (follow up of D13776).

This revision was automatically updated to reflect the committed changes. Closed by commit rL250816: [x86] Fix maskload/store intrinsic definitions in avxintrin.h (authored by adibiagio). Changed prior to commit: http://reviews.llvm.org/D13861?vs=37741=37852#toc Repository: rL LLVM

Re: [PATCH] D13871: Add modernize-use-default check to clang-tidy.

angelgarcia updated this revision to Diff 37859. angelgarcia added a comment. Remove the fixme. http://reviews.llvm.org/D13871 Files: clang-tidy/modernize/CMakeLists.txt clang-tidy/modernize/ModernizeTidyModule.cpp clang-tidy/modernize/UseDefaultCheck.cpp

[PATCH] D13889: Apply modernize-use-default to clang-tools-extra.

angelgarcia created this revision. angelgarcia added a reviewer: klimek. angelgarcia added subscribers: cfe-commits, alexfh. Replace empty bodies of default constructors and destructors with '= default'. http://reviews.llvm.org/D13889 Files: clang-modernize/Core/IncludeDirectives.cpp

Re: [PATCH] D13890: Apply modernize-use-default to clang.

bkramer added a comment. feel free to submit http://reviews.llvm.org/D13890 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D13892: Apply modernize-use-default to compiler-rt.

This revision was automatically updated to reflect the committed changes. Closed by commit rL250823: Apply modernize-use-default to compiler-rt. (authored by angelgarcia). Changed prior to commit: http://reviews.llvm.org/D13892?vs=37868=37869#toc Repository: rL LLVM

Re: [PATCH] D13890: Apply modernize-use-default to clang.

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. Looks good with one comment. Comment at: lib/StaticAnalyzer/Core/MemRegion.cpp:141-143 @@ -140,5 +141,1 @@ -MemRegionManager::~MemRegionManager() { - // All regions and

Re: [PATCH] D13336: [MSVC] 'property' with an empty array in array subscript expression.

ABataev updated this revision to Diff 37854. ABataev added a comment. Update after review http://reviews.llvm.org/D13336 Files: include/clang/AST/ASTContext.h include/clang/AST/BuiltinTypes.def include/clang/Serialization/ASTBitCodes.h lib/AST/ASTContext.cpp lib/AST/Type.cpp

Re: [PATCH] D13871: Add modernize-use-default check to clang-tidy.

klimek accepted this revision. klimek added a comment. This revision is now accepted and ready to land. LG. Yay! Comment at: clang-tidy/modernize/UseDefaultCheck.cpp:59-60 @@ +58,4 @@ + "= default;"); + // FIXME: this can generate a -Wpedantic warning if there is a

[PATCH] D13890: Apply modernize-use-default to clang.

angelgarcia created this revision. angelgarcia added a reviewer: klimek. angelgarcia added subscribers: cfe-commits, alexfh. Herald added a subscriber: klimek. Replace empty bodies of default constructors and destructors with '= default'. http://reviews.llvm.org/D13890 Files:

Re: [PATCH] D13890: Apply modernize-use-default to clang.

klimek added a reviewer: bkramer. klimek added a comment. +benjamin, who has been doing those changes lately... http://reviews.llvm.org/D13890 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D13889: Apply modernize-use-default to clang-tools-extra.

klimek accepted this revision. klimek added a comment. This revision is now accepted and ready to land. LG http://reviews.llvm.org/D13889 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D13892: Apply modernize-use-default to compiler-rt.

angelgarcia created this revision. angelgarcia added a reviewer: klimek. angelgarcia added subscribers: cfe-commits, alexfh. Replace empty bodies of default constructors and destructors with '= default'. http://reviews.llvm.org/D13892 Files: lib/asan/asan_fake_stack.h

Re: [PATCH] D13892: Apply modernize-use-default to compiler-rt.

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg with comments. Comment at: lib/tsan/rtl/tsan_mutex.cc:130 @@ -129,3 @@ -InternalDeadlockDetector::InternalDeadlockDetector() { - // Rely on zero initialization because

Re: [PATCH] D13890: Apply modernize-use-default to clang.

angelgarcia updated this revision to Diff 37867. angelgarcia added a comment. Put comment back. http://reviews.llvm.org/D13890 Files: include/clang/AST/ASTConsumer.h include/clang/AST/CanonicalType.h include/clang/AST/DeclFriend.h include/clang/AST/DeclTemplate.h

[clang-tools-extra] r250824 - Apply modernize-use-default to clang-tools-extra.

Author: angelgarcia Date: Tue Oct 20 07:56:27 2015 New Revision: 250824 URL: http://llvm.org/viewvc/llvm-project?rev=250824=rev Log: Apply modernize-use-default to clang-tools-extra. Summary: Replace empty bodies of default constructors and destructors with '= default'. Reviewers: klimek

Re: r250418 - [CodeGen] Remove dead code. NFC.

Put it back in r250803. Tests very welcome ;) - Benjamin On Tue, Oct 20, 2015 at 9:14 AM, Michael Gottesman via cfe-commits wrote: > Let me play with it a bit (I did not read the code, I just was tracking down > the linkage error). > > Michael > > On Oct 20, 2015, at

r250804 - Revert accidental commit. This isn't ready yet.

Author: d0k Date: Tue Oct 20 02:53:14 2015 New Revision: 250804 URL: http://llvm.org/viewvc/llvm-project?rev=250804=rev Log: Revert accidental commit. This isn't ready yet. Modified: cfe/trunk/lib/Tooling/Core/CMakeLists.txt cfe/trunk/unittests/Tooling/CMakeLists.txt Modified:

Re: [PATCH] D13643: [Sema] Warn on ternary comparison

danielmarjamaki added a subscriber: danielmarjamaki. danielmarjamaki added a comment. Interesting checker. I'll test it on some debian projects. If you're interested.. it does not currently warn about "1.0 < 2.0 < 3.0" as far as I see. http://reviews.llvm.org/D13643

[libcxx] r250802 - Detect relaxed constexpr rules for gcc versions

Author: marshall Date: Tue Oct 20 02:37:11 2015 New Revision: 250802 URL: http://llvm.org/viewvc/llvm-project?rev=250802=rev Log: Detect relaxed constexpr rules for gcc versions Modified: libcxx/trunk/include/__config Modified: libcxx/trunk/include/__config URL:

Re: [ALERT:Possible Phishing] r250418 - [CodeGen] Remove dead code. NFC.

Thanks! Michael > On Oct 20, 2015, at 12:55 AM, Benjamin Kramer wrote: > > Put it back in r250803. Tests very welcome ;) > > - Benjamin > > On Tue, Oct 20, 2015 at 9:14 AM, Michael Gottesman via cfe-commits > wrote: >> Let me play with it a

Re: [PATCH] D13673: Add initial support for the MUSL C library.

vkalintiris added inline comments. Comment at: src/locale.cpp:958 @@ -957,3 +961,3 @@ return static_cast(__classic_lower_table()[static_cast(c)]); -#elif defined(__GLIBC__) || defined(__EMSCRIPTEN__) || defined(__NetBSD__) return isascii(c) ? EricWF

Re: [PATCH] D13336: [MSVC] 'property' with an empty array in array subscript expression.

rjmccall added a comment. Needs more tests. 1. Dependent template instantiation. 2. Non-dependent template instantiation. 3. Indexes which are themselves pseudo-objects. 4. Templated getters and setters. 5. Non-POD by-value argument types. Comment at:

Re: [clang-tools-extra] r250742 - Added check uniqueptr-delete-release to replace "delete x.release()" with "x = nullptr"

On Tue, Oct 20, 2015 at 8:39 AM, Samuel Benzaquen wrote: > > On Mon, Oct 19, 2015 at 6:00 PM, David Blaikie wrote: > >> >> >> On Mon, Oct 19, 2015 at 2:49 PM, Samuel Benzaquen via cfe-commits < >> cfe-commits@lists.llvm.org> wrote: >> >>> Author: sbenza

r250839 - Look through using decls when classifying implicit member access

Author: rnk Date: Tue Oct 20 13:12:08 2015 New Revision: 250839 URL: http://llvm.org/viewvc/llvm-project?rev=250839=rev Log: Look through using decls when classifying implicit member access Clang will now accept this valid C++11 code: struct A { int field; }; struct B : A { using

r250844 - Add back null check removed accidentally in r250554

Author: rnk Date: Tue Oct 20 13:45:57 2015 New Revision: 250844 URL: http://llvm.org/viewvc/llvm-project?rev=250844=rev Log: Add back null check removed accidentally in r250554 Fixes PR25262 Added: cfe/trunk/test/Frontend/force-include-not-found.c Modified:

r250840 - [CMake] Make clang/tools subdirectories controlled via options

Author: cbieneman Date: Tue Oct 20 13:12:12 2015 New Revision: 250840 URL: http://llvm.org/viewvc/llvm-project?rev=250840=rev Log: [CMake] Make clang/tools subdirectories controlled via options Setting CLANG_TOOL_*_BUILD=Off on the CMake command line will disable inclusion of a clang/tools

[PATCH] D13909: clang-offload-bundler - offload files bundling/unbundling tool

sfantao created this revision. sfantao added reviewers: hfinkel, rsmith, echristo, ABataev, chandlerc. sfantao added a subscriber: cfe-commits. One of the goals of programming models that support offloading (e.g. OpenMP) is to enable users to offload with little effort, by annotating the code

Re: r250803 - Put back dead code that's used out-of-tree.

Nevermind, I see this was floated/discussed in the review thread of the original commit ( 250418 ) On Tue, Oct 20, 2015 at 11:46 AM, David Blaikie wrote: > > > On Tue, Oct 20, 2015 at 12:50 AM, Benjamin Kramer via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >>

Re: r250803 - Put back dead code that's used out-of-tree.

On Tue, Oct 20, 2015 at 12:50 AM, Benjamin Kramer via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: d0k > Date: Tue Oct 20 02:50:21 2015 > New Revision: 250803 > > URL: http://llvm.org/viewvc/llvm-project?rev=250803=rev > Log: > Put back dead code that's used out-of-tree. > Might be

r250834 - [CMake] Make external compiler-rt install scripts relative to CMAKE_INSTALL_PREFIX.

Author: cbieneman Date: Tue Oct 20 11:39:25 2015 New Revision: 250834 URL: http://llvm.org/viewvc/llvm-project?rev=250834=rev Log: [CMake] Make external compiler-rt install scripts relative to CMAKE_INSTALL_PREFIX. This change makes LLVM_BUILD_EXTERNAL_COMPILER_RT work correctly when

[PATCH] D13899: Fix bug in suggested fix that truncated variable names to 1 character.

sbenza created this revision. sbenza added reviewers: alexfh, aaron.ballman. sbenza added a subscriber: cfe-commits. Fix bug in suggested fix that truncated variable names to 1 character. Also, rework the suggested fix to try to remove unnecessary whitespace. http://reviews.llvm.org/D13899

Re: [PATCH] D13787: [clang-tidy] add check cppcoreguidelines-pro-type-vararg-use

mgehre updated this revision to Diff 37925. mgehre added a comment. removed __builtin_va_start; change f->foo() to f.foo() http://reviews.llvm.org/D13787 Files: clang-tidy/cppcoreguidelines/CMakeLists.txt clang-tidy/cppcoreguidelines/CppCoreGuidelinesTidyModule.cpp

Re: [PATCH] D13673: Add initial support for the MUSL C library.

EricWF added a comment. Thanks for the update, I think this should be good to go. I'll give it a final once over tonight. Comment at: src/locale.cpp:958 @@ -957,3 +961,3 @@ return static_cast(__classic_lower_table()[static_cast(c)]); -#elif defined(__GLIBC__) ||

Re: [clang-tools-extra] r250824 - Apply modernize-use-default to clang-tools-extra.

On 10/20/2015 11:37 PM, David Blaikie wrote: On Tue, Oct 20, 2015 at 2:24 PM, Tobias Grosser via cfe-commits > wrote: On 10/20/2015 02:56 PM, Angel Garcia Gomez via cfe-commits wrote: Author: angelgarcia Date:

Re: [PATCH] D13787: [clang-tidy] add check cppcoreguidelines-pro-type-vararg-use

sbenza accepted this revision. sbenza added a comment. This revision is now accepted and ready to land. Thanks for check. http://reviews.llvm.org/D13787 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r250854 - [-fms-extensions] Allow missing exception specifications in redeclarations as an extension

Author: majnemer Date: Tue Oct 20 15:49:21 2015 New Revision: 250854 URL: http://llvm.org/viewvc/llvm-project?rev=250854=rev Log: [-fms-extensions] Allow missing exception specifications in redeclarations as an extension Microsoft's ATL headers make use of this MSVC extension, add support for

[PATCH] D13913: Allow linking multiple bitcode files.

tra created this revision. tra added reviewers: echristo, pcc. tra added a subscriber: cfe-commits. This will be used for CUDA where we need to link with vendor-supplied bitcode library and with a bitcode library pretending to be libm for GPUs. Linking options for particular file depend on the

Re: r250577 - [modules] Allow the error when explicitly loading an incompatible module file

On Tue, Oct 20, 2015 at 6:45 AM, Manuel Klimek wrote: > On Tue, Oct 20, 2015 at 3:38 PM Brad King wrote: > >> On 10/20/2015 04:38 AM, Manuel Klimek wrote: >> > On Tue, Oct 20, 2015 at 5:52 AM Sean Silva wrote: >> >> get cmake to generate clang module

[clang-tools-extra] r250862 - Revert "Apply modernize-use-default to clang-tools-extra."

Author: dblaikie Date: Tue Oct 20 16:45:52 2015 New Revision: 250862 URL: http://llvm.org/viewvc/llvm-project?rev=250862=rev Log: Revert "Apply modernize-use-default to clang-tools-extra." Breaks the build in GCC 4.7.2 (see http://lab.llvm.org:8011/builders/perf-x86_64-penryn-O3 for example)

Re: [clang-tools-extra] r250824 - Apply modernize-use-default to clang-tools-extra.

Reverted in r250862 On Tue, Oct 20, 2015 at 2:39 PM, Tobias Grosser wrote: > On 10/20/2015 11:37 PM, David Blaikie wrote: > >> >> >> On Tue, Oct 20, 2015 at 2:24 PM, Tobias Grosser via cfe-commits >> > wrote: >>

Re: [PATCH] D13171: [CUDA] Added a wrapper header for inclusion of stock CUDA headers.

tra updated this revision to Diff 37912. tra added a comment. Herald added a subscriber: klimek. Changed header wrapping strategy. Previous version was attempting to make CUDA headers work for host/device compilations separately. In the end host and device compilations ended up with different

Re: [PATCH] D13787: [clang-tidy] add check cppcoreguidelines-pro-type-vararg-use

sbenza added a comment. Minor comments only. Comment at: clang-tidy/cppcoreguidelines/ProTypeVarargCheck.cpp:29 @@ +28,3 @@ + callExpr(callee(functionDecl(isVariadic(), + unless(hasName("__builtin_va_start") +

Re: [clang-tools-extra] r250824 - Apply modernize-use-default to clang-tools-extra.

On Tue, Oct 20, 2015 at 2:24 PM, Tobias Grosser via cfe-commits < cfe-commits@lists.llvm.org> wrote: > On 10/20/2015 02:56 PM, Angel Garcia Gomez via cfe-commits wrote: > >> Author: angelgarcia >> Date: Tue Oct 20 07:56:27 2015 >> New Revision: 250824 >> >> URL:

r250856 - Re-land r250592 without rejecting field refs in unevaluated contexts

Author: rnk Date: Tue Oct 20 16:04:13 2015 New Revision: 250856 URL: http://llvm.org/viewvc/llvm-project?rev=250856=rev Log: Re-land r250592 without rejecting field refs in unevaluated contexts This time, I went with the first approach from http://reviews.llvm.org/D6700, where clang actually

Re: [clang-tools-extra] r250824 - Apply modernize-use-default to clang-tools-extra.

On 10/20/2015 02:56 PM, Angel Garcia Gomez via cfe-commits wrote: Author: angelgarcia Date: Tue Oct 20 07:56:27 2015 New Revision: 250824 URL: http://llvm.org/viewvc/llvm-project?rev=250824=rev Log: Apply modernize-use-default to clang-tools-extra. Summary: Replace empty bodies of default

Re: [PATCH] D13263: Addition of __attribute__((pass_object_size)) to Clang

george.burgess.iv updated this revision to Diff 37935. george.burgess.iv added a comment. Rebased http://reviews.llvm.org/D13263 Files: include/clang/AST/Expr.h include/clang/AST/Type.h include/clang/Basic/Attr.td include/clang/Basic/AttrDocs.td

Re: [PATCH] D13787: [clang-tidy] add check cppcoreguidelines-pro-type-vararg-use

mgehre added a comment. Thanks for the good review! Comment at: clang-tidy/cppcoreguidelines/ProTypeVarargCheck.cpp:26 @@ +25,3 @@ + Finder->addMatcher( + varDecl(hasType(pointsTo(cxxRecordDecl(hasName("__va_list_tag") + .bind("va_list"),

r250866 - Revert r247977, "clang/test/lit.cfg: *-ps4 doesn't have appropriate driver yet. Mark it as "non-clang-driver"."

Author: chapuni Date: Tue Oct 20 17:36:16 2015 New Revision: 250866 URL: http://llvm.org/viewvc/llvm-project?rev=250866=rev Log: Revert r247977, "clang/test/lit.cfg: *-ps4 doesn't have appropriate driver yet. Mark it as "non-clang-driver"." They, "tests requiring clang-driver", should work in

[PATCH] D13897: [AST] Put TypeLocs and NestedNameSpecifierLocs into the ParentMap.

bkramer created this revision. bkramer added reviewers: klimek, sbenza. bkramer added a subscriber: cfe-commits. Herald added a subscriber: klimek. Firstly this changes the type of parent map to be keyed on DynTypedNode to simplify the following changes. This comes with a DenseMapInfo for

r250831 - [AST] Put TypeLocs and NestedNameSpecifierLocs into the ParentMap.

Author: d0k Date: Tue Oct 20 10:08:46 2015 New Revision: 250831 URL: http://llvm.org/viewvc/llvm-project?rev=250831=rev Log: [AST] Put TypeLocs and NestedNameSpecifierLocs into the ParentMap. Firstly this changes the type of parent map to be keyed on DynTypedNode to simplify the following

Re: [PATCH] D13897: [AST] Put TypeLocs and NestedNameSpecifierLocs into the ParentMap.

klimek accepted this revision. klimek added a comment. This revision is now accepted and ready to land. Yay, another yak shaved \o/ http://reviews.llvm.org/D13897 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D13640: [clang-tidy] Add new check cppcoreguidelines-pro-bounds-array-to-pointer-decay

aaron.ballman added inline comments. Comment at: test/clang-tidy/cppcoreguidelines-pro-bounds-array-to-pointer-decay.cpp:13 @@ +12,3 @@ + +void pointerfun(int* p); +void arrayfun(int p[]); > Currently, the diag is > ``` > diag(MatchedCast->getExprLoc(), "do not

[PATCH] D13925: Implement __attribute__((internal_linkage))

eugenis created this revision. eugenis added a reviewer: rsmith. eugenis added subscribers: cfe-commits, EricWF, rnk. eugenis set the repository for this revision to rL LLVM. The attrubite is applicable to functions and variables and changes the linkage of the subject to internal. Following the

Re: [PATCH] D12906: [RFC] Bug identification("issue_hash") change for CmpRuns.py

zaks.anna added a comment. Should this be closed? http://reviews.llvm.org/D12906 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [clang-tools-extra] r250824 - Apply modernize-use-default to clang-tools-extra.

Sorry, I have just seen all this. Thank you for reverting it, David. On Tue, Oct 20, 2015 at 11:48 PM, David Blaikie wrote: > Reverted in r250862 > > On Tue, Oct 20, 2015 at 2:39 PM, Tobias Grosser wrote: > >> On 10/20/2015 11:37 PM, David Blaikie wrote:

Re: [PATCH] D12358: [Analyzer] Widening loops which do not exit

dcoughlin added a comment. Hi Sean, Sorry it took me so long to get back to you. Comment at: include/clang/StaticAnalyzer/Core/AnalyzerOptions.h:266 @@ +265,3 @@ + /// \sa shouldWidenLoops + bool WidenLoops; + Is this field used? Comment

Re: [PATCH] D13925: Implement __attribute__((internal_linkage))

majnemer added a subscriber: majnemer. Comment at: include/clang/Basic/Attr.td:2114 @@ +2113,3 @@ + let Spellings = [GCC<"internal_linkage">]; + let Subjects = SubjectList<[Function,Var]>; + let Documentation = [InternalLinkageDocs]; Space between `Function`

Re: [PATCH] D13704: [Fix] Allow implicit conversions of the address of overloadable functions in C + docs update

george.burgess.iv updated this revision to Diff 37965. george.burgess.iv added a comment. Rebased http://reviews.llvm.org/D13704 Files: include/clang/Basic/AttrDocs.td lib/Sema/SemaOverload.cpp test/CodeGen/overloadable.c test/Sema/overloadable.c Index: test/Sema/overloadable.c

r250876 - Use ArrayRef and MutableArrayRef instead of a pointer and size. NFC

Author: ctopper Date: Tue Oct 20 21:34:10 2015 New Revision: 250876 URL: http://llvm.org/viewvc/llvm-project?rev=250876=rev Log: Use ArrayRef and MutableArrayRef instead of a pointer and size. NFC Modified: cfe/trunk/include/clang/Basic/TargetInfo.h cfe/trunk/lib/Basic/TargetInfo.cpp

Re: [PATCH] D13925: Implement __attribute__((internal_linkage))

eugenis added inline comments. Comment at: lib/Sema/SemaDeclAttr.cpp:1580-1585 @@ -1577,3 +1579,8 @@ + + if (InternalLinkageAttr *Internal = D->getAttr()) { +S.Diag(Attr.getRange().getBegin(), diag::warn_attribute_ignored) +<< Attr.getName(); +

Re: [PATCH] D13643: [Sema] Warn on ternary comparison

danielmarjamaki added a comment. I tested this on 2199 debian projects.. and got 16 warnings. ftp://ftp.se.debian.org/debian/pool/main/t/tf5/tf5_5.0beta8.orig.tar.gz expr.c:738:22: warning: comparisons such as 'a < b != c' do not have their mathematical meaning [-Wparentheses] if

[PATCH] D13928: [CodeGen] Attach function attributes to Objective-c and OpenMP functions.

ahatanak created this revision. ahatanak added reviewers: dexonsmith, echristo. ahatanak added a subscriber: cfe-commits. Another patch which fixes a bug in clang where it creates a function but doesn't attach function attributes to it. http://reviews.llvm.org/D13928 Files:

r250880 - Use std::find instead of a manual loop.

Author: ctopper Date: Tue Oct 20 23:52:38 2015 New Revision: 250880 URL: http://llvm.org/viewvc/llvm-project?rev=250880=rev Log: Use std::find instead of a manual loop. Modified: cfe/trunk/lib/Basic/TargetInfo.cpp Modified: cfe/trunk/lib/Basic/TargetInfo.cpp URL:

r250881 - Use range-based for loops. NFC.

Author: ctopper Date: Tue Oct 20 23:52:40 2015 New Revision: 250881 URL: http://llvm.org/viewvc/llvm-project?rev=250881=rev Log: Use range-based for loops. NFC. Modified: cfe/trunk/lib/Basic/TargetInfo.cpp Modified: cfe/trunk/lib/Basic/TargetInfo.cpp URL:

r250878 - Fix bad indentation.

Author: ctopper Date: Tue Oct 20 23:52:34 2015 New Revision: 250878 URL: http://llvm.org/viewvc/llvm-project?rev=250878=rev Log: Fix bad indentation. Modified: cfe/trunk/lib/Basic/TargetInfo.cpp Modified: cfe/trunk/lib/Basic/TargetInfo.cpp URL:

r250879 - Parse into an unsigned type instead of a signed type and then checking for positive and casting to unsigned. Since we know the string starts with a digit it couldn't be negative anyway. NFCI

Author: ctopper Date: Tue Oct 20 23:52:36 2015 New Revision: 250879 URL: http://llvm.org/viewvc/llvm-project?rev=250879=rev Log: Parse into an unsigned type instead of a signed type and then checking for positive and casting to unsigned. Since we know the string starts with a digit it couldn't

Re: [PATCH] D13731: [RFC][Analyzer] Supporting function attributes in .model files.

zaks.anna added inline comments. Comment at: lib/Analysis/BodyFarm.h:43 @@ +42,3 @@ + /// \brief Merge the attributes found in model files. + /// Note, this adds all attributes found in the model file without any sanity + /// checks. Why do we not have sanity

[PATCH] D13893: Roll-back r250822.

angelgarcia created this revision. angelgarcia added a subscriber: cfe-commits. Herald added a subscriber: klimek. It breaks the build for the ASTMatchers http://reviews.llvm.org/D13893 Files: include/clang/AST/ASTConsumer.h include/clang/AST/CanonicalType.h include/clang/AST/DeclFriend.h

Re: [PATCH] D13893: Roll-back r250822.

This revision was automatically updated to reflect the committed changes. Closed by commit rL250827: Roll-back r250822. (authored by angelgarcia). Changed prior to commit: http://reviews.llvm.org/D13893?vs=37875=37878#toc Repository: rL LLVM http://reviews.llvm.org/D13893 Files:

Re: r250577 - [modules] Allow the error when explicitly loading an incompatible module file

On 10/20/2015 04:38 AM, Manuel Klimek wrote: > On Tue, Oct 20, 2015 at 5:52 AM Sean Silva wrote: >> get cmake to generate clang module map files and add explicit module build >> steps? > > I have some experience hacking on cmake, and from my experience I think > this shouldn't be too hard to get

Re: r250577 - [modules] Allow the error when explicitly loading an incompatible module file

On Tue, Oct 20, 2015 at 3:38 PM Brad King wrote: > On 10/20/2015 04:38 AM, Manuel Klimek wrote: > > On Tue, Oct 20, 2015 at 5:52 AM Sean Silva wrote: > >> get cmake to generate clang module map files and add explicit module > build steps? > > > > I have some experience