Re: [PATCH] D13802: [OPENMP] Make -fopenmp to turn on OpenMP support by default.

ABataev added reviewers: hans, tstellarAMD. ABataev updated this revision to Diff 38374. ABataev marked an inline comment as done. http://reviews.llvm.org/D13802 Files: autoconf/configure.ac configure docs/GettingStarted.rst docs/ReleaseProcess.rst utils/release/test-release.sh Index:

[clang-tools-extra] r251279 - Drop dead return after llvm_unreachable. NFC.

Author: d0k Date: Mon Oct 26 04:57:00 2015 New Revision: 251279 URL: http://llvm.org/viewvc/llvm-project?rev=251279=rev Log: Drop dead return after llvm_unreachable. NFC. Modified: clang-tools-extra/trunk/clang-tidy/readability/ImplicitBoolCastCheck.cpp Modified:

Re: [PATCH] D14052: clang-format: Format std::function template parameter consistently inside function

djasper added a comment. I'll take a look. I agree that there should be a better approach. Also, you seem to have created the inverse patch :-). http://reviews.llvm.org/D14052 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D13802: [OPENMP] Make -fopenmp to turn on OpenMP support by default.

ABataev marked an inline comment as done. ABataev added a comment. Hi Chandler, thanks for the review. In http://reviews.llvm.org/D13802#272053, @chandlerc wrote: > Some minor issues below. Also, Hans and Tom should have a glance at the > release bits of this, I don't know any of that stuff. >

Re: [PATCH] D9898: MismatchingNewDeleteDetector uses incorrect field, and finds no initializer

This revision was automatically updated to reflect the committed changes. Closed by commit rL251335: MismatchingNewDeleteDetector uses incorrect field, and finds no initializer (authored by ismailp). Changed prior to commit: http://reviews.llvm.org/D9898?vs=26271=38449#toc Repository: rL

Re: r251335 - MismatchingNewDeleteDetector uses incorrect field, and finds no initializer

Hi, this patch addresses a crash-on-valid on 3.7. Could you please merge this to 3.7 branch? Ismail On Mon, Oct 26, 2015 at 8:20 PM, Ismail Pazarbasi via cfe-commits wrote: > Author: ismailp > Date: Mon Oct 26 14:20:24 2015 > New Revision: 251335 > > URL:

Re: [PATCH] D12382: Extend linux header search to find libc++ headers in c++/vN for any N.

jroelofs added a comment. LGTM Comment at: lib/Driver/ToolChains.cpp:3545 @@ +3544,3 @@ +!VersionText.slice(1, StringRef::npos).getAsInteger(10, Version)) { + if (Version > MaxVersion) { +MaxVersion = Version; Since you've got logic here to

Re: [PATCH] D13640: [clang-tidy] Add new check cppcoreguidelines-pro-bounds-array-to-pointer-decay

This revision was automatically updated to reflect the committed changes. Closed by commit rL251358: [clang-tidy] Add new check cppcoreguidelines-pro-bounds-array-to-pointer-decay (authored by mgehre). Changed prior to commit: http://reviews.llvm.org/D13640?vs=38353=38467#toc Repository: rL

Re: [PATCH] D14049: clang-tidy/add_new_check.py: Adapt to use %check_clang_tidy in tests

This revision was automatically updated to reflect the committed changes. Closed by commit rL251355: clang-tidy/add_new_check.py: Adapt to use %check_clang_tidy in tests (authored by mgehre). Changed prior to commit: http://reviews.llvm.org/D14049?vs=38354=38466#toc Repository: rL LLVM

[clang-tools-extra] r251355 - clang-tidy/add_new_check.py: Adapt to use %check_clang_tidy in tests

Author: mgehre Date: Mon Oct 26 16:48:08 2015 New Revision: 251355 URL: http://llvm.org/viewvc/llvm-project?rev=251355=rev Log: clang-tidy/add_new_check.py: Adapt to use %check_clang_tidy in tests Summary: Adapt clang-tidy/add_new_check.py according to commit r251010 "Add %check_clang_tidy and

[libcxx] r251334 - Fix test suite configuration. Sorry Marshall

Author: ericwf Date: Mon Oct 26 14:08:53 2015 New Revision: 251334 URL: http://llvm.org/viewvc/llvm-project?rev=251334=rev Log: Fix test suite configuration. Sorry Marshall Modified: libcxx/trunk/test/libcxx/test/config.py Modified: libcxx/trunk/test/libcxx/test/config.py URL:

Re: [PATCH] D13969: Tweak how -Wunused-value interacts with macros

thakis added a reviewer: rnk. thakis added a comment. rnk: Can you look at this if Richard is still away doing committee thing? http://reviews.llvm.org/D13969 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D13336: [MSVC] 'property' with an empty array in array subscript expression.

rjmccall added inline comments. Comment at: include/clang/AST/ExprCXX.h:689 @@ +688,3 @@ +/// indices. In this case, i=p->x[a][b] will be turned into i=p->GetX(a, b), and +/// p->x[a][b] = i will be turned into p->PutX(a, b, i). +class MSPropertySubscriptExpr : public Expr {

[clang-tools-extra] r251358 - [clang-tidy] Add new check cppcoreguidelines-pro-bounds-array-to-pointer-decay

Author: mgehre Date: Mon Oct 26 16:56:02 2015 New Revision: 251358 URL: http://llvm.org/viewvc/llvm-project?rev=251358=rev Log: [clang-tidy] Add new check cppcoreguidelines-pro-bounds-array-to-pointer-decay Summary: This check flags all array to pointer decays. Pointers should not be used as

[PATCH] D14096: [clang-tidy] add new check cppcoreguidelines-pro-type-cstyle-cast

mgehre created this revision. mgehre added reviewers: alexfh, sbenza, bkramer, aaron.ballman. mgehre added a subscriber: cfe-commits. This check flags all use of c-style casts that perform a static_cast downcast, const_cast, or reinterpret_cast. Use of these casts can violate type safety and

Re: r251371 - Use early exits to reduce indentation.

On Mon, Oct 26, 2015 at 5:06 PM, Eric Christopher via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: echristo > Date: Mon Oct 26 19:06:21 2015 > New Revision: 251371 > > URL: http://llvm.org/viewvc/llvm-project?rev=251371=rev > Log: > Use early exits to reduce indentation. > >

Re: [PATCH] D12382: Extend linux header search to find libc++ headers in c++/vN for any N.

eugenis added a comment. ping We will need this when libc++ is bumped to v2. There are no plans to do this AFAIK but the ABI version macros are in so it is possible and clang should be ready. http://reviews.llvm.org/D12382 ___ cfe-commits mailing

r251335 - MismatchingNewDeleteDetector uses incorrect field, and finds no initializer

Author: ismailp Date: Mon Oct 26 14:20:24 2015 New Revision: 251335 URL: http://llvm.org/viewvc/llvm-project?rev=251335=rev Log: MismatchingNewDeleteDetector uses incorrect field, and finds no initializer Summary: In `MismatchingNewDeleteDetector::analyzeInClassInitializer`, if `Field`'s

Re: [PATCH] D7639: Add readability-redundant-void-arg check to clang-tidy

sbenza added a comment. Just fyi, I am looking at this diff. It is very large with a lot of rounds of comments and I didn't have the context. I don't know if I should giving comments at this point of the change, but here it is. Have you considered matching on typeLoc() instead of having a large

r251371 - Use early exits to reduce indentation.

Author: echristo Date: Mon Oct 26 19:06:21 2015 New Revision: 251371 URL: http://llvm.org/viewvc/llvm-project?rev=251371=rev Log: Use early exits to reduce indentation. Modified: cfe/trunk/lib/CodeGen/CGBuiltin.cpp Modified: cfe/trunk/lib/CodeGen/CGBuiltin.cpp URL:

Re: [PATCH] D14096: [clang-tidy] add new check cppcoreguidelines-pro-type-cstyle-cast

sbenza added inline comments. Comment at: clang-tidy/cppcoreguidelines/ProTypeCstyleCastCheck.cpp:44 @@ +43,3 @@ + if (MatchedCast->getCastKind() == CK_BitCast || + MatchedCast->getCastKind() == CK_LValueBitCast || + MatchedCast->getCastKind() == CK_IntegralToPointer

Re: r251371 - Use early exits to reduce indentation.

On Mon, Oct 26, 2015 at 5:11 PM David Blaikie wrote: > On Mon, Oct 26, 2015 at 5:06 PM, Eric Christopher via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> Author: echristo >> Date: Mon Oct 26 19:06:21 2015 >> New Revision: 251371 >> >> URL:

Re: r251284 - clang-format: Fix false positive in cast detection.

On Mon, Oct 26, 2015 at 9:43 PM, Daniel Jasper wrote: > If you look closely, there are multiple tests for different configuration > options. > Ah, I see one that's "( int, int )" now - cool, thanks! > The before/after is always just one example. > > On Tue, Oct 27, 2015 at

r251384 - Be more conservative about diagnosing "incorrect" uses of __weak:

Author: rjmccall Date: Mon Oct 26 23:54:50 2015 New Revision: 251384 URL: http://llvm.org/viewvc/llvm-project?rev=251384=rev Log: Be more conservative about diagnosing "incorrect" uses of __weak: allow them to be written in certain kinds of user declaration and diagnose on the use-site instead.

r251385 - Create undef reference to profile hook symbol

Author: davidxl Date: Tue Oct 27 00:15:35 2015 New Revision: 251385 URL: http://llvm.org/viewvc/llvm-project?rev=251385=rev Log: Create undef reference to profile hook symbol Create undef reference to profile hook symbol when PGO instrumentation is turned on. This allows LLVM to omit emission

Re: r251284 - clang-format: Fix false positive in cast detection.

I mixed up before and after. Other than that, I don't see a typo. On Mon, Oct 26, 2015 at 5:44 PM, David Blaikie wrote: > > > On Mon, Oct 26, 2015 at 5:08 AM, Daniel Jasper via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> Author: djasper >> Date: Mon Oct 26

Re: [PATCH] D12922: Add support for function attribute "notail"

ping On Mon, Oct 19, 2015 at 5:59 PM, Akira Hatanaka wrote: > ahatanak updated this revision to Diff 37816. > ahatanak added a comment. > > Address review comments: > > 1. Renamed the attribute to "not_tail_called". > > I chose "not_tail_called" over "notailcall" or "notail"

[PATCH] D14104: clang-format: Add an additional value to AlignAfterOpenBracket: AlwaysBreak.

djasper created this revision. djasper added a reviewer: klimek. djasper added a subscriber: cfe-commits. Herald added a subscriber: klimek. If this option is set, clang-format will always insert a line wrap, e.g. before the first parameter of a function call unless all parameters fit on the same

[PATCH] D14105: clang-format: When a line is formatted, also format subsequence lines if their indent is off.

djasper created this revision. djasper added a reviewer: klimek. djasper added a subscriber: cfe-commits. Herald added a subscriber: klimek. This is especially important so that if a change is solely inserting a block around a few statements, clang-format-diff.py will still clean up and add

Re: r251284 - clang-format: Fix false positive in cast detection.

If you look closely, there are multiple tests for different configuration options. The before/after is always just one example. On Tue, Oct 27, 2015 at 5:42 AM, David Blaikie wrote: > > > On Mon, Oct 26, 2015 at 9:21 PM, Daniel Jasper wrote: > >> I mixed

Re: r251284 - clang-format: Fix false positive in cast detection.

On Mon, Oct 26, 2015 at 9:21 PM, Daniel Jasper wrote: > I mixed up before and after. Other than that, I don't see a typo. > It looks like the test case "+ verifyFormat("std::function< void(int, int) > fct;", Spaces);" ensures no spaces between the parameters and the () in

Re: [PATCH] D12906: [RFC] Bug identification("issue_hash") change for CmpRuns.py

o.gyorgy added a comment. Hi, You are right the diff is is based on the hash. We already tried to use an earlier hash generator (before the patch was introduced), which generates a slightly different plist, that is why the current version does not work with the patch. We will fix CodeChecker to

Porting Clang to a new architecture

Hi: Where I'm working I've been asked to look into developing a C (by this I mean C89 C standard) compiler a new processor architecture being created inhouse. On looking at the options and brushing up on compiler theory, I came up with Flex/Bison, Writing the compiler from scratch or use Clang.

r251289 - [analyzer] Fixed a rare crash when analyzing lambda functions.

Author: xazax Date: Mon Oct 26 08:32:26 2015 New Revision: 251289 URL: http://llvm.org/viewvc/llvm-project?rev=251289=rev Log: [analyzer] Fixed a rare crash when analyzing lambda functions. Modified: cfe/trunk/lib/StaticAnalyzer/Core/MemRegion.cpp Modified:

Re: Getting fully qualified names of random qualtypes

Some high level style comments: 1. Please convert the file to LLVM style for the things that clang-format doesn't change. In particular PascalCase for all variables and cameCase for all function names. 2. We don't do author attribution in file comments, sorry. 3. Try to avoid commented out/#if

r251284 - clang-format: Fix false positive in cast detection.

Author: djasper Date: Mon Oct 26 07:08:47 2015 New Revision: 251284 URL: http://llvm.org/viewvc/llvm-project?rev=251284=rev Log: clang-format: Fix false positive in cast detection. Before (with spaces in parentheses): void inFunction() { std::function fct; } After: void

Re: Porting Clang to a new architecture

Great. So this is what I wanted to know. I think understand what you are saying. You are saying that most of the work that I would need to do from the AST (I'm assuming that this stands from Abstract Syntax Tree) is allready being done by LLVM and I should look to modify for a my new

Re: [PATCH] D14030: Use linker option to reference profile runtime hook (Linux)

vsk added a comment. This looks good to me. Does this mean we will get rid of `getInstrProfRuntimeHookVarUseFuncName`? http://reviews.llvm.org/D14030 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D14030: Use linker option to reference profile runtime hook (Linux)

On Mon, Oct 26, 2015 at 8:44 AM, Vedant Kumar wrote: > vsk added a comment. > > This looks good to me. Does this mean we will get rid of > `getInstrProfRuntimeHookVarUseFuncName`? > not yet -- note that this is only enabled for Linux toolchain only for now. If it works for all

Re: [PATCH] D14014: Checker of proper vfork usage

ygribov marked 43 inline comments as done. ygribov added a comment. http://reviews.llvm.org/D14014 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D13802: [OPENMP] Make -fopenmp to turn on OpenMP support by default.

hans added a comment. The release script change looks good to me. Better than good actually; it's a great improvement :-) http://reviews.llvm.org/D13802 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r251313 - [analyzer] Added a missing test case for r251289.

Author: xazax Date: Mon Oct 26 12:42:14 2015 New Revision: 251313 URL: http://llvm.org/viewvc/llvm-project?rev=251313=rev Log: [analyzer] Added a missing test case for r251289. Modified: cfe/trunk/test/Analysis/lambdas.cpp Modified: cfe/trunk/test/Analysis/lambdas.cpp URL:

Re: r251289 - [analyzer] Fixed a rare crash when analyzing lambda functions.

Added missing testcase in r251313. On 26 October 2015 at 17:45, David Blaikie wrote: > > > On Mon, Oct 26, 2015 at 6:32 AM, Gabor Horvath via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> Author: xazax >> Date: Mon Oct 26 08:32:26 2015 >> New Revision: 251289 >> >>

Re: [PATCH] D12358: [Analyzer] Widening loops which do not exit

seaneveson marked an inline comment as done. seaneveson added a comment. Hi Devin, Sorry it also took me so long to get back to you. Comment at: include/clang/StaticAnalyzer/Core/AnalyzerOptions.h:266 @@ +265,3 @@ + /// \sa shouldWidenLoops + bool WidenLoops; +

Re: r251284 - clang-format: Fix false positive in cast detection.

On Mon, Oct 26, 2015 at 5:08 AM, Daniel Jasper via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: djasper > Date: Mon Oct 26 07:08:47 2015 > New Revision: 251284 > > URL: http://llvm.org/viewvc/llvm-project?rev=251284=rev > Log: > clang-format: Fix false positive in cast detection. >

Re: r251289 - [analyzer] Fixed a rare crash when analyzing lambda functions.

On Mon, Oct 26, 2015 at 6:32 AM, Gabor Horvath via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: xazax > Date: Mon Oct 26 08:32:26 2015 > New Revision: 251289 > > URL: http://llvm.org/viewvc/llvm-project?rev=251289=rev > Log: > [analyzer] Fixed a rare crash when analyzing lambda

Re: r251289 - [analyzer] Fixed a rare crash when analyzing lambda functions.

On 26 October 2015 at 17:45, David Blaikie wrote: > > > On Mon, Oct 26, 2015 at 6:32 AM, Gabor Horvath via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> Author: xazax >> Date: Mon Oct 26 08:32:26 2015 >> New Revision: 251289 >> >> URL:

r251312 - [analyzer] ccc-analyzer: Fix -isystem value passing.

Author: dcoughlin Date: Mon Oct 26 12:19:51 2015 New Revision: 251312 URL: http://llvm.org/viewvc/llvm-project?rev=251312=rev Log: [analyzer] ccc-analyzer: Fix -isystem value passing. The regex for -isystem matching is broken. -[D,I,Usystem] matches "-D", "-,", "-I", "-U", "-s" "-y", etc.

Re: [PATCH] D13800: ccc-analyzer: Fix -isystem value passing

This revision was automatically updated to reflect the committed changes. Closed by commit rL251312: [analyzer] ccc-analyzer: Fix -isystem value passing. (authored by dcoughlin). Changed prior to commit: http://reviews.llvm.org/D13800?vs=37567=38433#toc Repository: rL LLVM

Re: [PATCH] D13640: [clang-tidy] Add new check cppcoreguidelines-pro-bounds-array-to-pointer-decay

sbenza accepted this revision. sbenza added a comment. This revision is now accepted and ready to land. Just one formatting comment. Comment at: clang-tidy/cppcoreguidelines/ProBoundsArrayToPointerDecayCheck.cpp:52 @@ +51,3 @@ + + diag(MatchedCast->getExprLoc(), "do not

Re: [PATCH] D13731: [RFC][Analyzer] Supporting function attributes in .model files.

pgousseau updated this revision to Diff 38438. pgousseau added a comment. Following Anna's review: Remove unnecessary AST walk over declarations by reusing already captured declarations. Add handling of merge conflicts using Sema merge methods. Add condition at the end of