[PATCH] D14215: Disable frame pointer elimination when using -pg

sisnkemp created this revision. sisnkemp added a subscriber: cfe-commits. When using -pg in combination with optimizations (e.g. -O3), compiled programs crash in the profiling routine mcount(). This is because mcount (on x86_64 at least) relies on the frame pointer to be valid. See test case to

Re: [PATCH] D14205: [x86] Front-end part of MCU psABI support

mkuper accepted this revision. mkuper added a comment. This revision is now accepted and ready to land. LGTM Comment at: lib/Basic/Targets.cpp:2327 @@ -2325,3 +2326,3 @@ // X87 evaluates with 80 bits "long double" precision. return SSELevel == NoSSE ? 2 : 0; }

Re: r251738 - [MSVC Compat] Permit conversions from pointer-to-function to pointer-to-object iff -fms-compatibility

On Sat, Oct 31, 2015 at 5:50 PM, Nico Weber via cfe-commits < cfe-commits@lists.llvm.org> wrote: > I think we more commonly say "function pointer": > > $ grep 'pointer-to-function' include/clang/Basic/Diagnostic*td | wc -l >3 > $ grep 'function pointer' include/clang/Basic/Diagnostic*td |

Re: r251738 - [MSVC Compat] Permit conversions from pointer-to-function to pointer-to-object iff -fms-compatibility

On Sun, Nov 1, 2015 at 12:01 AM, James Dennett wrote: > On Sat, Oct 31, 2015 at 5:50 PM, Nico Weber via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> I think we more commonly say "function pointer": >> >> $ grep 'pointer-to-function'

Re: [PATCH] D13973: CFG: Delay creating Dtors for CompoundStmts which end in ReturnStmt

klimek added inline comments. Comment at: lib/Analysis/CFG.cpp:1949-1952 @@ +1948,6 @@ + } + if(!C->body_empty() && !dyn_cast(*C->body_rbegin())) { +// If the body ends with a ReturnStmt, the dtors will be added in VisitReturnStmt +addAutomaticObjDtors(ScopePos,

Re: [PATCH] D13854: Template class: emit better diagnostic in case of missing template argument list

davide added a comment. Gentle ping. Repository: rL LLVM http://reviews.llvm.org/D13854 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: r250577 - [modules] Allow the error when explicitly loading an incompatible module file

On Fri, Oct 23, 2015 at 9:31 PM Sean Silva wrote: > On Tue, Oct 20, 2015 at 1:52 AM, Manuel Klimek wrote: > >> On Tue, Oct 20, 2015 at 10:41 AM Sean Silva >> wrote: >> >>> On Tue, Oct 20, 2015 at 1:38 AM, Manuel Klimek

Re: [PATCH] D14145: modernize-use-default supports copy constructor and copy-assignment operator.

klimek accepted this revision. klimek added a comment. This revision is now accepted and ready to land. lg http://reviews.llvm.org/D14145 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D5767: Template Instantiation Observer + a few other templight-related changes

klimek added a subscriber: klimek. klimek added a comment. Is this still the most current patch out there? http://reviews.llvm.org/D5767 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D14096: [clang-tidy] add new check cppcoreguidelines-pro-type-cstyle-cast

On Tue, Oct 27, 2015 at 06:10:26PM +, Samuel Benzaquen via cfe-commits wrote: > sbenza added a comment. > > In http://reviews.llvm.org/D14096#275902, @xazax.hun wrote: > > > There is already a similar check in the Google package. What are the > > differences between those two checks? What

Re: [PATCH] D13643: [Sema] Warn on ternary comparison

aaron.ballman added a comment. Mostly looks good; the only thing left is a test to ensure the fixits are placing the parens in the expected location. Comment at: lib/Sema/SemaChecking.cpp:6725 @@ -6706,1 +6724,3 @@ static void AnalyzeComparison(Sema , BinaryOperator *E) { +

Re: [PATCH] D14096: [clang-tidy] add new check cppcoreguidelines-pro-type-cstyle-cast

On Sun, Nov 1, 2015 at 2:31 PM, Joerg Sonnenberger via cfe-commits wrote: > On Tue, Oct 27, 2015 at 06:10:26PM +, Samuel Benzaquen via cfe-commits > wrote: >> sbenza added a comment. >> >> In http://reviews.llvm.org/D14096#275902, @xazax.hun wrote: >> >> > There

r251691 - Update debug-info-scope test to remove "FIXME", which is fixed in r251689

Author: dehao Date: Fri Oct 30 00:08:43 2015 New Revision: 251691 URL: http://llvm.org/viewvc/llvm-project?rev=251691=rev Log: Update debug-info-scope test to remove "FIXME", which is fixed in r251689 Modified: cfe/trunk/test/CodeGen/debug-info-scope.c Modified:

Re: [PATCH] D14149: __builtin_signbit fix for ppcf128 type

abeserminji updated this revision to Diff 38795. abeserminji added a comment. Modified comments as suggested by @rjmccall Repository: rL LLVM http://reviews.llvm.org/D14149 Files: lib/CodeGen/CGBuiltin.cpp test/Analysis/builtin_signbit.cpp Index: test/Analysis/builtin_signbit.cpp

Re: [PATCH] D10802: [mips] Interrupt attribute support.

aaron.ballman requested changes to this revision. aaron.ballman added a comment. This revision now requires changes to proceed. This is coming along nicely! There are some minor nits that should be trivial to fix, but the fatal errors need to become semantic errors, and some tests are missing.

Re: [PATCH] D12922: Add support for function attribute "notail"

aaron.ballman added inline comments. Comment at: lib/Sema/SemaDecl.cpp:5374 @@ +5373,3 @@ + + // Virtual functions cannot be marked as 'notail'. + if (auto *Attr = ND.getAttr()) Is there a reason this is here instead of SemaDeclAttr.cpp? It seems like the decl

Re: [PATCH] D14096: [clang-tidy] add new check cppcoreguidelines-pro-type-cstyle-cast

aaron.ballman added inline comments. Comment at: clang-tidy/cppcoreguidelines/ProTypeCstyleCastCheck.cpp:49 @@ +48,3 @@ +diag(MatchedCast->getLocStart(), + "do not use c-style cast to convert between unrelated types"); +return; "C-style" instead

Re: Porting Clang to a new architecture

Ariel Arelovich via cfe-commits writes: > Great. > > So this is what I wanted to know. I think understand what you are saying. > You are saying that most of the work that I would need to do from the AST > (I'm assuming that this stands from Abstract Syntax Tree) is

Re: [PATCH] D13844: [libclang] Visit TypeAliasTemplateDecl

bkramer accepted this revision. bkramer added a comment. Looks good to me too, do you have commit access? http://reviews.llvm.org/D13844 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [libcxx] r249929 - Split out of .

Thanks, Richard! Just to confirm, the test is passing now. Michael > On Oct 29, 2015, at 5:22 PM, Richard Smith wrote: > > I reverted this change in r251665, and started a new thread for the patch to > reinstate this and fix the ambiguity issue. > > On Wed, Oct 28,

Re: [PATCH] D13899: Fix bug in suggested fix that truncated variable names to 1 character.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Comment at: clang-tidy/misc/UnusedParametersCheck.cpp:25 @@ +24,3 @@ +template +static CharSourceRange removeNode(const MatchFinder::MatchResult , +

Re: [PATCH] D13973: CFG: Delay creating Dtors for CompoundStmts which end in ReturnStmt

klimek added a reviewer: jordan_rose. klimek added a comment. +jordan for an opinion on whether we want to fix the more general case. My main problem is that while we're at it we need to fully understand the change anyway, and if somebody runs into this later, they'll need a long time

[libcxx] r251767 - Improve the tests for 'is_literal_type'

Author: marshall Date: Sun Nov 1 15:13:10 2015 New Revision: 251767 URL: http://llvm.org/viewvc/llvm-project?rev=251767=rev Log: Improve the tests for 'is_literal_type' Modified: libcxx/trunk/test/std/utilities/meta/meta.unary/meta.unary.prop/is_literal_type.pass.cpp Modified:

Re: [PATCH] D13973: CFG: Delay creating Dtors for CompoundStmts which end in ReturnStmt

mgehre added inline comments. Comment at: lib/Analysis/CFG.cpp:1949-1952 @@ +1948,6 @@ + } + if (!C->body_empty() && !isa(*C->body_rbegin())) { +// If the body ends with a ReturnStmt, the dtors will be added in VisitReturnStmt +addAutomaticObjDtors(ScopePos,

[libcxx] r251768 - Add 'nostdinc++' to the flags used by testit. Makes the tests run better on Mac OS X with the new depr.c headers change

Author: marshall Date: Sun Nov 1 15:14:22 2015 New Revision: 251768 URL: http://llvm.org/viewvc/llvm-project?rev=251768=rev Log: Add 'nostdinc++' to the flags used by testit. Makes the tests run better on Mac OS X with the new depr.c headers change Modified: libcxx/trunk/test/testit

Re: [PATCH] D14096: [clang-tidy] add new check cppcoreguidelines-pro-type-cstyle-cast

mgehre updated this revision to Diff 38857. mgehre added a comment. Review comments: Formating and changed diag messages http://reviews.llvm.org/D14096 Files: clang-tidy/cppcoreguidelines/CMakeLists.txt clang-tidy/cppcoreguidelines/CppCoreGuidelinesTidyModule.cpp

Re: [PATCH] D5767: Template Instantiation Observer + a few other templight-related changes

sabel83 added a comment. Hi Manuel, The patch is maintained in the Templight git repository (https://github.com/mikael-s-persson/templight/blob/master/templight_clang_patch.diff). I've written some tests for it (based on our discussion at CppCon), they are under review at the moment (see

Re: [PATCH] D12922: Add support for function attribute "notail"

ahatanak added inline comments. Comment at: lib/Sema/SemaDecl.cpp:5374 @@ +5373,3 @@ + + // Virtual functions cannot be marked as 'notail'. + if (auto *Attr = ND.getAttr()) aaron.ballman wrote: > Is there a reason this is here instead of SemaDeclAttr.cpp? It

Re: [PATCH] D13973: CFG: Delay creating Dtors for CompoundStmts which end in ReturnStmt

mgehre added a comment. I see. Thinking about this, the same issue should also apply to a throw inside the compound stmt. And it's not only about suppressing the dtors but any CFG entries after return/throw. I'll prepare an updated patch. Manuel Klimek schrieb am So., 1. Nov.