r252720 - Make test/Driver/biarch.c use FileCheck instead of grep

Author: askrobov Date: Wed Nov 11 04:45:44 2015 New Revision: 252720 URL: http://llvm.org/viewvc/llvm-project?rev=252720=rev Log: Make test/Driver/biarch.c use FileCheck instead of grep Summary: For clarity and ease of maintenance, I suggest porting this test to use the same tooling as the rest

Re: [PATCH] D10305: [Clang Static Analyzer] Bug identification

seaneveson added a comment. In http://reviews.llvm.org/D10305#286385, @zaks.anna wrote: > The reason I like names more than the numbers is that we may use different > solutions for issue hash generation and some users might prefer one over the > other. It is not necessarily clear which one is

Re: [PATCH] D12547: Add support for function attribute "disable_tail_calls"

aaron.ballman added a comment. In http://reviews.llvm.org/D12547#287153, @ahatanak wrote: > Marking virtual functions as disable_tail_calls is fine since > disable_tail_calls affects the call sites inside the body of the marked > function. In your example, it prevents tail call optimization on

Re: [PATCH] D12547: Add support for function attribute "disable_tail_calls"

aaron.ballman added a comment. Missing tests demonstrating use of the C++ spelling of the attribute. Perhaps a test showing it on a member function would be useful. Out of curiosity, what would be the expected behavior of the following: struct B { int g(int);

Re: [PATCH] D9600: Add scan-build python implementation

jroelofs added a subscriber: jroelofs. jroelofs added a comment. Would you mind re-uploading this patch as a diff against upstream trunk with full context? http://reviews.llvm.org/D9600 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D14293: [libcxx] Add -fno-exceptions libcxx builders to zorg

rmaprath added a comment. Would it be OK if I commit the x86 buildbot changes (Dmitri approved these earlier) while the ARM buildbot changes are being reviewed? I suppose the changes would only take effect once @gkistanova restarts/reconfigs the build-master ? Cheers, - Asiri

Re: [PATCH] D14293: [libcxx] Add -fno-exceptions libcxx builders to zorg

jroelofs added a comment. In http://reviews.llvm.org/D14293#287174, @rmaprath wrote: > Would it be OK if I commit the x86 buildbot changes (Dmitri approved these > earlier) while the ARM buildbot changes are being reviewed? I suppose the > changes would only take effect once @gkistanova

RE: [PATCH] D14570: Handle ARMv6KZ naming

> Why isn't this just part of D14568? It's in the other repository. From: James Molloy [mailto:ja...@jamesmolloy.co.uk] Sent: 11 November 2015 12:42 To: reviews+d14570+public+1de1f7f06e3d3...@reviews.llvm.org; Artyom Skrobov; renato.go...@linaro.org; jo...@netbsd.org; Bernard Ogden

r252771 - Hiding the scan-build and scan-view projects under the Misc folder in IDEs instead of having them at the root view.

Author: aaronballman Date: Wed Nov 11 12:13:42 2015 New Revision: 252771 URL: http://llvm.org/viewvc/llvm-project?rev=252771=rev Log: Hiding the scan-build and scan-view projects under the Misc folder in IDEs instead of having them at the root view. Modified:

Re: [PATCH] D12547: Add support for function attribute "disable_tail_calls"

ahatanak added a comment. Marking virtual functions as disable_tail_calls is fine since disable_tail_calls affects the call sites inside the body of the marked function. In your example, it prevents tail call optimization on call sites inside B::g, but doesn't affect call sites in D::g.

Re: [PATCH] D13899: Fix bug in suggested fix that truncated variable names to 1 character.

sbenza added inline comments. Comment at: clang-tidy/misc/UnusedParametersCheck.cpp:25 @@ +24,3 @@ +template +static CharSourceRange removeNode(const MatchFinder::MatchResult , + const T *PrevNode, const T *Node, aaron.ballman

Re: [PATCH] D13759: [Clang] Fix Clang-tidy modernize-use-auto warnings in headers and generated files; other minor cleanups.

aaron.ballman added inline comments. Comment at: include/clang/AST/ASTVector.h:385 @@ -383,3 +384,3 @@ // Allocate the memory from the ASTContext. - T *NewElts = new (C, llvm::alignOf()) T[NewCapacity]; + auto *NewElts = new (C, llvm::alignOf()) T[NewCapacity];

Re: [PATCH] D14560: [Clang] Fix Clang-tidy modernize-use-auto in some files in lib/AST; other minor cleanups.

aaron.ballman added inline comments. Comment at: lib/AST/ASTContext.cpp:3857 @@ -3856,4 +3856,3 @@ void *Mem = Allocate(sizeof(ObjCObjectPointerType), TypeAlignment); - ObjCObjectPointerType *QType = -new (Mem) ObjCObjectPointerType(Canonical, ObjectT); + auto *QType =

Re: [PATCH] D12031: Const std::move() argument ClangTidy check

aaron.ballman added inline comments. Comment at: clang-tidy/misc/MoveConstantArgumentCheck.cpp:11 @@ +10,3 @@ +#include "MoveConstantArgumentCheck.h" + +namespace clang { > I didn't find how it can be done, could you please advice? This is the usual way we do it

Re: r252474 - Create install targets for scan-build and scan-view

This change causes MSVC to have two new projects sitting at the root of the solution: scan-build and scan-view, neither of which appear to do anything. Are these projects required for IDEs? If they're installation-only projects, I think the CMake should be guarded with `if(NOT

r252727 - Silencing a -Wreturn-type warning for control reaching the end of a non-void function.

Author: aaronballman Date: Wed Nov 11 07:42:02 2015 New Revision: 252727 URL: http://llvm.org/viewvc/llvm-project?rev=252727=rev Log: Silencing a -Wreturn-type warning for control reaching the end of a non-void function. Modified: cfe/trunk/lib/Basic/Targets.cpp Modified:

Re: [PATCH] D13899: Fix bug in suggested fix that truncated variable names to 1 character.

aaron.ballman added inline comments. Comment at: clang-tidy/misc/UnusedParametersCheck.cpp:25 @@ +24,3 @@ +template +static CharSourceRange removeNode(const MatchFinder::MatchResult , + const T *PrevNode, const T *Node, sbenza

Re: [PATCH] D14560: [Clang] Fix Clang-tidy modernize-use-auto in some files in lib/AST; other minor cleanups.

aaron.ballman added a comment. In http://reviews.llvm.org/D14560#286819, @hans wrote: > Like the other patch, I'm not sure that using auto in all these places help > readability. I share these concerns. Repository: rL LLVM http://reviews.llvm.org/D14560

Re: [PATCH] D14548: Make test/Driver/biarch.c use FileCheck instead of grep

This revision was automatically updated to reflect the committed changes. Closed by commit rL252720: Make test/Driver/biarch.c use FileCheck instead of grep (authored by askrobov). Changed prior to commit: http://reviews.llvm.org/D14548?vs=39840=39889#toc Repository: rL LLVM

r252721 - [ASan] Allow -fsanitize-recover=address.

Author: ygribov Date: Wed Nov 11 04:45:48 2015 New Revision: 252721 URL: http://llvm.org/viewvc/llvm-project?rev=252721=rev Log: [ASan] Allow -fsanitize-recover=address. Differential Revision: http://reviews.llvm.org/D14243 Modified: cfe/trunk/docs/UsersManual.rst

[PATCH] D14570: Handle ARMv6KZ naming

tyomitch created this revision. tyomitch added reviewers: rengolin, joerg, bogden. tyomitch added a subscriber: cfe-commits. Herald added subscribers: rengolin, aemerson. Update for clang tests for D14568 http://reviews.llvm.org/D14570 Files: test/Driver/arm-cortex-cpus.c

Re: [PATCH] D14441: [OpenCL] Pipe types support.

pxli168 added a subscriber: pxli168. Comment at: test/CodeGenOpenCL/pipe_types.cl:5 @@ +4,3 @@ + +void test1(read_only pipe int p) { +// CHECK: define void @test1(%opencl.pipe_t* %p) Great work!! But I have tried your patch and find it does not support opencl

Re: [PATCH] D14570: Handle ARMv6KZ naming

Hi Artyom, Why isn't this just part of D14568? Cheers, James On Wed, 11 Nov 2015 at 12:08 A. Skrobov via cfe-commits < cfe-commits@lists.llvm.org> wrote: > tyomitch created this revision. > tyomitch added reviewers: rengolin, joerg, bogden. > tyomitch added a subscriber: cfe-commits. > Herald

Re: [PATCH] D13746: [clang-tidy] add check cppcoreguidelines-pro-bounds-constant-array-index

alexfh added a comment. Sorry for the delay. A few more comments. Comment at: clang-tidy/cppcoreguidelines/ProBoundsConstantArrayIndexCheck.cpp:86 @@ +85,3 @@ + if (!IndexExpr->isIntegerConstantExpr(Index, *Result.Context, nullptr, +

r252840 - Refactor out some common code from r252834

Author: dblaikie Date: Wed Nov 11 19:09:58 2015 New Revision: 252840 URL: http://llvm.org/viewvc/llvm-project?rev=252840=rev Log: Refactor out some common code from r252834 Modified: cfe/trunk/lib/CodeGen/CodeGenFunction.cpp Modified: cfe/trunk/lib/CodeGen/CodeGenFunction.cpp URL:

Re: r252834 - Provide a frontend based error for always_inline functions that require

On Wed, Nov 11, 2015 at 4:54 PM, David Blaikie wrote: > > > On Wed, Nov 11, 2015 at 4:44 PM, Eric Christopher via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> Author: echristo >> Date: Wed Nov 11 18:44:12 2015 >> New Revision: 252834 >> >> URL:

Re: r252834 - Provide a frontend based error for always_inline functions that require

Currently, we inline a function only if the call to isInlineViable returns true, which means there are cases where we don't inline functions marked always_inline. Is there a reason we haven't made changes to produce any diagnostic in those cases? The comment also says "should be inlined whenever

Re: [PATCH] D12359: New warning -Wnonconst-parameter when a pointer parameter can be const

danielmarjamaki added a comment. In http://reviews.llvm.org/D12359#287522, @rsmith wrote: > Why does this construct justify the compiler emitting a warning? It seems to > be reporting a fact about the code rather than a bug, and as there are many > coding styles where variables are not

Re: [PATCH] D12547: Add support for function attribute "disable_tail_calls"

ahatanak updated this revision to Diff 40011. ahatanak added a comment. Address review comments. http://reviews.llvm.org/D12547 Files: include/clang/Basic/Attr.td include/clang/Basic/AttrDocs.td lib/CodeGen/CGCall.cpp lib/Sema/SemaDeclAttr.cpp test/CodeGen/attr-disable-tail-calls.c

Re: [PATCH] D14471: [AArch64] Fix a crash in driver

On 11/11/15 5:01 PM, Akira Hatanaka via cfe-commits wrote: ahatanak added a comment. In http://reviews.llvm.org/D14471#287412, @rengolin wrote: In http://reviews.llvm.org/D14471#286380, @ahatanak wrote: I think I can use macro __aarch64__ to have getAArch64TargetCPU return "native" when

Re: r252827 - Add diagnostics which fall under [dcl.spec.concept]p5

On Wed, Nov 11, 2015 at 6:59 PM, Richard Smith wrote: > On Wed, Nov 11, 2015 at 3:53 PM, Nathan Wilson via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> Author: nwilson >> Date: Wed Nov 11 17:53:35 2015 >> New Revision: 252827 >> >> URL:

Re: [PATCH] D14592: Qt (version 4 or 5) signal/method checker

Dushistov added inline comments. Comment at: lib/StaticAnalyzer/Checkers/QtSignalSlotChecker.cpp:114 @@ +113,3 @@ + printMethodNameWithPramaTypes(Out, C, FName, M, false); + const std::string NS = qtNormalizeSignature(Out.str());

Re: r252834 - Provide a frontend based error for always_inline functions that require

On Wed, Nov 11, 2015 at 4:44 PM, Eric Christopher via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: echristo > Date: Wed Nov 11 18:44:12 2015 > New Revision: 252834 > > URL: http://llvm.org/viewvc/llvm-project?rev=252834=rev > Log: > Provide a frontend based error for always_inline

r252855 - [Sema] Remove unnecessary parens in check using logical or; NFC.

Author: nwilson Date: Wed Nov 11 22:25:03 2015 New Revision: 252855 URL: http://llvm.org/viewvc/llvm-project?rev=252855=rev Log: [Sema] Remove unnecessary parens in check using logical or; NFC. Modified: cfe/trunk/lib/Sema/SemaDecl.cpp Modified: cfe/trunk/lib/Sema/SemaDecl.cpp URL:

Re: r252834 - Provide a frontend based error for always_inline functions that require

I think you are suggesting we change the inliner to produce a diagnostic (error or warning?) when the callee is marked always_inline and its function attributes are not compatible with the caller's (functionsHaveCompatibleAttributes returns false). Is that correct? On Wed, Nov 11, 2015 at 4:48

r252834 - Provide a frontend based error for always_inline functions that require

Author: echristo Date: Wed Nov 11 18:44:12 2015 New Revision: 252834 URL: http://llvm.org/viewvc/llvm-project?rev=252834=rev Log: Provide a frontend based error for always_inline functions that require target features that the caller function doesn't provide. This matches the existing backend

Re: r252834 - Provide a frontend based error for always_inline functions that require

On Wed, Nov 11, 2015 at 6:08 PM Akira Hatanaka wrote: > I think you are suggesting we change the inliner to produce a diagnostic > (error or warning?) when the callee is marked always_inline and its > function attributes are not compatible with the caller's >

r252861 - Use %select to merge two diagnostics that only differ in one word and are emitted in the same place. NFC

Author: ctopper Date: Thu Nov 12 01:36:50 2015 New Revision: 252861 URL: http://llvm.org/viewvc/llvm-project?rev=252861=rev Log: Use %select to merge two diagnostics that only differ in one word and are emitted in the same place. NFC Modified:

[PATCH] D14592: Qt (version 4 or 5) signal/method checker

Dushistov created this revision. Dushistov added reviewers: dcoughlin, Ayal, xazax.hun, zaks.anna. Dushistov added a subscriber: cfe-commits. In Qt 4/5 it is possible connect classes methods in such way: connect(ObjectPointer1, SIGNAL(methodOfObject1()), ObjectPointer2, SLOT(methodOfObject2());

Re: [PATCH] D14170: Fix false positive warning about memory leak for QApplication::postEvent

Dushistov updated this revision to Diff 39985. Dushistov added a comment. mistype, actually I want to use '&&' here, not '||' to not create std::string, if match failed. http://reviews.llvm.org/D14170 Files: lib/StaticAnalyzer/Checkers/MallocChecker.cpp test/Analysis/Inputs/qt-simulator.h

Re: [PATCH] D14471: [AArch64] Fix a crash in driver

ahatanak added a comment. In http://reviews.llvm.org/D14471#287412, @rengolin wrote: > In http://reviews.llvm.org/D14471#286380, @ahatanak wrote: > > > I think I can use macro __aarch64__ to have getAArch64TargetCPU return > > "native" when the compiler is not run on an AArch64 platform, but it

r252828 - [Basic] Fix DRY violation, just call getLineTable() (NFC)

Author: vedantk Date: Wed Nov 11 18:11:19 2015 New Revision: 252828 URL: http://llvm.org/viewvc/llvm-project?rev=252828=rev Log: [Basic] Fix DRY violation, just call getLineTable() (NFC) Modified: cfe/trunk/lib/Basic/SourceManager.cpp Modified: cfe/trunk/lib/Basic/SourceManager.cpp URL:

Re: [PATCH] D14471: [AArch64] Fix a crash in driver

ahatanak added a comment. Sorry, there were mistakes in my comments. What I meant to say is that changing getAArch64TargetCPU to return "native" would break the case where clang is being run on an aarch64 host. The current code in trunk will get the host cpu name (which I believe is currently

Re: [PATCH] D10305: [Clang Static Analyzer] Bug identification

zaks.anna added a comment. > Just for the sake of explaining, lets say in 3 subsequent Analyzer releases > the hashes are called “hash_1”, “hash_2” and “hash_3”. > In the first release the suppression tool will record hash_1 to suppress a > warning. Some developers will upgrade to the

Re: [PATCH] D14200: Make FP_CONTRACT ON default.

hfinkel accepted this revision. hfinkel added a comment. This revision is now accepted and ready to land. LGTM, thanks! http://reviews.llvm.org/D14200 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] Change memcpy/memmove/memset to have dest and source alignment

- Original Message - > From: "Pete Cooper" > To: "Hal Finkel" > Cc: "Lang Hames" , "LLVM Commits" > , cfe-commits@lists.llvm.org > Sent: Monday, September 28, 2015 12:46:36 PM > Subject: Re: [PATCH]

[PATCH] D14578: Cull non-standard variants of ARM architectures (NFC)

tyomitch created this revision. tyomitch added a reviewer: rengolin. tyomitch added a subscriber: cfe-commits. Herald added subscribers: rengolin, aemerson. Clang-side update, corresponding to D14577 http://reviews.llvm.org/D14578 Files: lib/Basic/Targets.cpp Index: lib/Basic/Targets.cpp

r252793 - [SemaDeclCXX] Use isTemplateParamScope() rather than accessing raw bits.

Author: davide Date: Wed Nov 11 14:06:35 2015 New Revision: 252793 URL: http://llvm.org/viewvc/llvm-project?rev=252793=rev Log: [SemaDeclCXX] Use isTemplateParamScope() rather than accessing raw bits. Modified: cfe/trunk/lib/Sema/SemaDeclCXX.cpp Modified: cfe/trunk/lib/Sema/SemaDeclCXX.cpp

Re: r252827 - Add diagnostics which fall under [dcl.spec.concept]p5

On Wed, Nov 11, 2015 at 3:53 PM, Nathan Wilson via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: nwilson > Date: Wed Nov 11 17:53:35 2015 > New Revision: 252827 > > URL: http://llvm.org/viewvc/llvm-project?rev=252827=rev > Log: > Add diagnostics which fall under [dcl.spec.concept]p5

r252853 - libclang: add clang_Cursor_getCXXManglings

Author: compnerd Date: Wed Nov 11 21:57:22 2015 New Revision: 252853 URL: http://llvm.org/viewvc/llvm-project?rev=252853=rev Log: libclang: add clang_Cursor_getCXXManglings This function permits the mangling of a C++ 'structor. Depending on the ABI and the declaration, the declaration may

Re: [PATCH] D14583: Report Windows error code in a fatal error after a system call

probinson marked an inline comment as done. probinson added a comment. In http://reviews.llvm.org/D14583#287406, @bcraig wrote: > Looks good to me, but since this is in the LLVMSupport library, you should > probably add llvm-commits to the subscriber list. Ah, right, I should have. But I'm

Re: [PATCH] D14583: Report Windows error code in a fatal error after a system call

probinson closed this revision. probinson marked an inline comment as done. probinson added a comment. r252800, thanks! http://reviews.llvm.org/D14583 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D14583: Report Windows error code in a fatal error after a system call

gbedwell added a subscriber: gbedwell. gbedwell added a comment. > > Also, I am really curious to know why CryptAcquireContext fails in those > > cases! > > > Me too. Once is a fluke, twice is a trend. Probably some obscure > system-resource problem but it would be nice to be sure. I'm

r252797 - [analyzer] Fix scan-build to handle missing output directories.

Author: dcoughlin Date: Wed Nov 11 14:39:03 2015 New Revision: 252797 URL: http://llvm.org/viewvc/llvm-project?rev=252797=rev Log: [analyzer] Fix scan-build to handle missing output directories. Cwd::abs_path has a somewhat tricky semantics: if it's operand directory does not exist, it'll

Re: [PATCH] D13330: Implement __attribute__((unique_instantiation))

aaron.ballman added a comment. Modulo the question you and David are discussing about variable templates (for which I don't have an answer handy), I just have a few small testing nits. Comment at: test/SemaCXX/unique-instantiations.cpp:24 @@ +23,3 @@ +template struct foo5;

Re: [PATCH] D14471: [AArch64] Fix a crash in driver

rengolin added a comment. In http://reviews.llvm.org/D14471#286380, @ahatanak wrote: > I think I can use macro __aarch64__ to have getAArch64TargetCPU return > "native" when the compiler is not run on an AArch64 platform, but it doesn't > sound like that was what you had in mind? Not at all.

r252809 - [CMake] Fixing passthrough for variables starting with COMPILER_RT

Author: cbieneman Date: Wed Nov 11 15:53:08 2015 New Revision: 252809 URL: http://llvm.org/viewvc/llvm-project?rev=252809=rev Log: [CMake] Fixing passthrough for variables starting with COMPILER_RT This allows COMPILER_RT_* variables to be passed from the top-level CMake into the external

Re: [PATCH] D12359: New warning -Wnonconst-parameter when a pointer parameter can be const

rsmith added a comment. Why does this construct justify the compiler emitting a warning? It seems to be reporting a fact about the code rather than a bug, and as there are many coding styles where variables are not routinely marked as const whenever possible, this appears to be checking that

Re: [PATCH] D13263: Addition of __attribute__((pass_object_size)) to Clang

aaron.ballman added inline comments. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:2068 @@ -2064,1 +2067,3 @@ def err_attribute_pointers_only : Error; +def err_attribute_constant_pointers_only : Error< + "%0 attribute only applies to constant pointer arguments">;

Re: [PATCH] D14170: Fix false positive warning about memory leak for QApplication::postEvent

Dushistov marked an inline comment as done. Dushistov added a comment. http://reviews.llvm.org/D14170 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D14560: [Clang] Fix Clang-tidy modernize-use-auto in some files in lib/AST; other minor cleanups.

Eugene.Zelenko added a comment. I'm adept of consistency :-) It's also easier to fix all similar patterns in code then do such cleanups selectively. Actually, similar fixes were made recently in Decl.cpp when casts were involved, but not new. Comment at:

r252814 - [TLS on Darwin] change how we handle globals with linkonce or weak linkage.

Author: mren Date: Wed Nov 11 16:42:31 2015 New Revision: 252814 URL: http://llvm.org/viewvc/llvm-project?rev=252814=rev Log: [TLS on Darwin] change how we handle globals with linkonce or weak linkage. This is about how we handle static member of a template. Before this commit, we use internal

LLVM buildmaster will be restarted tonight

Hello everyone, LLVM buildmaster will be updated restarted after 7 PM Pacific time today. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r252819 - Extract out a function onto CodeGenModule for getting the map of

Author: echristo Date: Wed Nov 11 17:05:08 2015 New Revision: 252819 URL: http://llvm.org/viewvc/llvm-project?rev=252819=rev Log: Extract out a function onto CodeGenModule for getting the map of features for a particular function, then use it to clean up some code. Modified:

r252711 - [X86] Use __builtin_ia32_paddq and __builtin_ia32_psubq to implement a couple intrinsics that were supposed to operate on MMX registers. Otherwise we end up operating on GPRs. Throw in a tes

Author: ctopper Date: Wed Nov 11 02:00:41 2015 New Revision: 252711 URL: http://llvm.org/viewvc/llvm-project?rev=252711=rev Log: [X86] Use __builtin_ia32_paddq and __builtin_ia32_psubq to implement a couple intrinsics that were supposed to operate on MMX registers. Otherwise we end up operating

r252710 - [X86] Header formatting fixes. NFC

Author: ctopper Date: Wed Nov 11 02:00:39 2015 New Revision: 252710 URL: http://llvm.org/viewvc/llvm-project?rev=252710=rev Log: [X86] Header formatting fixes. NFC Modified: cfe/trunk/lib/Headers/avx512vlbwintrin.h cfe/trunk/lib/Headers/avx512vldqintrin.h Modified:

r252712 - [X86] Add 'pause' builtin that's already in llvm and use it instead of inline assembly to implement _mm_pause.

Author: ctopper Date: Wed Nov 11 02:13:33 2015 New Revision: 252712 URL: http://llvm.org/viewvc/llvm-project?rev=252712=rev Log: [X86] Add 'pause' builtin that's already in llvm and use it instead of inline assembly to implement _mm_pause. Modified: