Re: r254251 - ARM v8.1a adds Advanced SIMD instructions for Rounding Double Multiply

Hi, This is entirely the wrong way to do these tests. They shouldn't depend on assembly output or optimization. Please split them onto frontend IR tests and backend assembly tests. Thanks! On Sun, Nov 29, 2015, 2:56 AM Alexandros Lamprineas via cfe-commits < cfe-commits@lists.llvm.org> wrote:

Re: r254262 - [X86][SSE2] Added SSE2 IR + assembly codegen builtin tests

So the problem we’re trying to solve is it make sure that in debug builds, clang compiles c/c++ intrinsics in the headers down to assembly that is very close to the expected instruction. What we had before (testing c/c++ to IR results in clang/test/CodeGen and testing with llc on ‘similar' IR

Re: r254262 - [X86][SSE2] Added SSE2 IR + assembly codegen builtin tests

OK I’ll see what I can do to split the tests with a -O0/-fast-isel llc version. I understand the work is straightforward, as I said my fear is that by breaking the connection we end up with syncing issues with the backend testing for IR patterns that the frontend no longer generates, which is

Re: r254262 - [X86][SSE2] Added SSE2 IR + assembly codegen builtin tests

This is amazing... And entirely the wrong place for the asm tests. :) Would you mind splitting this test case in two with an IR test for clang and an asm test for llvm? Thanks! On Sun, Nov 29, 2015, 12:25 PM Simon Pilgrim via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: rksimon >

Re: [PATCH] D8940: Clang changes for indirect call target profiling

davidxl added a comment. Betul, is this patch up to date? http://reviews.llvm.org/D8940 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: r254262 - [X86][SSE2] Added SSE2 IR + assembly codegen builtin tests

There's no reason a split set of tests would fail at doing this. You can test that the IR is what you expect and then that the backend tests it as well. It's very simple to do. On Sun, Nov 29, 2015, 2:08 PM Simon Pilgrim wrote: > So the problem we’re trying to solve is

r254270 - [X86] _mm256_permutevar8x32_ps should take an integer vector for its shuffle index input.

Author: ctopper Date: Sun Nov 29 16:53:32 2015 New Revision: 254270 URL: http://llvm.org/viewvc/llvm-project?rev=254270=rev Log: [X86] _mm256_permutevar8x32_ps should take an integer vector for its shuffle index input. Modified: cfe/trunk/include/clang/Basic/BuiltinsX86.def

r254262 - [X86][SSE2] Added SSE2 IR + assembly codegen builtin tests

Author: rksimon Date: Sun Nov 29 14:23:00 2015 New Revision: 254262 URL: http://llvm.org/viewvc/llvm-project?rev=254262=rev Log: [X86][SSE2] Added SSE2 IR + assembly codegen builtin tests Improved tests as discussed in PR24580 Added: cfe/trunk/test/CodeGen/sse2-builtins.c Added:

RE: r254262 - [X86][SSE2] Added SSE2 IR + assembly codegen builtin tests

Resending because I forgot to explicitly CC the list AGAIN. :-P > -Original Message- > From: cfe-commits [mailto:cfe-commits-boun...@lists.llvm.org] On Behalf Of > Simon Pilgrim via cfe-commits > Sent: Sunday, November 29, 2015 12:23 PM > To: cfe-commits@lists.llvm.org > Subject: r254262

Re: [Static Analyzer] New checker hook: checkInitialState

+Jordan, Anna --- Best regards, Gábor 'ShdNx' Kozár http://gaborkozar.me On Sat, Nov 28, 2015, at 22:52, Gabor Kozar via cfe-commits wrote: > Hi, > > Once, long ago, I started working on this checker callback, but forgot > about it. I have decided to finish it now. Original discussion: >

r254252 - clang/test/CodeGen/arm-v8.1a-neon-intrinsics.c REQUIRES both arm and aarch64.

Author: chapuni Date: Sun Nov 29 07:43:05 2015 New Revision: 254252 URL: http://llvm.org/viewvc/llvm-project?rev=254252=rev Log: clang/test/CodeGen/arm-v8.1a-neon-intrinsics.c REQUIRES both arm and aarch64. Modified: cfe/trunk/test/CodeGen/arm-v8.1a-neon-intrinsics.c Modified:

Re: [PATCH] D14982: ARM v8.1a adds Advanced SIMD instructions for Rounding Double Multiply Add/Subtract.

This revision was automatically updated to reflect the committed changes. Closed by commit rL254250: ARM v8.1a adds Advanced SIMD instructions for Rounding Double Multiply (authored by alelab01). Changed prior to commit: http://reviews.llvm.org/D14982?vs=41316=41344#toc Repository: rL LLVM

r254250 - ARM v8.1a adds Advanced SIMD instructions for Rounding Double Multiply

Author: alelab01 Date: Sun Nov 29 04:43:59 2015 New Revision: 254250 URL: http://llvm.org/viewvc/llvm-project?rev=254250=rev Log: ARM v8.1a adds Advanced SIMD instructions for Rounding Double Multiply Add/Subtract. The following instructions are added to AArch32 instruction set: - VQRDMLAH:

r254251 - ARM v8.1a adds Advanced SIMD instructions for Rounding Double Multiply

Author: alelab01 Date: Sun Nov 29 04:53:28 2015 New Revision: 254251 URL: http://llvm.org/viewvc/llvm-project?rev=254251=rev Log: ARM v8.1a adds Advanced SIMD instructions for Rounding Double Multiply Add/Subtract. Add missing tests that accidentally were not committed in rL254250. Differential

[PATCH] D15055: [X86] Better support for the MCU psABI

mkuper created this revision. mkuper added reviewers: rnk, rafael, DavidKreitzer. mkuper added a subscriber: cfe-commits. This adds support for the MCU psABI in a way different from r251223 and r251224, basically reverting most of these two patches. The problem with the approach taken in r251223

Re: r254262 - [X86][SSE2] Added SSE2 IR + assembly codegen builtin tests

Yeah, I've been trying to fix them. I didn't see them go in. :( And yes, that's a good way to tie them. It shouldn't be bad though. Separation of concerns and all. -eric On Sun, Nov 29, 2015, 3:10 PM Robinson, Paul < paul_robin...@playstation.sony.com> wrote: It looks like there are a number

[libcxx] r254283 - Implement more of P0006; Type Traits Variable Templates.

Author: marshall Date: Sun Nov 29 22:30:02 2015 New Revision: 254283 URL: http://llvm.org/viewvc/llvm-project?rev=254283=rev Log: Implement more of P0006; Type Traits Variable Templates. Modified: libcxx/trunk/include/type_traits

Re: [PATCH] D8940: Clang changes for indirect call target profiling

betulb added a comment. No it's not. I need to replace the API's w/ the recent ones for retrieving the value profile data and add the flag definition for -fprofile-values. This was off the radar due to other commitments. I'll get back to this beginning of this week. -Betul

[PATCH] D15062: [clang-format] Add test for AlignAfterOpenBracket = AlwaysBreak in C++.

jeanphilippeD created this revision. jeanphilippeD added a subscriber: cfe-commits. Herald added a subscriber: klimek. Revision 251405 added AlwaysBreak to support Google's JavaScript style. This changeset complete existing AlignsAfterOpenBracket tests to exercise AlwaysBreak for C++. I thought

r254281 - Use std::begin() and std::end() instead of doing the same manually. NFC

Author: ctopper Date: Sun Nov 29 21:11:10 2015 New Revision: 254281 URL: http://llvm.org/viewvc/llvm-project?rev=254281=rev Log: Use std::begin() and std::end() instead of doing the same manually. NFC Modified: cfe/trunk/lib/Basic/VirtualFileSystem.cpp Modified:

r254282 - Use range-based for loop to avoid the need for calculating an array size. NFC

Author: ctopper Date: Sun Nov 29 21:11:12 2015 New Revision: 254282 URL: http://llvm.org/viewvc/llvm-project?rev=254282=rev Log: Use range-based for loop to avoid the need for calculating an array size. NFC Modified: cfe/trunk/lib/Analysis/CFG.cpp Modified: cfe/trunk/lib/Analysis/CFG.cpp

[libcxx] r254284 - Fix bad macros in tests

Author: marshall Date: Sun Nov 29 23:03:35 2015 New Revision: 254284 URL: http://llvm.org/viewvc/llvm-project?rev=254284=rev Log: Fix bad macros in tests Modified: libcxx/trunk/test/std/utilities/meta/meta.rel/is_base_of.pass.cpp

[libcxx] r254285 - Implement more of P0006; Type Traits Variable Templates.

Author: marshall Date: Sun Nov 29 23:04:22 2015 New Revision: 254285 URL: http://llvm.org/viewvc/llvm-project?rev=254285=rev Log: Implement more of P0006; Type Traits Variable Templates. Modified: libcxx/trunk/test/std/utilities/ratio/ratio.comparison/ratio_equal.pass.cpp

[libcxx] r254286 - Missing file from last commit

Author: marshall Date: Sun Nov 29 23:04:48 2015 New Revision: 254286 URL: http://llvm.org/viewvc/llvm-project?rev=254286=rev Log: Missing file from last commit Modified: libcxx/trunk/include/ratio Modified: libcxx/trunk/include/ratio URL:

[libcxx] r254289 - Fix bugs in alignment_of_v, etc. Re-enable the newly added tests

Author: marshall Date: Sun Nov 29 23:20:00 2015 New Revision: 254289 URL: http://llvm.org/viewvc/llvm-project?rev=254289=rev Log: Fix bugs in alignment_of_v, etc. Re-enable the newly added tests Modified: libcxx/trunk/include/type_traits

[libcxx] r254287 - Fix bad macros

Author: marshall Date: Sun Nov 29 23:10:10 2015 New Revision: 254287 URL: http://llvm.org/viewvc/llvm-project?rev=254287=rev Log: Fix bad macros Modified: libcxx/trunk/test/std/utilities/meta/meta.unary.prop.query/alignment_of.pass.cpp Modified:

Re: [PATCH] D10833: Retrieve BinaryOperator::getOpcode and BinaryOperator::getOpcodeStr via libclang and its python interface

RedX2501 added a comment. Ping http://reviews.llvm.org/D10833 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] r254288 - Temporarily disable new tests while I figure out what's going on

Author: marshall Date: Sun Nov 29 23:15:10 2015 New Revision: 254288 URL: http://llvm.org/viewvc/llvm-project?rev=254288=rev Log: Temporarily disable new tests while I figure out what's going on Modified: libcxx/trunk/test/std/utilities/meta/meta.unary.prop.query/alignment_of.pass.cpp

[libcxx] r254290 - Last bit of P0006; mark it as complete

Author: marshall Date: Sun Nov 29 23:39:30 2015 New Revision: 254290 URL: http://llvm.org/viewvc/llvm-project?rev=254290=rev Log: Last bit of P0006; mark it as complete Modified: libcxx/trunk/include/chrono