Re: [PATCH] D14871: [Power PC] fix calculating address of arguments on stack for variadic functions

rjmccall added a comment. Thank you. A few more style complaints; with those fixed, LGTM. Comment at: lib/CodeGen/TargetInfo.cpp:166 @@ +165,3 @@ +// Dynamically round a pointer up to a multiple of the given alignment. +static llvm::Value*

[PATCH] D15090: [Static Analyzer] New checker hook: checkInitialState

Week-of-Mon-20151130/144002.html Original-original discussion (very old, ~2 years ago, when the idea first came up): http://lists.llvm.org/pipermail/cfe-commits/Week-of-Mon-20131216/095565.html Artem Dergachev has commented that a similar hook allowing to add multiple transitions u

Re: [PATCH] D14731: [libcxx] Add clang thread safety annotations to mutex and lock_guard

mclow.lists added a comment. In general, this looks fine. There are a few nits. 1. There needs to be a way to disable these annotations. The usual way in libc++ is to check to see if `_LIBCPP_THREAD_ANNOTATION` is already defined, and if so, do not define it. We usually state things in the

Re: [PATCH] D14731: [libcxx] Add clang thread safety annotations to mutex and lock_guard

mclow.lists added a comment. > We usually state things in the negative, so the controlling macro should be > _LIBCPP_HAS_NO_THREAD_ANNOTATION Or actually, `_LIBCPP_HAS_NO_THREAD_ANNOTATIONS` http://reviews.llvm.org/D14731 ___ cfe-commits

r254306 - Add --gcc-toolchain= to one of the libclang unitests to fix issue related to

Author: sfantao Date: Mon Nov 30 11:26:28 2015 New Revision: 254306 URL: http://llvm.org/viewvc/llvm-project?rev=254306=rev Log: Add --gcc-toolchain= to one of the libclang unitests to fix issue related to the gcc libraries clang picks for when it was configures with a user defined path.

Re: [Static Analyzer] New checker hook: checkInitialState

Hmm. I once thought about creating a 'checkBeginAnalysis()' callback to match 'checkEndAnalysis()'; this one's more powerful, and matches 'checkEndFunction()' in a similar manner. At a glance, I wonder if it's worth it to provide a CheckerContext inside this callback and then handle

Re: [PATCH] D14980: PR18513: make gcc compatible layout for bit-fields with explicit aligned attribute

DmitryPolukhin added a comment. Friendly ping, any comments about this patch? http://reviews.llvm.org/D14980 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r254303 - Do not crash when dumping the objc_bridge_related attribute when its optional arguments are not supplied.

Author: aaronballman Date: Mon Nov 30 09:25:34 2015 New Revision: 254303 URL: http://llvm.org/viewvc/llvm-project?rev=254303=rev Log: Do not crash when dumping the objc_bridge_related attribute when its optional arguments are not supplied. Patch thanks to Joe Ranieri! Modified:

Re: [PATCH] Don't crash when dumping objc_bridge_related attributes

On Thu, Nov 26, 2015 at 12:00 PM, Joe Ranieri wrote: > On Thu, Nov 26, 2015 at 11:29 AM, Aaron Ballman > wrote: >> On Wed, Nov 25, 2015 at 6:13 PM, Joe Ranieri wrote: >>> Clang's AST dumping currently crashes when dumping

Re: [PATCH] D15025: [ThinLTO] Option to invoke ThinLTO backend passes and importing

tejohnson added a comment. Thanks for the review, comments below. Teresa Comment at: lib/CodeGen/CodeGenAction.cpp:190 @@ -169,3 +189,3 @@ [=](const DiagnosticInfo ) { - linkerDiagnosticHandler(DI, LinkModule); +

Re: [PATCH] D13980: Add "x87" in x86 target feature map

aturetsk added inline comments. Comment at: lib/Basic/Targets.cpp:2548 @@ +2547,3 @@ + // All X86 processors but i386 have X87. + if (Kind != CK_i386) +setFeatureEnabledImpl(Features, "x87", true); rsmith wrote: > What about `CK_Generic`? Also, if `CK_i486`

Re: [PATCH] D14980: PR18513: make gcc compatible layout for bit-fields with explicit aligned attribute

rsmith added a subscriber: rsmith. rsmith added a comment. GCC's behavior (`aligned` on a field specifies the alignment of the start of that field) makes a little more sense to me than Clang's behavior (the type and alignment of a field specify a flavour of storage unit, and the field goes in

Re: [PATCH] D14980: PR18513: make gcc compatible layout for bit-fields with explicit aligned attribute

rjmccall added a comment. Well, this is a really nasty bug. Please check how this interacts with #pragma pack, which normally takes precedence over even explicit alignment attributes. If that's the case here, then what you really want to do is just add the same "ExplicitFieldAlign ||" clause

Re: [PATCH] D13980: Add "x87" in x86 target feature map

rsmith added inline comments. Comment at: lib/Basic/Targets.cpp:2548 @@ +2547,3 @@ + // All X86 processors but i386 have X87. + if (Kind != CK_i386) +setFeatureEnabledImpl(Features, "x87", true); aturetsk wrote: > rsmith wrote: > > What about `CK_Generic`?

Re: [PATCH] D14980: PR18513: make gcc compatible layout for bit-fields with explicit aligned attribute

rjmccall added a comment. In http://reviews.llvm.org/D14980#298754, @rsmith wrote: > GCC's behavior (`aligned` on a field specifies the alignment of the start of > that field) makes a little more sense to me than Clang's behavior (the type > and alignment of a field specify a flavour of

Re: [PATCH] D14409: Remove visibility attributes from out-of-class method definitions in iostreams.

eugenis added a comment. ping Repository: rL LLVM http://reviews.llvm.org/D14409 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D11182: [OPENMP 4.0] Initial support for 'omp declare reduction' construct.

ABataev added a comment. Richard, could you take a look one more time, please? http://reviews.llvm.org/D11182 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D10599: [OPENMP 4.0] Initial support for '#pragma omp declare simd' directive.

ABataev added a comment. Ping http://reviews.llvm.org/D10599 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D15087: [PATCH] Add CERT license clarification

aaron.ballman created this revision. aaron.ballman added reviewers: dberlin, chandlerc, alexfh. aaron.ballman added a subscriber: cfe-commits. During the review of D13446, Daniel pointed out that the CERT website's Terms of Use appear to prohibit using the rule title and minimal descriptions in

Re: [PATCH] D13446: [PATCH] Add checker discouraging definition of variadic function definitions in C++

As a follow-up on this topic, I have proposed a patch in: http://reviews.llvm.org/D15087 ~Aaron On Tue, Nov 3, 2015 at 1:05 PM, Aaron Ballman wrote: > On Tue, Nov 3, 2015 at 7:19 AM, Alexander Kornienko wrote: >> On Fri, Oct 9, 2015 at 12:13 PM,

r254323 - [MS Compat] Adjust thiscall to cdecl when deducing template arguments

Author: majnemer Date: Mon Nov 30 14:34:28 2015 New Revision: 254323 URL: http://llvm.org/viewvc/llvm-project?rev=254323=rev Log: [MS Compat] Adjust thiscall to cdecl when deducing template arguments Function types can be extracted from member pointer types. However, the type is not appropriate

add null pointer check

Hello, While running some private CSA checkers on a recent checkout of clang (dev), I found the following fix to be necessary to prevent a null pointer error in lib/StaticAnalyzer/Core/IssueHash.cpp — Mathieu diff --git a/lib/StaticAnalyzer/Core/IssueHash.cpp

Re: add null pointer check

Hi! Thank you for reporting this. A more complete fix is available here: http://reviews.llvm.org/D14919 I recommend to use that one :) Best Regards, Gabor On 30 November 2015 at 21:38, Mathieu Baudet wrote: > Hello, > > While running some private CSA checkers on a

Re: add null pointer check

Awesome. Looking forward to the full fix :) — Mathieu On Nov 30, 2015, at 12:48 PM, Gábor Horváth > wrote: Hi! Thank you for reporting this. A more complete fix is available here:

Re: [PATCH] D13015: [X86] Make f16c intrinsics accessible through emmintrin.h, per Intel docs

probinson added a subscriber: probinson. probinson added a comment. Regarding _mm[256]_cvtps_ph and ...cvtph_ps, I can find an Intel doc that say the _mm_* functions are in emmintrin.h and the _mm256_* are in immintrin.h, so putting them all with emmintrin.h is not consistent with what Intel

Re: [PATCH] D14980: PR18513: make gcc compatible layout for bit-fields with explicit aligned attribute

On Mon, Nov 30, 2015 at 2:31 PM, Richard Smith wrote: > On Mon, Nov 30, 2015 at 11:33 AM, John McCall wrote: > >> rjmccall added a comment. >> >> In http://reviews.llvm.org/D14980#298754, @rsmith wrote: >> >> > GCC's behavior (`aligned` on a field

Re: [PATCH] D15095: Accept "-Weverything" in pragma clang diagnostic ...

rsmith added a subscriber: rsmith. Comment at: lib/Basic/Diagnostic.cpp:251-257 @@ -250,2 +250,9 @@ SourceLocation Loc) { + // Special handling for pragma clang diagnostic ... "-Weverything" + // There is no formal group named

r254365 - [modules] Don't reject multiple modules providing contents for the same embedded file.

Author: rsmith Date: Mon Nov 30 21:32:49 2015 New Revision: 254365 URL: http://llvm.org/viewvc/llvm-project?rev=254365=rev Log: [modules] Don't reject multiple modules providing contents for the same embedded file. Added: cfe/trunk/test/Modules/embed-files.cpp Modified:

Re: [PATCH] D13357: [Concepts] Diagnose when 'concept' is specified on a specialization

nwilson added inline comments. Comment at: lib/Sema/SemaDecl.cpp:7659 @@ +7658,3 @@ +Diag(D.getDeclSpec().getConceptSpecLoc(), + diag::err_concept_specified_specialization) << 1; + } rsmith wrote: > hubert.reinterpretcast wrote: > >

[PATCH] D15095: Accept "-Weverything" in pragma clang diagnostic ...

Sunil_Srivastava created this revision. Sunil_Srivastava added a subscriber: cfe-commits. Special handling for “-Weverything” in ‘pragma clang diagnostic handling’ There is no formal diagnostic group named “everything”, so this code is needed. http://reviews.llvm.org/D15095 Files:

Re: [Static Analyzer] New checker hook: checkInitialState

This patch proposal is now on Phabricator: http://reviews.llvm.org/D15090 - let's continue this discussion there. > At a glance, I wonder if it's worth it to provide a CheckerContext inside this callback and then handle transitions properly (which would allow the checker to split the program

Re: [PATCH] D14919: Fix IssueHash generation

zaks.anna accepted this revision. zaks.anna added a comment. This revision is now accepted and ready to land. LGTM. http://reviews.llvm.org/D14919 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D13357: [Concepts] Diagnose when 'concept' is specified on a specialization

nwilson updated this revision to Diff 41441. nwilson added a comment. Updating to r254337 http://reviews.llvm.org/D13357 Files: include/clang/AST/Decl.h include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaDecl.cpp lib/Sema/SemaTemplate.cpp

Re: r254323 - [MS Compat] Adjust thiscall to cdecl when deducing template arguments

You forgot to update test/CXX/drs/dr5xx.cpp. Updated in r254346. On Tue, Dec 1, 2015 at 5:37 AM David Majnemer via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: majnemer > Date: Mon Nov 30 14:34:28 2015 > New Revision: 254323 > > URL:

r254359 - Fix use-after-free when a C++ thread_local variable gets replaced (because its

Author: rsmith Date: Mon Nov 30 19:10:48 2015 New Revision: 254359 URL: http://llvm.org/viewvc/llvm-project?rev=254359=rev Log: Fix use-after-free when a C++ thread_local variable gets replaced (because its type changes when the initializer is attached). Don't hold onto the GlobalVariable*;

Buildbot numbers for week of 11/22/2015 - 11/28/2015

Hello everyone, Below are some buildbot numbers for the last week of 11/22/2015 - 11/28/2015. Thanks Galina Top 10 fastest builders(not docs): lldb-amd64-ninja-freebsd11 clang-bpf-build llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast libcxx-libcxxabi-x86_64-linux-ubuntu-cxx03

Re: Buildbot numbers for week of 11/22/2015 - 11/28/2015

Thanks for tracking these results, Galina I think it might be better to send these to the -dev lists, rather than the -commits lists, but I'm not sure what other people think on that. On Mon, Nov 30, 2015 at 4:17 PM, Galina Kistanova via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Hello

Re: Buildbot numbers for week of 11/22/2015 - 11/28/2015

On Mon, Nov 30, 2015 at 5:00 PM, Galina Kistanova wrote: > Hi David, > > Thank you for the useful suggestions, I will work on these. > > >I guess the entries with no entry in the failed column have zero failures? > Yes. > > perf-x86_64-penryn-O3-polly-before-vectorizer

Re: [PATCH] D14824: [PATCH] Add clang-tidy check for static or thread_local objects where construction may throw

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG Comment at: clang-tidy/utils/Matchers.h:26 @@ -25,1 +25,3 @@ +AST_MATCHER(FunctionDecl, isNoThrow) { + const auto *FnTy = Node.getType()->getAs();

Re: Buildbot numbers for week of 11/22/2015 - 11/28/2015

Hi David, Thank you for the useful suggestions, I will work on these. >I guess the entries with no entry in the failed column have zero failures? Yes. perf-x86_64-penryn-O3-polly-before-vectorizer | 31 | 31 |

Re: [PATCH] D14980: PR18513: make gcc compatible layout for bit-fields with explicit aligned attribute

On Mon, Nov 30, 2015 at 11:33 AM, John McCall wrote: > rjmccall added a comment. > > In http://reviews.llvm.org/D14980#298754, @rsmith wrote: > > > GCC's behavior (`aligned` on a field specifies the alignment of the > start of that field) makes a little more sense to me than

r254346 - [PR25661] Revert part of r217213 according to r254323.

Author: chapuni Date: Mon Nov 30 17:46:32 2015 New Revision: 254346 URL: http://llvm.org/viewvc/llvm-project?rev=254346=rev Log: [PR25661] Revert part of r217213 according to r254323. Modified: cfe/trunk/test/CXX/drs/dr5xx.cpp Modified: cfe/trunk/test/CXX/drs/dr5xx.cpp URL:

[PATCH] D15097: [Sema] Issue a warning for integer overflow in struct initializer

ahatanak created this revision. ahatanak added a subscriber: cfe-commits. Issue a warning if an initializing integer expression overflows. For example, clang should issue a warning when compiling the following code because 4 * 1024 * 1024 * 1024 doesn't fit into a 32-bit integer: struct s {

r254337 - [libFuzzer] clarify the limitation of fsanitize-coverage=trace-cmp

Author: kcc Date: Mon Nov 30 16:17:19 2015 New Revision: 254337 URL: http://llvm.org/viewvc/llvm-project?rev=254337=rev Log: [libFuzzer] clarify the limitation of fsanitize-coverage=trace-cmp Modified: cfe/trunk/docs/SanitizerCoverage.rst Modified: cfe/trunk/docs/SanitizerCoverage.rst URL:

Re: [PATCH] D14940: [OpenMP] Update target directive codegen to use 4.5 implicit data mappings.

sfantao added a comment. Hi Alexey, Thanks for the review! Comment at: include/clang/AST/Stmt.h:2018-2020 @@ -2016,2 +2017,5 @@ break; + case VCK_ByCopy: +assert(Var && "capturing by copy must have a variable!"); +break; case VCK_VLAType:

Re: [PATCH] D14731: [libcxx] Add clang thread safety annotations to mutex and lock_guard

mclow.lists added a comment. Where are the tests? http://reviews.llvm.org/D14731 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: Buildbot numbers for week of 11/22/2015 - 11/28/2015

On 12/01/2015 02:05 AM, David Blaikie wrote: On Mon, Nov 30, 2015 at 5:00 PM, Galina Kistanova > wrote: Hi David, Thank you for the useful suggestions, I will work on these. >I guess the entries with no entry in the failed

Re: [PATCH] D14180: enable -fms-extensions by default on the mingw-w64 target

martell added a comment. I tried testing __has_builtin(_InterlockedCompareExchangeAdd) as it seem to not exist even when -fms-extensions is passed Is this a bug or it is intended ? http://reviews.llvm.org/D14180 ___ cfe-commits mailing list

RE: [PATCH] D13015: [X86] Make f16c intrinsics accessible through emmintrin.h, per Intel docs

Hi Paul, I'd rather not move them into immintrin.h. The current situation is that if you include emmintrin.h you get "too many" intrinsics w.r.t to the Intel docs (and immintrin.h is just right, since it recursively includes emmintrin.h), while if we move it to immintrin.h, including

r254389 - [X86] Improve codegen for AVX2 gather with an all 1s mask.

Author: ctopper Date: Tue Dec 1 01:12:59 2015 New Revision: 254389 URL: http://llvm.org/viewvc/llvm-project?rev=254389=rev Log: [X86] Improve codegen for AVX2 gather with an all 1s mask. Use undefined instead of setzero as the pass through input since its going to be fully overwritten. Use

[PATCH] Add a builtin for indexing into parameter packs

Hi, I wrote a patch that adds a `__nth_element` builtin that allows fetching the n-th type of a parameter pack with very little compile-time overhead. The patch was inspired by r252036 and r252115 by David Majnemer, which add a similar `__make_integer_seq` builtin for efficiently creating a

[PATCH] Fix the err_objc_type_args_after_protocols error message.

Type arguments must be before protocols in Objective-C type declarations. The error name and code behavior are correct, just the message is wrong. --- include/clang/Basic/DiagnosticParseKinds.td | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH] D15070: [mips] Added support for -Wa,-mips32 and similar.

s.egerton created this revision. s.egerton added reviewers: dsanders, vkalintiris. s.egerton added a subscriber: cfe-commits. http://reviews.llvm.org/D15070 Files: lib/Driver/Tools.cpp test/Driver/mips-ias-Wa.s Index: test/Driver/mips-ias-Wa.s