Re: [PATCH] D13126: New static analyzer checker for loss of sign/precision

danielmarjamaki marked 2 inline comments as done. danielmarjamaki added a comment. For information, I am testing this patch right now.. it will take a while 1-2 days. http://reviews.llvm.org/D13126 ___ cfe-commits mailing list

Re: [PATCH] D16113: [clang-tdiy] Add header file extension configuration support.

hokein added a comment. ping @alexfh. http://reviews.llvm.org/D16113 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D16310: new clang-tidy checker misc-long-cast

danielmarjamaki added a comment. For information I have now tested latest patch. Statistics: projects: 1804 files:85976 warnings: 100 There were some new interesting warnings and imho they were TP. http://reviews.llvm.org/D16310 ___

Re: [PATCH] D15283: [ARMv8-M] Add Clang targeting for ARMv8-M Baseline/Mainline

bsmith added a comment. Now that the LLVM side of this is committed, it would be great to get this reviewed also, thanks. Repository: rL LLVM http://reviews.llvm.org/D15283 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D16572: PR23057: fix use-after-free due to local token buffer in ParseCXXAmbiguousParenExpression

DmitryPolukhin created this revision. DmitryPolukhin added a reviewer: rjmccall. DmitryPolukhin added a subscriber: cfe-commits. To completely eliminate use-after-free in this place I had to copy tokens into new array and pass ownership. As far as I understand the code it is not possible to

Re: [PATCH] D13126: New static analyzer checker for loss of sign/precision

danielmarjamaki updated this revision to Diff 45972. danielmarjamaki marked 2 inline comments as done. danielmarjamaki added a comment. fixed review comments, readded 'loss of sign' checking http://reviews.llvm.org/D13126 Files: lib/StaticAnalyzer/Checkers/CMakeLists.txt

Re: [PATCH] D15897: [libc++] Silence warning about padding inserted at the tail of struct _Rep_base

joerg added a comment. As I said on IRC, it might be useful to set -Wpadding -Wno-error=padding, but I don't think the current state adds value. So removing the option is certainly an acceptable step forward to me. http://reviews.llvm.org/D15897

Re: [PATCH] D15721: [Sema] Fix ICE on casting a vector of bools to a vector of T

Anastasia added a comment. OpenCL side seems fine! Thanks for adding OpenCL diagnostic btw. I think we will also need to forbid the invalid conversions too at some point. Comment at: lib/Sema/SemaExpr.cpp:5715 @@ +5714,3 @@ + // when compiling code as e.g. C++) + uint64_t

Re: [PATCH] D16040: [OpenCL] Refine OpenCLImageAccessAttr to OpenCLAccessAttr

Anastasia added inline comments. Comment at: lib/Sema/SemaDeclAttr.cpp:5705 @@ -5669,8 +5704,3 @@ - // Walk the declarator structure, applying decl attributes that were in a type - // position to the decl itself. This handles cases like: - // int *__attr__(x)** D; - //

Re: r258720 - [MSVC Compat] Only warn for unknown clang-cl arguments

On 26 January 2016 at 01:56, Ehsan Akhgari wrote: > OK, I reverted the test in r258772. Thanks! Ok, the error code with no output will make for an interesting investigation... :) I'll try to collect as much info as possible. In the meantime, if you have any insights,

Re: [PATCH] D15373: Fix for bug 25786 - Assertion "Chunk.Kind == DeclaratorChunk::Function" failed with regparm attribute.

a.makarov added a comment. Ping http://reviews.llvm.org/D15373 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r258804 - [OPENMP 4.5] Allow arrays in 'reduction' clause.

Author: abataev Date: Tue Jan 26 06:20:39 2016 New Revision: 258804 URL: http://llvm.org/viewvc/llvm-project?rev=258804=rev Log: [OPENMP 4.5] Allow arrays in 'reduction' clause. OpenMP 4.5, alogn with array sections, allows to use variables of array type in reductions. Modified:

Re: [PATCH] D16529: [clang-tidy] Add modernize-raw-string-literal check

LegalizeAdulthood updated this revision to Diff 46101. LegalizeAdulthood marked 2 inline comments as done. LegalizeAdulthood added a comment. Update from comments: - leave existing raw string literals unchanged - don't change UTF-8, UTF-16, UTF-32 or wide character string literals - apply

Re: [PATCH] D16047: [OpenCL] Add Sema checks for OpenCL 2.0

pxli168 marked 6 inline comments as done. pxli168 added a comment. I will separate this patch into small ones. Comment at: lib/Sema/SemaDecl.cpp:5724 @@ +5723,3 @@ + R->isPipeType()) { +Diag(D.getIdentifierLoc(), +

Re: [PATCH] D15120: Add support for __float128 type to be used by targets that support it

hubert.reinterpretcast added a comment. In http://reviews.llvm.org/D15120#336891, @rjmccall wrote: > > The C committee decided that "undefined behavior" was what they could agree > > on for this sort of case. > > > That's only when the operand value is actually outside of the range of the >

Re: [PATCH] D15120: Add support for __float128 type to be used by targets that support it

rjmccall added a comment. In http://reviews.llvm.org/D15120#336996, @hubert.reinterpretcast wrote: > In http://reviews.llvm.org/D15120#336891, @rjmccall wrote: > > > > The C committee decided that "undefined behavior" was what they could > > > agree on for this sort of case. > > > > > > That's

Re: [PATCH] D16582: fix array index out of bounds

This revision was automatically updated to reflect the committed changes. Closed by commit rL258911: Fix array index out of bounds (authored by danielmarjamaki). Changed prior to commit: http://reviews.llvm.org/D16582?vs=45991=46102#toc Repository: rL LLVM http://reviews.llvm.org/D16582

Re: [PATCH] D15636: Reduce false positives in printf/scanf format checker

rtrieu added a comment. It looks like you are limiting to one diagnostic per printf, no matter the number of format strings. How is the case when multiple format strings would trigger the warning? http://reviews.llvm.org/D15636 ___ cfe-commits

Re: [PATCH] D16040: [OpenCL] Refine OpenCLImageAccessAttr to OpenCLAccessAttr

pxli168 added inline comments. Comment at: test/Parser/opencl-image-access.cl:9 @@ -7,1 +8,3 @@ +#if CL20 __kernel void f__rw(__read_write image2d_t a) { } +#endif Anastasia wrote: > Btw, I can see that read_write is now accepted even if -cl-std=CL1.1. So >

r258911 - Fix array index out of bounds

Author: danielmarjamaki Date: Wed Jan 27 01:33:50 2016 New Revision: 258911 URL: http://llvm.org/viewvc/llvm-project?rev=258911=rev Log: Fix array index out of bounds Differential Revision: http://reviews.llvm.org/D16582 Modified: cfe/trunk/lib/Driver/MSVCToolChain.cpp Modified:

Re: [PATCH] D16535: [clang-tidy] Check to find unintended semicolons that changes the semantics.

xazax.hun updated this revision to Diff 45949. xazax.hun added a comment. - Fixed the nits pointed out by the review. http://reviews.llvm.org/D16535 Files: clang-tidy/misc/CMakeLists.txt clang-tidy/misc/MiscTidyModule.cpp clang-tidy/misc/SuspiciousSemicolonCheck.cpp

Re: [PATCH] D16535: [clang-tidy] Check to find unintended semicolons that changes the semantics.

xazax.hun marked 5 inline comments as done. xazax.hun added a comment. http://reviews.llvm.org/D16535 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D15636: Reduce false positives in printf/scanf format checker

AndyG added a comment. Hi Richard, Thank you for looking at my patch. I would argue that the code printf(minimal ? "%i\n" : "%i: %s\n", code, msg); is valid and should //not// cause a warning due to unused arguments since at least one code path uses all the arguments. This in my view is

Re: [PATCH] D16566: [Clang-tidy] Fix Clang-tidy modernize-use-override warning in unittests/clang-tidy/IncludeInserterTest.cpp; other minor fixes

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rL LLVM http://reviews.llvm.org/D16566 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: r258720 - [MSVC Compat] Only warn for unknown clang-cl arguments

Hi Renato, Thanks, Nico helped me diagnose and fix the test yesterday < http://lists.llvm.org/pipermail/cfe-commits/Week-of-Mon-20160125/147979.html>. I fixed the test accordingly in r258776 and that seems to have worked! Cheers, Ehsan On Tue, Jan 26, 2016 at 7:41 AM, Renato Golin

Re: [PATCH] D16365: Do not define GXX_RTTI macro for C

rsmith added a subscriber: rsmith. rsmith added a comment. LGTM, assuming this is the same behaviour as GCC. http://reviews.llvm.org/D16365 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D16066: [clang-format] Add BeforeWhileInDoWhile BraceWrapping option

ebaker355 added a comment. Thanks for responding, and for the documentation link! It is certainly wise to not attempt "to supporting every single style used by a codebase somewhere in the wild." I do not know of a predefined coding style that recommends this format. My thinking was: - it

Re: [PATCH] D16376: clang-tidy check: Assignment and Construction

jbcoe retitled this revision from "clang-tidy check: User-defined copy without assignment" to "clang-tidy check: Assignment and Construction". jbcoe updated the summary for this revision. jbcoe set the repository for this revision to rL LLVM. jbcoe updated this revision to Diff 45987. jbcoe added

Re: [PATCH] D16066: [clang-format] Add BeforeWhileInDoWhile BraceWrapping option

djasper added a comment. Feel free to leave this patch around. Maybe somebody else comes up with something that meets the other criteria ;-). Me personally, I just think that seeing "while (1);" on a single line is quite misleading. But maybe that is just me. http://reviews.llvm.org/D16066

Re: [PATCH] D16066: [clang-format] Add BeforeWhileInDoWhile BraceWrapping option

ebaker355 reclaimed this revision. ebaker355 added a comment. Ok, cool! :) Thanks! http://reviews.llvm.org/D16066 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D16579: Warn if friend function depends on template parameters.

sepavloff created this revision. sepavloff added a subscriber: cfe-commits. Declaration of friend function may depend on template parameters, however it does not become a template function: template class C1 { friend void func(T x); }; It may be not obvious for user, so compiler

[PATCH] D16582: fix array index out of bounds

danielmarjamaki created this revision. danielmarjamaki added a subscriber: cfe-commits. danielmarjamaki set the repository for this revision to rL LLVM. This little patch fixes possible array index out of bounds: [tools/clang/lib/Driver/MSVCToolChain.cpp:147]: (error) Array 'partialKey[256]'

Re: [PATCH] D16582: fix array index out of bounds

danielmarjamaki added reviewers: rnk, hans, chandlerc, majnemer. danielmarjamaki added a comment. adding reviewers according to 'svn blame' and CODE_OWNERS.txt Repository: rL LLVM http://reviews.llvm.org/D16582 ___ cfe-commits mailing list

r258813 - [Driver] Update FIXME comment now that PR4941 has been addressed.

Author: mcrosier Date: Tue Jan 26 09:46:29 2016 New Revision: 258813 URL: http://llvm.org/viewvc/llvm-project?rev=258813=rev Log: [Driver] Update FIXME comment now that PR4941 has been addressed. The actual fix should be addressed by someone who can test on Darwin. Modified:

Re: [PATCH] D16566: [Clang-tidy] Fix Clang-tidy modernize-use-override warning in unittests/clang-tidy/IncludeInserterTest.cpp; other minor fixes

On Mon, Jan 25, 2016 at 6:20 PM, Eugene Zelenko via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Eugene.Zelenko created this revision. > Eugene.Zelenko added reviewers: alexfh, aaron.ballman. > Eugene.Zelenko added a subscriber: cfe-commits. > Eugene.Zelenko set the repository for this

r258814 - [Driver] Make sure -fno-math-builtin option is being passed by the driver.

Author: mcrosier Date: Tue Jan 26 09:52:05 2016 New Revision: 258814 URL: http://llvm.org/viewvc/llvm-project?rev=258814=rev Log: [Driver] Make sure -fno-math-builtin option is being passed by the driver. Support for the -fno-math-builtin option was added in r186899. The codegen side is being

[PATCH] D16584: [libcxx] Work around for clang calling GAS after having already failed.

dsanders created this revision. dsanders added reviewers: EricWF, mclow.lists, hans. dsanders added a subscriber: cfe-commits. This is a workaround to a clang bug which causes libcxx tests to fail in the 3.8 release. The clang bug is currently being investigated. It seems that clang does not stop

r258815 - Revert "[Driver] Make sure -fno-math-builtin option is being passed by the driver."

Author: mcrosier Date: Tue Jan 26 10:16:53 2016 New Revision: 258815 URL: http://llvm.org/viewvc/llvm-project?rev=258815=rev Log: Revert "[Driver] Make sure -fno-math-builtin option is being passed by the driver." This reverts commit r258814. Modified: cfe/trunk/lib/Driver/Tools.cpp

Re: [PATCH] D16578: [clang-tidy] bug fix: Don't warn on partial template specialization in `misc-definitions-in-headers` check.

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG. Do you need me to commit the patch? Repository: rL LLVM http://reviews.llvm.org/D16578 ___ cfe-commits mailing list

Re: [PATCH] D16566: [Clang-tidy] Fix Clang-tidy modernize-use-override warning in unittests/clang-tidy/IncludeInserterTest.cpp; other minor fixes

alexfh added inline comments. Comment at: unittests/clang-tidy/IncludeInserterTest.cpp:101 @@ -100,3 +100,3 @@ : IncludeInserterCheckBase(CheckName, Context) {} - virtual ~CXXSystemIncludeInserterCheck() {} + ~CXXSystemIncludeInserterCheck() override = default;

Re: r258815 - Revert "[Driver] Make sure -fno-math-builtin option is being passed by the driver."

All, In r258814 I upgraded the -fno-math-builtin option from a cc1 only option to a full blown compiler option. However, after a bit of searching I can't seem to find documentation of this actually being a supported option by gcc. Therefore, I reverted the change. I can see the potential

Re: [PATCH] D16517: ClangTidy check to flag uninitialized builtin and pointer fields.

alexfh added a comment. A high-level comment: I think, this comment still applies. I'm also slightly concerned about having this check in misc-, since the check isn't universally applicable (e.g. based on a couple of discussions, I guess LLVM community

Re: [PATCH] D16527: [OpenMP] Parsing + sema for defaultmap clause.

This revision was automatically updated to reflect the committed changes. Closed by commit rL258817: [OpenMP] Parsing + sema for defaultmap clause. (authored by arpith). Changed prior to commit: http://reviews.llvm.org/D16527?vs=45856=46000#toc Repository: rL LLVM

Re: [PATCH] D16572: PR23057: fix use-after-free due to local token buffer in ParseCXXAmbiguousParenExpression

I don't fully understand your explanation. Is your change introducing a memory leak? (or was the old code causing a double free (if EnterTokenStream does take ownership of this argument)in addition to use-after-free?) On Tue, Jan 26, 2016 at 2:45 AM, Dmitry Polukhin via cfe-commits <

Re: [PATCH] D16517: ClangTidy check to flag uninitialized builtin and pointer fields.

flx added a comment. In http://reviews.llvm.org/D16517#336148, @alexfh wrote: > A high-level comment: I think, this comment > still applies. I'm also slightly > concerned about having this check in misc-, since the check isn't universally > applicable

[PATCH] D16586: Make clang AAPCS compliant w.r.t volatile bitfield accesses

rmaprath created this revision. rmaprath added reviewers: rjmccall, jmolloy, rengolin, olista01. rmaprath added a subscriber: cfe-commits. Herald added a subscriber: aemerson. Lets consider the following plain struct: ``` struct S1 { char a; short b : 8; }; ``` According to the AAPCS,

Re: [PATCH] D16582: fix array index out of bounds

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm This code is old and super janky. =/ Repository: rL LLVM http://reviews.llvm.org/D16582 ___ cfe-commits mailing list

[PATCH] D16587: Fixed function params comparison. Updated docs and tests.

congliu created this revision. congliu added a reviewer: alexfh. congliu added a subscriber: cfe-commits. "checkParamTypes" may fail if the the type of some parameter is not canonical. Fixed it by comparing canonical types. And added "getCanonicalType()" and "getCanonicalDecl()" on more places

Re: [PATCH] D16559: [CUDA] Add -fcuda-allow-variadic-functions.

bkramer accepted this revision. bkramer added a reviewer: bkramer. bkramer added a comment. This revision is now accepted and ready to land. Looks good to me, but I don't really now CUDA. http://reviews.llvm.org/D16559 ___ cfe-commits mailing list

Re: [PATCH] D16578: [clang-tidy] bug fix: Don't warn on partial template specialization in `misc-definitions-in-headers` check.

hokein added a comment. Yes, please help to land the patch for me :). Thanks. Repository: rL LLVM http://reviews.llvm.org/D16578 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D16559: [CUDA] Add -fcuda-allow-variadic-functions.

tra accepted this revision. tra added a comment. LGTM. http://reviews.llvm.org/D16559 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r258822 - [CUDA] Add -fcuda-allow-variadic-functions.

Author: jlebar Date: Tue Jan 26 11:47:20 2016 New Revision: 258822 URL: http://llvm.org/viewvc/llvm-project?rev=258822=rev Log: [CUDA] Add -fcuda-allow-variadic-functions. Summary: Turns out the variadic function checking added in r258643 was too strict for some existing users; give them an

Re: [PATCH] D16559: [CUDA] Add -fcuda-allow-variadic-functions.

This revision was automatically updated to reflect the committed changes. Closed by commit rL258822: [CUDA] Add -fcuda-allow-variadic-functions. (authored by jlebar). Changed prior to commit: http://reviews.llvm.org/D16559?vs=45915=46005#toc Repository: rL LLVM

Re: [PATCH] D16572: PR23057: fix use-after-free due to local token buffer in ParseCXXAmbiguousParenExpression

DmitryPolukhin added a comment. I didn't introduce a leak because I pass ownership of the Buffer to EnterTokenStream (i.e. pass true as the last argument OwnsTokens). ASan also doesn't report a leak with my patch. Original code didn't have double free because it used call EnterTokenStream with

[PATCH] D16591: Add backend dignostic printer for unsupported features

olista01 created this revision. olista01 added reviewers: ast, sunfish, tstellarAMD. olista01 added a subscriber: cfe-commits. olista01 set the repository for this revision to rL LLVM. The related LLVM patch adds a backend diagnostic type for reporting unsupported features, this adds a printer

r258824 - Use instance_properties instead of properties. NFC.

Author: mren Date: Tue Jan 26 12:05:23 2016 New Revision: 258824 URL: http://llvm.org/viewvc/llvm-project?rev=258824=rev Log: Use instance_properties instead of properties. NFC. All current properties are instance properties. This is the second patch in a series of patches to support class

Re: [PATCH] D15120: Add support for __float128 type to be used by targets that support it

nemanjai updated this revision to Diff 45998. nemanjai added a comment. Addressed review comments. The key differences are: - No assignments or operations between entities of long double and __float128 allowed if the two types have a different representation - Each type has a distinct rank

Merge OpenCL 2.0 Pipe builtins (r258782) in 3.8

Hi Hans, Could you please merge Clang commit r258782 into release 3.8. It adds Pipe BIFs to be used along with Pipe type committed earlier (in r257254). Thanks, Anastasia ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D16351: [FIX] Bug 25404 - Crash on typedef in OpenCL 2.0

arsenm added a subscriber: arsenm. arsenm added a comment. Add cfe-commits http://reviews.llvm.org/D16351 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r258834 - Class Property: parse property attribute (class).

Author: mren Date: Tue Jan 26 12:52:43 2016 New Revision: 258834 URL: http://llvm.org/viewvc/llvm-project?rev=258834=rev Log: Class Property: parse property attribute (class). This is the third patch in a series of patches to support class properties in addition to instance properties in

Re: [PATCH] D16591: Add backend dignostic printer for unsupported features

ast added a comment. looks good. could you add a testcase for DK_Unsupported ? Repository: rL LLVM http://reviews.llvm.org/D16591 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D16553: [OpenMP] Parsing + sema for target parallel directive.

arpith-jacob closed this revision. arpith-jacob added a comment. Committed revision 258832. I had to modify test cases 'target_parallel_reduction_messages.cpp' and 'target_parallel_map_messages.cpp' to use the updated error messages from patches recently committed to trunk.

Re: [PATCH] D16559: [CUDA] Add -fcuda-allow-variadic-functions.

mcrosier added a subscriber: mcrosier. Comment at: cfe/trunk/include/clang/Driver/CC1Options.td:681 @@ -680,1 +680,3 @@ HelpText<"Enable function overloads based on CUDA target attributes.">; +def fcuda_allow_variadic_functions : Flag<["-"], "fcuda-allow-variadic-functions">,

[clang-tools-extra] r258835 - Test commit. Fix typo in comment.

Author: jbcoe Date: Tue Jan 26 12:55:55 2016 New Revision: 258835 URL: http://llvm.org/viewvc/llvm-project?rev=258835=rev Log: Test commit. Fix typo in comment. Modified: clang-tools-extra/trunk/clang-tidy/readability/IdentifierNamingCheck.cpp Modified:

Re: [PATCH] D16559: [CUDA] Add -fcuda-allow-variadic-functions.

mcrosier added inline comments. Comment at: cfe/trunk/include/clang/Driver/CC1Options.td:681 @@ -680,1 +680,3 @@ HelpText<"Enable function overloads based on CUDA target attributes.">; +def fcuda_allow_variadic_functions : Flag<["-"], "fcuda-allow-variadic-functions">, +

r258836 - Fix Clang-tidy modernize-use-nullptr warnings; other minor fixes.

Author: eugenezelenko Date: Tue Jan 26 13:01:06 2016 New Revision: 258836 URL: http://llvm.org/viewvc/llvm-project?rev=258836=rev Log: Fix Clang-tidy modernize-use-nullptr warnings; other minor fixes. Differential revision: http://reviews.llvm.org/D16567 Modified:

Re: [PATCH] D16567: [Clang] Fix Clang-tidy modernize-use-nullptr warnings; other minor fixes

This revision was automatically updated to reflect the committed changes. Closed by commit rL258836: Fix Clang-tidy modernize-use-nullptr warnings; other minor fixes. (authored by eugenezelenko). Changed prior to commit: http://reviews.llvm.org/D16567?vs=45941=46016#toc Repository: rL LLVM

Re: [PATCH] D16559: [CUDA] Add -fcuda-allow-variadic-functions.

tra added inline comments. Comment at: cfe/trunk/include/clang/Driver/CC1Options.td:681 @@ -680,1 +680,3 @@ HelpText<"Enable function overloads based on CUDA target attributes.">; +def fcuda_allow_variadic_functions : Flag<["-"], "fcuda-allow-variadic-functions">, +

Re: [libcxx] r258107 - Fix PR#26175. Thanks to Josh Petrie for the report and the patch. Reviewed as http://reviews.llvm.org/D16262

On Tue, Jan 19, 2016 at 9:21 AM, Hans Wennborg wrote: > On Tue, Jan 19, 2016 at 12:01 AM, Dimitry Andric wrote: >> On 19 Jan 2016, at 01:50, Marshall Clow via cfe-commits >> wrote: >>> >>> Author: marshall >>> Date: Mon Jan 18

Re: [PATCH] D16408: [libcxx] Additional 'REQUIRE' directives for tests that require en_US.UTF-8.

hans added a comment. Ping? This and r258403 are on my watch-list for 3.8. http://reviews.llvm.org/D16408 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D16566: [Clang-tidy] Fix Clang-tidy modernize-use-override warning in unittests/clang-tidy/IncludeInserterTest.cpp; other minor fixes

Eugene.Zelenko added inline comments. Comment at: unittests/clang-tidy/IncludeInserterTest.cpp:101 @@ -100,3 +100,3 @@ : IncludeInserterCheckBase(CheckName, Context) {} - virtual ~CXXSystemIncludeInserterCheck() {} + ~CXXSystemIncludeInserterCheck() override = default;

Re: [libcxx] r249798 - Split out of .

Eric, Marshall: has there been any progress here? On Wed, Jan 20, 2016 at 10:29 AM, Hans Wennborg wrote: > /sub > > On Wed, Jan 20, 2016 at 4:45 AM, Nico Weber via cfe-commits > wrote: >> Eric, Marshall: another ping. This should be fixed on the

Re: r258307 - [OPENMP 4.0] Fix for codegen of 'cancel' directive within 'sections' directive.

Did that fix land, and should it be merged to 3.8? On Thu, Jan 21, 2016 at 7:03 PM, Alexey Bataev wrote: > Later today I will post another fix, that will fix all 'sections' > related troubles, including this one. So I don't think it is necessary > to merge it > > Best

Re: [PATCH] D16559: [CUDA] Add -fcuda-allow-variadic-functions.

mcrosier added inline comments. Comment at: cfe/trunk/include/clang/Driver/CC1Options.td:681 @@ -680,1 +680,3 @@ HelpText<"Enable function overloads based on CUDA target attributes.">; +def fcuda_allow_variadic_functions : Flag<["-"], "fcuda-allow-variadic-functions">, +

[PATCH] D16593: [CUDA] Implemented device-side support for functions in .

tra created this revision. tra added a reviewer: jlebar. tra added a subscriber: cfe-commits. CUDA expects math functions in std:: namespace to work on device side. In order to make it work with clang without allowing device-side code generation for functions w/o appropriate target attributes,

r258839 - [MS ABI] Allow a member pointers' converted type to change

Author: majnemer Date: Tue Jan 26 13:30:26 2016 New Revision: 258839 URL: http://llvm.org/viewvc/llvm-project?rev=258839=rev Log: [MS ABI] Allow a member pointers' converted type to change Member pointers in the MS ABI are tricky for a variety of reasons. The size of a member pointer is

Re: [PATCH] D16586: Make clang AAPCS compliant w.r.t volatile bitfield accesses

rjmccall added a comment. Well, that's certainly an interesting ABI rule. A few high-level notes: 1. AAPCS requires the bit-field to be loaded on a store, even if the store fills the entire container; that doesn't seem to be implemented in your patch. 2. Especially because of #1, let's not do

Re: [PATCH] D13357: [Concepts] Diagnose when 'concept' is specified on a specialization

nwilson added a comment. Ping. @rsmith - would you also mind clarifying the comment regarding `setConcept(bool IC)` at to whether it should exist at all or simply not have any params? http://reviews.llvm.org/D13357 ___ cfe-commits mailing list

Re: [PATCH] D15897: [libc++] Silence warning about padding inserted at the tail of struct _Rep_base

ahatanak added a comment. Do you mean "-Wpadded -Wno-error=padded" instead of padding? I'm looking for a way to silence the warning, so that isn't enough. If we need more time to decide whether we want to use -Wpadded (for both buildit and cmake), I think I'll just remove -Wpadded from

Re: [PATCH] D15897: [libc++] Silence warning about padding inserted at the tail of struct _Rep_base

ahatanak added a comment. There is also a PR about splitting -Wpadded into two options: one warns about padding in the middle of a struct and the other warns about padding at the end. If the former option is used instead of -Wpadded, I believe it's possible to remove the pragmas that are

Re: [PATCH] D16593: [CUDA] Implemented device-side support for functions in .

jlebar added a comment. Missing (?) functions: - div, ldiv, lldiv, imaxdiv - imaxabs If you left these out intentionally (I forget if nvidia supports div_t), that's probably fine, but maybe add a comment? wrt the "::" comments, some are nits because I think we end up calling the right thing,

Re: [PATCH] D15120: Add support for __float128 type to be used by targets that support it

rjmccall added a comment. In http://reviews.llvm.org/D15120#336282, @nemanjai wrote: > Addressed review comments. > The key differences are: > > - No assignments or operations between entities of long double and __float128 > allowed if the two types have a different representation > - Each

r258850 - Do not define GXX_RTTI macro for C.

Author: ygao Date: Tue Jan 26 14:15:02 2016 New Revision: 258850 URL: http://llvm.org/viewvc/llvm-project?rev=258850=rev Log: Do not define GXX_RTTI macro for C. This is same as GCC behavior (tested with GCC 4.8.2). Differential Revision: http://reviews.llvm.org/D16365 Modified:

Re: [PATCH] D16365: Do not define GXX_RTTI macro for C

This revision was automatically updated to reflect the committed changes. Closed by commit rL258850: Do not define GXX_RTTI macro for C. (authored by ygao). Changed prior to commit: http://reviews.llvm.org/D16365?vs=45416=46031#toc Repository: rL LLVM http://reviews.llvm.org/D16365 Files:

Re: [PATCH] D16408: [libcxx] Additional 'REQUIRE' directives for tests that require en_US.UTF-8.

EricWF added a subscriber: EricWF. EricWF accepted this revision. EricWF added a reviewer: EricWF. EricWF added a comment. This revision is now accepted and ready to land. LGTM. @dsanders: What platform are you on that doesn't have en_US.UTF-8? If your serious about testing libc++ you should

[libcxx] r258852 - Fix PR26103 - Error calling is_convertible with incomplete type. Patch from Michael Daniels.

Author: ericwf Date: Tue Jan 26 14:24:30 2016 New Revision: 258852 URL: http://llvm.org/viewvc/llvm-project?rev=258852=rev Log: Fix PR26103 - Error calling is_convertible with incomplete type. Patch from Michael Daniels. Modified: libcxx/trunk/include/type_traits

Re: [PATCH] D16344: [libcxx] Fix PR26103 - Error calling is_convertible with incomplete type

EricWF closed this revision. EricWF added a comment. Committed as r258852. Thanks for the patch. http://reviews.llvm.org/D16344 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] r258855 - Remove dead code missed in r258852.

Author: ericwf Date: Tue Jan 26 14:31:01 2016 New Revision: 258855 URL: http://llvm.org/viewvc/llvm-project?rev=258855=rev Log: Remove dead code missed in r258852. Modified: libcxx/trunk/include/type_traits Modified: libcxx/trunk/include/type_traits URL:

Re: [PATCH] D16584: [libcxx] Work around for clang calling GAS after having already failed.

EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. Obviously LGTM. @hans I'm OK with this going into 3.8. http://reviews.llvm.org/D16584 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D16135: Macro Debug Info support in Clang

aaboud updated this revision to Diff 46034. aaboud marked 6 inline comments as done. aaboud added a comment. Added comments explaining the implementation. http://reviews.llvm.org/D16135 Files: include/clang/AST/ASTConsumer.h lib/AST/ASTConsumer.cpp lib/CodeGen/CGDebugInfo.cpp

Re: [PATCH] D15897: [libc++] Silence warning about padding inserted at the tail of struct _Rep_base

On Tue, Jan 26, 2016 at 07:43:03PM +, Akira Hatanaka via cfe-commits wrote: > ahatanak added a comment. > > Do you mean "-Wpadded -Wno-error=padded" instead of padding? > > I'm looking for a way to silence the warning, so that isn't enough. If > we need more time to decide whether we want to

Re: [PATCH] D16593: [CUDA] Implemented device-side support for functions in .

tra updated this revision to Diff 46041. tra marked 3 inline comments as done. tra added a comment. Added missing :: http://reviews.llvm.org/D16593 Files: lib/Headers/CMakeLists.txt lib/Headers/__clang_cuda_cmath.h lib/Headers/__clang_cuda_runtime_wrapper.h Index:

Re: [PATCH] D16475: Remove autoconf support

This revision was automatically updated to reflect the committed changes. Closed by commit rL258864: Remove autoconf support (authored by cbieneman). Changed prior to commit: http://reviews.llvm.org/D16475?vs=45709=46045#toc Repository: rL LLVM http://reviews.llvm.org/D16475 Files:

[clang-tools-extra] r258864 - Remove autoconf support

Author: cbieneman Date: Tue Jan 26 15:31:36 2016 New Revision: 258864 URL: http://llvm.org/viewvc/llvm-project?rev=258864=rev Log: Remove autoconf support Summary: This patch is provided in preparation for removing autoconf on 1/26. The proposal to remove autoconf on 1/26 was discussed on the

Re: [PATCH] D15721: [Sema] Fix ICE on casting a vector of bools to a vector of T

george.burgess.iv updated this revision to Diff 46053. george.burgess.iv marked an inline comment as done. george.burgess.iv added a comment. Updated comment, as requested. http://reviews.llvm.org/D15721 Files: lib/Sema/SemaExpr.cpp lib/Sema/SemaType.cpp

Re: [PATCH] D16566: [Clang-tidy] Fix Clang-tidy modernize-use-override warning in unittests/clang-tidy/IncludeInserterTest.cpp; other minor fixes

This revision was automatically updated to reflect the committed changes. Closed by commit rL258870: Fix Clang-tidy modernize-use-override warning in unittests/clang… (authored by eugenezelenko). Changed prior to commit: http://reviews.llvm.org/D16566?vs=45938=46054#toc Repository: rL LLVM

Re: [PATCH] D16593: [CUDA] Implemented device-side support for functions in .

tra updated this revision to Diff 46055. tra marked 6 inline comments as done. tra added a comment. Fixed few issues revealed by -Wdouble-promotion http://reviews.llvm.org/D16593 Files: lib/Headers/CMakeLists.txt lib/Headers/__clang_cuda_cmath.h lib/Headers/__clang_cuda_runtime_wrapper.h

[PATCH] D16605: Implement `std::experimental::ostream_joiner`

mclow.lists created this revision. mclow.lists added reviewers: EricWF, howard.hinnant. mclow.lists added a subscriber: cfe-commits. This is part of the Library Fundamentals 2 TS http://reviews.llvm.org/D16605 Files: include/experimental/iterator

r258877 - [WinEH] Annotate calls to __RTtypeid with a funclet bundle

Author: majnemer Date: Tue Jan 26 17:14:47 2016 New Revision: 258877 URL: http://llvm.org/viewvc/llvm-project?rev=258877=rev Log: [WinEH] Annotate calls to __RTtypeid with a funclet bundle Clang's CodeGen has several paths which end up invoking or calling a function. The one that we used for

[PATCH] D16607: Implementation of PS4 ABI, round 1

Sunil_Srivastava created this revision. Sunil_Srivastava added a reviewer: rsmith. Sunil_Srivastava added a subscriber: cfe-commits. We are planning to upstream changes needed for maintaining PS4 ABI across future releases. Unlike many other targets, we need to maintain, in most cases, strict

  1   2   >