Re: [PATCH] D16527: [OpenMP] Parsing + sema for defaultmap clause.

This revision was automatically updated to reflect the committed changes. Closed by commit rL258817: [OpenMP] Parsing + sema for defaultmap clause. (authored by arpith). Changed prior to commit: http://reviews.llvm.org/D16527?vs=45856&id=46000#toc Repository: rL LLVM http://reviews.llvm.org

Re: [PATCH] D16517: ClangTidy check to flag uninitialized builtin and pointer fields.

alexfh added a comment. A high-level comment: I think, this comment still applies. I'm also slightly concerned about having this check in misc-, since the check isn't universally applicable (e.g. based on a couple of discussions, I guess LLVM community wo

Re: r258815 - Revert "[Driver] Make sure -fno-math-builtin option is being passed by the driver."

All, In r258814 I upgraded the -fno-math-builtin option from a cc1 only option to a full blown compiler option. However, after a bit of searching I can't seem to find documentation of this actually being a supported option by gcc. Therefore, I reverted the change. I can see the potential utility

Re: [PATCH] D16566: [Clang-tidy] Fix Clang-tidy modernize-use-override warning in unittests/clang-tidy/IncludeInserterTest.cpp; other minor fixes

alexfh added inline comments. Comment at: unittests/clang-tidy/IncludeInserterTest.cpp:101 @@ -100,3 +100,3 @@ : IncludeInserterCheckBase(CheckName, Context) {} - virtual ~CXXSystemIncludeInserterCheck() {} + ~CXXSystemIncludeInserterCheck() override = default;

Re: [PATCH] D16578: [clang-tidy] bug fix: Don't warn on partial template specialization in `misc-definitions-in-headers` check.

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG. Do you need me to commit the patch? Repository: rL LLVM http://reviews.llvm.org/D16578 ___ cfe-commits mailing list cfe-commits@lists.llvm

r258815 - Revert "[Driver] Make sure -fno-math-builtin option is being passed by the driver."

Author: mcrosier Date: Tue Jan 26 10:16:53 2016 New Revision: 258815 URL: http://llvm.org/viewvc/llvm-project?rev=258815&view=rev Log: Revert "[Driver] Make sure -fno-math-builtin option is being passed by the driver." This reverts commit r258814. Modified: cfe/trunk/lib/Driver/Tools.cpp

[PATCH] D16584: [libcxx] Work around for clang calling GAS after having already failed.

dsanders created this revision. dsanders added reviewers: EricWF, mclow.lists, hans. dsanders added a subscriber: cfe-commits. This is a workaround to a clang bug which causes libcxx tests to fail in the 3.8 release. The clang bug is currently being investigated. It seems that clang does not stop

r258814 - [Driver] Make sure -fno-math-builtin option is being passed by the driver.

Author: mcrosier Date: Tue Jan 26 09:52:05 2016 New Revision: 258814 URL: http://llvm.org/viewvc/llvm-project?rev=258814&view=rev Log: [Driver] Make sure -fno-math-builtin option is being passed by the driver. Support for the -fno-math-builtin option was added in r186899. The codegen side is bei

Re: [PATCH] D16566: [Clang-tidy] Fix Clang-tidy modernize-use-override warning in unittests/clang-tidy/IncludeInserterTest.cpp; other minor fixes

On Mon, Jan 25, 2016 at 6:20 PM, Eugene Zelenko via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Eugene.Zelenko created this revision. > Eugene.Zelenko added reviewers: alexfh, aaron.ballman. > Eugene.Zelenko added a subscriber: cfe-commits. > Eugene.Zelenko set the repository for this revis

r258813 - [Driver] Update FIXME comment now that PR4941 has been addressed.

Author: mcrosier Date: Tue Jan 26 09:46:29 2016 New Revision: 258813 URL: http://llvm.org/viewvc/llvm-project?rev=258813&view=rev Log: [Driver] Update FIXME comment now that PR4941 has been addressed. The actual fix should be addressed by someone who can test on Darwin. Modified: cfe/trunk/l

Re: [PATCH] D16582: fix array index out of bounds

danielmarjamaki added reviewers: rnk, hans, chandlerc, majnemer. danielmarjamaki added a comment. adding reviewers according to 'svn blame' and CODE_OWNERS.txt Repository: rL LLVM http://reviews.llvm.org/D16582 ___ cfe-commits mailing list cfe-co

[PATCH] D16582: fix array index out of bounds

danielmarjamaki created this revision. danielmarjamaki added a subscriber: cfe-commits. danielmarjamaki set the repository for this revision to rL LLVM. This little patch fixes possible array index out of bounds: [tools/clang/lib/Driver/MSVCToolChain.cpp:147]: (error) Array 'partialKey[256]' acc

[PATCH] D16579: Warn if friend function depends on template parameters.

sepavloff created this revision. sepavloff added a subscriber: cfe-commits. Declaration of friend function may depend on template parameters, however it does not become a template function: template class C1 { friend void func(T x); }; It may be not obvious for user, so compiler co

Re: [PATCH] D16066: [clang-format] Add BeforeWhileInDoWhile BraceWrapping option

ebaker355 reclaimed this revision. ebaker355 added a comment. Ok, cool! :) Thanks! http://reviews.llvm.org/D16066 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D16066: [clang-format] Add BeforeWhileInDoWhile BraceWrapping option

djasper added a comment. Feel free to leave this patch around. Maybe somebody else comes up with something that meets the other criteria ;-). Me personally, I just think that seeing "while (1);" on a single line is quite misleading. But maybe that is just me. http://reviews.llvm.org/D16066

Re: [PATCH] D16376: clang-tidy check: Assignment and Construction

jbcoe retitled this revision from "clang-tidy check: User-defined copy without assignment" to "clang-tidy check: Assignment and Construction". jbcoe updated the summary for this revision. jbcoe set the repository for this revision to rL LLVM. jbcoe updated this revision to Diff 45987. jbcoe added

Re: [PATCH] D16066: [clang-format] Add BeforeWhileInDoWhile BraceWrapping option

ebaker355 abandoned this revision. ebaker355 added a comment. Since I cannot meet these criteria: - be used in a project of significant size (have dozens of contributors) - have a publicly accessible style guide I will abandon this revision request. Thank you for considering! http://reviews.ll

Re: [PATCH] D16365: Do not define GXX_RTTI macro for C

rsmith added a subscriber: rsmith. rsmith added a comment. LGTM, assuming this is the same behaviour as GCC. http://reviews.llvm.org/D16365 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co

Re: [PATCH] D16066: [clang-format] Add BeforeWhileInDoWhile BraceWrapping option

ebaker355 added a comment. Thanks for responding, and for the documentation link! It is certainly wise to not attempt "to supporting every single style used by a codebase somewhere in the wild." I do not know of a predefined coding style that recommends this format. My thinking was: - it comp

Re: [PATCH] D16365: Do not define GXX_RTTI macro for C

LGTM, assuming this is the same behaviour as GCC. On 26 Jan 2016 1:59 a.m., "Yunzhong Gao" wrote: > ygao added a comment. > > A gentle ping. > > > http://reviews.llvm.org/D16365 > > > > ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://list

Re: r258720 - [MSVC Compat] Only warn for unknown clang-cl arguments

Hi Renato, Thanks, Nico helped me diagnose and fix the test yesterday < http://lists.llvm.org/pipermail/cfe-commits/Week-of-Mon-20160125/147979.html>. I fixed the test accordingly in r258776 and that seems to have worked! Cheers, Ehsan On Tue, Jan 26, 2016 at 7:41 AM, Renato Golin wrote: > Hi,

Re: [PATCH] D16567: [Clang] Fix Clang-tidy modernize-use-nullptr warnings; other minor fixes

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rL LLVM http://reviews.llvm.org/D16567 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.ll

Re: [PATCH] D16566: [Clang-tidy] Fix Clang-tidy modernize-use-override warning in unittests/clang-tidy/IncludeInserterTest.cpp; other minor fixes

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rL LLVM http://reviews.llvm.org/D16566 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.ll

Re: [PATCH] D16066: [clang-format] Add BeforeWhileInDoWhile BraceWrapping option

djasper added a comment. Is there a coding style that actually recommends this? I would be quite doubtful that it is a good idea as it makes those loops harder to distinguish from other while loops. Generally, there is a certain bar to getting additional style flags into clang-format: http://cl

Re: r258720 - [MSVC Compat] Only warn for unknown clang-cl arguments

On Mon, Jan 25, 2016 at 09:14:52PM -, Ehsan Akhgari via cfe-commits wrote: > Author: ehsan > Date: Mon Jan 25 15:14:52 2016 > New Revision: 258720 > > URL: http://llvm.org/viewvc/llvm-project?rev=258720&view=rev > Log: > [MSVC Compat] Only warn for unknown clang-cl arguments > > Summary: > MS

Re: [PATCH] D16047: [OpenCL] Add Sema checks for OpenCL 2.0

Anastasia added a comment. Xiuli, do you still plan to continue here? I was just thinking if it would make sense to re-upload the review since the line numbers got broken due to full diff. Also it would be nice to partition to several independent commits/reviews. Let's say: - Blocks diagnosti

Re: [PATCH] D15721: [Sema] Fix ICE on casting a vector of bools to a vector of T

Anastasia added a comment. OpenCL side seems fine! Thanks for adding OpenCL diagnostic btw. I think we will also need to forbid the invalid conversions too at some point. Comment at: lib/Sema/SemaExpr.cpp:5715 @@ +5714,3 @@ + // when compiling code as e.g. C++) + uint64_t src

Re: [PATCH] D16040: [OpenCL] Refine OpenCLImageAccessAttr to OpenCLAccessAttr

Anastasia added inline comments. Comment at: lib/Sema/SemaDeclAttr.cpp:5705 @@ -5669,8 +5704,3 @@ - // Walk the declarator structure, applying decl attributes that were in a type - // position to the decl itself. This handles cases like: - // int *__attr__(x)** D; - // w

r258804 - [OPENMP 4.5] Allow arrays in 'reduction' clause.

Author: abataev Date: Tue Jan 26 06:20:39 2016 New Revision: 258804 URL: http://llvm.org/viewvc/llvm-project?rev=258804&view=rev Log: [OPENMP 4.5] Allow arrays in 'reduction' clause. OpenMP 4.5, alogn with array sections, allows to use variables of array type in reductions. Modified: cfe/tru

Re: [PATCH] D13126: New static analyzer checker for loss of sign/precision

danielmarjamaki marked 2 inline comments as done. danielmarjamaki added a comment. For information, I am testing this patch right now.. it will take a while 1-2 days. http://reviews.llvm.org/D13126 ___ cfe-commits mailing list cfe-commits@lists.llv

Re: [PATCH] D15897: [libc++] Silence warning about padding inserted at the tail of struct _Rep_base

joerg added a comment. As I said on IRC, it might be useful to set -Wpadding -Wno-error=padding, but I don't think the current state adds value. So removing the option is certainly an acceptable step forward to me. http://reviews.llvm.org/D15897 _

Re: [PATCH] D13126: New static analyzer checker for loss of sign/precision

danielmarjamaki updated this revision to Diff 45972. danielmarjamaki marked 2 inline comments as done. danielmarjamaki added a comment. fixed review comments, readded 'loss of sign' checking http://reviews.llvm.org/D13126 Files: lib/StaticAnalyzer/Checkers/CMakeLists.txt lib/StaticAnalyzer/

Re: [PATCH] D16536: Fix crashing on user-defined conversion.

alexfh added a comment. Thank you for the fix! Committed as r258801. Repository: rL LLVM http://reviews.llvm.org/D16536 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D16536: Fix crashing on user-defined conversion.

This revision was automatically updated to reflect the committed changes. Closed by commit rL258801: Fix crashing on user-defined conversion. (authored by alexfh). Changed prior to commit: http://reviews.llvm.org/D16536?vs=45873&id=45963#toc Repository: rL LLVM http://reviews.llvm.org/D1653

[clang-tools-extra] r258801 - Fix crashing on user-defined conversion.

Author: alexfh Date: Tue Jan 26 04:56:27 2016 New Revision: 258801 URL: http://llvm.org/viewvc/llvm-project?rev=258801&view=rev Log: Fix crashing on user-defined conversion. Summary: Fix the assertion failure for the user-defined conversion method. e.g.: operator bool() Reviewers: alexfh, aaron

[PATCH] D16572: PR23057: fix use-after-free due to local token buffer in ParseCXXAmbiguousParenExpression

DmitryPolukhin created this revision. DmitryPolukhin added a reviewer: rjmccall. DmitryPolukhin added a subscriber: cfe-commits. To completely eliminate use-after-free in this place I had to copy tokens into new array and pass ownership. As far as I understand the code it is not possible to guar

Re: [PATCH] D15373: Fix for bug 25786 - Assertion "Chunk.Kind == DeclaratorChunk::Function" failed with regparm attribute.

a.makarov added a comment. Ping http://reviews.llvm.org/D15373 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: r258720 - [MSVC Compat] Only warn for unknown clang-cl arguments

On 26 January 2016 at 01:56, Ehsan Akhgari wrote: > OK, I reverted the test in r258772. Thanks! Ok, the error code with no output will make for an interesting investigation... :) I'll try to collect as much info as possible. In the meantime, if you have any insights, just let me know. cheers,

Re: [PATCH] D15283: [ARMv8-M] Add Clang targeting for ARMv8-M Baseline/Mainline

bsmith added a comment. Now that the LLVM side of this is committed, it would be great to get this reviewed also, thanks. Repository: rL LLVM http://reviews.llvm.org/D15283 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llv

Re: [PATCH] D16310: new clang-tidy checker misc-long-cast

danielmarjamaki added a comment. For information I have now tested latest patch. Statistics: projects: 1804 files:85976 warnings: 100 There were some new interesting warnings and imho they were TP. http://reviews.llvm.org/D16310 ___ cfe-commit

Re: [PATCH] D16113: [clang-tdiy] Add header file extension configuration support.

hokein added a comment. ping @alexfh. http://reviews.llvm.org/D16113 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D16535: [clang-tidy] Check to find unintended semicolons that changes the semantics.

xazax.hun updated this revision to Diff 45949. xazax.hun added a comment. - Fixed the nits pointed out by the review. http://reviews.llvm.org/D16535 Files: clang-tidy/misc/CMakeLists.txt clang-tidy/misc/MiscTidyModule.cpp clang-tidy/misc/SuspiciousSemicolonCheck.cpp clang-tidy/misc/Susp

Re: [PATCH] D16535: [clang-tidy] Check to find unintended semicolons that changes the semantics.

xazax.hun marked 5 inline comments as done. xazax.hun added a comment. http://reviews.llvm.org/D16535 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D15636: Reduce false positives in printf/scanf format checker

AndyG added a comment. Hi Richard, Thank you for looking at my patch. I would argue that the code printf(minimal ? "%i\n" : "%i: %s\n", code, msg); is valid and should //not// cause a warning due to unused arguments since at least one code path uses all the arguments. This in my view is th

<    1   2