r258994 - ARMv7k: simplify logic for deciding sjlj-exceptions.

Author: tnorthover Date: Wed Jan 27 16:14:02 2016 New Revision: 258994 URL: http://llvm.org/viewvc/llvm-project?rev=258994=rev Log: ARMv7k: simplify logic for deciding sjlj-exceptions. Slight change of behaviour in the odd armv7+watchos case, which should match the other runtime components.

Re: [PATCH] D15999: Adding doxygen comments to the LLVM intrinsics (part 2, _wmmintrin_pclmul.h)

kromanova added a comment. In http://reviews.llvm.org/D15999#335653, @echristo wrote: > Honestly if they've been reviewed like that internally I'm ok with you just > committing them - especially if they look like this. > > The only concerns I'd have are in the case of "This intrinsic

Re: [PATCH] D15829: [PGO] Clang Option that enables IR level PGO instrumentation

davidxl added inline comments. Comment at: include/clang/Frontend/CodeGenOptions.def:106 @@ -105,3 +105,3 @@ -CODEGENOPT(ProfileInstrGenerate , 1, 0) ///< Instrument code to generate -///< execution counts to use with PGO.

Re: [PATCH] D15829: [PGO] Clang Option that enables IR level PGO instrumentation

silvas added inline comments. Comment at: lib/Frontend/CompilerInvocation.cpp:483 @@ +482,3 @@ +Opts.ProfileIRInstr = true; + else +// Opts.ClangProfInstrGen will be used for Clang instrumentation only. davidxl wrote: > silvas wrote: > > This still isn't

Re: [PATCH] D16605: Implement `std::experimental::ostream_joiner`

mclow.lists added inline comments. Comment at: include/experimental/iterator:62 @@ +61,3 @@ + +_LIBCPP_BEGIN_NAMESPACE_LFTS + EricWF wrote: > Wrong namespace. This gives `std::experimental::fundamentals_v2`. This brings > up the bigger question of how we want to

Re: [PATCH] D16529: [clang-tidy] Add modernize-raw-string-literal check

alexfh added inline comments. Comment at: clang-tidy/modernize/RawStringLiteralCheck.cpp:27 @@ +26,3 @@ + // we only transform ASCII string literals + if (!Literal->isAscii()) +return false; LegalizeAdulthood wrote: > alexfh wrote: > > Why can't the check

Re: [PATCH] D15999: Adding doxygen comments to the LLVM intrinsics (part 2, _wmmintrin_pclmul.h)

kromanova added a comment. In http://reviews.llvm.org/D15999#335653, @echristo wrote: > Honestly if they've been reviewed like that internally I'm ok with you just > committing them - especially if they look like this. > > The only concerns I'd have are in the case of "This intrinsic

Re: [PATCH] D15721: [Sema] Fix ICE on casting a vector of bools to a vector of T

This revision was automatically updated to reflect the committed changes. Closed by commit rL259011: [Sema] Make extended vectors of `bool` an error. (authored by gbiv). Changed prior to commit: http://reviews.llvm.org/D15721?vs=46088=46205#toc Repository: rL LLVM

r259011 - [Sema] Make extended vectors of `bool` an error.

Author: gbiv Date: Wed Jan 27 19:38:18 2016 New Revision: 259011 URL: http://llvm.org/viewvc/llvm-project?rev=259011=rev Log: [Sema] Make extended vectors of `bool` an error. In OpenCL, `bool` vectors are a reserved type, and are therefore illegal. Outside of OpenCL, if we try to make an

Re: [PATCH] D8822: Proposed fix for PR23076 (conditional branch debug line info)

dblaikie added a comment. Fair question on overloaded operators... Taking the original code: 1: int main() { 2: if ( 3: tr() 4: && 5: tr() 6: ) 7: func(); 8: if ( 9: fa() 10: && 11: tr() 12: ) 13: func(); 14: } & making tr/fa return a user defined type with

Re: [clang-tools-extra] r258926 - [clang-tidy] Fix documentation.

Thanks! On Wed, Jan 27, 2016 at 7:30 PM, Hans Wennborg wrote: > On Wed, Jan 27, 2016 at 3:37 AM, Alexander Kornienko via cfe-commits > wrote: > > Author: alexfh > > Date: Wed Jan 27 05:37:19 2016 > > New Revision: 258926 > > > > URL:

Re: [PATCH] D16605: Implement `std::experimental::ostream_joiner`

EricWF added inline comments. Comment at: include/experimental/iterator:85 @@ +84,3 @@ +template +ostream_joiner& operator=(const _Tp& __v) +{ EricWF wrote: > People are going to try and use this as an assignment operator. We either > need to static

r259000 - [sancov] sancov tool documentation

Author: aizatsky Date: Wed Jan 27 17:56:12 2016 New Revision: 259000 URL: http://llvm.org/viewvc/llvm-project?rev=259000=rev Log: [sancov] sancov tool documentation Differential Revision: http://reviews.llvm.org/D16432 Modified: cfe/trunk/docs/SanitizerCoverage.rst Modified:

Re: [PATCH] D16538: [cc1as] Add MCTargetOptions argument to createAsmBackend

echristo added a comment. Hi Joel, Since you're likely going to need to start filling in the Options there anyhow, can you lift the one from the TODO and start filling it in? -eric http://reviews.llvm.org/D16538 ___ cfe-commits mailing list

Re: [PATCH] D16605: Implement `std::experimental::ostream_joiner`

EricWF added a comment. - Please add the header to `test/libcxx/double_include.sh.cpp` - Please add a `_LIBCPP_VERSION` test in `test/libcxx/experimental/iterator` - The `ostream_joiner` type and it's members should be given visibility attributes. Comment at:

Re: [PATCH] D16605: Implement `std::experimental::ostream_joiner`

mclow.lists marked 4 inline comments as done. mclow.lists added a comment. http://reviews.llvm.org/D16605 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D16605: Implement `std::experimental::ostream_joiner`

mclow.lists updated this revision to Diff 46203. mclow.lists added a comment. Addressed Eric's comments. (at least some of them) http://reviews.llvm.org/D16605 Files: test/std/experimental/iterator/nothing_to_do.pass.cpp

r258997 - Strengthen cfi-check-fail test.

Author: eugenis Date: Wed Jan 27 16:28:56 2016 New Revision: 258997 URL: http://llvm.org/viewvc/llvm-project?rev=258997=rev Log: Strengthen cfi-check-fail test. r258993 allows stricter testing for basic block labels by making sure that they are always followed by ":". Use this to improve the

Re: [PATCH] D16605: Implement `std::experimental::ostream_joiner`

EricWF added a comment. One last thing. The spec implicitly defines the copy/move/assignment operators for "ostream_joiner" by making "_Delim" an exposition only member. Essentially "ostream_joiner" should only copy/moveable if "_Delim" is. I think we should add tests that ensure we actually

Re: [PATCH] D16664: [CUDA] Generate CUDA's printf alloca in its function's entry block.

echristo added inline comments. Comment at: lib/CodeGen/CGCUDABuiltin.cpp:109 @@ -106,1 +108,3 @@ +// stacksave/stackrestore intrinsics, which cause ptxas to choke. +auto *Alloca = new llvm::AllocaInst( llvm::Type::getInt8Ty(Ctx), llvm::ConstantInt::get(Int32Ty,

Re: [PATCH] D16605: Implement `std::experimental::ostream_joiner`

mclow.lists updated this revision to Diff 46210. mclow.lists added a comment. Add the tests that Eric suggested. Had to toss in a `decay`. http://reviews.llvm.org/D16605 Files: test/std/experimental/iterator/nothing_to_do.pass.cpp

RE: r258782 - Recommit: R258773 [OpenCL] Pipe builtin functions

Hi hans, Request to merge it to release 38 It adds Pipe BIFs to be used along with Pipe type committed earlier (in r257254). Thanks Xiuli -Original Message- From: cfe-commits [mailto:cfe-commits-boun...@lists.llvm.org] On Behalf Of Xiuli Pan via cfe-commits Sent: Tuesday, January 26,

Re: [PATCH] D16514: Add -stop-on-failure driver option, and enable it by default for CUDA compiles.

jlebar added a comment. Friendly ping. http://reviews.llvm.org/D16514 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r259016 - Revert r258951 (and r258950), "Refactor backend diagnostics for unsupported features"

Author: chapuni Date: Wed Jan 27 22:41:32 2016 New Revision: 259016 URL: http://llvm.org/viewvc/llvm-project?rev=259016=rev Log: Revert r258951 (and r258950), "Refactor backend diagnostics for unsupported features" It broke layering violation in LLVMIR. clang r258950 "Add backend dignostic

[PATCH] D16664: [CUDA] Generate CUDA's printf alloca in its function's entry block.

jlebar created this revision. jlebar added a reviewer: rnk. jlebar added subscribers: tra, echristo, jhen, cfe-commits. This is necessary to prevent llvm from generating stacksave intrinsics around this alloca. NVVM doesn't have a stack, and we don't handle said intrinsics. I'm not sure if

Re: [PATCH] D16605: Implement `std::experimental::ostream_joiner`

EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. LGTM. http://reviews.llvm.org/D16605 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D16673: Don't split NumericConstant tokens if a digit separator proceeds a period.

craig.topper created this revision. craig.topper added a reviewer: rsmith. craig.topper added a subscriber: cfe-commits. Currently we split a token if a digit separator proceeds a period. This causes the digit separator to be interpreted instead as the start of a character constant token. gcc

Re: [PATCH] D16634: [libcxx] Whitelist inclusion of sysctl.h instead of blacklisting

mclow.lists accepted this revision. mclow.lists added a comment. This revision is now accepted and ready to land. This looks fine to me. http://reviews.llvm.org/D16634 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[libcxx] r259023 - [libcxx] Remove pragmas that were needed to suppress warnings produced

Author: ahatanak Date: Thu Jan 28 00:13:36 2016 New Revision: 259023 URL: http://llvm.org/viewvc/llvm-project?rev=259023=rev Log: [libcxx] Remove pragmas that were needed to suppress warnings produced by -Wpadded. We don't need these pragmas anymore because -Wpadded was removed from buildit in

Re: [PATCH] D16634: [libcxx] Whitelist inclusion of sysctl.h instead of blacklisting

bcraig marked 2 inline comments as done. bcraig added a comment. http://reviews.llvm.org/D16634 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D16584: [libcxx] Work around for clang calling GAS after having already failed.

EricWF added a comment. I'm OK signing off on this myself. http://reviews.llvm.org/D16584 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D13420: Fix deduction of __atomic_load's parameter types.

EricWF added a comment. ping. http://reviews.llvm.org/D13420 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D15829: [PGO] Clang Option that enables IR level PGO instrumentation

xur updated this revision to Diff 46199. xur added a comment. This new version implemented the usage model David proposed. We now have a cc1 option -fprofile-instrumentor={llvm | clang} to choose which instrumentation to use. The slight difference from David's proposal is that we can use this

Re: [PATCH] D15829: [PGO] Clang Option that enables IR level PGO instrumentation

silvas added inline comments. Comment at: include/clang/Frontend/CodeGenOptions.def:106 @@ -105,3 +105,3 @@ -CODEGENOPT(ProfileInstrGenerate , 1, 0) ///< Instrument code to generate -///< execution counts to use with PGO.

Re: r258504 - Change of UserLabelPrefix default value from "_" to ""

Hi James, > I reverted this change with r258894, as it breaks (at least) sparc-rtems. Can you send me a reproducer, please? Right now I'm at a dead end -- no tests are broken, and no buildbots are reported any fails. Yet you claim that my patch breaks one target -- and there is zero info how to

Re: [PATCH] D16607: Implementation of PS4 ABI, round 1

probinson added a comment. Subscribed the reviewers of http://reviews.llvm.org/D14980, which had fixed the alignment-attribute layout bug. http://reviews.llvm.org/D16607 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D16632: clang-cl: Take dllexport from original function decl into account

sberg created this revision. sberg added a reviewer: rnk. sberg added a subscriber: cfe-commits. ...in cases where a member function is redeclared as a friend of a nested class. (LibreOffice happens to get tripped up by this.) http://reviews.llvm.org/D16632 Files:

Re: [PATCH] D14653: [libcxx] Introduce the mechanism for fixing -fno-exceptions test failures.

mclow.lists added inline comments. Comment at: include/__config:847 @@ +846,3 @@ +} +#define _LIBCPP_THROW(E, MSG) __libcxx_noexceptions_report(MSG) +#else // !_LIBCPP_NO_EXCEPTIONS I don't care for having to specify something twice. (E, MSG). Maybe

Re: [PATCH] D16628: clang-cl: support __cdecl-on-struct anachronism

rnk added inline comments. Comment at: lib/Parse/ParseDeclCXX.cpp:1108-1110 @@ -1106,1 +1107,5 @@ + case tok::kw___cdecl: // struct foo {...} __cdecl x; // C4229 +if (!getLangOpts().MicrosoftExt) + break; +// fall through // Type qualifiers

r258935 - Adding back in a test that I inadvertently removed in r258862

Author: cbieneman Date: Wed Jan 27 09:51:56 2016 New Revision: 258935 URL: http://llvm.org/viewvc/llvm-project?rev=258935=rev Log: Adding back in a test that I inadvertently removed in r258862 Added: cfe/trunk/test/SemaObjC/atomoic-property-synnthesis-rules.m Added:

Re: [PATCH] D16632: clang-cl: Take dllexport from original function decl into account

rnk added a subscriber: rnk. rnk added a comment. Hans knows all about dllexport now. http://reviews.llvm.org/D16632 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D15267: For MS ABI, emit dllexport friend functions defined inline in class

rnk added inline comments. Comment at: include/clang/AST/ASTConsumer.h:58-64 @@ -57,5 +57,9 @@ /// \brief This callback is invoked each time an inline method definition is /// completed. virtual void HandleInlineMethodDefinition(CXXMethodDecl *D) {} + /// \brief

Re: [PATCH] D15267: For MS ABI, emit dllexport friend functions defined inline in class

sberg added inline comments. Comment at: include/clang/AST/ASTConsumer.h:58-64 @@ -57,5 +57,9 @@ /// \brief This callback is invoked each time an inline method definition is /// completed. virtual void HandleInlineMethodDefinition(CXXMethodDecl *D) {} + /// \brief

Re: [PATCH] D16628: clang-cl: support __cdecl-on-struct anachronism

sberg updated this revision to Diff 46228. sberg added a comment. updated as discussed in the comments http://reviews.llvm.org/D16628 Files: lib/Parse/ParseDeclCXX.cpp test/Parser/ms-anachronism.c Index: test/Parser/ms-anachronism.c

Re: [PATCH] D16632: clang-cl: Take dllexport from original function decl into account

sberg added a comment. Yeah, my first naive finding when encountering the error was that it went away when unconditionally using FD->getCanonicalDecl() instead of FD in that if-else-if block. But that caused other parts of clang-test to fail. The current version passes all tests (happens to),

Re: [PATCH] D15267: For MS ABI, emit dllexport friend functions defined inline in class

sberg updated this revision to Diff 46227. sberg added a comment. updated as discussed in the comments http://reviews.llvm.org/D15267 Files: include/clang/AST/ASTConsumer.h include/clang/Frontend/MultiplexConsumer.h include/clang/Sema/Sema.h lib/CodeGen/CodeGenAction.cpp

Re: [clang-tools-extra] r258924 - Add clang-tools-extra documentation to the CMake build.

On Wed, Jan 27, 2016 at 3:37 AM, Alexander Kornienko via cfe-commits wrote: > Author: alexfh > Date: Wed Jan 27 05:37:08 2016 > New Revision: 258924 > > URL: http://llvm.org/viewvc/llvm-project?rev=258924=rev > Log: > Add clang-tools-extra documentation to the CMake

Re: [PATCH] D16628: clang-cl: support __cdecl-on-struct anachronism

majnemer added a subscriber: majnemer. Comment at: lib/Parse/ParseDeclCXX.cpp:1107 @@ +1106,3 @@ + // Microsoft compatibility + case tok::kw___cdecl: // struct foo {...} __cdecl x; // C4229 +if (!getLangOpts().MicrosoftExt) What about __fastcall,

Re: [PATCH] D15120: Add support for __float128 type to be used by targets that support it

rjmccall added a comment. I think it's not unlikely that float128_t will see future standardization (as an optional extension, of course), and it would be strange for an operation between two types to not consistently yield the type of higher rank. I could see an argument that we should not

r258950 - Add backend dignostic printer for unsupported features

Author: olista01 Date: Wed Jan 27 11:30:28 2016 New Revision: 258950 URL: http://llvm.org/viewvc/llvm-project?rev=258950=rev Log: Add backend dignostic printer for unsupported features The related LLVM patch adds a backend diagnostic type for reporting unsupported features, this adds a printer

Re: [PATCH] D16591: Add backend dignostic printer for unsupported features

This revision was automatically updated to reflect the committed changes. Closed by commit rL258950: Add backend dignostic printer for unsupported features (authored by olista01). Changed prior to commit: http://reviews.llvm.org/D16591?vs=46127=46144#toc Repository: rL LLVM

Re: [PATCH] D16632: clang-cl: Take dllexport from original function decl into account

hans added a comment. Hi Stephan, I would rather see that we could get this right in the AST. The problem is that the Befriended::func() definition doesn't have dllexport attached: `-CXXMethodDecl 0x5ba1cf0 parent 0x5b4f288 prev 0x5b4f750 col:18 used func 'void (void)'

Re: [PATCH] D16591: Add backend dignostic printer for unsupported features

ast accepted this revision. ast added a comment. This revision is now accepted and ready to land. thanks http://reviews.llvm.org/D16591 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D16607: Implementation of PS4 ABI, round 1

rjmccall added a comment. Seems reasonable. http://reviews.llvm.org/D16607 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D16586: Make clang AAPCS compliant w.r.t volatile bitfield accesses

rmaprath added inline comments. Comment at: lib/CodeGen/CGExpr.cpp:1761 @@ +1760,3 @@ +Ptr = Address(AdjustAAPCSBitfieldAccess(Dst, Info, false), + getContext().getTypeAlignInChars(Dst.getType())); + rjmccall wrote: > This alignment

Re: [PATCH] D16628: clang-cl: support __cdecl-on-struct anachronism

sberg added inline comments. Comment at: lib/Parse/ParseDeclCXX.cpp:1107 @@ +1106,3 @@ + // Microsoft compatibility + case tok::kw___cdecl: // struct foo {...} __cdecl x; // C4229 +if (!getLangOpts().MicrosoftExt) majnemer wrote: > What about

Re: [PATCH] D15267: For MS ABI, emit dllexport friend functions defined inline in class

rnk added inline comments. Comment at: include/clang/AST/ASTConsumer.h:58-64 @@ -57,5 +57,9 @@ /// \brief This callback is invoked each time an inline method definition is /// completed. virtual void HandleInlineMethodDefinition(CXXMethodDecl *D) {} + /// \brief

Re: [PATCH] D16628: clang-cl: support __cdecl-on-struct anachronism

majnemer added inline comments. Comment at: lib/Parse/ParseDeclCXX.cpp:1107 @@ +1106,3 @@ + // Microsoft compatibility + case tok::kw___cdecl: // struct foo {...} __cdecl x; // C4229 +if (!getLangOpts().MicrosoftExt) sberg wrote: > majnemer wrote:

Re: [clang-tools-extra] r258926 - [clang-tidy] Fix documentation.

On Wed, Jan 27, 2016 at 3:37 AM, Alexander Kornienko via cfe-commits wrote: > Author: alexfh > Date: Wed Jan 27 05:37:19 2016 > New Revision: 258926 > > URL: http://llvm.org/viewvc/llvm-project?rev=258926=rev > Log: > [clang-tidy] Fix documentation. > > Fixed broken

[clang-tools-extra] r258960 - docs/conf.py: update copyright year

Author: hans Date: Wed Jan 27 12:29:16 2016 New Revision: 258960 URL: http://llvm.org/viewvc/llvm-project?rev=258960=rev Log: docs/conf.py: update copyright year Modified: clang-tools-extra/trunk/docs/conf.py Modified: clang-tools-extra/trunk/docs/conf.py URL:

r258962 - Emit calls to objc_unsafeClaimAutoreleasedReturnValue when

Author: rjmccall Date: Wed Jan 27 12:32:30 2016 New Revision: 258962 URL: http://llvm.org/viewvc/llvm-project?rev=258962=rev Log: Emit calls to objc_unsafeClaimAutoreleasedReturnValue when reclaiming a call result in order to ignore it or assign it to an __unsafe_unretained variable. This avoids

Re: [PATCH] D15829: [PGO] Clang Option that enables IR level PGO instrumentation

davidxl added inline comments. Comment at: lib/Driver/Tools.cpp:5520 @@ +5519,3 @@ +A->claim(); +if ((StringRef(A->getValue(0)) == "-fprofile-ir-instr") && +(Args.hasArg(options::OPT_fprofile_instr_generate) || silvas wrote: > This is definitely

Re: [PATCH] D16634: [libcxx] Whitelist inclusion of sysctl.h instead of blacklisting

bcraig added a comment. Added cfe-commits to subscriber list. http://reviews.llvm.org/D16634 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D16639: [libcxx] Limit catopen usage to unix-like OSes

bcraig created this revision. bcraig added reviewers: mclow.lists, ed, jfb, EricWF, jroelofs. bcraig added a subscriber: cfe-commits. Herald added subscribers: srhines, danalbert, tberghammer, jfb. Operating systems that are not unix-like are unlikely to have access to catopen. Instead of

Re: [PATCH] D16638: [CUDA] Added device-side std::{malloc/free}

jlebar accepted this revision. This revision is now accepted and ready to land. Comment at: lib/Headers/__clang_cuda_cmath.h:222 @@ +221,3 @@ +__DEVICE__ void free(void *__ptr) { return ::free(__ptr); } +__DEVICE__ void *malloc(size_t __size) { return ::malloc(__size); } +

[PATCH] D16638: [CUDA] Added device-side std::{malloc/free}

tra created this revision. tra added a reviewer: jlebar. tra added a subscriber: cfe-commits. In addition to math functions, we also need to support std::malloc and std::free to match NVCC behavior. http://reviews.llvm.org/D16638 Files: lib/Headers/__clang_cuda_cmath.h

Re: [PATCH] D15829: [PGO] Clang Option that enables IR level PGO instrumentation

Sean: Adding a new CC1 option ProfileClangInstr will make things cleaner. But this won't solve the problem. The root of all the mess is there is no driver level option for IR instrumentation. I need to either "hijack" the -Xclang option, or move the logic to CompilerInvocation.cpp, which both you

Re: [PATCH] D15120: Add support for __float128 type to be used by targets that support it

hubert.reinterpretcast added a comment. In http://reviews.llvm.org/D15120#337384, @rjmccall wrote: > I think it's not unlikely that float128_t will see future standardization (as > an optional extension, of course), and it would be strange for an operation > between two types to not

LLVM buildmaster will be restarted tonight

Hello everyone, LLVM buildmaster will be updated and restarted after 6 PM Pacific time today. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D15829: [PGO] Clang Option that enables IR level PGO instrumentation

On Wed, Jan 27, 2016 at 11:31 AM, David Li wrote: > davidxl added inline comments. > > > Comment at: lib/Driver/Tools.cpp:5520 > @@ +5519,3 @@ > +A->claim(); > +if ((StringRef(A->getValue(0)) == "-fprofile-ir-instr") && > +

Re: [PATCH] D16310: new clang-tidy checker misc-long-cast

LegalizeAdulthood added a comment. In http://reviews.llvm.org/D16310#335844, @danielmarjamaki wrote: > There were some new interesting warnings and imho they were TP. TP? http://reviews.llvm.org/D16310 ___ cfe-commits mailing list

Re: [PATCH] D16012: Carry raw string literal information through to the AST StringLiteral representation

LegalizeAdulthood added a subscriber: LegalizeAdulthood. LegalizeAdulthood added a comment. In http://reviews.llvm.org/D16012#337208, @rsmith wrote: > What's the benefit of storing this? You can get the same effect by > re-lexing. We don't guarantee that the pretty printed version of the AST >

Re: [PATCH] D16529: [clang-tidy] Add modernize-raw-string-literal check

LegalizeAdulthood added inline comments. Comment at: clang-tidy/modernize/RawStringLiteralCheck.cpp:107 @@ +106,3 @@ + if (const auto *Literal = Result.Nodes.getNodeAs("lit")) +preferRawStringLiterals(Result, Literal); +} alexfh wrote: > I don't see a reason

r258981 - clang-format: [Java] Remove unnecessary line break after complex annotations

Author: djasper Date: Wed Jan 27 14:14:23 2016 New Revision: 258981 URL: http://llvm.org/viewvc/llvm-project?rev=258981=rev Log: clang-format: [Java] Remove unnecessary line break after complex annotations Before: @Annotation("Some" + " text") List list; After:

Re: [PATCH] D15120: Add support for __float128 type to be used by targets that support it

hubert.reinterpretcast added a comment. In http://reviews.llvm.org/D15120#337384, @rjmccall wrote: > I think it's not unlikely that float128_t will see future standardization (as > an optional extension, of course), and it would be strange for an operation > between two types to not

Re: [PATCH] D16529: [clang-tidy] Add modernize-raw-string-literal check

LegalizeAdulthood added inline comments. Comment at: clang-tidy/modernize/RawStringLiteralCheck.cpp:27 @@ +26,3 @@ + // we only transform ASCII string literals + if (!Literal->isAscii()) +return false; alexfh wrote: > Why can't the check convert non-ascii

Re: [PATCH] D15829: [PGO] Clang Option that enables IR level PGO instrumentation

We first need to nail the use model of the option, and then talk about implementation. To clarify, I think the following should be the way: (assuming the current clang instrumetnation is the default): 1) To turn on clang based instrumentation: -fprofile-instr-generate[=] 2) To turn on clang

r258976 - ARMv7k: select ABI based on v7k Arch rather than watchos OS.

Author: tnorthover Date: Wed Jan 27 13:32:40 2016 New Revision: 258976 URL: http://llvm.org/viewvc/llvm-project?rev=258976=rev Log: ARMv7k: select ABI based on v7k Arch rather than watchos OS. Various bits we'd like to use the new ABI actually compile with "-arch armv7k

r258979 - Class Property: handle class properties.

Author: mren Date: Wed Jan 27 14:00:32 2016 New Revision: 258979 URL: http://llvm.org/viewvc/llvm-project?rev=258979=rev Log: Class Property: handle class properties. At places where we handle instance properties, if necessary. rdar://23891898 Modified: cfe/trunk/lib/AST/DeclObjC.cpp

Re: [PATCH] D16529: [clang-tidy] Add modernize-raw-string-literal check

aaron.ballman added inline comments. Comment at: clang-tidy/modernize/RawStringLiteralCheck.cpp:57 @@ +56,3 @@ + + // already a raw string literal if R comes before " + if (Text.find_first_of("R") < Text.find_first_of(R"(")")) LegalizeAdulthood wrote: > alexfh

r258980 - Class Property: create accessors (class methods) for class property.

Author: mren Date: Wed Jan 27 14:10:32 2016 New Revision: 258980 URL: http://llvm.org/viewvc/llvm-project?rev=258980=rev Log: Class Property: create accessors (class methods) for class property. Change a few places where we assume property accessors can only be instance methods. rdar://23891898

Re: [PATCH] D16639: [libcxx] Limit catopen usage to unix-like OSes

ed added a comment. I'm usually not a big fan of using definitions such as `__unix__`, because it is pretty vague and defined inconsistently. That said, if you're going to use this definition, then there is some good news: CloudABI doesn't define it, meaning that you could just remove it from

Re: [PATCH] D15120: Add support for __float128 type to be used by targets that support it

rjmccall added a comment. In http://reviews.llvm.org/D15120#337552, @hubert.reinterpretcast wrote: > In http://reviews.llvm.org/D15120#337384, @rjmccall wrote: > > > I think it's not unlikely that float128_t will see future standardization > > (as an optional extension, of course), and it would

r259022 - [Lex] Share some common code between decimal and octal parsing in NumericLiteralParser.

Author: ctopper Date: Wed Jan 27 23:22:54 2016 New Revision: 259022 URL: http://llvm.org/viewvc/llvm-project?rev=259022=rev Log: [Lex] Share some common code between decimal and octal parsing in NumericLiteralParser. There were a couple slight variations between the two copies that I don't

Re: [PATCH] D15120: Add support for __float128 type to be used by targets that support it

nemanjai added a comment. Thank you for the discussion on rank. I'm glad we have an agreement on the rank of the two types. However, considering __float128 already has a higher rank in this patch, is there anything else that you would like me to change here before the patch is approved? Do

[clang-tools-extra] r258925 - [clang-tidy] Use relative URL for redirection.

Author: alexfh Date: Wed Jan 27 05:37:12 2016 New Revision: 258925 URL: http://llvm.org/viewvc/llvm-project?rev=258925=rev Log: [clang-tidy] Use relative URL for redirection. Modified: clang-tools-extra/trunk/docs/clang-tidy.rst Modified: clang-tools-extra/trunk/docs/clang-tidy.rst URL:

[clang-tools-extra] r258924 - Add clang-tools-extra documentation to the CMake build.

Author: alexfh Date: Wed Jan 27 05:37:08 2016 New Revision: 258924 URL: http://llvm.org/viewvc/llvm-project?rev=258924=rev Log: Add clang-tools-extra documentation to the CMake build. Added: clang-tools-extra/trunk/docs/CMakeLists.txt clang-tools-extra/trunk/docs/doxygen.cfg.in

[clang-tools-extra] r258926 - [clang-tidy] Fix documentation.

Author: alexfh Date: Wed Jan 27 05:37:19 2016 New Revision: 258926 URL: http://llvm.org/viewvc/llvm-project?rev=258926=rev Log: [clang-tidy] Fix documentation. Fixed broken links to cppcoreguidelines (anchors specified in the .md file should be used, not automatic anchors generated by github).

Re: [PATCH] D15721: [Sema] Fix ICE on casting a vector of bools to a vector of T

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. Seems sensible. LGTM! http://reviews.llvm.org/D15721 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D16298: Improve test coverage of -Wdouble-promotion

rob.lougher added a comment. Ping. http://reviews.llvm.org/D16298 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r258918 - Update for LLVM change.

Author: d0k Date: Wed Jan 27 04:01:30 2016 New Revision: 258918 URL: http://llvm.org/viewvc/llvm-project?rev=258918=rev Log: Update for LLVM change. Modified: cfe/trunk/lib/Parse/ParseStmtAsm.cpp cfe/trunk/tools/driver/cc1as_main.cpp Modified: cfe/trunk/lib/Parse/ParseStmtAsm.cpp URL:

[libcxx] r258920 - [libcxx] Additional 'REQUIRE' directives for tests that require en_US.UTF-8.

Author: dsanders Date: Wed Jan 27 04:45:07 2016 New Revision: 258920 URL: http://llvm.org/viewvc/llvm-project?rev=258920=rev Log: [libcxx] Additional 'REQUIRE' directives for tests that require en_US.UTF-8. Summary: These are the tests that didn't fail in the release candidate because they were

Re: [PATCH] D15120: Add support for __float128 type to be used by targets that support it

hubert.reinterpretcast added a comment. In http://reviews.llvm.org/D15120#337144, @nemanjai wrote: > Do you suggest that we need to allow operations (or at least assignments) > between the two types and take away the diagnostics that are part of this > patch? My overriding concern at this

[PATCH] D16628: clang-cl: support __cdecl-on-struct anachronism

sberg created this revision. sberg added a reviewer: rnk. sberg added a subscriber: cfe-commits. The Microsoft compiler emits warning C4229: anachronism used : modifiers on data are ignored for struct {} __cdecl s; but ICU's gendict can generate such (and does when building LibreOffice),

Re: r258504 - Change of UserLabelPrefix default value from "_" to ""

Yes, I understand this -- but the whole idea of my patch is to change the blanket default, on the whole table. Rafael believes this is the right thing to do (actually, he is the one who requested the change), and judging by feedback on PR26255, he is right. Please let me know when you'll add the

Re: [PATCH] D15920: [CMake] Add option to switch default C++ stdlib

Hahnfeld added a reviewer: mcrosier. Hahnfeld added a comment. Any comments on this change? http://reviews.llvm.org/D15920 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D16219: PR8901: attribute "mode" rejected for enums and dependent types

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Aside from one nitpick about the diagnostic wording, this LGTM. Comment at: include/clang/Basic/Attr.td:882 @@ -881,3 +881,3 @@ let Spellings =

Re: [PATCH] D16012: Carry raw string literal information through to the AST StringLiteral representation

What's the benefit of storing this? You can get the same effect by re-lexing. We don't guarantee that the pretty printed version of the AST comprises the same sequence of tokens in general. On 27 Jan 2016 3:03 p.m., "Aaron Ballman via cfe-commits" < cfe-commits@lists.llvm.org> wrote: >

Re: [PATCH] D16591: Add backend dignostic printer for unsupported features

olista01 removed rL LLVM as the repository for this revision. olista01 updated this revision to Diff 46127. olista01 added a comment. Added a test for the new diagnostic printer. http://reviews.llvm.org/D16591 Files: include/clang/Basic/DiagnosticFrontendKinds.td

Re: [PATCH] D16012: Carry raw string literal information through to the AST StringLiteral representation

On Wed, Jan 27, 2016 at 9:08 AM, Richard Smith wrote: > What's the benefit of storing this? You can get the same effect by > re-lexing. We don't guarantee that the pretty printed version of the AST > comprises the same sequence of tokens in general. So we don't lose

  1   2   >