Re: [PATCH] D15450: Avoid double deletion in Clang driver.

CodeGen action defined in the unit test does not call HandleTranslationUnit, so the hack implemented in `BackendConsumer::HandleTranslationUnit` does not run and clang crashes. With the fix no crash occurs. Thanks, --Serge 2016-02-05 1:17 GMT+06:00 Serge Pavlov : >

Re: [PATCH] D16947: [PGO] assignment operator does not get profile data

On Tue, Feb 9, 2016 at 11:30 AM, David Blaikie wrote: > > > On Tue, Feb 9, 2016 at 11:26 AM, Xinliang David Li > wrote: >> >> On Tue, Feb 9, 2016 at 11:14 AM, David Blaikie wrote: >> > >> > >> > On Mon, Feb 8, 2016 at 9:23 PM, Xinliang

RE: [libcxx] r260235 - Introduce a cmake module to figure out whether we need to link with libatomic.

Hi Hans, Can we merge this on the 3.8 release branch? It fixes libcxx builds on MIPS by linking with libatomic when needed. Also, all the x86_64 and ARM buildbots for libcxx look good. Thanks, Vasileios From: cfe-commits

r260246 - Simplify EnterTokenStream API to make it more robust for memory management

Author: dblaikie Date: Tue Feb 9 12:52:09 2016 New Revision: 260246 URL: http://llvm.org/viewvc/llvm-project?rev=260246=rev Log: Simplify EnterTokenStream API to make it more robust for memory management While this won't help fix things like the bug that r260219 addressed, it seems like good

Re: [PATCH] D16947: [PGO] assignment operator does not get profile data

On Tue, Feb 9, 2016 at 11:14 AM, David Blaikie wrote: > > > On Mon, Feb 8, 2016 at 9:23 PM, Xinliang David Li > wrote: >> >> Wrong in the sense the the coverage result for the default operators >> (the line where they are declared) is marked as if they are

Re: [PATCH] D17034: Add an AST matcher for null pointers

aaron.ballman added inline comments. Comment at: include/clang/ASTMatchers/ASTMatchers.h:4821 @@ +4820,3 @@ +/// initializer for i. +AST_MATCHER(Expr, nullPointerConstant) { + return Matcher( sbenza wrote: > sbenza wrote: > > Use AST_MATCHER_FUNCTION instead,

r260253 - [libclang] indexing: for a synthesized property reference have the parent be the ObjC implementation decl.

Author: akirtzidis Date: Tue Feb 9 13:07:19 2016 New Revision: 260253 URL: http://llvm.org/viewvc/llvm-project?rev=260253=rev Log: [libclang] indexing: for a synthesized property reference have the parent be the ObjC implementation decl. Modified:

r260250 - [libclang] indexing: Have the semantic container of synthesized ObjC getter/setter methods be the implementation decl.

Author: akirtzidis Date: Tue Feb 9 13:07:07 2016 New Revision: 260250 URL: http://llvm.org/viewvc/llvm-project?rev=260250=rev Log: [libclang] indexing: Have the semantic container of synthesized ObjC getter/setter methods be the implementation decl. Matches the behavior of other ObjC methods.

r260251 - [ASTUnit] Change the parameter of ASTUnit::LoadFromCompilerInvocationAction to accept a more general FrontendAction.

Author: akirtzidis Date: Tue Feb 9 13:07:13 2016 New Revision: 260251 URL: http://llvm.org/viewvc/llvm-project?rev=260251=rev Log: [ASTUnit] Change the parameter of ASTUnit::LoadFromCompilerInvocationAction to accept a more general FrontendAction. Modified:

r260252 - [Frontend] Handle ASTConsumer::shouldSkipFunctionBody via the MultiplexConsumer.

Author: akirtzidis Date: Tue Feb 9 13:07:16 2016 New Revision: 260252 URL: http://llvm.org/viewvc/llvm-project?rev=260252=rev Log: [Frontend] Handle ASTConsumer::shouldSkipFunctionBody via the MultiplexConsumer. Modified: cfe/trunk/include/clang/Frontend/MultiplexConsumer.h

r260255 - [libclang] indexing: make sure to not visit init-list expressions twice.

Author: akirtzidis Date: Tue Feb 9 13:07:24 2016 New Revision: 260255 URL: http://llvm.org/viewvc/llvm-project?rev=260255=rev Log: [libclang] indexing: make sure to not visit init-list expressions twice. Modified: cfe/trunk/test/Index/index-refs.cpp

Re: Patch for Bug 26283: float.h is missing mandatory C11 fp macros like DBL_DECIMAL_DIG and LDBL_DECIMAL_DIG

I see no immediate issue with this patch, but I am not one of the usual reviewers for this part of the code base. -- HT On Tue, Feb 9, 2016 at 2:56 PM, Jorge Teixeira wrote: > Thanks Hubert. Somehow I omitted that prefix when typing the macros, > and I did not

Re: Patch for Bug 26283: float.h is missing mandatory C11 fp macros like DBL_DECIMAL_DIG and LDBL_DECIMAL_DIG

Thanks Hubert. Somehow I omitted that prefix when typing the macros, and I did not noticed it when I was testing because on my arch DECIMAL_DIG is defined to be the LDBL version... Updated patch is attached. JT On Tue, Feb 9, 2016 at 1:41 PM, Hubert Tong

Re: [PATCH] D15861: Support fully-qualified names for all QualTypes

I've updated the change. Would you mind checking it in? I'll look into switching the implementations shortly. On Tue, Feb 9, 2016 at 11:02 AM, Sterling Augustine wrote: > saugustine updated this revision to Diff 47343. > saugustine added a comment. > > - Cleanup dyn_cast

r260266 - clang-cl: Enable plugins on Windows

Author: ehsan Date: Tue Feb 9 13:43:13 2016 New Revision: 260266 URL: http://llvm.org/viewvc/llvm-project?rev=260266=rev Log: clang-cl: Enable plugins on Windows Modified: cfe/trunk/test/Frontend/plugins.c cfe/trunk/test/lit.cfg Modified: cfe/trunk/test/Frontend/plugins.c URL:

r260265 - clang-cl: Support loading plugins on Windows

Author: ehsan Date: Tue Feb 9 13:43:11 2016 New Revision: 260265 URL: http://llvm.org/viewvc/llvm-project?rev=260265=rev Log: clang-cl: Support loading plugins on Windows This builds on the support being added to LLVM to import and export registries from DLLs. This will allow us to pick up the

Re: Need to use function "getAsCXXRecordDecl" of ASTMatchFinder.cpp in a clang-tidy check

On Tue, Feb 9, 2016 at 9:03 AM, Cong Liu via cfe-commits wrote: > Hi Richard, > > I need to use the function (line 747 of ASTMatchFinder.cpp): > > static CXXRecordDecl *getAsCXXRecordDecl(const Type *TypeNode) > > in the misc-virtual-near-miss check of clang-tidy,

Re: Patch for Bug 26283: float.h is missing mandatory C11 fp macros like DBL_DECIMAL_DIG and LDBL_DECIMAL_DIG

There is a __LDBL_DECIMAL_DIG__ predefined macro. __DECIMAL_DIG__ will not always be the same as __LDBL_DECIMAL_DIG__. -- HT On Mon, Feb 8, 2016 at 11:26 PM, Jorge Teixeira via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Hi, I filed the bug (https://llvm.org/bugs/show_bug.cgi?id=26283)

Re: [PATCH] D17034: Add an AST matcher for null pointers

sbenza added inline comments. Comment at: include/clang/ASTMatchers/ASTMatchers.h:4821 @@ +4820,3 @@ +/// initializer for i. +AST_MATCHER(Expr, nullPointerConstant) { + return Matcher( aaron.ballman wrote: > aaron.ballman wrote: > > sbenza wrote: > > > sbenza

r260270 - [PGO] Fix issue: explicitly defaulted assignop is not profiled

Author: davidxl Date: Tue Feb 9 14:02:59 2016 New Revision: 260270 URL: http://llvm.org/viewvc/llvm-project?rev=260270=rev Log: [PGO] Fix issue: explicitly defaulted assignop is not profiled Differential Revision: http://reviews.llvm.org/D16947 Added:

Re: [PATCH] D16947: [PGO] assignment operator does not get profile data

On Mon, Feb 8, 2016 at 9:23 PM, Xinliang David Li wrote: > Wrong in the sense the the coverage result for the default operators > (the line where they are declared) is marked as if they are not called > which can be confusing to the user. > Presumably a user would have the

Re: [PATCH] D17034: Add an AST matcher for null pointers

sbenza added inline comments. Comment at: include/clang/ASTMatchers/ASTMatchers.h:4821 @@ +4820,3 @@ +/// initializer for i. +AST_MATCHER(Expr, nullPointerConstant) { + return Matcher( Use AST_MATCHER_FUNCTION instead, where the return value is the matcher

Re: [PATCH] D16947: [PGO] assignment operator does not get profile data

This revision was automatically updated to reflect the committed changes. Closed by commit rL260270: [PGO] Fix issue: explicitly defaulted assignop is not profiled (authored by davidxl). Changed prior to commit: http://reviews.llvm.org/D16947?vs=47239=47351#toc Repository: rL LLVM

Re: r260267 - Pass /bigobj when building lib/ASTMatchers/Dynamic/Registry.cpp

On Tue, Feb 9, 2016 at 2:53 PM, Reid Kleckner via cfe-commits wrote: > Author: rnk > Date: Tue Feb 9 13:53:30 2016 > New Revision: 260267 > > URL: http://llvm.org/viewvc/llvm-project?rev=260267=rev > Log: > Pass /bigobj when building

[clang-tools-extra] r260212 - [clang-tidy] Replace a custom ASTMatcher with a built-in one.

Author: xazax Date: Tue Feb 9 03:26:11 2016 New Revision: 260212 URL: http://llvm.org/viewvc/llvm-project?rev=260212=rev Log: [clang-tidy] Replace a custom ASTMatcher with a built-in one. Modified: clang-tools-extra/trunk/clang-tidy/readability/ContainerSizeEmptyCheck.cpp Modified:

r260218 - Add AST matcher reference to documentation directory when building HTML docs.

Author: klimek Date: Tue Feb 9 04:59:21 2016 New Revision: 260218 URL: http://llvm.org/viewvc/llvm-project?rev=260218=rev Log: Add AST matcher reference to documentation directory when building HTML docs. Modified: cfe/trunk/docs/CMakeLists.txt Modified: cfe/trunk/docs/CMakeLists.txt URL:

[PATCH] D17021: Adding doxygen comments to the LLVM intrinsics (part 5, f16cintrin.h)

kromanova created this revision. kromanova added reviewers: ygao, probinson, echristo, gribozavr, craig.topper, jroelofs. kromanova added a subscriber: cfe-commits. kromanova set the repository for this revision to rL LLVM. Eric Christopher told me that from now on it's OK to commit doxygen

Re: [PATCH] D16873: Refactor MemRegionManager::getVarRegion to call two new functions, improving readability

a.sidorin added a comment. Hello Alexander, Yes, types in `static_cast` should be changed. So, you need only to change return type and types in static_cast, and it should work. http://reviews.llvm.org/D16873 ___ cfe-commits mailing list

r260215 - [OPENMP] Allow to use the variable in the same 'threadprivate'

Author: abataev Date: Tue Feb 9 03:41:42 2016 New Revision: 260215 URL: http://llvm.org/viewvc/llvm-project?rev=260215=rev Log: [OPENMP] Allow to use the variable in the same 'threadprivate' directive. Modified: cfe/trunk/lib/Sema/SemaOpenMP.cpp Modified: cfe/trunk/lib/Sema/SemaOpenMP.cpp

r260214 - Do not mark variable as threadprivate if it was marked already.

Author: abataev Date: Tue Feb 9 03:41:33 2016 New Revision: 260214 URL: http://llvm.org/viewvc/llvm-project?rev=260214=rev Log: Do not mark variable as threadprivate if it was marked already. Modified: cfe/trunk/lib/Sema/SemaOpenMP.cpp Modified: cfe/trunk/lib/Sema/SemaOpenMP.cpp URL:

r260213 - [OPENMP] Allow to reference threadprivate variable in same directive.

Author: abataev Date: Tue Feb 9 03:41:09 2016 New Revision: 260213 URL: http://llvm.org/viewvc/llvm-project?rev=260213=rev Log: [OPENMP] Allow to reference threadprivate variable in same directive. Modified: cfe/trunk/lib/Sema/SemaOpenMP.cpp

[clang-tools-extra] r260217 - [clang-tidy] Make readability-container-size-empty work with inline namespaces. Fix PR25812.

Author: xazax Date: Tue Feb 9 04:20:48 2016 New Revision: 260217 URL: http://llvm.org/viewvc/llvm-project?rev=260217=rev Log: [clang-tidy] Make readability-container-size-empty work with inline namespaces. Fix PR25812. Modified:

Re: [PATCH] D16183: Added CheckName field to YAML report

Elijah_Th added a comment. YAML report looks like this now: --- MainSourceFile: '' Diagnostics: CheckName: misc-macro-parentheses Replacements: - FilePath:/media/SSD_/code/zdoom/main_1.cpp Offset: 1354 Length: 0 ReplacementText:

Re: [PATCH] D16613: Introduce a cmake module to figure out whether we need to link with libatomic.

dsanders accepted this revision. dsanders added a comment. LGTM http://reviews.llvm.org/D16613 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D15373: Fix for bug 25786 - Assertion "Chunk.Kind == DeclaratorChunk::Function" failed with regparm attribute.

a.makarov added a comment. Richard, Reid, please take a look. http://reviews.llvm.org/D15373 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: r260077 - [OPENMP 4.5] Ccapture/codegen of private non-static data members.

Hi Alexey, It's still broken on ARM: http://lab.llvm.org:8011/builders/clang-cmake-armv7-a15-full/builds/10409 cheers, --renato On 8 February 2016 at 14:25, Alexey Bataev via cfe-commits wrote: > Ok, thanks a lot! Hope it will fix win-based buildbots completely. >

r260219 - Fix possible OOB access found by buildbot

Author: abataev Date: Tue Feb 9 05:01:58 2016 New Revision: 260219 URL: http://llvm.org/viewvc/llvm-project?rev=260219=rev Log: Fix possible OOB access found by buildbot Modified: cfe/trunk/lib/Frontend/PrintPreprocessedOutput.cpp Modified:

Re: [PATCH] D15920: [CMake] Add option to switch default C++ stdlib

Hahnfeld added a comment. ping http://reviews.llvm.org/D15920 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D16183: Added CheckName field to YAML report

Elijah_Th updated this revision to Diff 47302. Elijah_Th added a comment. Fixed YAML format (was not correct in the last patch). Grouped replacements in YAML by Diagnostics. It will help to apply replacements for one fix at once. http://reviews.llvm.org/D16183 Files:

r260211 - Fixed preprocessed output of the first token for pragmas.

Author: abataev Date: Tue Feb 9 02:51:26 2016 New Revision: 260211 URL: http://llvm.org/viewvc/llvm-project?rev=260211=rev Log: Fixed preprocessed output of the first token for pragmas. Clang did not expanded macros in the very first token of the pragmas during preprocessed output Modified:

Re: [PATCH] D16524: [clang-format-vs] Fix sort include main include: Use current path for the '-assume-filename'

klimek accepted this revision. klimek added a comment. This revision is now accepted and ready to land. lg http://reviews.llvm.org/D16524 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D16308: clang-tidy Enhance readability-simplify-boolean-expr check to handle implicit conversions of integral types to bool and member pointers

LegalizeAdulthood added a comment. In article , Aaron Ballman writes: > aaron.ballman added a comment. > > This is causing build bot failures: > >

Re: [PATCH] D16953: Enhance clang-tidy modernize-redundant-void-arg check to apply fixes to header files

LegalizeAdulthood marked an inline comment as done. Comment at: test/clang-tidy/check_clang_tidy.py:152 @@ -68,4 +151,3 @@ - has_check_fixes = input_text.find('CHECK-FIXES') >= 0 - has_check_messages = input_text.find('CHECK-MESSAGES') >= 0 + has_check_fixes,

r260222 - Registering the gnuNullExpr AST matcher as a dynamic matcher so that it is available from clang-query.

Author: aaronballman Date: Tue Feb 9 08:04:49 2016 New Revision: 260222 URL: http://llvm.org/viewvc/llvm-project?rev=260222=rev Log: Registering the gnuNullExpr AST matcher as a dynamic matcher so that it is available from clang-query. Modified:

Re: [clang-tools-extra] r260217 - [clang-tidy] Make readability-container-size-empty work with inline namespaces. Fix PR25812.

Now that I submitted the fix to hasName(), I'll work on adding hasAnyName. On Tue, Feb 9, 2016 at 6:54 AM, Alexander Kornienko wrote: > I think, we need to add a `hasAnyName()` matcher that would take a list of > names. > > On Tue, Feb 9, 2016 at 11:20 AM, Gabor Horvath via

Re: [PATCH] D16535: [clang-tidy] Check to find unintended semicolons that changes the semantics.

xazax.hun updated this revision to Diff 47316. xazax.hun added a comment. - Fixed the cases pointed out by the review. http://reviews.llvm.org/D16535 Files: clang-tidy/misc/CMakeLists.txt clang-tidy/misc/MiscTidyModule.cpp clang-tidy/misc/SuspiciousSemicolonCheck.cpp

[clang-tools-extra] r260223 - [clang-tidy] Add 'misc-misplaced-widening-cast' check.

Author: danielmarjamaki Date: Tue Feb 9 08:08:49 2016 New Revision: 260223 URL: http://llvm.org/viewvc/llvm-project?rev=260223=rev Log: [clang-tidy] Add 'misc-misplaced-widening-cast' check. Reviewers: alexfh Subscribers: cfe-commits Differential Revision: http://reviews.llvm.org/D16310

Re: [PATCH] D16535: [clang-tidy] Check to find unintended semicolons that changes the semantics.

xazax.hun added a comment. Thank you, good catches! http://reviews.llvm.org/D16535 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D16308: clang-tidy Enhance readability-simplify-boolean-expr check to handle implicit conversions of integral types to bool and member pointers

In article , Aaron Ballman writes: > aaron.ballman added a comment. > > This is causing build bot failures: > > http://bb.pgr.jp/builders/cmake-clang-tools-x86_64-linux/builds/23351 >

Re: [PATCH] D16953: Enhance clang-tidy modernize-redundant-void-arg check to apply fixes to header files

LegalizeAdulthood updated this revision to Diff 47319. LegalizeAdulthood added a comment. Update from review comments http://reviews.llvm.org/D16953 Files: clang-tidy/modernize/RedundantVoidArgCheck.cpp test/clang-tidy/check_clang_tidy.py test/clang-tidy/modernize-redundant-void-arg.cpp

r260220 - [OPENMP] Fix test incompatibility with arm buildbots.

Author: abataev Date: Tue Feb 9 06:16:42 2016 New Revision: 260220 URL: http://llvm.org/viewvc/llvm-project?rev=260220=rev Log: [OPENMP] Fix test incompatibility with arm buildbots. Modified: cfe/trunk/test/OpenMP/parallel_private_codegen.cpp Modified:

Re: [PATCH] D16922: [clang-tidy] Added check-fixes for misc-virtual-near-miss.

congliu updated this revision to Diff 47307. congliu added a comment. - Disallowed matches for method in template instantiations. Updated test. http://reviews.llvm.org/D16922 Files: clang-tidy/misc/VirtualNearMissCheck.cpp test/clang-tidy/misc-virtual-near-miss.cpp Index:

Re: r260077 - [OPENMP 4.5] Ccapture/codegen of private non-static data members.

Renato, Will be fixed ASAP Best regards, Alexey Bataev = Software Engineer Intel Compiler Team 09.02.2016 14:07, Renato Golin пишет: > Hi Alexey, > > It's still broken on ARM: > > http://lab.llvm.org:8011/builders/clang-cmake-armv7-a15-full/builds/10409 > > cheers, > --renato > > >

Re: [clang-tools-extra] r260217 - [clang-tidy] Make readability-container-size-empty work with inline namespaces. Fix PR25812.

I think, we need to add a `hasAnyName()` matcher that would take a list of names. On Tue, Feb 9, 2016 at 11:20 AM, Gabor Horvath via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: xazax > Date: Tue Feb 9 04:20:48 2016 > New Revision: 260217 > > URL:

Re: [PATCH] D16535: [clang-tidy] Check to find unintended semicolons that changes the semantics.

hokein added inline comments. Comment at: clang-tidy/misc/SuspiciousSemicolonCheck.cpp:23 @@ +22,3 @@ + Finder->addMatcher( + stmt(anyOf(ifStmt(hasThen(nullStmt().bind("semi"))), + forStmt(hasBody(nullStmt().bind("semi"))), Looks like this

Re: r259931 - [SystemZ] Define __GCC_HAVE_SYNC_COMPARE_AND_SWAP macros

Hal Finkel wrote on 09.02.2016 04:59:21: > We generally notice this when we try to use some part of the C++ > standard library (std::atomic or std::thread as I recall). Could we > have something in the test-suite that uses that functionality in a > way likely to expose this bug?

Patch for Bug 26283: float.h is missing mandatory C11 fp macros like DBL_DECIMAL_DIG and LDBL_DECIMAL_DIG

Hi, I filed the bug (https://llvm.org/bugs/show_bug.cgi?id=26283) some time ago and nobody picked it up, so here is a trivial patch exposing the missing macros, that to the best of my ability were already present as the internal underscored versions. Perhaps a more general bug about C11 floating

Re: [PATCH] D16639: [libcxx] Limit catopen usage to unix-like OSes

mclow.lists added a comment. I don't have a problem with this change (assuming that it is correct, and it looks correct), but I think it should stay in __config, with all the other configuration tests. (There are other configuration tests in the .cpp files, but users never see those). FWIW,

[clang-tools-extra] r260225 - [clang-tidy] Add -target in misc-misplaced-widening-cast test so it will work on various bots

Author: danielmarjamaki Date: Tue Feb 9 09:43:05 2016 New Revision: 260225 URL: http://llvm.org/viewvc/llvm-project?rev=260225=rev Log: [clang-tidy] Add -target in misc-misplaced-widening-cast test so it will work on various bots Modified:

Re: [PATCH] D15539: [libcxxabi] Reducing stack usage of test

mclow.lists added a comment. I think you've reduced the scope of the tests significantly with this change. If you want to make the objects smaller, that's fine - but please heed Howard's advice in the email thread: - Don't make them too small. (three digits is better than two) - Keep the

Re: [PATCH] D15539: [libcxxabi] Reducing stack usage of test

bcraig added a comment. Any objections to using the original sizes, but constructing the objects at global scope? That fixes the stack usage without significantly changing the layout characteristics of the test? http://reviews.llvm.org/D15539

Re: [PATCH] D16351: [FIX] Bug 25404 - Crash on typedef in OpenCL 2.0

Anastasia added inline comments. Comment at: test/SemaOpenCL/implicit-typedef.cl:1 @@ +1,2 @@ +// RUN: %clang_cc1 %s -DTEST_WARNINGS -cl-std=CL2.0 -verify -pedantic -fsyntax-only -Wsystem-headers +// RUN: %clang_cc1 %s -cl-std=CL2.0 -fsyntax-only do you need

Re: [PATCH] D15920: [CMake] Add option to switch default C++ stdlib

beanz added a comment. Is it correct to assume that all the test case changes are needed just to make the tests pass if you set CLANG_DEFAULT_CXX_STDLIB=libc++? I'm not really comfortable approving this patch because I've made all of one or two changes ever to the driver, but I can try to

Re: [PATCH] D15539: [libcxxabi] Reducing stack usage of test

bcraig updated the summary for this revision. bcraig updated this revision to Diff 47327. http://reviews.llvm.org/D15539 Files: test/dynamic_cast14.pass.cpp Index: test/dynamic_cast14.pass.cpp === --- test/dynamic_cast14.pass.cpp

Re: [PATCH] D16535: [clang-tidy] Check to find unintended semicolons that changes the semantics.

hokein added inline comments. Comment at: docs/clang-tidy/checks/misc-suspicious-semicolon.rst:35 @@ +34,3 @@ + +if(x >= y); +x -= y; The doc needs to be updated. With your latest patch, this is also a warning case. http://reviews.llvm.org/D16535

Re: [PATCH] D15465: [git-clang-format]: New option to perform formatting against staged changes only

lodato added inline comments. Comment at: git-clang-format:124 @@ -121,3 +123,3 @@ del opts.quiet commit, files = interpret_args(opts.args, dash_dash, opts.commit) lodato wrote: > This will work without `--diff` (otherwise it will try to apply changes in

Re: [PATCH] D16963: Copy LibASTMatchersReference.html to gen'd docs

sdowney added a subscriber: sdowney. sdowney added a comment. I'll push up a review with the one line link addition later. Thanks! The html copy should also get applied to the release_38 branch too, if there's going to be another RC. http://reviews.llvm.org/D16963

Re: [PATCH] D16922: [clang-tidy] Added check-fixes for misc-virtual-near-miss.

alexfh added inline comments. Comment at: clang-tidy/misc/VirtualNearMissCheck.cpp:183 @@ +182,3 @@ +/// +/// This function is copied from the one defined in ASTMatchFinder.cpp to solve +/// the problem that QualType::getAsCXXRecordDecl does not work for template

Re: [clang-tools-extra] r260225 - [clang-tidy] Add -target in misc-misplaced-widening-cast test so it will work on various bots

I'm not sure this is a good fix. What was the specific issue (and on which buildbots)? On Tue, Feb 9, 2016 at 4:43 PM, Daniel Marjamaki via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: danielmarjamaki > Date: Tue Feb 9 09:43:05 2016 > New Revision: 260225 > > URL:

Re: [PATCH] D15465: [git-clang-format]: New option to perform formatting against staged changes only

lodato added a subscriber: lodato. lodato requested changes to this revision. lodato added a reviewer: lodato. lodato added a comment. This revision now requires changes to proceed. This does not work properly because it calls `clang-format` on the files in the working directory, even if

Need to use function "getAsCXXRecordDecl" of ASTMatchFinder.cpp in a clang-tidy check

Hi Richard, I need to use the function (line 747 of ASTMatchFinder.cpp ): static CXXRecordDecl *getAsCXXRecordDecl(const Type *TypeNode) in the misc-virtual-near-miss check of clang-tidy, because it can correctly get the

Re: [PATCH] D16963: Copy LibASTMatchersReference.html to gen'd docs

I'll push up a review with the one line link addition later. Thanks! The html copy should also get applied to the release_38 branch too, if there's going to be another RC. On Tue, Feb 9, 2016 at 11:52 AM Manuel Klimek wrote: > klimek added a subscriber: klimek. > klimek

Re: [PATCH] D16963: Copy LibASTMatchersReference.html to gen'd docs

klimek added a subscriber: klimek. klimek added a comment. I have fixed that in r260218 for LibASTMatcherReference (basically using the same mechanism, but only copying the one file). Not sure which is the better approach, I considered globbing, but my gut feeling decided against it :)

Re: [PATCH] D16639: [libcxx] Limit catopen usage to unix-like OSes

bcraig updated the summary for this revision. bcraig updated this revision to Diff 47328. bcraig added a comment. Moved the CATOPEN config check back to __config. Saving a larger locale refactor for later (but oh boy is it coming). http://reviews.llvm.org/D16639 Files: include/__config

Re: [PATCH] D16613: Introduce a cmake module to figure out whether we need to link with libatomic.

This revision was automatically updated to reflect the committed changes. Closed by commit rL260235: Introduce a cmake module to figure out whether we need to link with libatomic. (authored by vkalintiris). Changed prior to commit: http://reviews.llvm.org/D16613?vs=46286=47329#toc Repository:

[libcxx] r260235 - Introduce a cmake module to figure out whether we need to link with libatomic.

Author: vkalintiris Date: Tue Feb 9 11:00:38 2016 New Revision: 260235 URL: http://llvm.org/viewvc/llvm-project?rev=260235=rev Log: Introduce a cmake module to figure out whether we need to link with libatomic. Summary: This fixes the tests under std/atomics for 32-bit MIPS CPUs where the

Re: RFC: Update Intel386, x86-64 and IA MCU psABIs for passing/returning empty struct

On Tue, Feb 9, 2016 at 6:45 AM, H.J. Lu wrote: > On Mon, Feb 8, 2016 at 3:28 PM, Richard Smith wrote: >> On Mon, Feb 8, 2016 at 3:01 PM, H.J. Lu wrote: >>> On Mon, Feb 8, 2016 at 2:58 PM, Richard Smith

Re: [PATCH] D15829: [PGO] Clang Option that enables IR level PGO instrumentation

xur updated this revision to Diff 47331. xur added a comment. Ping (also added the test that missed from last upload). Thanks, -Rong http://reviews.llvm.org/D15829 Files: include/clang/Driver/CC1Options.td include/clang/Frontend/CodeGenOptions.h lib/CodeGen/BackendUtil.cpp

Re: [PATCH] D16947: [PGO] assignment operator does not get profile data

dblaikie added inline comments. Comment at: cfe/trunk/test/Profile/def-assignop.cpp:27 @@ +26,3 @@ + +int main() { + A a1, a2; This doesn't need to be main or have an int return. Just make it a void function (with some generic name) & drop the "return 0" to

r260276 - Fix the test added in r260266

Author: ehsan Date: Tue Feb 9 14:49:24 2016 New Revision: 260276 URL: http://llvm.org/viewvc/llvm-project?rev=260276=rev Log: Fix the test added in r260266 Modified: cfe/trunk/test/Frontend/plugins.c Modified: cfe/trunk/test/Frontend/plugins.c URL:

Re: Patch for Bug 26283: float.h is missing mandatory C11 fp macros like DBL_DECIMAL_DIG and LDBL_DECIMAL_DIG

Patch looks good. Please also add a testcase to test/Headers. On Tue, Feb 9, 2016 at 12:08 PM, Hubert Tong via cfe-commits wrote: > I see no immediate issue with this patch, but I am not one of the usual > reviewers for this part of the code base. > > -- HT > > > On

Re: r260267 - Pass /bigobj when building lib/ASTMatchers/Dynamic/Registry.cpp

On Tue, Feb 9, 2016 at 3:59 PM, Reid Kleckner wrote: > On Tue, Feb 9, 2016 at 12:32 PM, Aaron Ballman > wrote: >> >> On Tue, Feb 9, 2016 at 2:53 PM, Reid Kleckner via cfe-commits >> wrote: >> > Author: rnk >> > Date: Tue Feb

Re: [PATCH] D15373: Fix for bug 25786 - Assertion "Chunk.Kind == DeclaratorChunk::Function" failed with regparm attribute.

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. Thanks, lgtm! http://reviews.llvm.org/D15373 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[libclc] r260303 - configure: Remove cl_khr_fp64 for device that don't support doubles

Author: jvesely Date: Tue Feb 9 16:17:46 2016 New Revision: 260303 URL: http://llvm.org/viewvc/llvm-project?rev=260303=rev Log: configure: Remove cl_khr_fp64 for device that don't support doubles Also remove definitions if provided by clang (3.7+) This halves the size of

[libclc] r260301 - math: Fix log2 vectorization on non-fp64 hw

Author: jvesely Date: Tue Feb 9 16:17:42 2016 New Revision: 260301 URL: http://llvm.org/viewvc/llvm-project?rev=260301=rev Log: math: Fix log2 vectorization on non-fp64 hw reviewer: tstellard Signed-off-by: Jan Vesely Modified: libclc/trunk/generic/lib/math/log2.cl

r260311 - Update documentation to reflect that libc++abi provides __cxa_thread_atexit (and has for quite a while). Also document that we have not yet implemented the new inheriting constructor rules.

Author: rsmith Date: Tue Feb 9 16:48:14 2016 New Revision: 260311 URL: http://llvm.org/viewvc/llvm-project?rev=260311=rev Log: Update documentation to reflect that libc++abi provides __cxa_thread_atexit (and has for quite a while). Also document that we have not yet implemented the new

Re: [PATCH] D16524: [clang-format-vs] Fix sort include main include: Use current path for the '-assume-filename'

jeanphilippeD added a comment. Hi Manuel, Thank you very much for the review. I do not have commit access, would you be able to commit this patch for me. Kind Regards, Jean-Philippe http://reviews.llvm.org/D16524 ___ cfe-commits mailing list

Re: [PATCH] D16947: [PGO] assignment operator does not get profile data

On Tue, Feb 9, 2016 at 12:07 PM, David Li via llvm-commits < llvm-comm...@lists.llvm.org> wrote: > This revision was automatically updated to reflect the committed changes. > Closed by commit rL260270: [PGO] Fix issue: explicitly defaulted assignop > is not profiled (authored by davidxl). > In

r260307 - PR26349: correctly check whether a digit sequence is empty in the presence of digit separators.

Author: rsmith Date: Tue Feb 9 16:34:35 2016 New Revision: 260307 URL: http://llvm.org/viewvc/llvm-project?rev=260307=rev Log: PR26349: correctly check whether a digit sequence is empty in the presence of digit separators. Modified: cfe/trunk/include/clang/Lex/LiteralSupport.h

Re: r260267 - Pass /bigobj when building lib/ASTMatchers/Dynamic/Registry.cpp

On Tue, Feb 9, 2016 at 12:32 PM, Aaron Ballman wrote: > On Tue, Feb 9, 2016 at 2:53 PM, Reid Kleckner via cfe-commits > wrote: > > Author: rnk > > Date: Tue Feb 9 13:53:30 2016 > > New Revision: 260267 > > > > URL:

Re: [PATCH] D17002: [lanai] Add Lanai backend to clang driver

eliben added a subscriber: eliben. eliben added a comment. Clang-level tests? Comment at: lib/Basic/Targets.cpp:5873 @@ +5872,3 @@ +"-m:e" // ELF name manging +"-p:32:32" // 32-bit pointers work aligned +"-i64:64" // 64 bit integers, 64 bit

r260278 - Add Tooling functionality to get a name for a QualType that can be used to name

Author: rsmith Date: Tue Feb 9 15:04:04 2016 New Revision: 260278 URL: http://llvm.org/viewvc/llvm-project?rev=260278=rev Log: Add Tooling functionality to get a name for a QualType that can be used to name that type from the global scope. Patch by Sterling Augustine, derived (with permission)

[libclc] r260302 - configure: Introduce per device defines

Author: jvesely Date: Tue Feb 9 16:17:45 2016 New Revision: 260302 URL: http://llvm.org/viewvc/llvm-project?rev=260302=rev Log: configure: Introduce per device defines Make cl_khr_fp64 define per-device. This patch does not change the generated Makefile (for llvm 3.6, 3.7) v2: Make the device

[libclc] r260304 - configure: Remove llvm 3.6 defines

Author: jvesely Date: Tue Feb 9 16:17:48 2016 New Revision: 260304 URL: http://llvm.org/viewvc/llvm-project?rev=260304=rev Log: configure: Remove llvm 3.6 defines we require llvm 3.7 reviewer: tstellard Signed-off-by: Jan Vesely Modified: libclc/trunk/configure.py

r260277 - Simplify and rename ASTMatchFinder's getCXXRecordDecl to make it more obvious

Author: rsmith Date: Tue Feb 9 14:59:05 2016 New Revision: 260277 URL: http://llvm.org/viewvc/llvm-project?rev=260277=rev Log: Simplify and rename ASTMatchFinder's getCXXRecordDecl to make it more obvious what it's actually trying to do. Modified:

Re: [PATCH] D15861: Support fully-qualified names for all QualTypes

rsmith closed this revision. rsmith added a comment. In r260278. http://reviews.llvm.org/D15861 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D15861: Support fully-qualified names for all QualTypes

saugustine updated this revision to Diff 47343. saugustine added a comment. - Cleanup dyn_cast usage inside QualTypeNames. http://reviews.llvm.org/D15861 Files: include/clang/Tooling/Core/QualTypeNames.h lib/Tooling/Core/CMakeLists.txt lib/Tooling/Core/QualTypeNames.cpp

Re: [PATCH] D16947: [PGO] assignment operator does not get profile data

On Tue, Feb 9, 2016 at 11:26 AM, Xinliang David Li wrote: > On Tue, Feb 9, 2016 at 11:14 AM, David Blaikie wrote: > > > > > > On Mon, Feb 8, 2016 at 9:23 PM, Xinliang David Li > > wrote: > >> > >> Wrong in the sense the the coverage

Re: [PATCH] D16947: [PGO] assignment operator does not get profile data

On Tue, Feb 9, 2016 at 11:41 AM, Xinliang David Li wrote: > On Tue, Feb 9, 2016 at 11:30 AM, David Blaikie wrote: > > > > > > On Tue, Feb 9, 2016 at 11:26 AM, Xinliang David Li > > wrote: > >> > >> On Tue, Feb 9, 2016 at 11:14 AM,

Re: [PATCH] D16947: [PGO] assignment operator does not get profile data

On Tue, Feb 9, 2016 at 11:44 AM, David Blaikie wrote: > > > On Tue, Feb 9, 2016 at 11:41 AM, Xinliang David Li > wrote: >> >> On Tue, Feb 9, 2016 at 11:30 AM, David Blaikie wrote: >> > >> > >> > On Tue, Feb 9, 2016 at 11:26 AM,

  1   2   >