Re: [PATCH] D17130: Debloat some headers

ariccio added a comment. In http://reviews.llvm.org/D17130#349744, @craig.topper wrote: > What's complex about the SVal constructors? I arbitrarily figured that classes that are more than twice-derived (is there a better way to say that) are complex. I don't think there was any

Re: [PATCH] D16535: [clang-tidy] Check to find unintended semicolons that changes the semantics.

xazax.hun added a comment. In http://reviews.llvm.org/D16535#348469, @alexfh wrote: > Could you run the check on LLVM and post here a summary of results: how many > warnings are generated, whether there are any false positives (based on a > reasonably-sized random sample, if there are too many

Re: [PATCH] D16535: [clang-tidy] Check to find unintended semicolons that changes the semantics.

This revision was automatically updated to reflect the committed changes. Closed by commit rL260503: [clang-tidy] Add a check to find unintended semicolons that changes the… (authored by xazax). Changed prior to commit: http://reviews.llvm.org/D16535?vs=47446=47604#toc Repository: rL LLVM

Re: [PATCH] D17130: Debloat some headers

ariccio added inline comments. Comment at: llvm/tools/clang/include/clang/StaticAnalyzer/Core/PathSensitive/CoreEngine.h:143 @@ -144,3 +142,3 @@ void addAbortedBlock(const ExplodedNode *node, const CFGBlock *block) { -blocksAborted.push_back(std::make_pair(block, node));

[clang-tools-extra] r260503 - [clang-tidy] Add a check to find unintended semicolons that changes the semantics.

Author: xazax Date: Thu Feb 11 03:23:33 2016 New Revision: 260503 URL: http://llvm.org/viewvc/llvm-project?rev=260503=rev Log: [clang-tidy] Add a check to find unintended semicolons that changes the semantics. Reviewers: hokein, alexfh Differential Revision: http://reviews.llvm.org/D16535

RE: [libcxx] r260235 - Introduce a cmake module to figure out whether we need to link with libatomic.

Hi, In my latests rc2+patches build I've also found that we need to rename HAVE_CXX_ATOMICS_WITH_LIB to something like LIBCXX_HAVE_CXX_ATOMICS_WITH_LIB. It's currently re-using the result of LLVM's check which doesn't include 64-bit atomics. From:

Re: [PATCH] D17149: Consolidate and improve the handling of built-in feature-like macros

AndyG added a comment. To be honest, the simple answer is because it was just as easy to do with nesting as without (the code would still need to track the appearance of left and right parentheses in order to correctly parse to the closing right-parenthesis of the macro invocation in any

Re: [PATCH] D15920: [CMake] Add option to switch default C++ stdlib

This revision was automatically updated to reflect the committed changes. Closed by commit rL260662: [CMake] Add option to switch default C++ stdlib (authored by Hahnfeld). Changed prior to commit: http://reviews.llvm.org/D15920?vs=47441=47770#toc Repository: rL LLVM

r260662 - [CMake] Add option to switch default C++ stdlib

Author: hahnfeld Date: Fri Feb 12 01:48:37 2016 New Revision: 260662 URL: http://llvm.org/viewvc/llvm-project?rev=260662=rev Log: [CMake] Add option to switch default C++ stdlib With this option one can optionally override the architecture dependent default library to use if no -stdlib= is

r260661 - tests: Add explicit -stdlib=libstdc++ to tests that require it

Author: hahnfeld Date: Fri Feb 12 01:48:28 2016 New Revision: 260661 URL: http://llvm.org/viewvc/llvm-project?rev=260661=rev Log: tests: Add explicit -stdlib=libstdc++ to tests that require it This will be needed for the next commit that allows to switch the default C++ library which would

Re: [PATCH] D15920: [CMake] Add option to switch default C++ stdlib

Hahnfeld added a comment. In http://reviews.llvm.org/D15920#350401, @beanz wrote: > Can you commit the test changes in a separate commit before committing the > other changes? That way if something goes wrong the diff for the meat of the > patch is a small diff. Committed seperately in

Re: [PATCH] D17140: [clang-tidy] improve misc-misplaced-widening-cast so it also detects portability problems

This revision was automatically updated to reflect the committed changes. Closed by commit rL260665: [clang-tidy] improve misc-misplaced-widening-cast so it also detects… (authored by danielmarjamaki). Changed prior to commit: http://reviews.llvm.org/D17140?vs=47640=47771#toc Repository: rL

[clang-tools-extra] r260665 - [clang-tidy] improve misc-misplaced-widening-cast so it also detects portability problems.

Author: danielmarjamaki Date: Fri Feb 12 01:51:10 2016 New Revision: 260665 URL: http://llvm.org/viewvc/llvm-project?rev=260665=rev Log: [clang-tidy] improve misc-misplaced-widening-cast so it also detects portability problems. Reviewers: alexfh Subscribers: cfe-commits Differential Revision:

Re: [PATCH] D17132: [libcxx] Fix definition of regex_traits::__regex_word on big-endian glibc systems

dsanders added inline comments. Comment at: include/regex:980 @@ +979,3 @@ +#if defined(__GLIBC__) +static const char_class_type __regex_word = static_cast(_ISbit(15)); +#else The static_cast is necessary to silence a false-positive warning on

r260506 - Update of "GCC extensions not implemented yet" in Clang User's Manual

Author: asbokhan Date: Thu Feb 11 04:36:06 2016 New Revision: 260506 URL: http://llvm.org/viewvc/llvm-project?rev=260506=rev Log: Update of "GCC extensions not implemented yet" in Clang User's Manual #pragma weak, global register variables and static initialization of flexible array members are

Re: [PATCH] D16851: Update of "GCC extensions not implemented yet" in Clang User's Manual

This revision was automatically updated to reflect the committed changes. Closed by commit rL260506: Update of "GCC extensions not implemented yet" in Clang User's Manual (authored by asbokhan). Changed prior to commit: http://reviews.llvm.org/D16851?vs=46779=47615#toc Repository: rL LLVM

Re: RFC: Update Intel386, x86-64 and IA MCU psABIs for passing/returning empty struct

On Thu, Feb 11, 2016 at 2:47 AM, Matthijs van Duin wrote: > On 8 February 2016 at 22:40, H.J. Lu wrote: >> "empty type". An empty type is either an array of empty types or a >> class type where every member is of empty type. > > Note that the term

Re: [PATCH] D16545: [libcxxabi] Enable testing for static libc++abi

bcraig added a comment. ping http://reviews.llvm.org/D16545 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D16544: [libcxx] Framework to allow testing of static libc++abi

bcraig added a comment. ping http://reviews.llvm.org/D16544 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: RFC: Update Intel386, x86-64 and IA MCU psABIs for passing/returning empty struct

On Thu, Feb 11, 2016 at 6:30 AM, Michael Matz wrote: > Hi, > > On Thu, 11 Feb 2016, Jonathan Wakely wrote: > >> On 11 February 2016 at 12:40, Matthijs van Duin wrote: >> > You never define "POD for the purposes of layout", and I can only >> > interpret it as being equivalent to

Re: RFC: Update Intel386, x86-64 and IA MCU psABIs for passing/returning empty struct

Hi, On Thu, 11 Feb 2016, H.J. Lu wrote: > Any suggestions on new wording, something like > > 1. "class type". A class type is a structure, union or C++ class. > 2. "empty type". An empty type is a type where it and all of its > subobjects are of class or array type. > > Does it cover >

[PATCH] D17140: [clang-tidy] improve misc-misplaced-widening-cast so it also detects portability problems

danielmarjamaki created this revision. danielmarjamaki added a reviewer: alexfh. danielmarjamaki added a subscriber: cfe-commits. danielmarjamaki set the repository for this revision to rL LLVM. The misc-misplaced-widening-cast currently only looks at the size to determine if a cast is widening.

Re: [libcxx] r260515 - Re-commit "Introduce a cmake module to figure out whether we need to link with libatomic."

Hi Vasileios, This patch doesn't quite work correctly. I've committed a follow up fix to it as r260524. Let me know if you have any issues. /Eric On Thu, Feb 11, 2016 at 5:43 AM, Vasileios Kalintiris via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: vkalintiris > Date: Thu Feb 11

RE: [libcxx] r260515 - Re-commit "Introduce a cmake module to figure out whether we need to link with libatomic."

Hi Hans, Can we merge this on the release branch? It's a re-commit of D16613's patch with the an additional option (-gcc-toolchain) to the default flags, that we use in order to test support for atomics, when the user doesn't want to use the default/system GCC installation. Buildbots look good

Re: RFC: Update Intel386, x86-64 and IA MCU psABIs for passing/returning empty struct

Hi, On Thu, 11 Feb 2016, Jonathan Wakely wrote: > On 11 February 2016 at 12:40, Matthijs van Duin wrote: > > You never define "POD for the purposes of layout", and I can only > > interpret it as being equivalent to "standard-layout". > > As Richard pointed out, it's defined in the C++ ABI.

Re: [PATCH] D16922: [clang-tidy] Added check-fixes for misc-virtual-near-miss.

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. Looks good now. Thank you! http://reviews.llvm.org/D16922 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D15797: [clang-tidy] Fix readability-braces-around-statements assert failure

alexfh added a comment. An alternative fix has recently been committed. Can you run clang-tidy built after r260505 on your code? Repository: rL LLVM http://reviews.llvm.org/D15797 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D17148: [OPENMP] Basic teams directive implementation

ABataev added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:4378-4398 @@ +4377,23 @@ + + const OMPNumTeamsClause *NT = TD.getSingleClause(); + const OMPThreadLimitClause *TL = TD.getSingleClause(); + if (NT || TL) { +NumTeamsVal = (NT) ?

Re: [PATCH] D17170: [OPENMP] Codegen for distribute directive

ABataev added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.h:669-692 @@ -668,1 +668,26 @@ + /// \brief Schedule types for 'omp for' loops (these enumerators are taken from + /// the enum sched_type in kmp.h). + enum OpenMPSchedType { + /// \brief Lower

Re: [libcxx] r260337 - Fix overload sets of strchr, strpbrk, strrchr, memchr and strstr from

Argh, the glibc folks broke their string.h and wchar.h prototypes in this commit: https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=8e2e833ac4d6509b152d6b8d74d388725717c56f On Thu, Feb 11, 2016 at 11:02 AM, Ismail Donmez wrote: > Hi, > > On Wed, Feb 10, 2016 at 2:59 AM,

Re: [PATCH] D15920: [CMake] Add option to switch default C++ stdlib

beanz added a comment. Everything about this looks reasonable to me. Can you commit the test changes in a separate commit before committing the other changes? That way if something goes wrong the diff for the meat of the patch is a small diff. http://reviews.llvm.org/D15920

Re: r252114 - [modules] If we're given a module file, via -fmodule-file=, for a module, but

> On Feb 11, 2016, at 11:04 AM, Ben Langmuir wrote: > > FYI I changed this to early-exit again in r260563 to fix implicit builds. > It’s not safe to keep reading if we haven’t told ReadOptionsBlock to expect > failures, since it will itself early-exit, leaving the stream

r260577 - In C11, provide macros FLT_DECIMAL_DIG, DBL_DECIMAL_DIG, and LDBL_DECIMAL_DIG in .

Author: rsmith Date: Thu Feb 11 13:57:37 2016 New Revision: 260577 URL: http://llvm.org/viewvc/llvm-project?rev=260577=rev Log: In C11, provide macros FLT_DECIMAL_DIG, DBL_DECIMAL_DIG, and LDBL_DECIMAL_DIG in . Patch by Jorge Teixeira! Added: cfe/trunk/test/Headers/float.c Modified:

r260581 - Add parse+sema and regression test for OpenMP firstprivate clause of target directive

Author: cbertol Date: Thu Feb 11 14:12:28 2016 New Revision: 260581 URL: http://llvm.org/viewvc/llvm-project?rev=260581=rev Log: Add parse+sema and regression test for OpenMP firstprivate clause of target directive Added: cfe/trunk/test/OpenMP/target_firstprivate_messages.cpp Modified:

Re: [PATCH] D17076: [OPENMP] firstprivate clause for target

carlo.bertolli closed this revision. carlo.bertolli added a comment. Committed revision 260581. Repository: rL LLVM http://reviews.llvm.org/D17076 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D16040: [OpenCL] Refine OpenCLImageAccessAttr to OpenCLAccessAttr

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! @Pekka, any comments here? We will finalize it if not. Comment at: lib/Sema/SemaDeclAttr.cpp:5823 @@ -5788,8 +5822,3 @@ - // Walk the declarator structure,

Re: [PATCH] D17132: [libcxx] Fix definition of regex_traits::__regex_word on big-endian glibc systems

dsanders added a comment. I haven't fully proven this yet (because I haven't found the table), but I think that C and C++ are sharing the same table and we're colliding with a bit that only makes sense to C. This would explain why your tests don't fail but regex_word still collides with

Re: [PATCH] D16946: Add link to llvm git documentation, and recommend always building libcxx on OSX

hintonda added a comment. Thanks Marshall. Btw, I don't have commit access, so if approved, could someone commit this for me? http://reviews.llvm.org/D16946 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r260567 - [PR26550] Use a different TBAA root for C++ vs C.

Author: mren Date: Thu Feb 11 13:19:18 2016 New Revision: 260567 URL: http://llvm.org/viewvc/llvm-project?rev=260567=rev Log: [PR26550] Use a different TBAA root for C++ vs C. This commit changes the root from "Simple C/C++ TBAA" to "Simple C++ TBAA" for C++. The problem is that the type name

Re: [PATCH] D16946: Add link to llvm git documentation, and recommend always building libcxx on OSX

mclow.lists added a comment. This looks fine to me. I think this should be committed. http://reviews.llvm.org/D16946 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: r252114 - [modules] If we're given a module file, via -fmodule-file=, for a module, but

FYI I changed this to early-exit again in r260563 to fix implicit builds. It’s not safe to keep reading if we haven’t told ReadOptionsBlock to expect failures, since it will itself early-exit, leaving the stream in the middle of a block. It’s also a performance advantage to early exit when

Re: Patch for Bug 26283: float.h is missing mandatory C11 fp macros like DBL_DECIMAL_DIG and LDBL_DECIMAL_DIG

Here is a revised test, which I renamed to c11-5_2_4_2_2p11.c instead of float.c because I am only checking a subset of what the standard mandates for float.h, and because there were similar precedents, like test/Preprocessor/c99-*.c. Feel free to override, though. The first part checks for basic

Re: [PATCH] D17132: [libcxx] Fix definition of regex_traits::__regex_word on big-endian glibc systems

mclow.lists added a comment. > ctype_base is defining graph by combining alnum and punct instead of using > the _IS* macro like the other bits. Because that's how the standard (22.4.1) shows to do it :-) > I'm not sure where it's getting the definition of classic_table. Presumably > it's

[libcxx] r260570 - Work around regression in glibc 2.22: request that glibc provides the correct

Author: rsmith Date: Thu Feb 11 13:40:06 2016 New Revision: 260570 URL: http://llvm.org/viewvc/llvm-project?rev=260570=rev Log: Work around regression in glibc 2.22: request that glibc provides the correct prototypes for functions that are converted into overload sets in C++. This matches the

Re: [libcxx] r260337 - Fix overload sets of strchr, strpbrk, strrchr, memchr and strstr from

Should be fixed in r260570. On Thu, Feb 11, 2016 at 11:28 AM, Richard Smith wrote: > Argh, the glibc folks broke their string.h and wchar.h prototypes in > this commit: > > https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=8e2e833ac4d6509b152d6b8d74d388725717c56f > > On

Re: [PATCH] D17148: [OPENMP] Basic teams directive implementation

carlo.bertolli removed rL LLVM as the repository for this revision. carlo.bertolli updated this revision to Diff 47695. carlo.bertolli added a comment. Remove handling of reductions - not supported by this patch. http://reviews.llvm.org/D17148 Files: lib/CodeGen/CGOpenMPRuntime.cpp

r260563 - [Modules] Early-exit if ReadOptionsBlock fails to avoid crashing

Author: benlangmuir Date: Thu Feb 11 12:54:02 2016 New Revision: 260563 URL: http://llvm.org/viewvc/llvm-project?rev=260563=rev Log: [Modules] Early-exit if ReadOptionsBlock fails to avoid crashing If we didn't tell ReadOptionsBlock to allow failures then we can't assume that the stream is not

Re: [PATCH] D17146: [libcxx] locale portability refactor

mclow.lists added a comment. I am very much in favor of cleaning up this part of libc++. Thanks for taking this on. > I'm open to recommendations on ways to test this that are better than > "Submit, watch build bots, revert as necessary". My suggestion is to do this incrementally. Implement

Re: Patch for Bug 26283: float.h is missing mandatory C11 fp macros like DBL_DECIMAL_DIG and LDBL_DECIMAL_DIG

Thanks, I modified the test to also test C89 and C99 modes and committed this as r260577. On Thu, Feb 11, 2016 at 11:29 AM, Jorge Teixeira wrote: > Here is a revised test, which I renamed to c11-5_2_4_2_2p11.c instead > of float.c because I am only checking a subset

Re: r252114 - [modules] If we're given a module file, via -fmodule-file=, for a module, but

On Thu, Feb 11, 2016 at 11:04 AM, Ben Langmuir wrote: > FYI I changed this to early-exit again in r260563 to fix implicit builds. > It’s not safe to keep reading if we haven’t told ReadOptionsBlock to expect > failures, since it will itself early-exit, leaving the stream in

Re: [PATCH] D17069: [clang-tidy] Fix an assert failure in 'readability-braces-around-statements' check.

hokein updated this revision to Diff 47609. hokein added a comment. Address review comment. http://reviews.llvm.org/D17069 Files: clang-tidy/readability/BracesAroundStatementsCheck.cpp test/clang-tidy/readability-braces-around-statements-assert-failure.cpp Index:

r260510 - [MCU] Fix assertion failure on function returning empty union.

Author: dzobnin Date: Thu Feb 11 05:26:03 2016 New Revision: 260510 URL: http://llvm.org/viewvc/llvm-project?rev=260510=rev Log: [MCU] Fix assertion failure on function returning empty union. Treat empty struct/union in return type as void for MCU ABI. PR26438. Differential Revision:

Re: [PATCH] D16808: [MCU] PR26438: Fix assertion failure on function returning an empty struct or union

This revision was automatically updated to reflect the committed changes. Closed by commit rL260510: [MCU] Fix assertion failure on function returning empty union. (authored by dzobnin). Changed prior to commit: http://reviews.llvm.org/D16808?vs=47333=47624#toc Repository: rL LLVM

[PATCH] D17132: [libcxx] Fix definition of regex_traits::__regex_word on big-endian glibc systems

dsanders created this revision. dsanders added reviewers: mclow.lists, hans. dsanders added a subscriber: cfe-commits. On glibc, the bits used for the various character classes is endian dependant (see _ISbit() in ctypes.h) but __regex_word does not account for this and uses a spare bit that

Re: [PATCH] D16851: Update of "GCC extensions not implemented yet" in Clang User's Manual

andreybokhanko added a comment. In http://reviews.llvm.org/D16851#349537, @silvas wrote: > Assuming the features are implemented this seems fine. LGTM. Thank you! Comment at: docs/UsersManual.rst:1698 @@ -1697,3 @@ -- clang does not support #pragma weak (`bug - 3679

Re: [PATCH] D16949: Fix for: Bug 5941 - improve diagnostic for * vs & confusion

ryee88 added a comment. Ping-- can someone look at this review? http://reviews.llvm.org/D16949 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D15998: Implement __attribute__((gc_leaf_function)).

sanjoy resigned from this revision. sanjoy removed a reviewer: sanjoy. sanjoy added a comment. Resigning for now to make my "Revisions Waiting on You" queue less noisy. Please don't hesitate to add me back if this or a variant of this change becomes active. http://reviews.llvm.org/D15998

Re: Linux-abi group

H.J, I think we are fragmenting with too many standards and mailing lists. This new discussion group and eventually the resulting standards, all might be put under LSB http://refspecs.linuxfoundation.org/lsb.shtml The Intro on LSB says:

Re: RFC: Update Intel386, x86-64 and IA MCU psABIs for passing/returning empty struct

On Thu, Feb 11, 2016 at 4:40 AM, Matthijs van Duin wrote: > On 11 February 2016 at 11:53, H.J. Lu wrote: >> Since this isn't Plain Old Data (POD) for the purposes of layout, it >> isn't covered by my proposal for psABI. I leave this to C++ ABI. >

Re: [PATCH] D16965: Fix for Bug 14644 - clang confuses scope operator for global namespace giving extra qualification on member

ryee88 added a comment. Ping-- I think this review got missed. http://reviews.llvm.org/D16965 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D16792: unordered_map: Use __hash_table::__emplace_unique(), NFC

EricWF added a comment. All of the prep work has landed. This patch is no longer needed though. http://reviews.llvm.org/D16792 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D14203: [analyzer] Improve pointer arithmetic checker.

xazax.hun added a comment. Ping. http://reviews.llvm.org/D14203 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] r260513 - Teach __hash_table how to handle unordered_map's __hash_value_type.

Author: ericwf Date: Thu Feb 11 05:59:44 2016 New Revision: 260513 URL: http://llvm.org/viewvc/llvm-project?rev=260513=rev Log: Teach __hash_table how to handle unordered_map's __hash_value_type. This patch is fairly large and contains a number of changes. The main change is teaching

Re: [PATCH] D17069: [clang-tidy] Fix an assert failure in 'readability-braces-around-statements' check.

hokein marked an inline comment as done. hokein added a comment. http://reviews.llvm.org/D17069 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D17134: [clang-tidy] Fix an assert failure of ForStmt in `readability-braces-around-statements` check.

alexfh added inline comments. Comment at: test/clang-tidy/readability-braces-around-statements-assert-failure.cpp:13 @@ +12,3 @@ + std::vector e; + for (typename std::vector::const_reverse_iterator iter = e.begin(), + end2

[libcxx] r260515 - Re-commit "Introduce a cmake module to figure out whether we need to link with libatomic."

Author: vkalintiris Date: Thu Feb 11 06:43:04 2016 New Revision: 260515 URL: http://llvm.org/viewvc/llvm-project?rev=260515=rev Log: Re-commit "Introduce a cmake module to figure out whether we need to link with libatomic." This re-applies commit r260235. However, this time we add

Re: RFC: Update Intel386, x86-64 and IA MCU psABIs for passing/returning empty struct

On 11 February 2016 at 12:40, Matthijs van Duin wrote: > You never define "POD for the purposes of layout", and I can only > interpret it as being equivalent to "standard-layout". As Richard pointed out, it's defined in the C++ ABI. ___ cfe-commits

[libcxx] r260516 - separate nested >>

Author: ericwf Date: Thu Feb 11 06:51:19 2016 New Revision: 260516 URL: http://llvm.org/viewvc/llvm-project?rev=260516=rev Log: separate nested >> Modified: libcxx/trunk/test/support/container_test_types.h Modified: libcxx/trunk/test/support/container_test_types.h URL:

Re: RFC: Update Intel386, x86-64 and IA MCU psABIs for passing/returning empty struct

On 8 February 2016 at 22:40, H.J. Lu wrote: > "empty type". An empty type is either an array of empty types or a > class type where every member is of empty type. Note that the term "empty type" is commonly used in type theory to denote a (or the) type with no values. The

Re: RFC: Update Intel386, x86-64 and IA MCU psABIs for passing/returning empty struct

On 11 February 2016 at 11:53, H.J. Lu wrote: > Since this isn't Plain Old Data (POD) for the purposes of layout, it > isn't covered by my proposal for psABI. I leave this to C++ ABI. You never define "POD for the purposes of layout", and I can only interpret it as being

Re: [PATCH] D16517: ClangTidy check to flag uninitialized builtin and pointer fields.

alexfh added inline comments. Comment at: clang-tidy/cppcoreguidelines/ProTypeMemberInitCheck.cpp:206 @@ +205,3 @@ + // Do not propose fixes in macros since we cannot place them correctly. + if (Ctor->getLocStart().isMacroID()) +return; IIUC what this is

r260518 - clang-format: [JS] Support for (.. of ..) loops.

Author: djasper Date: Thu Feb 11 07:24:15 2016 New Revision: 260518 URL: http://llvm.org/viewvc/llvm-project?rev=260518=rev Log: clang-format: [JS] Support for (.. of ..) loops. Before: for (var i of[2, 3]) {} After: for (var i of [2, 3]) {} Modified: cfe/trunk/lib/Format/FormatToken.h

Re: RFC: Update Intel386, x86-64 and IA MCU psABIs for passing/returning empty struct

On 11 February 2016 at 15:00, H.J. Lu wrote: > I intentionally exclude C++ specific features in my propose. Yet you use a definition from the Itanium C++ ABI which itself depends on multiple definitions in a particular version of the C++ standard, which depend on C++

Re: RFC: Update Intel386, x86-64 and IA MCU psABIs for passing/returning empty struct

On Thu, Feb 11, 2016 at 6:18 AM, Matthijs van Duin wrote: > On 11 February 2016 at 15:00, H.J. Lu wrote: >> I intentionally exclude C++ specific features in my propose. > > Yet you use a definition from the Itanium C++ ABI which itself depends > on

r260517 - clang-format: Make indentation after "<<" more consistent.

Author: djasper Date: Thu Feb 11 07:15:14 2016 New Revision: 260517 URL: http://llvm.org/viewvc/llvm-project?rev=260517=rev Log: clang-format: Make indentation after "<<" more consistent. Before: Diag(, ) << (

r260519 - Partial revert of rL260506.

Author: asbokhan Date: Thu Feb 11 07:27:02 2016 New Revision: 260519 URL: http://llvm.org/viewvc/llvm-project?rev=260519=rev Log: Partial revert of rL260506. After some experiments I discovered that clang doesn't support static initialization of flexible array members in full, so restored this

Re: RFC: Update Intel386, x86-64 and IA MCU psABIs for passing/returning empty struct

On 11 February 2016 at 13:58, H.J. Lu wrote: > "POD for the purpose of layout" is defined in the Itanium C++ ABI here: > > http://mentorembedded.github.io/cxx-abi/abi.html#definitions Sorry, I overlooked that. I still stand by my viewpoint however that triviality of copying

Re: Linux-abi group

On Thu, Feb 11, 2016 at 2:26 AM, Suprateeka R Hegde wrote: > H.J, > > I think we are fragmenting with too many standards and mailing lists. This > new discussion group and eventually the resulting standards, all might be > put under LSB

[clang-tools-extra] r260535 - [clang-tidy] google-runtime-int: fix a false positive in implicit code.

Author: alexfh Date: Thu Feb 11 10:22:58 2016 New Revision: 260535 URL: http://llvm.org/viewvc/llvm-project?rev=260535=rev Log: [clang-tidy] google-runtime-int: fix a false positive in implicit code. Modified: clang-tools-extra/trunk/clang-tidy/google/IntegerTypesCheck.cpp

Re: Linux-abi group

On 8 February 2016 at 18:08, Joseph Myers wrote: > On Mon, 8 Feb 2016, H.J. Lu wrote: > >> >> I was referring to program properties: >> >> >> >> https://groups.google.com/forum/#!topic/generic-abi/fyIXttIsYc8 >> > >> > This looks more like an ELF topic to me, not really

r260533 - [ARM] Add command-line options for ARMv8.2-A

Author: olista01 Date: Thu Feb 11 10:05:52 2016 New Revision: 260533 URL: http://llvm.org/viewvc/llvm-project?rev=260533=rev Log: [ARM] Add command-line options for ARMv8.2-A This allows ARMv8.2-A to be targeted either by using "armv8.2a" in the triple, or by using -march=armv8.2-a (or the alias

[libcxx] r260531 - Rename CheckLibcxxAtomic.cmake variable result names so they don't clash with LLVM

Author: ericwf Date: Thu Feb 11 09:52:52 2016 New Revision: 260531 URL: http://llvm.org/viewvc/llvm-project?rev=260531=rev Log: Rename CheckLibcxxAtomic.cmake variable result names so they don't clash with LLVM Modified: libcxx/trunk/cmake/Modules/CheckLibcxxAtomic.cmake Modified:

Re: Linux-abi group

On 11-Feb-2016 07:21 PM, H.J. Lu wrote: On Thu, Feb 11, 2016 at 2:26 AM, Suprateeka R Hegde wrote: H.J, I think we are fragmenting with too many standards and mailing lists. This new discussion group and eventually the resulting standards, all might be put under LSB

Re: [PATCH] D17140: [clang-tidy] improve misc-misplaced-widening-cast so it also detects portability problems

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG Repository: rL LLVM http://reviews.llvm.org/D17140 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[libcxx] r260526 - Properly down-cast a sentinal node pointer through void*

Author: ericwf Date: Thu Feb 11 09:22:37 2016 New Revision: 260526 URL: http://llvm.org/viewvc/llvm-project?rev=260526=rev Log: Properly down-cast a sentinal node pointer through void* Modified: libcxx/trunk/include/__hash_table Modified: libcxx/trunk/include/__hash_table URL:

[libcxx] r260527 - Add some tests to ensure that the __regex_word does not conflict with any of ctype_base's values.

Author: marshall Date: Thu Feb 11 09:23:04 2016 New Revision: 260527 URL: http://llvm.org/viewvc/llvm-project?rev=260527=rev Log: Add some tests to ensure that the __regex_word does not conflict with any of ctype_base's values. Hopefully this will catch cases like

Re: RFC: Update Intel386, x86-64 and IA MCU psABIs for passing/returning empty struct

On Thu, Feb 11, 2016 at 6:54 AM, Michael Matz wrote: > Hi, > > On Thu, 11 Feb 2016, H.J. Lu wrote: > >> Any suggestions on new wording, something like >> >> 1. "class type". A class type is a structure, union or C++ class. >> 2. "empty type". An empty type is a type where it and

[libcxx] r260524 - Fix r260515 - Correct typos in CMake changes

Author: ericwf Date: Thu Feb 11 09:05:56 2016 New Revision: 260524 URL: http://llvm.org/viewvc/llvm-project?rev=260524=rev Log: Fix r260515 - Correct typos in CMake changes Modified: libcxx/trunk/cmake/Modules/CheckLibcxxAtomic.cmake libcxx/trunk/cmake/config-ix.cmake Modified:

Re: RFC: Update Intel386, x86-64 and IA MCU psABIs for passing/returning empty struct

To avoid depending again on precise wording of definitions in C++ standard it may be worth being explicit about the requirement to be trivially copyable *and* destructible, since although the former implies the latter in the C++ standard this is not obvious from the terminology (although you also

Re: [PATCH] D17132: [libcxx] Fix definition of regex_traits::__regex_word on big-endian glibc systems

mclow.lists added a comment. In r260527, I added some tests to catch this if it happens again. If those tests fail w/o this patch and succeed with, then I'm happy with applying it. http://reviews.llvm.org/D17132 ___ cfe-commits mailing list

RE: [libcxx] r260515 - Re-commit "Introduce a cmake module to figure out whether we need to link with libatomic."

Hi Eric, Your changes work fine for me. Out of curiosity, the correctness issue you mentioned was about the lines you removed from config-ix.cmake, right? - Vasileios From: Eric Fiselier [e...@efcs.ca] Sent: 11 February 2016 15:11 To: Vasileios Kalintiris Cc:

Re: [libcxx] r260515 - Re-commit "Introduce a cmake module to figure out whether we need to link with libatomic."

There were a couple of correctness issues. 'LIBCXX_HAS_ATOMIC_WITHOUT_LIB' was accidentally typo-ed '_WITH_' in a couple of places and 'LIBCXX_HAS_ATOMIC_LIB' was not originally a cache variable like it probably should have been. I just used 'LIBCXX_HAS_ATOMIC_LIB' directly in

[clang-tools-extra] r260532 - Merge branch 'arcpatch-D16922'

Author: congliu Date: Thu Feb 11 10:03:27 2016 New Revision: 260532 URL: http://llvm.org/viewvc/llvm-project?rev=260532=rev Log: Merge branch 'arcpatch-D16922' Modified: clang-tools-extra/trunk/clang-tidy/misc/VirtualNearMissCheck.cpp

Re: [libcxx] r260235 - Introduce a cmake module to figure out whether we need to link with libatomic.

> we need to rename HAVE_CXX_ATOMICS_WITH_LIB to something like LIBCXX_HAVE_CXX_ATOMICS_WITH_LIB. Fixed in r260531. I think we will eventually want to merge the following commits, assuming they don't regress the build, especially with the -gcc-toolchain option. - [libcxx] r260515 - Re-commit

[PATCH] D17143: When trying to get destructor name, make we have a complete type before calling LookupQualifiedName(), which will assert otherwise.

hintonda created this revision. hintonda added reviewers: doug.gregor, majnemer. hintonda added a subscriber: cfe-commits. Fix crash from PR25156 where getDestructorName() calls LookupQualifiedName() on incomplete type. http://reviews.llvm.org/D17143 Files: lib/Sema/SemaExprCXX.cpp

Re: Linux-abi group

On Thu, Feb 11, 2016 at 8:05 AM, Suprateeka R Hegde wrote: > On 11-Feb-2016 07:21 PM, H.J. Lu wrote: >> >> On Thu, Feb 11, 2016 at 2:26 AM, Suprateeka R Hegde >> wrote: >>> >>> H.J, >>> >>> I think we are fragmenting with too many standards and

[libunwind] r260595 - [AArch64] Fix libunwind build when using GNU assembler

Author: rengolin Date: Thu Feb 11 15:22:57 2016 New Revision: 260595 URL: http://llvm.org/viewvc/llvm-project?rev=260595=rev Log: [AArch64] Fix libunwind build when using GNU assembler Use x29 and x30 for fp and lr respectively. This does not change the code generation with integrated asm but

Re: [PATCH] D16544: [libcxx] Framework to allow testing of static libc++abi

bcraig added inline comments. Comment at: test/libcxx/test/config.py:469 @@ +468,3 @@ +if cxx_library_root: +abs_path = cxx_library_root + "/libc++.a" +self.cxx.link_flags += [abs_path] EricWF wrote: > Why

Re: Patch for Bug 26283: float.h is missing mandatory C11 fp macros like DBL_DECIMAL_DIG and LDBL_DECIMAL_DIG

On Thu, Feb 11, 2016 at 3:42 PM, Jorge Teixeira wrote: > Richard, > > Thanks and got it re: test filename and hosted mode. > > 1) AFAIK, C89/C90 does not define DECIMAL_DIG, so here is a revised > patch, with minor comment modifications to explicitly list the (draft) >

Re: r246985 - Compute and preserve alignment more faithfully in IR-generation.

On Tue, Sep 8, 2015 at 1:06 AM, John McCall via cfe-commits wrote: > Author: rjmccall > Date: Tue Sep 8 03:05:57 2015 > New Revision: 246985 > > URL: http://llvm.org/viewvc/llvm-project?rev=246985=rev > Log: > Compute and preserve alignment more faithfully in

  1   2   >