Re: [PATCH] D17183: Make TargetInfo store an actual DataLayout instead of a string.

probinson added a subscriber: probinson. probinson added a comment. Driveby comment: the changes in unittests look unrelated? http://reviews.llvm.org/D17183 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

RE: [libcxx] r260235 - Introduce a cmake module to figure out whether we need to link with libatomic.

> Fixed in r260531. Thanks > I think we will eventually want to merge the following commits, assuming they > don't regress the build, especially with the -gcc-toolchain option. Yes, the MIPS release needs these changes to fix the ~24 tests in PR26369. From: Eric Fiselier [mailto:e...@efcs.ca]

Re: [PATCH] D16973: Fix ICE with constexpr and friend functions

This revision was automatically updated to reflect the committed changes. Closed by commit rL260675: Fix ICE with constexpr and friend functions (authored by ogoffart). Changed prior to commit: http://reviews.llvm.org/D16973?vs=47146=47791#toc Repository: rL LLVM

r260675 - Fix ICE with constexpr and friend functions

Author: ogoffart Date: Fri Feb 12 06:34:44 2016 New Revision: 260675 URL: http://llvm.org/viewvc/llvm-project?rev=260675=rev Log: Fix ICE with constexpr and friend functions Fix a crash while parsing this code: struct X { friend constexpr int foo(X*) { return 12; } static constexpr

Re: [PATCH] D17134: [clang-tidy] Fix an assert failure of ForStmt in `readability-braces-around-statements` check.

hokein updated this revision to Diff 47795. hokein added a comment. Make test ignore all compliation errors. http://reviews.llvm.org/D17134 Files: clang-tidy/readability/BracesAroundStatementsCheck.cpp test/clang-tidy/readability-braces-around-statements-assert-failure.cpp Index:

Re: [PATCH] D17163: [ASTMatchers] Add matcher hasAnyName.

alexfh added inline comments. Comment at: include/clang/ASTMatchers/ASTMatchersInternal.h:644 @@ -643,2 +643,3 @@ explicit HasNameMatcher(StringRef Name); + explicit HasNameMatcher(ArrayRef Names); bkramer wrote: > alexfh wrote: > > Why not `ArrayRef`? >

Re: [PATCH] D17134: [clang-tidy] Fix an assert failure of ForStmt in `readability-braces-around-statements` check.

hokein marked an inline comment as done. Comment at: test/clang-tidy/readability-braces-around-statements-assert-failure.cpp:16 @@ -6,2 +15,2 @@ } } > Interesting. Does creduce fail to further reduce the test? I reduce the test case manually. Now I use

Re: [PATCH] D17163: [ASTMatchers] Add matcher hasAnyName.

alexfh added a subscriber: alexfh. Comment at: include/clang/ASTMatchers/ASTMatchersInternal.h:644 @@ -643,2 +643,3 @@ explicit HasNameMatcher(StringRef Name); + explicit HasNameMatcher(ArrayRef Names); Why not `ArrayRef`? http://reviews.llvm.org/D17163

Re: [PATCH] D16040: [OpenCL] Refine OpenCLImageAccessAttr to OpenCLAccessAttr

pekka.jaaskelainen accepted this revision. pekka.jaaskelainen added a comment. Otherwise LGTM. Comment at: lib/Sema/SemaChecking.cpp:267 @@ -266,3 +266,3 @@ /// Returns OpenCL access qual. // TODO: Refine OpenCLImageAccessAttr to OpenCLAccessAttr since pipe can use // it too

r260671 - [OpenCL] Disable C99 standard lib functions

Author: stulova Date: Fri Feb 12 06:07:04 2016 New Revision: 260671 URL: http://llvm.org/viewvc/llvm-project?rev=260671=rev Log: [OpenCL] Disable C99 standard lib functions The library functions defined in the C99 standard headers are not available (OpenCL v1.2 s6.9.f). This change stops

Re: [PATCH] D16309: Use getCharWidth() instead of magic number

danielmarjamaki added a comment. ping http://reviews.llvm.org/D16309 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D13126: New static analyzer checker for loss of sign/precision

danielmarjamaki added a comment. ping http://reviews.llvm.org/D13126 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D17197: [OPENMP] NFC rewrite ParseOpenMPDirectiveKind

DmitryPolukhin created this revision. DmitryPolukhin added a reviewer: ABataev. DmitryPolukhin added a subscriber: cfe-commits. New implementation is easier to read and extend. http://reviews.llvm.org/D17197 Files: lib/Parse/ParseOpenMP.cpp Index: lib/Parse/ParseOpenMP.cpp

Re: [PATCH] D17163: [ASTMatchers] Add matcher hasAnyName.

klimek added inline comments. Comment at: lib/ASTMatchers/ASTMatchersInternal.cpp:408 @@ +407,3 @@ + PatternSet Patterns(Names); + + llvm::SmallString<128> Scratch; That empty line confuses me for some reason. Comment at:

Re: [PATCH] D17163: [ASTMatchers] Add matcher hasAnyName.

bkramer added a subscriber: bkramer. Comment at: include/clang/ASTMatchers/ASTMatchersInternal.h:644 @@ -643,2 +643,3 @@ explicit HasNameMatcher(StringRef Name); + explicit HasNameMatcher(ArrayRef Names); alexfh wrote: > Why not `ArrayRef`? That's an

Re: [PATCH] D17183: Make TargetInfo store an actual DataLayout instead of a string.

Those changes were necessary due to a name (IIRC it was "Module") existing in both the clang and llvm namespaces, and after this change, becoming ambiguous in those files. On Feb 12, 2016 3:16 AM, "Paul Robinson" wrote: > probinson added a subscriber:

Re: [PATCH] D16529: [clang-tidy] Add modernize-raw-string-literal check

alexfh added a comment. Sorry for the delay. I'm trying to prioritize reviews that are taking less time per-iteration. Unfortunately, here we have a bunch of disagreements and I have to spend significant time to read through your arguments and address your points. Comment

Re: [PATCH] D17134: [clang-tidy] Fix an assert failure of ForStmt in `readability-braces-around-statements` check.

alexfh added inline comments. Comment at: test/clang-tidy/readability-braces-around-statements-assert-failure.cpp:8 @@ +7,3 @@ + +#include + Tests shouldn't include any library headers. This is problematic in many different ways: * standard library can be

Re: [PATCH] D9888: [OPENMP] Driver support for OpenMP offloading

Hahnfeld added a comment. @rsmith could you possibly take a look at this one? It has been around for roughly 8 months now and hasn't received much feedback http://reviews.llvm.org/D9888 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D16040: [OpenCL] Refine OpenCLImageAccessAttr to OpenCLAccessAttr

aaron.ballman added a subscriber: aaron.ballman. aaron.ballman added a reviewer: aaron.ballman. Comment at: include/clang/Basic/Attr.td:671 @@ -670,3 +670,3 @@ Keyword<"write_only">]>]; let Documentation = [Undocumented]; }

[clang-tools-extra] r260681 - Reapply r260096.

Author: aaronballman Date: Fri Feb 12 09:09:05 2016 New Revision: 260681 URL: http://llvm.org/viewvc/llvm-project?rev=260681=rev Log: Reapply r260096. Expand the simplify boolean expression check to handle implicit conversion of integral types to bool and improve the handling of implicit

Re: Patch for Bug 26283: float.h is missing mandatory C11 fp macros like DBL_DECIMAL_DIG and LDBL_DECIMAL_DIG

Thanks Jorge. I'll work on committing this today. -- HT On Fri, Feb 12, 2016 at 12:10 AM, Jorge Teixeira wrote: > Hubert, > > Thanks for the code review. Over the weekend I'll try to learn a bit > more about using Phabricator, but for now I'll reply here, and

r260680 - [Hexagon] Specify vector alignment in DataLayout string

Author: kparzysz Date: Fri Feb 12 08:48:34 2016 New Revision: 260680 URL: http://llvm.org/viewvc/llvm-project?rev=260680=rev Log: [Hexagon] Specify vector alignment in DataLayout string The DataLayout can calculate alignment of vectors based on the alignment of the element type and the number of

Re: RFC: Update Intel386, x86-64 and IA MCU psABIs for passing/returning empty struct

On 11 February 2016 at 16:31, H.J. Lu wrote: > struct A { > static void foo (void) (); > static int xxx; > }; What about it? It's an empty struct. (And it declares a function and a variable in the namespace of A, which however do not have any relevant impact here.)

Re: [PATCH] D16308: clang-tidy Enhance readability-simplify-boolean-expr check to handle implicit conversions of integral types to bool and member pointers

aaron.ballman added a comment. I have commit in r260681. You should look into obtaining commit privileges: http://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access ~Aaron http://reviews.llvm.org/D16308 ___ cfe-commits mailing list

[clang-tools-extra] r260667 - [clang-tidy] Fix failure in 'misc-misplaced-widening-cast' test.

Author: danielmarjamaki Date: Fri Feb 12 03:38:38 2016 New Revision: 260667 URL: http://llvm.org/viewvc/llvm-project?rev=260667=rev Log: [clang-tidy] Fix failure in 'misc-misplaced-widening-cast' test. I added portability warnings when int results are casted to long. I forgot to handle uint,

Re: [PATCH] D17183: Make TargetInfo store an actual DataLayout instead of a string.

probinson added a comment. In http://reviews.llvm.org/D17183#351361, @jyknight wrote: > Those changes were necessary due to a name (IIRC it was "Module") existing > in both the clang and llvm namespaces, and after this change, becoming > ambiguous in those files. Ah, that one. Okay.

Re: [PATCH] D16749: [OpenMP] Map clause codegeneration.

sfantao added a comment. Ping! http://reviews.llvm.org/D16749 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D17163: [ASTMatchers] Add matcher hasAnyName.

sbenza added inline comments. Comment at: include/clang/ASTMatchers/ASTMatchersInternal.h:644 @@ -643,2 +643,3 @@ explicit HasNameMatcher(StringRef Name); + explicit HasNameMatcher(ArrayRef Names); alexfh wrote: > bkramer wrote: > > alexfh wrote: > > > Why

Re: [PATCH] D16152: [clang-tidy] Add check performance-faster-string-find

sbenza updated this revision to Diff 47808. sbenza marked an inline comment as done. sbenza added a comment. Minor fix on comment http://reviews.llvm.org/D16152 Files: clang-tidy/performance/CMakeLists.txt clang-tidy/performance/FasterStringFindCheck.cpp

Re: [PATCH] D16517: ClangTidy check to flag uninitialized builtin and pointer fields.

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. Looks good! Thank you for the new awesome check and to Jonathan for the original patch! http://reviews.llvm.org/D16517 ___ cfe-commits mailing

Re: [PATCH] D17197: [OPENMP] NFC rewrite ParseOpenMPDirectiveKind

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG http://reviews.llvm.org/D17197 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [libcxx] r258107 - Fix PR#26175. Thanks to Josh Petrie for the report and the patch. Reviewed as http://reviews.llvm.org/D16262

Marshall: ping? On Mon, Feb 1, 2016 at 1:48 PM, Hans Wennborg wrote: > Marshall: ping? > > On Tue, Jan 26, 2016 at 11:08 AM, Hans Wennborg wrote: >> On Tue, Jan 19, 2016 at 9:21 AM, Hans Wennborg wrote: >>> On Tue, Jan 19, 2016 at 12:01

Re: [PATCH] D16686: [OpenCL] Generate metadata for opencl_unroll_hint attribute

Anastasia added a comment. @Pekka, Xiuli, Richard, any more comments here? Thanks! http://reviews.llvm.org/D16686 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D17104: [VFS] Drop path traversal assertion

bruno added a comment. > Your two-path solution seems like it's on the right track but I don't like > that it brings us back to having ".." in the source path. Given the two-path solution, another thing we could do in the first path, is to default to the remove_dots() version for the source,

Re: [PATCH] D16870: [CUDA] Tweak attribute-based overload resolution to match nvcc behavior.

This revision was automatically updated to reflect the committed changes. Closed by commit rL260697: [CUDA] Tweak attribute-based overload resolution to match nvcc behavior. (authored by tra). Changed prior to commit: http://reviews.llvm.org/D16870?vs=47753=47819#toc Repository: rL LLVM

Re: [libcxx] r259682 - re.results.form: Format out-of-range subexpression references as null

Marshall: ping? On Wed, Feb 3, 2016 at 5:08 PM, Hans Wennborg wrote: > I'm OK if Marshall is. > > Thanks, > Hans > > On Wed, Feb 3, 2016 at 4:59 PM, Duncan P. N. Exon Smith via > cfe-commits wrote: >> Hans, do you mind merging this to the 3.8

r260697 - [CUDA] Tweak attribute-based overload resolution to match nvcc behavior.

Author: tra Date: Fri Feb 12 12:29:18 2016 New Revision: 260697 URL: http://llvm.org/viewvc/llvm-project?rev=260697=rev Log: [CUDA] Tweak attribute-based overload resolution to match nvcc behavior. This is an artefact of split-mode CUDA compilation that we need to mimic. HD functions are

Re: [PATCH] D16040: [OpenCL] Refine OpenCLImageAccessAttr to OpenCLAccessAttr

Anastasia added inline comments. Comment at: lib/Sema/SemaDeclAttr.cpp:5823 @@ -5788,8 +5822,3 @@ - // Walk the declarator structure, applying decl attributes that were in a type - // position to the decl itself. This handles cases like: - // int *__attr__(x)** D; - //

Re: [PATCH] D16040: [OpenCL] Refine OpenCLImageAccessAttr to OpenCLAccessAttr

aaron.ballman added inline comments. Comment at: lib/Sema/SemaDeclAttr.cpp:5823 @@ -5788,8 +5822,3 @@ - // Walk the declarator structure, applying decl attributes that were in a type - // position to the decl itself. This handles cases like: - // int *__attr__(x)** D; -

Re: [PATCH] D17104: [VFS] Drop path traversal assertion

benlangmuir added a comment. > Given the two-path solution, another thing we could do in the first path, is > to default to the remove_dots() version for the source, i.e. > "/install-dir/lib/clang/3.8.0/include" instead of > "/install-dir/bin/../lib/clang/3.8.0/include". The path after

r260710 - test/Headers/float.c: fix theoretical edge values

Author: hubert.reinterpretcast Date: Fri Feb 12 13:24:36 2016 New Revision: 260710 URL: http://llvm.org/viewvc/llvm-project?rev=260710=rev Log: test/Headers/float.c: fix theoretical edge values For *_MANT_DIG, *_MAX_EXP and *_MIN_EXP, the C Standard does not list the least requirements directly.

Re: [PATCH] D16928: [OpenCL] Apply missing restrictions for Blocks in OpenCL v2.0

Anastasia removed rL LLVM as the repository for this revision. Anastasia updated this revision to Diff 47823. Anastasia added a comment. Update according to review comments! http://reviews.llvm.org/D16928 Files: include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaDecl.cpp

[clang-tools-extra] r260712 - [clang-tidy] Add check performance-faster-string-find

Author: sbenza Date: Fri Feb 12 13:28:14 2016 New Revision: 260712 URL: http://llvm.org/viewvc/llvm-project?rev=260712=rev Log: [clang-tidy] Add check performance-faster-string-find Summary: Add check performance-faster-string-find. It replaces single character string literals to character

[PATCH] D17206: Fix AST printing of ascii char literals above 127.

steven_watanabe created this revision. steven_watanabe added a reviewer: rsmith. steven_watanabe added a subscriber: cfe-commits. Currently literals like '\xff' may be sign extended, resulting in output like '\U', which is not valid. http://reviews.llvm.org/D17206 Files:

Re: [PATCH] D16152: [clang-tidy] Add check performance-faster-string-find

This revision was automatically updated to reflect the committed changes. Closed by commit rL260712: [clang-tidy] Add check performance-faster-string-find (authored by sbenza). Changed prior to commit: http://reviews.llvm.org/D16152?vs=47808=47825#toc Repository: rL LLVM

Re: [PATCH] D17104: [VFS] Drop path traversal assertion

bruno added a comment. > I'm not sure I understand how the 2nd path would cover the realpath case. It > is just an entry for the realpath itself; that doesn't help if the client > looks up "/install-dir/lib/clang/3.8.0" directly (not just from removing dots > from bin/..). What I was

Re: [PATCH] D17188: AMDGPU: Add sin/cos builtins

tstellarAMD accepted this revision. tstellarAMD added a comment. This revision is now accepted and ready to land. LGTM. http://reviews.llvm.org/D17188 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: r260707 - [CMake] Pass stage1 tools through to stage2 when building with LTO

Any reason it is lto specific? For example, it is nice to test llvm-ar in stage2 even if not doing LTO, no? Cheers, Rafael On 12 February 2016 at 14:06, Chris Bieneman via cfe-commits wrote: > Author: cbieneman > Date: Fri Feb 12 13:06:12 2016 > New Revision: 260707

Re: r260707 - [CMake] Pass stage1 tools through to stage2 when building with LTO

It is needed if you're doing LTO. If you're not doing an LTO build using the host AR will work, and it is faster to not have to build extra targets. It is really just a build-time optimization. -Chris > On Feb 12, 2016, at 11:52 AM, Rafael Espíndola > wrote: > >

r260811 - [OPENMP] NFC rewrite ParseOpenMPDirectiveKind

Author: dpolukhin Date: Sat Feb 13 00:53:38 2016 New Revision: 260811 URL: http://llvm.org/viewvc/llvm-project?rev=260811=rev Log: [OPENMP] NFC rewrite ParseOpenMPDirectiveKind New implementation is easier to read and extend. Differential Revision: http://reviews.llvm.org/D17197 Modified:

r260807 - [index] Change some default parameters to fix an MSVC ICE.

Author: akirtzidis Date: Fri Feb 12 23:17:15 2016 New Revision: 260807 URL: http://llvm.org/viewvc/llvm-project?rev=260807=rev Log: [index] Change some default parameters to fix an MSVC ICE. Many thanks to Yunzhong Gao for tracking this down! Modified: cfe/trunk/lib/Index/IndexingContext.h

Re: [PATCH] D17197: [OPENMP] NFC rewrite ParseOpenMPDirectiveKind

This revision was automatically updated to reflect the committed changes. Closed by commit rL260811: [OPENMP] NFC rewrite ParseOpenMPDirectiveKind (authored by dpolukhin). Changed prior to commit: http://reviews.llvm.org/D17197?vs=47794=47899#toc Repository: rL LLVM

Re: Patch for Bug 26283: float.h is missing mandatory C11 fp macros like DBL_DECIMAL_DIG and LDBL_DECIMAL_DIG

Hi, I decided to strike while the iron was hot and add the remaining tests for float.h. 1) clang was missing the C11 mandatory *_HAS_SUBNORM macros, so I added them. The internal underscored versions are *_HAS_DENORM, and the Std. defines only "subnormal" and "unnormalized", so there could be,

[PATCH] D17239: Sema: typo correct both sides of binary expression

compnerd created this revision. compnerd added a reviewer: rtrieu. compnerd added a subscriber: cfe-commits. When parsing a ternary expression, we would parse the middle and the last components of the expression. If there was a typo in both, we would only run the typo correction once. Normally,

Re: [PATCH] D16529: [clang-tidy] Add modernize-raw-string-literal check

LegalizeAdulthood added inline comments. Comment at: clang-tidy/modernize/RawStringLiteralCheck.cpp:97 @@ +96,3 @@ +} + +} // namespace alexfh wrote: > > I believe we agree on the following: ... > > Yes. > > > Where we seem to disagree is what algorithm should

[PATCH] D17215: Fix PR14211 Crash for explicit instantiation of overloaded template function within class template

hintonda created this revision. hintonda added reviewers: lvoufo, rjmccall. hintonda added a subscriber: cfe-commits. Fix PR14211 Only add FunctionDecl's that are actual template methods to the set of matches passed to getMostSpecializied() -- otherwise it will assert/crash. If a match to a

Re: [PATCH] D16999: [CMake] Improve the clang order-file generation workflow

Chris Bieneman writes: > beanz created this revision. > beanz added a reviewer: bogner. > beanz added a subscriber: cfe-commits. > > This commit re-lands r259862. The underlying cause of the build > breakage was an incorrectly written capabilities test. In >

Re: [PATCH] D16012: Carry raw string literal information through to the AST StringLiteral representation

aaron.ballman added a comment. Ping. Richard, I think we've provided justification that warrants this functionality (mostly for clang-tidy checks). Any issues with the code? http://reviews.llvm.org/D16012 ___ cfe-commits mailing list

Re: r260719 - Added missing '__'.

*nod* I figure at least include them into something :) -eric On Fri, Feb 12, 2016 at 1:31 PM Artem Belevich wrote: > No problem. It's hard to test CUDA wrappers properly without real CUDA > headers. :-( > > > On Fri, Feb 12, 2016 at 1:28 PM, Eric Christopher

Re: [PATCH] D17206: Fix AST printing of ascii char literals above 127.

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. LGTM Comment at: lib/AST/StmtPrinter.cpp:1253-1256 @@ -1252,2 +1252,6 @@ default: +// A character literal might be sign-extended, which +// would result in an

r260742 - [CMake] Improve the clang order-file generation workflow

Author: cbieneman Date: Fri Feb 12 15:36:55 2016 New Revision: 260742 URL: http://llvm.org/viewvc/llvm-project?rev=260742=rev Log: [CMake] Improve the clang order-file generation workflow Summary: This commit re-lands r259862. The underlying cause of the build breakage was an incorrectly

r260755 - Darwin: pass -stdlib=libc++ down to cc1 whenever we're targeting libc++

Author: tnorthover Date: Fri Feb 12 16:30:42 2016 New Revision: 260755 URL: http://llvm.org/viewvc/llvm-project?rev=260755=rev Log: Darwin: pass -stdlib=libc++ down to cc1 whenever we're targeting libc++ Recent refactoring meant it only got passed down when explicitly specified, which breaks

r260757 - Fix remaining Clang-tidy readability-redundant-control-flow warnings; other minor fixes.

Author: eugenezelenko Date: Fri Feb 12 16:53:10 2016 New Revision: 260757 URL: http://llvm.org/viewvc/llvm-project?rev=260757=rev Log: Fix remaining Clang-tidy readability-redundant-control-flow warnings; other minor fixes. Differential revision: http://reviews.llvm.org/D17218 Modified:

Re: [PATCH] D13704: [Fix] Allow implicit conversions of the address of overloadable functions in C + docs update

george.burgess.iv added a comment. FYI: I noticed a few cases this patch misses. Will add them soon. http://reviews.llvm.org/D13704 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: r260616 - Now that Sparc/Sparc64 backend is mostly usable, provide the same

On Thu, Feb 11, 2016 at 3:18 PM, Joerg Sonnenberger via cfe-commits wrote: > Author: joerg > Date: Thu Feb 11 17:18:36 2016 > New Revision: 260616 > > URL: http://llvm.org/viewvc/llvm-project?rev=260616=rev > Log: > Now that Sparc/Sparc64 backend is mostly usable,

Buildbot numbers for week of 1/31/2016 - 2/06/2016

Hello everyone, Below are some buildbot numbers for the last week of 1/31/2016 - 2/6/2016. I have added a new report that shows a "status change ratio" for each builder. The idea is to provide some kind of metrics for a noise level a builder produces. The number is a percent of builds that

[PATCH] D17216: Make test/Driver/output-file-cleanup.c hermetic.

jlebar created this revision. jlebar added a reviewer: rafael. jlebar added a subscriber: cfe-commits. It checks that certain files do and exist, so make sure that they don't exist at the beginning of the test. This hid a failure in r260448; to see the failure, you had to run the test with a

[PATCH] D17217: Bail on compilation as soon as a job fails.

jlebar created this revision. jlebar added a reviewer: rafael. jlebar added subscribers: tra, echristo, jhen, cfe-commits. (Re-land of r260448, which was reverted in r260522 due to a test failure in Driver/output-file-cleanup.c that only showed up in fresh builds.) Previously we attempted to be

Re: [PATCH] D17214: Stop using "template" when printing qualtype names

saugustine added a comment. Thanks for the quick review. Assuming my response to your comment on line 138 is adequate, would you mind checking it in? Comment at: unittests/Tooling/QualTypeNamesTest.cpp:138 @@ -136,3 +137,3 @@ " typedef int non_dependent_type;\n"

Re: [PATCH] D17218: [Clang] Fix remaining Clang-tidy readability-redundant-control-flow warnings; other minor fixes

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm Repository: rL LLVM http://reviews.llvm.org/D17218 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [libcxx] r260431 - Recommit r260012 - Cleanup node-type handling in the unordered containers.

Hi, hash_map still looks broken to me. I don't have a simple reproducer, but these declarations in __hash_table: template class _LIBCPP_TYPE_VIS_ONLY __hash_map_iterator; template class _LIBCPP_TYPE_VIS_ONLY __hash_map_const_iterator; should not they be prefixed with __gnu_cxx:: ? Clang

r260719 - Added missing '__'.

Author: tra Date: Fri Feb 12 14:26:43 2016 New Revision: 260719 URL: http://llvm.org/viewvc/llvm-project?rev=260719=rev Log: Added missing '__'. Modified: cfe/trunk/lib/Headers/__clang_cuda_cmath.h Modified: cfe/trunk/lib/Headers/__clang_cuda_cmath.h URL:

r260744 - [CMake] Fixing bots I broke.

Author: cbieneman Date: Fri Feb 12 15:46:25 2016 New Revision: 260744 URL: http://llvm.org/viewvc/llvm-project?rev=260744=rev Log: [CMake] Fixing bots I broke. Modified: cfe/trunk/CMakeLists.txt Modified: cfe/trunk/CMakeLists.txt URL:

Re: [PATCH] D16514: Add -stop-on-failure driver option, and enable it by default for CUDA compiles.

jlebar added a comment. espindola reverted this in r260522 because of test failures in Driver/output-file-cleanup.c. The reason I didn't catch this locally is that the test is non-hermetic -- if it passed once in an objdir, this patch does not make it fail again. You have to nuke (part of)

[PATCH] D17218: [Clang] Fix remaining Clang-tidy readability-redundant-control-flow warnings; other minor fixes

Eugene.Zelenko created this revision. Eugene.Zelenko added reviewers: hans, aaron.ballman. Eugene.Zelenko added a subscriber: cfe-commits. Eugene.Zelenko set the repository for this revision to rL LLVM. I checked this patch on my own build on RHEL 6. Regressions were OK. Repository: rL LLVM

[PATCH] D17214: Stop using "template" when printing qualtype names

saugustine created this revision. saugustine added a reviewer: rsmith. saugustine added subscribers: cfe-commits, klimek. The keyword "template" isn't necessary when printing a fully-qualified qualtype name, and, in fact, results in a syntax error if one tries to use it. So stop printing it.

Re: [PATCH] D17214: Stop using "template" when printing qualtype names

rnk added a subscriber: rnk. rnk accepted this revision. rnk added a reviewer: rnk. rnk added a comment. This revision is now accepted and ready to land. lgtm This code seems like it's intended to avoid operating on dependent types, so it shouldn't need the template keyword. It's hard to have a

Re: [PATCH] D16012: Carry raw string literal information through to the AST StringLiteral representation

rsmith added a comment. In http://reviews.llvm.org/D16012#351821, @aaron.ballman wrote: > Ping. Richard, I think we've provided justification that warrants this > functionality (mostly for clang-tidy checks). I am not convinced. This flag does not seem to make sense for `StringLiteral`,

Re: [PATCH] D17218: [Clang] Fix remaining Clang-tidy readability-redundant-control-flow warnings; other minor fixes

This revision was automatically updated to reflect the committed changes. Closed by commit rL260757: Fix remaining Clang-tidy readability-redundant-control-flow warnings; other… (authored by eugenezelenko). Changed prior to commit: http://reviews.llvm.org/D17218?vs=47859=47860#toc Repository:

Re: [PATCH] D15095: Accept "-Weverything" in pragma clang diagnostic ...

Sunil_Srivastava updated this revision to Diff 47866. Sunil_Srivastava added a comment. Hi Richard, Good point about that extra test. I suppose I need another LGTM for the new test. No other changes. (Sorry I had missed the code change in the last round) http://reviews.llvm.org/D15095

r260787 - [Sema] More changes to fix Objective-C fallout from r249995.

Author: bwilson Date: Fri Feb 12 19:41:41 2016 New Revision: 260787 URL: http://llvm.org/viewvc/llvm-project?rev=260787=rev Log: [Sema] More changes to fix Objective-C fallout from r249995. This is a follow-up to PR26085. That was fixed in r257710 but the testcase there was incomplete. There is

[libclc] r260777 - Split sources for amdgcn and r600

Author: arsenm Date: Fri Feb 12 19:01:59 2016 New Revision: 260777 URL: http://llvm.org/viewvc/llvm-project?rev=260777=rev Log: Split sources for amdgcn and r600 Most files remain in a common amdgpu directory. Also switches barriers to to use convergent, and use llvm.amdgcn.s.barrier. This now

[libclc] r260778 - Update page to list supported targets

Author: arsenm Date: Fri Feb 12 19:02:06 2016 New Revision: 260778 URL: http://llvm.org/viewvc/llvm-project?rev=260778=rev Log: Update page to list supported targets Modified: libclc/trunk/www/index.html Modified: libclc/trunk/www/index.html URL:

Re: [PATCH] D17188: AMDGPU: Add sin/cos builtins

arsenm closed this revision. arsenm added a comment. r260783 http://reviews.llvm.org/D17188 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r260788 - Accept "-Weverything" in clang diagnistic pragmas

Author: ssrivastava Date: Fri Feb 12 19:44:05 2016 New Revision: 260788 URL: http://llvm.org/viewvc/llvm-project?rev=260788=rev Log: Accept "-Weverything" in clang diagnistic pragmas Differential Revision: http://reviews.llvm.org/D15095 Added:

Re: [PATCH] D17206: Fix AST printing of ascii char literals above 127.

This revision was automatically updated to reflect the committed changes. Closed by commit rL260795: Fix the ASTPrinter output for ascii char literals >127. (authored by steven_watanabe). Changed prior to commit: http://reviews.llvm.org/D17206?vs=47822=47887#toc Repository: rL LLVM

r260795 - Fix the ASTPrinter output for ascii char literals >127.

Author: steven_watanabe Date: Fri Feb 12 20:31:28 2016 New Revision: 260795 URL: http://llvm.org/viewvc/llvm-project?rev=260795=rev Log: Fix the ASTPrinter output for ascii char literals >127. Differential Revision: http://reviews.llvm.org/D17206 Modified: cfe/trunk/lib/AST/StmtPrinter.cpp

Re: [PATCH] D17148: [OPENMP] Basic teams directive implementation

carlo.bertolli updated this revision to Diff 47890. carlo.bertolli added a comment. Apply changes to reflect review: have a single emit outlined function call for both parallel and teams; call push_num_teams outside of runtime class. http://reviews.llvm.org/D17148 Files:

Re: [PATCH] D17148: [OPENMP] Basic teams directive implementation

carlo.bertolli marked 2 inline comments as done. carlo.bertolli added a comment. I applied your suggestions and generated a new diff file. Thanks! http://reviews.llvm.org/D17148 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D15095: Accept "-Weverything" in pragma clang diagnostic ...

rsmith added a comment. If a patch is LGTM'd and some small change is requested at the same time, that typically means "LGTM once you make the following changes, which I trust you to make with no further pre-commit review". If you'd prefer more pre-commit review, of course, that's fine too.

Re: [PATCH] D15095: Accept "-Weverything" in pragma clang diagnostic ...

Sunil_Srivastava updated this revision to Diff 47865. Sunil_Srivastava added a comment. Hi Richard, Good point about that extra test. I suppose I need another LGTM for the new test. No other changes. http://reviews.llvm.org/D15095 Files: Preprocessor/Weverything_pragma.c

r260781 - AMDGPU: Update builtin for intrinsic change

Author: arsenm Date: Fri Feb 12 19:03:09 2016 New Revision: 260781 URL: http://llvm.org/viewvc/llvm-project?rev=260781=rev Log: AMDGPU: Update builtin for intrinsic change Modified: cfe/trunk/include/clang/Basic/BuiltinsAMDGPU.def cfe/trunk/lib/CodeGen/CGBuiltin.cpp

r260779 - Disable two tests that use a lot of stack under ASan.

Author: samsonov Date: Fri Feb 12 19:02:59 2016 New Revision: 260779 URL: http://llvm.org/viewvc/llvm-project?rev=260779=rev Log: Disable two tests that use a lot of stack under ASan. Modified: cfe/trunk/test/Index/index-many-call-ops.cpp cfe/trunk/test/Index/index-many-logical-ops.c

r260783 - AMDGPU: Add sin/cos builtins

Author: arsenm Date: Fri Feb 12 19:21:09 2016 New Revision: 260783 URL: http://llvm.org/viewvc/llvm-project?rev=260783=rev Log: AMDGPU: Add sin/cos builtins Modified: cfe/trunk/include/clang/Basic/BuiltinsAMDGPU.def cfe/trunk/lib/CodeGen/CGBuiltin.cpp

r260785 - [RecursiveASTVisitor] Introduce dataTraverseStmtPre()/dataTraverseStmtPost() to allow clients to do before/after actions during data recursive visitation.

Author: akirtzidis Date: Fri Feb 12 19:24:19 2016 New Revision: 260785 URL: http://llvm.org/viewvc/llvm-project?rev=260785=rev Log: [RecursiveASTVisitor] Introduce dataTraverseStmtPre()/dataTraverseStmtPost() to allow clients to do before/after actions during data recursive visitation. This

Re: [PATCH] D17166: [Sema] More changes to fix Objective-C fallout from r249995.

bob.wilson closed this revision. bob.wilson marked an inline comment as done. bob.wilson added a comment. Committed in r260787. I had previously missed a regression in one of the existing ovl-check.m tests. The testTakesCFTypeRef function was checking that the CFTypeRef overload was selected.

Re: [PATCH] D15095: Accept "-Weverything" in pragma clang diagnostic ...

This revision was automatically updated to reflect the committed changes. Closed by commit rL260788: Accept "-Weverything" in clang diagnistic pragmas (authored by ssrivastava). Changed prior to commit: http://reviews.llvm.org/D15095?vs=47866=47881#toc Repository: rL LLVM