r261312 - Correct typos after acting on invalid subscript expressions

Author: majnemer Date: Fri Feb 19 01:15:33 2016 New Revision: 261312 URL: http://llvm.org/viewvc/llvm-project?rev=261312=rev Log: Correct typos after acting on invalid subscript expressions Modified: cfe/trunk/lib/Parse/ParseExpr.cpp cfe/trunk/test/SemaCXX/typo-correction.cpp Modified:

Re: [PATCH] D17434: [Clang-tidy] Make readability-container-size-empty working with STL string

should probably have test coverage On Thu, Feb 18, 2016 at 6:46 PM, Eugene Zelenko via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Eugene.Zelenko created this revision. > Eugene.Zelenko added reviewers: alexfh, xazax.hun, aaron.ballman. > Eugene.Zelenko added a subscriber: cfe-commits. >

Re: [PATCH] D17349: ARM: fix VFP asm constraints

This revision was automatically updated to reflect the committed changes. Closed by commit rL261309: ARM: fix VFP asm constraints (authored by jfb). Changed prior to commit: http://reviews.llvm.org/D17349?vs=48363=48453#toc Repository: rL LLVM http://reviews.llvm.org/D17349 Files:

r261310 - Add test.

Author: jfb Date: Fri Feb 19 00:54:47 2016 New Revision: 261310 URL: http://llvm.org/viewvc/llvm-project?rev=261310=rev Log: Add test. Added: cfe/trunk/test/CodeGen/arm-vfp-asm-constraint.c Added: cfe/trunk/test/CodeGen/arm-vfp-asm-constraint.c URL:

r261309 - ARM: fix VFP asm constraints

Author: jfb Date: Fri Feb 19 00:54:45 2016 New Revision: 261309 URL: http://llvm.org/viewvc/llvm-project?rev=261309=rev Log: ARM: fix VFP asm constraints Summary: Rich Felker was sad that clang used 'w' and 'P' for VFP constraints when GCC documents them as 't' and 'w':

Re: [PATCH] D16040: [OpenCL] Refine OpenCLImageAccessAttr to OpenCLAccessAttr

pxli168 updated this revision to Diff 48452. pxli168 added a comment. Refine the pipe parse to solve the problem the attribute for pipe will be handled twice within Declarator http://reviews.llvm.org/D16040 Files: include/clang/Basic/Attr.td include/clang/Basic/AttrDocs.td

Re: [PATCH] D17349: ARM: fix VFP asm constraints

compnerd accepted this revision. compnerd added a reviewer: compnerd. compnerd added a comment. This revision is now accepted and ready to land. Yeah, constraint validation is not one of the highlights of the current implementation. This seems reasonable enough to merge I think.

r261301 - Fix SemaTemplate/instantiate-field.cpp after r261297.

Author: nico Date: Thu Feb 18 20:51:07 2016 New Revision: 261301 URL: http://llvm.org/viewvc/llvm-project?rev=261301=rev Log: Fix SemaTemplate/instantiate-field.cpp after r261297. For templates, fields can have incomplete types: template struct A2 { struct B; B b; }; Don't try

[PATCH] D17434: [Clang-tidy] Make readability-container-size-empty working with STL string

Eugene.Zelenko created this revision. Eugene.Zelenko added reviewers: alexfh, xazax.hun, aaron.ballman. Eugene.Zelenko added a subscriber: cfe-commits. Eugene.Zelenko set the repository for this revision to rL LLVM. While working with LLDB code I noticed that readability-container-size-empty

Re: [PATCH] D5238: [analyzer] Detect duplicate [super dealloc] calls

dcoughlin updated this revision to Diff 48447. dcoughlin added a comment. Addressed additional comments from Anna offline: - "[super dealloc] called again" is OK as a path note but not good as an error message. I've changed it to "[super dealloc] should not be called multiple times". - Added a

Re: [PATCH] D17349: ARM: fix VFP asm constraints

jfb added a comment. Is this ready to land? I'm hoping to get it into the 3.8 branch since it affects musl libc's latest release. http://reviews.llvm.org/D17349 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D16552: Implement the likely resolution of core issue 253.

thakis closed this revision. thakis added a comment. Thanks! Landed the cxx_dr_status.html update in r261295 and this change in r261297. http://reviews.llvm.org/D16552 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r261297 - Implement the likely resolution of core issue 253.

Author: nico Date: Thu Feb 18 19:52:46 2016 New Revision: 261297 URL: http://llvm.org/viewvc/llvm-project?rev=261297=rev Log: Implement the likely resolution of core issue 253. C++11 requires const objects to have a user-provided constructor, even for classes without any fields. DR 253 relaxes

r261295 - Update cxx_dr_status.html with today's cwg_index.html.

Author: nico Date: Thu Feb 18 19:49:39 2016 New Revision: 261295 URL: http://llvm.org/viewvc/llvm-project?rev=261295=rev Log: Update cxx_dr_status.html with today's cwg_index.html. Created by: cd www curl -O http://www.open-std.org/jtc1/sc22/wg21/docs/cwg_index.html ./make_cxx_dr_status

Re: [PATCH] D17313: [CUDA] Annotate all calls in CUDA device mode as convergent.

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm http://reviews.llvm.org/D17313 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D15829: [PGO] Clang Option that enables IR level PGO instrumentation

silvas added a comment. Apologies for the delay. At this point, I think that this patch has evolved enough that it is best to start a new patch. I think the steps forward are: - Have cc1 accept -fprofile-instrument=llvm (requires no driver changes, but is enough for developers to test by being

Re: [PATCH] D17418: [analyzer] Add checker callback for beginning of function.

This revision was automatically updated to reflect the committed changes. Closed by commit rL261293: [analyzer] Add checker callback for beginning of function. (authored by dcoughlin). Changed prior to commit: http://reviews.llvm.org/D17418?vs=48406=48438#toc Repository: rL LLVM

r261293 - [analyzer] Add checker callback for beginning of function.

Author: dcoughlin Date: Thu Feb 18 19:35:10 2016 New Revision: 261293 URL: http://llvm.org/viewvc/llvm-project?rev=261293=rev Log: [analyzer] Add checker callback for beginning of function. Add a checker callback that is called when the analyzer starts analyzing a function either at the top

Re: [PATCH] D17418: [analyzer] Add checker callback for beginning of function.

dcoughlin marked an inline comment as done. dcoughlin added a comment. http://reviews.llvm.org/D17418 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r261292 - [Sema] PR25181 Fix crash when method declaration with throw spec fails to parse correctly

Author: rnk Date: Thu Feb 18 19:15:08 2016 New Revision: 261292 URL: http://llvm.org/viewvc/llvm-project?rev=261292=rev Log: [Sema] PR25181 Fix crash when method declaration with throw spec fails to parse correctly Fixes crash referenced in PR25181 where dyn_cast is called on a null instance of

Re: [PATCH] D17072: [Sema] PR25181 Fix crash when method declaration with throw spec fails to parse correctly

This revision was automatically updated to reflect the committed changes. Closed by commit rL261292: [Sema] PR25181 Fix crash when method declaration with throw spec fails to… (authored by rnk). Changed prior to commit: http://reviews.llvm.org/D17072?vs=47923=48435#toc Repository: rL LLVM

Re: [PATCH] D17418: [analyzer] Add checker callback for beginning of function.

zaks.anna accepted this revision. zaks.anna added a comment. This revision is now accepted and ready to land. LGTM with a request for a tiny other improvement in the documentation. Thanks! Comment at: include/clang/StaticAnalyzer/Core/PathSensitive/SubEngine.h:111 @@ -103,3

Re: [PATCH] D17072: [Sema] PR25181 Fix crash when method declaration with throw spec fails to parse correctly

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. Looks good, thanks. I like the new approach of avoiding the creation of a LateParsedMethodDeclaration if we couldn't get a NamedDecl back. I'll land it soon. http://reviews.llvm.org/D17072

r261290 - Add call to find_package to load LLVM dependencies

Author: rnk Date: Thu Feb 18 18:56:56 2016 New Revision: 261290 URL: http://llvm.org/viewvc/llvm-project?rev=261290=rev Log: Add call to find_package to load LLVM dependencies ClangConfig requires LLVMConfig, so add find_package call in ClangConfig so find_package(clang REQUIRED CONFIG) will

Re: [PATCH] D13622: Add call to find_package to load LLVM dependencies

This revision was automatically updated to reflect the committed changes. Closed by commit rL261290: Add call to find_package to load LLVM dependencies (authored by rnk). Changed prior to commit: http://reviews.llvm.org/D13622?vs=37031=48431#toc Repository: rL LLVM

Re: [PATCH] D3976: -Wcomma, a new warning for questionable uses of the comma operator

ovyalov added a subscriber: ovyalov. ovyalov added a comment. It seems this CL broke LLDB CMake build bot - http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-cmake/builds/11554 Could you take a look? Repository: rL LLVM http://reviews.llvm.org/D3976

Re: [PATCH] D16552: Implement the likely resolution of core issue 253.

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Thanks, LGTM! If it's convenient, it'd be nice to check in a new cxx_dr_status.html without your change first, as a separate commit, so it's more obvious which parts of the file are changed

r261278 - Add -Wcomma warning to Clang.

Author: rtrieu Date: Thu Feb 18 17:58:40 2016 New Revision: 261278 URL: http://llvm.org/viewvc/llvm-project?rev=261278=rev Log: Add -Wcomma warning to Clang. -Wcomma will detect and warn on most uses of the builtin comma operator. It currently whitelists the first and third statements of the

Re: [PATCH] D16552: Implement the likely resolution of core issue 253.

thakis updated this revision to Diff 48418. thakis added a comment. Thanks! All done. http://reviews.llvm.org/D16552 Files: include/clang/AST/DeclCXX.h lib/AST/ASTImporter.cpp lib/AST/DeclCXX.cpp lib/Sema/SemaInit.cpp lib/Serialization/ASTReaderDecl.cpp

Re: [PATCH] D17029: [AST] Implemented missing import for the Template type parameter and Injected Class Name in ASTImporter class.

akyrtzi added a subscriber: akyrtzi. akyrtzi added a comment. If I apply just the test changes without the rest of the changes, I don't see any failures, so I'm not sure these are effective tests. http://reviews.llvm.org/D17029 ___ cfe-commits

Re: [PATCH] D16552: Implement the likely resolution of core issue 253.

rsmith added inline comments. Comment at: lib/AST/DeclCXX.cpp:396-425 @@ -394,1 +395,32 @@ +bool CXXRecordDecl::allowConstDefaultInitSlow() const { + assert(getDefinition() && "only call this on completed records"); + if (hasUserProvidedDefaultConstructor()) { +

Re: [PATCH] D17026: Changed ASTImporter DiagnosticsEngine from FromDiag to ToDiag for unsupported ASTNodes Import.

akyrtzi added a subscriber: akyrtzi. akyrtzi added a comment. Doesn't this mean that _all_ of the Importer.FromDiag() calls will be ignored by VerifyDiagnosticConsumer ? Why specifically change only this two and what are we going to do with the others ? This seems more like needing a fix higher

Re: [PATCH] D16923: [AST] Implemented missing VisitAccessSpecDecl function in ASTImporter class.

akyrtzi added a subscriber: akyrtzi. akyrtzi accepted this revision. akyrtzi added a reviewer: akyrtzi. akyrtzi added a comment. This revision is now accepted and ready to land. LGTM, committed in r261274. http://reviews.llvm.org/D16923 ___

r261274 - [ASTImporter] Implement missing VisitAccessSpecDecl function in ASTImporter class.

Author: akirtzidis Date: Thu Feb 18 17:08:36 2016 New Revision: 261274 URL: http://llvm.org/viewvc/llvm-project?rev=261274=rev Log: [ASTImporter] Implement missing VisitAccessSpecDecl function in ASTImporter class. Patch by Elisavet Sakellari! Modified: cfe/trunk/lib/AST/ASTImporter.cpp

Re: RFC: Update Intel386, x86-64 and IA MCU psABIs for passing/returning empty struct

On Thu, Feb 18, 2016 at 6:35 AM, Michael Matz wrote: > Hi, > > On Tue, 16 Feb 2016, H.J. Lu wrote: > >> Here is the new definition: >> >> An empty type is a type where it and all of its subobjects (recursively) >> are of class, structure, union, or array type. No memory slot nor >>

Re: RFC: Update Intel386, x86-64 and IA MCU psABIs for passing/returning empty struct

On Thu, Feb 18, 2016 at 6:35 AM, Michael Matz wrote: > Hi, > > On Tue, 16 Feb 2016, H.J. Lu wrote: > >> Here is the new definition: >> >> An empty type is a type where it and all of its subobjects (recursively) >> are of class, structure, union, or array type. No memory slot nor >>

r261271 - Remove use of builtin comma operator.

Author: rtrieu Date: Thu Feb 18 16:34:54 2016 New Revision: 261271 URL: http://llvm.org/viewvc/llvm-project?rev=261271=rev Log: Remove use of builtin comma operator. Cleanup for upcoming Clang warning -Wcomma. No functionality change intended. Modified:

[PATCH] D17416: [libcxx] Reorganize locale extension fallbacks

bcraig created this revision. bcraig added reviewers: jroelofs, danalbert, mclow.lists. bcraig added a subscriber: cfe-commits. Herald added subscribers: srhines, danalbert, tberghammer, jfb. This is one part of many of a locale refactor. See http://reviews.llvm.org/D17146 for an idea of where

Re: [PATCH] D17360: [cfi] Fix handling of sanitize trap/recover flags in the cross-DSO CFI mode.

eugenis added a comment. This lets us support the following case: module A checks vcalls and casts, with diagnostics module B checks vcalls but not casts (but it still has bitsets for vtables), with diagnostics then a cast check from module A with a target in module B should print diagnostics

Re: [PATCH] D17104: [VFS] Drop path traversal assertion

bruno updated this revision to Diff 48397. bruno added a comment. Updated the patch, with the following changes: Handle ".", ".." and "./" with trailing slashes while collecting files to be dumped into the vfs overlay directory. Include the support for symlinks into components. Given

[PATCH] D17410: [libcxxabi] Respect LIBCXXABI_LIBDIR_SUFFIX before an install

bcraig created this revision. bcraig added reviewers: mclow.lists, EricWF, danalbert, jroelofs. bcraig added a subscriber: cfe-commits. Prior to this patch, setting LIBCXXABI_LIBDIR_SUFFIX would confuse the check-libcxxabi target. libc++abi.* would get output to lib instead of

Re: [PATCH] D16843: [Sema] Fix bug in TypeLocBuilder::pushImpl

This revision was automatically updated to reflect the committed changes. Closed by commit rL261260: [Sema] Fix bug in TypeLocBuilder::pushImpl (authored by ahatanak). Changed prior to commit: http://reviews.llvm.org/D16843?vs=48387=48392#toc Repository: rL LLVM

r261260 - [Sema] Fix bug in TypeLocBuilder::pushImpl

Author: ahatanak Date: Thu Feb 18 15:05:09 2016 New Revision: 261260 URL: http://llvm.org/viewvc/llvm-project?rev=261260=rev Log: [Sema] Fix bug in TypeLocBuilder::pushImpl The code in TypeLocBuilder::pushImpl wasn't correctly handling the case where an element that has an 8-byte alignment was

Re: [PATCH] D16749: [OpenMP] Map clause codegeneration.

sfantao added a comment. Hi Alexey, Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:3901-3932 @@ +3900,34 @@ +// Reference types are ignored for mapping purposes. +if (auto *RefTy = ExprTy->getAs()) + ExprTy = RefTy->getPointeeType().getCanonicalType(); + +// Given

[PATCH] D17407: [Sema] PR25755 Fix crash when initializing out-of-order struct references

hintonda created this revision. hintonda added a reviewer: rsmith. hintonda added a subscriber: cfe-commits. Remove assert that fired whenever initialization lists had errors, and pass VerifyOnly=false to PerformEmptyInit so we'll get diagnostics. http://reviews.llvm.org/D17407 Files:

Re: [PATCH] D16843: [Sema] Fix bug in TypeLocBuilder::pushImpl

manmanren added a comment. Thanks Akira, LGTM. Manman http://reviews.llvm.org/D16843 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D16843: [Sema] Fix bug in TypeLocBuilder::pushImpl

ahatanak updated this revision to Diff 48387. ahatanak added a comment. Fix indentation. http://reviews.llvm.org/D16843 Files: lib/Sema/TypeLocBuilder.cpp test/SemaObjCXX/typeloc-data-alignment.mm Index: test/SemaObjCXX/typeloc-data-alignment.mm

r261252 - Use Backend_EmitMCNull for null codegen unit tests.

Author: dlj Date: Thu Feb 18 14:27:16 2016 New Revision: 261252 URL: http://llvm.org/viewvc/llvm-project?rev=261252=rev Log: Use Backend_EmitMCNull for null codegen unit tests. Using Backend_EmitLL attemps to create a file with an empty filename. This is problematic in certain environments: an

Re: [PATCH] D17405: Use Backend_EmitMCNull for null codegen unit tests.

This revision was automatically updated to reflect the committed changes. Closed by commit rL261252: Use Backend_EmitMCNull for null codegen unit tests. (authored by dlj). Changed prior to commit: http://reviews.llvm.org/D17405?vs=48380=48386#toc Repository: rL LLVM

Re: [PATCH] D16843: [Sema] Fix bug in TypeLocBuilder::pushImpl

ahatanak updated this revision to Diff 48384. ahatanak added a comment. Address Manman's review comments. Handle elements with "LocalAlignment == 8" similarly to those with "LocalAlignment == 4". http://reviews.llvm.org/D16843 Files: lib/Sema/TypeLocBuilder.cpp

Re: [PATCH] D17405: Use Backend_EmitMCNull for null codegen unit tests.

rsmith added a subscriber: rsmith. rsmith accepted this revision. rsmith added a reviewer: rsmith. rsmith added a comment. This revision is now accepted and ready to land. LGTM http://reviews.llvm.org/D17405 ___ cfe-commits mailing list

r261251 - Make test less prone to attribute changes

Author: kparzysz Date: Thu Feb 18 14:02:03 2016 New Revision: 261251 URL: http://llvm.org/viewvc/llvm-project?rev=261251=rev Log: Make test less prone to attribute changes Modified: cfe/trunk/test/CodeGen/ms-intrinsics.c Modified: cfe/trunk/test/CodeGen/ms-intrinsics.c URL:

[PATCH] D17405: Use Backend_EmitMCNull for null codegen unit tests.

dlj created this revision. dlj added a subscriber: cfe-commits. Using Backend_EmitLL attemps to create a file with an empty filename. This is problematic in certain environments: an empty filename may be illegal, or the default output path may not be writable (in the case where an empty filename

Re: [PATCH] D17170: [OPENMP] Codegen for distribute directive

carlo.bertolli updated this revision to Diff 48379. carlo.bertolli marked 4 inline comments as done. carlo.bertolli added a comment. Partially address comments to replace schedule type with schedule num in interface of static function generating call to kmpc_for_static_init. Still waiting for

Re: [PATCH] D17170: [OPENMP] Codegen for distribute directive

carlo.bertolli added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.h:187-208 @@ -185,30 +186,24 @@ + +public: /// \brief Values for bit flags used in the ident_t to describe the fields. /// All enumeric elements are named and described in accordance with the code

Re: [PATCH] D17019: [OpenMP] Code generation for teams - kernel launching

sfantao added a comment. Hi Alexey Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:3799-3806 @@ -3780,4 +3798,10 @@ OffloadEntriesInfoManager.registerTargetRegionEntryInfo( DeviceID, FileID, ParentName, Line, OutlinedFn, OutlinedFnID); } +/// \brief Emit the num_teams

Re: [PATCH] D17397: Make deprecation message for -fsanitize-coverage= with numeric argument friendlier.

thakis closed this revision. thakis added a comment. 261247 http://reviews.llvm.org/D17397 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D16552: Implement the likely resolution of core issue 253.

thakis updated this revision to Diff 48376. thakis added a comment. update test http://reviews.llvm.org/D16552 Files: include/clang/AST/DeclCXX.h lib/AST/ASTImporter.cpp lib/AST/DeclCXX.cpp lib/Sema/SemaInit.cpp lib/Serialization/ASTReaderDecl.cpp lib/Serialization/ASTWriter.cpp

Re: [PATCH] D16552: Implement the likely resolution of core issue 253.

thakis added inline comments. Comment at: lib/AST/DeclCXX.cpp:403-413 @@ +402,13 @@ + for (const auto *F : fields()) { +if (F->hasInClassInitializer() || F->isMutable() || F->isUnnamedBitfield()) + continue; +if (CXXRecordDecl *FieldType =

Re: [PATCH] D16552: Implement the likely resolution of core issue 253.

thakis added a comment. thanks! Comment at: include/clang/AST/DeclCXX.h:405-416 @@ -404,1 +404,14 @@ +enum AllowConstDefInitKind { + ACDI_Unknown, + ACDI_Yes, + ACDI_No, +}; +unsigned AllowConstDefaultInit : 3; +AllowConstDefInitKind

Re: [PATCH] D16552: Implement the likely resolution of core issue 253.

thakis updated this revision to Diff 48373. thakis marked an inline comment as done. thakis added a comment. address comments http://reviews.llvm.org/D16552 Files: include/clang/AST/DeclCXX.h lib/AST/ASTImporter.cpp lib/AST/DeclCXX.cpp lib/Sema/SemaInit.cpp

Re: [PATCH] D17019: [OpenMP] Code generation for teams - kernel launching

ABataev added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:3799-3806 @@ -3780,4 +3798,10 @@ OffloadEntriesInfoManager.registerTargetRegionEntryInfo( DeviceID, FileID, ParentName, Line, OutlinedFn, OutlinedFnID); } +/// \brief Emit the num_teams clause

r261243 - [analyzer] Improve modeling of ObjC synthesized property setters.

Author: dcoughlin Date: Thu Feb 18 13:13:30 2016 New Revision: 261243 URL: http://llvm.org/viewvc/llvm-project?rev=261243=rev Log: [analyzer] Improve modeling of ObjC synthesized property setters. When modeling a call to a setter for a property that is synthesized to be backed by an instance

Re: [PATCH] D17148: [OPENMP] Basic teams directive implementation

carlo.bertolli updated this revision to Diff 48369. carlo.bertolli added a comment. Addressed latest comments. Repository: rL LLVM http://reviews.llvm.org/D17148 Files: lib/CodeGen/CGOpenMPRuntime.cpp lib/CodeGen/CGOpenMPRuntime.h lib/CodeGen/CGStmtOpenMP.cpp

Re: [PATCH] D17148: [OPENMP] Basic teams directive implementation

carlo.bertolli marked 4 inline comments as done. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:4426-4431 @@ +4425,8 @@ + SourceLocation Loc) { + llvm::Value *PushNumTeamsArgs[] = { + emitUpdateLocation(CGF, Loc), getThreadID(CGF, Loc),

Re: [PATCH] D16552: Implement the likely resolution of core issue 253.

rsmith added inline comments. Comment at: include/clang/AST/DeclCXX.h:405-416 @@ -404,1 +404,14 @@ +enum AllowConstDefInitKind { + ACDI_Unknown, + ACDI_Yes, + ACDI_No, +}; +unsigned AllowConstDefaultInit : 3; +AllowConstDefInitKind

Re: [PATCH] D16749: [OpenMP] Map clause codegeneration.

sfantao added a comment. Hi Alexey, Thanks for the feedback! Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:3901-3932 @@ +3900,34 @@ +// Reference types are ignored for mapping purposes. +if (auto *RefTy = ExprTy->getAs()) + ExprTy =

Re: [PATCH] D17397: Make deprecation message for -fsanitize-coverage= with numeric argument friendlier.

kcc accepted this revision. kcc added a comment. This revision is now accepted and ready to land. LGTM Thanks! I don't see much value in doing this, but also don't mind. http://reviews.llvm.org/D17397 ___ cfe-commits mailing list

Re: [PATCH] D17349: ARM: fix VFP asm constraints

jfb updated this revision to Diff 48363. jfb added a comment. - Add test. http://reviews.llvm.org/D17349 Files: lib/Basic/Targets.cpp test/CodeGen/arm-vfp-asm-constraint.c Index: test/CodeGen/arm-vfp-asm-constraint.c === ---

Re: [PATCH] D16928: [OpenCL] Apply missing restrictions for Blocks in OpenCL v2.0

Anastasia added a comment. @Mats, I think I would prefer not to add even more special handling (i.e. error in this case) for printf. I will look into adding it as a Builtin instead. However, I would prefer to remove it from this change and submit a separate patch as it doesn't belong to Clang

[PATCH] D17397: Make deprecation message for -fsanitize-coverage= with numeric argument friendlier.

thakis created this revision. thakis added a reviewer: kcc. thakis added a subscriber: cfe-commits. http://reviews.llvm.org/D17397 Files: lib/Driver/SanitizerArgs.cpp test/Driver/fsanitize-coverage.c Index: test/Driver/fsanitize-coverage.c

Re: [PATCH] D15829: [PGO] Clang Option that enables IR level PGO instrumentation

davidxl added inline comments. Comment at: lib/CodeGen/CodeGenModule.cpp:150 @@ -149,2 +149,3 @@ - if (!CodeGenOpts.InstrProfileInput.empty()) { + if (!CodeGenOpts.hasProfileIRInstr() && + !CodeGenOpts.InstrProfileInput.empty()) { Better to use if

Re: [PATCH] D16012: Carry raw string literal information through to the AST StringLiteral representation

LegalizeAdulthood added a comment. In http://reviews.llvm.org/D16012#351827, @rsmith wrote: > I'm definitely sympathetic to making `StringLiteralParser` expose information > [...] I was unaware of this class; so far I have only studied the classes appearing in the AST. I did notice that the

Embedded Bitcode in Object Files

Hi all I put up some patches for embedding bitcode inside the object file (-fembed-bitcode) option. As I described in the dev list before, the new option can create normal object file with bitcode embedded in a special section. You can easily recreate the same object file with the embedded

Re: [PATCH] D16552: Implement the likely resolution of core issue 253.

thakis added inline comments. Comment at: include/clang/AST/DeclCXX.h:410 @@ +409,3 @@ +}; +unsigned AllowConstDefaultInit : 3; +AllowConstDefInitKind allowConstDefInitKind() { This should be :2 of course. http://reviews.llvm.org/D16552

Re: [PATCH] D16843: [Sema] Fix bug in TypeLocBuilder::pushImpl

manmanren added a comment. > If Capacity is not a multiple of 8, (LocalSize + NumBytesAtAlign4) % 8 > doesn't tell you whether the new element will be 8-byte aligned. For example, > if Capacity==36, NumBytesAtAlign4==4, and LocalSize==8, (LocalSize + > NumBytesAtAlign4) equals 12 but padding

[libcxx] r261230 - Split locale management out of ibm/xlocale.h. NFCI

Author: bcraig Date: Thu Feb 18 11:37:33 2016 New Revision: 261230 URL: http://llvm.org/viewvc/llvm-project?rev=261230=rev Log: Split locale management out of ibm/xlocale.h. NFCI This is one part of many of a locale refactor. See http://reviews.llvm.org/D17146 for an idea of where this is going.

[libcxx] r261231 - Split locale management out of newlib/xlocale.h. NFCI

Author: bcraig Date: Thu Feb 18 11:40:16 2016 New Revision: 261231 URL: http://llvm.org/viewvc/llvm-project?rev=261231=rev Log: Split locale management out of newlib/xlocale.h. NFCI This is one part of many of a locale refactor. See http://reviews.llvm.org/D17146 for an idea of where this is

[PATCH] D17392: Embed bitcode in object file (clang cc1 part)

steven_wu created this revision. steven_wu added a subscriber: cfe-commits. steven_wu added a dependency: D17390: Introduce -fembed-bitcode driver option. Teach clang to embed bitcode inside bitcode. When -fembed-bitcode cc1 option is used, clang will embed both the input bitcode and cc1

Re: [PATCH] D17389: Embed bitcode in object file (clang cc1 part)

steven_wu abandoned this revision. steven_wu added a comment. I accidentally send this patch with everything in it. I will send out patch in small chunks instead. http://reviews.llvm.org/D17389 ___ cfe-commits mailing list

[PATCH] D17390: Introduce -fembed-bitcode driver option

steven_wu created this revision. steven_wu added a subscriber: cfe-commits. This is the clang driver part of the change to embedded bitcode. This includes: 1. -fembed-bitcode option which breaks down the compilation into two stages. The first stage emits optimized bitcode and the second stage

[PATCH] D17389: Embed bitcode in object file (clang cc1 part)

steven_wu created this revision. steven_wu added a subscriber: cfe-commits. Herald added subscribers: dschuff, jfb. Teach clang to embed bitcode inside bitcode. When -fembed-bitcode cc1 option is used, clang will embed both the input bitcode and cc1 commandline into the bitcode in special

[PATCH] D17387: Add check for CERT FLP30-C

aaron.ballman created this revision. aaron.ballman added reviewers: alexfh, sbenza. aaron.ballman added a subscriber: cfe-commits. This patch adds a check for the CERT secure coding rule: FLP30-C. Do not use floating-point variables as loop counters. It flags any for loop induction expression

Re: [PATCH] D17385: clang-format: [JS] single quote double quoted strings.

mprobst updated this revision to Diff 48338. mprobst added a comment. Fixed typo. http://reviews.llvm.org/D17385 Files: lib/Format/Format.cpp unittests/Format/FormatTestJS.cpp Index: unittests/Format/FormatTestJS.cpp === ---

Re: [PATCH] D16843: [Sema] Fix bug in TypeLocBuilder::pushImpl

On Thu, Feb 18, 2016 at 8:47 AM, Akira Hatanaka wrote: > On Thu, Feb 18, 2016 at 8:10 AM, Manman Ren wrote: > >> >> >> On Wed, Feb 17, 2016 at 10:33 PM, Akira Hatanaka >> wrote: >> >>> ahatanak added a comment. >>> >>> OK, I now

Re: r257763 - clang-format: Fix incorrectly enforced linebreak with ColumnLimit 0.

On Thu, Jan 14, 2016 at 5:36 AM, Daniel Jasper via cfe-commits wrote: > Author: djasper > Date: Thu Jan 14 07:36:46 2016 > New Revision: 257763 > > URL: http://llvm.org/viewvc/llvm-project?rev=257763=rev > Log: > clang-format: Fix incorrectly enforced linebreak with

[PATCH] D17385: clang-format: [JS] single quote double quoted strings.

mprobst created this revision. mprobst added a reviewer: djasper. mprobst added a subscriber: cfe-commits. Herald added a subscriber: klimek. http://reviews.llvm.org/D17385 Files: lib/Format/Format.cpp unittests/Format/FormatTestJS.cpp Index: unittests/Format/FormatTestJS.cpp

r261223 - File missed from r261222

Author: sepavloff Date: Thu Feb 18 10:43:24 2016 New Revision: 261223 URL: http://llvm.org/viewvc/llvm-project?rev=261223=rev Log: File missed from r261222 Added: cfe/trunk/unittests/Frontend/CodeGenActionTest.cpp Added: cfe/trunk/unittests/Frontend/CodeGenActionTest.cpp URL:

Re: [PATCH] D16843: [Sema] Fix bug in TypeLocBuilder::pushImpl

On Thu, Feb 18, 2016 at 8:10 AM, Manman Ren wrote: > > > On Wed, Feb 17, 2016 at 10:33 PM, Akira Hatanaka > wrote: > >> ahatanak added a comment. >> >> OK, I now understand what you meant. >> >> > How about the following? >> >> > >> >> > else if

r261222 - Avoid double deletion in Clang driver.

Author: sepavloff Date: Thu Feb 18 10:42:09 2016 New Revision: 261222 URL: http://llvm.org/viewvc/llvm-project?rev=261222=rev Log: Avoid double deletion in Clang driver. Llvm module object is shared between CodeGenerator and BackendConsumer, in both classes it is stored as std::unique_ptr, which

Re: [PATCH] D17375: Add parentheses around arithmetic in operand of '|' in llvm-dwp.cpp.

On Thu, Feb 18, 2016 at 5:39 PM, David Blaikie wrote: > Thanks all! Which compiler flagged this? Wonder if/why Clang didn't flag it > for me? It was coming from GCC 4.9. Haven't checked if Clang also has this somewhere. > On Thu, Feb 18, 2016 at 5:27 AM, Phabricator via

r261221 - Add an AST matcher for real floating-point types. e.g., float, double, long double, but not complex.

Author: aaronballman Date: Thu Feb 18 10:36:01 2016 New Revision: 261221 URL: http://llvm.org/viewvc/llvm-project?rev=261221=rev Log: Add an AST matcher for real floating-point types. e.g., float, double, long double, but not complex. Modified: cfe/trunk/docs/LibASTMatchersReference.html

Re: [PATCH] D17375: Add parentheses around arithmetic in operand of '|' in llvm-dwp.cpp.

Thanks all! Which compiler flagged this? Wonder if/why Clang didn't flag it for me? On Thu, Feb 18, 2016 at 5:27 AM, Phabricator via cfe-commits < cfe-commits@lists.llvm.org> wrote: > This revision was automatically updated to reflect the committed changes. > Closed by commit rL261207: Add

Re: [PATCH] D17380: [libcxx] Split locale management out of ibm/xlocale.h. NFCI

jroelofs added a subscriber: jroelofs. jroelofs accepted this revision. jroelofs added a reviewer: jroelofs. jroelofs added a comment. This revision is now accepted and ready to land. LGTM http://reviews.llvm.org/D17380 ___ cfe-commits mailing list

Re: [PATCH] D17382: [libcxx] Split locale management out of newlib/xlocale.h. NFCI

jroelofs accepted this revision. jroelofs added a comment. This revision is now accepted and ready to land. LGTM http://reviews.llvm.org/D17382 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D16843: [Sema] Fix bug in TypeLocBuilder::pushImpl

On Wed, Feb 17, 2016 at 10:33 PM, Akira Hatanaka wrote: > ahatanak added a comment. > > OK, I now understand what you meant. > > > How about the following? > > > > > > else if (LocalAlignment == 8) { > > > if (NumBytesAtAlign8 == 0) { > > > // We have not seen any

Re: [PATCH] D15883: Add ARM EHABI-related constants to unwind.h.

logan added inline comments. Comment at: lib/Headers/unwind.h:61 @@ +60,3 @@ +#define _UNWIND_ARM_EHABI 0 +#endif + compnerd wrote: > logan wrote: > > compnerd wrote: > > > logan wrote: > > > > Since this is `unwind.h`, I feel that we can get a step further and

[PATCH] D17382: [libcxx] Split locale management out of newlib/xlocale.h. NFCI

bcraig created this revision. bcraig added reviewers: jroelofs, mclow.lists. bcraig added a subscriber: cfe-commits. Herald added a subscriber: jfb. This is one part of many of a locale refactor. See http://reviews.llvm.org/D17146 for an idea of where this is going. For the locale refactor, the

Re: r258524 - Merge templated static member variables, fixes http://llvm.org/pr26179.

Тhanks, could you (or smb else with commit perms) check it in? --Vassil On 18/02/16 03:24, Richard Smith wrote: (And otherwise this LGTM.) On Wed, Feb 17, 2016 at 5:24 PM, Richard Smith wrote: + // TODO: Check visibility. New is hidden but has a complete type. If

r261219 - [analyzer] dump_ast_matchers.py: fix replacement regexps

Author: ygribov Date: Thu Feb 18 09:43:56 2016 New Revision: 261219 URL: http://llvm.org/viewvc/llvm-project?rev=261219=rev Log: [analyzer] dump_ast_matchers.py: fix replacement regexps Patch by Alex Sidorin! Differential Revision: http://reviews.llvm.org/D17376 Modified:

  1   2   >