Re: r261552 - [VFS] Add 'overlay-relative' field to YAML files

Reverted r261552 & r261556 in r261613. Waiting for next win bot results to see if it's necessary to revert r261551 as well. On Mon, Feb 22, 2016 at 7:16 PM, Bruno Cardoso Lopes wrote: > Yes, but because of a related but different issue. The same as here: >

Re: [PATCH] D17092: [X86] Add -mseparate-stack-seg

delena added a subscriber: delena. Comment at: lib/CodeGen/TargetInfo.cpp:1569 @@ +1568,3 @@ +CGF.getTarget().getTargetOpts().Features; + if (std::find(TargetFeatures.begin(), TargetFeatures.end(), +"+separate-stack-seg") != TargetFeatures.end()) {

r261613 - Revert "[VFS] Add 'overlay-relative' field to YAML files" and "[VFS] Fix call to getVFSFromYAML in unittests"

Author: bruno Date: Tue Feb 23 01:06:12 2016 New Revision: 261613 URL: http://llvm.org/viewvc/llvm-project?rev=261613=rev Log: Revert "[VFS] Add 'overlay-relative' field to YAML files" and "[VFS] Fix call to getVFSFromYAML in unittests" This reverts commit r261552 and r261556 because of failing

Re: [PATCH] D17436: [OpenCL] Add Sema checks for OpenCL 2.0 block

pxli168 added inline comments. Comment at: lib/Sema/SemaDecl.cpp:6714 @@ +6713,3 @@ + if (LangOpts.OpenCLVersion >= 200 && T->isBlockPointerType()) { +const BlockPointerType *BlkTy = T->getAs(); +const FunctionProtoType *FTy = Anastasia wrote: > Yes, but

Re: [PATCH] D17436: [OpenCL] Add Sema checks for OpenCL 2.0 block

pxli168 updated this revision to Diff 48774. http://reviews.llvm.org/D17436 Files: include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaDecl.cpp lib/Sema/SemaExpr.cpp lib/Sema/SemaType.cpp test/SemaOpenCL/invalid-block.cl Index: test/SemaOpenCL/invalid-block.cl

Re: [PATCH] D17437: [OpenCL] Add Sema checks for types

pxli168 updated this revision to Diff 48773. pxli168 added a comment. Add array check for types. http://reviews.llvm.org/D17437 Files: include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaDecl.cpp lib/Sema/SemaType.cpp test/CodeGenOpenCL/opencl_types.cl

LLVM buildmaster restarted in few minutes

Hello everyone, LLVM buildmaster will be updated and restarted in few minutes. Thank you for understanding. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: r261552 - [VFS] Add 'overlay-relative' field to YAML files

Yes, but because of a related but different issue. The same as here: http://lab.llvm.org:8011/builders/clang-x64-ninja-win7/builds/10026 I've been trying to figure it out but it's been hard without a Unix system available. I'll keep investigating and revert later tonight in case I can't guess it.

Re: r261552 - [VFS] Add 'overlay-relative' field to YAML files

The bot is still red: http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast On Mon, Feb 22, 2016 at 6:48 PM, Bruno Cardoso Lopes < bruno.card...@gmail.com> wrote: > Hi Sean, > > This is hopefully fixed in r261556. > > On Mon, Feb 22, 2016 at 5:45 PM, Sean Silva

Re: r261552 - [VFS] Add 'overlay-relative' field to YAML files

Hi Sean, This is hopefully fixed in r261556. On Mon, Feb 22, 2016 at 5:45 PM, Sean Silva wrote: > This or r261551 seem to be causing a build failure: > http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/527 > > -- Sean SIlva > > On

Re: [PATCH] D17438: [OpenCL] Add Sema checks for atomics and implicit declaration

pxli168 added a comment. It seems this patch is useless. The spec does not tell about implicit declaration of function, but now clang with -triple spir will output err if there is implicit declaration of function. I have read about spir and opencl spec but could not find anything talk about

Re: [PATCH] SemaCXX: Support templates in availability attributes

> On 2016-Feb-22, at 17:24, Manman Ren wrote: > > > >> On Feb 8, 2016, at 8:17 PM, Duncan P. N. Exon Smith >> wrote: >> >> This patch adds support for templates in availability attributes. >> - If the context for an availability diagnostic is a >>

Re: [PATCH] D16928: [OpenCL] Apply missing restrictions for Blocks in OpenCL v2.0

pxli168 accepted this revision. pxli168 added a comment. This revision is now accepted and ready to land. Then there will be no problem. I will change my patches as well. LGTM! Thanks. http://reviews.llvm.org/D16928 ___ cfe-commits mailing list

Re: r261552 - [VFS] Add 'overlay-relative' field to YAML files

This or r261551 seem to be causing a build failure: http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/527 -- Sean SIlva On Mon, Feb 22, 2016 at 10:41 AM, Bruno Cardoso Lopes via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: bruno > Date: Mon

Re: r259975 - Fix a crash when emitting dbeug info for forward-declared scoped enums.

Hi Adrian, On Sat, Feb 20, 2016 at 1:18 PM Adrian Prantl wrote: > This had me puzzled for a second, but then I figured out what happened :-) > The “crash” I quoted in the commit message really was an assertion > failure, to be precise, the very assertion I relaxed in LLVM

Re: [PATCH] SemaCXX: Support templates in availability attributes

> On Feb 8, 2016, at 8:17 PM, Duncan P. N. Exon Smith > wrote: > > This patch adds support for templates in availability attributes. > - If the context for an availability diagnostic is a >`FunctionTemplateDecl`, look through it to the `FunctionDecl`. >

Re: [PATCH] D17511: [analyzer] Make ObjCDeallocChecker path sensitive.

zaks.anna added inline comments. Comment at: lib/StaticAnalyzer/Checkers/CheckObjCDealloc.cpp:89 @@ -109,7 +88,3 @@ -static bool synthesizedPropertyRequiresRelease(const ObjCPropertyDecl *PD) { - // A synthesized property must be released if and only if the kind of setter -

r261596 - Lex: Return "" when HeaderMap::lookupFilename fails

Author: dexonsmith Date: Mon Feb 22 18:48:16 2016 New Revision: 261596 URL: http://llvm.org/viewvc/llvm-project?rev=261596=rev Log: Lex: Return "" when HeaderMap::lookupFilename fails Change getString() to return Optional, and change lookupFilename() to return an empty string if either one of

Re: [PATCH] D17248: [Sema] PR26444 fix crash when alignment value is >= 2**16

hintonda added a comment. Thanks David. Btw, could you commit it for me? I don't have commit access. http://reviews.llvm.org/D17248 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D17248: [Sema] PR26444 fix crash when alignment value is >= 2**16

majnemer accepted this revision. majnemer added a comment. This revision is now accepted and ready to land. LGTM http://reviews.llvm.org/D17248 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D16821: Add whole-program vtable optimization feature to Clang.

On Mon, Feb 22, 2016 at 03:59:01PM -0800, Mehdi Amini wrote: > > > On Feb 22, 2016, at 3:47 PM, Peter Collingbourne wrote: > > > > On Mon, Feb 22, 2016 at 01:38:27PM -0800, Pete Cooper wrote: > >> > >>> On Feb 22, 2016, at 1:30 PM, Peter Collingbourne wrote:

Re: [PATCH] D17511: [analyzer] Make ObjCDeallocChecker path sensitive.

dcoughlin added a subscriber: cfe-commits. dcoughlin updated this revision to Diff 48750. dcoughlin added a comment. Provide diff with context. Apologies for leaving that out. http://reviews.llvm.org/D17511 Files: lib/StaticAnalyzer/Checkers/CheckObjCDealloc.cpp

Re: [PATCH] D16821: Add whole-program vtable optimization feature to Clang.

> On Feb 22, 2016, at 3:47 PM, Peter Collingbourne wrote: > > On Mon, Feb 22, 2016 at 01:38:27PM -0800, Pete Cooper wrote: >> >>> On Feb 22, 2016, at 1:30 PM, Peter Collingbourne wrote: >>> >>> One thing that I'd like to do (and this would help CFI as well)

Re: [PATCH] D16821: Add whole-program vtable optimization feature to Clang.

On Mon, Feb 22, 2016 at 01:38:27PM -0800, Pete Cooper wrote: > > > On Feb 22, 2016, at 1:30 PM, Peter Collingbourne wrote: > > > > One thing that I'd like to do (and this would help CFI as well) is to > > specifically recognize cases like this: > > > > ``` > > struct B { > >

[PATCH] D17528: [analyzer] Warn on use of 'self' after call to to [super dealloc].

dcoughlin created this revision. dcoughlin added a reviewer: zaks.anna. dcoughlin added a subscriber: cfe-commits. Referring to 'self' after a call to [super dealloc] is a use-after-free in Objective-C because NSObject's -dealloc frees the memory pointed to by self. This patch extends the

Re: [PATCH] D17248: [Sema] PR26444 fix crash when alignment value is >= 2**16

hintonda updated this revision to Diff 48742. hintonda added a comment. Added comment Added comment to test file. http://reviews.llvm.org/D17248 Files: lib/CodeGen/CGValue.h test/Sema/attr-aligned.c Index: test/Sema/attr-aligned.c

Buildbot numbers for week of 2/14/2016 - 2/20/2016

Hello everyone, Below are some buildbot numbers for the last week of 2/14/2016 - 2/20/2016. Thanks Galina "Status change ratio" by active builder (percent of builds that changed the builder status from greed to red or from red to green): buildername

Re: [PATCH] D17484: [clang-tidy] introduce modernize-deprecated-headers check

alexfh added inline comments. Comment at: clang-tidy/modernize/DeprecatedHeadersCheck.cpp:78 @@ +77,3 @@ + if (LangOpts.CPlusPlus11) { +std::vector> Cxx11DeprecatedHeaders = { +{"fenv.h", "cfenv"}, This can be done

Re: [PATCH] D17516: AMDGPU: Verify subtarget specific builtins

arsenm added inline comments. Comment at: lib/Basic/Targets.cpp:2059-2063 @@ +2058,7 @@ + + if (Has16BitInsts) +Features["16-bit-insts"] = true; + + if (hasSMemRealTime) +Features["s-memrealtime"] = true; + echristo wrote: > This is typically more of

Re: r261574 - [ASTMatchers] Add matcher hasAnyName.

On Mon, Feb 22, 2016 at 5:27 PM, Hans Wennborg wrote: > On Mon, Feb 22, 2016 at 1:13 PM, Samuel Benzaquen via cfe-commits > wrote: > > Author: sbenza > > Date: Mon Feb 22 15:13:02 2016 > > New Revision: 261574 > > > > URL:

Re: r261574 - [ASTMatchers] Add matcher hasAnyName.

On Mon, Feb 22, 2016 at 4:44 PM, Aaron Ballman wrote: > On Mon, Feb 22, 2016 at 4:43 PM, Samuel Benzaquen > wrote: > > > > On Mon, Feb 22, 2016 at 4:19 PM, Aaron Ballman > > wrote: > >> > >> On Mon, Feb 22, 2016 at 4:13 PM,

Re: r261448 - Lex: Check buckets on header map construction

> On 2016-Feb-22, at 10:39, Adrian Prantl wrote: > >> >> On Feb 20, 2016, at 1:00 PM, Duncan P. N. Exon Smith via cfe-commits >> wrote: >> >> Author: dexonsmith >> Date: Sat Feb 20 15:00:58 2016 >> New Revision: 261448 >> >> URL:

r261585 - Lex: Check for 0 buckets on header map construction

Author: dexonsmith Date: Mon Feb 22 16:24:22 2016 New Revision: 261585 URL: http://llvm.org/viewvc/llvm-project?rev=261585=rev Log: Lex: Check for 0 buckets on header map construction Switch to using `isPowerOf2_32()` to check whether the buckets are a power of two, and as a side benefit reject

Re: r261574 - [ASTMatchers] Add matcher hasAnyName.

On Mon, Feb 22, 2016 at 1:13 PM, Samuel Benzaquen via cfe-commits wrote: > Author: sbenza > Date: Mon Feb 22 15:13:02 2016 > New Revision: 261574 > > URL: http://llvm.org/viewvc/llvm-project?rev=261574=rev > Log: > [ASTMatchers] Add matcher hasAnyName. > > Summary: Add

r261583 - Fix Visual Studio build after r261574

Author: hans Date: Mon Feb 22 16:21:58 2016 New Revision: 261583 URL: http://llvm.org/viewvc/llvm-project?rev=261583=rev Log: Fix Visual Studio build after r261574 Modified: cfe/trunk/include/clang/ASTMatchers/ASTMatchers.h cfe/trunk/lib/ASTMatchers/ASTMatchersInternal.cpp Modified:

Re: r261574 - [ASTMatchers] Add matcher hasAnyName.

On Mon, Feb 22, 2016 at 4:43 PM, Samuel Benzaquen wrote: > > On Mon, Feb 22, 2016 at 4:19 PM, Aaron Ballman > wrote: >> >> On Mon, Feb 22, 2016 at 4:13 PM, Samuel Benzaquen via cfe-commits >> wrote: >> > Author: sbenza >> >

Re: r261574 - [ASTMatchers] Add matcher hasAnyName.

On Mon, Feb 22, 2016 at 4:19 PM, Aaron Ballman wrote: > On Mon, Feb 22, 2016 at 4:13 PM, Samuel Benzaquen via cfe-commits > wrote: > > Author: sbenza > > Date: Mon Feb 22 15:13:02 2016 > > New Revision: 261574 > > > > URL:

Re: [PATCH] D16821: Add whole-program vtable optimization feature to Clang.

> On Feb 22, 2016, at 1:30 PM, Peter Collingbourne wrote: > > One thing that I'd like to do (and this would help CFI as well) is to > specifically recognize cases like this: > > ``` > struct B { > virtual void vf(); > }; > > struct D1 { > }; I assume you meant D1 : B here?

Re: [PATCH] D16821: Add whole-program vtable optimization feature to Clang.

pcc added inline comments. Comment at: lib/CodeGen/CGVTables.cpp:904-919 @@ -900,5 +903,18 @@ + +bool CodeGenModule::IsBitSetBlacklistedRecord(const CXXRecordDecl *RD) { + std::string TypeName = RD->getQualifiedNameAsString(); + auto isInBlacklist = [&](const SanitizerBlacklist

Re: r261574 - [ASTMatchers] Add matcher hasAnyName.

On Mon, Feb 22, 2016 at 4:13 PM, Samuel Benzaquen via cfe-commits wrote: > Author: sbenza > Date: Mon Feb 22 15:13:02 2016 > New Revision: 261574 > > URL: http://llvm.org/viewvc/llvm-project?rev=261574=rev > Log: > [ASTMatchers] Add matcher hasAnyName. > > Summary: Add

r261574 - [ASTMatchers] Add matcher hasAnyName.

Author: sbenza Date: Mon Feb 22 15:13:02 2016 New Revision: 261574 URL: http://llvm.org/viewvc/llvm-project?rev=261574=rev Log: [ASTMatchers] Add matcher hasAnyName. Summary: Add matcher hasAnyName as an optimization over anyOf(hasName(),...) Reviewers: alexfh Subscribers: klimek, cfe-commits

Re: [PATCH] D17163: [ASTMatchers] Add matcher hasAnyName.

This revision was automatically updated to reflect the committed changes. Closed by commit rL261574: [ASTMatchers] Add matcher hasAnyName. (authored by sbenza). Changed prior to commit: http://reviews.llvm.org/D17163?vs=47802=48720#toc Repository: rL LLVM http://reviews.llvm.org/D17163

Re: [PATCH] D17516: AMDGPU: Verify subtarget specific builtins

echristo added inline comments. Comment at: lib/Basic/Targets.cpp:1829 @@ -1820,2 +1828,3 @@ } + AddrSpaceMap = Extra whitespace. Comment at: lib/Basic/Targets.cpp:2059-2063 @@ +2058,7 @@ + + if (Has16BitInsts) +

Re: [PATCH] D16993: Add documentation for bitreverse builtins

arsenm added a comment. ping http://reviews.llvm.org/D16993 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [modules] PR24954

On 02/02/16 02:52, Richard Smith via cfe-commits wrote: On Thu, Jan 28, 2016 at 8:23 AM, Vassil Vassilev wrote: Would this patch be more reasonable? It follows what RegisterTemplateSpecialization (introduced in r245779) does. AFAICT this adds an update record far less often.

[PATCH] D17520: AMDGPU: Fix inconsistent register name for flat_scratch

arsenm created this revision. arsenm added a reviewer: tstellarAMD. arsenm added a subscriber: cfe-commits. http://reviews.llvm.org/D17520 Files: lib/Basic/Targets.cpp test/CodeGenOpenCL/amdgcn-flat-scratch-name.cl Index: test/CodeGenOpenCL/amdgcn-flat-scratch-name.cl

r261563 - clang-format: [JS] Add @return to the supported JSDoc pragmas in Google

Author: djasper Date: Mon Feb 22 14:24:11 2016 New Revision: 261563 URL: http://llvm.org/viewvc/llvm-project?rev=261563=rev Log: clang-format: [JS] Add @return to the supported JSDoc pragmas in Google style. Modified: cfe/trunk/lib/Format/Format.cpp Modified: cfe/trunk/lib/Format/Format.cpp

[PATCH] D17519: AMDGPU: Fix broken/confusing predefined macro

arsenm created this revision. arsenm added a reviewer: tstellarAMD. arsenm added a subscriber: cfe-commits. amdgcn should not be defining __R600__ http://reviews.llvm.org/D17519 Files: lib/Basic/Targets.cpp test/Preprocessor/predefined-arch-macros.c Index:

Re: [PATCH] D15829: [PGO] Clang Option that enables IR level PGO instrumentation

xur marked an inline comment as done. xur added a comment. I'll send a revised patch soon. Comment at: lib/CodeGen/CodeGenModule.cpp:150 @@ -149,2 +149,3 @@ - if (!CodeGenOpts.InstrProfileInput.empty()) { + if (!CodeGenOpts.hasProfileIRInstr() && +

r261560 - [WebAssembly] Initial driver support for standard library paths.

Author: djg Date: Mon Feb 22 13:26:15 2016 New Revision: 261560 URL: http://llvm.org/viewvc/llvm-project?rev=261560=rev Log: [WebAssembly] Initial driver support for standard library paths. Modified: cfe/trunk/lib/Driver/ToolChains.cpp cfe/trunk/lib/Driver/Tools.cpp

r261557 - [WebAssembly] Lower va_arg in clang.

Author: djg Date: Mon Feb 22 13:17:40 2016 New Revision: 261557 URL: http://llvm.org/viewvc/llvm-project?rev=261557=rev Log: [WebAssembly] Lower va_arg in clang. This uses the general emitVoidPtrVAArg lowering logic for everything, since this supports all types, and we don't have any special

Re: [PATCH] D17484: [clang-tidy] introduce modernize-deprecated-headers check

omtcyf0 added a comment. Marked the comments as *done*. Comment at: test/clang-tidy/modernize-deprecated-headers-cxx03.cpp:1 @@ +1,2 @@ +// RUN: %check_clang_tidy %s modernize-deprecated-headers %t -- -- -std=c++03 -isystem %S/Inputs/Headers + alexfh wrote: >

Re: [PATCH] D17457: [VFS] Add 'overlay-relative' field to YAML files

bruno closed this revision. bruno added a comment. Committed r261552 / r261556 http://reviews.llvm.org/D17457 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D17104: [VFS] Drop path traversal assertion

bruno closed this revision. bruno added a comment. Committed r261551 http://reviews.llvm.org/D17104 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D17484: [clang-tidy] introduce modernize-deprecated-headers check

omtcyf0 updated this revision to Diff 48711. omtcyf0 marked 9 inline comments as done. omtcyf0 added a comment. Fixed all the issues @alexfh pointed to. http://reviews.llvm.org/D17484 Files: clang-tidy/modernize/CMakeLists.txt clang-tidy/modernize/DeprecatedHeadersCheck.cpp

Re: r261548 - Add has_feature attribute_availability_with_strict.

On Mon, Feb 22, 2016 at 1:57 PM, Manman Ren wrote: > > On Feb 22, 2016, at 10:37 AM, Aaron Ballman via cfe-commits > wrote: > > On Mon, Feb 22, 2016 at 1:24 PM, Manman Ren via cfe-commits > wrote: > > Author: mren > Date:

r261556 - [VFS] Fix call to getVFSFromYAML in unittests

Author: bruno Date: Mon Feb 22 13:02:27 2016 New Revision: 261556 URL: http://llvm.org/viewvc/llvm-project?rev=261556=rev Log: [VFS] Fix call to getVFSFromYAML in unittests Follow up from r261552 Modified: cfe/trunk/unittests/Basic/VirtualFileSystemTest.cpp Modified:

Re: r261548 - Add has_feature attribute_availability_with_strict.

> On Feb 22, 2016, at 10:37 AM, Aaron Ballman via cfe-commits > wrote: > > On Mon, Feb 22, 2016 at 1:24 PM, Manman Ren via cfe-commits > > wrote: >> Author: mren >> Date: Mon Feb 22 12:24:30 2016 >> New

Re: r261422 - Fix handling of vaargs on PPC32 when going from regsave to overflow.

On Sat, Feb 20, 2016 at 6:29 AM, Hal Finkel wrote: > > > - Original Message - >> From: "Dimitry Andric via cfe-commits" >> To: "Hans Wennborg" >> Cc: "Roman Divacky" , "cfe-commits" >>

r261552 - [VFS] Add 'overlay-relative' field to YAML files

Author: bruno Date: Mon Feb 22 12:41:09 2016 New Revision: 261552 URL: http://llvm.org/viewvc/llvm-project?rev=261552=rev Log: [VFS] Add 'overlay-relative' field to YAML files The VFS overlay mapping between virtual paths and real paths is done through the 'external-contents' entries in YAML

r261551 - [VFS] Add support for handling path traversals

Author: bruno Date: Mon Feb 22 12:41:01 2016 New Revision: 261551 URL: http://llvm.org/viewvc/llvm-project?rev=261551=rev Log: [VFS] Add support for handling path traversals Handle ".", ".." and "./" with trailing slashes while collecting files to be dumped into the vfs overlay directory.

Re: r261448 - Lex: Check buckets on header map construction

> On Feb 20, 2016, at 1:00 PM, Duncan P. N. Exon Smith via cfe-commits > wrote: > > Author: dexonsmith > Date: Sat Feb 20 15:00:58 2016 > New Revision: 261448 > > URL: http://llvm.org/viewvc/llvm-project?rev=261448=rev > Log: > Lex: Check buckets on header map

Re: r261548 - Add has_feature attribute_availability_with_strict.

On Mon, Feb 22, 2016 at 1:24 PM, Manman Ren via cfe-commits wrote: > Author: mren > Date: Mon Feb 22 12:24:30 2016 > New Revision: 261548 > > URL: http://llvm.org/viewvc/llvm-project?rev=261548=rev > Log: > Add has_feature attribute_availability_with_strict. > >

r261548 - Add has_feature attribute_availability_with_strict.

Author: mren Date: Mon Feb 22 12:24:30 2016 New Revision: 261548 URL: http://llvm.org/viewvc/llvm-project?rev=261548=rev Log: Add has_feature attribute_availability_with_strict. rdar://23791325 Modified: cfe/trunk/lib/Lex/PPMacroExpansion.cpp

Re: [PATCH] D17484: [clang-tidy] introduce modernize-deprecated-headers check

omtcyf0 added a comment. Thank you for a review, Alex! I'll clean up the parts you mentioned soon! In http://reviews.llvm.org/D17484#358617, @alexfh wrote: > The most important question to this check is that the standard doesn't > guarantee that the C++ headers declare all the same functions

Re: [PATCH] D17437: [OpenCL] Add Sema checks for types

Anastasia added inline comments. Comment at: test/SemaOpenCL/invalid-image.cl:3 @@ +2,3 @@ + +void test1(image1d_t *i){} // expected-error {{pointer to type 'image1d_t' is invalid in OpenCL}} + Anastasia wrote: > Could we add similar tests for other types too. I

Re: [PATCH] D17446: ASTMatchers: add new statement/decl matchers

LegalizeAdulthood added a subscriber: LegalizeAdulthood. Comment at: docs/LibASTMatchersReference.html:512 @@ +511,3 @@

Re: [PATCH] D17437: [OpenCL] Add Sema checks for types

Anastasia added inline comments. Comment at: test/SemaOpenCL/invalid-image.cl:3 @@ +2,3 @@ + +void test1(image1d_t *i){} // expected-error {{pointer to type 'image1d_t' is invalid in OpenCL}} + Could we add similar tests for other types too. I think we could put

Re: [PATCH] D5238: [analyzer] Detect duplicate [super dealloc] calls

This revision was automatically updated to reflect the committed changes. Closed by commit rL261545: [analyzer] Detect duplicate [super dealloc] calls (authored by dcoughlin). Changed prior to commit: http://reviews.llvm.org/D5238?vs=48447=48707#toc Repository: rL LLVM

r261545 - [analyzer] Detect duplicate [super dealloc] calls

Author: dcoughlin Date: Mon Feb 22 11:56:24 2016 New Revision: 261545 URL: http://llvm.org/viewvc/llvm-project?rev=261545=rev Log: [analyzer] Detect duplicate [super dealloc] calls Add an alpha path checker that warns about duplicate calls to [super dealloc]. This will form the foundation of a

Re: [PATCH] D17436: [OpenCL] Add Sema checks for OpenCL 2.0 block

Anastasia added inline comments. Comment at: lib/Sema/SemaDecl.cpp:6714 @@ +6713,3 @@ + if (LangOpts.OpenCLVersion >= 200 && T->isBlockPointerType()) { +const BlockPointerType *BlkTy = T->getAs(); +const FunctionProtoType *FTy = Yes, but you have to

r261537 - Don't enable /GX by default

Author: majnemer Date: Mon Feb 22 11:44:51 2016 New Revision: 261537 URL: http://llvm.org/viewvc/llvm-project?rev=261537=rev Log: Don't enable /GX by default The /GX flag is disabled unless explicitly specified on the command line. This partially addresses PR26698. Modified:

Re: [PATCH] D17484: [clang-tidy] introduce modernize-deprecated-headers check

LegalizeAdulthood added a comment. In http://reviews.llvm.org/D17484#358617, @alexfh wrote: > Thank you for this check! Mostly looks good, but there are a number of style > nits. > > The most important question to this check is that the standard doesn't > guarantee that the C++ headers declare

[PATCH] D17516: AMDGPU: Verify subtarget specific builtins

arsenm created this revision. arsenm added reviewers: tstellarAMD, echristo. arsenm added a subscriber: cfe-commits. Cleanup setup of subtarget features. http://reviews.llvm.org/D17516 Files: include/clang/Basic/BuiltinsAMDGPU.def lib/Basic/Targets.cpp

[PATCH] D17515: AMDGPU: Add builtins for recently added intrinsics

arsenm created this revision. arsenm added a reviewer: tstellarAMD. arsenm added a subscriber: cfe-commits. http://reviews.llvm.org/D17515 Files: include/clang/Basic/BuiltinsAMDGPU.def test/CodeGenOpenCL/builtins-amdgcn.cl test/SemaOpenCL/builtins-amdgcn.cl Index:

r261535 - [MS ABI] Correctly handle dllimport'd explicit instantiation declaration w/ vbases

Author: majnemer Date: Mon Feb 22 11:22:08 2016 New Revision: 261535 URL: http://llvm.org/viewvc/llvm-project?rev=261535=rev Log: [MS ABI] Correctly handle dllimport'd explicit instantiation declaration w/ vbases We gave a VBTable dllimport storage class and external linkage while also

Re: [PATCH] D16317: [Analyzer] Fix for PR23790: bind real value returned from strcmp when modelling strcmp.

dcoughlin accepted this revision. dcoughlin added a comment. This revision is now accepted and ready to land. Looks great, other than some non-standard indentation. Comment at: lib/StaticAnalyzer/Checkers/CStringChecker.cpp:1886 @@ +1885,3 @@ +

Re: [PATCH] D15636: Reduce false positives in printf/scanf format checker

AndyG added inline comments. Comment at: lib/Sema/SemaChecking.cpp:3905 @@ -3822,14 +3904,3 @@ CoveredArgs.flip(); -signed notCoveredArg = CoveredArgs.find_first(); -if (notCoveredArg >= 0) { - assert((unsigned)notCoveredArg < NumDataArgs); - if (const Expr

r261533 - Add support for Android Vector calling convention for AArch64

Author: niravd Date: Mon Feb 22 10:48:42 2016 New Revision: 261533 URL: http://llvm.org/viewvc/llvm-project?rev=261533=rev Log: Add support for Android Vector calling convention for AArch64 This modification applies the following Android commit when we have an Android environment. This is the

Re: [PATCH] D17170: [OPENMP] Codegen for distribute directive

carlo.bertolli updated this revision to Diff 48691. carlo.bertolli added a comment. Address latest comments. Repository: rL LLVM http://reviews.llvm.org/D17170 Files: include/clang/AST/StmtOpenMP.h lib/CodeGen/CGOpenMPRuntime.cpp lib/CodeGen/CGOpenMPRuntime.h

Re: [PATCH] D17335: [clang-tidy] Fix a crash issue when clang-tidy runs with compilation database.

alexfh added a comment. In http://reviews.llvm.org/D17335#358613, @hokein wrote: > - Don't save BuildDirectory for every error in each check. I think, it's not going to work with multiple files. There's just one Stats instance. Comment at:

Re: [PATCH] D17170: [OPENMP] Codegen for distribute directive

carlo.bertolli marked 5 inline comments as done. carlo.bertolli added a comment. Updating patch following comments. Repository: rL LLVM http://reviews.llvm.org/D17170 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D16928: [OpenCL] Apply missing restrictions for Blocks in OpenCL v2.0

Anastasia added a comment. Yes, that's right. In this commit I assume parser has already accepted the blocks. We currently accept them if -fblocks is passed. I think we should also accept blocks by default with CL2.0. But I am thinking not to restrict passing -fblocks with earlier CL version.

Re: [PATCH] D17345: [OpenCL] Improve diagnostics of address spaces for variables inside function

Anastasia added a comment. Yes, that's right. In this commit I assume parser has already accepted the blocks. We currently accept them if -fblocks is passed. I think we should also accept blocks by default with CL2.0. But I am thinking not to restrict passing -fblocks with earlier CL version.

Re: [PATCH] D17456: [libcxx] Reorganize _LIBCPP_LOCALE__L_EXTENSIONS

bcraig updated the summary for this revision. bcraig added a reviewer: joerg. bcraig updated this revision to Diff 48687. bcraig added a comment. Changed libcxx prefix to libcpp. Changed BSD forwarding macros to macro functions. http://reviews.llvm.org/D17456 Files:

Re: [PATCH] D17484: [clang-tidy] introduce modernize-deprecated-headers check

alexfh added a comment. In http://reviews.llvm.org/D17484#358617, @alexfh wrote: > ... the check in its current form can break the code that uses library > symbols from the global namespace. ... An action item for this is: document this possible issue and add a FIXME somewhere in the code to

[clang-tools-extra] r261530 - Add a new check, cert-env33-c, that diagnoses uses of system(), popen(), and _popen() to execute a command processor. This check corresponds to the CERT secure coding rul

Author: aaronballman Date: Mon Feb 22 10:01:06 2016 New Revision: 261530 URL: http://llvm.org/viewvc/llvm-project?rev=261530=rev Log: Add a new check, cert-env33-c, that diagnoses uses of system(), popen(), and _popen() to execute a command processor. This check corresponds to the CERT secure

Re: [PATCH] D17447: Add check for CERT ENV33-C

aaron.ballman closed this revision. aaron.ballman added a comment. Thanks! I've commit in r261530. http://reviews.llvm.org/D17447 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D17335: [clang-tidy] Fix a crash issue when clang-tidy runs with compilation database.

hokein marked 2 inline comments as done. Comment at: clang-tidy/ClangTidyDiagnosticConsumer.cpp:122 @@ -121,3 +121,3 @@ IsWarningAsError(IsWarningAsError) {} // Returns true if GlobList starts with the negative indicator ('-'), removes it Done. Now

Re: [PATCH] D17335: [clang-tidy] Fix a crash issue when clang-tidy runs with compilation database.

hokein updated this revision to Diff 48686. hokein marked an inline comment as done. hokein added a comment. Address one comment. http://reviews.llvm.org/D17335 Files: clang-tidy/ClangTidy.cpp clang-tidy/ClangTidy.h clang-tidy/ClangTidyDiagnosticConsumer.cpp

Re: [PATCH] D17484: [clang-tidy] introduce modernize-deprecated-headers check

alexfh added a comment. Thank you for this check! Mostly looks good, but there are a number of style nits. The most important question to this check is that the standard doesn't guarantee that the C++ headers declare all the same functions **in the global namespace** (at least, this is how I

Re: [PATCH] D17335: [clang-tidy] Fix a crash issue when clang-tidy runs with compilation database.

hokein updated this revision to Diff 48684. hokein added a comment. Remove an extra blank line. http://reviews.llvm.org/D17335 Files: clang-tidy/ClangTidy.cpp clang-tidy/ClangTidy.h clang-tidy/ClangTidyDiagnosticConsumer.cpp clang-tidy/ClangTidyDiagnosticConsumer.h

Re: [PATCH] D17163: [ASTMatchers] Add matcher hasAnyName.

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. Looks good. Thanks! (I suppose, Manuel has no substantial comments on this, since he has already seen the patch). http://reviews.llvm.org/D17163

[PATCH] D17507: The controlling expression for _Generic is unevaluated

aaron.ballman created this revision. aaron.ballman added a reviewer: rsmith. aaron.ballman added a subscriber: cfe-commits. In r252104, I fixed a _Generic bug so that the controlling expression has its type decayed and qualifiers stripped. However, this caused a diagnostic regression because

Re: [PATCH] D17335: [clang-tidy] Fix a crash issue when clang-tidy runs with compilation database.

hokein updated this revision to Diff 48683. hokein added a comment. Some cleanup. http://reviews.llvm.org/D17335 Files: clang-tidy/ClangTidy.cpp clang-tidy/ClangTidy.h clang-tidy/ClangTidyDiagnosticConsumer.cpp clang-tidy/ClangTidyDiagnosticConsumer.h

Re: [PATCH] D17335: [clang-tidy] Fix a crash issue when clang-tidy runs with compilation database.

hokein updated this revision to Diff 48682. hokein marked an inline comment as done. hokein added a comment. - Don't save BuildDirectory for every error in each check. http://reviews.llvm.org/D17335 Files: clang-tidy/ClangTidy.cpp clang-tidy/ClangTidy.h

Re: [PATCH] D17507: The controlling expression for _Generic is unevaluated

On Mon, Feb 22, 2016 at 10:52 AM, Aaron Ballman wrote: > aaron.ballman created this revision. > aaron.ballman added a reviewer: rsmith. > aaron.ballman added a subscriber: cfe-commits. > > In r252104, I fixed a _Generic bug so that the controlling expression has its >

Re: [PATCH] D17456: [libcxx] Reorganize _LIBCPP_LOCALE__L_EXTENSIONS

mclow.lists added a comment. Actually, the prefix we use in the rest of libc++ for private functions is `__libcpp_` Take a look in type_traits for a bunch of examples. In general, I'm liking the way this is going. I suspect I will have more comments later today.

Re: [PATCH] D17456: [libcxx] Reorganize _LIBCPP_LOCALE__L_EXTENSIONS

On Mon, Feb 22, 2016 at 08:25:56AM -0600, Craig, Ben via cfe-commits wrote: > On 2/19/2016 3:32 PM, Joerg Sonnenberger via cfe-commits wrote: > >On Fri, Feb 19, 2016 at 06:14:18PM +, Ben Craig via cfe-commits wrote: > >>Instead of checking _LIBCPP_LOCALE__L_EXTENSIONS all over, instead >

Re: [PATCH] D17416: [libcxx] Reorganize locale extension fallbacks. NFCI

mclow.lists added a comment. This looks fine to me; but I want to hear from @danalbert. http://reviews.llvm.org/D17416 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

  1   2   >