Re: [PATCH] D18268: [Objective-c] Fix a crash in WeakObjectProfileTy::getBaseInfo

Thanks Jordan. r264025. > On Mar 21, 2016, at 1:08 PM, Jordan Rose wrote: > > Yes, that looks good. For bonus points, add a similar test using the new > property syntax > > @property (class) NSBundle *foo2; > > instead of the method. (I expect that version to behave

r264025 - [Objective-c] Do not set IsExact to true when the receiver is a class.

Author: ahatanak Date: Tue Mar 22 00:00:21 2016 New Revision: 264025 URL: http://llvm.org/viewvc/llvm-project?rev=264025=rev Log: [Objective-c] Do not set IsExact to true when the receiver is a class. IsExact shouldn't be set to true in WeakObjectProfileTy::getBaseInfo when the receiver is a

Re: [PATCH] D17596: [OpenCL] Add ocl and spir version for spir target

pxli168 updated this revision to Diff 51253. pxli168 added a comment. Add test for spir64. http://reviews.llvm.org/D17596 Files: lib/CodeGen/TargetInfo.cpp test/CodeGenOpenCL/spir_version.cl Index: test/CodeGenOpenCL/spir_version.cl

Re: r257934 - [CMake] Support generation of linker order files using dtrace

On Fri, Jan 15, 2016 at 1:21 PM, Chris Bieneman via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: cbieneman > Date: Fri Jan 15 15:21:12 2016 > New Revision: 257934 > > URL: http://llvm.org/viewvc/llvm-project?rev=257934=rev > Log: > [CMake] Support generation of linker order files

r264021 - [Perf-training] Fixing an issue with multi-threading PGO generation

Author: cbieneman Date: Mon Mar 21 21:55:40 2016 New Revision: 264021 URL: http://llvm.org/viewvc/llvm-project?rev=264021=rev Log: [Perf-training] Fixing an issue with multi-threading PGO generation When LIT parallelizes the profraw file generation we need to generate unique temp filenames then

r264020 - Visual Studio Native Visualizations for constructors and methods

Author: mps Date: Mon Mar 21 21:29:22 2016 New Revision: 264020 URL: http://llvm.org/viewvc/llvm-project?rev=264020=rev Log: Visual Studio Native Visualizations for constructors and methods With this change, the class struct A { A(int _i); ~A(); int foo(double d); double bar(A

r264018 - [OpenMP] Base support for target directive codegen on NVPTX device.

Author: arpith Date: Mon Mar 21 20:48:56 2016 New Revision: 264018 URL: http://llvm.org/viewvc/llvm-project?rev=264018=rev Log: [OpenMP] Base support for target directive codegen on NVPTX device. Summary: This patch adds base support for codegen of the target directive on the NVPTX device.

Re: [PATCH] D16965: Fix for Bug 14644 - clang confuses scope operator for global namespace giving extra qualification on member

ryee88 added a comment. Yeah I don't think it's worth it to modify the general case wording to to explicitly call out the degenerate global nested-name-specifier. It'll cause more confusion for the general case. At this point, do we just close the bug and keep the new unit tests?

Re: r202683 - Introduce '-fmodules-user-build-path' which accepts the "canonical" path to a user workspace build.

The long-term intention of this was to separate user modules vs system modules, so that you could have user modules generated in the project-specific build directory while system modules would be in the global directory shared across projects. That way when you deleted the project build

Re: [PATCH] D18325: export additional header modules from xmmintrin

rsmith added a subscriber: rsmith. Comment at: lib/Headers/module.modulemap:48 @@ -47,3 +47,1 @@ - export mmx - export sse2 // note: for hackish dependency header "xmmintrin.h" Did you intentionally remove this comment? Comment

Re: r263974 - clang-cl: With -fmsc-version=1900, use MSVS2015 diag formatting.

On Mon, Mar 21, 2016 at 8:09 PM, Nico Weber wrote: > Thanks, attempting to fix. > > On Mon, Mar 21, 2016 at 7:43 PM, Richard Smith via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> Seems to have caused a bot failure: >> >>

r264008 - [sema] [CUDA] Use std algorithms in EraseUnwantedCUDAMatchesImpl.

Author: jlebar Date: Mon Mar 21 19:09:25 2016 New Revision: 264008 URL: http://llvm.org/viewvc/llvm-project?rev=264008=rev Log: [sema] [CUDA] Use std algorithms in EraseUnwantedCUDAMatchesImpl. Summary: NFC Reviewers: tra Subscribers: cfe-commits Differential Revision:

r264009 - [CUDA] Implement atomicInc and atomicDec builtins

Author: jlebar Date: Mon Mar 21 19:09:28 2016 New Revision: 264009 URL: http://llvm.org/viewvc/llvm-project?rev=264009=rev Log: [CUDA] Implement atomicInc and atomicDec builtins These functions cannot be implemented as atomicrmw or cmpxchg instructions, so they are implemented as a call to the

Re: [PATCH] D18327: [sema] [CUDA] Use std algorithms in EraseUnwantedCUDAMatchesImpl.

This revision was automatically updated to reflect the committed changes. Closed by commit rL264008: [sema] [CUDA] Use std algorithms in EraseUnwantedCUDAMatchesImpl. (authored by jlebar). Changed prior to commit: http://reviews.llvm.org/D18327?vs=51220=51247#toc Repository: rL LLVM

Re: [PATCH] D18322: [CUDA] Implement atomicInc and atomicDec builtins

This revision was automatically updated to reflect the committed changes. Closed by commit rL264009: [CUDA] Implement atomicInc and atomicDec builtins (authored by jlebar). Changed prior to commit: http://reviews.llvm.org/D18322?vs=51191=51248#toc Repository: rL LLVM

Re: r263974 - clang-cl: With -fmsc-version=1900, use MSVS2015 diag formatting.

Thanks, attempting to fix. On Mon, Mar 21, 2016 at 7:43 PM, Richard Smith via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Seems to have caused a bot failure: > > http://lab.llvm.org:8011/builders/clang-x86-win2008-selfhost/builds/7039 > > The NOTRIPLE test appears to be picking up the

Re: r263974 - clang-cl: With -fmsc-version=1900, use MSVS2015 diag formatting.

Reverted in r264007. MSVC_NOTRIPLE and MSVC_ORIG were affected by the default target triple. Nico, could you tweak the test to be stable? On Tue, Mar 22, 2016 at 8:43 AM Richard Smith via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Seems to have caused a bot failure: > >

r264007 - Revert r263974, "clang-cl: With -fmsc-version=1900, use MSVS2015 diag formatting."

Author: chapuni Date: Mon Mar 21 18:51:50 2016 New Revision: 264007 URL: http://llvm.org/viewvc/llvm-project?rev=264007=rev Log: Revert r263974, "clang-cl: With -fmsc-version=1900, use MSVS2015 diag formatting." It seems the test wouldn't expect if default target is *-win32. Modified:

Re: [PATCH] D17950: Implement is_always_lock_free

On Mon, Mar 21, 2016 at 4:46 PM, JF Bastien via cfe-commits wrote: > jfb added inline comments. > > > Comment at: lib/Frontend/InitPreprocessor.cpp:465 > @@ +464,3 @@ > + if (LangOpts.CPlusPlus1z) { > +

Re: [PATCH] D17950: Implement is_always_lock_free

jfb added inline comments. Comment at: lib/Frontend/InitPreprocessor.cpp:465 @@ +464,3 @@ + if (LangOpts.CPlusPlus1z) { +Builder.defineMacro("__cpp_lib_atomic_is_always_lock_free", "201603"); + } rsmith wrote: > This should be defined by the relevant

Re: r263974 - clang-cl: With -fmsc-version=1900, use MSVS2015 diag formatting.

Seems to have caused a bot failure: http://lab.llvm.org:8011/builders/clang-x86-win2008-selfhost/builds/7039 The NOTRIPLE test appears to be picking up the version of MSVC from that installed on the system, so this passes or fails depending on which version of MSVC we find. On Mon, Mar 21, 2016

Re: [PATCH] D17950: Implement is_always_lock_free

rsmith added inline comments. Comment at: lib/Frontend/InitPreprocessor.cpp:465 @@ +464,3 @@ + if (LangOpts.CPlusPlus1z) { +Builder.defineMacro("__cpp_lib_atomic_is_always_lock_free", "201603"); + } This should be defined by the relevant library header, not

Re: [PATCH] D18328: [CUDA] Add option to mark most functions inside as host+device.

rsmith added inline comments. Comment at: lib/Sema/SemaCUDA.cpp:464-465 @@ +463,4 @@ +// without passing -fcuda-allow-std-complex. +// TODO: Output a nvcc-compat warning if you try to use a non-constexpr function +// from -- nvcc only lets you use constexpr functions. +bool

Re: [PATCH] D18328: [CUDA] Add option to mark most functions inside as host+device.

rsmith added inline comments. Comment at: lib/Sema/SemaCUDA.cpp:479-481 @@ +478,5 @@ +return false; + StringRef Filename = FE->getName(); + if (Filename != "complex" && !Filename.endswith("/complex")) +return false; + jlebar wrote: > rsmith wrote: > > I

[clang-tools-extra] r264001 - Fixed some cases in the modularize assistant mode where header file names didn't translate to valid module names.

Author: jtsoftware Date: Mon Mar 21 18:05:14 2016 New Revision: 264001 URL: http://llvm.org/viewvc/llvm-project?rev=264001=rev Log: Fixed some cases in the modularize assistant mode where header file names didn't translate to valid module names. Modified:

Re: [PATCH] D18328: [CUDA] Add option to mark most functions inside as host+device.

jlebar added inline comments. Comment at: include/clang/Driver/Options.td:383-384 @@ -382,2 +382,4 @@ HelpText<"Enable device-side debug info generation. Disables ptxas optimizations.">; +def cuda_allow_std_complex : Flag<["--"], "cuda-allow-std-complex">, + HelpText<"Allow

Re: [PATCH] D18088: Add a new warning to notify users of mismatched SDK and deployment target

edward-san added a comment. I'm more concerned about some users who might think that option would work also with their favourite sdk (visual studio comes into mind as a common sdk). http://reviews.llvm.org/D18088 ___ cfe-commits mailing list

r263997 - [Perf-training] Adding support for tests to skip the clang driver

Author: cbieneman Date: Mon Mar 21 17:37:14 2016 New Revision: 263997 URL: http://llvm.org/viewvc/llvm-project?rev=263997=rev Log: [Perf-training] Adding support for tests to skip the clang driver This patch adds a new set of substitutions to the lit run lines for order files and PGO generation

r263996 - [modules] Store mangling numbers in a deterministic order so they don't cause the resulting .pcm files to be nondeterministic.

Author: rsmith Date: Mon Mar 21 17:33:02 2016 New Revision: 263996 URL: http://llvm.org/viewvc/llvm-project?rev=263996=rev Log: [modules] Store mangling numbers in a deterministic order so they don't cause the resulting .pcm files to be nondeterministic. Modified:

Re: [PATCH] D18328: [CUDA] Add option to mark most functions inside as host+device.

rsmith added inline comments. Comment at: include/clang/Driver/Options.td:383-384 @@ -382,2 +382,4 @@ HelpText<"Enable device-side debug info generation. Disables ptxas optimizations.">; +def cuda_allow_std_complex : Flag<["--"], "cuda-allow-std-complex">, + HelpText<"Allow

Re: [PATCH] D18328: [CUDA] Add option to mark most functions inside as host+device.

jlebar added inline comments. Comment at: include/clang/Driver/Options.td:383-384 @@ -382,2 +382,4 @@ HelpText<"Enable device-side debug info generation. Disables ptxas optimizations.">; +def cuda_allow_std_complex : Flag<["--"], "cuda-allow-std-complex">, + HelpText<"Allow

Re: [PATCH] D18328: [CUDA] Add option to mark most functions inside as host+device.

jlebar added inline comments. Comment at: include/clang/Driver/Options.td:383-384 @@ -382,2 +382,4 @@ HelpText<"Enable device-side debug info generation. Disables ptxas optimizations.">; +def cuda_allow_std_complex : Flag<["--"], "cuda-allow-std-complex">, + HelpText<"Allow

Re: [PATCH] D18328: [CUDA] Add option to mark most functions inside as host+device.

rnk added a comment. In http://reviews.llvm.org/D18328#379824, @rsmith wrote: > I would much prefer for us to, say, provide a header that wraps the > system one and does something like > > // > #pragma clang cuda_implicit_host_device { > #include_next > #pragma clang

Re: [PATCH] D18328: [CUDA] Add option to mark most functions inside as host+device.

jlebar added a comment. Here are two other approaches we considered and rejected, for the record: 1. Copy-paste a implementation from e.g. libc++ into __clang_cuda_runtime_wrapper.h, and edit it appropriately. Then #define the real 's include guards. Main problem with this is the obvious

Re: [PATCH] D18328: [CUDA] Add option to mark most functions inside as host+device.

tra added a comment. In http://reviews.llvm.org/D18328#379824, @rsmith wrote: > I would much prefer for us to, say, provide a header that wraps the > system one and does something like > > // > #pragma clang cuda_implicit_host_device { > #include_next > #pragma clang

Re: [PATCH] D18328: [CUDA] Add option to mark most functions inside as host+device.

jlebar added a comment. Thanks for the suggestions, Richard. I'm not sure any of them will work, but I don't defend this patch as anything other than a hack, so if we can come up with something that works for what we need to accomplish and is cleaner, that's great. In

Re: [PATCH] D18328: [CUDA] Add option to mark most functions inside as host+device.

rnk added inline comments. Comment at: lib/Sema/SemaCUDA.cpp:474 @@ +473,3 @@ + SourceLocation Loc = FD.getLocation(); + if (!SM.isInSystemHeader(Loc)) +return false; jlebar wrote: > tra wrote: > > Can C++ library headers ever be non-system? I.e. can

Re: [PATCH] D18328: [CUDA] Add option to mark most functions inside as host+device.

rsmith added a subscriber: rsmith. rsmith added a comment. I would much prefer for us to, say, provide a header that wraps the system one and does something like // #pragma clang cuda_implicit_host_device { #include_next #pragma clang cuda_implicit_host_device } or to provide an

LLVM buildmaster will be restarted tonight

Hello everyone, LLVM buildmaster will be updated and restarted after 7 PM Pacific time today. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D18328: [CUDA] Add option to mark most functions inside as host+device.

jlebar added inline comments. Comment at: lib/Sema/SemaCUDA.cpp:474 @@ +473,3 @@ + SourceLocation Loc = FD.getLocation(); + if (!SM.isInSystemHeader(Loc)) +return false; tra wrote: > Can C++ library headers ever be non-system? I.e. can someone use libc++

r263989 - [modules] Renumber DECL_UPDATES from 30 to 50, so it no longer collides with

Author: rsmith Date: Mon Mar 21 16:16:01 2016 New Revision: 263989 URL: http://llvm.org/viewvc/llvm-project?rev=263989=rev Log: [modules] Renumber DECL_UPDATES from 30 to 50, so it no longer collides with TYPE_TEMPLATE_SPECIALIZATION. This was fine in practice because both record kinds are only

Re: [PATCH] D17741: adds __FILE_BASENAME__ builtin macro

weimingz added a comment. In http://reviews.llvm.org/D17741#374725, @weimingz wrote: > In http://reviews.llvm.org/D17741#372098, @weimingz wrote: > > > rebased > > > ping~ HI, Any comments/suggestions? http://reviews.llvm.org/D17741 ___

Re: [PATCH] D18328: [CUDA] Add option to mark most functions inside as host+device.

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. One minor question, LGTM otherwise. Comment at: lib/Sema/SemaCUDA.cpp:474 @@ +473,3 @@ + SourceLocation Loc = FD.getLocation(); + if (!SM.isInSystemHeader(Loc)) +return

r263984 - Revert "Convert some ObjC msgSends to runtime calls."

Author: pete Date: Mon Mar 21 15:50:03 2016 New Revision: 263984 URL: http://llvm.org/viewvc/llvm-project?rev=263984=rev Log: Revert "Convert some ObjC msgSends to runtime calls." This reverts commit r263607. This change caused more objc_retain/objc_release calls in the IR but those are then

[PATCH] D18328: [CUDA] Add option to mark most functions inside as host+device.

jlebar created this revision. jlebar added reviewers: tra, rnk. jlebar added subscribers: cfe-commits, jhen. clang --cuda-allow-std-complex translates into cc1 -fcuda-allow-std-complex. With this flag, we will mark all functions inside within namespace std as host+device, other than operator>>

[PATCH] D18327: [sema] [CUDA] Use std algorithms in EraseUnwantedCUDAMatchesImpl.

jlebar created this revision. jlebar added a reviewer: tra. jlebar added a subscriber: cfe-commits. NFC http://reviews.llvm.org/D18327 Files: lib/Sema/SemaCUDA.cpp Index: lib/Sema/SemaCUDA.cpp === --- lib/Sema/SemaCUDA.cpp +++

Re: [PATCH] D17852: Added formatAndApplyAllReplacements that works on multiple files in libTooling.

Just wanted to check if there are existing test cases for format::getStyle. If there is no test for it, I'll add test cases for sure :=) On Mon, Mar 21, 2016, 21:20 Manuel Klimek wrote: > On Mon, Mar 21, 2016 at 6:36 PM Eric Liu wrote: > >> ioeric added

Re: [PATCH] D17852: Added formatAndApplyAllReplacements that works on multiple files in libTooling.

On Mon, Mar 21, 2016 at 6:36 PM Eric Liu wrote: > ioeric added inline comments. > > > Comment at: unittests/Tooling/RefactoringTest.cpp:206 > @@ +205,3 @@ > +TEST_F(ReplacementTest, ReplaceAndFormatNoStyle) { > + std::string Code =

Re: [PATCH] D9557: Remove duplicate type definitions from f16cintrin.h

jtsoftware abandoned this revision. jtsoftware added a comment. It looks like this has already been addressed. http://reviews.llvm.org/D9557 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D18268: [Objective-c] Fix a crash in WeakObjectProfileTy::getBaseInfo

Yes, that looks good. For bonus points, add a similar test using the new property syntax @property (class) NSBundle *foo2; instead of the method. (I expect that version to behave nearly the same, including the "may" in the diagnostic.) Jordan > On Mar 21, 2016, at 12:36, Akira Hatanaka

[PATCH] D18325: export additional header modules from xmmintrin

jtsoftware created this revision. jtsoftware added reviewers: silvas, probinson. jtsoftware added a subscriber: cfe-commits. If someone only includes xmmintrin.h, but references any definitions from stdlib.h (included via mm_malloc.h), if module are enabled it will fail, but if modules are not

Re: [PATCH] D18149: Add check for unneeded copies of locals

fowles updated this revision to Diff 51215. fowles marked 2 inline comments as done. http://reviews.llvm.org/D18149 Files: clang-tidy/performance/UnnecessaryCopyInitialization.cpp clang-tidy/performance/UnnecessaryCopyInitialization.h

r263974 - clang-cl: With -fmsc-version=1900, use MSVS2015 diag formatting.

Author: nico Date: Mon Mar 21 14:44:18 2016 New Revision: 263974 URL: http://llvm.org/viewvc/llvm-project?rev=263974=rev Log: clang-cl: With -fmsc-version=1900, use MSVS2015 diag formatting. Modified: cfe/trunk/lib/Driver/Tools.cpp cfe/trunk/lib/Frontend/TextDiagnostic.cpp

Re: [PATCH] D18268: [Objective-c] Fix a crash in WeakObjectProfileTy::getBaseInfo

Jordan,Does the attached patch look OK?On Mar 18, 2016, at 1:19 PM, Jordan Rose wrote:No, that case worked already. The case you fixed is the one where Base is 'foo' and Property is 'prop'…and actually, thinking more about it, this should not be considered "exact". *sigh*

Re: [PATCH] D18110: [OpenMP] Fix SEMA bug in the capture of global variables in template functions.

sfantao added a comment. Ping! http://reviews.llvm.org/D18110 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D17950: Implement is_always_lock_free

jyknight added a comment. > Changed to what you suggested. Much nicer. I don't remember why I thought it > was a bad idea. Thanks, great! I don't have any opinion on what remains in this patch; someone else should review now. http://reviews.llvm.org/D17950

r263970 - [modules] Don't invent a module cache path unless implicit module builds are enabled.

Author: rsmith Date: Mon Mar 21 14:06:06 2016 New Revision: 263970 URL: http://llvm.org/viewvc/llvm-project?rev=263970=rev Log: [modules] Don't invent a module cache path unless implicit module builds are enabled. Modified: cfe/trunk/lib/Driver/Tools.cpp

Fwd: r202683 - Introduce '-fmodules-user-build-path' which accepts the "canonical" path to a user workspace build.

[Resend to new ML] What is this option for? This seems, in effect, to provide a way to use a distinct module cache. Why would someone use this rather than specifying a module cache path? On Mon, Mar 3, 2014 at 12:12 AM, Argyrios Kyrtzidis wrote: > Author: akirtzidis > Date:

Re: [PATCH] D17986: [ASTMatchers] New matcher hasReturnValue added

sbenza added a comment. In http://reviews.llvm.org/D17986#379271, @baloghadamsoftware wrote: > I can rerun the script, however it seems it was not executed before the last > commit on the master branch, thus if I rerun it then changes will appear in > my diff which are not related to my work.

Re: [PATCH] D16749: [OpenMP] Map clause codegeneration.

sfantao added a comment. In http://reviews.llvm.org/D16749#378969, @ABataev wrote: > Samuel, this is true for device part of codegen. But what about host? If > this code must be executed on host, will it be handled correctly? Hi Alexey, Yes, it will be handled correctly. The map clause

Re: [PATCH] D18264: [clang-tidy] misc-assign-operator-signature checker checks return value of all assign operators

etienneb added a subscriber: etienneb. Comment at: clang-tidy/misc/AssignOperatorSignatureCheck.cpp:39 @@ -37,1 +38,3 @@ + const auto IsSelfAssign = +cxxMethodDecl(IsAssign, hasParameter(0, parmVarDecl(hasType(IsSelf nit: could you

[clang-tools-extra] r263963 - [clang-tidy] Fix check broken in rL263822.

Author: sbenza Date: Mon Mar 21 13:00:43 2016 New Revision: 263963 URL: http://llvm.org/viewvc/llvm-project?rev=263963=rev Log: [clang-tidy] Fix check broken in rL263822. Add names missing from rL263822 and add tests to prevent future omissions. Modified:

Re: [PATCH] D18294: clang-format: [JS] no space in union and intersection types.

djasper closed this revision. djasper added a comment. Submitted as r263961. http://reviews.llvm.org/D18294 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r263961 - clang-format: [JS] no space in union and intersection types.

Author: djasper Date: Mon Mar 21 12:57:31 2016 New Revision: 263961 URL: http://llvm.org/viewvc/llvm-project?rev=263961=rev Log: clang-format: [JS] no space in union and intersection types. The operators | and & in types, as opposed to the bitwise operators, should not have whitespace around

r263958 - Add replacement = "xxx" to AvailabilityAttr.

Author: mren Date: Mon Mar 21 12:30:55 2016 New Revision: 263958 URL: http://llvm.org/viewvc/llvm-project?rev=263958=rev Log: Add replacement = "xxx" to AvailabilityAttr. This commit adds a named argument to AvailabilityAttr, while r263652 adds an optional string argument to

Re: [PATCH] D17852: Added formatAndApplyAllReplacements that works on multiple files in libTooling.

ioeric added inline comments. Comment at: unittests/Tooling/RefactoringTest.cpp:206 @@ +205,3 @@ +TEST_F(ReplacementTest, ReplaceAndFormatNoStyle) { + std::string Code = "MyType012345678901234567890123456789 *a =\n" + "new

r263957 - [ARM] Clang tests for ARM Cortex-A32 support

Author: rengolin Date: Mon Mar 21 12:29:51 2016 New Revision: 263957 URL: http://llvm.org/viewvc/llvm-project?rev=263957=rev Log: [ARM] Clang tests for ARM Cortex-A32 support Patch by Sam Parker. Modified: cfe/trunk/test/CodeGen/arm-target-features.c

Re: [PATCH] D18311: Clang tests for ARM Cortex-A32 support.

rengolin closed this revision. rengolin added a comment. Committed in r263957. http://reviews.llvm.org/D18311 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r263955 - NFC: wrap Availability-related data in its own struct in AttributeList.

Author: mren Date: Mon Mar 21 12:26:40 2016 New Revision: 263955 URL: http://llvm.org/viewvc/llvm-project?rev=263955=rev Log: NFC: wrap Availability-related data in its own struct in AttributeList. This makes it easy to add more data into Availability. Modified:

r263953 - clang-cl: Move /FC from "Unsupported" to "Ignored" list.

Author: nico Date: Mon Mar 21 12:19:31 2016 New Revision: 263953 URL: http://llvm.org/viewvc/llvm-project?rev=263953=rev Log: clang-cl: Move /FC from "Unsupported" to "Ignored" list. /FC affects if diagnostics print with full paths and if __FILE__ expands with a full path. clang-cl does both of

Re: [PATCH] D17440: clang-format: [JS] do not wrap ES6 imports/exports.

mprobst marked an inline comment as done. mprobst added a comment. As discussed offline, this matches existing very similar behaviour for destructured goog.require calls: js const {X, Y, Z} = goog.require('a'); // won't ever wrap import {X, Y, Z} from 'a'; // Shouldn't ever wrap It also

Re: [PATCH] D12761: MPI-Checker patch for Clang Static Analyzer

Alexander_Droste marked 6 inline comments as done. Comment at: lib/StaticAnalyzer/Checkers/MPI-Checker/MPIBugReporter.cpp:39 @@ +38,3 @@ + + if (Range.isValid()) +Report->addRange(Range); `sourceRange` patch -> http://reviews.llvm.org/D18309

Re: [PATCH] D18319: Add a PragmaHandler Registry for plugins to add PragmaHandlers to

rnk added a comment. This seems reasonable. Repository: rL LLVM http://reviews.llvm.org/D18319 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D12761: MPI-Checker patch for Clang Static Analyzer

Alexander_Droste updated this revision to Diff 51179. Alexander_Droste added a comment. - remove `checkMissingWaitsGlobals` to prevent potential false positives http://reviews.llvm.org/D12761 Files: lib/StaticAnalyzer/Checkers/CMakeLists.txt lib/StaticAnalyzer/Checkers/Checkers.td

[PATCH] D18319: Add a PragmaHandler Registry for plugins to add PragmaHandlers to

john.brawn created this revision. john.brawn added reviewers: bkramer, rsmith, rnk. john.brawn added a subscriber: cfe-commits. john.brawn set the repository for this revision to rL LLVM. This allows plugins which add AST passes to also define pragmas to do things like only enable certain

Re: [PATCH] D13126: New static analyzer checker for loss of sign/precision

zaks.anna added a comment. Why is there such a large jump in the number of warnings reported in the last patch iteration? It went from "1678 projects where scanned. In total I got 124 warnings" to "In 2215 projects it found 875 warnings." Did the number of warnings in the initial 1678 projects

r263947 - clang-cl: support __cdecl-on-struct anachronism

Author: rnk Date: Mon Mar 21 11:08:49 2016 New Revision: 263947 URL: http://llvm.org/viewvc/llvm-project?rev=263947=rev Log: clang-cl: support __cdecl-on-struct anachronism Summary: The Microsoft compiler emits warning C4229: anachronism used : modifiers on data are ignored for struct {}

Re: [PATCH] D16628: clang-cl: support __cdecl-on-struct anachronism

This revision was automatically updated to reflect the committed changes. Closed by commit rL263947: clang-cl: support __cdecl-on-struct anachronism (authored by rnk). Changed prior to commit: http://reviews.llvm.org/D16628?vs=46228=51176#toc Repository: rL LLVM

Re: [PATCH] D18311: Clang tests for ARM Cortex-A32 support.

samparker updated this revision to Diff 51173. samparker added a comment. Combined the two diffs http://reviews.llvm.org/D18311 Files: test/CodeGen/arm-target-features.c test/Driver/arm-cortex-cpus.c test/Preprocessor/arm-target-features.c Index: test/Preprocessor/arm-target-features.c

Re: [PATCH] D17986: [ASTMatchers] New matcher hasReturnValue added

baloghadamsoftware added a comment. I can rerun the script, however it seems it was not executed before the last commit on the master branch, thus if I rerun it then changes will appear in my diff which are not related to my work. What is the exect policy about running this scipt? Should it be

Re: [PATCH] D12761: MPI-Checker patch for Clang Static Analyzer

zaks.anna added inline comments. Comment at: lib/StaticAnalyzer/Checkers/MPI-Checker/MPIChecker.cpp:136 @@ +135,3 @@ + auto NodeIt = G.eop_begin(); + const auto NodeEndIt = G.eop_end(); + Alexander_Droste wrote: > zaks.anna wrote: > > The analyzer does not do a

Re: [PATCH] D18311: Clang tests for ARM Cortex-A32 support.

rengolin added a comment. Right, if you could update both reviews with the full patch, I could commit them for you, for now. http://reviews.llvm.org/D18311 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D17852: Added formatAndApplyAllReplacements that works on multiple files in libTooling.

klimek added inline comments. Comment at: unittests/Tooling/RefactoringTest.cpp:206 @@ +205,3 @@ +TEST_F(ReplacementTest, ReplaceAndFormatNoStyle) { + std::string Code = "MyType012345678901234567890123456789 *a =\n" + "new

Re: [PATCH] D18243: [ASTMatchers] Existing matcher hasAnyArgument fixed

baloghadamsoftware updated this revision to Diff 51167. http://reviews.llvm.org/D18243 Files: include/clang/ASTMatchers/ASTMatchers.h unittests/ASTMatchers/ASTMatchersTest.cpp Index: unittests/ASTMatchers/ASTMatchersTest.cpp

Re: [PATCH] D18294: clang-format: [JS] no space in union and intersection types.

mprobst added inline comments. Comment at: lib/Format/TokenAnnotator.cpp:2154 @@ -2141,1 +2153,3 @@ return Style.SpacesInAngles; + if (Style.Language == FormatStyle::LK_JavaScript && + (Left.is(TT_JsTypeOperator) || Right.is(TT_JsTypeOperator)))

Re: [PATCH] D16993: Add missing __builtin_bitreverse8

arsenm added a comment. ping http://reviews.llvm.org/D16993 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D18294: clang-format: [JS] no space in union and intersection types.

djasper added a comment. Looks good. http://reviews.llvm.org/D18294 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D18311: Clang tests for ARM Cortex-A32 support.

samparker added a comment. Hi Renato, Thanks for the tips, one patch makes much more sense. I'm currently in the process of obtaining commit access and this patch depends on http://reviews.llvm.org/D18239. Thanks again, sam http://reviews.llvm.org/D18311

clang-tidy modernize-use-override

Hi, First time poster here, Please advise... Can I contribute these patches for clang-tidy modernize-use-override addressing two problems: 1: missing spaces on pure function decls Orig: void pure() const=0 Problem: void pure() constoverride =0 Fixed: void pure() const override =0 2: This is

Re: [PATCH] D18311: Clang tests for ARM Cortex-A32 support.

rengolin accepted this revision. rengolin added a reviewer: rengolin. rengolin added a comment. This revision is now accepted and ready to land. Hi Sam, The patch looks good, thanks! A few comments on the process: 1. When you send an update, send the whole patch again, not just the new diff.

Re: [PATCH] D17852: Added formatAndApplyAllReplacements that works on multiple files in libTooling.

ioeric updated this revision to Diff 51166. ioeric marked 8 inline comments as done. ioeric added a comment. - removed FileToReplacementsMap typedef; refactored formatAndApplyReplacements to reduce duplicated code. http://reviews.llvm.org/D17852 Files: include/clang/Basic/SourceManager.h

Re: [PATCH] D17852: Added formatAndApplyAllReplacements that works on multiple files in libTooling.

ioeric added inline comments. Comment at: lib/Tooling/Refactoring.cpp:90 @@ +89,3 @@ + +// FIXME: duplicated code here. Any better way to overload? +bool formatAndApplyAllReplacements(const Replacements , klimek wrote: > ioeric wrote: > > klimek wrote: > > > Just

Re: [PATCH] D18311: Clang tests for ARM Cortex-A32 support.

samparker updated this revision to Diff 51165. samparker added a comment. Changed A53-ARM and A53-THUMB test prefixes to ARMV8-ARM and ARMV8-THUMB. http://reviews.llvm.org/D18311 Files: test/Preprocessor/arm-target-features.c Index: test/Preprocessor/arm-target-features.c

Re: [PATCH] D17986: [ASTMatchers] New matcher hasReturnValue added

sbenza added a comment. Can you rerun the doc script (dump_ast_matchers.py)? http://reviews.llvm.org/D17986 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D18264: [clang-tidy] misc-assign-operator-signature checker checks return value of all assign operators

aaron.ballman added a comment. In http://reviews.llvm.org/D18264#379159, @xazax.hun wrote: > In http://reviews.llvm.org/D18264#379092, @aaron.ballman wrote: > > > Also, it's quite common for older code (pre C++11) to return void and make > > these functions private (with no definition) as an

Re: [PATCH] D18264: [clang-tidy] misc-assign-operator-signature checker checks return value of all assign operators

xazax.hun added a comment. In http://reviews.llvm.org/D18264#379092, @aaron.ballman wrote: > Also, it's quite common for older code (pre C++11) to return void and make > these functions private (with no definition) as an early form of deleting the > operator. This checker will not warn on

r263943 - clang-format: Make include sorting's main include detection configurable.

Author: djasper Date: Mon Mar 21 09:11:27 2016 New Revision: 263943 URL: http://llvm.org/viewvc/llvm-project?rev=263943=rev Log: clang-format: Make include sorting's main include detection configurable. This patch adds a regular expression to configure suffixes of an included file to check

Re: [PATCH] D18149: Add check for unneeded copies of locals

hokein added inline comments. Comment at: clang-tidy/performance/UnnecessaryCopyInitialization.cpp:87 @@ +86,3 @@ + +namespace { +void recordFixes(const VarDecl , ASTContext , I prefer to move the anonymous namespace under `namespace performance {` statement.

Re: [PATCH] D17852: Added formatAndApplyAllReplacements that works on multiple files in libTooling.

klimek added inline comments. Comment at: lib/Tooling/Refactoring.cpp:90 @@ +89,3 @@ + +// FIXME: duplicated code here. Any better way to overload? +bool formatAndApplyAllReplacements(const Replacements , ioeric wrote: > klimek wrote: > > Just call the above with

Re: [PATCH] D18294: clang-format: [JS] no space in union and intersection types.

mprobst updated this revision to Diff 51159. mprobst marked 2 inline comments as done. mprobst added a comment. - Address review comments. http://reviews.llvm.org/D18294 Files: lib/Format/FormatToken.h lib/Format/TokenAnnotator.cpp unittests/Format/FormatTestJS.cpp Index:

  1   2   >