Re: [PATCH] D17596: [OpenCL] Add ocl and spir version for spir target

This revision was automatically updated to reflect the committed changes. Closed by commit rL264241: [OpenCL] Add ocl and spir version for spir target (authored by pxl). Changed prior to commit: http://reviews.llvm.org/D17596?vs=51253=51509#toc Repository: rL LLVM

r264241 - [OpenCL] Add ocl and spir version for spir target

Author: pxl Date: Wed Mar 23 22:57:17 2016 New Revision: 264241 URL: http://llvm.org/viewvc/llvm-project?rev=264241=rev Log: [OpenCL] Add ocl and spir version for spir target Summary: Add opencl.spir.version and opencl.ocl.version metadata for CodeGen to identify OpenCL version. Reviewers:

Re: [PATCH] D17981: [clang-tidy] Fix clang-tidy to support parsing of assembly statements.

etienneb added a comment. In http://reviews.llvm.org/D17981#380350, @alexfh wrote: > Adding Manuel, who might have better ideas. > > In http://reviews.llvm.org/D17981#374904, @rnk wrote: > > > In http://reviews.llvm.org/D17981#374553, @etienneb wrote: > > > > > This is a huge difference. I

[PATCH] D18425: [Sema] Make enable_if act correctly with value dependent conditions/arguments

george.burgess.iv created this revision. george.burgess.iv added a reviewer: rsmith. george.burgess.iv added a subscriber: cfe-commits. Test case: ``` int foo(int A) __attribute__((enable_if(A == 0, ""))); template int bar() { return foo(A); } int G = bar<1>(); // calls foo(1), which should be

r264236 - Add release notes for the removal of the silent include of altivec.h.

Author: echristo Date: Wed Mar 23 20:28:25 2016 New Revision: 264236 URL: http://llvm.org/viewvc/llvm-project?rev=264236=rev Log: Add release notes for the removal of the silent include of altivec.h. Modified: cfe/trunk/docs/ReleaseNotes.rst Modified: cfe/trunk/docs/ReleaseNotes.rst URL:

[PATCH] D18424: [Clang] Fix Clang-tidy modernize-deprecated-headers warnings; other minor fixes

Eugene.Zelenko created this revision. Eugene.Zelenko added reviewers: hans, aaron.ballman. Eugene.Zelenko added a subscriber: cfe-commits. Eugene.Zelenko set the repository for this revision to rL LLVM. Herald added a subscriber: klimek. Some Include What You Use suggestions were used too. I

r264235 - The time when -faltivec (or, on clang only, -maltivec) will magically

Author: echristo Date: Wed Mar 23 20:26:08 2016 New Revision: 264235 URL: http://llvm.org/viewvc/llvm-project?rev=264235=rev Log: The time when -faltivec (or, on clang only, -maltivec) will magically include altivec.h has come and gone. Rationale: This causes modules, rewrite-includes, etc to be

Re: [PATCH] D18271: Avoid -Wshadow warnings about constructor parameters named after fields

alexfh added a comment. > Depending on how strictly you define "initialized" here, this is either > unhelpful or difficult to chpatterneck. s/chpatterneck/check/ http://reviews.llvm.org/D18271 ___ cfe-commits mailing list

Re: [PATCH] D18271: Avoid -Wshadow warnings about constructor parameters named after fields

alexfh added a comment. In http://reviews.llvm.org/D18271#382082, @rnk wrote: > In http://reviews.llvm.org/D18271#381769, @rsmith wrote: > > > I think a reasonable approach would be: "do not warn on shadowing if the > > idiom of naming a constructor parameter after a class member is used, and

r264229 - Display const/volatile/restrict qualifiers in Visual Studio visualizations

Author: mps Date: Wed Mar 23 19:38:54 2016 New Revision: 264229 URL: http://llvm.org/viewvc/llvm-project?rev=264229=rev Log: Display const/volatile/restrict qualifiers in Visual Studio visualizations Modified: cfe/trunk/utils/clang.natvis Modified: cfe/trunk/utils/clang.natvis URL:

r264227 - Modules builds are necessarily compile actions, but they don't

Author: echristo Date: Wed Mar 23 19:34:02 2016 New Revision: 264227 URL: http://llvm.org/viewvc/llvm-project?rev=264227=rev Log: Modules builds are necessarily compile actions, but they don't necessarily produce object files. Turn off split dwarf if we're not producing a file that the driver

r264226 - NFC: clarify comment on lock-free macros

Author: jfb Date: Wed Mar 23 19:20:44 2016 New Revision: 264226 URL: http://llvm.org/viewvc/llvm-project?rev=264226=rev Log: NFC: clarify comment on lock-free macros Used by both libstdc++ and libc++. Modified: cfe/trunk/lib/Frontend/InitPreprocessor.cpp Modified:

Re: [PATCH] D18380: [CUDA] Implement -fcuda-relaxed-constexpr, and enable it by default.

jlebar updated this revision to Diff 51495. jlebar added a comment. Add check for __global__ constexpr functions. http://reviews.llvm.org/D18380 Files: include/clang/Basic/LangOptions.def include/clang/Driver/CC1Options.td lib/Frontend/CompilerInvocation.cpp lib/Sema/SemaDecl.cpp

Re: [PATCH] D18380: [CUDA] Implement -fcuda-relaxed-constexpr, and enable it by default.

jlebar added inline comments. Comment at: lib/Sema/SemaDecl.cpp:8011-8013 @@ +8010,5 @@ + // allowed, so we just treat those as host-only. + if (getLangOpts().CUDA && getLangOpts().CUDAHostDeviceConstexpr && + NewFD->isConstexpr() && !NewFD->isVariadic() && +

Re: [PATCH] D16962: clang-tidy: avoid std::bind

alexfh added inline comments. Comment at: clang-tidy/readability/AvoidStdBindCheck.cpp:46 @@ +45,3 @@ +BindArgument B; +if (const auto * M = dyn_cast(E)) { + const auto * TE = M->GetTemporaryExpr(); In LLVM style this should be `const auto *M`.

r264216 - clang-cl: Add a FIXME for bumping the default msc version.

Author: nico Date: Wed Mar 23 18:26:59 2016 New Revision: 264216 URL: http://llvm.org/viewvc/llvm-project?rev=264216=rev Log: clang-cl: Add a FIXME for bumping the default msc version. Modified: cfe/trunk/lib/Driver/Tools.cpp Modified: cfe/trunk/lib/Driver/Tools.cpp URL:

Re: [PATCH] D18271: Avoid -Wshadow warnings about constructor parameters named after fields

rnk added a comment. In http://reviews.llvm.org/D18271#381769, @rsmith wrote: > I think a reasonable approach would be: "do not warn on shadowing if the > idiom of naming a constructor parameter after a class member is used, and the > class member is initialized from that constructor

r264211 - Fix typo in test from r264210, sigh.

Author: nico Date: Wed Mar 23 18:01:38 2016 New Revision: 264211 URL: http://llvm.org/viewvc/llvm-project?rev=264211=rev Log: Fix typo in test from r264210, sigh. (The test passes both with and without this change, but it's confusing without it.) Modified: cfe/trunk/test/Misc/diag-format.c

r264210 - clang-cl: With -fmsc-version=1900, use MSVS2015 diag formatting.

Author: nico Date: Wed Mar 23 17:57:55 2016 New Revision: 264210 URL: http://llvm.org/viewvc/llvm-project?rev=264210=rev Log: clang-cl: With -fmsc-version=1900, use MSVS2015 diag formatting. Remove tests that have neither a triple nor an explicit -fmsc-version flag, since in the absence of an

Re: [PATCH] D18264: [clang-tidy] misc-assign-operator-signature checker checks return value of all assign operators

alexfh added a comment. In http://reviews.llvm.org/D18264#381846, @baloghadamsoftware wrote: > Oh, I was searching in the C++ Core Guidlines, but at the wrong place because > I did not find it. So I will change this option to be enabled by default. DSL > users who do not follow this rule for

Re: [PATCH] D18385: [CUDA] Simplify SemaCUDA/function-overload.cu test.

This revision was automatically updated to reflect the committed changes. Closed by commit rL264206: [CUDA] Simplify SemaCUDA/function-overload.cu test. (authored by jlebar). Changed prior to commit: http://reviews.llvm.org/D18385?vs=51382=51484#toc Repository: rL LLVM

r264207 - [CUDA] Merge most of CodeGenCUDA/function-overload.cu into SemaCUDA/function-overload.cu.

Author: jlebar Date: Wed Mar 23 17:42:30 2016 New Revision: 264207 URL: http://llvm.org/viewvc/llvm-project?rev=264207=rev Log: [CUDA] Merge most of CodeGenCUDA/function-overload.cu into SemaCUDA/function-overload.cu. Summary: Previously we were using the codegen test to ensure that we choose

Re: [PATCH] D18386: [CUDA] Merge most of CodeGenCUDA/function-overload.cu into SemaCUDA/function-overload.cu.

This revision was automatically updated to reflect the committed changes. Closed by commit rL264207: [CUDA] Merge most of CodeGenCUDA/function-overload.cu into SemaCUDA/function… (authored by jlebar). Changed prior to commit: http://reviews.llvm.org/D18386?vs=51383=51485#toc Repository: rL

Re: [PATCH] D18417: [CUDA] Don't define __NVCC__.

This revision was automatically updated to reflect the committed changes. Closed by commit rL264205: [CUDA] Don't define __NVCC__. (authored by jlebar). Changed prior to commit: http://reviews.llvm.org/D18417?vs=51482=51483#toc Repository: rL LLVM http://reviews.llvm.org/D18417 Files:

r264206 - [CUDA] Simplify SemaCUDA/function-overload.cu test.

Author: jlebar Date: Wed Mar 23 17:42:28 2016 New Revision: 264206 URL: http://llvm.org/viewvc/llvm-project?rev=264206=rev Log: [CUDA] Simplify SemaCUDA/function-overload.cu test. Summary: Principally, don't hardcode the line numbers of various notes. This lets us make changes to the test

Re: [PATCH] D18380: [CUDA] Implement -fcuda-relaxed-constexpr, and enable it by default.

tra added inline comments. Comment at: lib/Sema/SemaDecl.cpp:8011-8013 @@ +8010,5 @@ + // allowed, so we just treat those as host-only. + if (getLangOpts().CUDA && getLangOpts().CUDAHostDeviceConstexpr && + NewFD->isConstexpr() && !NewFD->isVariadic() && +

[PATCH] D18417: [CUDA] Don't define __NVCC__.

jlebar created this revision. jlebar added a reviewer: tra. jlebar added a subscriber: cfe-commits. We decided this makes life too difficult for code authors. For example, people may want to detect NVCC and disable variadic templates, which NVCC does not support, but which we do. Since people

[PATCH] D18416: [CUDA] Remove three obsolete CUDA cc1 flags.

jlebar created this revision. jlebar added a reviewer: tra. jlebar added subscribers: cfe-commits, rsmith. * -fcuda-target-overloads Previously unconditionally set to true by the driver. Necessary for correct functioning of the compiler -- our CUDA headers wrapper won't compile without

Re: [PATCH] D16993: Add missing __builtin_bitreverse8

arsenm closed this revision. arsenm added a comment. r264203 http://reviews.llvm.org/D16993 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D18380: [CUDA] Implement -fcuda-relaxed-constexpr, and enable it by default.

jlebar added a comment. Changed as discussed. Please have another look. Thank you for your continued patience here. http://reviews.llvm.org/D18380 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r264203 - Add missing __builtin_bitreverse8

Author: arsenm Date: Wed Mar 23 17:14:43 2016 New Revision: 264203 URL: http://llvm.org/viewvc/llvm-project?rev=264203=rev Log: Add missing __builtin_bitreverse8 Also add documentation for bitreverse builtins Modified: cfe/trunk/docs/LanguageExtensions.rst

Re: [PATCH] D18380: [CUDA] Implement -fcuda-relaxed-constexpr, and enable it by default.

jlebar updated this revision to Diff 51479. jlebar added a comment. Switch to -fno-cuda-host-device-constexpr. Only implicitly add the attributes on functions which themselves lack host/device attributes. Add more tests. http://reviews.llvm.org/D18380 Files:

Re: [PATCH] D18385: [CUDA] Simplify SemaCUDA/function-overload.cu test.

jlebar marked an inline comment as done. jlebar added a comment. One comment is done, will be reflected when I submit. Thank you! http://reviews.llvm.org/D18385 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D16993: Add missing __builtin_bitreverse8

arsenm added inline comments. Comment at: docs/LanguageExtensions.rst:1533 @@ +1532,3 @@ +the bitpattern of an integer value; for example ``0b1234567`` becomes +``0b7654321``. + rsmith wrote: > This example doesn't make much sense: it looks like it's bit

r264196 - ObjC: add getter/setter for class properties to global pool.

Author: mren Date: Wed Mar 23 16:39:31 2016 New Revision: 264196 URL: http://llvm.org/viewvc/llvm-project?rev=264196=rev Log: ObjC: add getter/setter for class properties to global pool. rdar://problem/25323072 Modified: cfe/trunk/lib/Sema/SemaObjCProperty.cpp

Re: [PATCH] D18171: [CUDA][OpenMP] Create generic offload action

jlebar added a comment. > @jlebar: Justin, any suggestions on what we can/should do regarding [const > correctness issues]? Using "mutable" to work around const-incorrectness should be a last resort. I've been frustrated by the const-incorrectness of Action as well, but if it's an issue

Re: [PATCH] D18171: [CUDA][OpenMP] Create generic offload action

tra added a comment. Thank you for making these changes. They don't solve all the shortcomings, but they improve things quite a bit, IMO. Overall I'm happy with the changes, though use of mutable and changing action state from const functions may need a look from someone with better C++-fu

Re: [PATCH] D18347: [PATCH] Fix thread_annotation negtest for thread safety.

richard.barton.arm added a comment. Hi Eric - no problem at all, you practically wrote it for me after all ;-) http://reviews.llvm.org/D18347 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[libcxx] r264191 - Guard a number of tests relying on threads support when built in

Author: rbarton Date: Wed Mar 23 16:04:11 2016 New Revision: 264191 URL: http://llvm.org/viewvc/llvm-project?rev=264191=rev Log: Guard a number of tests relying on threads support when built in single-threaded mode. Differential Revision: http://reviews.llvm.org/D14731 Modified:

Re: [PATCH] D17951: Implement is_always_lock_free

jfb added inline comments. Comment at: include/atomic:859 @@ +858,3 @@ +#if defined(__cpp_lib_atomic_is_always_lock_free) + static _LIBCPP_CONSTEXPR bool is_always_lock_free = __atomic_always_lock_free(sizeof(__a_), 0); +#endif EricWF wrote: > jfb wrote: > > I

Re: [PATCH] D17951: Implement is_always_lock_free

jfb updated this revision to Diff 51473. jfb added a comment. - Add definition. http://reviews.llvm.org/D17951 Files: include/atomic test/std/atomics/atomics.lockfree/isalwayslockfree.pass.cpp Index: test/std/atomics/atomics.lockfree/isalwayslockfree.pass.cpp

Re: [PATCH] D17951: Implement is_always_lock_free

EricWF added inline comments. Comment at: include/atomic:859 @@ +858,3 @@ +#if defined(__cpp_lib_atomic_is_always_lock_free) + static _LIBCPP_CONSTEXPR bool is_always_lock_free = __atomic_always_lock_free(sizeof(__a_), 0); +#endif jfb wrote: > I don't think so:

Re: [PATCH] D17951: Implement is_always_lock_free

jfb added inline comments. Comment at: include/atomic:859 @@ +858,3 @@ +#if defined(__cpp_lib_atomic_is_always_lock_free) + static _LIBCPP_CONSTEXPR bool is_always_lock_free = __atomic_always_lock_free(sizeof(__a_), 0); +#endif I don't think so: it's similar to

r264189 - Make SemaAccess smarter about determining when a dependent class might

Author: rsmith Date: Wed Mar 23 15:39:06 2016 New Revision: 264189 URL: http://llvm.org/viewvc/llvm-project?rev=264189=rev Log: Make SemaAccess smarter about determining when a dependent class might instantiate to match a friend class declaration. It's still pretty dumb, though. Modified:

Re: [PATCH] D18380: [CUDA] Implement -fcuda-relaxed-constexpr, and enable it by default.

jlebar added inline comments. Comment at: include/clang/Driver/CC1Options.td:702-703 @@ -701,2 +701,4 @@ HelpText<"Allow variadic functions in CUDA device code.">; +def fcuda_relaxed_constexpr : Flag<["-"], "fcuda-relaxed-constexpr">, + HelpText<"Treat constexpr functions as

Re: [PATCH] D18412: [clang-tidy] Add support for different char-types for the readability-redundant-string-cstr checker.

etienneb added a comment. In http://reviews.llvm.org/D18412#381843, @dblaikie wrote: > can you just match on the name of the template instead? I'm not sure to get your point? Are you proposing to match "basic_string" instead of the whole regexp? I'm in favor of that change as I don't see any

Re: [PATCH] D18412: [clang-tidy] Add support for different char-types for the readability-redundant-string-cstr checker.

mamai added a subscriber: mamai. mamai added a comment. nit: in summary, consiring -> considering ? Comment at: test/clang-tidy/readability-redundant-string-cstr.cpp:54 @@ +53,3 @@ + // CHECK-MESSAGES: :[[@LINE-1]]:6: warning: redundant call to `c_str()`

Re: [PATCH] D18412: [clang-tidy] Add support for different char-types for the readability-redundant-string-cstr checker.

etienneb updated this revision to Diff 51464. etienneb marked an inline comment as done. etienneb added a comment. Fix unittests. http://reviews.llvm.org/D18412 Files: clang-tidy/readability/RedundantStringCStrCheck.cpp test/clang-tidy/readability-redundant-string-cstr.cpp Index:

Re: [PATCH] D18347: [PATCH] Fix thread_annotation negtest for thread safety.

EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. LGTM! Thanks for the complete patch! The "no-threads" bot should now be green so future breakage will be detected immediately! http://reviews.llvm.org/D18347

r264184 - Make sure to perform dependent access checks when instantiating a

Author: rsmith Date: Wed Mar 23 15:07:07 2016 New Revision: 264184 URL: http://llvm.org/viewvc/llvm-project?rev=264184=rev Log: Make sure to perform dependent access checks when instantiating a lambda-expression. We don't actually instantiate the closure type / operator() in the template in order

Re: [PATCH] D18264: [clang-tidy] misc-assign-operator-signature checker checks return value of all assign operators

baloghadamsoftware added a comment. Oh, I was searching in the C++ Core Guidlines, but at the wrong place because I did not find it. So I will change this option to be enabled by default. DSL users who do not follow this rule for the non copy and non move assign operators can disable it.

Re: [PATCH] D18412: [clang-tidy] Add support for different char-types for the readability-redundant-string-cstr checker.

can you just match on the name of the template instead? On Wed, Mar 23, 2016 at 12:46 PM, Etienne Bergeron via cfe-commits < cfe-commits@lists.llvm.org> wrote: > etienneb created this revision. > etienneb added a reviewer: alexfh. > etienneb added a subscriber: cfe-commits. > > The current

[PATCH] D18412: [clang-tidy] Add support for different char-types for the readability-redundant-string-cstr checker.

etienneb created this revision. etienneb added a reviewer: alexfh. etienneb added a subscriber: cfe-commits. The current checker is able to recognize std::string but do not recognize other string variants. This path is adding the support for any string define with basic_string without consiring

Re: [PATCH] D18271: Avoid -Wshadow warnings about constructor parameters named after fields

bcraig added a subscriber: mclow.lists. bcraig added a comment. > > Not dblaikie, but I've used the GCC version of -Wshadow on reasonably large > > code bases before. The ctor pattern that this is trying to squelch was > > certainly a significant portion of the warnings, particularly when

Re: [PATCH] D17412: PR19957: [OpenCL] incorrectly accepts implicit address space conversion with ternary operator

yaxunl removed rL LLVM as the repository for this revision. yaxunl updated this revision to Diff 51460. yaxunl marked 13 inline comments as done. yaxunl added a comment. Added comments. Revised test. http://reviews.llvm.org/D17412 Files: include/clang/Basic/DiagnosticSemaKinds.td

Re: [PATCH] D17821: [OpenCL] Complete image types support

mgrang added a subscriber: mgrang. Comment at: include/clang/AST/ASTContext.h:903 @@ +902,3 @@ +#define IMAGE_TYPE(ImgType, Id, SingletonId, Access, Suffix) \ + CanQualType SingletonId; +#include "clang/AST/OpenCLImageTypes.def" remove extra

r264182 - clang-cl: Fix remaining bugs in interaction of /Yc and /FI /showIncludes.

Author: nico Date: Wed Mar 23 13:46:57 2016 New Revision: 264182 URL: http://llvm.org/viewvc/llvm-project?rev=264182=rev Log: clang-cl: Fix remaining bugs in interaction of /Yc and /FI /showIncludes. Instead of putting the /Yc header into ExtraDeps, give DependencyOutputOptions a dedicated field

Re: [PATCH] D18380: [CUDA] Implement -fcuda-relaxed-constexpr, and enable it by default.

rsmith added inline comments. Comment at: include/clang/Driver/CC1Options.td:702-703 @@ -701,2 +701,4 @@ HelpText<"Allow variadic functions in CUDA device code.">; +def fcuda_relaxed_constexpr : Flag<["-"], "fcuda-relaxed-constexpr">, + HelpText<"Treat constexpr functions as

Re: [PATCH] D13126: New static analyzer checker for loss of sign/precision

zaks.anna added a comment. Could you add the reduced false positives to the tests file? > As far as I see the diagnostics are showing the proper path now.. What do you mean? Does this refer to supplying more information the the path about why the error occurs? Comment at:

Re: [PATCH] D18275: [ASTMatchers] Add own version of VariadicFunction.

alexfh added a comment. Still LG. Comment at: include/clang/ASTMatchers/ASTMatchersInternal.h:82 @@ +81,3 @@ + ResultT operator()(ArrayRef Args) const { +SmallVector InnerArgs; +for (const ArgT : Args) > On the other hand, constructing the matchers

Re: [PATCH] D18271: Avoid -Wshadow warnings about constructor parameters named after fields

rsmith added a comment. I think a reasonable approach would be: "do not warn on shadowing if the idiom of naming a constructor parameter after a class member is used, and the class member is initialized from that constructor parameter, and all uses of the parameter in the constructor body

Re: [PATCH] D18380: [CUDA] Implement -fcuda-relaxed-constexpr, and enable it by default.

jlebar added inline comments. Comment at: include/clang/Driver/CC1Options.td:702-703 @@ -701,2 +701,4 @@ HelpText<"Allow variadic functions in CUDA device code.">; +def fcuda_relaxed_constexpr : Flag<["-"], "fcuda-relaxed-constexpr">, + HelpText<"Treat constexpr functions as

Re: [PATCH] D18271: Avoid -Wshadow warnings about constructor parameters named after fields

thakis added a comment. In http://reviews.llvm.org/D18271#381758, @bcraig wrote: > In http://reviews.llvm.org/D18271#381744, @thakis wrote: > > > FWIW we don't currently use this warning on Chromium because it's way to > > noisy. So something like this looks like a great change to me. > > > >

Re: [PATCH] D18271: Avoid -Wshadow warnings about constructor parameters named after fields

bcraig added a subscriber: bcraig. bcraig added a comment. In http://reviews.llvm.org/D18271#381744, @thakis wrote: > FWIW we don't currently use this warning on Chromium because it's way to > noisy. So something like this looks like a great change to me. > > dblaikie, are you aware of any

Re: [PATCH] D18271: Avoid -Wshadow warnings about constructor parameters named after fields

thakis added a subscriber: thakis. thakis added a comment. FWIW we don't currently use this warning on Chromium because it's way to noisy. So something like this looks like a great change to me. dblaikie, are you aware of any codebases that use this warning in its current form?

Re: [PATCH] D18271: Avoid -Wshadow warnings about constructor parameters named after fields

alexfh added a comment. In http://reviews.llvm.org/D18271#378196, @dblaikie wrote: > It's not just modifications of shadowed variables that are a problem - one of > the one's I'm concerned we should catch is: > > struct foo { > std::unique_ptr p; > foo(std::unique_ptr p) :

Re: [PATCH] D18271: Avoid -Wshadow warnings about constructor parameters named after fields

On Wed, Mar 23, 2016 at 11:03 AM, Alexander Kornienko via cfe-commits < cfe-commits@lists.llvm.org> wrote: > alexfh added a subscriber: alexfh. > alexfh added a comment. > > As a data point: I ran -Wshadow on our code base with a similar, but > simpler patch (http://reviews.llvm.org/D18395, just

Re: [PATCH] D18401: clang-cl: Include /FI headers in /showIncludes output.

thakis closed this revision. thakis added a comment. …and landed in r264174. http://reviews.llvm.org/D18401 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r264174 - clang-cl: Include /FI headers in /showIncludes output.

Author: nico Date: Wed Mar 23 13:00:22 2016 New Revision: 264174 URL: http://llvm.org/viewvc/llvm-project?rev=264174=rev Log: clang-cl: Include /FI headers in /showIncludes output. -H in gcc mode doesn't print -include headers, but they are included in depfiles written by MMD and friends. Since

Re: [PATCH] D18401: clang-cl: Include /FI headers in /showIncludes output.

thakis updated this revision to Diff 51448. thakis marked 2 inline comments as done. thakis added a comment. Thanks! All done. http://reviews.llvm.org/D18401 Files: lib/Frontend/CompilerInstance.cpp lib/Frontend/HeaderIncludeGen.cpp lib/Frontend/InitPreprocessor.cpp

Re: [PATCH] D18271: Avoid -Wshadow warnings about constructor parameters named after fields

alexfh added a comment. In http://reviews.llvm.org/D18271#381728, @alexfh wrote: > ... and then gradually adding back the cases that seem to be important to > flag ... Maybe as separate warnings. http://reviews.llvm.org/D18271 ___ cfe-commits

Re: [PATCH] D18271: Avoid -Wshadow warnings about constructor parameters named after fields

alexfh added a subscriber: alexfh. alexfh added a comment. As a data point: I ran -Wshadow on our code base with a similar, but simpler patch (http://reviews.llvm.org/D18395, just disables the warning on ctor parameters named after fields). It removes more than half of the hits (from ~100k

Re: [PATCH] D18275: [ASTMatchers] Add own version of VariadicFunction.

sbenza added inline comments. Comment at: include/clang/ASTMatchers/ASTMatchersInternal.h:80 @@ +79,3 @@ + ResultT operator()(ArrayRef Args) const { +std::vector InnerArgs; +for (const ArgT : Args) alexfh wrote: > It's unfortunate that we need to create

Re: [PATCH] D18275: [ASTMatchers] Add own version of VariadicFunction.

sbenza updated this revision to Diff 51447. sbenza added a comment. Minor fix http://reviews.llvm.org/D18275 Files: include/clang/ASTMatchers/ASTMatchers.h include/clang/ASTMatchers/ASTMatchersInternal.h lib/ASTMatchers/Dynamic/Marshallers.h unittests/ASTMatchers/ASTMatchersTest.cpp

Re: [PATCH] D18380: [CUDA] Implement -fcuda-relaxed-constexpr, and enable it by default.

rsmith added inline comments. Comment at: include/clang/Driver/CC1Options.td:702-703 @@ -701,2 +701,4 @@ HelpText<"Allow variadic functions in CUDA device code.">; +def fcuda_relaxed_constexpr : Flag<["-"], "fcuda-relaxed-constexpr">, + HelpText<"Treat constexpr functions as

[PATCH] D18408: readability check for const params in declarations

fowles created this revision. fowles added a reviewer: alexfh. fowles added a subscriber: cfe-commits. Adds a clang-tidy warning for top-level consts in function declarations. http://reviews.llvm.org/D18408 Files: clang-tidy/readability/AvoidConstParamsInDecls.cpp

Re: [PATCH] D18401: clang-cl: Include /FI headers in /showIncludes output.

rsmith added a subscriber: rsmith. rsmith accepted this revision. rsmith added a reviewer: rsmith. This revision is now accepted and ready to land. Comment at: lib/Frontend/HeaderIncludeGen.cpp:155-156 @@ -151,3 +154,4 @@ // Dump the header include information we are past

r264170 - [NFC] Delete an unused function parameter from a static function

Author: faisalv Date: Wed Mar 23 12:39:51 2016 New Revision: 264170 URL: http://llvm.org/viewvc/llvm-project?rev=264170=rev Log: [NFC] Delete an unused function parameter from a static function Modified: cfe/trunk/lib/Sema/SemaExpr.cpp Modified: cfe/trunk/lib/Sema/SemaExpr.cpp URL:

Re: [PATCH] D18401: clang-cl: Include /FI headers in /showIncludes output.

thakis updated the summary for this revision. thakis updated this revision to Diff 51442. http://reviews.llvm.org/D18401 Files: lib/Frontend/CompilerInstance.cpp lib/Frontend/HeaderIncludeGen.cpp lib/Frontend/InitPreprocessor.cpp test/Driver/cl-pch-showincludes.cpp

r264169 - Visualize fields of records as they were declared in Visual Studio debugger

Author: mps Date: Wed Mar 23 12:29:42 2016 New Revision: 264169 URL: http://llvm.org/viewvc/llvm-project?rev=264169=rev Log: Visualize fields of records as they were declared in Visual Studio debugger Modified: cfe/trunk/utils/clang.natvis Modified: cfe/trunk/utils/clang.natvis URL:

Re: [PATCH] D17762: Fix an assertion failure in setPointOfInstantiation.

rsmith added a comment. It seems to me that the bug is that we're producing an invalid source location, not how we handle that downstream. Typo correction should be able to preserve the source location of whatever expression it was correcting. Comment at:

Re: [PATCH] D18264: [clang-tidy] misc-assign-operator-signature checker checks return value of all assign operators

xazax.hun added a comment. According to cpp core guidelines any assignment operator should return *this. https://github.com/isocpp/CppCoreGuidelines/blob/master/CppCoreGuidelines.md#Rf-assignment-op So in case this check is activated by using an alias it should not be a special case.

Re: [PATCH] D18399: Added support for different VFSs in format::getStyle.

klimek accepted this revision. klimek added a comment. This revision is now accepted and ready to land. lg http://reviews.llvm.org/D18399 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D18399: Added support for different VFSs in format::getStyle.

ioeric updated this revision to Diff 51440. ioeric added a comment. - changed c_str() to str() http://reviews.llvm.org/D18399 Files: include/clang/Format/Format.h lib/Format/Format.cpp unittests/Format/FormatTest.cpp Index: unittests/Format/FormatTest.cpp

Re: [PATCH] D18385: [CUDA] Simplify SemaCUDA/function-overload.cu test.

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. Small nit, LGTM otherwise. Comment at: test/SemaCUDA/function-overload.cu:66 @@ +65,3 @@ +__device__ int d() { return 8; } +// expected-note@-1 0+ {{'d' declared here}} +//

Re: [PATCH] D18401: clang-cl: Include /FI headers in /showIncludes output.

thakis added a comment. On second thought, and after looking at -E output with -include and gch files, and at CC_PRINT_HEADERS behavior (it prints but doesn't indent), I think I like the alternative implementation I'm mentioning better. Let me make that change.

Re: [PATCH] D18399: Added support for different VFSs in format::getStyle.

klimek added inline comments. Comment at: lib/Format/Format.cpp:2148 @@ -2140,3 +2147,3 @@ // the file or not. -llvm::sys::fs::is_regular_file(Twine(ConfigFile), IsFile); - +Status = FS->status(ConfigFile.c_str()); +bool IsFile = Prefer .str to

Re: [PATCH] D18243: [ASTMatchers] Existing matcher hasAnyArgument fixed

baloghadamsoftware updated this revision to Diff 51437. baloghadamsoftware added a comment. Release notes fixed. http://reviews.llvm.org/D18243 Files: docs/LibASTMatchersReference.html docs/ReleaseNotes.rst include/clang/ASTMatchers/ASTMatchers.h

AUTO: Jacob Hansen is out of the office (returning 05/04/2016)

I am out of the office until 05/04/2016. Note: This is an automated response to your message "cfe-commits Digest, Vol 105, Issue 505" sent on 3/23/2016 4:59:28 PM. This is the only notification you will receive while this person is away. This message and any attachments are intended for

Re: [PATCH] D18264: [clang-tidy] misc-assign-operator-signature checker checks return value of all assign operators

baloghadamsoftware updated this revision to Diff 51435. baloghadamsoftware added a comment. Check for non copy and move assign operators made optional. http://reviews.llvm.org/D18264 Files: clang-tidy/misc/AssignOperatorSignatureCheck.cpp clang-tidy/misc/AssignOperatorSignatureCheck.h

Re: [PATCH] D18243: [ASTMatchers] Existing matcher hasAnyArgument fixed

alexfh added inline comments. Comment at: docs/ReleaseNotes.rst:123 @@ +122,3 @@ +- hasAnyArgument: Matcher no longer ignores parentheses and implicit casts on + the argument before applying the inner matcher. The fix was done allow for + greater control by the user. In all

Re: [PATCH] D18396: Clang-tidy:modernize-use-override. Fix for __declspec attributes and const=0 without spacse

alexfh added a comment. Thank you for the patch! Looks good in general. A few nits. Comment at: clang-tidy/modernize/UseOverrideCheck.cpp:125 @@ -124,1 +124,3 @@ + if (T.is(tok::kw___attribute) && + !(Sources.isBeforeInTranslationUnit(T.getLocation(),

r264167 - ObjC: Handle boolean fixed type for enum.

Author: mren Date: Wed Mar 23 11:28:28 2016 New Revision: 264167 URL: http://llvm.org/viewvc/llvm-project?rev=264167=rev Log: ObjC: Handle boolean fixed type for enum. Before this commit, we assert failure in ImplicitCastExpr "unheralded conversion to bool". This commit fixes the assertion by

Re: [PATCH] D18395: -Wshadow: don't warn on ctor parameters with the same name as a field name

Ah, now I see your follow-up email. Soryr I missed it... On Wed, Mar 23, 2016 at 9:30 AM, David Blaikie wrote: > Reid sent out a different patch for this warning improvement. Have you > checked that one out? Is it abandoned? > > I'm still a bit concerned about whitelisting

Re: [PATCH] D18395: -Wshadow: don't warn on ctor parameters with the same name as a field name

Reid sent out a different patch for this warning improvement. Have you checked that one out? Is it abandoned? I'm still a bit concerned about whitelisting all these cases & not catching cases where the parameter is then used inside the function in some problematic way (the classic being a

Re: [PATCH] D17852: Added formatAndApplyAllReplacements that works on multiple files in libTooling.

ioeric updated this revision to Diff 51433. ioeric marked 3 inline comments as done. ioeric added a comment. - removed format::getStyle test case from ToolingTests; http://reviews.llvm.org/D17852 Files: include/clang/Basic/SourceManager.h include/clang/Format/Format.h

[PATCH] D18401: clang-cl: Include /FI headers in /showIncludes output.

thakis created this revision. thakis added a reviewer: hans. thakis added a subscriber: cfe-commits. `-H` in gcc mode doesn't print `-include` headers, but they are included in depfiles written by MMD and friends. Since `/showIncludes` is what's used instead of depfiles, printing `/FI` there

Re: [PATCH] D17451: PR26448: [Sema] Fix determined type of ternary operator acting on two xvalue class types

erik.pilkington added a comment. ping! http://reviews.llvm.org/D17451 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D18399: Added support for different VFSs in format::getStyle.

ioeric updated this revision to Diff 51431. ioeric marked 3 inline comments as done. ioeric added a comment. - some more redundancy removed http://reviews.llvm.org/D18399 Files: include/clang/Format/Format.h lib/Format/Format.cpp unittests/Format/FormatTest.cpp Index:

Re: [PATCH] D18363: Fix typo s/initalize/initialize/

This revision was automatically updated to reflect the committed changes. Closed by commit rL264164: [analyzer] Fix typo s/initalize/initialize/ (authored by chh). Changed prior to commit: http://reviews.llvm.org/D18363?vs=51307=51429#toc Repository: rL LLVM http://reviews.llvm.org/D18363

  1   2   >