Re: [PATCH] D18567: Block: Fix a crash when we have type attributes or qualifiers with omitted return type.

manmanren marked 3 inline comments as done. Comment at: lib/Sema/SemaType.cpp:1253-1254 @@ -1252,4 +1253,4 @@ break; } else if (declarator.getContext() == Declarator::LambdaExprContext || isOmittedBlockReturnType(declarator)) { Result =

r265104 - Visual Studio native visualizers for clang::TemplateSpecializationType

Author: mps Date: Thu Mar 31 22:31:43 2016 New Revision: 265104 URL: http://llvm.org/viewvc/llvm-project?rev=265104=rev Log: Visual Studio native visualizers for clang::TemplateSpecializationType Displays a template specialization as, say, A. Does not yet handle

r265103 - [analyzer] Prefer accessor method in extension over category in CallEvent.

Author: dcoughlin Date: Thu Mar 31 22:24:13 2016 New Revision: 265103 URL: http://llvm.org/viewvc/llvm-project?rev=265103=rev Log: [analyzer] Prefer accessor method in extension over category in CallEvent. In ObjCMethodCall:getRuntimeDefinition(), if the method is an accessor in a category, and

Re: [PATCH] D18575: [clang-tidy] New checker to replace deprecated throw() specifications

hintonda added a comment. Addressed comments and believe it's ready for review. http://reviews.llvm.org/D18575 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D18575: [clang-tidy] New checker to replace deprecated throw() specifications

hintonda marked 8 inline comments as done. hintonda added a comment. http://reviews.llvm.org/D18575 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D18575: [clang-tidy] New checker to replace deprecated throw() specifications

hintonda updated this revision to Diff 52322. hintonda added a comment. Address comments and refactor. http://reviews.llvm.org/D18575 Files: clang-tidy/modernize/CMakeLists.txt clang-tidy/modernize/ModernizeTidyModule.cpp clang-tidy/modernize/UseNoexceptCheck.cpp

Re: [PATCH] D18635: Rework interface for bitset-using features to use a notion of class scope.

pcc added inline comments. Comment at: docs/ClassScope.rst:2 @@ +1,3 @@ +=== +Class Scope +=== rsmith wrote: > pcc wrote: > > rsmith wrote: > > > pcc wrote: > > > > rsmith wrote: > > > > > Can you use some word other than "scope" here? "Class

Re: [PATCH] D18672: [NVPTX] Read __CUDA_FTZ from module flags in NVVMReflect.

This revision was automatically updated to reflect the committed changes. Closed by commit rL265090: [NVPTX] Read __CUDA_FTZ from module flags in NVVMReflect. (authored by jlebar). Changed prior to commit: http://reviews.llvm.org/D18672?vs=52274=52320#toc Repository: rL LLVM

Re: [PATCH] D18567: Block: Fix a crash when we have type attributes or qualifiers with omitted return type.

rsmith added inline comments. Comment at: lib/Sema/SemaType.cpp:1253-1254 @@ -1252,4 +1253,4 @@ break; } else if (declarator.getContext() == Declarator::LambdaExprContext || isOmittedBlockReturnType(declarator)) { Result = Context.DependentTy;

Re: [PATCH] D18635: Rework interface for bitset-using features to use a notion of class scope.

rsmith added inline comments. Comment at: docs/ClassScope.rst:2 @@ +1,3 @@ +=== +Class Scope +=== pcc wrote: > rsmith wrote: > > pcc wrote: > > > rsmith wrote: > > > > Can you use some word other than "scope" here? "Class scope" is already > > >

Re: [PATCH] D18565: Implement an "I'm dtrace, please retain all debug types" option.

On Wed, Mar 30, 2016 at 10:49 AM, Adrian Prantl wrote: > > On Mar 29, 2016, at 10:06 PM, David Blaikie wrote: > > > > On Tue, Mar 29, 2016 at 12:03 PM, Adrian Prantl via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> >> > On Mar 29, 2016, at 12:00

r265083 - [CUDA] Fix typo in __clang_cuda_runtime_wrapper.h.

Author: jlebar Date: Thu Mar 31 19:25:42 2016 New Revision: 265083 URL: http://llvm.org/viewvc/llvm-project?rev=265083=rev Log: [CUDA] Fix typo in __clang_cuda_runtime_wrapper.h. We're #including the wrong file! Modified: cfe/trunk/lib/Headers/__clang_cuda_runtime_wrapper.h Modified:

Re: [PATCH] D18635: Rework interface for bitset-using features to use a notion of class scope.

pcc added inline comments. Comment at: docs/ClassScope.rst:2 @@ +1,3 @@ +=== +Class Scope +=== rsmith wrote: > pcc wrote: > > rsmith wrote: > > > Can you use some word other than "scope" here? "Class scope" is already a > > > term of art in C++,

r265078 - Adapt to LLVM API change in r265077.

Author: adrian Date: Thu Mar 31 18:57:45 2016 New Revision: 265078 URL: http://llvm.org/viewvc/llvm-project?rev=265078=rev Log: Adapt to LLVM API change in r265077. EmissionKind moved from DIBuilder to DICompileUnit. Modified: cfe/trunk/lib/CodeGen/CGDebugInfo.cpp

Re: [PATCH] D18635: Rework interface for bitset-using features to use a notion of class scope.

rsmith added inline comments. Comment at: docs/ClassScope.rst:2 @@ +1,3 @@ +=== +Class Scope +=== pcc wrote: > rsmith wrote: > > Can you use some word other than "scope" here? "Class scope" is already a > > term of art in C++, meaning something

Re: [PATCH] D18671: [CUDA] Add --cuda-flush-denormals-to-zero.

jlebar added a comment. Thank you for explaining that, Reid! http://reviews.llvm.org/D18671 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D18671: [CUDA] Add --cuda-flush-denormals-to-zero.

jlebar added inline comments. Comment at: lib/Frontend/CompilerInvocation.cpp:1567 @@ +1566,3 @@ + if (Opts.CUDAIsDevice && Args.hasArg(OPT_fcuda_flush_denormals_to_zero)) +Opts.CUDADeviceFlushDenormalsToZero = 1; + Aha, I knew there had to be a better way

Re: [PATCH] D18671: [CUDA] Add --cuda-flush-denormals-to-zero.

jlebar updated this revision to Diff 52310. jlebar marked an inline comment as done. jlebar added a comment. Update flags so we only pass -fcuda-flush-denormals-to-zero to cc1 if appropriate. http://reviews.llvm.org/D18671 Files: include/clang/Basic/LangOptions.def

Re: [PATCH] D18635: Rework interface for bitset-using features to use a notion of class scope.

pcc added inline comments. Comment at: docs/ControlFlowIntegrity.rst:271 @@ +270,3 @@ +linkage-unit scope. With this flag enabled, the compiler will emit cross-DSO +CFI checks for all classes, except for those which appear in the CFI blacklist +or which use a ``no_sanitize``

Re: [PATCH] D18635: Rework interface for bitset-using features to use a notion of class scope.

pcc added inline comments. Comment at: docs/ClassScope.rst:2 @@ +1,3 @@ +=== +Class Scope +=== rsmith wrote: > Can you use some word other than "scope" here? "Class scope" is already a > term of art in C++, meaning something completely different.

Re: [PATCH] D18567: Block: Fix a crash when we have type attributes or qualifiers with omitted return type.

manmanren added a comment. Thanks for reviewing! I will update the patch addressing the comments soon! Manman Comment at: lib/Sema/SemaType.cpp:1569 @@ +1568,3 @@ +// Mark them as invalid. +attr.setInvalid(); + } rsmith wrote: > rjmccall

[clang-tools-extra] r265072 - Update release notes with list of checks added since 3.8.

Author: eugenezelenko Date: Thu Mar 31 18:09:42 2016 New Revision: 265072 URL: http://llvm.org/viewvc/llvm-project?rev=265072=rev Log: Update release notes with list of checks added since 3.8. Fix some checks documentation style. Differential revision: http://reviews.llvm.org/D18582 Modified:

Re: [PATCH] D18509: clang-tidy: add_new_check.py stubs out release notes

alexfh added a comment. In http://reviews.llvm.org/D18509#388071, @hintonda wrote: > With this change, won't you need to update 2 different repos: clang and > extra? Is it possible to update both with a single Phabricator patch? Clang-tidy release notes are now in the clang-tools-extra

Re: [PATCH] D18509: clang-tidy: add_new_check.py stubs out release notes

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko added a comment. Please use single ` around check name and also add link. See http://reviews.llvm.org/D18582 as example. http://reviews.llvm.org/D18509 ___ cfe-commits mailing list

Re: [PATCH] D18582: [Clang-tidy] Update release notes with list of checks added since 3.8

alexfh added a comment. Good to submit now. Thank you for working on this! Repository: rL LLVM http://reviews.llvm.org/D18582 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D18582: [Clang-tidy] Update release notes with list of checks added since 3.8

Eugene.Zelenko added a comment. I fixed indentation. Should I commit changes? Repository: rL LLVM http://reviews.llvm.org/D18582 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D18582: [Clang-tidy] Update release notes with list of checks added since 3.8

alexfh added a comment. In http://reviews.llvm.org/D18582#388931, @Eugene.Zelenko wrote: > I align them as in 3.8 changes, to first `. If you think that alignment > should be other way, I'll change it. This observation doesn't capture the intent correctly. They are aligned with the first

Re: [PATCH] D18582: [Clang-tidy] Update release notes with list of checks added since 3.8

Eugene.Zelenko updated this revision to Diff 52306. Eugene.Zelenko added a comment. Updated to trunk. Changed per Alexander comments. Repository: rL LLVM http://reviews.llvm.org/D18582 Files: docs/ReleaseNotes.rst docs/clang-tidy/checks/misc-dangling-handle.rst

Re: [PATCH] D18396: Clang-tidy:modernize-use-override. Fix for __declspec attributes and const=0 without spacse

alexfh added a comment. In http://reviews.llvm.org/D18396#388287, @Rob wrote: > I tried > > check_clang_tidy.py modernize-use-override-ms.cpp modernize-use-override > temp -- -- -fms-extensions It also needs -std=c++11, since you specify options manually and "opt out" of the defaults

Re: [PATCH] D18396: Clang-tidy:modernize-use-override. Fix for __declspec attributes and const=0 without spacse

alexfh added a comment. In http://reviews.llvm.org/D18396#388287, @Rob wrote: > I tried > > check_clang_tidy.py modernize-use-override-ms.cpp modernize-use-override > temp -- -- -fms-extensions It also needs -std=c++11, which needs to be specified, when you specify any options manually. >

Re: [PATCH] D18582: [Clang-tidy] Update release notes with list of checks added since 3.8

Eugene.Zelenko added a comment. I align them as in 3.8 changes, to first `. If you think that alignment should be other way, I'll change it. Repository: rL LLVM http://reviews.llvm.org/D18582 ___ cfe-commits mailing list

Re: [PATCH] D18582: [Clang-tidy] Update release notes with list of checks added since 3.8

alexfh added a comment. One more nit. Comment at: docs/clang-tidy/checks/performance-implicit-cast-in-loop.rst:4 @@ -3,3 +3,3 @@ -This warning appears in range-based loop with loop variable of const ref type +This warning appears in range-based loop with a loop variable of

Re: [PATCH] D18671: [CUDA] Add --cuda-flush-denormals-to-zero.

rnk requested changes to this revision. This revision now requires changes to proceed. Comment at: include/clang/Driver/Options.td:385 @@ -384,1 +384,3 @@ HelpText<"CUDA installation path">; +def fcuda_flush_denormals_to_zero : Flag<["-"], "fcuda-flush-denormals-to-zero">, +

Re: [PATCH] D18582: [Clang-tidy] Update release notes with list of checks added since 3.8

alexfh added inline comments. Comment at: docs/ReleaseNotes.rst:67 @@ -67,1 +66,3 @@ +- New `cert-env33-c + `_ check Should these lines be indented to `New ...` (i.e. with just two spaces)?

Re: [PATCH] D18671: [CUDA] Add --cuda-flush-denormals-to-zero.

jlebar updated this revision to Diff 52302. jlebar marked an inline comment as done. jlebar added a comment. Add -fno variant. http://reviews.llvm.org/D18671 Files: include/clang/Basic/LangOptions.def include/clang/Driver/Options.td lib/CodeGen/CGCall.cpp lib/CodeGen/CodeGenModule.cpp

Re: [PATCH] D18671: [CUDA] Add --cuda-flush-denormals-to-zero.

jlebar marked an inline comment as done. Comment at: include/clang/Driver/Options.td:385 @@ -384,1 +384,3 @@ HelpText<"CUDA installation path">; +def fcuda_flush_denormals_to_zero : Flag<["-"], "fcuda-flush-denormals-to-zero">, + Group, Flags<[CC1Option]>,

Re: [PATCH] D17926: [clang-tidy] Don't delete unused parameter in class override method in anonymous namespace.

alexfh added inline comments. Comment at: clang-tidy/misc/UnusedParametersCheck.cpp:80 @@ -78,2 +79,3 @@ !Result.SourceManager->isInMainFile(Function->getLocation()) || - UsedByRef()) { + !ast_matchers::match(DeclRefExpr, *Result.Context).empty()|| +

Re: [PATCH] D17926: [clang-tidy] Don't delete unused parameter in class override method in anonymous namespace.

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG. Thank you! http://reviews.llvm.org/D17926 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D17933: Set MaxAtomicInlineWidth properly for i386, i486, and x86-64 cpus without cmpxchg16b.

rsmith added a subscriber: rsmith. Comment at: lib/Basic/Targets.cpp:4080 @@ -4079,1 +4079,3 @@ +// x86-64 has atomics up to 16 bytes, when the HasCX16 target +// feature is enabled, 64 otherwise. MaxAtomicPromoteWidth = 128; ... where by 64, you

Re: [PATCH] D18582: [Clang-tidy] Update release notes with list of checks added since 3.8

alexfh added inline comments. Comment at: docs/clang-tidy/checks/performance-implicit-cast-in-loop.rst:4 @@ -3,3 +3,3 @@ -This warning appears in range-based loop with loop variable of const ref type +This warning appears in range-based loop with loop a variable of const ref

Re: [PATCH] D18582: [Clang-tidy] Update release notes with list of checks added since 3.8

alexfh added a comment. In http://reviews.llvm.org/D18582#388496, @Eugene.Zelenko wrote: > Updated per Etienne comments. > > Links are still need to be added, but I'm not clear about address. I'd point the links to the live version (e.g.

Re: [PATCH] D17933: Set MaxAtomicInlineWidth properly for i386, i486, and x86-64 cpus without cmpxchg16b.

jyknight added a comment. Ping. http://reviews.llvm.org/D17933 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D18671: [CUDA] Add --cuda-flush-denormals-to-zero.

rnk added inline comments. Comment at: include/clang/Driver/Options.td:385 @@ -384,1 +384,3 @@ HelpText<"CUDA installation path">; +def fcuda_flush_denormals_to_zero : Flag<["-"], "fcuda-flush-denormals-to-zero">, + Group, Flags<[CC1Option]>, rnk wrote: >

Re: [PATCH] D18671: [CUDA] Add --cuda-flush-denormals-to-zero.

rnk accepted this revision. This revision is now accepted and ready to land. Comment at: include/clang/Driver/Options.td:385 @@ -384,1 +384,3 @@ HelpText<"CUDA installation path">; +def fcuda_flush_denormals_to_zero : Flag<["-"], "fcuda-flush-denormals-to-zero">, + Group,

Re: [PATCH] D18671: [CUDA] Add --cuda-flush-denormals-to-zero.

jlebar updated this revision to Diff 52292. jlebar added a comment. Address tra's review comments. I also decided no longer to turn this on when -menable-unsafe-fp-math is on: That's a cc1 flag that's implied by various clang flags, but now ftz is a clang flag, so turning it on implicitly didn't

Re: [PATCH] D18671: [CUDA] Add --cuda-flush-denormals-to-zero.

jlebar added a comment. Thank you for the review, Art! Comment at: include/clang/Driver/Options.td:385 @@ -384,1 +384,3 @@ HelpText<"CUDA installation path">; +def cuda_flush_denormals_to_zero : Flag<["--"], "cuda-flush-denormals-to-zero">, + HelpText<"Flush denormal

Re: [PATCH] D18672: [NVPTX] Read __CUDA_FTZ from module flags in NVVMReflect.

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. LGTM. http://reviews.llvm.org/D18672 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D18671: [CUDA] Add --cuda-flush-denormals-to-zero.

tra added inline comments. Comment at: include/clang/Driver/Options.td:385 @@ -384,1 +384,3 @@ HelpText<"CUDA installation path">; +def cuda_flush_denormals_to_zero : Flag<["--"], "cuda-flush-denormals-to-zero">, + HelpText<"Flush denormal floating point values to zero in

r265042 - [index] Fix regression where ObjC method declarations may mistakenly get indexed as definition.

Author: akirtzidis Date: Thu Mar 31 15:18:22 2016 New Revision: 265042 URL: http://llvm.org/viewvc/llvm-project?rev=265042=rev Log: [index] Fix regression where ObjC method declarations may mistakenly get indexed as definition. rdar://25372906 Modified:

[PATCH] D18672: [NVPTX] Read __CUDA_FTZ from module flags in NVVMReflect.

jlebar created this revision. jlebar added reviewers: tra, rnk. jlebar added a subscriber: cfe-commits. Herald added a subscriber: jholewinski. Previously the NVVMReflect pass would read its configuration from command-line flags or a static configuration given to the pass at instantiation time.

[PATCH] D18671: [CUDA] Add --cuda-flush-denormals-to-zero.

jlebar created this revision. jlebar added reviewers: tra, rnk. jlebar added a subscriber: cfe-commits. Setting this flag causes all functions are annotated with the "nvvm-f32ftz" = "true" attribute. In addition, we annotate the module with "nvvm-reflect-ftz" set to 0 or 1, depending on whether

Re: [PATCH] D18635: Rework interface for bitset-using features to use a notion of class scope.

rsmith added inline comments. Comment at: docs/ClassScope.rst:2 @@ +1,3 @@ +=== +Class Scope +=== Can you use some word other than "scope" here? "Class scope" is already a term of art in C++, meaning something completely different. I think what

Re: [PATCH] D18635: Rework interface for bitset-using features to use a notion of class scope.

eugenis added inline comments. Comment at: docs/ClassScope.rst:23 @@ +22,3 @@ + + - ``-fdefault-class-scope=attrs`` indicates that the compiler will infer + class scope based on platform-specific attributes that control the class's Maybe call it "default"?

r265038 - Diagnostics: remove dodgy handler for bitcode inlineasm diagnostics.

Author: tnorthover Date: Thu Mar 31 14:19:24 2016 New Revision: 265038 URL: http://llvm.org/viewvc/llvm-project?rev=265038=rev Log: Diagnostics: remove dodgy handler for bitcode inlineasm diagnostics. Whatever crash it was there to present appears to have been fixed in the backend now, and it

Re: [PATCH] D18582: [Clang-tidy] Update release notes with list of checks added since 3.8

Eugene.Zelenko updated this revision to Diff 52253. Eugene.Zelenko added a comment. Updated per Etienne comments. Links are still need to be added, but I'm not clear about address. Repository: rL LLVM http://reviews.llvm.org/D18582 Files: docs/ReleaseNotes.rst

Re: [PATCH] D18654: In C++11 it is undefined to shift into the sign bit

filcab abandoned this revision. filcab added a comment. Thanks for clarifying, Richard. I'll think about getting some fixes/tests in for our DRs. http://reviews.llvm.org/D18654 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D18636: [PGO] Avoid instrumenting constants at value sites

betulb added a comment. Committed as r265037. Repository: rL LLVM http://reviews.llvm.org/D18636 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D18652: [Inline asm] Correctly parse GCC-style asm line following MS-style asm line

rsmith added a subscriber: rsmith. Comment at: lib/Parse/ParseStmtAsm.cpp:423 @@ -421,3 +422,3 @@ bool isAsm = Tok.is(tok::kw_asm); -if (SingleLineMode && !isAsm) +if (SingleLineMode && (!isAsm || NextToken().is(tok::l_paren))) break;

r265037 - [PGO] Avoid instrumenting constants at value sites

Author: betulb Date: Thu Mar 31 13:41:34 2016 New Revision: 265037 URL: http://llvm.org/viewvc/llvm-project?rev=265037=rev Log: [PGO] Avoid instrumenting constants at value sites Value profiling should not profile constants and/or constant expressions when they appear as callees in call

Re: [PATCH] D18582: [Clang-tidy] Update release notes with list of checks added since 3.8

etienneb accepted this revision. etienneb added a comment. thanks for taking care of this. Comment at: docs/ReleaseNotes.rst:131 @@ +130,3 @@ + Finds unnecessary string initializations. + +Fixed bugs: I just landed this one: http://reviews.llvm.org/D18457

Re: [PATCH] D18654: In C++11 it is undefined to shift into the sign bit

rsmith added a comment. In http://reviews.llvm.org/D18654#388419, @filcab wrote: > That means that our C++11 mode will have some fixes, right? Right. The standard's rules are often incoherent or unimplementable without the fixes in DRs, so it's not meaningful to implement ISO C++ as

Re: [PATCH] D18636: [PGO] Avoid instrumenting constants at value sites

betulb removed rL LLVM as the repository for this revision. betulb updated this revision to Diff 52249. betulb added a comment. Addressed review comments. http://reviews.llvm.org/D18636 Files: lib/CodeGen/CodeGenPGO.cpp test/Profile/c-avoid-direct-call.c Index:

Re: [PATCH] D18479: [CodeGenCXX] Fix ItaniumCXXABI::getAlignmentOfExnObject to return 8-byte alignment on Darwin

ahatanak added inline comments. Comment at: cfe/trunk/include/clang/Basic/TargetInfo.h:426 @@ +425,3 @@ +/// we assume that alignment here. (It's generally 16 bytes, but +/// some targets overwrite it.) +return getDefaultAlignForAttributeAligned();

[clang-tools-extra] r265033 - [clang-tidy] Add a new checker to detect missing comma in initializer list.

Author: etienneb Date: Thu Mar 31 13:12:23 2016 New Revision: 265033 URL: http://llvm.org/viewvc/llvm-project?rev=265033=rev Log: [clang-tidy] Add a new checker to detect missing comma in initializer list. Summary: This checker is able to detect missing comma in an array of string literals.

Re: [PATCH] D18654: In C++11 it is undefined to shift into the sign bit

That means that our C++11 mode will have some fixes, right? How can we call what out C++11 mode is? Are there updated versions of the standard? Are there lists of defects that we have fixed and others we haven't? Sorry, I'm not too familiar with how the standard+fixes usually work. Thank you,

Re: [PATCH] D18654: In C++11 it is undefined to shift into the sign bit

filcab added a subscriber: filcab. filcab added a comment. That means that our C++11 mode will have some fixes, right? How can we call what out C++11 mode is? Are there updated versions of the standard? Are there lists of defects that we have fixed and others we haven't? Sorry, I'm not too

Re: [PATCH] D18653: [Sema] Diagnose template alias declaration in local class

rsmith accepted this revision. This revision is now accepted and ready to land. Comment at: test/CXX/temp/temp.decls/temp.mem/p2.cpp:11 @@ -10,2 +10,3 @@ template void qux(); // expected-error{{templates cannot be declared inside of a local class}} +template using

Re: [PATCH] D18654: In C++11 it is undefined to shift into the sign bit

rsmith requested changes to this revision. rsmith added a comment. This revision now requires changes to proceed. Core issue 1457 is a DR against C++11, so it applies to our C++11 mode. http://reviews.llvm.org/D18654 ___ cfe-commits mailing list

Re: [PATCH] D18584: Complete support for C++ Core Guidelines Type.6: Always initialize a member variable.

michael_miller updated this revision to Diff 52238. michael_miller added a comment. Ran clang-format on all modified source files. http://reviews.llvm.org/D18584 Files: clang-tidy/cppcoreguidelines/ProTypeMemberInitCheck.cpp clang-tidy/cppcoreguidelines/ProTypeMemberInitCheck.h

[PATCH] D18657: Propagate missing empty exception spec from function declared in system header

d.zobnin.bugzilla created this revision. d.zobnin.bugzilla added reviewers: doug.gregor, rjmccall. d.zobnin.bugzilla added a subscriber: cfe-commits. If new function is missing empty exception specification "throw()" and "throw()" came from system header, don't emit errors. It is already

Re: [PATCH] D18369: [OpenCL] Upstreaming khronos OpenCL 1.2/2.0 header files.

yaxunl added a comment. > Rather than having a separate header for each version with another header for > the common parts, couldn't we just have a single header that uses #if guards > for the version specific functionality? e.g. > > size_t __attribute__((overloadable)) get_global_id(uint

[PATCH] D18654: In C++11 it is undefined to shift into the sign bit

filcab created this revision. filcab added reviewers: rsmith, samsonov. filcab added a subscriber: cfe-commits. Clang was using C++14 rules for shifts into the sign bit with any C++ standard. Now it has the C++ <14 special case (same as C). Using this C++11 standard draft as reference (before

Re: [PATCH] D18649: [clang-tidy] cppcoreguidelines-interfaces-global-init

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko added a comment. Please mention new check in docs/ReleaseNotes.rst. http://reviews.llvm.org/D18649 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D18567: Block: Fix a crash when we have type attributes or qualifiers with omitted return type.

rjmccall added inline comments. Comment at: lib/Sema/SemaType.cpp:1569 @@ +1568,3 @@ +// Mark them as invalid. +attr.setInvalid(); + } manmanren wrote: > rjmccall wrote: > > It's not generally a good idea to set things as invalid if you're

Re: [PATCH] D18596: [MSVC] PR27132: Proper mangling for __unaligned qualifier

aaron.ballman added a comment. In http://reviews.llvm.org/D18596#388148, @andreybokhanko wrote: > Aaron, Reid, David, thank you for the review! > > I resolved some of your comments. As for > > In http://reviews.llvm.org/D18596#386841, @aaron.ballman wrote: > > > I'd like to see some Sema tests

Re: [PATCH] D18457: [clang-tidy] Add a new checker to detect missing comma in initializer list.

etienneb added a comment. ready to land. Comment at: clang-tidy/misc/SuspiciousMissingCommaCheck.cpp:75 @@ +74,3 @@ + diag(ConcatenatedLiteral->getLocStart(), + "suspicious string literal, probably missing a comma"); +} alexfh wrote: > xazax.hun wrote: >

Re: [PATCH] D18396: Clang-tidy:modernize-use-override. Fix for __declspec attributes and const=0 without spacse

Rob updated this revision to Diff 52227. Rob added a comment. I tried check_clang_tidy.py modernize-use-override-ms.cpp modernize-use-override temp -- -- -fms-extensions and check_clang_tidy.py modernize-use-override-ms.cpp modernize-use-override temp on OSX and nethier work as

Re: [PATCH] D18651: [X86] Introduction of -march=lakemont

aturetsk added a comment. I used existing test "test/CodeGen/attr-target-x86.c" to check Lakemont's target features. However the test is actually run with 64-bit triple "x86_64-linux-gnu", so "+mmx,+sse,+sse2" are included in target features. The same thing happens with Pentium and other

Re: [PATCH] D18457: [clang-tidy] Add a new checker to detect missing comma in initializer list.

etienneb updated this revision to Diff 52226. etienneb added a comment. nits http://reviews.llvm.org/D18457 Files: clang-tidy/misc/CMakeLists.txt clang-tidy/misc/MiscTidyModule.cpp clang-tidy/misc/SuspiciousMissingCommaCheck.cpp clang-tidy/misc/SuspiciousMissingCommaCheck.h

Re: [PATCH] D18457: [clang-tidy] Add a new checker to detect missing comma in initializer list.

etienneb updated this revision to Diff 52225. etienneb marked 5 inline comments as done. etienneb added a comment. address alexfh@ comments. http://reviews.llvm.org/D18457 Files: clang-tidy/misc/CMakeLists.txt clang-tidy/misc/MiscTidyModule.cpp

[PATCH] D18652: [Inline asm] Correctly parse GCC-style asm line following MS-style asm line

d.zobnin.bugzilla created this revision. d.zobnin.bugzilla added a reviewer: echristo. d.zobnin.bugzilla added a subscriber: cfe-commits. Clang fails to compile the following code: void f() { __asm mov ebx, ecx __asm__("movl %ecx, %edx"); } reporting unexpected token "__asm__" at start of

Re: [PATCH] D18542: [OPENMP] Parsing and Sema support for 'omp declare target' directive

aaron.ballman added a comment. In http://reviews.llvm.org/D18542#387934, @DmitryPolukhin wrote: > Could you please take a look to OMPDeclareTargetDecl attribute implementation > and printPrettyEnd approach in general? > For post print mechanism alternative approach is to use ad hoc solution in

[PATCH] D18651: [X86] Introduction of -march=lakemont

aturetsk created this revision. aturetsk added reviewers: rsmith, echristo. aturetsk added subscribers: cfe-commits, zinovy.nis. Add a new CPU - Lakemont. http://reviews.llvm.org/D18651 Files: lib/Basic/Targets.cpp test/CodeGen/attr-target-x86.c test/Preprocessor/predefined-arch-macros.c

Re: [PATCH] D18369: [OpenCL] Upstreaming khronos OpenCL 1.2/2.0 header files.

jprice added a subscriber: jprice. jprice added a comment. In http://reviews.llvm.org/D18369#387560, @yaxunl wrote: > In http://reviews.llvm.org/D18369#385799, @Anastasia wrote: > > > Is there any chance we could factor out the common bits into separate files > > to avoid large code repetition?

Re: r264428 - [ASTMatchers] Fix build for VariadicFunction.

On Thu, Mar 31, 2016 at 11:16 AM, David Blaikie wrote: > Yep, reproduces even with a plain (non template arg) function pointer - > and immediately goes away with a real function of the same type. > Thanks for the extra reduction. > That's bothersome. I played around with a

Re: [PATCH] D18442: A clang-tidy check for std:accumulate.

courbet added a comment. ping ? http://reviews.llvm.org/D18442 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D18649: [clang-tidy] cppcoreguidelines-interfaces-global-init

courbet created this revision. courbet added a reviewer: alexfh. courbet added a subscriber: cfe-commits. This check flags initializers of globals that access extern objects, and therefore can lead to order-of-initialization problems (this recommandation is part of CPP core guidelines). Note

[PATCH] D18648: make __builtin_isfinite more efficient (PR27145)

spatel created this revision. spatel added reviewers: hfinkel, scanon, chandlerc. spatel added a subscriber: cfe-commits. Herald added a subscriber: mcrosier. isinf (infinite) and isfinite should be implemented with the same function except we change the comparison operator. See PR27145 for more

Re: r264428 - [ASTMatchers] Fix build for VariadicFunction.

Yep, reproduces even with a plain (non template arg) function pointer - and immediately goes away with a real function of the same type. That's bothersome. I played around with a few ways of writing the call-to-function-pointer but couldn't find any particular syntax that seemed to untickle GCC's

Re: [PATCH] D18596: [MSVC] PR27132: Proper mangling for __unaligned qualifier

andreybokhanko updated this revision to Diff 52208. andreybokhanko added a comment. Resolved [some of] comments made by Aaron and Reid. http://reviews.llvm.org/D18596 Files: include/clang/AST/Type.h include/clang/Basic/Attr.td include/clang/Basic/AttrDocs.td lib/AST/MicrosoftMangle.cpp

Re: r264428 - [ASTMatchers] Fix build for VariadicFunction.

I was able to reduce the bug to this: struct A { A(int (&)[1]); }; template int E() { int X[] = {0}; return F(X); } Note that the array is not empty and we are not using variadics anymore. The problem seems to be related to the function pointer template parameter. gcc doesn't want

Re: [PATCH] D18551: Added Fixer implementation and fix() interface in clang-format for removing redundant code.

ioeric updated this revision to Diff 52199. ioeric added a comment. - Added fixReplacements() that fix and reformat replacements. http://reviews.llvm.org/D18551 Files: include/clang/Format/Format.h lib/Format/Format.cpp lib/Format/FormatToken.h unittests/Format/FormatTest.cpp Index:

Re: [PATCH] D18408: readability check for const params in declarations

I tried manually specifying --create. The problem was that my commit message had stuff from an early arc diff still in it which arc was picking up and getting confused by. Matt On Thu, Mar 31, 2016 at 8:29 AM, Alexander Kornienko wrote: > On Wed, Mar 30, 2016 at 4:01 PM,

Re: [PATCH] D18509: clang-tidy: add_new_check.py stubs out release notes

hintonda added a subscriber: hintonda. hintonda added a comment. With this change, won't you need to update 2 different repos: clang and extra? Is it possible to update both with a single Phabricator patch? http://reviews.llvm.org/D18509 ___

Re: [PATCH] D18319: Add a PragmaHandler Registry for plugins to add PragmaHandlers to

john.brawn added a comment. In http://reviews.llvm.org/D18319#379337, @rnk wrote: > This seems reasonable. OK to commit then? Repository: rL LLVM http://reviews.llvm.org/D18319 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D18408: readability check for const params in declarations

On Wed, Mar 30, 2016 at 4:01 PM, Matthew Fowles Kulukundis < matt.fow...@gmail.com> wrote: > My attempts to do this end with: > > $ arc diff > I normally use `arc diff --create` or `arc diff --update D`, and this works. > Linting... > No lint engine configured for this project. > Running

Re: [PATCH] D18509: clang-tidy: add_new_check.py stubs out release notes

alexfh added a comment. I like the idea, but we could make this a bit more reliable, see the inline comment. Comment at: clang-tidy/add_new_check.py:280 @@ +279,3 @@ + if not clang_tidy_found: +if line.startswith("Improvements to ``clang-tidy``"): +

Re: [PATCH] D18584: Complete support for C++ Core Guidelines Type.6: Always initialize a member variable.

alexfh added a comment. Thank you for the patch! I'd like the original author to take a look at it, so just a couple of peanut gallery comments from me for now. Comment at: clang-tidy/cppcoreguidelines/ProTypeMemberInitCheck.cpp:51 @@ +50,3 @@ +static bool

Re: [PATCH] D18608: note for top-level consts in function decls tidy

alexfh added a comment. Thank you for the patch, btw! Repository: rL LLVM http://reviews.llvm.org/D18608 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D18608: note for top-level consts in function decls tidy

alexfh added inline comments. Comment at: docs/ReleaseNotes.rst:73 @@ +72,3 @@ + + This check warns about top-level const parameters in function delcartions. + Typo: "delcartions". Fixed in a follow up. Repository: rL LLVM http://reviews.llvm.org/D18608

  1   2   >